[Koha-bugs] [Bug 27344] Implement Elastic's update_index_background using Koha::BackgroundJob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27344 --- Comment #24 from Jonathan Druart --- Why isn't this moving forward? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15121] runreport.pl cronjob ought to let you specify multiple email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15121 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #834 from Aleisha Amohia --- Created attachment 130656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130656=edit Bug 19532: (follow-up) Fixes along recall workflow -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129319|0 |1 is obsolete|| --- Comment #833 from Aleisha Amohia --- Created attachment 130655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130655=edit Bug 19532: (QA follow-up) Enable XSLT statuses translation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129318|0 |1 is obsolete|| --- Comment #832 from Aleisha Amohia --- Created attachment 130654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130654=edit Bug 19532: (follow-up) Fix calls, tests, syspref settings, checks Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129317|0 |1 is obsolete|| --- Comment #831 from Aleisha Amohia --- Created attachment 130653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130653=edit Bug 19532: (follow-up) Fixing tests and QA tools And making reverted ajax message clearer Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129316|0 |1 is obsolete|| --- Comment #830 from Aleisha Amohia --- Created attachment 130652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130652=edit Bug 19532: (follow-up) Fix undef recall_id preventing fulfillment of recall Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129315|0 |1 is obsolete|| --- Comment #829 from Aleisha Amohia --- Created attachment 130651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130651=edit Bug 19532: (follow-up) Fixing OPAC display and staff client errors - fixes the displays of opac-recalls.pl and opac-recall.pl - fix the error on Recalls to pull page - fix JS error preventing Recalled link from showing in checkouts table - fix cancelling of recall when checking out item Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129314|0 |1 is obsolete|| --- Comment #828 from Aleisha Amohia --- Created attachment 130650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130650=edit Bug 19532: (follow-up) Fixing failing CalcFine.t test Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129313|0 |1 is obsolete|| --- Comment #827 from Aleisha Amohia --- Created attachment 130649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130649=edit Bug 19532: (follow-up) aria-hidden attr on OPAC, and more - removing authnotrequired flag from scripts - fixing opac buttons - chmod +x for recalls test files Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129312|0 |1 is obsolete|| --- Comment #826 from Aleisha Amohia --- Created attachment 130648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130648=edit Bug 19532: Recalls on intranet See recalls on Intranet - old recalls (all inactive recalls) - recalls queue (all active recalls) - cancel, expire, revert waiting status, multiple cancel, mark overdue - recalls to pull (available but not yet waiting) - cancel - recalls awaiting pickup (awaiting pickup, awaiting pickup more than RecallMaxPickUpDelay days) - expire, revert waiting status - overdue recalls (overdue to be returned) - cancel, multiple cancel - biblio recalls tab (all active recalls relevant to this bib) - cancel, expire, revert waiting status, mark overdue - patron recalls tab (all active recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - patron recalls history tab (all recalls relevant to this patron) - cancel, expire, revert waiting status, mark overdue - log viewer and the general circulation of recalls == TEST PLAN FOR RECALLS == ADMINISTRATION 1. Apply all patches 2. Run database updates, update schema files and confirm everything applies cleanly 3. Run tests and confirm everything passes: t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Recalls.t t/db_dependent/Stats.t t/db_dependent/Circulation/CalcFine.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Patron.t t/db_dependent/XSLT.t t/db_dependent/Search.t t/db_dependent/Holds.t t/db_dependent/Circulation/transferbook.t t/db_dependent/Circulation.t 4. Go to Administration -> system preferences. Find the UseRecalls system preference. It should be DISABLED. Confirm RecallsMaxPickUpDelay is set to 7 by default. 5. Go to Administration -> circulation rules. Confirm there are no recalls circulation rules showing. 6. Test a few circulation flows: checking out, placing a reserve, checking in, fulfilling a reserve, etc. Confirm everything works as normal. 7. Go to Administration -> system preferences. Enable the UseRecalls system preference. 8. Go to Administration -> circulation rules. Set the following rules: Recalls allowed (count) = 0 Recalls per record (count) = 0 On shelf recalls allowed ( If any unavailable / If all unavailable ) = If any unavailable Recall due date interval (days) = 3 Recall overdue fine amount = (something different to your normal fine amount) Recall pickup period (days) = 1 Throughout your testing, try with different combinations of these rules and itemtype / branchcode / categorycode. Also try with null values. Keep the circulation rules open in another tab so you can refer to and update these easily. You should also have at least one other tab open for the staff client, and a third tab open for the OPAC, for ease of testing. 9. Go to your account -> More -> Set permissions. Confirm the recalls permission is checked. 10. Set up a test user with OPAC login details (Borrower A). This could also be your own user, as long as you have OPAC login access. 11. Set up a test record (Biblio A) with at least two items (Item A and Item B) of the same item type (or an item type with the same recall circ rules). PLACING A RECALL 12. Log in to the OPAC as Borrower A. Do a catalogue search with a term that will return multiple results, including Biblio A. 13. Click on Biblio A. 14. Notice there is a 'Place recall' button on the sidebar menu. Click this button. There will be a message saying that there are no items to recall - this is because all items are available. 15. Check out Item A to another borrower (Borrower B). 16. Refresh the 'Place recall' page. You will still NOT be able to place a recall - this is because Recalls allowed = 0 and Recalls per record = 0. 17. Edit the circulation rules to have the following values: Recalls allowed (count) = 1 Recalls per record (count) = 1 18. Refresh the 'Place recall' page. You will now see the form to place a recall. BIBLIO-LEVEL RECALL, NO TRANSFER 19. Place a biblio-level recall. Pickup location: Branch A, the set branch when you are logged into the staff client Recall not needed after (expiration date): whatever you want Select 'recall next available item' Click confirm 20. Confirm the recall is placed successfully. Confirm that the new due date displayed is correctly calculated to be today's date, plus 3 days (taken from the 'recall due date interval' circ rule) 21. In the staff client, look at Borrower B's account, and go to their Notices tab. Confirm they have received a 'Notification to return recalled item' notice. 22. Look at Borrower B's checkouts table. Notice the due date for their checkout has been adjusted, and there is now a note
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129311|0 |1 is obsolete|| --- Comment #825 from Aleisha Amohia --- Created attachment 130647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130647=edit Bug 19532: Recalls on OPAC - place a biblio-level or item-level recall via the biblio detail page, OPAC search results, or course reserves - view or cancel your active recalls from 'your summary' recalls tab - view all active and inactive (and cancel active) recalls from 'your recall history' - stopped from placing a reserve on an item that the patron has already recalled Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129310|0 |1 is obsolete|| --- Comment #824 from Aleisha Amohia --- Created attachment 130646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130646=edit Bug 19532: Other objects used in recalls feature - biblio->recalls - biblio->can_be_recalled - item->recall - item->can_be_recalled - item->can_set_waiting_recall - item->check_recalls - patron->recalls - Biblio.RecallsCount and relevant tests - t/db_dependent/Stats.t - t/db_dependent/Koha/Item.t - t/db_dependent/Koha/Biblio.t - t/db_dependent/Koha/Patron.t - t/db_dependent/XSLT.t - t/db_dependent/Search.t - t/db_dependent/Holds.t - t/db_dependent/Circulation/transferbook.t - t/db_dependent/Circulation.t Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129309|0 |1 is obsolete|| --- Comment #823 from Aleisha Amohia --- Created attachment 130645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130645=edit Bug 19532: Expiry and overdue cronjobs, and overdue fine calculation - misc/cronjobs/recalls/expire_recalls.pl - misc/cronjobs/recalls/overdue_recalls.pl - tests for overdue fines in t/db_dependent/Circulation/CalcFine.t Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129308|0 |1 is obsolete|| --- Comment #822 from Aleisha Amohia --- Created attachment 130644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130644=edit Bug 19532: Recalls objects and tests Koha/Recall.pm - biblio - item - patron - library - checkout - requested - waiting - overdue - in_transit - expired - cancelled - finished - calc_expirationdate - start_transfer - revert_transfer - set_waiting - revert_waiting - set_overdue - set_expired - set_cancelled - set_finished - should_be_overdue Koha/Recalls.pm - add_recall - move_recall and relevant tests Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129307|0 |1 is obsolete|| --- Comment #821 from Aleisha Amohia --- Created attachment 130643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130643=edit Bug 19532: Add boolean flags to recalls.old and recalls.item_level_recall Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129306|0 |1 is obsolete|| --- Comment #820 from Aleisha Amohia --- Created attachment 130642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130642=edit Bug 19532: Updated schema files Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Attachment #129305|0 |1 is obsolete|| --- Comment #819 from Aleisha Amohia --- Created attachment 130641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130641=edit Bug 19532: Database and installer stuff - Add recalls table - Add recalls circulation rules - recalls allowed, recalls per record, on shelf recalls, recall due date interval, recall overdue fine, recall shelf time - Add system preferences - useRecalls, RecallsMaxPickUpDelay, RecallsLog - Add email notices (RETURN_RECALLED_ITEM, PICKUP_RECALLED_ITEM) - Add print notice (RECALL_REQUESTER_DET) - Add user permission - recalls, manage_recalls - Add Recall and CancelRecall enum options for branchtransfers reason Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19532] Recalls for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24895] Elasticsearch CCL searching with phr modifier doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24895 Lari Taskula changed: What|Removed |Added CC||lari.task...@hypernova.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29155] Upgrade jquery version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #11 from Lucas Gass --- Created attachment 130640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130640=edit Bug 21225: (follow-up) Make SyndeticCovers work on catalog detail page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25025] Drag-and-drop cover image upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web crawlers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30116] New: When using UseACQFrameworkForBiblioRecords visibility settings have no effect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30116 Bug ID: 30116 Summary: When using UseACQFrameworkForBiblioRecords visibility settings have no effect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When UseACQFrameworkForBiblioRecords is active the form for adding a bibliographic record can be configured via the ACQ framework. But you can't hide/preset fields as removing the editor checkbox has no effect. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30115] Uninitialized value warning in C4/Output.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30115 Blou changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30115] Uninitialized value warning in C4/Output.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30115 --- Comment #1 from Blou --- Created attachment 130639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130639=edit Bug 30115: Uninitialized value warning in C4/Output.pm Use of uninitialized value $url_suffix in concatenation (.) or string at GIT/C4/Output.pm line 180. Use of uninitialized value $url_suffix in concatenation (.) or string at GIT/C4/Output.pm line 197. Use of uninitialized value $url_suffix in concatenation (.) or string at GIT/C4/Output.pm line 211. This is in pagination_bar sub. A lot of pages call it. For me it happened with any Authority search (authorities/authorities-home.pl) producing multiple results. Simple fix is initializing the variable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30115] New: Uninitialized value warning in C4/Output.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30115 Bug ID: 30115 Summary: Uninitialized value warning in C4/Output.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: philippe.blo...@inlibro.com QA Contact: testo...@bugs.koha-community.org Use of uninitialized value $url_suffix in concatenation (.) or string at GIT/C4/Output.pm line 180. Use of uninitialized value $url_suffix in concatenation (.) or string at GIT/C4/Output.pm line 197. Use of uninitialized value $url_suffix in concatenation (.) or string at GIT/C4/Output.pm line 211. This is in pagination_bar sub. A lot of pages call it. For me it happened with any Authority search (authorities/authorities-home.pl) producing multiple results. Simple fix is initializing the variable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 --- Comment #10 from Lucas Gass --- rebased for current master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21225] Add Syndetics enhanced content to staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21225 Lucas Gass changed: What|Removed |Added Attachment #123581|0 |1 is obsolete|| --- Comment #9 from Lucas Gass --- Created attachment 130638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130638=edit Bug 21225: Add Syndetics cover images to staff client. To test: 1 - Enable system preferences: SyndeticsEnabled SyndeticsCoverImages SyndeticsClientCode (you will need a valid code for testing) 2 - Perform a search on the staff client 3 - Check that results have images if upc,oclc number, or isbn existin record 4 - Confirm that dtails paeg displays same image 5 - Confirm size on details page follows syspref SyndeticsCoverImageSize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26975] Reindent authorities editor template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 --- Comment #12 from Owen Leonard --- Created attachment 130637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130637=edit Bug 26795: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=26975 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26975] Reindent authorities editor template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26975 Owen Leonard changed: What|Removed |Added Attachment #129965|0 |1 is obsolete|| Attachment #129966|0 |1 is obsolete|| --- Comment #11 from Owen Leonard --- Created attachment 130636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130636=edit Bug 26975: Reindent authorities editor template This patch performs general template cleanup to the authorities editor: Make indentation consistent, replace tabs with spaces, and trim trailing whitespace. To test, apply the patch and edit or create a new authority record. Test the functionality of the authority editor and confirm that everything works correctly, including JS interactions like subfield reordering, tag and subfield cloning, and tag and subfield deletion. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web crawlers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29965] MARC preview for authority search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Owen Leonard changed: What|Removed |Added Attachment #129983|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 130635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130635=edit Bug 29965: Preview MARC in authority search results This enhancement makes the authority MARC preview modal available for the general authority search results. To test: 1) Do a catalog search and edit a biblio record 2) Go to one of the authority tags (i.e. 1xx, 6xx, 7xx) and open the authority finder plugin 3) Do an authority search 4) Click on one of the search result headings to open the modal. Confirm it opens as expected. 5) Exit the biblio editor and go to Authorities 6) Do an authority search 7) Click on the Actions dropdown, then the MARC preview button, to open the modal. Confirm it opens as expected. Sponsored-by: Education Services Australia SCIS Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29965] MARC preview for authority search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29965 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass changed: What|Removed |Added Attachment #130633|0 |1 is obsolete|| --- Comment #7 from Lucas Gass --- Created attachment 130634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130634=edit Bug 29845: add classes to overdrive results action buttons To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold buttons, none of them contain classes. 4. Apply patch 5. Repeat 3 again but this time they should all contain a class which makes them much easier to style. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29845] Styling OverDrive buttons is difficult
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29845 Lucas Gass changed: What|Removed |Added Attachment #129332|0 |1 is obsolete|| --- Comment #6 from Lucas Gass --- Created attachment 130633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130633=edit Bug 29845: add classes to overdrive results action buttonswq To test: 1. You must have OverDrive credentials populated in the OverDrive system preferences 2. Go to the Overdrive results page and make sure you are logged in. 3. Use your browsers dev tools to look at the check-in, check-out, place hold, cancel hold buttons, none of them contain classes. 4. Apply patch 5. Repeat 3 again but this time they should all contain a class which makes them much easier to style. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25025] Drag-and-drop cover image upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 Owen Leonard changed: What|Removed |Added Attachment #123825|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 130632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130632=edit Bug 25025: Drag-and-drop cover image upload This patch updates the Upload local cover image page so that the user has the option of dragging a file from a folder on their computer instead of using a file upload button. The patch also adds a preview of uploaded single images and display of existing images on the record you're adding to. To test, apply the patch and make sure the LocalCoverImages system preference is enabled. - Go to Tools -> Upload local cover image and test the following processes: - Upload single cover image, specifying a biblionumber - Test dragging an image from a file on your computer - Test clicking the "Drop files here or click..." link. - You should see a preview of the image file on the screen, with information about the file: file name, image type, file size. - Click "Process images" - with "Existing covers will be replaced" checked - with "Existing covers will be replaced" unchecked When the upload process completes you should see information about the title in the page heading and a thumbnail of the cover in the sidebar. - Test that the image can be deleted from this page. You should be redirected back to this page with the same title still selected. - Upload a zip file of images - Test dragging an image from a file on your computer - Test clicking the "Drop files here or click..." link. - A zip file can't be previewed onscreen but you should see the same file information and a Font Awesome "zip file" icon. - Click "Process images" From the bibliographic detail page, click the "Images" tab, and click "Upload." With this workflow the field asking for a biblionumber should not appear. From the bibliographic detail page, in the holdings table, choose Edit -> Upload image. This process should be the same as above but should provide item information on the screen. Confirm that images are uploaded correctly to the specific item. Test with AllowMultipleCovers enabled and disabled to confirm that the "Existing covers will be replaced" checkbox is enabled only when multiple covers are possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25025] Drag-and-drop cover image upload
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25025 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30114] Koha offline circulation will always cancel the next hold when issuing item to a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Kyle M Hall changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30114] Koha offline circulation will always cancel the next hold when issuing item to a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Kyle M Hall changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30114] Koha offline circulation will always cancel the next hold when issuing item to a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 --- Comment #1 from Kyle M Hall --- Created attachment 130631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130631=edit Bug 30114: Koha offline circulation will always cancel the next hold when issuing item to a patron If a record has holds on it, and, using offline circulation, an item on that is checked out to a patron that did not have a hold on the record, the next hold that would have trapped that item will be canceled. 1) Place two bib level holds on an item for two patrons 2) Find a third patron, note his or her cardnumber 3) Create the file test.koc by copying and pasting the following into a text editor Version=1.0 Generator=kocTest GeneratorVersion=0.7 2008-06-11 12:24:11 547 issue PATRONCARDNUMBERITEMBARCODE note the fields are tab delemited, ensure the tabs do not get lost when copying and pasting! 4) Upload the offline circ action, and commit the action 5) Note the item was checked out to the third patron 6) Note one of the other patron's holds were canceled 7) Reset your database 8) Apply this patch 9) Test again, no hold should be canceled! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30114] Koha offline circulation will always cancel the next hold when issuing item to a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #38 from Martin Renvoize --- Created attachment 130630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130630=edit Bug 30055: (follow-up) Clarify 'AND' logic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 --- Comment #37 from Martin Renvoize --- Created attachment 130629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130629=edit Bug 30055: (follow-up) Increase popup window size With the required addition of fields to the displayed result table, we need to increase the size of the popover window to prevent horizontal scrolling. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30114] New: Koha offline circulation will always cancel the next hold when issuing item to a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30114 Bug ID: 30114 Summary: Koha offline circulation will always cancel the next hold when issuing item to a patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If a record has holds on it, and, using offline circulation, an item on that is checked out to a patron that did not have a hold on the record, the next hold that would have trapped that item will be canceled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30093] Rewrite the patron search when placing a hold with the REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 --- Comment #4 from Jonathan Druart --- Created attachment 130628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130628=edit Bug 30093: Make patron search from request.pl use the REST API In this patch we want to reuse what has been done in the previous bug report to search patrons using the REST API route. The code is mainly in members/search.tt, for all the patron searches that "add" or "select" a patron (popup windows). The patron search for holds is a bit different, we don't want to open a popup window. We are moving to code to an include file (patron-search.tt) to make it reusable easily. Note that we are improving how the patron's addresses are displayed, and provide a JS equivalent to the TT includes files. Test plan: Search for patrons from the "Place a hold on" view. You should see the same view as behaviour, with more filters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30093] Rewrite the patron search when placing a hold with the REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart changed: What|Removed |Added Attachment #130605|0 |1 is obsolete|| Attachment #130606|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 130627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130627=edit Bug 30093: Rename patron-search.inc to patron-search-header.inc We will use 'patron-search.inc' in the next patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 Jonathan Druart changed: What|Removed |Added Blocks||30093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 [Bug 30093] Rewrite the patron search when placing a hold with the REST API route -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30093] Rewrite the patron search when placing a hold with the REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30093 Jonathan Druart changed: What|Removed |Added Depends on||30055 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055 [Bug 30055] Rewrite some of the patron searches to make them use the REST API routes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30098] Patron search redirects when one result on any page of results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098 e.betemps changed: What|Removed |Added CC||e.bete...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30098] Patron search redirects when one result on any page of results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30098 Kyle M Hall changed: What|Removed |Added Attachment #130564|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 130626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130626=edit Bug 30098: ONly redirect from patron search if single result is on first page This patch simply adds a check that we are oin the first page (starting at result 0) before redirecting to a isngle patron To test: 1 - Perform a patron search that returns 41 results, on Koha testing docker, 'a' works 2 - Go to second page of results, works 3 - Go to third page of results, redirected to the patron 4 - Apply patch 5 - Repeat search and paging 6 - On third page you remian in results and are not redirected to patron Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22428] MARC modification template cuts text to 100 characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22428 Noémie Labine changed: What|Removed |Added CC||noemie.lab...@collecto.ca --- Comment #1 from Noémie Labine --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30113] New: kohaTable add_filters option should be renamed to show_filter_row
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30113 Bug ID: 30113 Summary: kohaTable add_filters option should be renamed to show_filter_row Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org The 'add_filters' option available to us on the ajax dataTables wrapper, kohaTable, is used to enabled/disable the presence of the search filters row displayed at the top of the datatable. We should rename the option to clarify it's intended use... add_filters is too generic and could mean a number of things. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30072] Add more holds hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30072] Add more holds hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #12 from Kyle M Hall --- Stable patches tested as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30088] Improve forgotten password form to be more obvious that only one field must be filled out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30088 --- Comment #4 from Christopher Brannon --- Thanks for helping me work this out, and listening. Sometimes it isn't easy to put a finger on, and I have to think a little more about what is going on. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30112] Incorrect timestamps on Orders By Fund report (orders_by_fund.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30112 --- Comment #1 from Barbara Johnson --- Created attachment 130625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130625=edit Incorrect timestamps -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30112] New: Incorrect timestamps on Orders By Fund report (orders_by_fund.pl)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30112 Bug ID: 30112 Summary: Incorrect timestamps on Orders By Fund report (orders_by_fund.pl) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.john...@bedfordtx.gov QA Contact: testo...@bugs.koha-community.org The timestamps recorded for Entry Dates and Received Dates on the Orders By Fund report (orders_by_fund.pl) are incorrect. Most of them are shown as 12:00 AM when the library isn't even open. I found a few that showed other times such as 8:59 AM and 9:09 AM. We order and receive items throughout the day so there should be other timestamps included in the report. Unless the timestamps can be accurate then it seems that they should not be displayed at all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30072] Add more holds hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #11 from Kyle M Hall --- Created attachment 130624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130624=edit Bug 30072: (follow-up) Silence useless warning Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30072] Add more holds hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 --- Comment #10 from Kyle M Hall --- Created attachment 130623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130623=edit Bug 30072: Add missing hold actions plugin hooks This patch introduces the after_hold_action plugin hook, with 4 different 'action' parameters: - fill - cancel - suspend - resume To test: 1. Apply the unit tests 2. Run: $ kshell k$ t/db_dependent/Koha/Plugins/Holds_hooks.t -v => FAIL: The hooks are not in the code, so the expected output from the Koha::Plugin::Test plugin is not there, and the tests fail 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Note: I think we could deprecate 'after_hold_create' and migrate it to the one introduced here, using the 'place' action. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30072] Add more holds hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Kyle M Hall changed: What|Removed |Added Attachment #130517|0 |1 is obsolete|| Attachment #130621|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 130622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130622=edit Bug 30072: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30072] Add more holds hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Kyle M Hall changed: What|Removed |Added Attachment #130518|0 |1 is obsolete|| Attachment #130519|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 130621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130621=edit Bug 30072: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall bsoletes: 130517 - Bug 30072: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30072] Add more holds hooks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30072 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30111] New: EDIFACT chapter has lots of broken links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30111 Bug ID: 30111 Summary: EDIFACT chapter has lots of broken links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Manual Severity: normal Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org https://koha-community.org/manual/21.11/en/html/acquisitions.html#edi-process In the EDIFACT part of the manual there are a lot of broken links showing with the syntax ref:... Example: EANs: Each library using EDIFACT needs to specify a buyer identifier know as a SAN or EAN. This will fill in the :ref:`Library EANs ` setting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30104] Holds to pull is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30104 Lucas Gass changed: What|Removed |Added Attachment #130593|0 |1 is obsolete|| --- Comment #3 from Lucas Gass --- Created attachment 130620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130620=edit Bug 30104: (bug 29844 follow-up): Fix holds to pull There was an error when circ/pendingreserves.pl was hit: The method Koha::Items->biblionumber is not covered by tests! Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30104] Holds to pull is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30104 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29760] Show patron category in Holds queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 --- Comment #9 from Lucas Gass --- Created attachment 130619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130619=edit Bug 29760: (follow-up) Fix class name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29760] Show patron category in Holds queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29760 --- Comment #8 from Lucas Gass --- (In reply to Fridolin Somers from comment #7) > I see HTML classes are : > +Patron category > + > +... > > Is third one with a dash on purpose ? I think that was a mistake, I will provide a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30110] New: Potential bug source: plenty of "my" declarations with conditional assignments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30110
Bug ID: 30110
Summary: Potential bug source: plenty of "my" declarations with
conditional assignments
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: nug...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: jonathan.druart+k...@gmail.com
We have a lot of these things like "my $var .= ...", what is shouldn't be (if
no var before "my" so why conditional assignments?) - this looks like
refactoring remnants since old times, here I found some to analyze (and fix):
C4/Circulation.pm:
859: my $guarantors_non_issues_charges +=
$patron->relationships_debt({ include_guarantors => 1, only_this_guarantor =>
0, include_this_patron => 1 });
C4/Message.pm:
165: my $format ||= sub { $_[0] || "" };
C4/Search.pm:
891: my $weighted_query .= "(rk=(";# Specifies that we're applying
rank
C4/Utils/DataTables/VirtualShelves.pm:
47: my $join_vs .= q|
circ/circulation.pl:
477: my $guarantors_non_issues_charges +=
$patron->relationships_debt({ include_guarantors => 1, only_this_guarantor =>
0, include_this_patron => 1 });
Koha/DateUtils.pm:
146: my $time_re .= qr|
t/Labels_split_ccn.t:
41: my $split_num += scalar(@{$ccns->{$_}});
t/Labels_split_ddcn.t:
40: my $split_num += scalar(@{$ddcns->{$_}});
t/Labels_split_lccn.t:
43: my $split_num += scalar(@{$lccns->{$_}});
t/db_dependent/SIP/Message.t:
127: my $resp .= C4::SIP::Sip::maybe_add( FID_CALL_NUMBER,
$sip_item->hold_patron_name, $server );
840: my $resp .= C4::SIP::Sip::maybe_add( FID_CALL_NUMBER,
$sip_item->hold_patron_bcode, $server );
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29989] Improve headings in MARC staging template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29989 --- Comment #1 from Owen Leonard --- Created attachment 130618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130618=edit Bug 29989: Improve headings in MARC staging template This patch updates the MARC staging page so that the headings are descriptive based on the context. To test, apply the patch and go to Tools -> Stage MARC for import. - The heading should be "Stage MARC records for import." - Upload a MARC file and stage the file for import. - The heading on the next page should read "MARC staging results." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29989] Improve headings in MARC staging template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29989 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30109] New: Wrong interface in logs when renewing patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30109 Bug ID: 30109 Summary: Wrong interface in logs when renewing patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org I have not been able to recreate this in my testing environment, however, I can find evidence of the problem in many production environments. When renewing a patron the interface recorded in action logs is often 'api' SELECT * FROM action_logs WHERE module='MEMBERS' AND action="RENEW" AND interface='api'; The specific log is from Koha::Patron->renew_account This is only called in members/setstatus.pl setstatus uses 'checkauth' rather than other routines for verifying logged in patron, and it seems that the interface must not be set for Context in that call -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29989] Improve headings in MARC staging template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29989 Owen Leonard changed: What|Removed |Added Summary|Remove before : from "MARC |Improve headings in MARC |staging results :" |staging template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30108] New: Allow making hold dates required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30108 Bug ID: 30108 Summary: Allow making hold dates required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Make it possible that the two hold dates on opac-reserve (starts on and not needed after) are mandatory. Enable OPACAllowHoldDateInFuture to see the first one. A new pref could include the various (4) combinations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30060] Missing primary key on user_permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 --- Comment #9 from Jonathan Druart --- Thanks for the follow-up, Martin. However I don't think the "temp" column is needed. See installer/data/mysql/db_revs/210600012.pl where we delete duplicate from language tables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30060] Missing primary key on user_permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 --- Comment #8 from Martin Renvoize --- Created attachment 130617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130617=edit Bug 30060: (follow-up) Remove duplicate prior to adding key I had issues with this update as somehow my user_permissions table contained duplicate rows which throws an error when adding the new primary key. This follow-up patch adds SQL to remove any duplicate rows prior to adding the new primary key. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30060] Missing primary key on user_permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30060 Martin Renvoize changed: What|Removed |Added Attachment #130533|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 130616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130616=edit Bug 30060: Add primary key to user_permissions table Without primary key DBIC is failing with something like: GET /api/v1/suggestions/managers: unhandled exception (DBIx::Class::Exception)< user_permissions chain): fetch more unique non-nullable columns at /kohadevbox/koha/Koha/Objects.pm line 394>> Koha::REST::Plugin::Exceptions::__ANON__ / kohadevbox/koha/Koha/REST/Plugin/Exceptions.pm (73) Test plan: Execute the atomic update and confirm that the new PK has been added to the user_permissions table. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30107] New: When editing a desk, the currently logged in library is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Bug ID: 30107 Summary: When editing a desk, the currently logged in library is selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Instead of showing the library the desk was added to, on editing a desk, it always shows the library the user is currently logged in as preselected. Requires UseCirculationDesks to be activated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #9 from Jonathan Druart --- Please use the remote branch for testing, it contains all the tree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What|Removed |Added Attachment #130615|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What|Removed |Added Attachment #130614|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What|Removed |Added Attachment #130613|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What|Removed |Added Attachment #130612|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What|Removed |Added Attachment #130611|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What|Removed |Added Attachment #130610|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What|Removed |Added Attachment #130609|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What|Removed |Added Attachment #130608|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321
--- Comment #5 from Magnus Enger ---
After applying these patches I get this when I try to create a new illrequest:
Can't call method "borrowernumber" on an undefined value at
/home/me/kohaclone/Koha/Illrequest.pm line 1643.
1637 my @holds;
1638 if( defined $updated_columns{'borrowernumber'} and
1639 Koha::Patrons->find( $updated_columns{'borrowernumber'} ) )
1640 {
1641 # borrowernumber has changed
1642 my $old_illreq = $self->get_from_storage;
1643 @holds = Koha::Holds->search( {
1644 borrowernumber => $old_illreq->borrowernumber,
1645 biblionumber => $self->biblio_id,
1646 } )->as_list;
1647 }
Not sure what the problem is, but could it be that this works for existing
requests, but for new ones there just isn't an $old_illreq to get the
borrowernumber from?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||oleon...@myacpl.org, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #8 from Jonathan Druart --- Created attachment 130615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130615=edit Bug 30063: Display search description for main search only -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #7 from Jonathan Druart --- Created attachment 130614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130614=edit Bug 30063: Add kind of POD for the include file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #6 from Jonathan Druart --- Created attachment 130613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130613=edit Bug 30063: Fix address format -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #5 from Jonathan Druart --- Created attachment 130612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130612=edit Bug 30063: Remove occurrences of C4::Utils::DataTables::Members -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #4 from Jonathan Druart --- Created attachment 130611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130611=edit Bug 30063: Remove svc/members/search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30063] Make the main patron search use the /patrons REST API route
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30063 --- Comment #3 from Jonathan Druart --- Created attachment 130610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130610=edit Bug 30063: Make the main patron search use the REST API To test: * Length menu (PatronsPerPage) * Query description * Highlight of the current library * sticky header - Does not work (?) If the table does not show when you submit the filter form, make sure you regenerated the compiled CSS. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
