[Koha-bugs] [Bug 30084] Remove dependency of liblocale-codes-perl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30084 --- Comment #16 from Mason James --- (In reply to Kyle M Hall from comment #15) > Should this be backported to 21.11.x? If so, it seems incoomplete as it > doesn't reference list-deps the patch can be backported to 19.11.x it does modify list-deps, and looks complete to me :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29863] Show requested transfers in the holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29863 --- Comment #2 from Katrin Fischer --- Hi Andrew and Micheal, just a question: are requested transfers always related to stock rotation or are there other ways to make this happen (and to test this)? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29594] Koha should print transfer slip when generating a transfer from cancelling a hold on Holds Awaiting Pickup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29594 --- Comment #1 from Katrin Fischer --- Could an option to 'reprint' the transfer slip instead of the wrong transfer message also be an option here? I think you can usually print the hold slips multiple times, so I don't see why we should not do the same for the transfer slip. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20689] Improve usability of Item search fields administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer changed: What|Removed |Added Summary|Make it possible to add |Improve usability of Item |capital letter subfields to |search fields |item search fields |administration page --- Comment #63 from Katrin Fischer --- If it makes things a little easier, we could change description to: Improve usability of Item search fields administration page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28841] Canceling holds from 'Holds awaiting pickup' should follow return policies regarding transfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28841 Katrin Fischer changed: What|Removed |Added Summary|Canceling holds from|Canceling holds from 'Holds |Waiting Reserves should |awaiting pickup' should |follow the same rules as|follow return policies |for checking in items |regarding transfers |concerning transfers| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29119] Datatables filter on course reserves requires diacritics to be entered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29119 Katrin Fischer changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29119] Datatables filter on course reserves requires diacritics to be entered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29119 Katrin Fischer changed: What|Removed |Added Summary|Search of course reserves |Datatables filter on course |doesn't work propertly with |reserves requires |accents |diacritics to be entered CC||oleon...@myacpl.org --- Comment #1 from Katrin Fischer --- I can confirm this. I think this might not only affect the course reserves but also other tables that offer datatables for filtering. Not sure if there is an option or plugin we could use here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29047] Update the calendar page to use a calendar component
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29047 --- Comment #1 from Katrin Fischer --- Can you explain what the main difference would be? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29048] Incorrect search for linked authority records from authority search result list in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 Katrin Fischer changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org QA Contact|testo...@bugs.koha-communit | |y.org | Component|OPAC|Searching - Elasticsearch Summary|Authorities search results |Incorrect search for linked |- related records link |authority records from ||authority search result ||list in OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29048] Authorities search results - related records link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 --- Comment #2 from Katrin Fischer --- Created attachment 131154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131154=edit Bug 29048: Fix link to linked records from authority search results in OPAC Without this patch the constructed search link would give wrong results with Elasticsearch. If you searched for records linked to authority id 3 it would also turn up all other records linked to an authority where the id started with 3... This just copies the more specific link using an,phr used in the staff interface and the OPAC detail page to make things consistent To test: - Turn on Elasticsearch - Search for authorities in the OPAC - Locate a authority with a low ID in your result list - Note the number of linked records - Click on the link - It will give you more results than it said before - Verify results don't match your search - Apply patch - Try again - now it should all match up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29048] Authorities search results - related records link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Katrin Fischer changed: What|Removed |Added Attachment #131153|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #13 from Katrin Fischer --- Sorry, bug number confusion on my part... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 --- Comment #12 from Katrin Fischer --- Created attachment 131153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131153=edit Bug 29048: Fix link to linked records from authority search results in OPAC Without this patch the constructed search link would give wrong results with Elasticsearch. If you searched for records linked to authority id 3 it would also turn up all other records linked to an authority where the id started with 3... This just copies the more specific link using an,phr used in the staff interface and the OPAC detail page to make things consistent To test: - Turn on Elasticsearch - Search for authorities in the OPAC - Locate a authority with a low ID in your result list - Note the number of linked records - Click on the link - It will give you more results than it said before - Verify results don't match your search - Apply patch - Try again - now it should all match up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Needs Signoff Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27613] Pipe separated contents are hard to customize (OPAC)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27613 --- Comment #27 from Katrin Fischer --- (In reply to Fridolin Somers from comment #26) > Pushed to master for 22.05, thanks to everybody involved 濾 I found some display issues that might be related to this bug: Example in ktd sample database: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=70 The label by is 'below' the content that is 'above' it. Could some CSS be missing? I think it looked ok in testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30191] Authority search result list in the OPAC should use 'record' instead of 'biblios'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30191 Katrin Fischer changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30191] New: Authority search result list in the OPAC should use 'record' instead of 'biblios'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30191 Bug ID: 30191 Summary: Authority search result list in the OPAC should use 'record' instead of 'biblios' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org 'biblios' is not a term users understand, we should use 'record' or 'records' like in the staff interface. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29048] Authorities search results - related records link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29048 Katrin Fischer changed: What|Removed |Added Version|21.05 |master Severity|minor |normal --- Comment #1 from Katrin Fischer --- It looks like this is only an issue with Elasticsearch - Zebra seems to be have fine. I guess there is some automatic truncation going on here? You can test this easily with: an:3 and an,phr:3 in ktd and notice the difference in result lists. The authority detail page already uses the ,phr, so making them consistent seems like a good idea for a quick fix, but maybe we want to dig a little deeper to fully understand the difference in behavior here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Katrin Fischer changed: What|Removed |Added Blocks||30154 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30154 [Bug 30154] AuthorityControlledIndicators copies empty indicators as space making it hard to edit in cataloguing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30154] AuthorityControlledIndicators copies empty indicators as space making it hard to edit in cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30154 Katrin Fischer changed: What|Removed |Added Version|20.05 |master Summary|Can't write in the second |AuthorityControlledIndicato |indicator box in field 830 |rs copies empty indicators |after adding a new |as space making it hard to |authority |edit in cataloguing Depends on||14769 --- Comment #1 from Katrin Fischer --- Hi Noemie, you described it perfectly and I can confirm the behavior on the latest development version as well. I believe this is due to the AuthorityControlledIndicators system preference. It's defined there, that the second indicator will be copied from the authority record. If you haven't set any indicator in the authority, it will copy a 'space'. As the input is set to only allow you to enter one character, it looks like you can't enter anything. For the other fields you tested the second indicator is not taken from the authority, so that would explain the difference. But: Click into the field and then hit backspace/delete the space. Then you can add your indicator. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 [Bug 14769] Authorities merge: Set correct indicators in biblio field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #8 from Katrin Fischer --- I like the idea of having it on the dashboard, but if we put them there, I'd also like to see them on the holds awaiting pickup report somehow, because this is where they probably are still :) I wonder database wise how we should deal with these. We could just show 'cancelled in last... hours' - but then the library will be closed etc. and it won't work as nicely and you will never see what your coworkers have already taken care of... Some way to actually process them might be nice. Maybe a checkin could remove them from the list? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29616] Replace library information popup in the OPAC with a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 --- Comment #13 from Katrin Fischer --- (In reply to Fridolin Somers from comment #10) > (In reply to Lucas Gass from comment #9) > > > > Do we file a new bug? It seems like perhaps it was intentional to have the > > blue. > Yep, please open another bug report. > We will close invalid if it is on purpose. Done: Bug 30190 - Green buttons turn blue for a second when clicking them -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29616] Replace library information popup in the OPAC with a modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29616 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30190 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30190] New: Green buttons turn blue for a second when clicking them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30190
Bug ID: 30190
Summary: Green buttons turn blue for a second when clicking
them
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleon...@myacpl.org
Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
When clicking green buttons, like the "Go" button in simple search, it turns
dark blue for a second before returning to green.
In testing bug 29616 we were not sure if this was intentional, so filing a bug
to check and confirm.
From the comments:
(In reply to Lucas Gass from comment #9)
> That appears to be from this rule in the OPAC CSS file:
>
> .btn-primary:not(:disabled):not(.disabled).active,
> .btn-primary:not(:disabled):not(.disabled):active, .show >
> .btn-primary.dropdown-toggle {
> color: #fff;
> background-color: #0062cc;
> border-color: #005cbf;
> }
>
> Do we file a new bug? It seems like perhaps it was intentional to have the
> blue.
(In reply to Fridolin Somers from comment #10)
> (In reply to Lucas Gass from comment #9)
> >
> > Do we file a new bug? It seems like perhaps it was intentional to have the
> > blue.
> Yep, please open another bug report.
> We will close invalid if it is on purpose.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29578] Search term highlighting breaks with titles containing characters with Greek diacritics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29578 Katrin Fischer changed: What|Removed |Added CC||oleon...@myacpl.org Status|Needs Signoff |Failed QA --- Comment #11 from Katrin Fischer --- 1) Replicating the problem I am sorry to say, but I can't replicate the error exactly as described: The buttons don't disappear. But I see a small improvement with the patch: Συλλογής των εν επιτομή τοῖς πάλαι γεωγραφηθέντων First it only highlighted the last 2 letters, but not the τ. With the patch applied and after some nudging to load the new libary των is highlighted completely. I tested in latest Ubuntu with Firefox and Chrome. 2) Updating plugin I think if we update the plugin, we will also want to change the version coded in the file name, so we force browsers to load the updated file: koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.highlight-3.js Also, your change is only for the OPAC, we probably need to update in the staff interface separately. Adding Owen for some advice here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29584] autoBarcode generates a fifteen-digit number in the unit catalog instead of EAN13
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29584 --- Comment #1 from Katrin Fischer --- Hi Pavel, the autobarcode feature always looks at what is already in your database in terms of the highest used number so far. So for example if someone added a barcode manually that is odd/very long, this could set off the calculation. Maybe check if there is anything unusual with your existing barcodes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #9 from Katrin Fischer --- Created attachment 131152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131152=edit Bug 29589: (follow-up) Add TT filter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Katrin Fischer changed: What|Removed |Added Attachment #128698|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 131151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131151=edit Bug 29589: MARCOverlayRules - fix translatability issue Strings must not contain html tags, we should use KohaSpan instead. Test plan: Apply the patch, update translation for a given language, edit XX-YY-staff-prog.po Notice that the string is now "The %s preference is not set, don't forget to enable it for rules to take effect." Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29589] Translation issue with formatting in MARC overlay rules page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29589 --- Comment #7 from Katrin Fischer --- I am not completely sure about my follow-up, but to explain: Adding a html filter, won't work, as the text in the span is actually HTML - a link in this case. so if you make it html | $KohaSpan it will just output the HTML and destroy the link (tested). Maybe we'd need something more flexible than KohaSpan - KohaTag? Having parameters that allow us to specify the html tag for the surrounding elements and href in addition to class and id. For now I am proposing $raw. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592 Katrin Fischer changed: What|Removed |Added Attachment #128083|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 131150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131150=edit Bug 29592: Counterpart for authorities Similar adjustment. Check the breedingid again. Test plan: Same as former patch for authorities editor. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592 Katrin Fischer changed: What|Removed |Added Attachment #128082|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 131149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131149=edit Bug 29592: Do not apply defaultvalue to imported record The condition breedingid excludes records from Z3950. Test plan: Import to new or existing record. Verify that defaults are not applied. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29592] Imported records should not be completed with defaultvalues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29592 Katrin Fischer changed: What|Removed |Added Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29602] We must be nicer with translators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #53 from Katrin Fischer --- Sadly these no longer apply and I am not sure about some of the changes. Victor or Jonathan, could you rebase maybe? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29247] Enable staff to see whether a patron has a password or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29247 Katrin Fischer changed: What|Removed |Added Version|unspecified |master --- Comment #3 from Katrin Fischer --- I think we set borrowers.password to "" or ! when not set, so it should be possible to use that information for a visual clue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28541] Incorrect default pickup location passed to HTML, causing UI show items unreservable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28541 --- Comment #4 from Katrin Fischer --- Ping! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812
--- Comment #21 from Katrin Fischer ---
I'd really like to see this moving, trying to summarize:
1) Triggering the notice
(In reply to Martin Renvoize from comment #19)
> I actually liked that we triggered on password change..
I have had another look, I think the change is that now it will trigger when
the userid is changed:
Before:
if ( C4::Context->preference("AutoEmailOpacUser") == 1 && $newdata{'userid'}
&& $newdata{'password'}) {
After:
if ( C4::Context->preference("AutoEmailOpacUser") == 1 && $newdata{'userid'}) {
This might be out of scope here, but it seems a little odd before and after the
patch. We might want to have a more solid way of triggering this. My suggestion
would be to match what we have 'on the tin' and what has been the source of a
lot of confusion over the years:
"Send/Don't send an email to newly created patrons with their account details."
* Email when a new user is added/saved. This would also resolve bug 18543 about
not being able to send the auto-generated userid.
* Email when a librarian triggers the notice. We could add a button to do that.
This would also resolve bug 9097.
2) Updating existing notice templates
(In reply to Jonathan Druart from comment #18)
> Existing notice templates still need to be adjusted.
> If we cannot adjust them (because modified or translated) we should add a
> warning if "borrowers.password" or "patron.password" exists.
I think there are possibly too many variations in the templates to auto-update
them. Where should we add the warning? System information tab? The database
update?
3) Translated installers
> We won't remove all the translated installer files for 21.05, and this patch
> may be backported. We must fix all the .sql files.
True. I could provide a patch for this, but the others are a little too tricky
for me.
4) Move notices to message queue
This is a totally separate bug, but it will be so great: Once this is in we can
move to message_queue and we will exactly know when or when not a notice was
sent (bug 17648)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27812] Remove the ability to transmit a patron's plain text password over email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 Katrin Fischer changed: What|Removed |Added Blocks||18543 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18543 [Bug 18543] Emails for new patron accounts with the AutoEmailOpacUser preference require to enter password manually -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18543] Emails for new patron accounts with the AutoEmailOpacUser preference require to enter password manually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18543 Katrin Fischer changed: What|Removed |Added Depends on||27812 --- Comment #3 from Katrin Fischer --- There is Bug 27812 - Remove the ability to transmit a patron's plain text password over email now. With a password not longer being sent, we could add the notice to the message_queue and also make other changes much more easily to make it more useful. The reasoning is that you should never send a password by email and we have much better options now with the password recovery feature where patrons can set their own passwords easily. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 [Bug 27812] Remove the ability to transmit a patron's plain text password over email -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer changed: What|Removed |Added CC||andrew.isherwood@ptfs-europ ||e.com, ||martin.renvoize@ptfs-europe ||.com Status|NEW |Needs Signoff Summary|Add per borrower category |Add per borrower category |restrictions on ILL |restrictions on ILL |placement. |placement --- Comment #7 from Katrin Fischer --- Alex is no longer working on Koha so I am not sure why this was never set to 'needs sign-off'. The DO NOT PUSH for schema changes is normal as this file is only used for testing and the RM will not use it when pushing the patch set. So this doesn't tell us much. hm. I am updating the status to 'Patch doesn't apply' and adding Andrew and Martin who may know what happened here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203 Katrin Fischer changed: What|Removed |Added CC||ha...@orex.es --- Comment #6 from Katrin Fischer --- *** Bug 23976 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23976] Limit interlibrary loan by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23976 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 18203 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29446] Add ability to delete image from item edit drop down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29446 Katrin Fischer changed: What|Removed |Added Version|21.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26269] Overdues: Download file doesn't match result in staff interface when due date filters or 'show any available items currently checked out' are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 Katrin Fischer changed: What|Removed |Added Attachment #130204|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26269] Overdues: Download file doesn't match result in staff interface when due date filters or 'show any available items currently checked out' are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 Katrin Fischer changed: What|Removed |Added Text to go in the|RMNOTE: REMOVE FROM RELEASE | release notes|NOTE| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26269] Overdues: Download file doesn't match result in staff interface when due date filters or 'show any available items currently checked out' are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 Katrin Fischer changed: What|Removed |Added Summary|"Download file of displayed |Overdues: Download file |overdues" in|doesn't match result in |Circulation->Overdues |staff interface when due |produces .csv with fewer|date filters or 'show any |results than the displayed |available items currently |list under certain |checked out' are used |circumstances | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26269] "Download file of displayed overdues" in Circulation->Overdues produces .csv with fewer results than the displayed list under certain circumstances
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 --- Comment #8 from Katrin Fischer --- Created attachment 131148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131148=edit Bug 26269: "Date due to" and "Show any items currently checked out" filters doesn't work properly in overdues.pl Filter "Date due to" is now taken into account even when filled with a future date for the displayed result and downloaded results. Filter "Show any items currently checked out" is now taken into account for the downloaded results. To test: 1- Go to Circulation then to overdues 2a- Add a filter with "Date due To" > today 2b- Check that only the results with "Due date" < today are displayed (not those with "Due date" between today and the date requested) 2c- Click on "Download file of displayed overdues" 2d- Check that the file contains only the results with "Due date" < today (not those with "Due date" between today and the date requested) 3a- Reset filter and then add the filter "Show any items currently checked out" 3b- Check that all the results are displayed (even those with "Due date" > today) 3c- Click on "Download file of displayed overdues" 3d- Check that the file contains only the results with "Due date" < today (not those with "Due date" between today and the date requested) 9- Apply the patch 10- Repeat step 1 to 8, checking that all the results corresponding to the selected filter are now displayed/downloaded https://bugs.koha-community.org/show_bug.cgi?id=26269 Signed-off-by: Theodoros Theodoropoulos Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26269] "Download file of displayed overdues" in Circulation->Overdues produces .csv with fewer results than the displayed list under certain circumstances
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26269] "Download file of displayed overdues" in Circulation->Overdues produces .csv with fewer results than the displayed list under certain circumstances
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26269 --- Comment #7 from Katrin Fischer --- This is an older patch now already, but please remember that patch files always need to start with Bug : -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24548] Show different status in OPAC for items that have holds but have not yet been captured
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24548 --- Comment #4 from Katrin Fischer --- (In reply to Koha Team University Lyon 3 from comment #3) > Actually, we have in our OPAC a status "pending hold" in a 20.11.09 koha > version, but, we don't want to :-( > In our library, we want that holds concerned only books already on loan. We > left items on shelves for students that prefer to go and see through the > library. > > In the circulation rules, we have "on shelf holds allowed = If any > unavailable" and we don't allow OPAC item level holds. It means for us that > if one item is borrowed, it is possible to put an hold on the biblio level, > but the hold will be filled only if an item is returned. > > I'm a bit confused because I tried several possibilities for > OPACShowHoldQueueDetails but it didn't change anything :-( Could this have been an item level hold placed from the staff side? As only one item shows the status, it looks like it must be item level - at least that is what I would check first. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer changed: What|Removed |Added Attachment #130730|0 |1 is obsolete|| --- Comment #68 from Katrin Fischer --- Created attachment 131147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131147=edit Bug 22785: (follow-up) Fix translatability Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer changed: What|Removed |Added Attachment #130729|0 |1 is obsolete|| --- Comment #67 from Katrin Fischer --- Created attachment 131146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131146=edit Bug 22785: (follow-up) Don't sort by chosen and fix selection of matches Previously the sorting took 'chosen' into account and would move a selected match to the top on next load - it is better to preserve the same sorting every time When loading matches the 'cehcked' variable was not being cleared, so multiple matches were being marked 'checked="checked"'. Fixing this ensures the correct record displays as chosen Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Ben Daeuber Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer changed: What|Removed |Added Attachment #130728|0 |1 is obsolete|| --- Comment #66 from Katrin Fischer --- Created attachment 131145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131145=edit Bug 22785: Update Schema for boolean Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Ben Daeuber Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer changed: What|Removed |Added Attachment #130727|0 |1 is obsolete|| --- Comment #65 from Katrin Fischer --- Created attachment 131144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131144=edit Bug 22785: DO NOT PUSH Schema Updates Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer changed: What|Removed |Added Attachment #130726|0 |1 is obsolete|| --- Comment #64 from Katrin Fischer --- Created attachment 131143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131143=edit Bug 22785: Allow option to choose which record match is applied during import This patchset adds the display of all matches found during import to the import management screen A staff member with the permission to manage batches will be able to select for any individual record which match, or none, should be used during import To test: 1 - Import a batch of records or export existing records from your catalog 2 - Import the file (again) and select a matching rule that will find matches 3 - Note that you now have radio buttons allowing you to select a record, or none 4 - Test scenarios: I - When 'Action if matching record found' is 'Ignore' a - Imported record ignored if match is selected b - 'Action if no match found' followed if no match is selected (Ignore matches) II - When 'Action if matching record found' is 'Replace' a - The chosen record is the one overlayed (you can edit the chosen record before importing to confirm) b - 'Action if no match found' followed if no match is selected (Ignore matches) III - When 'Action if matching record found' is 'Add incoming record' a - Record is added regardless of matches 5 - Confirm 'Diff' 'View' links work as expected 6 - Confirm that after records are imported the radio buttons to choose are disabled Signed-off-by: Andrew Fuerste-Henry Bug 22785: API files Signed-off-by: Ben Daeuber Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #63 from Katrin Fischer --- I am adding a second sign-off, but as I had a bit of a rough start with this one, I'd like someone else to have a final look. It turns out, I was not hallucinating, but there is something odd happening here with the QA test tools on ktd in that it deleted and modified files: reset --hard origin/master git bz apply 22785 git status - clean kshell qa -v 2 testing 5 commit(s) (applied to 4cc3c0a '60 Bug 30133: (follow-up) Update obje') Processing files before patches |>| 17 / 17 (100.00%) Processing files after patches |>| 17 / 17 (100.00%) OK C4/ImportBatch.pm OK Koha/REST/V1/ImportRecordMatches.pm OK Koha/Schema/Result/ImportRecordMatch.pm OK api/v1/swagger/definitions.yaml OK api/v1/swagger/definitions/import_record_match.yaml OK api/v1/swagger/parameters.yaml OK api/v1/swagger/parameters/import_record_match.yaml OK api/v1/swagger/paths.yaml OK api/v1/swagger/paths/import_record_matches.yaml OK api/v1/swagger/x-primitives.yaml FAIL installer/data/mysql/atomicupdate/bug_22785.pl FAIL file permissions File must have the exec flag OK installer/data/mysql/kohastructure.sql OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt OK t/db_dependent/ImportBatch.t OK t/db_dependent/Koha/Import/Record/Matches.t FAIL t/db_dependent/api/v1/import_record_matches.t FAIL file permissions File must have the exec flag OK tools/batch_records_ajax.pl git status On branch 59-22785-manage-staged Changes to be committed: (use "git restore --staged ..." to unstage) modified: C4/ImportBatch.pm deleted:Koha/REST/V1/ImportRecordMatches.pm modified: Koha/Schema/Result/ImportRecordMatch.pm modified: api/v1/swagger/definitions.yaml deleted:api/v1/swagger/definitions/import_record_match.json deleted:api/v1/swagger/definitions/import_record_match.yaml modified: api/v1/swagger/parameters.yaml deleted:api/v1/swagger/parameters/import_record_match.json deleted:api/v1/swagger/parameters/import_record_match.yaml modified: api/v1/swagger/paths.yaml deleted:api/v1/swagger/paths/import_record_matches.json deleted:api/v1/swagger/paths/import_record_matches.yaml modified: api/v1/swagger/x-primitives.yaml deleted:installer/data/mysql/atomicupdate/bug_22785.pl modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt modified: t/db_dependent/ImportBatch.t modified: t/db_dependent/Koha/Import/Record/Matches.t deleted:t/db_dependent/api/v1/import_record_matches.t modified: tools/batch_records_ajax.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #62 from Katrin Fischer --- (In reply to Katrin Fischer from comment #61) > Did the database update get lost somehow? We have a Schema change noting a > new column, kohastructure.sql, but no atomic update file. Did a git reset --hard origin/master and reapplied the patches. The missing files have reappeared. I have no clue how they got deleted the first time. ls installer/data/mysql/atomicupdate/ didn't list the file, now it does... maybe hallucinating. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #61 from Katrin Fischer --- Did the database update get lost somehow? We have a Schema change noting a new column, kohastructure.sql, but no atomic update file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #60 from Katrin Fischer --- Besides the QA test failures which might be false positives (files don't appear to exist?) what is really blocking me here is: I see no checkboxes! I have staged the same file of records twice. Imported one file into catalog. Matched the other on ISBN. -> No checkboxed in result list, although there are several Match found in the list. Am I looking in the wrong spot? http://localhost:8081/cgi-bin/koha/tools/manage-marc-import.pl?import_batch_id=5 and have several -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #40 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #39) > Trying to comment here in order to get this unstuck... maybe. > > As this is going to be used for bug 8179 which I very much would like to see > moving :) > > If I understand Tomas last comment correctly the problem might be with > result lists that contain objects that can have different sets of AV > mappings... does that sound right? > > I am thinking about a list of order lines (aqorders) where every order line > is linked to a fund... that can be linked to different or none AV for the 2 > statistical values. Right, the idea is to make each object return (inside of it) done generic structure that lets the caller know how to find the av description. I'll get back to this next week, as we are responsible for having 8179 done, as the sponsor requested. We just need that people having different pov on the matter just say how they'd do it. And eventually vote something. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22785] Manage matches when importing through Stage Marc Record Import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22785 --- Comment #59 from Katrin Fischer --- OK C4/ImportBatch.pm FAIL installer/data/mysql/atomicupdate/bug_22785.pl FAIL file permissions File must have the exec flag FAIL t/db_dependent/api/v1/import_record_matches.t FAIL file permissions File must have the exec flag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30078] Holds to pull list does not show available item if already another item on pickup shelf
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30078 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28556] Make guarantor information available in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |the-minh.lu...@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26635] Expand authorised values in REST API call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #39 from Katrin Fischer --- Trying to comment here in order to get this unstuck... maybe. As this is going to be used for bug 8179 which I very much would like to see moving :) If I understand Tomas last comment correctly the problem might be with result lists that contain objects that can have different sets of AV mappings... does that sound right? I am thinking about a list of order lines (aqorders) where every order line is linked to a fund... that can be linked to different or none AV for the 2 statistical values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30026] International phone number not supported for sending SMS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |florian.bontemps@biblibre.c |ity.org |om --- Comment #10 from Katrin Fischer --- I am putting this back in the queue to get more opinions. I am ok with this change, but if we do it, we should adapt the hint below the field too. It currently reads: Please enter numbers only. Prefix the number with + if including the country code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30026] International phone number not supported for sending SMS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30026 Katrin Fischer changed: What|Removed |Added Status|In Discussion |Needs Signoff Summary|International Phone Number |International phone number |Not supported for SMSAlert |not supported for sending ||SMS --- Comment #9 from Katrin Fischer --- +49 or 0049 are equivalent here and both are accepted for example when adding contacts in my phone. I don't see the issue in making the regex for the SMS number accept more valid combinations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27123] Add messages to batch patrons modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA Summary|Add messaging preferences |Add messages to batch |to batch patrons|patrons modification |modification| --- Comment #3 from Katrin Fischer --- Hi Jeremy, 0) Please assign yourself the bugs you plan to work on :) 1) QA test tools A good habit to start is to always run the QA test tools against your patches before submitting, so simple stuff doesn't get your patches sent back: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt FAIL filters missing_filter at line 265 ( [% patron_message.message %] ) FAIL tools/modborrowers.pl FAIL spelling bloc ==> block For adding the filter, this might be helpful in the future: misc/devel/add_missing_filters.pl 2) Code comments in English please :) +# Créer un bloc pour enregistrer en bdd l'update de la table patron_messages + sécurité : 'si' tel champ est remplit alors etc Can you please provide a follow-up and switch back to signed off? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27123] Add messaging preferences to batch patrons modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jeremy.breuillard@biblibre. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lari.task...@hypernova.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27123] Add messaging preferences to batch patrons modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 Katrin Fischer changed: What|Removed |Added Keywords||Manual, ||release-notes-needed Summary|Add messages to batch |Add messaging preferences |patrons modification|to batch patrons ||modification -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321
--- Comment #15 from Katrin Fischer ---
I'd like to sign-off, but have issues with the tests here before and after
applying the patch. This is without the patches:
kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Illrequests.t
t/db_dependent/Illrequests.t .. 9/13
# Failed test 'We get expected error on notforloan of item'
# at t/db_dependent/Illrequests.t line 1150.
# Structures begin differing at:
# $got->{confirm} = HASH(0x564c474ded60)
# $expected->{confirm} = Does not exist
# Failed test at t/db_dependent/Illrequests.t line 1173.
# got: 'form'
# expected: 'done_check_out'
# Failed test at t/db_dependent/Illrequests.t line 1175.
# got: '0'
# expected: '1'
# Failed test at t/db_dependent/Illrequests.t line 1176.
# got: 'YPI9JroljKCZerYRd4NATNNudqRk7gIs0eisCksKqghavsp'
# expected: 'CHK'
# Looks like you failed 4 tests of 17.
t/db_dependent/Illrequests.t .. 10/13
# Failed test 'Checking out'
# at t/db_dependent/Illrequests.t line 1179.
t/db_dependent/Illrequests.t .. 13/13 # Looks like you failed 1 test of 13.
t/db_dependent/Illrequests.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/13 subtests
Test Summary Report
---
t/db_dependent/Illrequests.t (Wstat: 256 Tests: 13 Failed: 1)
Failed test: 10
Non-zero exit status: 1
Files=1, Tests=13, 10 wallclock secs ( 0.06 usr 0.00 sys + 8.58 cusr 1.42
csys = 10.06 CPU)
Result: FAIL
Any idea about this? Do they pass for you, Magnus?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30128] language_subtag_registry.description is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30128 Katrin Fischer changed: What|Removed |Added Attachment #130810|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 131142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131142=edit Bug 30128: [DO NOT PUSH] Update DBIC Schema Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30128] language_subtag_registry.description is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30128 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 --- Comment #10 from Katrin Fischer --- Created attachment 131141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131141=edit Bug 30135: (follow-up) Rephrase system preference description to use collection Avoids ccode in favor of collection in the system preference description. Also makes it a tiny bit easier to translate. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 Katrin Fischer changed: What|Removed |Added Attachment #131007|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 131140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131140=edit Bug 30135: Unit tests Add a unit test for EdifactLSQ preference. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 Katrin Fischer changed: What|Removed |Added Attachment #131006|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 131139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131139=edit Bug 30135: Add EdifactLSQ mapping preference This patch adds a new system preference, EdifactLSQ, to allow configuration of the ambiguous LSQ, sequence code, field included in the EDIFACT specifications. Originally the field was hard coded to map to 'location', but as per the specification it could have been mapped to 'ccode'. From the specification: A code or other designation which identifies stock which is to be shelved in a specified sequence or collection. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30150] Dutch option in language limits is garbled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30150 --- Comment #1 from Katrin Fischer --- Hi Eric, I see "Nederlands (Dutch)". What was your query to the language_descriptions table? For me it looks like this: MariaDB [koha_kohadev]> select * from language_descriptions where subtag = "nl"; ++--+--+-+-+ | subtag | type | lang | description | id | ++--+--+-+-+ | nl | language | de | Niederländisch | 148 | | nl | language | en | Dutch | 146 | | nl | language | fr | Néerlandais | 147 | | nl | language | nl | Nederlands | 145 | | NL | region | en | Netherlands | 319 | | NL | region | nl | Nederland | 320 | ++--+--+-+-+ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #111 from Katrin Fischer --- Almost there, some small things I noticed while testing: 1) Doubled up information http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=32 Information appears doubled up: Pamela Bennett (23529000318858) Pamela Bennett (23529000318858) 2) Position of headline http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=32 http://localhost:8081/cgi-bin/koha/members/pay.pl?borrowernumber=32 The heading appears above the toolbar, on all other pages it's below, which I think is better. 3) No heading http://localhost:8081/cgi-bin/koha/admin/edi_ean_accounts.pl http://localhost:8081/cgi-bin/koha/admin/items_search_fields.pl http://localhost:8081/cgi-bin/koha/tools/marc_modification_templates.pl 4) Typo http://localhost:8081/cgi-bin/koha/admin/z3950servers.pl Z19.50/SRU servers administration 5) Reword heading h1? Classification sources Classification sources h1 and h2 here are the same, maybe we should adjust h1 and the link on the admin page to have a wider scope and fit better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30189] New: Heading of Overdues with fines doesn't match
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30189 Bug ID: 30189 Summary: Heading of Overdues with fines doesn't match Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When going to 'overdues with fines' from the start page of circulation the heading there and in the breadcrumbs doesn't match. Heading: Circulation: Overdues at Centerville Circulation could be dropped, fines is missing. Breadcrumbs: Home Circulation Overdues at Centerville -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30188] New: Hold ratios report is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30188 Bug ID: 30188 Summary: Hold ratios report is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When trying to access the report I et: CGI::Compile::ROOT::kohadevbox_koha_circ_reserveratios_2epl::reserveratios_2epl(): DBI Exception: DBD::mysql::st execute failed: 'koha_kohadev.reserves.reservedate' isn't in GROUP BY at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 Testing on ktd with sample database. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178 --- Comment #10 from Janusz Kaczmarek --- > We just arrived at the same spot :) I first confirmed it by adding the line > to the templates: > > [% item.homebranch %] | [% Branches.GetLoggedInBranchname() %] > > So the fix is correct, but I feel we might want to revisit this confusing > variable at some point. Changing code to name is an easy template task, so > passing it like this appears not necessary. The more that the use of GetLoggedInBranchname creates a possible security issue in a malignant case of two different branches with the same name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #110 from Katrin Fischer --- Hi Owen, a little hard to see here that you have taken care of Jonathan's comments - can you add a comment at the end next time please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29964] SMTP server list not populating
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29964 Katrin Fischer changed: What|Removed |Added Severity|critical|normal --- Comment #19 from Katrin Fischer --- Just downgrading importance a little bit as I think we are up against an installation issue here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30171] Creating a subfield without linking it to an authorized value is error 500
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30171 Katrin Fischer changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30171] Creating a subfield without linking it to an authorized value is error 500
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30171 --- Comment #2 from Katrin Fischer --- Can't confirm on master or 20.11.14, possibly version specific. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29713] Make item table when placing an item level hold sortable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29713 --- Comment #10 from Katrin Fischer --- I tried... but it's way too confusing for me. :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add option for building the holds queue for a single record in background
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Katrin Fischer changed: What|Removed |Added Summary|Add option for building the |Add option for building the |holds queue for a single|holds queue for a single |bib in background |record in background -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30147] OpacBrowseResults causing error on detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 Katrin Fischer changed: What|Removed |Added Attachment #131096|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 131138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131138=edit Bug 30147: Fix modules usage in opac-detail.pl On the ktd sample database when trying to go to the detail page from the result list: Undefined subroutine ::Compile::ROOT::kohadevbox_koha_opac_opac_2ddetail_2epl::searchResults called at /kohadevbox/koha/opac/opac-detail.pl line 260 Turning off OpacBrowseResults makes the error disappear. In opac-detail.pl, use C4::Search is missing searchResults and getRecords To test: - Search for something that gives several result pages in OPAC, example: e - Switch to one of the last pages using link on top of results, example: 10 - Open any of the records listed in detail view - Verify that the error is shown - Apply patch and repeat, error is gone and browsing behaves as expected Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30147] OpacBrowseResults causing error on detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30147] OpacBrowseResults causing error on detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30147 --- Comment #2 from Katrin Fischer --- Not a very generalized test plan yet, but what triggers it for me: * Search for 'e' in simple search on the OPAC * Go to page 10 using the link in the paging on top of results * Go to any detail page from here - boom! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178 Katrin Fischer changed: What|Removed |Added Attachment #131123|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 131137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131137=edit Bug 30178: (bugs 27526 and 28445 follow-up) Every librarian can edit every item with IndependentBranches on Problem arises after applying bugfix 27526 and 28445: with IndependentBranches on, a librarian without superlibrarian privileges, can edit (and potentially delete) every item (i.e. also from a foreign branch). This is because can_be_edited calculation is buggy (in two spots). Test plan: 1. Have (at least) two branches defined. 2. Have IndependentBranches set. 3. Have a biblio record with items belonging to different branches. 4. Be a librarian without superlibrarian rights, with editcatalogue and tool permissions set. Scenario A (Edit items): 1. Go to Edit -> Edit items view (cataloguing/additems.pl). 2. You will be able to edit every item, also ones not from the branch you are from (cf. the button 'Actions'). 3. Apply the patch. 4. Repeat 1. 5. You should be able to edit only the items from your branch. Scenario B (Edit items in batch): 1. From Normal view go to Edit -> Edit items in batch. 2. You will be able to batch edit every item, also ones not from the branch you are from. 3. Apply the patch. 4. Repeat 1. 5. You should be able to edit only the items from your branch (and see 'Cannot edit' for others. Scenario C (Delete items in batch): 1. From Normal view go to Edit -> Delete items in batch. 2. You will not see the string 'Cannot delete' and only by chance will not be able to activate the checkboxes next to foreign items. 3. Apply the patch. 4. Repeat 1. 5. You should be able to delete only the items from your branch (and see 'Cannot delete' for others. Scenario D and E: Analogous steps can be executed from Tools -> Batch item modification and Tools -> Batch item deletion Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178
--- Comment #8 from Janusz Kaczmarek ---
One could add for testing a line like this:
[% Koha.Preference('IndependentBranches') %] // [%
logged_in_user.is_superlibrarian %] // [% item.homebranch %] // [%
Branches.GetLoggedInBranchname() ) %] // [% Branches.GetLoggedInBranchcode() )
%]
next to "SET can_be_edited" to see the actual values on the web page...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178 --- Comment #7 from Katrin Fischer --- And great commit message now btw! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178
--- Comment #6 from Katrin Fischer ---
(In reply to Janusz Kaczmarek from comment #5)
> Katrin, you are right, it is confusing. I wish it was a branch code, but it
> is not--it is the name. Have a look at columns_to_str here
> (cataloguing/additem.pl):
>
> my @items;
> for my $item ( $biblio->items->as_list, $biblio->host_items->as_list ) {
> push @items, $item->columns_to_str;
> }
>
> It took me some time to figure this out. The values of item.homebranch are
> then put directly into the table for users, so--I guess--it has been decided
> to pass this like this...
We just arrived at the same spot :) I first confirmed it by adding the line to
the templates:
[% item.homebranch %] | [% Branches.GetLoggedInBranchname() %]
So the fix is correct, but I feel we might want to revisit this confusing
variable at some point. Changing code to name is an easy template task, so
passing it like this appears not necessary.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30178] Every librarian can edit every item with IndependentBranches on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30178
--- Comment #5 from Janusz Kaczmarek ---
Katrin, you are right, it is confusing. I wish it was a branch code, but it is
not--it is the name. Have a look at columns_to_str here
(cataloguing/additem.pl):
my @items;
for my $item ( $biblio->items->as_list, $biblio->host_items->as_list ) {
push @items, $item->columns_to_str;
}
It took me some time to figure this out. The values of item.homebranch are
then put directly into the table for users, so--I guess--it has been decided to
pass this like this...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
