[Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 --- Comment #4 from Alex Buckley --- Created attachment 133518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133518=edit Bug 30444: Add shibboleth login to self checkout This patch adds a 'Shibboleth' option to the SelfCheckoutByLogin system preference. When 'Shibboleth' is selected the user should be logged straight into the self check module - assuming the AutoSelfCheckAllowed, AutoSelfCheckID and AutoSelfCheckPass system preferences are set. Test plan: 1. Have your Koha setup to do Shibboleth login 2. Set the following system preferences: - AutoSelfCheckAllowed => 'Allow' - AutoSelfCheckId and AutoSelfCheckPass => Set these to a patron with 'circulate' permissions - WebBasedSelfCheck -> 'Enable' - OpacShibOnly -> "Don't allow" 3. Visit the self checkout page /cgi-bin/koha/sco/sco-main.pl and notice a local login page loads 4. Apply patchset, update database and restart services 5. Set the new syspref: - SelfCheckoutByLogin -> 'Shibboleth' 6. Visit the self checkout page and notice you're logged into the sco interface straight away, without the local login page loading Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 Alex Buckley changed: What|Removed |Added Attachment #133513|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on vendor search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082 Aleisha Amohia changed: What|Removed |Added Attachment #131986|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 133517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133517=edit Bug 28082: Add acquisitions toolbar to vendors on vendor search page This patch makes a number of changes to the vendor search/view template in order to make it work better in different contexts: - Add a vendor-specific toolbar under each vendor search result. This gives instant access to the options for a new basket, new contract, vendor edit, or to receive shipments. A delete button will appear if available. - Add a summary of the number of baskets and subscriptions. This helps the user know if there are closed baskets and whether an outstanding subscription might be blocking the option to delete. Each number is linked to the view of those entries. - Indicate whether a vendor is inactive. The vendor name appears in a different color when it is inactve and is labeled as such. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - To test you should have multiple vendors in your system, some active and some inactive. Add some baskets and subscriptions to one or more if necessary. - Go to Acquisitions and submit an empty vendor search to show all vendors. - Verify that the page looks correct and that all controls work as expected. - Open the basket view for a single vendor and compare the two views. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28082] Add acquisitions toolbar to vendors on vendor search page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29057] Use font awesome icons on request.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29057 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |ASSIGNED CC||alei...@catalyst.net.nz --- Comment #19 from Aleisha Amohia --- It sounds like this is not yet ready for testing and awaiting a new patch? Adjusting bug status - feel free to change back if I'm wrong -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30196] Odd number of elements warning caused by dt_from_string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30196 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|Needs Signoff |ASSIGNED --- Comment #2 from Aleisha Amohia --- Can you please attach a test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20615] Add the link of number of times the authority are used in edit mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20615 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|Needs Signoff |Signed Off --- Comment #10 from Aleisha Amohia --- Looks like this was signed off so adjusting bug status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #147 from Mason James --- (In reply to Fridolin Somers from comment #145) > This follow-up looks nice. > I have a branch prepared for push. > Waiting for Mason about perl dep. hi Frido, i've added a patch for the dep -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #146 from Mason James --- Created attachment 133516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133516=edit Bug 28786: add Auth::GoogleAuth module to cpanfile -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29077] Warns when searching blank index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077 Aleisha Amohia changed: What|Removed |Added Attachment #125132|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 133515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133515=edit Bug 29077: Remove blank indexes before convert To test: 1 - Be using Elasticsearch 2 - Search on OPAC with dropdown set to 'Library catalog' 3 - Warns in plack-opac-error.log 4 - Apply patch 5 - Repeat 6 - No warns 7 - Search returns correct results Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29077] Warns when searching blank index
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29077 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28512] spinelabel-print.tt should include the logged in branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Aleisha Amohia changed: What|Removed |Added Attachment #121607|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 133514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133514=edit Bug 28512: add logged in branch as class to spinelabel-print.tt body To test: -Apply patch and generate a quick spine label. -Inscept the page and notice that the body should contain a new class which corresponds with that the of the logged in branch. Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28512] spinelabel-print.tt should include the logged in branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 Aleisha Amohia changed: What|Removed |Added Attachment #133512|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 133513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133513=edit Bug 30444: Add shibboleth login to self checkout This patch adds a 'Shibboleth' option to the SelfCheckoutByLogin system preference. When 'Shibboleth' is selected the user should be logged straight into the self check module - assuming the AutoSelfCheckAllowed, AutoSelfCheckID and AutoSelfCheckPass system preferences are set. Test plan: 1. Have your Koha setup to do Shibboleth login 2. Set the following system preferences: - AutoSelfCheckAllowed => 'Allow' - AutoSelfCheckId and AutoSelfCheckPass => Set these to a patron with 'circulate' permissions - WebBasedSelfCheck -> 'Enable' - OpacShibOnly -> "Don't allow" 3. Visit the self checkout page /cgi-bin/koha/sco/sco-main.pl and notice a local login page loads 4. Apply patchset, update database and restart services 5. Set the new syspref: - SelfCheckoutByLogin -> 'Shibboleth' 6. Visit the self checkout page and notice you're logged into the sco interface straight away, without the local login page loading Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 Aleisha Amohia changed: What|Removed |Added Attachment #133419|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 133512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133512=edit Bug 30444: Add shibboleth login to self checkout This patch adds a 'Shibboleth' option to the SelfCheckoutByLogin system preference. When 'Shibboleth' is selected the user should be logged straight into the self check module - assuming the AutoSelfCheckAllowed, AutoSelfCheckID and AutoSelfCheckPass system preferences are set. Test plan: 1. Have your Koha setup to do Shibboleth login 2. Set the following system preferences: - AutoSelfCheckAllowed => 'Allow' - AutoSelfCheckId and AutoSelfCheckPass => Set these to a patron with 'circulate' permissions - WebBasedSelfCheck -> 'Enable' - OpacShibOnly -> "Don't allow" 3. Visit the self checkout page /cgi-bin/koha/sco/sco-main.pl and notice a local login page loads 4. Apply patchset, update database and restart services 5. Set the new syspref: - SelfCheckoutByLogin -> 'Shibboleth' 6. Visit the self checkout page and notice you're logged into the sco interface straight away, without the local login page loading Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30444] Enable Shibboleth option for SelfCheck modules for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30444 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326 --- Comment #7 from Aleisha Amohia --- Created attachment 133511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133511=edit Bug 30326: (follow-up) Add output parameter and handle bad biblionumbers When the script is run without the --html parameter, the output will be simply text. When the script is run with the --html parameter, the output will display in an HTML table. Additional test plan: 5. Test running script with and without --html parameter and confirm output is correct. 6. Test running script with a --bibnum that does not exist and confirm the output acknowledges this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30326] Cronjob that checks biblios for MARC errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30326
--- Comment #6 from Aleisha Amohia ---
(In reply to Tomás Cohen Arazi from comment #5)
> 3. I suggest you add a --where parameter, that is passed as a literal query
> to
>
> Koha::Biblios->search( $query, { prefetch => ['biblio_metadata'] } );
>
> and use $biblio->metadata->record instead of GetMarcBiblio.
I thought about doing it this way but it's significantly slower, not ideal when
there are lots of biblios to check through.
I can implement the other suggestions.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS in tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 --- Comment #10 from Aleisha Amohia --- Created attachment 133510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133510=edit Bug 30288: (follow-up) Use CSS for separator pipes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS in tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Aleisha Amohia changed: What|Removed |Added Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What|Removed |Added Attachment #130250|0 |1 is obsolete|| --- Comment #11 from Aleisha Amohia --- Created attachment 133509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133509=edit Bug 16522: Adding 773 to cart and list displays and emails This patch adds a new subroutine get_host_item_entries in the Koha::Biblio module which retrieves any 773 fields from the biblio record. The subroutine is used to show a host item entry and a link to the record in the following places: - staff client list - staff client cart - staff client send list email - staff client send cart email - opac list - opac cart - opac send list email email - opac send cart email To test: 1. apply patch, restart services 2. log into the staff client and enable the syspref EasyAnalyticalRecords 3. find a record with an item. take note of the barcode. 4. go to another record (biblio 2). click Edit -> Link to host record 5. enter the barcode in the input and submit. 6. click the MARC tab and confirm the host record has been linked under MARC field 773. 7. add biblio 2 to your cart, and to a list. 8. go to your cart. confirm you see the 'host item entry' link. 9. click on 'more details' and confirm you see the 'host item entries' link. 10. click 'send' to email the cart. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 11. go to the list you added the record to. confirm you see the 'source' link for the host item entry. 12. click 'send list' to email the list. confirm the email contains the host item entry and the link sends you to the catalogue page for the record in the OPAC. 13. log into the OPAC. repeat steps 7 to 12 on the OPAC and confirm they all pass as expected. 14. confirm tests pass: t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27470] Improve link text for logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27470 Aleisha Amohia changed: What|Removed |Added Attachment #115402|0 |1 is obsolete|| Attachment #115403|0 |1 is obsolete|| --- Comment #5 from Aleisha Amohia --- Created attachment 133508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133508=edit Bug 27470: Improved link text for shibboleth login TEST PLAN: 1) Enable shibboleth by adding shibboleth to koha-conf.xml, you can do this by following https://wiki.koha-community.org/wiki/Shibboleth_Configuration#Using_AD_FS_Metadata 2) If you are logged in Koha, log out, on the login screen the text at the top should say the following, "Log in using a Shibboleth account" Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27470] Improve link text for logging in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27470 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30288] Provide links to OPACUserJS and OPACUserCSS in tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30288 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin Somers --- Ah this patch adds pipes as separator. Please use CSS for this, like in #moresearches : https://git.koha-community.org/Koha-community/Koha/src/commit/833c9efee0c0e01a0223318b578efa77272ed958/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss#L377 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30226] Add system preference to disable auto-renew checkbox at checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 --- Comment #11 from Fridolin Somers --- Created attachment 133507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133507=edit Bug 30226: (follow-up) Remove text from database update The text displayed by database update is not really helpful. And it will be incorrect if update is run several times. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30226] Add system preference to disable auto-renew checkbox at checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30226 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25029 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25029] AllowPatronToControlAutorenewal needs to have a disable setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30226 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when adding/editing items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #12 from Fridolin Somers --- Makes sens. For a total free input, one must not use this value builder. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30482] Potential for bad string concatenation in cataloging validation error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482 David Nind changed: What|Removed |Added Attachment #133062|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 133506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133506=edit Bug 30482: Potential for bad string concatenation in cataloging validation error message In validating the basic MARC editor form before submission, we run AreFieldsNotOk() twice (once with the parameter "false") and concatenate the result for output. This creates the potential for the error string to be appended with "0" if AreFieldsNotOk() returns false. This patch improves the logic around building the error string. To test, apply the patch and make sure one of your MARC frameworks contains at least one mandatory field and at least one important field. - Edit or create a MARC record in the basic MARC editor. - Submit the form in various states of completion: - If a mandatory and an important field are empty, you should see two error messages at the top. "The following mandatory subfields aren't filled" and "The following important subfields aren’t filled." - If a mandatory OR an important field is empty, you should see a single message. - If it's the important field which is empty, a confirmation will ask if you want to save the record anyway. Test that both answers to this confirmation work correctly. - If no mandatory or important fields are empty the form should submit. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30482] Potential for bad string concatenation in cataloging validation error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 David Nind changed: What|Removed |Added Attachment #132129|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 133505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133505=edit Bug 29537: Remove unnecessary if-else checks for soonest renew date GetSoonestRenewDate() calculates the renewal due date now also correctly for auto-renewals after the fixes from bug 29476 so we don't have to add any if-else checks because of it being buggy anymore. To test: 1) prove t/db_dependent/Circulation.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29537] Simplify auto-renewal code in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29537 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29602] We must be nicer with translators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #95 from Victor Grousset/tuxayo --- (In reply to Victor Grousset/tuxayo from comment #89) > The QA script complained about some existing missing filters. It's not from > the patch Actually they are new from the patch. And find-missing-filters.t is failing because of that. It's when changing the way of displaying the item link using KohaSpan. from: Item with barcode [% m.barcode | html %] cannot be deleted: to: [% item_link = BLOCK %][% m.barcode | html %][% END %] Item with barcode [% item_link | $KohaSpan%] cannot be deleted: Actually it's a false positive because when assigning item_link, variables already go though a filter. Anyway to make the check happy which filter to use? raw? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14797] Cancelling orders with no alert to existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14797 CB changed: What|Removed |Added CC||balestri...@monterey.org --- Comment #6 from CB --- My current practice is to cancel the order and delete the Bib record when cancelling an item on order. If we have another copy of the same item on the existing Bib record, koha will not let you delete the Bib record; it will only allow you to cancel the order for the item. This should be fine as far as a hold is concerned, as the hold will now still be in place for the item currently in circulation. As such, koha will not allow you to cancel the order and delete the Bib record if there is a hold on the item (and this is the only item attached to the Bib record). This automatically alerts me that there is a hold on the item. I do not find this "bug" to be an issue in my workflow or with koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29602] We must be nicer with translators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #94 from Victor Grousset/tuxayo --- Thanks Zeno for another test, more eyes are always welcome. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20398] Add a system preference to disable search result highlighting in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398 David Nind changed: What|Removed |Added Text to go in the|This enhancement adds a new |This enhancement adds a new release notes|system preference |system preference |StaffHghlightWords. This|StaffHighlightWords. This |enables highlighting of |enables highlighting of |words in search results for |words in search results for |the staff interface to be |the staff interface to be |turned on or off. |turned on or off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 The Minh Luong changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #179 from The Minh Luong --- I tried to apply the patch and it seems to apply cleanly. I do not have any merge markers when I apply the patch. Did you make sure that your environment is up to date? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong changed: What|Removed |Added Attachment #132581|0 |1 is obsolete|| --- Comment #111 from The Minh Luong --- Created attachment 133504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133504=edit Bug 17385: Fixing display for XSL-Simple Export in OPAC This attachment correct the placement of XSL-Simple Export in the OPAC's page. It is now displayed in the "Save record" dropdown menu. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong changed: What|Removed |Added Attachment #132493|0 |1 is obsolete|| --- Comment #110 from The Minh Luong --- Created attachment 133503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133503=edit Bug 17385: Correction of opac-detail-sidebar.inc This patch reverts the changes made in opac-detail-sidebar.inc, so the sidebar is displayed as wanted. Tests are now passing properly. TEST PLAN: 1- Apply the patch and search for a record in the OPAC. 2- Click on "Save record". Notice that the dropdown menu is unchanged. 3- Run t/db_dependent/XSLT.t (All tests should pass) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong changed: What|Removed |Added Attachment #132492|0 |1 is obsolete|| --- Comment #109 from The Minh Luong --- Created attachment 133502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133502=edit Bug 17385: Add custum export format option when saving a record This patch adds "XSL-Simple Export" when saving a bibliographic record. Previous patches are combined into this one. To test: 1) Search for a record in the intranet. 2) Click on the "Save" button and observe the dropdown menu. 3) Notice that "XSL- Simple Export" is not in the menu. 4) Apply the patch. 5) Repeat the steps 1 and 2. 6) Notice that "XSL - Simple Export" is in the menu. 7) Click on "XSL - Simple Export". A .html file should be downloaded. 8) Open the .html file. You should see the record's informations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong changed: What|Removed |Added Attachment #132491|0 |1 is obsolete|| --- Comment #108 from The Minh Luong --- Created attachment 133501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133501=edit Bug 17385: Add tests for CustomXSLTExportList Tests are now in one patch. One test does not pass and I am not able to fix it. The test who fails : $ prove -l t/db_dependent/XSLT.t t/db_dependent/XSLT.t .. 1/3 # Failed test 'This list comes from the cache and that is fine' # at t/db_dependent/XSLT.t line 122. # got: '1' # expected: '2' # Looks like you failed 1 test of 1. # Failed test 'CustomXSLTExportList: Caching' # at t/db_dependent/XSLT.t line 124. # Looks like you failed 1 test of 3. t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report --- t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 2 Non-zero exit status: 1 Files=1, Tests=3, 3 wallclock secs ( 0.03 usr 0.00 sys + 1.74 cusr 0.14 csys = 1.91 CPU) Result: FAIL This one works fine : $ prove -l t/XSLT.t t/XSLT.t .. ok All tests successful. Files=1, Tests=12, 4 wallclock secs ( 0.02 usr 0.00 sys + 2.55 cusr 0.17 csys = 2.74 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong changed: What|Removed |Added Attachment #132490|0 |1 is obsolete|| --- Comment #107 from The Minh Luong --- Created attachment 133500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133500=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong changed: What|Removed |Added Attachment #132489|0 |1 is obsolete|| --- Comment #106 from The Minh Luong --- Created attachment 133499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133499=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 The Minh Luong changed: What|Removed |Added Attachment #132488|0 |1 is obsolete|| --- Comment #105 from The Minh Luong --- Created attachment 133498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133498=edit Bug 17385: Add custom export XSLT Rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #145 from Fridolin Somers --- This follow-up looks nice. I have a branch prepared for push. Waiting for Mason about perl dep. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #135 from Fridolin Somers --- I add to resolve some conflicts on patrons search due to Bug 30063 I fixed to h1 to div in follow-up : https://git.koha-community.org/Koha-community/Koha/commit/05ba079814facb569feb9327992a1dc441753754 Feel free to add some other follow-up if needed. Best regards, -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556 --- Comment #1 from The Minh Luong --- Created attachment 133497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133497=edit Bug 30556: Place hold button doesn't show when not allowed When On shelf holds holds allowed is on "If all unavailable", the Place hold button is not showed. To test: 1. Create a circulation rule with on shelf holds set to "If all unavailable" 2. Create or modify a record to match the items itype to the circulation rule 3. Use a patron matching the circ rule category to log into the opac 4. Look for the record 5. Notice that the Place hold button is there, even thought it's not allowed 6. Apply the patch. 7. The button is not there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373 --- Comment #36 from Bernardo Gonzalez Kriegel --- (In reply to Fridolin Somers from comment #35) > (In reply to Jonathan Druart from comment #25) > > Fridolin, patches with signed-off-by lines are available at > > https://gitlab.com/joubu/Koha/-/commits/bug_30373 > > Hi, could you please apply last patch : > Bug 30373: Fix visibility, authorised values and descriptions > > It does not work with 'git bz apply' Hi, you need to apply the last four patches over Jonathan's branch. The last patch depends on #29 and #30 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items via SIP2 for arbitrary patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370 Martin Renvoize changed: What|Removed |Added Text to go in the||This patch adds a new release notes||option to the SIP config, ||`inhouse_patron_categories` ||. Adding a comma-separated ||list of patron category ||codes to this option will ||cause the SIP checkout to ||never send the ||'demagnetize' command to ||the checkout preventing ||said users from removing ||the items from the library. Version(s)|This patch adds a new |22.05.00 released in|option to the SIP | |config,22.05.00,| |`inhouse_patron_categories` | |. Adding a comma-separated | |list of patron category | |codes to this option will | |cause the SIP checkout to | |never send the | |'demagnetize' command to| |the checkout preventing | |said users from removing| |the items from the library. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30544] Add font awesome version to licenses page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30544] Add font awesome version to licenses page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30544 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30237] Rename/rephrase AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 --- Comment #31 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30237] Rename/rephrase AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 --- Comment #33 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29420] HTTP status code incorrect when calling error pages directly under Plack/PSGI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29420 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29005] Add option to send ACCTDETAILS notice for new patrons added via patron imports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 --- Comment #21 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29005] Add option to send ACCTDETAILS notice for new patrons added via patron imports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 --- Comment #134 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27631] Accessibility: Staff interface - on each page is Logo but should be page description/title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27631 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items via SIP2 for arbitrary patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370 --- Comment #15 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26370] Add ability to disable demagnetizing items via SIP2 for arbitrary patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26370 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)|This patch adds a new |This patch adds a new released in|option to the SIP config, |option to the SIP |`inhouse_patron_categories` |config,22.05.00, |. Adding a comma-separated |`inhouse_patron_categories` |list of patron category |. Adding a comma-separated |codes to this option will |list of patron category |cause the SIP checkout to |codes to this option will |never send the |cause the SIP checkout to |'demagnetize' command to|never send the |the checkout preventing |'demagnetize' command to |said users from removing|the checkout preventing |the items from the library. |said users from removing ||the items from the library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9097] Add option to trigger 'Welcome mail' manually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 --- Comment #24 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9097] Add option to trigger 'Welcome mail' manually
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373 --- Comment #35 from Fridolin Somers --- (In reply to Jonathan Druart from comment #25) > Fridolin, patches with signed-off-by lines are available at > https://gitlab.com/joubu/Koha/-/commits/bug_30373 Hi, could you please apply last patch : Bug 30373: Fix visibility, authorised values and descriptions It does not work with 'git bz apply' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30373] Rewrite UNIMARC installer data to YAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373 Fridolin Somers changed: What|Removed |Added URL||https://gitlab.com/joubu/Ko ||ha/-/commits/bug_30373 CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30573] Do not hide "Total Tax Inc" on invoice details when tax has been charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30573 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30570] Replace the use of jQueryUI tabs in OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30570 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Shi Yao Wang changed: What|Removed |Added Attachment #115217|0 |1 is obsolete|| --- Comment #41 from Shi Yao Wang --- Created attachment 133496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133496=edit Bug 11300: Add a new authority linker which searches for authority links on a Z39.50 server. This patch adds a Z39.50 Linker which searches for authority links on a remote server. If a matching authority is found, it's imported in the local database for linking with the current biblio record. If no matching authority was found on the remote server, the Linker falls back to a local authority search. Configuration : * The option "Z39.50 Server" is added to the LinkerModule preference. You must choose this to use the new Linker. * The preference LinkerZ3950Server is required and specifies which server to use for linking. It must contain the "name" of the server, as defined in the z3950servers table. * You can set the "local_first" option in the LinkerOptions preference to force the Linker to search for authorities in the local database first. If no local authority match was found, the Linker falls back to a remote Z39.50 search. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29346] Add real-time holds queue update option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29602] We must be nicer with translators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #93 from Martin Renvoize --- Final follow-up fixes one of the failing unit tests on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29602] We must be nicer with translators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 Martin Renvoize changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29602] We must be nicer with translators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29602 --- Comment #92 from Martin Renvoize --- Created attachment 133495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133495=edit Bug 29602: (follow-up) Fix TemplateToolkit test This patch fixes the t/db_dependent/Letters/TemplateToolkit.t by adding the nested `` into the expected output string to reflect the change added to the primary include. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Excellent, thanks for the quick follow-up. PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457 Martin Renvoize changed: What|Removed |Added Attachment #133491|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 133494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133494=edit Bug 30457: (follow-up) Tweak markup around search form This patch makes a change to the markup around the patron/clubs search form on the holds page. This change prevents the Bootstrap tabs from inheriting an unwanted margin from the fieldset.brief definition. The change also replaces a tag with an . I think a heading makes more sense than a free-floating . To test, apply the patch and confirm that the holds page (/cgi-bin/koha/reserve/request.pl?biblionumber=XXX) looks correct. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457 Martin Renvoize changed: What|Removed |Added Attachment #133088|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 133493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133493=edit Bug 30457: Convert holds page tabs to Bootstrap This patch updates the holds page to replace jQueryUI tabs with Bootstrap. To test, apply the patch and begin the process of placing a hold on a title in the catalog. If you have one or more patron clubs configured: - You should see two tabs, Patrons and Clubs. - Both should look correct and work correctly. - The Patrons tab should be selected initially, with cursor focus in the form field. - Switch to the Clubs tab. The cursor focus should move to the form field under this tab. - Submit a club search which will return results. - The page should refresh and the clubs tab should be preselected, showing the search results. If you have no patron clubs configured, the page should show only the Patrons tab. Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30433] Convert advanced search tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30433] Convert advanced search tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Perfec, PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30433] Convert advanced search tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30433 Martin Renvoize changed: What|Removed |Added Attachment #132867|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 133492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133492=edit Bug 30433: Convert advanced search tabs to Bootstrap This patch updates the advanced search page in the staff interface to use Bootstrap tabs instead of jQueryUI. To test, apply the patch and test the advanced search interface. The tabs should look correct and work correctly. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17787] Hidden items included in count of search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- This is still a problem in master and this bugfix seems to fix the problem, I am setting it to NSO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457 --- Comment #5 from Owen Leonard --- Created attachment 133491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133491=edit Bug 30457: (follow-up) Tweak markup around search form This patch makes a change to the markup around the patron/clubs search form on the holds page. This change prevents the Bootstrap tabs from inheriting an unwanted margin from the fieldset.brief definition. The change also replaces a tag with an . I think a heading makes more sense than a free-floating . To test, apply the patch and confirm that the holds page (/cgi-bin/koha/reserve/request.pl?biblionumber=XXX) looks correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30457] Convert holds page tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30457 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30489] Convert MARC and authority subfield edit tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30489 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30489] Convert MARC and authority subfield edit tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30489 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #3 from Martin Renvoize --- Looking great and working great.. nice one.. Going straight for PQA here too.. Scripts are happy and no regressions found. PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30489] Convert MARC and authority subfield edit tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30489 Martin Renvoize changed: What|Removed |Added Attachment #133304|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 133490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133490=edit Bug 30489: Convert MARC and authority subfield edit tabs to Bootstrap This patch updates the MARC and authority subfield edit interface to replace jQueryUI tabs with Bootstrap. The code for handling drag-to-reorder tabs is updated to accommodate the new markup. To test, apply the patch and restart_all. - Go to Administration -> MARC bibliographic framework -> Default framework and choose "MARC structure" from the Actions menu. - In the row for 000 LEADER, click Actions -> View subfields. - Click "Edit." On the edit page the tabs should look correct and work correctly. - Return to the list of tags and click "View subfields" for the 245 tag. - Click one of the "Edit" buttons for any but the first subfield, e.g. "a". - On the "Tag 245 Subfield constraints" page the "a" tab should be pre-selected. - Click any of the subfield tabs and drag it to re-order it in the sequence of tags. - It should stay in the correct slot when you release it. - Save and confirm that the new sequence of subfields has been saved. Perform all the same tests under Administration -> Authority types. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #50 from Tomás Cohen Arazi --- I already tested this one. Will do a second round to check the rebase fixes and Nick's follow-up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30475] Convert tools pages tabs to Bootstrap (part 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 --- Comment #4 from Martin Renvoize --- Looks great, Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30475] Convert tools pages tabs to Bootstrap (part 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30475] Convert tools pages tabs to Bootstrap (part 2)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 Martin Renvoize changed: What|Removed |Added Attachment #133474|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 133489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133489=edit Bug 30475: Convert tools pages tabs to Bootstrap (part 2) This patch converts jQueryUI tabs on three tools templates to Bootstrap tabs. The patch contains indentation changes, so diff accordingly. To test, apply the patch and go to Tools -> Export. - You should see at least two tabs, "Export bibliographic records" and "Export authority records." - Confirm that they look correct and work correctly. Go to Tools -> Batch patron modification. - Check the "By card number," "By borrowernumber," and "By patron list" tabs. Go to Tools -> Overdue notice/status triggers. - Check the "First," "Second," and "Third" tabs. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30453] Convert offline circulation tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30453] Convert offline circulation tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #4 from Martin Renvoize --- Looking good.. PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30453] Convert offline circulation tabs to Bootstrap
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30453 Martin Renvoize changed: What|Removed |Added Attachment #133279|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 133488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133488=edit Bug 30453: Convert offline circulation tabs to Bootstrap This patch updates the offline circulation page in the staff interface to use Bootstrap tabs instead of jQueryUI. To test, apply the patch and make sure the AllowOfflineCirculation system preference is enabled. - Go to Circulation -> Built-in offline circulation interface - Submit a patron barcode in the "Check out" field. - Under the barcode input field you should see two tabs: Checkouts and Fines. Confirm that they look correct and work correctly. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30573] New: Do not hide "Total Tax Inc" on invoice details when tax has been charged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30573 Bug ID: 30573 Summary: Do not hide "Total Tax Inc" on invoice details when tax has been charged Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: and...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org On invoice.pl, if the vendor is set up so prices at receiving do not include tax, we hide the "Total tax inc" column in invoice details. If there is a tax rate associated with this vendor and tax has been calculated and charged, we should show the "Total tax inc" column. Otherwise the user ends up having to either click the reveal the column or do the math themselves. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on the notices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- This is great.. Passing QA Minor annoyance that predates this though.. when you switch the language tab, we don't keep the context of the open accordion.. would be great if we could.. but that can wait on another bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30545] Replace the use of jQueryUI Accordion on the notices page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30545 Martin Renvoize changed: What|Removed |Added Attachment #133473|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 133487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133487=edit Bug 30545: Replace the use of jQueryUI Accordion on the notices page This patch updates the notices edit interface in order to replace jQueryUI accordion and tabs widgets with Bootstrap collapse and tabs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Set the TranslateNotices system preference to "Don't allow." - Go to Tools -> Notices and edit any notice. - On the "Modify notice" page you should see three collapsed sections: Email, Print, and SMS. - Clicking the section headings should expand and collapse the panels. - With one of the panels open, click Save -> Save and continue editing. - When the page reloads the same panel should be expanded. - Enable the TranslateNotices system preference. - Return to the edit interface for one of your notices. - You should now see at least two tabs: Default and English. - The sections under each tab should continue to work correctly. - Test the "Save and continue" functionality again. When redirected you should return to both the correct tab and the correct panel, e.g. the "Print" section under the "English (en)" tab. Signed-off-by: Lucas Gass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30474] Convert tools pages tabs to Bootstrap (part 1)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30474 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #9 from Martin Renvoize --- Looking good.. again the top padding is fixed elsewhere already.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
