[Koha-bugs] [Bug 30747] Column settings on otherholdings table in detail.tt doesnt work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30747 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |BLOCKED --- Comment #11 from Marcel de Rooy --- Looking here now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #107 from Jonathan Druart --- Do you agree with this last patch, Martin? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #106 from Jonathan Druart --- Created attachment 135189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135189=edit Bug 21978: Add middle_name to sysprefs.sql And add middle_name at the exact same places for installations with the default value. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #105 from Jonathan Druart --- Created attachment 135188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135188=edit Bug 21978: (follow-up) Stop using C4 methods in atomicupdate We should really only use C4::Context methods where absolutely necessary.. in this case is was simple to replace the get_preference and set_preference calls with SQL Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #104 from Jonathan Druart --- Created attachment 135187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135187=edit Bug 21978: (follow-up) Stop passing holdfor_cardnumber We not longer need to pass holdfor_cardnumber distinctly, we can just refer to holdfor_patron.cardnumber instead. This patch does that ;P Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #103 from Jonathan Druart --- Created attachment 135186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135186=edit Bug 21978: Use patron-title for holdfor handling in results This patch update the catalogue search results page to use the patron-title include to display patron titles for the 'Holds for' line in results and dropdown list. Test plan 1) Load patron account 2) Press search to hold 3) Perform a search which brings back 2+ items (e.g. 'street') 4) Note that on the search results it says: Place hold for 'firstname (othername) surname (cardnumber)' 5) Press the Place hold button and note that the dropdown includes "Place hold for 'firstname (othername) surname'" and "Forget 'firstname (othername) surname'" 6) Click through to an item from the results, press the 'Place hold' button and note the dropdown includes "Place hold for 'firstname (othername) surname'" Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #102 from Jonathan Druart --- Created attachment 135185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135185=edit Bug 21978: Use patron-title.inc in request.tt This patch updates all manual accurences of the patron title display to use the patron-title.inc include (so we get middlename handling) in request.tt. We also add the option to hide the cardnumber from the include and set the link_to to 'members_pay' to retain the current display format on this page. Test plan You'll need to trigger the following cases to test all cases: 1) Too many holds 2) Account expired 3) Has restrictions 4) Outstanding fines 5) Already has hold on item 6) No holds allowed 7) Too many holds for this record 8) Already in possession 9) Already has a hold 10) Already has a recall 11) Pickup library doesn't many patron home library Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #101 from Jonathan Druart --- Created attachment 135184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135184=edit Bug 21978: Add middle_name into hold request autocomplete Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #100 from Jonathan Druart --- Created attachment 135183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135183=edit Bug 21978: Schema Update Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #99 from Jonathan Druart --- Created attachment 135182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135182=edit Bug 21978: Add support for middle name This patch adds the new 'Middle name' field to the patron record. To test: 1) Apply patches 2) Update database, restart all and clear the browser cache 3) Load a patron in the staff module 4) Confirm you can see and edit the new 'Middle name' field 5) Confirm the new middle name data displays on patron details 6) Confirm the new middle name data displays on patron search results 7) Confirm the new middle name data displays everywhere patron names are displayed. 8) Confirm the new middle name data displays on the OPAC 9) Confirm the 'Middle name' field appears in the OPAC borrower modification screens 10) Edit sysprefs `BorrowerMandatoryFields`, `BorrowerUnwantedFields`, `SelfModificationBorrowerUnwantedField`, `PatronSelfModificationMandatoryField`, `PatronSelfRegistrationBorrowerMandatoryField` and `PatronSelfRegistrationBorrowerUnwantedField` to confirm you can make the new field required or hidden. 11) Verify that DefaultPatronSearchFields contains the new field if you already had 'firstname' in the field list 12) Enable PatronAutoComplete system preference 13) Type patrons surname into checkout or patron search but don't hit return 14) Confirm the patrons middle name is displayed in the preview 15) Go to tools > patron lists and attempt to add a patron to a list 16) Patrons middle name should appear in the autocomplete here too Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #98 from Jonathan Druart --- Created attachment 135181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135181=edit Bug 21978: Add middle_name to api specification This patch adds middle_name to the accaeptable fields in API requests and responses. Test plan 1) Search for a user using the API 2) Confirm the API responds with a 200 Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Jonathan Druart changed: What|Removed |Added Attachment #135147|0 |1 is obsolete|| Attachment #135148|0 |1 is obsolete|| Attachment #135149|0 |1 is obsolete|| Attachment #135150|0 |1 is obsolete|| Attachment #135151|0 |1 is obsolete|| Attachment #135152|0 |1 is obsolete|| Attachment #135153|0 |1 is obsolete|| Attachment #135154|0 |1 is obsolete|| Attachment #135155|0 |1 is obsolete|| --- Comment #97 from Jonathan Druart --- Created attachment 135180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135180=edit Bug 21978: Add middle_name field to the database This patch adds a new field, middle_name, to the borrowers, deletedborrowers and borrower_modifications tables. It also updates the DefaultPatronSearchFields preference to include the new field if the preference is still set to it's default settings from install. Sponsored-by: Cheshire Libraries Signed-off-by: Sally Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #112 from David Cook --- (In reply to Julian Maurice from comment #111) > Not in production, but I'm using it daily for development since more than a > year now. The only problems I have is when `fork` is used. Oh that's cool. Yeah, same problem as the Starman then too. Slowly but surely the task queue should eliminate that problem. > If you want to try, there are Docker images here: > https://hub.docker.com/r/julianmaurice/koha and you can find a > docker-compose.yml at https://github.com/jajm/koha-docker/tree/master/master I'm intrigued but I'm pretty invested in sticking to the mainstream :/. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30802] numReturnedItemsToShow doesn't show more than 20 items on the return screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail.
||com
--- Comment #1 from Jonathan Druart ---
Indeed, there is a 20 hardcoded somewhere else...
A possible fix could be
diff --git a/circ/returns.pl b/circ/returns.pl
index e2d2317a37a..ee874864d05 100755
--- a/circ/returns.pl
+++ b/circ/returns.pl
@@ -94,6 +94,7 @@ my $userenv_branch = $userenv->{'branch'} // '';
my $forgivemanualholdsexpire = $query->param('forgivemanualholdsexpire');
my $overduecharges = (C4::Context->preference('finesMode') &&
C4::Context->preference('finesMode') eq 'production');
+my $numReturnedItemsToShow = (
C4::Context->preference('numReturnedItemsToShow') ) ?
C4::Context->preference('numReturnedItemsToShow') : 8;
# Set up the item stack
my %returneditems;
@@ -104,7 +105,7 @@ foreach ( $query->param ) {
my $counter;
if (/ri-(\d*)/) {
$counter = $1;
-if ($counter > 20) {
+if ($counter > $numReturnedItemsToShow) {
next;
}
}
@@ -645,14 +646,13 @@ foreach my $code ( keys %$messages ) {
$template->param( errmsgloop => \@errmsgloop );
#set up so only the last 8 returned items display (make for faster loading
pages)
-my $returned_counter = ( C4::Context->preference('numReturnedItemsToShow') ) ?
C4::Context->preference('numReturnedItemsToShow') : 8;
my $count = 0;
my @riloop;
my $shelflocations =
{ map { $_->{authorised_value} => $_->{lib} }
Koha::AuthorisedValues->get_descriptions_by_koha_field( { frameworkcode => '',
kohafield => 'items.location' } ) };
foreach ( sort { $a <=> $b } keys %returneditems ) {
my %ri;
-if ( $count++ < $returned_counter ) {
+if ( $count++ < $numReturnedItemsToShow ) {
my $bar_code = $returneditems{$_};
if ($riduedate{$_}) {
my $duedate = dt_from_string( $riduedate{$_}, 'sql');
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30747] Column settings on otherholdings table in detail.tt doesnt work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30747 Jonathan Druart changed: What|Removed |Added Keywords||rel_22_05_candidate --- Comment #10 from Jonathan Druart --- Lucas, adjust the naming for "item" then we are good to go here. Any other improvements must go on its own bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 Jonathan Druart changed: What|Removed |Added Version|20.11 |unspecified Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart --- To test that a subroutine call does not produce a warning you should use warning_is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30725] BatchDeleteItem job param named wrongly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 --- Comment #2 from Fridolin Somers --- Then do the same with BatchUpdateItem I bet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30725] BatchDeleteItem job param named wrongly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 Fridolin Somers changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30725] BatchDeleteItem job param named wrongly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 --- Comment #1 from Fridolin Somers --- Created attachment 135179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135179=edit Bug 30725: Rename BatchDeleteItem job param from record_ids to item_ids It is clearly a copy and paste error, but the parameter is called 'record_ids' when it should be 'item_ids'. Test plan : Run prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Perform a batch items deletion via staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30725] BatchDeleteItem job param named wrongly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 Fridolin Somers changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30725] BatchDeleteItem job param named wrongly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 Fridolin Somers changed: What|Removed |Added Depends on||28445 CC||fridolin.som...@biblibre.co ||m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 [Bug 28445] Use the task queue for the batch delete and update items tool -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28445] Use the task queue for the batch delete and update items tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445 Fridolin Somers changed: What|Removed |Added Blocks||30725 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30725 [Bug 30725] BatchDeleteItem job param named wrongly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 --- Comment #3 from Fridolin Somers --- Created attachment 135178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135178=edit Bug 30781: Fix warning in GetPreparedLetter Test by running : prove t/db_dependent/Letters.t Check you dont see warning : Use of uninitialized value $val in substitution iterator -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 --- Comment #2 from Fridolin Somers --- Created attachment 135177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135177=edit Bug 30781: Add unit test for substitute with undefined value Add unit test that generates warn. This may be usefull as no regression test. Run prove t/db_dependent/Letters.t You see warn : t/db_dependent/Letters.t .. 1/84 Use of uninitialized value $val in substitution iterator at /kohadevbox/koha/C4/Letters.pm line 607. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 Fridolin Somers changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 Fridolin Somers changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30781] Use of uninitialized value $val in substitution iterator at /usr/share/koha/lib/C4/Letters.pm line 665.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30781 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30729] Template toolkit comments are caught in the translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30729 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30795] Configure unwanted and mandatory borrower fields based on patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30795 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #1 from Fridolin Somers --- +1 Makes sens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30797] Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30797] Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30776] import_webservice_batch.pl cronjob completely broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30776 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30776] import_webservice_batch.pl cronjob completely broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30776 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30735] Filtering by patron attribute with AV does not work in overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30735 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30735] Filtering by patron attribute with AV does not work in overdues report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30735 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30714] Checkins from other branches spam the cataloguing log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 --- Comment #10 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30714] Checkins from other branches spam the cataloguing log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30640] Focus does not always move to correct search header form field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30640 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30640] Focus does not always move to correct search header form field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30640 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30009] Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30009 --- Comment #12 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30009] Records with invalid MarcXML show notes tab 'Descriptions(1)' but tab is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30009 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30774] Typo: i %sEdit %sReserve %s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30774 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #6 from Fridolin Somers --- VIM did it ^^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30714] Checkins from other branches spam the cataloguing log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30714 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin Somers --- This also rises again the need to separate biblio cataloguing logs from items cataloguing logs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Aleisha Amohia changed: What|Removed |Added Attachment #135174|0 |1 is obsolete|| --- Comment #12 from Aleisha Amohia --- Created attachment 135176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135176=edit Bug 30700: (follow-up) Add system preference StaffLoginResetPassword This syspref wraps around the functionality added for patrons with the 'catalogue' permission to reset their own password via the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27770] ES: Deprecated aggregation order key [_term] used, replaced by [_key]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27770 --- Comment #20 from wainuiwitikap...@catalyst.net.nz --- Backported to 19.11.x for 19.11.30 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30212] Make Select2 available for ILL backend developers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30212 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #9 from wainuiwitikap...@catalyst.net.nz --- Does this need to be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30199] self checkout login by cardnumber is broken if you input a non-existent cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30199 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #21 from wainuiwitikap...@catalyst.net.nz --- Does this need to be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #12 from wainuiwitikap...@catalyst.net.nz --- Does this need to be backported to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28556] Make guarantor information available in notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28556 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #3 from Lucas Gass --- When I set my guarantor as a Non-patron guarantor and run the overdue_notices cron the job fails and I get this error: Can't call method "unblessed" on an undefined value at /kohadevbox/koha/C4/Letters.pm line 652 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30802] New: numReturnedItemsToShow doesn't show more than 20 items on the return screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30802 Bug ID: 30802 Summary: numReturnedItemsToShow doesn't show more than 20 items on the return screen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The system preference numReturnedItemsToShow says "show the XX last returned items on the checkin screen". The default value is 20. If you put a value < 20, it affects the returns.pl table. But if you put a value > 20 in the syspref, the table on returns.pl shows a maximum of 21 items. To test: 1- Make lots of checkouts, at least like 40 (I used the batchCheckouts feature) 2- Go to Circulation > Check in 3- Return 21 items The last 20 items returned will be displayed 4- Change numReturnedItemsToShow to 50 5- Return a couple more items Only the last 21 returned items are displayed 6- Change numReturnedItemsToShow to 10 7- Return a couple more items Only the last 10 returned items are displayed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30458] Librarian ( manager_id ) not included in accountline when using "Payout amount" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30458 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- When I do steps 1-3 I do see a manager_id without this patch. Here is what I am doing when I look: select manager_id from accountlines where debit_type_code = 'PAYOUT'; Am I doing something wrong? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||lu...@bywatersolutions.com --- Comment #15 from Lucas Gass --- Hi Alex, it looks like there is a small conflict in sample_notices.yml in current master. Can this be rebased? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- I love consistency for terminology, so this is great! I have two suggestions to move the "Show/Don't show" options to the start of the system preference text, rather than at the end, to be as consistent as possible with how it is used elsewhere: - noItemTypeImages: . Updated text: Show itemtype icons in the staff interface: Show/Don't show . Change to: Show/Don't show itemtype icons in the staff interface. - OpacNoItemTypeImages: . Updated text: Show itemtype icons in the OPAC: Show/Don't show . Change to: Show/Don't show itemtype icons in the OPAC. I'll also add to the terminology list: https://wiki.koha-community.org/wiki/Terminology -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23919] Make ISSN searchable with and without hyphen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23919 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #16 from Lucas Gass --- Hello Slava, Do you have a test plan we can use when trying this patchset? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30684] koha-* scripts --restart should start even when not running
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684 --- Comment #13 from Alex Buckley --- (In reply to Marcel de Rooy from comment #12) > (In reply to Alex Buckley from comment #11) > > Please correct me if I'm misunderstanding, but I should amend the files > > below, making the restart function in each stop and then start the service? > > > > - koha-indexer > > - koha-sip > > - koha-worker > > - koha-z3950-responder > > - koha-zebra > > Yes, please. > > > Also, do you think I should still write to the mailing list to see if there > > is a broader community consensus, or just proceed with the above? > > I would say that it does not hurt to do so. It might even trigger a quick > signoff. Sure thing, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30797] Subfields linked to the dateaccessioned.pl value builder on addbiblio.pl throw a JS error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30797 --- Comment #6 from Alex Buckley --- Thank you Marcel and Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Lucas Gass changed: What|Removed |Added Attachment #135145|0 |1 is obsolete|| --- Comment #4 from Lucas Gass --- Created attachment 135175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135175=edit Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29012] Some rules are not saved when left blank while editing a 'rule' line in smart-rules.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29012 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Lucas Gass --- This patchset doesn't apply cleanly to current master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Aleisha Amohia changed: What|Removed |Added Attachment #135087|0 |1 is obsolete|| --- Comment #11 from Aleisha Amohia --- Created attachment 135174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135174=edit Bug 30700: (follow-up) Add system preference StaffLoginResetPassword This syspref wraps around the functionality added for patrons with the 'catalogue' permission to reset their own password via the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Aleisha Amohia changed: What|Removed |Added Attachment #134772|0 |1 is obsolete|| --- Comment #10 from Aleisha Amohia --- Created attachment 135173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135173=edit Bug 30700: Allow staff users to change their password via staff client Patrons who can log into the staff client (have the 'catalogue' permission) should be able to change their own password. To test: 1) Create a user with only 'catalogue' permissions (Patron A) 2) Log in to the staff client as Patron A 3) Click the menu with your username in the top-right of the window. Click the 'your account' menu link. 4) Confirm you are forced to a login screen, so you cannot view your account, which is where the 'change password' link is normally found. 5) Try to access the page to change your password directly http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=X (swap Patron A's borrowernumber in). Confirm you are forced to a login screen. 6) Apply this patch and restart services. Go back to the mainpage logged in as Patron A. 7) Click the menu with your username in the top-right of the window. Notice there is now a 'Change password' menu link. Go to 'change password'. 8) Confirm you are now shown a page to change your password. Change your password, and confirm you are redirect to the mainpage. 9) Try to access the page to change someone else's page directly http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=X (swap some other borrowernumber in). Confirm you are redirected to a 404. 10) Log out and log back in as your original borrower. Confirm you are able to change your password as normal. Sponsored-by: Education Services Australia SCIS Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29260] UNIMARC 210a is reported to Autor (meeting/conference) when upgrading an authority through Z3950
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29260 David Nind changed: What|Removed |Added Text to go in the||This fixes UNIMARC release notes||authority editing when ||using 'Replace record via ||Z3950/SRU search'. When ||pre-populating the search ||form the value of 210$a ||(Authorized Access Point - ||Corporate Body Name) now ||goes into the Author ||(corporate) search form ||field instead of Author ||(meeting / conference). CC||da...@davidnind.com --- Comment #3 from David Nind --- Testing notes: - When using koha-testing-docker, an example of an authority record to use that has a 210$a is école camps Major (#3650). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29260] UNIMARC 210a is reported to Autor (meeting/conference) when upgrading an authority through Z3950
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29260 David Nind changed: What|Removed |Added Attachment #126417|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 135172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135172=edit Bug 29260: 210a is reported to Autor (meeting/conference) when upgrading an authority through Z3950 When upgrading an authority with Z39.50, the field 2XX is sent into the research grid. The field 210a is sent into the search field "Author (meeting/conference)". Or a collective authority is more often a corporation than and meeting so librarian has to copy and paste this data. (In unimarc field 210a is used both for corporation and meeting.) This patch makes 210a field be sent into the search field "Author (corporate)" instead of the "Author (meeting/conference)" one. 1- Find an authority with collectivity type (with a field 210a). 2- Click on "Edit" then on "Edit record" 3- Click on "Replace record via Z39.50/SRU search" 4- See that the field 210 is reported in the search grid in "Author (meeting/conference)" field 5- Apply the patch 6- Go throug step 1 to 3 again 7- See that the field 210 is now reported in the search grid in "Author (corporate)" field Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29260] UNIMARC 210a is reported to Autor (meeting/conference) when upgrading an authority through Z3950
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29260 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #20 from Tomás Cohen Arazi --- Ok, I submitted so y'all can see where this is headed to. What is done: - Circulation rules page setting the ability to request cancellation of waiting holds per library, category and item type. - Barebones, internals (db table, classes, tests, etc). All based on circ rules - OPAC handling for this - A mockup of how we would handle this in staff (see Holds awaiting pickup) The idea is that the new tab in 'Holds awaiting pickup' will provide buttons for accepting or rejecting the cancellation request. Once that's done, we should move into making some actions trigger acceptance/rejection automatically, if required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 135171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135171=edit Bug 22456: Staff interface handling WIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 135170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135170=edit Bug 22456: Allow requesting cancellation from the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 135169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135169=edit Bug 22456: Add cancellation request methods to Koha::Hold This patch adds the following helper methods for dealing with hold cancellation requests to the Koha::Hold class: * cancellation_requests * add_cancellation_request * cancellation_requestable_from_opac * cancellation_requested_by_owner To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 135168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135168=edit Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es) This patch adds the Koha::Object-derived classes for cancellation requests. Tests are added for the overloaded ->store method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold/CancellationRequest.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 135167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135167=edit Bug 22456: DBIC update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 135166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135166=edit Bug 22456: Add waiting_hold_cancellation circulation rule This patch adds handling for the waiting_hold_cancellation circulation rule. It is set no 'No' by default in the atomic update, if not previously set. Handling in the rules editor is added, in its own section. To test: 1. Apply this patch 2. Run: $ updatedatabase => SUCCESS: All good 3. Verify that the syspref is set: $ koha-mysql kohadev > SELECT * FROM circulation_rules WHERE rule_name='waiting_hold_cancellation'; => SUCCESS: Set to 0 4. Play with the rules editor, changing things back and forth, things should work, including library-specific and global/defualt settings. => SUCCESS: It works => SUCCESS: Texts are idiomatic 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30747] Column settings on otherholdings table in detail.tt doesnt work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30747
--- Comment #9 from Lucas Gass ---
(In reply to Fridolin Somers from comment #8)
> Hi, good catch
>
> +ids.forEach( function(item, index) {
>
> Ich, using 'item' for something else than catalogue (item of a biblio
> record) is not a good idea I think.
> Maybe 'table_id' would be better.
Yes, good point. I am still unsure how Jonathan and Marcel would like this
implemented. Will the forEach() work? If so, I will change item to something
better! Thanks Frido
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 135165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135165=edit Bug 22456: Add cancellation request table This patch adds a new table, for storing holds cancellation requests, and managing them afterwards. The *hold_id* attribute is not made a FK on the reserves table because of the old_reserves thing we still do (see bug 25260 for a discussion about it). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507 David Nind changed: What|Removed |Added Text to go in the||This enhancement for release notes||UNIMARC field 183 adds ||value builders for ||subfields $a and $2. These ||are based on the official ||UNIMARC codes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30507] Value builder for UNIMARC field 183
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30507 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind --- Patch doesn't apply 8-(.. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30507: Value builder for field 183 error: sha1 information is lacking or useless (cataloguing/value_builder/unimarc_field_182a.pl). error: could not build fake ancestor Patch failed at 0001 Bug 30507: Value builder for field 183 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506 David Nind changed: What|Removed |Added Attachment #135117|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 135164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135164=edit Bug 30506: Value builder for field 182 This patch provides values builders for the subfields $a, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 182 : it contains subfields $a, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $c and $2 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30506] Value builder for UNIMARC field 182
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30506 David Nind changed: What|Removed |Added Attachment #134430|0 |1 is obsolete|| --- Comment #7 from David Nind --- Comment on attachment 134430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134430 MT 35336: Value builder for field 182 I've obsoleted the MT 35336 patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504 David Nind changed: What|Removed |Added Attachment #135122|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 135163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135163=edit Bug 30504: Value builder for field 181 This patch provides values builders for the subfields $a, $b, $c and $2. Those are unimarc official codes who help to identify the kind of items Test plan: 1)Go to Home > Cataloging > New record 2)Section 1 - field 181 : it contains subfields $a, $b, $c & $2 3)Inputs are writable but notice that no plugins are suggested 4)Apply patch and repeat 1) to 3) 5)Values builders plugins are available for $a, $b, $c and $2 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30504] Value builder for UNIMARC field 181
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30504 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30747] Column settings on otherholdings table in detail.tt doesnt work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30747
Fridolin Somers changed:
What|Removed |Added
CC||fridolin.som...@biblibre.co
||m
--- Comment #8 from Fridolin Somers ---
Hi, good catch
+ids.forEach( function(item, index) {
Ich, using 'item' for something else than catalogue (item of a biblio record)
is not a good idea I think.
Maybe 'table_id' would be better.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25051] Elasticsearch truncates range searches when QueryAutoTruncate is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25051 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #8 from David Nind --- Testing notes (koha-testing-docker): - When testing, I was getting some "flaky" behaviour with new news items not displaying. - In the end, I emptied the additional_contents table (truncate additional_contents;) and started again. - I think the issue was the difference between the date on my computer (we are NZST - so date was 19 May 2022) compared with koha-testing-docker (UTC time 18 May 2022): news wasn't displaying in the OPAC and staff interface as the date of the news item was in the future (that is, the publication date had not yet been reached). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 David Nind changed: What|Removed |Added Attachment #135097|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 135162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135162=edit Bug 29828: Prevent additional content to be created without default When creating or editing an additional content, the form is submitted if only the title of the 'default' tab is filled in. We should submit the form only if both title and content exist. Test plan: Create a new content using text editor (codemirror) Confirm that the form is submitted only if title and content from the default tab are not empty Try again with wysiwyg (tinymce) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29828] If no content is added to default, but a translation, news/additional content entries don't show in list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29828 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 --- Comment #1 from Noémie Labine --- I get a result if I put a space between my last word and the “?” symbol, even tho there is no space in the title of the document. How come we have this issue with “?” but not with “!” ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884 Noémie Labine changed: What|Removed |Added CC||noemie.lab...@collecto.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #59 from Martin Renvoize --- All working well still.. added my SO lines to the subsequent patches that have come in :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Martin Renvoize changed: What|Removed |Added Attachment #135065|0 |1 is obsolete|| --- Comment #58 from Martin Renvoize --- Created attachment 135161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135161=edit Bug 25711: move get_effective_expire_charge to Koha::CirculationRules Move get_effective_expire_reserves_charge as a new method in Koha::CirculationRules to retrieve the effective value of the rule, which means it will get the value from existing circulation rule and if it doesn't exist or set to undefined it will get the default value from the preferences. Also added tests for this logic. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Martin Renvoize changed: What|Removed |Added Attachment #135064|0 |1 is obsolete|| --- Comment #57 from Martin Renvoize --- Created attachment 135160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135160=edit Bug 25711: fix existing tests and add new one Add a new test with circulation rule for library_C_code that has set expire_reserves_charge which is 0. In this case 0 should be used as the charge. Also use build_object instead of build to build the koha object. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Martin Renvoize changed: What|Removed |Added Attachment #135063|0 |1 is obsolete|| --- Comment #56 from Martin Renvoize --- Created attachment 135159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135159=edit Bug 25711: Wording 'use global' > 'Default' We use 'Default' for useDaysMode already Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Martin Renvoize changed: What|Removed |Added Attachment #135062|0 |1 is obsolete|| --- Comment #55 from Martin Renvoize --- Created attachment 135158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135158=edit Bug 25711: (QA follow-up) Move tests and disallow blank rule The tests can go where the existing cancellation charge tests are. If we define the default rule we do not need to delete all circulation rules as the itemtypes and branches are all created for the tests The rule should not be saved if blank, this allows simplifying the logic when getting the charge Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Martin Renvoize changed: What|Removed |Added Attachment #135061|0 |1 is obsolete|| --- Comment #54 from Martin Renvoize --- Created attachment 135157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135157=edit Bug 25711: (QA follow-up) Refactor to clarify logic At the point where 'ExpireReservesMaxPickUpDelayCharge' can/should kick in, we should already have an item waiting (else what's triggered a pickup delay). As such we can drop the fall through default of using the syspref when we don't yet have an item. We can also save us some calculations and database hits by only calculating the charge value when we've actually been asked to charge. So we also move the block inside the 'charge_cancel_fee' block. Signed-off-by: Martin Renvoize Signed-off-by: Petro Vashchuk Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25711] Move ExpireReservesMaxPickUpDelayCharge to the circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711
Martin Renvoize changed:
What|Removed |Added
Attachment #135060|0 |1
is obsolete||
--- Comment #53 from Martin Renvoize ---
Created attachment 135156
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135156=edit
Bug 25711: add ExpireReservesMaxPickUpDelayCharge to circulation rules
Add a feature that allows to define ExpireReservesMaxPickUpDelayCharge
in circulation rules per specific items/patron categories.
When value not found in circulation rules it uses global
ExpireReservesMaxPickUpDelayCharge, as it was before this smart-rules
feature was introduced.
To check the feature after applying the patch:
1) Go to /cgi-bin/koha/admin/preferences.pl and set
ExpireReservesMaxPickUpDelay to allow.
1) Go to /cgi-bin/koha/admin/smart-rules.pl circulation rules table
and notice the newly added "Expire reserve charge" row.
2) In that row add numerical values to type/patron categories
that you will be using later to test this feature.
3) Prepare an item for our next step, pick a biblio that has item
with the same item type you altered in smart rules and check it out.
3) Place a hold on that item and set the expiration date as the
next day.
4) Check in it after that.
5) Do SQL request to change expiration date manually to "yesterday":
in "reserves" table, find the id of the hold that you placed and
"UPDATE reserves SET `expirationdate`='2020-07-19' WHERE
`reserve_id`=329;"
Or alternatively:
5) Wait for tomorrow, change server time or invent a time machine.
6) Run cancel_expired_holds.pl cron job.
7) Check that patron got charged in "accounting" left tab and
"transactions" upper tab: your patron should have debt of that amount
of fee you assigned in that rule
(/cgi-bin/koha/members/boraccount.pl?borrowernumber=...YourPatronID...)
8) You can repeat this with other rules and different
numbers/biblio/item types to check that different fees apply according
to smart rules.
9) If there's no matching smart rule or smart rule have an empty
string as a fee - global ExpireReservesMaxPickUpDelayCharge variable
value will be used.
10) But in case if matching rule has zero ("0") as a value - that
allows to have no-fee smart-rule results, as a feature.
IMPORTANT:
Smart-rules filters only applied to item-level holds when item-type
for items is known. If there's biblio-level hold, in that case global
ExpireReservesMaxPickUpDelayCharge value will be used).
Mentored-by: Andrew Nugged
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30275] Checkout renewals should be stored in their own table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #96 from Martin Renvoize --- (In reply to Jonathan Druart from comment #83 and #84) * Spacing fixed and squashed * Indents fixed and squashed * Follow-up added to drop passing for holdfor_cardnumber. Original reason for keeping it was that I hadn't dug enough to spot if it was used more widely.. I've not done that digging and replaced the JS reference to it with the right placeholder too. * Follow-up added to fix atomicupdate to only use SQL where possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21978] Add middle name field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
