[Koha-bugs] [Bug 30885] Recall - detail page explosion

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||19532


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532
[Bug 19532] Recalls for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19532] Recalls for Koha

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||30885


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885
[Bug 30885] Recall - detail page explosion
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29815] Pre-populate 'Date acquired' field when adding/editing items

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||29963


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963
[Bug 29963] date picker automatically fills todays date on cataloging screens
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29963] date picker automatically fills todays date on cataloging screens

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||29815
 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #8 from Jonathan Druart  ---
You are then reverting
  commit bd197c64567fba6899f12e4897d786adf52384d8
  Bug 29815: Pre-populate 'Date acquired' field when adding/editing items


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29815
[Bug 29815] Pre-populate 'Date acquired' field when adding/editing items
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20988] [OMNIBUS] Internationalization: wrap all translatable text inside t() calls

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988

--- Comment #64 from Jonathan Druart  ---
(In reply to Victor Grousset/tuxayo from comment #63)
> Did you mean Joubu that in order to check, the wrapping script
> (https://github.com/jajm/koha-i18n) should be used on the syspref template.
> And then a global counter can be added in the t sub in
> Koha/Template/Plugin/I18N.pm ?

Yes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30733] Simplify translatable strings

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733

--- Comment #43 from Jonathan Druart  ---
I would suggest then to continue the work and go with spans here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30886] Recall status cannot be correct on opac-detail

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30886

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #135635|0   |1
is obsolete||

--- Comment #2 from Aleisha Amohia  ---
Created attachment 135636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135636=edit
Bug 30886: Show pending recall on item on OPAC

The 'completed' flag was causing the wrong status to be shown, but we
can also give a more useful message to the patron.

To test:
1) Enable the UseRecalls system preference and set up your
recalls-related circulation rules.
2) Check out an item to Patron B.
3) Log into the OPAC as Patron A and search for the item.
4) Place a recall on that item.
5) Go back to the staff client and check the item in. Confirm the recall
as waiting for Patron A.
6) Go back to the OPAC record page and look at the holdings table.
Notice the status still says the item is Available.
7) Apply patch, restart services, refresh the OPAC.
8) Confirm the holdings table status now says the item has a pending
recall.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30733] Simplify translatable strings

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733

--- Comment #42 from Victor Grousset/tuxayo  ---
Thanks for the feedback Julian and Jonathan :D

I'll 1st address the part about i18n TT functions.

(In reply to Julian Maurice from comment #39)
> Hey, have you heard about
> https://gitlab.com/koha-community/Koha/-/blob/master/docs/development/
> internationalization.md ? :-)

Of course I did :P , on Bug 29602 I pushed to use that instead of  but it
couldn't be done (more on that bellow) and nothing changed on the situation of
use of i18n TT functions so for this ticket I reluctantly used the same method
as bug 29602. Which I find cluttering so I would be happy to make a 180° turn
here and replace the ugly  with t().


(In reply to Jonathan Druart from comment #41)
> Yes, and what Julian said, the i18n TT functions are the way to go for
> complicated strings/structures.

Which couldn't be used for bug 29602 so I followed the same constraint here.

But you are the right person to clear the uncertainty about the used of i18n TT
functions because you raised the concern about them on bug 29602 comment 7

> IIRC there were perf issues

That question was hard to settle on bug 20988. Current state is that I'm not
sure what was the methodology you suggested to measure this accurately and
asked for confirmation.

So what is your current position? I guess it's because of the not that high
number of strings that performances aren't a worry here. But so was the case
for bug 29602.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17787] Hidden items included in count of search results

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Signed Off  |Failed QA

--- Comment #16 from Victor Grousset/tuxayo  ---
After testing many search terms to find a case that is closer to the original
report (multiple pages of results), here is one and it doesn't work.

== Test plan ==
1. Use sample data
2. Change OpacHiddenItems to «itype: [BK]»
3. Search in the OPAC for 'man'
4. 29 or 28 results depending on SearchEngine being Zebra of ElasticSearch
   Actually there are a handful of results on every page.
   Which is wrong because it shouldn't say 29 but around 10 and they should be
on one page
5. Apply patch and restart service
6. Redo the search
7. Number of hits should match the actual number and be on one page.

But last step doesn't happen with the current patch.

I found the reason:

comment 7:
> I worked around using [...]
> But this seems to base itself off the fact that our users will not notice 
> biased results counts if the results span over more than a page.

comment 11:
> my glitchy bugfix

So patch isn't ready, it was just a workaround solving part of the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #8 from David Cook  ---
+1 to hiding the indexing tasks from the general view

I don't know about deleting them immediately. On one hand, I'm in favour of
this and it would be useful for some other background tasks I have in mind
(like OAI-PMH harvesting of records). On the other hand, it does make it harder
to track background tasks when troubleshooting.

Could we hide them from the interface and then rely on cleanup_database.pl to
clean up the successful indexing tasks nightly? 

That way users don't see useless tasks, but administrators could double-check.

The other issue I see with this one is that the behaviour is encoded in
Koha/BackgroundJob/UpdateElasticIndex.pm specifically rather than in the
general task management. Doesn't that open up the door for inconsistent
behaviours among different background jobs? 

Not opposed to the current patch. Just asking some questions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20065] Perennial or persistent identifier implementation

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20065

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21366] add plack reload

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366

--- Comment #10 from David Cook  ---
(In reply to Andreas Jonsson from comment #8)
> Would it be too risky to send a HUP-signal to the plack process
> automatically when a plugin is reuploaded?
> 
> I think that this would be very nice, as it would make plugins upgradable
> without command line access.

I've opened bug 30897 for this one but it's easier said than done...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30897] Gracefully reload Koha after plugin install/upgrade

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897

David Cook  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
   ||, k...@bywatersolutions.com

--- Comment #1 from David Cook  ---
We should be able to just run:

kill('HUP',$starman_master_pid);

However, the tough part is getting $starman_master_pid. As a human, I know the
PID for kohadev is stored at /var/run/koha/kohadev/plack.pid but Koha itself
doesn't know that.

The "koha-plack" script defines the PIDFILE like so:

local PIDFILE="/var/run/koha/${instancename}/plack.pid"

--

I suppose another option might be to invoke "koha-plack --reload
$instance_name" (after bug 
21366), but that would assume that it's a Debian package installation and that
we have the $instance_name, which we also don't have.

--

I suppose the other thing is that this would be Starman specific. I don't know
how it would work with Hypnotoad for instance. 

Based on https://metacpan.org/pod/Mojo::Server::Hypnotoad#MANAGER-SIGNALS it
looks like it's graceful restart is done via the USER2 signal rather than the
HUP signal.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21366] add plack reload

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30897

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30897] Gracefully reload Koha after plugin install/upgrade

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21366

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30897] New: Gracefully reload Koha after plugin install/upgrade

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30897

Bug ID: 30897
   Summary: Gracefully reload Koha after plugin install/upgrade
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Plugin architecture
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

When a plugin is installed/upgraded, it would be good to send a SIGHUP to the
Starman master, so that Koha will gracefully restart itself. 

As Kyle noted on the listserv, it is especially useful for plugins that add API
routes, since the API can't use those until Starman workers are restarted.

By doing a graceful restart, no active HTTP requests are interrupted.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30684] koha-* scripts --restart should start even when not running

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684

David Cook  changed:

   What|Removed |Added

 Blocks|21366   |
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21366


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
[Bug 21366] add plack reload
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21366] add plack reload

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366

David Cook  changed:

   What|Removed |Added

 Depends on|30684   |
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30684


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684
[Bug 30684] koha-* scripts --restart should start even when not running
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30887] Gravestone page for deleted authorities or biblios

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30887

--- Comment #2 from David Cook  ---
It's an interesting idea. 

I first bumped into it using Fedora 4.x where they have a similar tombstone
concept: https://wiki.lyrasis.org/pages/viewpage.action?pageId=34649759

Maybe we could have a system preference to show a tombstone page if there is an
entry in the deletedbiblio table and we could return a status of "410 Gone". 

That seems like a pretty straightforward solution to me. 

I think having a system preference is probably a good idea as people might rely
on the current behaviour... which actually redirects to 404.pl with a status of
200. Huh. That's not so great either...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30888] Add a table for deletedauthorities

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30888

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #17 from David Cook  ---
(In reply to David Cook from comment #16)
> I think that would maek sense since what we're really trying to do here is
> "get_enabled_plugins_with_method", right?

Actually, why not create "get_enabled_plugins_with_method"? 

We store the methods in a table too, so you could fetch all enabled plugins for
method X, and then cache those plugins.

That way, you're just caching a list of plugins for methods that are used. That
means every call of "$_->can($method)" *should* be true, so there should be no
wasted loops.

That said, you could wind up with multiple plugin objects in different cached
hash maps. I suppose you could work around that by having 2 cached hash maps. 

But I suppose that's growing in complexity. 

Anyway just my two cents.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29672] Increase performance of Koha::Plugins->call

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29672

--- Comment #16 from David Cook  ---
I like the concept.

A few questions:

1) Why does get_enabled_plugins return the array rather than an array
reference? (I suppose it might not matter much since the array will just be a
list of references itself, but it just seems less efficient.)

2) Each Koha::Plugins->call() loops through the plugin list checking the
methods available. If there is a large plugin list, this will scale linearly
and be progressively slower. 

Since we're already looping through the plugins in get_enabled_plugins, it
could be a good idea to do that method check at the same time and build a hash
map of methods to plugins. (The downside is that you'd have to pre-check all
methods rather than lazily check just the methods you're demanding at method
call time, but that expense would be 1 time rather than N times.)

I think that would maek sense since what we're really trying to do here is
"get_enabled_plugins_with_method", right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30886] Recall status cannot be correct on opac-detail

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30886

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||alei...@catalyst.net.nz
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30886] Recall status cannot be correct on opac-detail

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30886

--- Comment #1 from Aleisha Amohia  ---
Created attachment 135635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135635=edit
Bug 30886: Show pending recall on item on OPAC

The 'completed' flag was causing the wrong status to be shown, but we
can also give a more useful message to the patron.

To test:
1) Enable the UseRecalls system preference and set up your
recalls-related circulation rules.
2) Check out an item to Patron B.
3) Log into the OPAC as Patron A and search for the item.
4) Place a recall on that item.
5) Go back to the staff client and check the item in. Confirm the recall
as waiting for Patron A.
6) Go back to the OPAC record page and look at the holdings table.
Notice the status still says the item is Available.
7) Apply patch, restart services, refresh the OPAC.
8) Confirm the holdings table status now says the item has a pending
recall.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30886] Recall status cannot be correct on opac-detail

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30886

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30850] Add default mapping for biblio.author to 110$a (MARC21)

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30850

--- Comment #12 from David Nind  ---
I have signed-off the dbrev patch (using koha-testing-docker). The instructions
worked (see note) for updating an existing installation:

1. Apply patches.
2. Run updatedatabase, flush_memcached, and restart_all.
3. Add mapping for 110$a to biblio.author (Administration > Koha to MARC
mapping).
4. Run ./misc/batchRebuilBiblioTables.pl -c (see note).

Note:

- I encountered this error message with the KTD sample data when running
./misc/batchRebuilBiblioTables.pl -c

  C4::Biblio::_koha_modify_biblioitem_nonmarc(): DBI Exception: DBD::mysql::st
execute failed: Data too long for column 'lccn' at row 1 at
misc/batchRebuildBiblioTables.pl line 71

- I have logged bug 30896 for this.

- To get around the error, I used Tools > Batch item modification to delete the
LCCN data in 010 (created report to list all the record numbers, added MARC
modification templates to delete fields 010 $8 $a $b $z, ran batch record
modification).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30896] New: Running misc/batchRebuildBiblioTables.pl -c fails with error "Running Data too long for column 'lccn'"

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30896

Bug ID: 30896
   Summary: Running misc/batchRebuildBiblioTables.pl -c fails with
error "Running Data too long for column 'lccn'"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: da...@davidnind.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The command line script misc/batchRebuildBiblioTables.plcommand is used after
updating Koha to MARC mappings (Administration > Catalog > Koha to MARC
mappings).

Running misc/batchRebuildBiblioTables.pl -c from the command line (to rebuild
the Koha to MARC mappings) with the sample data in koha-testing-data generates
this error message:

C4::Biblio::_koha_modify_biblioitem_nonmarc(): DBI Exception: DBD::mysql::st
execute failed: Data too long for column 'lccn' at row 1 at
misc/batchRebuildBiblioTables.pl line 71

To replicate (when using koha-testing-docker and the sample data):

1. From the command line run ./misc/batchRebuildBiblioTables.pl -c
2. Error occurs:
   C4::Biblio::_koha_modify_biblioitem_nonmarc(): DBI Exception: DBD::mysql::st
execute failed: Data too long for column 'lccn' at row 1 at
misc/batchRebuildBiblioTables.pl line 71

I identified this when testing bug 30850 (I worked around the issue by using
Tools > Batch item modification to delete the LCCN data in 010: created report
to list all the record numbers, added MARC modification templates to delete
fields 010 $8 $a $b $z, ran batch record modification).

I'm not sure whether this is a problem with the table structure, or whether in
real life you would have to identify and fix the problematic data for 010.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

--- Comment #7 from Lucas Gass  ---
Created attachment 135634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135634=edit
Bug 25267: (follow-up) Improve title text responsiveness

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23334] Modal window for Z3950 search

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23334

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30850] Add default mapping for biblio.author to 110$a (MARC21)

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30850

David Nind  changed:

   What|Removed |Added

 Attachment #135588|0   |1
is obsolete||

--- Comment #11 from David Nind  ---
Created attachment 135633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135633=edit
Bug 30850: dbrev to inform existing users of the mapping change

This patch adds a message in a dbrev to inform users of existing
installations that they might want to add a mapping from 110$a to
biblio.author

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30850] Add default mapping for biblio.author to 110$a (MARC21)

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30850

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

Lucas Gass  changed:

   What|Removed |Added

 Attachment #114242|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

--- Comment #6 from Lucas Gass  ---
Created attachment 135632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135632=edit
Bug 25267: Impove shelf browser responsiveness

Test plan:
1. Turn on  OPACShelfBrowser.
2. If youre using test data you will have to give some items call numbers. I
did: update items set itemcallnumber = 'acallnumber';
3. It will also be best if you add some cover images.
4. Go to an item detail page and Browse Shelf.
5. The feature looks good until the viewport is about 1700px or less.
6. Apply patch
7. Regenerate OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)
8. Try the shelf browse at all screen sizes and make sure everything still
works.
9. Test the controls (previous, next, and close), make sure they still work

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25267] OPAC browse shelf feature is not responsive

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25267

Lucas Gass  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30876] recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30876

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
 QA Contact|testo...@bugs.koha-communit |alei...@catalyst.net.nz
   |y.org   |
 Status|Signed Off  |Passed QA

--- Comment #8 from Aleisha Amohia  ---
Code looks good, patch works, tests happy, passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30885] Recall - detail page explosion

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
 CC||alei...@catalyst.net.nz
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30885] Recall - detail page explosion

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885

--- Comment #1 from Aleisha Amohia  ---
Created attachment 135631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135631=edit
Bug 30885: Display recall data correctly

This page does not pull the recall columns correctly.

To test:
1) Enable the UseRecalls system preference and set up your
recalls-related circulation rules.
2) Check out an item to Patron B.
3) Log into the OPAC as Patron A and search for the item.
4) Place an item-level recall on that item.
5) Go back to the OPAC and search for the item. Confirm that when you go
to the record detail page, it explodes and errors are shown.
6) Apply patch and refresh page.
7) Confirm page loads as expected.
8) Check the Status information for the item in the Holdings table.
Confirm it shows the recall information correctly.
9) Check in the item and confirm the recall as waiting for Patron A.
10) Go back to the record detail page and confirm the Status information
for the item shows as Waiting in the Holdings table.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30885] Recall - detail page explosion

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30895] New: Electronic acknowledgement for certain loans

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30895

Bug ID: 30895
   Summary: Electronic acknowledgement for certain loans
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

It would be beneficial to libraries that loan non-traditional items that carry
some risk, such as in a library of things that loans tools, for example, to
have some form of electronic acknowledgement of the risk and waiving rights
associated with said risks.

In particular, it would be great if there were some way to create a Patron
Attribute Type that the patron has the ability to check or fill out, that would
allow the loan of the above items.

So, in general, if this patron attribute type is filled out or checked,
specific circulation rules go into affect and allow the patron to check out or
place on hold specified items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30177] When changing patron categories of existing accounts it should not reset message prefs without warning

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30302] Include subtitle in fields searched by Title in serials

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30302
Bug 30302 depends on bug 30205, which changed state.

Bug 30205 Summary: Add biblio.subtitle to the subscription-detail.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30205] Add biblio.subtitle to the subscription-detail.pl page

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30205

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30107] When editing a desk, the currently logged in library is selected

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30346] Editing circ rule with Overdue fines cap (amount) results in data loss and extra fines

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30346

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldoldstable  |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28872] AcquisitionLog, NewsLog, NoticesLog should use 1/0 for their values

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28872
Bug 28872 depends on bug 26205, which changed state.

Bug 26205 Summary: News changes aren't logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28717] NewsLog doesn't work

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28717
Bug 28717 depends on bug 26205, which changed state.

Bug 26205 Summary: News changes aren't logged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26205] News changes aren't logged

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26205

Lucas Gass  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30234] Serial local covers do not appear in the administrative interface, unless their home library is the same as the one selected by the user upon entry.

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30234

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #18 from Lucas Gass  ---
(In reply to Jonathan Druart from comment #16)
> Hum I found a bug but it's not exactly what you are describing. Can you try
> the patch and see if it fixes your problem?

Jonathan, your fix seems similar to the problem describe in Bug 30792. Do you
think these are duplicate issues?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30894] New: Add ability to select all/clear all and delete selected label batches

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30894

Bug ID: 30894
   Summary: Add ability to select all/clear all and delete
selected label batches
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When managing label batches (label-manage.pl) it would be handy to be able to
select all/clear all label batches. 

It would also be nice if you could delete all selected batches instead of
having to go through your batches and delete them one at a time

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28642] Add IndependentBranches syspref to hide other items and libraries

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28642

Michael Hafen  changed:

   What|Removed |Added

 Attachment #134174|0   |1
is obsolete||

--- Comment #7 from Michael Hafen  ---
Created attachment 135630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135630=edit
Bug 28642: [master 2022-06-02] Expand IndependentBranches to hide others items 
and libraries

[master 2022-06-02]
Adds a system preference: IndependentBranchesHideOtherBranchesItems.
When on:
  All library select's will be limited to just the users library.
  Item lists in search results, title details, item details, holds, and exports
will only show items at the users library.

Test Plan:

Apply patch and run koha-upgrade-schema or manually create
IndependentBranchesHideOtherBranchesItems system preference.
Login with an account that is not Super Librarian.
Set the IndependentBranchesHideOtherBranchesItems system preference to yes.
On the Item Search page observe that only your library shows in the home and
current library fields.
On the Advanced Search page observe that only your library shows in the
location -> individual libraries field.
Search the catalog for a title with an item at your library and also at another
library.
Observe that you only see your library listed in the facets panel (Refine your
search -> Home Libraries section)
Observe that you only see the item at your library in the search results, title
details, MARC details, Items, Checkout history, and Edit Items pages.
On the title details page Save the title as a text format, for example MARCXML,
and observe that only item(s) at your library are in the export.
On the Place hold page, search for a patron and observe that only patrons at
your library are found.
After selecting a patron observe that only items at your library are displaed.
In the Circulation -> Overdues page observe that you only see items at your
library.
In the Check out quick search search for patrons.  Observe that only patrons at
your school are found unless you search by cardnumber.
On the Patrons page observe that only your library shows in the library field
of the search form.
In the Search Patrons tab of the quick search click the '+' to open the other
fields.  Observe that only your library shows in the Library field.
On the Modify Patron page (edit patron) observe that only your library shows in
the library field in the library management section.
In Serials start a new subscription and observe that only your library shows in
the library field.
In Serials -> Check expiration observe that only your library show in the
library field.
In Reports observe that only your library shows in the following reports:
Acquisitions statistics, Patrons statistics, Catalog statistics, Circulation
statistics, Serials statistics, Cash register statistics, Holds statistics,
Patrons with the most checkouts, Most-circulated items, Items with no
checkouts, Items lost, Catalog by item type, Average loan time.
In Suggestions observe that only your library shows in the library field on the
Suggestion management and New purchase suggestion pages.
In Tools -> Patron Lists when adding patrons to a list observe that only
patrons at your library are found by name.
In Patron Clubs observe that the library field only shows your library in the
Club Template and Club edit pages.
In Comments observe that only comments at your library are shown.
In Import Patrons observe that the library field in the defaults section only
shows your library.
In Batch patron modification observe that your library is the only library in
the library field.
In Batch item modification observe that your library is the only library in the
Home and Current library fields.
In Export data observe that only your library shows in the 'With items owned by
the following libraries' field and it is selected.
In Inventory observe that only your library shows in the library field.
In News observe that only your library shows in the library field in the Filter
on the home page and the Edit entry page.
Open the Opac and log in.
On the Advanced search page observe that your library is the only library in
the Location field.
Search for a title with items at multiple libraries.  Observe that only your
library shows in the libraries facets (refine your search).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #518 from Kyle M Hall  ---
Created attachment 135629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135629=edit
Bug 24857: DO NOT PUSH: Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #517 from Kyle M Hall  ---
Created attachment 135628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135628=edit
Bug 24857: Add object classes to Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #516 from Kyle M Hall  ---
Created attachment 135627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135627=edit
Bug 24857: Add new Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #515 from Kyle M Hall  ---
Created attachment 135626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135626=edit
Bug 24857: Delete item group when last item is deleted

To test:
1 - Find a record with an item gorup, or add a group
2 - Add an item to this group, ensure it is the only item in the group
3 - Delete the item
4 - Confirm the gorup was also deleted
5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #514 from Kyle M Hall  ---
Created attachment 135625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135625=edit
Bug 24857: Add ability to set item group when adding a new item

During cataloging a user may wish to add an item to a group when
creating a new item

This patch also copies the group description to the enumchron field

To test:
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group, or
create new
5 - Note when a group is selected the enumchron field is populated
6 - Confirm item is saved to group when saved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #135618|0   |1
is obsolete||
 Attachment #135619|0   |1
is obsolete||
 Attachment #135620|0   |1
is obsolete||
 Attachment #135621|0   |1
is obsolete||
 Attachment #135622|0   |1
is obsolete||
 Attachment #135623|0   |1
is obsolete||

--- Comment #513 from Kyle M Hall  ---
Created attachment 135624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135624=edit
Bug 24857: Add item group management to detail.pl

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableItemGroups
5) Browse to detail.pl for a record with items
6) Note the new Item Groups tab
7) Test creating, editing and deleting groups
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting an item group for items,
   and for clearing an item group for items.
9) Test adding and clearing the item group for items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #512 from Kyle M Hall  ---
Created attachment 135623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135623=edit
Bug 24857: DO NOT PUSH: Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #511 from Kyle M Hall  ---
Created attachment 135622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135622=edit
Bug 24857: Add object classes to Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #510 from Kyle M Hall  ---
Created attachment 135621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135621=edit
Bug 24857: Add new Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #509 from Kyle M Hall  ---
Created attachment 135620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135620=edit
Bug 24857: Delete item group when last item is deleted

To test:
1 - Find a record with an item gorup, or add a group
2 - Add an item to this group, ensure it is the only item in the group
3 - Delete the item
4 - Confirm the gorup was also deleted
5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #508 from Kyle M Hall  ---
Created attachment 135619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135619=edit
Bug 24857: Add ability to set item group when adding a new item

During cataloging a user may wish to add an item to a group when
creating a new item

This patch also copies the group description to the enumchron field

To test:
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group, or
create new
5 - Note when a group is selected the enumchron field is populated
6 - Confirm item is saved to group when saved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #507 from Kyle M Hall  ---
Created attachment 135618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135618=edit
Bug 24857: Add item group management to detail.pl

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableItemGroups
5) Browse to detail.pl for a record with items
6) Note the new Item Groups tab
7) Test creating, editing and deleting groups
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting an item group for items,
   and for clearing an item group for items.
9) Test adding and clearing the item group for items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #506 from Kyle M Hall  ---
Created attachment 135617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135617=edit
Bug 24857: Add Object Methods

To test:
1 - prove t/db_dependent/Koha/Biblio.t
2 - prove t/db_dependent/Koha/Item.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #505 from Kyle M Hall  ---
Created attachment 135616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135616=edit
Bug 24857: API spec

To test:
1 - prove t/db_dependent/api/v1/item_groups.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #504 from Kyle M Hall  ---
Created attachment 135615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135615=edit
Bug 24857: Add Koha Objects

To test:
1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #135601|0   |1
is obsolete||
 Attachment #135602|0   |1
is obsolete||
 Attachment #135603|0   |1
is obsolete||
 Attachment #135604|0   |1
is obsolete||
 Attachment #135605|0   |1
is obsolete||
 Attachment #135606|0   |1
is obsolete||
 Attachment #135607|0   |1
is obsolete||
 Attachment #135608|0   |1
is obsolete||
 Attachment #135609|0   |1
is obsolete||
 Attachment #135610|0   |1
is obsolete||

--- Comment #503 from Kyle M Hall  ---
Created attachment 135614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135614=edit
Bug 24857: Database updates

This adds the new tables, syspref, and a new permission

https://bugs.koha-community.org/show_bug.cgi?id=24860

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24860] Add ability to place item group level holds

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Kyle M Hall  changed:

   What|Removed |Added

Summary|Add ability to place volume |Add ability to place item
   |level holds |group level holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27704] Group locations for advanced search

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27704

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30892] Holds not getting placed

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30892

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30892] Holds not getting placed

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30892

Lucas Gass  changed:

   What|Removed |Added

 Attachment #135611|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 135613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135613=edit
Bug 30892: (bug 30742 follow-up) Send single bib as a holdable bib

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30892] Holds not getting placed

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30892

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30891] SMS provider shows on staff side even if SMS::Send driver is not set to "Email"

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891

Lucas Gass  changed:

   What|Removed |Added

 Attachment #135589|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 135612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135612=edit
Bug 30891: SMS provider shows on staff side even if SMS::Send driver is not set
to "Email"

It appears that in my original submission ( Bug 9021 ),
I hid the SMS provider selector unless the SMS::Send
driver was set to "Email", but only on the OPAC,
not on the staff interface!

Test Plan:
1) Set SMSSendDriver to anything except "Email"
2) Note the SMS Provider pulldown shows in the patron editor
3) Apply this patch
4) Reload the page, SMS Provider id should now be gone
5) Set SMSSendDriver to "Email"
6) Reload the page, SMS Provider should now be shown

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30891] SMS provider shows on staff side even if SMS::Send driver is not set to "Email"

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30891

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30892] Holds not getting placed

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30892

--- Comment #1 from Nick Clemens  ---
Created attachment 135611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135611=edit
Bug 30892: (bug 30742 follow-up) Send single bib as a holdable bib

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30892] Holds not getting placed

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30892

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30840] Add support for barcode filters to course reserves

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30840

--- Comment #4 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30840] Add support for barcode filters to course reserves

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30840

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756

--- Comment #13 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30756] Get skip block out of Koha_Authority.t and add TestBuilder

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30756

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29961] Horizontal scroll bar in acquisition z39.50 search should always show

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29961

--- Comment #5 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29961] Horizontal scroll bar in acquisition z39.50 search should always show

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29961

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29961] Horizontal scroll bar in acquisition z39.50 search should always show

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29961

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30893] New: typo: update_patrons_category.pl fine(s)

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30893

Bug ID: 30893
   Summary: typo: update_patrons_category.pl fine(s)
 Change sponsored?: ---
   Product: Koha
   Version: 21.05
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: n...@bywatersolutions.com
  Reporter: eve...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

in the SYNOPSIS and OPTIONS portions of update_patrons_category.pl, the options
fineover and fineunder do not match the GetOptions finesover and finesunder.
The shortened versions can be used, but the plural/not plural should be fixed. 

 -fo=X --fineover=X   update if fines over  X amount
 -fu=X --fineunder=X  update if fines under X amount

vs

 'fo|finesover=s'  => \$fine_min,
 'fu|finesunder=s' => \$fine_max,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30892] New: Holds not getting placed

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30892

Bug ID: 30892
   Summary: Holds not getting placed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

This seems to effect current master, but not 22.05.x

To test:
1. Try placing hold
2. Everything seems to work but no hold gets placed.


I am not finding anything in the error logs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30855] Rename /import => /import_batches

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30855

--- Comment #9 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30855] Rename /import => /import_batches

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30855

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27697] Opening bibliographic record page prepopulates search bar text

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27697

--- Comment #8 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27697] Opening bibliographic record page prepopulates search bar text

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27697

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #502 from Kyle M Hall  ---
Created attachment 135610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135610=edit
Bug 24857: DO NOT PUSH: Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #501 from Kyle M Hall  ---
Created attachment 135609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135609=edit
Bug 24857: Add object classes to Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #500 from Kyle M Hall  ---
Created attachment 135608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135608=edit
Bug 24857: Add new Schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #499 from Kyle M Hall  ---
Created attachment 135607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135607=edit
Bug 24857: Delete item group when last item is deleted

To test:
1 - Find a record with an item gorup, or add a group
2 - Add an item to this group, ensure it is the only item in the group
3 - Delete the item
4 - Confirm the gorup was also deleted
5 - prove t/db_dependent/Koha/Biblio/ItemGroups.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #498 from Kyle M Hall  ---
Created attachment 135606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135606=edit
Bug 24857: Add ability to set item group when adding a new item

During cataloging a user may wish to add an item to a group when
creating a new item

This patch also copies the group description to the enumchron field

To test:
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group, or
create new
5 - Note when a group is selected the enumchron field is populated
6 - Confirm item is saved to group when saved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #497 from Kyle M Hall  ---
Created attachment 135605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135605=edit
Bug 24857: Add item group management to detail.pl

Test Plan:
1) Apply the patches for this bug
2) Run updatedatabase.pl
3) Restart all the things!
4) Enable the new syspref EnableItemGroups
5) Browse to detail.pl for a record with items
6) Note the new Item Groups tab
7) Test creating, editing and deleting groups
8) On the Holdings tab, select one or more items using the checkboxes
8) Note new selection options for setting an item group for items,
   and for clearing an item group for items.
9) Test adding and clearing the item group for items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #496 from Kyle M Hall  ---
Created attachment 135604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135604=edit
Bug 24857: Add Object Methods

To test:
1 - prove t/db_dependent/Koha/Biblio.t
2 - prove t/db_dependent/Koha/Item.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #495 from Kyle M Hall  ---
Created attachment 135603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135603=edit
Bug 24857: API spec

To test:
1 - prove t/db_dependent/api/v1/item_groups.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #494 from Kyle M Hall  ---
Created attachment 135602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135602=edit
Bug 24857: Add Koha Objects

To test:
1 - prove t/db_dependent/Koha/Biblio/ItemGroups.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #135591|0   |1
is obsolete||
 Attachment #135592|0   |1
is obsolete||
 Attachment #135593|0   |1
is obsolete||
 Attachment #135594|0   |1
is obsolete||
 Attachment #135595|0   |1
is obsolete||
 Attachment #135596|0   |1
is obsolete||
 Attachment #135597|0   |1
is obsolete||
 Attachment #135598|0   |1
is obsolete||
 Attachment #135599|0   |1
is obsolete||
 Attachment #135600|0   |1
is obsolete||

--- Comment #493 from Kyle M Hall  ---
Created attachment 135601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135601=edit
Bug 24857: Database updates

This adds the new tables, syspref, and a new permission

https://bugs.koha-community.org/show_bug.cgi?id=24860

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #492 from Kyle M Hall  ---
Created attachment 135600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135600=edit
Bug 24857: DO NOT PUSH: Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

--- Comment #491 from Kyle M Hall  ---
Created attachment 135599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135599=edit
Bug 24857: Add object classes to Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >