[Koha-bugs] [Bug 30768] Typo: pin should be PIN

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768

--- Comment #2 from Michal Urban  ---
Created attachment 135788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135788=edit
Bug 30768: Capitalizing "pin" in 2FA setup

Change of text from "pin" to "PIN" in the 2FA setup interface.
This slight changes clarifies that "PIN" is an acronym, and increases user
comp>

To test:
1) Log in as an Administrator
2) Enable TwoFactorAuthentication
3) Log in to a user with superlibrarian permissions.
4) On the user profile page, click the "More" dropdown button, click "Manage
Tw>
5) Check that "pin" is displayed in lowercase, in both instances.
6) Apply patch.
7) Refresh the page and observe that "pin" has changed to "PIN"
8) Sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28787] Send a notice with the TOTP token

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #12 from David Cook  ---
(In reply to Martin Renvoize from comment #4)
> Hmm, I'm not so sure about this.. whilst I understand TOTP over SMS delivery
> makes sense as SMS is in theory immediate delivery.. Email has lots of
> caveats around delivery speed and so it's more common to send an HOTP or
> even a simple random string OTP in the email case due to the timeout factor?

I just signed up for a new system that uses OTP over email and it looks like
they've set their code expiry to 5 minutes. (They tell the user in the email of
that expiration time.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29782] Missing entries for display locations in HTML customizations

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782

--- Comment #4 from Fridolin Somers  ---
Still valid in master ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912

Robert Cooper  changed:

   What|Removed |Added

   Severity|critical|minor
  Component|Installation and upgrade|Database
   |(web-based installer)   |

--- Comment #1 from Robert Cooper  ---
Digging into this further, I found that the following was causing an error in
MySql v8 server:

ALTER TABLE user_permissions DROP INDEX IF EXISTS `PRIMARY`;

I have manually run the changes in the db fix file and the rest of the updates
using koha-upgrade-schema utility proceeded normally. I have updated the
details in my bug report, but I'm not sure what the process is for fixing this
further.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30917] Improve course reserves breadcrumbs

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30917

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #2 from David Nind  ---
When adding items:

1. [Course name] is in italics

2. Page title is: Add items > [Course name] > Course reserves > Koha

This is the same for batch add reserves.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889

--- Comment #8 from David Cook  ---
(In reply to Jonathan Druart from comment #5)
> Martin, Tomas, do you have opinion on how to fix this issue correctly?
> 
> The first patch is ugly but could work for backport.
> 

I think what you've done might be the only viable option at this point. Koha
relies a fair bit on global variables and (pseudo-)sessions.

I think you might not need to unset the userenv due to the forking but I would
have to double-check the code..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889

--- Comment #7 from David Cook  ---
Comment on attachment 135759
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135759
Bug 30889: Set userenv for background jobs

Review of attachment 135759:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=30889=135759)
-

::: misc/background_jobs_worker.pl
@@ +132,5 @@
> +);
> +$job->process( $args );
> +C4::Context->_unset_userenv(-1);
> +} ese {
> +$job->process( $args );

I don't think that you need to repeat $job->process($args). You can just do the
patron check and userenv around it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30923] OAuth2 implementation is not experimental

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30923

David Nind  changed:

   What|Removed |Added

   Keywords||Manual
 CC||da...@davidnind.com
  Text to go in the||This enhancement removes
  release notes||the [EXPERIMENTAL] text
   ||from the
   ||RESTOAuth2ClientCredentials
   ||system preference
   ||description. OAuth2 has
   ||been in use by third
   ||parties to securely
   ||interact with Koha since
   ||its introduction in 2018.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30889] Background jobs lead to wrong/missing info in logs

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30889

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #6 from David Cook  ---
(In reply to Jonathan Druart from comment #4)
> Created attachment 135760 [details] [review]
> Bug 30889: Set interface to 'intranet'
> 
> Is that correct?

It looks like 'interface' is a VARCHAR(30). I wonder if it's time to add an
interface beyond 'intranet' and 'opac'. 

Or if we care where the job comes from, I suppose that detail would need to be
passed with the job...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30923] OAuth2 implementation is not experimental

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30923

David Nind  changed:

   What|Removed |Added

 Attachment #135786|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 135787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135787=edit
Bug 30923: Remove EXPERIMENTAL mark on RESTOAuth2ClientCredentials

The feature is not experimental at all.

To test:
1. Search for the RESTOAuth2ClientCredentials syspref
=> FAIL: It says it is an experimental feature
2. Apply this patch and reload
3. Repeat 1
=> SUCCESS: No longer marked as experimental
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30923] OAuth2 implementation is not experimental

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30923

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30924] Recalls workflow - errors and issues: log viewer, patron details, transfers, cancelling once checked in (waiting for pickup)

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924

David Nind  changed:

   What|Removed |Added

 Blocks||29734


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734
[Bug 29734] [OMNIBUS] Recalls for Koha
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29734] [OMNIBUS] Recalls for Koha

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734

David Nind  changed:

   What|Removed |Added

 Depends on||30924


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924
[Bug 30924] Recalls workflow - errors and issues: log viewer, patron details,
transfers, cancelling once checked in (waiting for pickup)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30823] Recalls should use 'FILL' in action logs

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30823

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #5 from David Nind  ---
I tried to test, but I'm getting lots of errors with recalls BEFORE applying
the patch.

I've logged these as bug 30924

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30924] New: Recalls workflow - errors and issues: log viewer, patron details, transfers, cancelling once checked in (waiting for pickup)

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924

Bug ID: 30924
   Summary: Recalls workflow - errors and issues: log viewer,
patron details, transfers, cancelling once checked in
(waiting for pickup)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: da...@davidnind.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

I am getting several errors and issues when testing bug 30823 - BEFORE applying
the patch.

I thought these were fixed with some of the recent recalls bugs that were
pushed to master.

I'm not sure whether separate bugs are required, or just one to look at what is
causing these. In the interim, I've created this bug.

Scenario/settings using koha-testing-docker (up-to-date with master):
- UseRecalls system preference: set to 'Use'.
- RecallsLog system preference: set to 'Log'.
- Circulation and fines rules:
  . Recalls allowed (total) = 5
  . Recalls per record (count) = 2
  . On shelf recalls allowed = 'If any unavailable'
  . Recall due date interval (day) = 3
  . Recall overdue fine amount = 5
  . Recall pickup period (day) = 2
- Patron B: Mary Burton (Midway)
- Patron A: Henry Acevedo (Midway)
- Record used to place recalls on: Programming Perl (biblionumber = 262, one
item = 311418, home library = Centerville)

TLDR:
- Log viewer: Error on log viewer for recalls once there is are logged recalls
transactions
- Transfers for recalls: error on transfers to receive
- After check in and waiting for pickup: actions to cancel recall on several
pages do not work

Error 1: Setup and place a recall - log viewer error


I get this error using the log viewer limited to the recalls module - recall
placed, no other actions.

Template process failed: undef error - The method
Koha::Recall->item_level_recall is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Object.pm line 875
Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x55d076a68a48)') called at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line
379
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line
379
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line
409
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt line
18
Template::Provider::__ANON__('Template::Context=HASH(0x55d074a2b5f0)') called
at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line
161


Error 2: Viewing the check out page > checkouts tab for Mary - after recall
placed
~

No checkouts are listed, sits on "Loading... you may continue scanning" in a
floating box at the bottom of the page, with "Loading..." showing in the center
of the table. Does not show other items checked out.

The details page > checkouts tab is the same.

Error 3: If a transfer is required
~~

Step 1: Check in the item (311418) > Transfer to Midway required >
Confirm recall and transfer.
- Mary: checkouts list is now displaying
- Henry: recalls tab showing "In transit to Midway"
- Circulation > Recalls > Recalls queue: showing "In transit to Midway"
- Circulation > Recalls > Recalls to pull: listed with button to "Cancel recall
and return to: Centerville

Step 2: Transfer to Midway
- Change library to Midway
- Ciculation > Transfers > Transfers to receive: get this error:

Template process failed: undef error - The method Koha::Recall->borrowernumber
is not covered by tests!

Trace begun at /kohadevbox/koha/Koha/Object.pm line 875
Koha::Object::AUTOLOAD('Koha::Recall=HASH(0x559d07b59d00)') called at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt
line 93
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt
line 93
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt
line 108
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt
line 112
eval {...} at
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt
line 18


Step 3: Check in item (with library set to Midway)
- Modal window with "Recall at Midway + Confirm recall"
- Circulation > Recalls > Recalls awaiting pickup: listed
- Circulation > Transfers > Transfers to receive: no errors
- Record detail page in staff interface: showing as "Waiting at 

[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #19 from David Cook  ---
(In reply to Jonathan Druart from comment #17)
> Wouldn't it better to fetch the queued jobs only by default? Thinking about
> perfs if there are too many entries.

I was thinking about that as well. 

So long as there is a timestamp index, I reckon we show the queued jobs and
maybe the last 60 minutes of completed jobs (no indexing jobs though), and that
should be good?

A database admin or Reports user can look up indexing jobs more directly if
they want to double-check that the indexing is running correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963

--- Comment #26 from Katrin Fischer  ---
Hi,

the inconsistency that we discussed was that the same field should show the
same behaviour in all places where we can add items. These are:

* Adding items in serials
* Adding items in cataloguing
* Adding items in acquisitions

I believe that serials and acq use similar code, but the code for cataloguing
is different.

The issue as I understand it was the 'hidden' behaviour. People assumed that
leaving the field empty would mean 'no dateaccessioned' while Koha would
_always_ use today's date if left empty. Or they would feel a need to fill out
the field, when it was not necessary, adding extra steps.

I think reverting and adding a hint would actually be a good start.

Being context aware only pre-filling when the item is added/new would also be a
good compromise. I just wonder if it might upset people that do a lot of
cataloguing of items with past accession dates where it might feel like an
issue having to change the pre-filled value.

Also another thought pro hint: if we pre-fill, setting date-accessioned to
mandatory will have no effect/the warning will never trigger. This might be an
issue for libraries that want to make sure the date is verified manually.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904

--- Comment #4 from Janusz Kaczmarek  ---
Another possibility would be issuing search with three criteria instead of
find.  Maybe this would be simpler and still correct?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30922] moremember.pl column settings aren't working

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30919] Search on any order status

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30919

--- Comment #3 from Katrin Fischer  ---
I had to try different searches too, easier if you have seen the bug before!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904

--- Comment #3 from Janusz Kaczmarek  ---
(In reply to Jonathan Druart from comment #2)
> I am not expecting this patch to work correctly.
> You are removing branchcode from ->find, in my understanding ->find is
> expecting only 1 result to be returned and for that you have to pass either
> the PK or the unique key. branchcode is part of the unique key
> 
> UNIQUE KEY `additional_contents_uniq`
> (`category`,`code`,`branchcode`,`lang`),

Thank you, Jonathan, for your comment.

IMVHO, from the logical point of view, if the change of the
additional_contents.branchcode is possible by the design (exactly equal as it
is in the case of Display location = additional_contents.location),
additional_contents.branchcode should not be part of the unique key.  For
unambiguous identification of the row in question, category + code + lang is
enough (in fact, probably even code + lang would be enough, keeping in mind how
the data is generated). 

If I understand well, DBIx::Class::ResultSet->find would currently issue a
warning in case when the find query based on supplied criteria produced more
than one row.  This will never happen since—I think, you would agree–category +
code + lang would identify exactly one row (or no row) under each condition. 

Supplying four criteria to this find, i.e. category + code + lang + branchcode,
will result with empty result in case of a change made to the library.  This
will make $additional_content undef (line 116) and so we jump to the line 147,
with $code defined.  So we create a new set of news rows, sharing the old code.
 This results in severe data inconsistency.

Hence, the four columns as unique key should be considered superfluous and
incorrect.

To sum up—I would suggest considering the patch OK, but probably data
definition introduced by you with the commit
8df3116760bdf1b889dc6f78e4605e231c4d7d6d requires correction as well.  IMO,
UNIQUE KEY `additional_contents_uniq` (`category`,`code`,`lang`) would be
perfect. 

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23548] AQ field required in checkin response

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23548

--- Comment #9 from Martin Renvoize  ---
I'm convinced, and looked up the specs to confirm. Now we just need a unit test
to protect us from later regressions ;-).

Are you able to submit that, of should I add it to my list to try and get to
soon?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963

--- Comment #25 from Alex Buckley  ---
(In reply to Benjamin Daeuber from comment #24)
> > 
> > Going forward if there are concerns with the original patch changing the
> > behavior of one item form making it inconsistent with others in cataloguing
> > and acq. Then I think, instead of a behavior change, it should be sufficient
> > to add a hint saying that if you save the 952$d with nothing in it Koha will
> > still auto-populate the 952$d with today's date. Perhaps this is the most
> > straight forward solution?
> 
> I'm not sure I agree with this. I don't really see an issue with being
> context aware. Hints get missed with potentially far reaching consequences
> in the case of a batch edit. Logical, context aware behavior seems more user
> friendly. It makes sense to populate that field in the case of serials and
> new items, but not in the case of item edits. I don't really find that to be
> an inconsistent behavior.

Thanks for sharing your thoughts on this Benjamin. I think it could be helpful
to get Katrin's thoughts on the best approach because as Martin noted in
comment #18 she failed QA the original 29815 patch as it doesn't affect all
data entries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page.

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688

David Nind  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||da...@davidnind.com
 Status|Failed QA   |RESOLVED

--- Comment #33 from David Nind  ---
Recalls implemented in bug 19532 - changed status to resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30923] OAuth2 implementation is not experimental

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30923

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 CC||martin.renvoize@ptfs-europe
   ||.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30923] OAuth2 implementation is not experimental

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30923

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 135786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135786=edit
Bug 30923: Remove EXPERIMENTAL mark on RESTOAuth2ClientCredentials

The feature is not experimental at all.

To test:
1. Search for the RESTOAuth2ClientCredentials syspref
=> FAIL: It says it is an experimental feature
2. Apply this patch and reload
3. Repeat 1
=> SUCCESS: No longer marked as experimental
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30923] OAuth2 implementation is not experimental

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30923

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30923] New: OAuth2 implementation is not experimental

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30923

Bug ID: 30923
   Summary: OAuth2 implementation is not experimental
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: REST API
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
CC: tomasco...@gmail.com

We added a confusing warning on the sysprefs. OAuth2 has been used by third
parties to interact with Koha in a secure way since its introduction back in
2018.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30922] New: moremember.pl column settings aren't working

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30922

Bug ID: 30922
   Summary: moremember.pl column settings aren't working
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marie-luce.lafla...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

the Patron > moremember > issues-table are not applied correctly. If you hide
columns, hidden columns are still displayed in the relative's checkouts.

1. Go to admin > Table settings > Patron > moremember > issues-table
2. Hide few columns  (e.g. record_type)
3. Find a patron account
4. Checkout an item
5. Add a guarantee to this account
6. Check the "relatives' checkouts" tab
All the columns are still visible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30882] Add max_result_window to index config

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30882

--- Comment #11 from David Nind  ---
(In reply to Marcel de Rooy from comment #10)
> Thats a courageous change!

Fridolin is the courageous one!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813

--- Comment #39 from Nick Clemens  ---
Why add the qw(); to the use statements?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29805] Database update fails in MySQL 5.7 because it's missing REGEXP_REPLACE

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29805

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||n...@bywatersolutions.com

--- Comment #9 from Nick Clemens  ---
We tested this on a sandbox we were upgrading - the upgrade failed but the DB
still had opac_news in the letter content

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30736] Upgrade 'libsearch-elasticsearch-perl' package to version 6.00

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30736

--- Comment #2 from Nick Clemens  ---
ping

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30676] View all ... preferences links don't work when GUI language doesn't match

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30676

Katrin Fischer  changed:

   What|Removed |Added

Version|20.11   |master

--- Comment #3 from Katrin Fischer  ---
I am not sure either, apart from having an id in the yaml file for the
different headings maybe to use instead of the translated string?

I marked it minor after figuring out it was not totally broken, just depending
on the active language. I think it's not a high priority one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511

--- Comment #20 from Katrin Fischer  ---
I am a little worried by the patch comments:

>Remove translation support for short version of season

>The season is stored in the DB in English and but not translated when
>displayed on the interface.

I am not sure if that is correct?

If a translated GUI is used, you will have created a string (serialseq I tihnk)
using the numberpattern that contains the translation of the season.

Will this still work as before after the patches?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30901] Add template method to be able to look up renewal data in Koha slips and notices

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30901

--- Comment #11 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #10)
> It's handy but cannot we already provide the same output without this patch?
> From the patron object you can get the number of renews, the
> CirculationRules will give you the values for the renewal rules, and then
> it's a subtraction.

I think it sounds more complicated for users, tbh. 

Could you write up a working example to document? I think patron object is not
correct or we need another step to the issue and then calculate a lot of
things.

At the moment the main issue using TT notices is that you practically need to
read and understand the code for anything a little out of the ordinary :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

--- Comment #16 from Jonathan Druart  ---
Magnus maybe, can you test this is working for you?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30903] CSV import of quotes broken

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

--- Comment #7 from Jonathan Druart  ---
I think you are raising too many problems on the same bug :)
We should first fix the import error (it's blocking the feature) then focus on
the UI glitches (which are not major IMO)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30920] Add caching to C4::Biblio::GetAuthorisedValueDesc

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920

--- Comment #5 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #2)
> We could improve it that way, but then it should be used from the other
> places (git grep GetClassSources).

This is actually not relevant. Other occurrences are building the dropdown
list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25126] MARC visibility settings not obeyed on cart normal and detailed views

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25126

--- Comment #4 from Martin Renvoize  ---
Can anyone varify where this is still an issue..

To me, it looks like the cart is taken care of already..

I realise there's also a bug open regarding title notes which is also being
worked on.. but where else are these filters not taking effect?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #134953|0   |1
is obsolete||

--- Comment #6 from Andrew Fuerste-Henry  ---
Created attachment 135785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135785=edit
Bug 30745: handle ES ranges for date of acquisition

Test plan:
  - Enable elasticsearch
  - git to labels/label-item-search.pl
  - search using after date only
=> check you get items with date-of-acquisition greater than after
date
  - search using before date only
=> check you get items with date-of-acquisition less than before
date
  - search using after and before date
=> check you get items with date-of-acquisition between after and
before
  - Combine this searches with a specified index
  - enable zebra and repeat these tests

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #134952|0   |1
is obsolete||

--- Comment #5 from Andrew Fuerste-Henry  ---
Created attachment 135784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135784=edit
Bug 30745: Use query builder and search_compat in label-item-search

Test plan:
  - apply this patch,
  - make some searches in labels/label-item-search.pl using
the 3 form input (index, after date, before date),
  - check it works like before

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25579

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29346] Real-time holds queue update

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29346

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25579

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25579] Holds Tracker Page

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25579

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29346,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=8352
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30903] CSV import of quotes broken

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

--- Comment #6 from Caroline Cyr La Rose  ---
I tested and here are my comments:

1) The Browse/Choose file button is still off center for some reason, it's at
the top of the box, rather than vertically centered. (see attached screenshot
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135781 ) I tried
both in Firefox and Chrome and it's at the top in both browsers

2) The editing boxes are still really small, when compared to how they were
previously, as illustrated in the manual 
(currently https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135782
previously
https://koha-community.org/manual/latest/en/html/_images/editquote.png ) Again,
I tried both in Firefox and Chrome and it's the same

3) The quotes seem to have been imported, if I trust the confirmation message,
but I stayed on the same page and the two options available to me are "Save
quotes", which I already clicked (multiple times because it was slow) and
"Cancel import", which, if clicked, asks me a confirmation if I really want to
cancel and sends me back to the import page with the Browse/Choose file button.
I think once the quotes are imported, we should be sent back to the main QOTD
editor page with the list of quotes already in the system.

Caroline

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

Marcel de Rooy  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #15 from Marcel de Rooy  ---
Jonathan: Do you want to check this one, or straight to Tomas?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

Marcel de Rooy  changed:

   What|Removed |Added

 CC||arthur.suz...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

Marcel de Rooy  changed:

   What|Removed |Added

  Text to go in the||This database revision
  release notes||fixes the one from bug
   ||30449 for table
   ||borrower_attribute_types.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

--- Comment #14 from Marcel de Rooy  ---
Created attachment 135783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135783=edit
Bug 30899: [21.11.x] Follow-up for dbrev 211200041 from bug 30449

Replace DROP CONSTRAINT by DROP FOREIGN KEY in old dbrev, and
submit a new dbrev to fix cases where dbrev went wrong.

Test plan:

NOTE: When you check show create table, verify that you see an index for
category_code and a foreign key called borrower_attribute_types_ibfk_1.

[1] run updatedatabase; check show create table
[2] alter table borrower_attribute_types drop foreign key
borrower_attribute_types_ibfk_1; alter table borrower_attribute_types drop
index category_code; RUN updatedatabase again; check show create table
[3] alter table borrower_attribute_types drop foreign key
borrower_attribute_types_ibfk_1; ALTER TABLE borrower_attribute_types ADD
CONSTRAINT category_code_fk FOREIGN KEY (category_code) REFERENCES
categories(categorycode); RUN updatedatabase again; check show create table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30903] CSV import of quotes broken

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

--- Comment #5 from Caroline Cyr La Rose  ---
Created attachment 135782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135782=edit
Editing box is very small

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30903] CSV import of quotes broken

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

--- Comment #4 from Caroline Cyr La Rose  ---
Created attachment 135781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135781=edit
Browse button off center from the box

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30920] Add caching to C4::Biblio::GetAuthorisedValueDesc

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920

--- Comment #4 from Jonathan Druart  ---
Yes sure, my main point was about the removal. I thought it was kind of
obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

--- Comment #13 from Marcel de Rooy  ---
Created attachment 135780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135780=edit
Bug 30899: [22.05.x] Follow-up for dbrev 211200041 from bug 30449

Replace DROP CONSTRAINT by DROP FOREIGN KEY in old dbrev, and
submit a new dbrev to fix cases where dbrev went wrong.

Test plan:

NOTE: When you check show create table, verify that you see an index for
category_code and a foreign key called borrower_attribute_types_ibfk_1.

[1] run updatedatabase; check show create table
[2] alter table borrower_attribute_types drop foreign key
borrower_attribute_types_ibfk_1; alter table borrower_attribute_types drop
index category_code; RUN updatedatabase again; check show create table
[3] alter table borrower_attribute_types drop foreign key
borrower_attribute_types_ibfk_1; ALTER TABLE borrower_attribute_types ADD
CONSTRAINT category_code_fk FOREIGN KEY (category_code) REFERENCES
categories(categorycode); RUN updatedatabase again; check show create table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30920] Add caching to C4::Biblio::GetAuthorisedValueDesc

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920

--- Comment #3 from Martin Renvoize  ---
Baby steps back at you ;P.

I agree it would be nice to shift this stuff to Koha::.. but that's for another
day.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30653] "Check out" search with one result does not redirect to checkout

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30653

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #1 from Jonathan Druart  ---
Looks ok for me on master. Are you able to confirm that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

Marcel de Rooy  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30920

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30920] Add caching to C4::Biblio::GetAuthorisedValueDesc

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30848

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30920] Add caching to C4::Biblio::GetAuthorisedValueDesc

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920

Martin Renvoize  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30920] Add caching to C4::Biblio::GetAuthorisedValueDesc

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920

Martin Renvoize  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

--- Comment #12 from Marcel de Rooy  ---
Still coming patches for 22.05 and 21.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921

Martin Renvoize  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

Marcel de Rooy  changed:

   What|Removed |Added

Version|21.11   |master
  Component|Installation and upgrade|Database
   |(command-line installer)|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

--- Comment #11 from Marcel de Rooy  ---
Created attachment 135779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135779=edit
Bug 30899: [MASTER 22.12] Correct dbrev 211200041

Replace DROP CONSTRAINT by DROP FOREIGN KEY.

Note: It seems that we do not need a new dbrev for master. A developer
could follow test plan below to correct if really needed.

Test plan:

NOTE: When you check show create table, verify that you see an index for
category_code and a foreign key called borrower_attribute_types_ibfk_1.

[1] cp installer/data/mysql/db_revs/211200041.pl
installer/data/mysql/atomicupdate/
[2] run updatedatabase; check show create table
[3] alter table borrower_attribute_types drop foreign key
borrower_attribute_types_ibfk_1; alter table borrower_attribute_types drop
index category_code; RUN updatedatabase again; check show create table
[4] alter table borrower_attribute_types drop foreign key
borrower_attribute_types_ibfk_1; ALTER TABLE borrower_attribute_types ADD
CONSTRAINT category_code_fk FOREIGN KEY (category_code) REFERENCES
categories(categorycode); RUN updatedatabase again; check show create table
[5] rm installer/data/atomicupdate/211200041.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921

--- Comment #1 from Martin Renvoize  ---
Created attachment 135778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135778=edit
Bug 30921: Replace C4::XSLT::transformMARCXML4XSLT with RecordProcessor

This patch removes the last remaining uses of transformMARCXML4XSLT and
replaced them with the equivilent RecordProcessor usage.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30920] Add caching to C4::Biblio::GetAuthorisedValueDesc

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30920

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #2 from Jonathan Druart  ---
I thought this sub was going to be removed.
We could improve it that way, but then it should be used from the other places
(git grep GetClassSources).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899
Bug 30899 depends on bug 30449, which changed state.

Bug 30449 Summary: Missing FK constraint on borrower_attribute_types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30486] [OMNIBUS] Synchronize database schema with (older) database revisions

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30486
Bug 30486 depends on bug 30449, which changed state.

Bug 30449 Summary: Missing FK constraint on borrower_attribute_types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30449] Missing FK constraint on borrower_attribute_types

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30449

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #16 from Marcel de Rooy  ---
See bug 30899. Patch forthcoming on that report.
No need to push this further down.
Closing the report to prevent that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30672] Special characters entered into circulation and fine rules causes errors

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30672

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #1 from Jonathan Druart  ---
Where do you get an error? When saving the rule?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30919] Search on any order status

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30919

--- Comment #2 from Séverine Queune  ---
Oups... I'm becoming bad at searching existing bugs...
Sorry for the duplicate, thanks a lot Katrin !

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511

--- Comment #19 from Florian  ---
Comment on attachment 135775
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135775
Bug 13614: Compiled CSS

Apologies, not sure how that one sneaked in there

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511

--- Comment #18 from Florian  ---
Created attachment 135777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135777=edit
Bug 20511: Remove translation support for short version of season

Everything get messy when we translate "Sum", then "Summer" as it's a
substring.

Signed-off-by: Florian Bontemps 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511

Florian  changed:

   What|Removed |Added

 Attachment #135504|0   |1
is obsolete||
 Attachment #135505|0   |1
is obsolete||

--- Comment #17 from Florian  ---
Created attachment 135776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135776=edit
Bug 20511: Make seasons translatable in prediction pattern

The season is stored in the DB in English and but not translated when
displayed on the interface.
This patch will translate the different seasons and their short form
('Spr' for 'Spring').

Test plan:
Update the PO of the language you like
Edit po/xx-XX-messages.po and translate the season names
Setup a new language and use it for the staff interface
Create a new subscription using the "Seasonal" subscription pattern
Generate new serial items and confirm that the seasons are correctly
translated when displayed

Sponsored-by: Orex Digital
Signed-off-by: Florian Bontemps 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511

Florian  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963

--- Comment #24 from Benjamin Daeuber  ---
> 
> Going forward if there are concerns with the original patch changing the
> behavior of one item form making it inconsistent with others in cataloguing
> and acq. Then I think, instead of a behavior change, it should be sufficient
> to add a hint saying that if you save the 952$d with nothing in it Koha will
> still auto-populate the 952$d with today's date. Perhaps this is the most
> straight forward solution?

I'm not sure I agree with this. I don't really see an issue with being context
aware. Hints get missed with potentially far reaching consequences in the case
of a batch edit. Logical, context aware behavior seems more user friendly. It
makes sense to populate that field in the case of serials and new items, but
not in the case of item edits. I don't really find that to be an inconsistent
behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511

Florian  changed:

   What|Removed |Added

 CC||florian.bontemps@biblibre.c
   ||om
 Attachment #135775|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30682] Indicate in addbiblio.pl when an edit will not be saved due to Overlay Rules

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30682

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #1 from Jonathan Druart  ---
I wrote a patch on
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126667

Can be useful to start.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511

--- Comment #16 from Florian  ---
Created attachment 135775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135775=edit
Bug 13614: Compiled CSS

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||30921


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921
[Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||30744


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744
[Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do
not leak
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30903] CSV import of quotes broken

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com
   Assignee|koha-b...@lists.koha-commun |jonathan.druart+koha@gmail.
   |ity.org |com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30903] CSV import of quotes broken

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

--- Comment #3 from Jonathan Druart  ---
Created attachment 135774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135774=edit
Bug 30903: Fix UI glitch on the quotes upload view

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30903] CSV import of quotes broken

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

--- Comment #2 from Jonathan Druart  ---
Created attachment 135773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135773=edit
Bug 30903: Fix POST /quote

quote_id should not be required

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30903] CSV import of quotes broken

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30903

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30848] Introduce Koha::Filter::ExpandCodedFields

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||30921


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921
[Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||30848


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30848
[Bug 30848] Introduce Koha::Filter::ExpandCodedFields
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30921] New: Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921

Bug ID: 30921
   Summary: Replace use of C4::XSLT::transformMARCXML4XSLT with
RecordProcessor
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

We should remove C4::XSLT::transformMARCXML4XSLT and instead utilise the
coherent interface provided by RecordProcessor and the new ExpandCodedValues
filter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #4 from Andrew Fuerste-Henry  ---
*** Bug 30908 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30908] Date range search in label creator does not work with Elastic (label-item-search.pl)

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30908

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Andrew Fuerste-Henry  ---


*** This bug has been marked as a duplicate of bug 30745 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display

2022-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371

--- Comment #44 from Martin Renvoize  ---
OK.. I completely different approach to this that caches at the
C4::Biblio::GetAuthorisedValueDesc level can be found on bug 30920.

When comparing directly to this I found the performance improvements rather
favourable to the caching approach (and I also think the code is a little
clearer not passing around the variables as much).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >