[Koha-bugs] [Bug 30684] koha-* scripts --restart should start even when not running
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30684 --- Comment #17 from David Cook --- (In reply to Alex Buckley from comment #16) > Looking at how Apache does it we thought it would be best for the restart > functions in the koha-* scripts to check if the service is running and if > not then only start the service, not try to stop then start. > > Our proposed functionality is contained in the attached patchset for all the > koha-* scripts with restart functions. > > Can you please let me know your thoughts when you have a chance? > > Thanks, > Alex Sounds good to me. Easy to get the Starman PID to see if it's running. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30925] Creating public list by adding items to new list creates a private list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30925 --- Comment #4 from Alex Buckley --- Just noting: I checked out the v21.11.00 tag and found that this bug can be replicated - at least when creating a public list by adding items to new list on the staff client. I have not tested on the OPAC. Bug 26346 was not pushed to 21.11.00. Also, if you check out commit c9fc07aee3bc9b60a856b1b873ec731a31c2bc8a which the commit before bug 28959 was pushed this buggy behaviour cannot be replicated in the staff client. Therefore I do not think this bug was caused by 26346 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30768] Typo: pin should be PIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 --- Comment #9 from Michal Urban --- (In reply to Lucas Gass from comment #8) > Template and test changes look good, tests all still pass, QA script is > happy. > > Welcome aboard Michal! Thanks Lucas! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30930] Ability to change authority type while editing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30930 --- Comment #1 from Aleisha Amohia --- Created attachment 135851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135851=edit Bug 30930: Ability to change auth type while editing record This patch adds the ability to change the authority MARC framework/type being used while editing an authority record. To test: 1) Log into the staff client and go to Authorities 2) Search for an existing authority and edit it 3) Notice there is no way to change this authority type 4) Apply patch, restart services, refresh editor in browser 5) Notice the new Settings dropdown. Click to open 6) Confirm the correct current authority type is selected 7) Select another type to change to that. The page should reload 8) Confirm the page reloads with the correct authority type framework loaded and the MARC data is still correct Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30930] Ability to change authority type while editing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30930 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30930] Ability to change authority type while editing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30930 Aleisha Amohia changed: What|Removed |Added Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30930] New: Ability to change authority type while editing record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30930 Bug ID: 30930 Summary: Ability to change authority type while editing record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl When editing a biblio record, the editor has a 'Settings' menu which allows you to change the record's framework within the editor. The authority editor should have this feature too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23334] Modal window for Z3950 search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23334 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 --- Comment #18 from David Cook --- (In reply to Katrin Fischer from comment #17) > > Deeply I think MARC datas should always be public ;) > > I agree to a point. The problem is, that we have no way to store item > specific internal information outside of MARC. I think this might be the > missing feature that would resolve a lot of those issues. I was thinking the same thing last night. We have a tendency of storing everything in MARC, but maybe having internal "Koha notes" would be a good idea. Maybe we could have a way of automagically stuffing those into a MARC record if library staff needed to export to move the records somewhere... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30929] Option to view actions logs in descending order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30929 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #1 from Aleisha Amohia --- Sorry I'm not sure what I was looking at... this clearly already works in upstream! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30768] Typo: pin should be PIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 --- Comment #8 from Lucas Gass --- Template and test changes look good, tests all still pass, QA script is happy. Welcome aboard Michal! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30768] Typo: pin should be PIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 Lucas Gass changed: What|Removed |Added Attachment #135833|0 |1 is obsolete|| --- Comment #7 from Lucas Gass --- Created attachment 135850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135850=edit Bug 30768: Capitalizing "pin" in 2FA setup Change of text from "pin" to "PIN" in the 2FA setup interface. This slight changes clarifies that "PIN" is an acronym, and increases user comprehension To test: 1) Log in as an Administrator 2) Enable TwoFactorAuthentication 3) Log in to a user with superlibrarian permissions. 4) On the user profile page, click the "More" dropdown button, click "Manage Two-Factor 5) Check that "pin" is displayed in lowercase, in both instances. 6) Apply patch. 7) Refresh the page and observe that "pin" has changed to "PIN" 8) Sign off. Signed-off-by: David Nind Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30768] Typo: pin should be PIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 Lucas Gass changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30929] Option to view actions logs in descending order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30929 Aleisha Amohia changed: What|Removed |Added Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30929] New: Option to view actions logs in descending order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30929 Bug ID: 30929 Summary: Option to view actions logs in descending order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org A fix for this was first attempted at Bug 25968 but was reverted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30768] Typo: pin should be PIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 Lucas Gass changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30768] Typo: pin should be PIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 Lucas Gass changed: What|Removed |Added Assignee|oleon...@myacpl.org |michalurban...@gmail.com CC||lu...@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 Lucas Gass changed: What|Removed |Added Attachment #135792|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Attachment #135701|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 --- Comment #9 from Lucas Gass --- Created attachment 135849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135849=edit Bug 30904: (bug 24387 follow-up) Fix library modification of additional contents Modifying an existing element of additional content (News) by changing the library causes a duplication of the entry on the Additional contents (News) list. A subsequent attempt of deleting one of the entries results in deleting both of them. This is due to the fact that after the unwanted duplication all the entries share the same additional_contents.code. Test plan = 1. Create a piece of news under Tools > News. 2. After having saved it make a modification by changing the library. It should result in two rows in the table. 3. Delete one of the lines with Delete button. Both lines will disappear. 4. Apply the patch. 5. Repeat the steps 1 and 2. Only the one (the modified) entry should be present in the table. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 Lucas Gass changed: What|Removed |Added Attachment #135837|0 |1 is obsolete|| --- Comment #6 from Lucas Gass --- Created attachment 135848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135848=edit Bug 30500: Allow patrons to change in transit holds pickup locations This patch adds a way for patrons to change the pickup location for in transit holds. This is done in the OPAC on the holds table. The feature is controlled by a new system preference: * OPACInTransitHoldPickupLocationChange To test: 1. Apply this patches 2. Run: $ updatedatabase $ restart_all => SUCCESS: system preference added 3. Have an in-transit hold for a known patron 4. Visit the holds table for the patron (OPAC) => SUCCESS: Hold in transit, cannot change pickup location 5. Enable the OPACInTransitHoldPickupLocationChange system preference => SUCCESS: Descriptive text makes sense and is idiomatic 6. Reload the OPAC page => SUCCESS: You can now choose a new pickup location 7. Choose one => SUCCESS: It works! Reloaded page pre-selects the new pickup location 8. Switch to the new pickup location library on the staff interface 9. Go to Circulation > Transfers to receive => SUCCESS: The hold is there! 10. Scan the hold => SUCCESS: Usual workflow follows 11. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 Lucas Gass changed: What|Removed |Added Attachment #135836|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 135847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135847=edit Bug 30500: Add OPACInTransitHoldPickupLocationChange syspref Sponsored-by: Montgomery County Public Libraries Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23334] Modal window for Z3950 search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23334 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30130] Allow setting EDI type at the vendor level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30130 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Keywords||Manual-updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30135] We should allow configuration of whether EDI LSQ segments map to 'location' or 'collection'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30135 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Keywords||Manual-updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16258] Add a preference to turn EDIFACT off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16258 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Keywords||Manual-updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27212] Add column configuration to the acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Keywords||Manual-updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30928] New: Add interface to statistics table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30928 Bug ID: 30928 Summary: Add interface to statistics table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: he...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Many libraries are interested in seeing stats on the interfaces where transactions took place (staff intranet vs sip checkout, for example). Currently the only way to find that information is via action_logs, which means that data drops off eventually. It would be nice to have this information as part of statistics for ease of reporting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135832|0 |1 is obsolete|| --- Comment #65 from Tomás Cohen Arazi --- Created attachment 135846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135846=edit Bug 22456: (follow-up) Cancel holds at checkin This patch makes checkin process the cancellation requested holds actually cancel them before moving forward. To test: 1. Have a waiting hold with a patron generated cancellation request 2. At circulation, check the item in => SUCCESS: The workflow follows as if the cancellation requested hold was already cancelled => SUCCESS: The hold is actually cancelled => SUCCESS: Not shown in the OPAC anymore Sponsored-by: Montgomery County Public Libraries Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135831|0 |1 is obsolete|| --- Comment #64 from Tomás Cohen Arazi --- Created attachment 135845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135845=edit Bug 22456: Staff interface handling This patch introduces a new tab to the 'Holds awaiting pickup' screen for holds that have cancellation requests. This can be accepted (by cancelling the hold) or rejected. To test: 1. Set circulation rules for cancellation requests, allowing them for certain item type. 2. Have some waiting holds for a patron on an item type that allows requesting cancellation. 3. Visit 'Holds awaiting pickup' => SUCCESS: No holds have cancellation requests 4. In the OPAC, on the user details, notice some holds have the ability to be requested cancellation. 5. Choose to request cancellation => SUCCESS: Request is placed, the button is disabled 6. In 'Holds awaiting pickup' you can see them 7. Play with rejecting/accepting => SUCCESS: It works! 8. Things are reflected in the OPAC side Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135830|0 |1 is obsolete|| --- Comment #63 from Tomás Cohen Arazi --- Created attachment 135844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135844=edit Bug 22456: Allow requesting cancellation from the OPAC Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135409|0 |1 is obsolete|| --- Comment #62 from Tomás Cohen Arazi --- Created attachment 135843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135843=edit Bug 22456: Add Koha::Holds->filter_by_has_cancellation_requests This patch adds that method. Which is covered by new tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135408|0 |1 is obsolete|| --- Comment #61 from Tomás Cohen Arazi --- Created attachment 135842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135842=edit Bug 22456: Add cancellation request methods to Koha::Hold This patch adds the following helper methods for dealing with hold cancellation requests to the Koha::Hold class: * cancellation_requests * add_cancellation_request * cancellation_requestable_from_opac * cancellation_requested_by_owner To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135407|0 |1 is obsolete|| --- Comment #60 from Tomás Cohen Arazi --- Created attachment 135841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135841=edit Bug 22456: Add Koha::Hold::CancellationRequest(s) class(es) This patch adds the Koha::Object-derived classes for cancellation requests. Tests are added for the overloaded ->store method. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold/CancellationRequest.t => SUCCESS: Tests pass! 3. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135406|0 |1 is obsolete|| --- Comment #59 from Tomás Cohen Arazi --- Created attachment 135840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135840=edit Bug 22456: DBIC update Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135405|0 |1 is obsolete|| --- Comment #58 from Tomás Cohen Arazi --- Created attachment 135839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135839=edit Bug 22456: Add waiting_hold_cancellation circulation rule This patch adds handling for the waiting_hold_cancellation circulation rule. It is set no 'No' by default in the atomic update, if not previously set. Handling in the rules editor is added, in its own section. To test: 1. Apply this patch 2. Run: $ updatedatabase => SUCCESS: All good 3. Verify that the syspref is set: $ koha-mysql kohadev > SELECT * FROM circulation_rules WHERE rule_name='waiting_hold_cancellation'; => SUCCESS: Set to 0 4. Play with the rules editor, changing things back and forth, things should work, including library-specific and global/defualt settings. => SUCCESS: It works => SUCCESS: Texts are idiomatic 5. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135404|0 |1 is obsolete|| --- Comment #57 from Tomás Cohen Arazi --- Created attachment 135838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135838=edit Bug 22456: Add cancellation request table This patch adds a new table, for storing holds cancellation requests, and managing them afterwards. The *hold_id* attribute is not made a FK on the reserves table because of the old_reserves thing we still do (see bug 25260 for a discussion about it). Sponsored-by: Montgomery County Public Libraries Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added URL|https://gitlab.com/thekesol | |utions/Koha/-/commits/bug_2 | |2456| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Morgan Daigneault changed: What|Removed |Added CC||mor...@bywatersolutions.com --- Comment #12 from Morgan Daigneault --- This would be great to have. I think it would make the most sense to include it as an optional free text field with the rest of the patron identity info. When it’s added as an additional attribute, it’s far removed from that info, which is where it would be most useful to have for patron interactions. Echoing others in that the purpose would be less for collecting data and more for informational purposes in the spirit of good service and inclusivity (for example, knowing how to address a patron when calling them on the phone). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135835|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 135837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135837=edit Bug 30500: Allow patrons to change in transit holds pickup locations This patch adds a way for patrons to change the pickup location for in transit holds. This is done in the OPAC on the holds table. The feature is controlled by a new system preference: * OPACInTransitHoldPickupLocationChange To test: 1. Apply this patches 2. Run: $ updatedatabase $ restart_all => SUCCESS: system preference added 3. Have an in-transit hold for a known patron 4. Visit the holds table for the patron (OPAC) => SUCCESS: Hold in transit, cannot change pickup location 5. Enable the OPACInTransitHoldPickupLocationChange system preference => SUCCESS: Descriptive text makes sense and is idiomatic 6. Reload the OPAC page => SUCCESS: You can now choose a new pickup location 7. Choose one => SUCCESS: It works! Reloaded page pre-selects the new pickup location 8. Switch to the new pickup location library on the staff interface 9. Go to Circulation > Transfers to receive => SUCCESS: The hold is there! 10. Scan the hold => SUCCESS: Usual workflow follows 11. Sign off :-D Sponsored-by: Montgomery County Public Libraries Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135834|0 |1 is obsolete|| --- Comment #3 from Tomás Cohen Arazi --- Created attachment 135836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135836=edit Bug 30500: Add OPACInTransitHoldPickupLocationChange syspref Sponsored-by: Montgomery County Public Libraries Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29963] Date accessioned plugin should not automatically fill today's date on cataloguing screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29963 --- Comment #27 from Benjamin Daeuber --- A few things: 1. Applying this patch on master and deleting the accessioned date now fills todays date, even if I have don't have that field set to mandatory. Can anyone confirm that? 2. Assuming this is the case, this makes batch modification even more fraught because batch modifying an item with a date and another item without a date will cause one to end up with todays date. There's really no winning for the end user there: either change all items to the same date, or change any item without a date to todays date. 3. I think the hint wording is confusing on batchmod.pl since it implies that leaving that field blank will set all batch modified items to todays date. I still think leaving batchmod.pl out of this entirely is best. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 135835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135835=edit Bug 30500: Allow patrons to change in transit holds pickup locations This patch adds a way for patrons to change the pickup location for in transit holds. This is done in the OPAC on the holds table. The feature is controlled by a new system preference: * OPACInTransitHoldPickupLocationChange To test: 1. Apply this patches 2. Run: $ updatedatabase $ restart_all => SUCCESS: system preference added 3. Have an in-transit hold for a known patron 4. Visit the holds table for the patron (OPAC) => SUCCESS: Hold in transit, cannot change pickup location 5. Enable the OPACInTransitHoldPickupLocationChange system preference => SUCCESS: Descriptive text makes sense and is idiomatic 6. Reload the OPAC page => SUCCESS: You can now choose a new pickup location 7. Choose one => SUCCESS: It works! Reloaded page pre-selects the new pickup location 8. Switch to the new pickup location library on the staff interface 9. Go to Circulation > Transfers to receive => SUCCESS: The hold is there! 10. Scan the hold => SUCCESS: Usual workflow follows 11. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 135834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135834=edit Bug 30500: Add OPACInTransitHoldPickupLocationChange syspref Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- A lot of libraries would still like to see this a designated field. It would be great if we could get this to Koha for 22.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Blocks||30500 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Depends on||22456 Patch complexity|--- |Small patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 [Bug 22456] Allow patrons to cancel their waiting holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30768] Typo: pin should be PIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 David Nind changed: What|Removed |Added Attachment #135822|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 135833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135833=edit Bug 30768: Capitalizing "pin" in 2FA setup Change of text from "pin" to "PIN" in the 2FA setup interface. This slight changes clarifies that "PIN" is an acronym, and increases user comprehension To test: 1) Log in as an Administrator 2) Enable TwoFactorAuthentication 3) Log in to a user with superlibrarian permissions. 4) On the user profile page, click the "More" dropdown button, click "Manage Two-Factor 5) Check that "pin" is displayed in lowercase, in both instances. 6) Apply patch. 7) Refresh the page and observe that "pin" has changed to "PIN" 8) Sign off. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30768] Typo: pin should be PIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30775] 952w should have datepicker plugin enabled for it by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30775 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds the release notes||date picker to 952$w (price ||effective from). || ||This ||improves usability (952$d ||(date acquired) has the ||date picker enabled) and ||also adds date field ||validation (the date is ||added to the database as ||-MM-DD and when entered ||incorrectly it can lead to ||crashes in other areas). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30775] 952w should have datepicker plugin enabled for it by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30775 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135430|0 |1 is obsolete|| --- Comment #56 from Tomás Cohen Arazi --- Created attachment 135832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135832=edit Bug 22456: (follow-up) Cancel holds at checkin This patch makes checkin process the cancellation requested holds actually cancel them before moving forward. To test: 1. Have a waiting hold with a patron generated cancellation request 2. At circulation, check the item in => SUCCESS: The workflow follows as if the cancellation requested hold was already cancelled => SUCCESS: The hold is actually cancelled => SUCCESS: Not shown in the OPAC anymore Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135411|0 |1 is obsolete|| --- Comment #55 from Tomás Cohen Arazi --- Created attachment 135831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135831=edit Bug 22456: Staff interface handling This patch introduces a new tab to the 'Holds awaiting pickup' screen for holds that have cancellation requests. This can be accepted (by cancelling the hold) or rejected. To test: 1. Set circulation rules for cancellation requests, allowing them for certain item type. 2. Have some waiting holds for a patron on an item type that allows requesting cancellation. 3. Visit 'Holds awaiting pickup' => SUCCESS: No holds have cancellation requests 4. In the OPAC, on the user details, notice some holds have the ability to be requested cancellation. 5. Choose to request cancellation => SUCCESS: Request is placed, the button is disabled 6. In 'Holds awaiting pickup' you can see them 7. Play with rejecting/accepting => SUCCESS: It works! 8. Things are reflected in the OPAC side Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135410|0 |1 is obsolete|| --- Comment #54 from Tomás Cohen Arazi --- Created attachment 135830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135830=edit Bug 22456: Allow requesting cancellation from the OPAC Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED CC||tomasco...@gmail.com Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- I'm getting this error when I click on the iCal link: Can't call method "hour" on an undefined value at /kohadevbox/koha/opac/opac-ics.pl line 88 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 --- Comment #7 from Kyle M Hall --- Removed the "DO NOT PUSH", as these changes *do* need pushed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 Kyle M Hall changed: What|Removed |Added Attachment #135828|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 135829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135829=edit Bug 30612: Update schema files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 --- Comment #5 from Kyle M Hall --- Created attachment 135828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135828=edit Bug 30612: Update schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 Kyle M Hall changed: What|Removed |Added Attachment #134567|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 135827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135827=edit Bug 30612: Add accountlines method to Koha::Checkout and Koha::Old::Checkout It would be very useful to have an accountlines method on checkouts objects. In particular it would make fees related to a checkout available from the checkout objects in overdue notices. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Line.t 3) prove t/db_dependent/Koha/Checkouts.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30612] Add accountlines method to Koha::Checkout and Koha::Old::Checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30612 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #1 from Kyle M Hall --- Created attachment 135826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135826=edit Bug 30927 - Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. It makes more sense for: A) Checkouts due at midnight to be "All day events" B) Checkouts due at specific time to start in the morning, and end at the time due. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout starts in the morning and ends at the due time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall changed: What|Removed |Added Assignee|oleon...@myacpl.org |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] New: Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Bug ID: 30927 Summary: Improve formatting or iCal files for checkout due dates Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. It makes more sense for: A) Checkouts due at midnight to be "All day events" B) Checkouts due at specific time to start in the morning, and end at the time due. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Joy Nelson changed: What|Removed |Added Text to go in the|This developments adds a|This developments adds a release notes|way to choose multiple |way to choose multiple |holds using checkboxes, to |holds using checkboxes, to |cancel them in bulk. |cancel them in bulk. | | |It |It |uses the new background |uses the new background |jobs infrastructure |jobs infrastructure |recently introduced.|recently introduced. || ||Sponsored by: Bedford ||Public Library, ||Hunstville-Madison County ||Library, Los Gatos Public ||Library, and Portsmouth ||Public Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23678] Cancel holds in bulk
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23678 Joy Nelson changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30921] Replace use of C4::XSLT::transformMARCXML4XSLT with RecordProcessor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30921 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #2 from David Nind --- Hi Martin. What is the best way to test this? - prove t/db_dependent/XSLT.t passes before and after the patch is applied - a git grep transformMARCXML4XSLT shows no occurrences after the patch is applied Since this is tied in with all the other dependencies, is there an overall test plan? David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30744] Use RecordProcessor in get_marc_notes to ensure non-public notes do not leak
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30744 --- Comment #18 from David Nind --- What's required to test this, since the quick fix is in another bug? Or is more work still required? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 --- Comment #8 from Janusz Kaczmarek --- (In reply to Jonathan Druart from comment #7) > (In reply to Janusz Kaczmarek from comment #3) > > To sum up—I would suggest considering the patch OK, but probably data > > definition introduced by you with the commit > > 8df3116760bdf1b889dc6f78e4605e231c4d7d6d requires correction as well. IMO, > > UNIQUE KEY `additional_contents_uniq` (`category`,`code`,`lang`) would be > > perfect. > > Which means you couldn't have 2 identical contents for different libraries? > Sounds wrong to me. Why not? In every case you have to create them separately, which means they would get a different additional_contents.code. The presence or absence of branchcode in unique key does not change anything here, IMHO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 --- Comment #50 from Tomás Cohen Arazi --- Created attachment 135825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135825=edit Bug 30813: (follow-up) Fix tests import Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30399] Patron.t fails when there is a patron attribute that is mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 David Nind changed: What|Removed |Added Attachment #135791|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 135824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135824=edit Bug 30399: Make Patron.t pass even if mandatory attributes exist t/db_dependent/Koha/Patron.t is failing if mandatory attributes already exist in the DB. We can make it pass easily by deleting all the attributes before we run the tests. Test plan: prove t/db_dependent/Koha/Patron.t must return green even if one mandatory patron attribute exists. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30399] Patron.t fails when there is a patron attribute that is mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30399 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30721] Markup error in detail page's component parts tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30721 David Nind changed: What|Removed |Added Text to go in the||This fixes the display of release notes||the component parts tab on ||the bibliographic detail ||page in the staff ||interface. A missing ||was causing content from ||later tabs to be ||incorrectly displayed at ||the end of the component ||parts tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27519] Normalize Show/Don't show vs Display/Don't display in system preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 David Nind changed: What|Removed |Added Text to go in the||This enhancement replaces release notes||"Display/Don't display" ||with "Show/Don't show" for ||several system preferences ||to improve terminology ||consistency and make ||translation easier. A few ||preferences were also ||updated where "Yes/No" and ||"Show/Hide" were used. Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30849] Make pending patron modification notices on staff main page number of modifications at logged in branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 --- Comment #1 from Lucas Gass --- Created attachment 135823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135823=edit Bug 30849: show pending modifications by branch To test: 1. Add some borrower modifications from the OPAC from patrons that belong to some different libraries. 2. On the staff client mainpage (mainpage.pl) you should see a link 'Patrons requesting modifications:' but no way of knowing if they are patrons from your logged in branch or not 3. Apply patch, restart_all 4. Try step 2 again and now you should see something like 'Patrons requesting modifications: Centerville: 1 / All libraries: 2'; 5. Trying and and fulfilling some modifcations and make sure the numbers on mainpage.pl are always correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30849] Make pending patron modification notices on staff main page number of modifications at logged in branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30849 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30768] Typo: pin should be PIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 Michal Urban changed: What|Removed |Added CC||michalurban...@gmail.com Status|NEW |Needs Signoff --- Comment #5 from Michal Urban --- (In reply to Owen Leonard from comment #3) > IF this is ready for signoff (the bug doesn't say so): The changes to the > template and test look great, but the .po files shouldn't be changed in the > patch. They will get updated when translations are updated. I wasn't sure if there needed to be changes in the .po files, but thanks for clarification. The new patch reverts the changes, and only keeps the template/test changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30768] Typo: pin should be PIN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30768 Michal Urban changed: What|Removed |Added Attachment #135788|0 |1 is obsolete|| --- Comment #4 from Michal Urban --- Created attachment 135822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135822=edit Bug 30768: Capitalizing "pin" in 2FA setup Change of text from "pin" to "PIN" in the 2FA setup interface. This slight changes clarifies that "PIN" is an acronym, and increases user comprehension To test: 1) Log in as an Administrator 2) Enable TwoFactorAuthentication 3) Log in to a user with superlibrarian permissions. 4) On the user profile page, click the "More" dropdown button, click "Manage Two-Factor 5) Check that "pin" is displayed in lowercase, in both instances. 6) Apply patch. 7) Refresh the page and observe that "pin" has changed to "PIN" 8) Sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30508] Do not display OPAC message about block from holds when OPACHoldRequests is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30508] Do not display OPAC message about block from holds when OPACHoldRequests is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30508 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy changed: What|Removed |Added Attachment #25972|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #65 from Marcel de Rooy --- Please wait. Not ready yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #64 from Marcel de Rooy --- Created attachment 135821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135821=edit Bug 11889: (QA follow-up) Fix tests Noise from 28959 changing category to public. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #63 from Marcel de Rooy --- Created attachment 135820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135820=edit Bug 11889: (QA follow-up) Changes for wantarray move in ->search See bug 29844. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #62 from Marcel de Rooy --- Created attachment 135819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135819=edit Bug 11889: (QA follow-up) Convert to new atomicupdate style The first patch contained an old .sql atomic update. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #61 from Marcel de Rooy --- Created attachment 135818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135818=edit Bug 11889: (QA follow-up) Add POD ground work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy changed: What|Removed |Added Attachment #135813|0 |1 is obsolete|| --- Comment #60 from Marcel de Rooy --- Created attachment 135817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135817=edit Bug 11889: (follow-up) Tests and new get_shared_shelves This is a manual reconstruction of an older patch, that git did not want to apply anymore (sha trouble etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy changed: What|Removed |Added Attachment #135812|0 |1 is obsolete|| --- Comment #59 from Marcel de Rooy --- Created attachment 135816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135816=edit Bug 11889: (QA follow-up) Add entry to sysprefs.sql Also changes the insert in the atomic update to an insert ignore, as we generally do for inserting sysprefs (see updatedatabase). Signed-off-by: Marcel de Rooy Signed-off-by: Cédric Vita -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy changed: What|Removed |Added Attachment #135809|0 |1 is obsolete|| --- Comment #58 from Marcel de Rooy --- Created attachment 135815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135815=edit Bug 11889: (follow-up) Remove share if you are the new owner This will probably be exceptional. But if the staff member already had a share for a private list of the patron he deletes now, he will be the new owner and we should remove the share record. Signed-off-by: Marcel de Rooy Signed-off-by: Cédric Vita -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy changed: What|Removed |Added Attachment #135808|0 |1 is obsolete|| --- Comment #57 from Marcel de Rooy --- Created attachment 135814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135814=edit Bug 11889: Disown a list upon deletion of owner This patch adds a syspref 'ListOwnershipUponPatronDeletion' which decides if all the owner's lists (public and private) are deleted when the owner is deleted, or if the ownership of their public and shared lists are transfered to the user who deleted the owner (private lists that are not shared are always deleted). To test: 1) Apply patch and update database 2) Set the ListOwnershipUponPatronDeletion syspref to 'Transfer...' 3) Set up a superlibrarian user 4) Log in as this superlibrarian user and set up three lists, a public list (maybe named 'public'), and two private lists (named 'private' and 'shared') 5) Log in as this user to the opac (if you haven't already) and share the 'shared' list with someone 6) View the virtualshelves table in mysql to see the three lists you just created under your new user 7) Also view the virtualshelfshares table in mysql to see the 'shared' list 8) Log into the staff client with your regular user (a different user to the one you just created) 9) Search for the user you just created and delete them 10) Go to your lists 11) You should see the 'shared' list under your private lists, and their 'public' list under your public lists, both with you as the owner 12) if you view both the virtualshelves table and the virtualshelfshares table in mysql again, youll see you are now the owner and the 'private' list will no longer exist. 13) Set the ListOwnershipUponPatronDeletion syspref back to 'Delete...' 14) Repeat steps 3 - 10 again (it may help to delete the 'shared' and 'public' lists before you re-create them) 15) You should not see any of the lists you just made under private or public lists this time. To confirm, check the virtualshelves table in mysql and make sure that all three lists have been deleted. Sponsored-by: Catalyst IT Signed-off-by: Cédric Vita Signed-off-by: Marcel de Rooy 2022-06-08 Removed old atomic update. See new follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy changed: What|Removed |Added Attachment #108247|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy changed: What|Removed |Added Attachment #108246|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 Marcel de Rooy changed: What|Removed |Added Attachment #108245|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961 (300 shown) .
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29312] Punctuation: Total number of results: 961 (300 shown) .
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29312 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30813] Refactor TransformMarcToKoha to remove TransformMarcToKohaOneField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30813 --- Comment #49 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
