[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #310 from David Cook --- (In reply to Eugene Espinoza from comment #309) > Hi David! Any updates on this? Thanks! No, no updates on this one. Occasionally, I think about doing a simpler version, but I don't really have the time for it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29623] Cache effective circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29623 --- Comment #35 from David Cook --- (In reply to Jonathan Druart from comment #28) > IMO It's not about refactoring, it's just not possible. get_effective_rule > will still need to get (category, library, itemtype) in parameter. If the > caller has the rule's id, it does not need to ask for the *effective* rule :) I must've misworded my earlier comment. Originally, I meant refactoring to use the ID for doing database updates/deletions. Wasn't really related to the caching. Not sure how that got dragged into it. Totally separate thing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30958] OPAC Overdrive search result page broken for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30958 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30958] OPAC Overdrive search result page broken for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30958 --- Comment #1 from Alex Buckley --- Created attachment 136056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136056=edit Bug 30958: OPAC overdrive search result page broken for translations Note: You will need a valid OverDrive subscription to test this. This patch fixes a JavaScript error thrown on the OPAC overdrive search results page for libraries using translation templates and who don't have the OverDrivePasswordRequired system preference = 'Required'. Test plan: 1. Install the en-NZ translation: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client 2. Enable the en-NZ language: - In the OPACLanguages system preference -> tick 'English New Zealand (en-NZ)' checkbox and untick 'English (en)' 3. Fill in the OverDrive system preferences: - Make sure you set: OverDrivePasswordRequired = "Not required" 4. Perform an OPAC search 5. Click on the Overdrive results link 6. Open the browser console and notice there is a JS error, and the OverDrive results do not load 7. Apply patch 8. Update the en_NZ translation: 9. Repeat steps 4, 5 and 6 and notice there is no JavaScript error and the OverDrive results do display Sponsored-by: Melbourne Athenaeum Library, Australia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30824] Improve performance of BatchCommitItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30824 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30824] Improve performance of BatchCommitItems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30824 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30624] Remove IndependentBranchesLoggedInLibrary in favor of a permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 --- Comment #1 from Lucas Gass --- Created attachment 136055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136055=edit Bug 30624: Add select_loggedin_library permission To test: 1. Apply patch, updatedatabase, restart_all 2. Have a user with superlibrarian privileges ( User1 ) 3. Have a user who has staff access and circulate privileges but is not a super librarian. ( User2 ) Make note of this users home library 4. Turn on the system preference 'CircSidebar'. -MAIN log in ( auth.tt ) 5. As User1, go to the main login screen and try logging in. You should be able to log in AND you should be able to properly chnage your branch BEFORE logging in. 6. As User2, to to the main login screnn amd try logging in. You should be able to but if you try and switch your libraray to anything beside the user's home branch it will not work. You will be logged in at your home branch. 7. For User2, set the new permission 'select_loggedin_library' on. 8. Now you should be able to successfully switch libraries before log in. 9. Turn the 'select_loggedin_library' back off for User2. -AFTER log in- 10. With User1, click on your name/branch in the top right, you should see the the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the link will be 'Set library and desk'. 11. With User2, click on your name/branch in the top right. If you have 'UseCirculationDesks' on, you should see 'Set desk', otherwise you should see nothing. 12. Repeat step 7. 13. NOw if you click on your name/branch in the top right, you should see the the link 'Set library' at the top. If you turn on 'UseCirculationDesks' the link will be 'Set library and desk'. 14. Repeat Step 9. -CircSideBar- 15. With 'CircSideBar' turned on, go to any ciculation page (Holds queue, Holds to pull, Holds awaiting pickup) with User1. You will see the 'Set library' link. If 'UseCirculationDesks' is on you will see a 'Set library and desk'. 16. Try with User2 and you will not see a 'Set library' link. If 'UseCirculationDesks' is on you will see a 'Set desk' link. 17. Repeat step 7. 18. For with User2 you go to any ciculation page (Holds queue, Holds to pull, Holds awaiting pickup). You will see the 'Set library' link. If 'UseCirculationDesks' is on you will see a 'Set library and desk'. 19. Repeat step 9. -Set library page- 20. Go to the set library page (http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User1. You will see a dropdown for 'Set library'. Make sure you can change your library successfully. 21. Go to the set library page (http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. You should NOT see see a dropdown for 'Set library'. 22. Repeat step 7. 23. Go to the set library page (http://localhost:8081/cgi-bin/koha/circ/set-library.pl) with User2. Now you should see a dropdown for 'Set library'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30958] OPAC Overdrive search result page broken for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30958 Alex Buckley changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30958] OPAC Overdrive search result page broken for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30958 Alex Buckley changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23713] Subscription add form broken for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30958 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30958] OPAC Overdrive search result page broken for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30958 Alex Buckley changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23713 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30958] New: OPAC Overdrive search result page broken for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30958
Bug ID: 30958
Summary: OPAC Overdrive search result page broken for
translations
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: I18N/L10N
Assignee: koha-bugs@lists.koha-community.org
Reporter: alexbuck...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr
If a library does not have the OverDrivePasswordRequired system preference =
'Required' then translated OPAC Overdrive search result pages throw a
JavaScript error and do not display results.
The problematic line (below) in the English template is:
var OD_password_required = [% IF Koha.Preference('OverDrivePasswordRequired')
%]1[% ELSE %]0[% END %];
Which is translated to the following in the en-NZ (and other languages)
template:
var OD_password_required = [% IF Koha.Preference('OverDrivePasswordRequired')
%]1[% ELSE %][% END %];
Like in bug 23713 the line is translated to:
var OD_password_required = ;
When it should be:
var OD_password_required = 0;
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30946] Error in database update 21.12.00.048
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30946 --- Comment #13 from victor --- (In reply to victor from comment #12) > (In reply to victor from comment #11) > > (In reply to Fridolin Somers from comment #10) > > > (In reply to victor from comment #4) > > > > > > > > In Ubuntu 20.04.4 LTS > > > > > > > > mysql Ver 15.1 Distrib 10.4.14-MariaDB, for debian-linux-gnu (x86_64) > > > > using > > > > readline 5.2 > > > > > > > > > > Hi, > > > > > > We have servers with Ubuntu 20.04 Focal and MariaDB 10.4. > > > Can't reproduce. > > > > > > I see Ubuntu package is on MariaDB 10.3 : > > > https://packages.ubuntu.com/search?suite=focal- > > > updates=names=mariadb-server > > > > > > We install mariaDB with its repo : > > > deb [arch=amd64,arm64] > > > https://downloads.mariadb.com/MariaDB/mariadb-10.4/repo/ubuntu focal main > > > And we hace 10.4.25-MariaDB. > > > > > > How did you install MariaDB ? 10.4.14 is quite late. > > > > Install with sudo apt install mariadb-server > Not really I believe it is not in the repo Does koha 22.05 with Ubuntu 20.04 and 10.4.25-MariaDB work correctly? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30946] Error in database update 21.12.00.048
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30946 --- Comment #12 from victor --- (In reply to victor from comment #11) > (In reply to Fridolin Somers from comment #10) > > (In reply to victor from comment #4) > > > > > > In Ubuntu 20.04.4 LTS > > > > > > mysql Ver 15.1 Distrib 10.4.14-MariaDB, for debian-linux-gnu (x86_64) > > > using > > > readline 5.2 > > > > > > > Hi, > > > > We have servers with Ubuntu 20.04 Focal and MariaDB 10.4. > > Can't reproduce. > > > > I see Ubuntu package is on MariaDB 10.3 : > > https://packages.ubuntu.com/search?suite=focal- > > updates=names=mariadb-server > > > > We install mariaDB with its repo : > > deb [arch=amd64,arm64] > > https://downloads.mariadb.com/MariaDB/mariadb-10.4/repo/ubuntu focal main > > And we hace 10.4.25-MariaDB. > > > > How did you install MariaDB ? 10.4.14 is quite late. > > Install with sudo apt install mariadb-server Not really I believe it is not in the repo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass changed: What|Removed |Added Blocks|30624 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 [Bug 30624] Remove IndependentBranchesLoggedInLibrary in favor of a permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30624] Remove IndependentBranchesLoggedInLibrary in favor of a permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Lucas Gass changed: What|Removed |Added Depends on|29887 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Bug 29887 depends on bug 30387, which changed state. Bug 30387 Summary: IndependentBranches allows users to change libraries when they should not be able to https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30387] IndependentBranches allows users to change libraries when they should not be able to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30387 Lucas Gass changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #11 from Lucas Gass --- Since we need to move this logic from the system preference IndependentBranchesLoggedInLibrary into a permission, I am resolving this bug and will work on adding the permission in Bug 30624. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30624] Remove IndependentBranchesLoggedInLibrary in favor of a permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624 Bug 30624 depends on bug 29887, which changed state. Bug 29887 Summary: Create system preference IndependentBranchesLoggedInLibrary https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 What|Removed |Added Status|BLOCKED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29887] Create system preference IndependentBranchesLoggedInLibrary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29887 Lucas Gass changed: What|Removed |Added Resolution|--- |INVALID Status|BLOCKED |RESOLVED --- Comment #22 from Lucas Gass --- Since we need to move this logic from the system preference IndependentBranchesLoggedInLibrary into a permission, I am resolving this bug and will work on adding the permission in Bug 30624. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Fridolin Somers changed: What|Removed |Added Attachment #136021|0 |1 is obsolete|| --- Comment #65 from Fridolin Somers --- Created attachment 136054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136054=edit Bug 30733: Split strings differently Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Fridolin Somers changed: What|Removed |Added Attachment #136020|0 |1 is obsolete|| --- Comment #64 from Fridolin Somers --- Created attachment 136053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136053=edit Bug 30733: fix url => URL to merge with existing string Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Fridolin Somers changed: What|Removed |Added Attachment #136019|0 |1 is obsolete|| --- Comment #63 from Fridolin Somers --- Created attachment 136052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136052=edit Bug 30733: Undo some additions that don't yield good strings They need more complex solutions that would be better in a follow up ticket to not drag this one too long. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Fridolin Somers changed: What|Removed |Added Attachment #136018|0 |1 is obsolete|| --- Comment #62 from Fridolin Somers --- Created attachment 136051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136051=edit Bug 30733: Simplify some singular cases To be sure translators don't think it's wrong and translate it plurally. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Fridolin Somers changed: What|Removed |Added Attachment #136017|0 |1 is obsolete|| --- Comment #61 from Fridolin Somers --- Created attachment 136050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136050=edit Bug 30733: Undo in an ICS calendar file Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Fridolin Somers changed: What|Removed |Added Attachment #136016|0 |1 is obsolete|| --- Comment #60 from Fridolin Somers --- Created attachment 136049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136049=edit Bug 30733: Wrap one more string in Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Fridolin Somers changed: What|Removed |Added Attachment #136015|0 |1 is obsolete|| --- Comment #59 from Fridolin Somers --- Created attachment 136048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136048=edit Bug 30733: Undo bad handling of a plural case Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Fridolin Somers changed: What|Removed |Added Attachment #136014|0 |1 is obsolete|| --- Comment #58 from Fridolin Somers --- Created attachment 136047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136047=edit Bug 30733: Fix string context lost due to being in two parts Due to conditions. Things like "Edit batch" need to be keept in one strings. Also removed some capitalization because it wasn't needed and wasn't consistend with and which had now capitalization. Also fixed patron edit-batch.tt and edit-layout.tt because they were incomplete in regard to their label counterparts. They had the condition on description and batch_id but weren't displaying anything different between the two cases. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Fridolin Somers changed: What|Removed |Added Attachment #136013|0 |1 is obsolete|| --- Comment #57 from Fridolin Somers --- Created attachment 136046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136046=edit Bug 30733: Move all semicolons inside the translatable strings In the 1st patch, sometimes they where left out Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Fridolin Somers changed: What|Removed |Added Attachment #136012|0 |1 is obsolete|| --- Comment #56 from Fridolin Somers --- Created attachment 136045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136045=edit Bug 30733: Simplify translatable strings And a few minor fixes when they where causing issues for translatability. And rephrased a string about password reset to have it identical to other strings with the same meaning. Simplified via wrapping strings with to split to huge concatenated strings with a lot of %s everywhere. == Test plan == This patch needs mainly proof reading. Still it's possible to do some basic testing to demonstrate that adding a in an IF doesn't break anything. Pick in one of the 110 modified templates a string that you know how to display. Otherwise: 1. acquisitions => vendor => basket => add to basket => search "from existing record" => add order 2. Cancel the order 3. You see without issue "Bibliographic record will not be deleted" 4. administration => Patron categories 5. Try to delete a used and unused category 6. You see as expected Category is in use. Deletion not possible! and Confirm deletion of category Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30733] Simplify translatable strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30733 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951 --- Comment #3 from victor --- (In reply to Fridolin Somers from comment #2) > Hi, > > We have seen this one only once, on a very old database (started at 3.2). > > We detect it with : > MariaDB [koha]> SELECT language_subtag,GROUP_CONCAT(script_subtag SEPARATOR > ' | '),COUNT(*) AS nb\ > -> FROM language_script_mapping GROUP BY language_subtag HAVING nb > > 1; > +-+-++ > | language_subtag | GROUP_CONCAT(script_subtag SEPARATOR ' | ') | nb | > +-+-++ > | ar | Arab | Arab | 2 | > | he | Hebr | Hebr | 2 | > +-+-++ > > And fix with : > DELETE FROM language_script_mapping WHERE language_subtag = 'ar' LIMIT 1 ; > DELETE FROM language_script_mapping WHERE language_subtag = 'he' LIMIT 1 ; Thank you very much! The issue was resolved with your guidance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #2 from Fridolin Somers --- Hi, We have seen this one only once, on a very old database (started at 3.2). We detect it with : MariaDB [koha]> SELECT language_subtag,GROUP_CONCAT(script_subtag SEPARATOR ' | '),COUNT(*) AS nb\ -> FROM language_script_mapping GROUP BY language_subtag HAVING nb > 1; +-+-++ | language_subtag | GROUP_CONCAT(script_subtag SEPARATOR ' | ') | nb | +-+-++ | ar | Arab | Arab | 2 | | he | Hebr | Hebr | 2 | +-+-++ And fix with : DELETE FROM language_script_mapping WHERE language_subtag = 'ar' LIMIT 1 ; DELETE FROM language_script_mapping WHERE language_subtag = 'he' LIMIT 1 ; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30946] Error in database update 21.12.00.048
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30946 --- Comment #11 from victor --- (In reply to Fridolin Somers from comment #10) > (In reply to victor from comment #4) > > > > In Ubuntu 20.04.4 LTS > > > > mysql Ver 15.1 Distrib 10.4.14-MariaDB, for debian-linux-gnu (x86_64) using > > readline 5.2 > > > > Hi, > > We have servers with Ubuntu 20.04 Focal and MariaDB 10.4. > Can't reproduce. > > I see Ubuntu package is on MariaDB 10.3 : > https://packages.ubuntu.com/search?suite=focal- > updates=names=mariadb-server > > We install mariaDB with its repo : > deb [arch=amd64,arm64] > https://downloads.mariadb.com/MariaDB/mariadb-10.4/repo/ubuntu focal main > And we hace 10.4.25-MariaDB. > > How did you install MariaDB ? 10.4.14 is quite late. So should I upgrade to version 10.4.25-MariaDB? Could this cause any problems with koha installations? And that should solve my problem? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30946] Error in database update 21.12.00.048
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30946 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #10 from Fridolin Somers --- (In reply to victor from comment #4) > > In Ubuntu 20.04.4 LTS > > mysql Ver 15.1 Distrib 10.4.14-MariaDB, for debian-linux-gnu (x86_64) using > readline 5.2 > Hi, We have servers with Ubuntu 20.04 Focal and MariaDB 10.4. Can't reproduce. I see Ubuntu package is on MariaDB 10.3 : https://packages.ubuntu.com/search?suite=focal-updates=names=mariadb-server We install mariaDB with its repo : deb [arch=amd64,arm64] https://downloads.mariadb.com/MariaDB/mariadb-10.4/repo/ubuntu focal main And we hace 10.4.25-MariaDB. How did you install MariaDB ? 10.4.14 is quite late. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30946] Error in database update 21.12.00.048
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30946 --- Comment #9 from victor --- (In reply to Jonathan Druart from comment #6) > Cannot recreate on 10.5.16-MariaDB-1 Sorry but I did not understand, There's no solution for the version of the bank I'm using? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30946] Error in database update 21.12.00.048
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30946 --- Comment #8 from Nick Clemens --- https://jira.mariadb.org/browse/MDEV-22775 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30946] Error in database update 21.12.00.048
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30946 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Cannot recreate on Server version: 5.5.5-10.4.25-MariaDB-1:10.4.25+maria~focal mariadb.org binary distribution -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Shi Yao Wang changed: What|Removed |Added Resolution|WORKSFORME |--- Status|RESOLVED|REOPENED --- Comment #65 from Shi Yao Wang --- Here is a patch that fixes the missing checkin message without changing code in _calculate_new_debar_dt or _debar_user_on_return. So it shouldn't affect other functionality too much. It shouldn't cause additional test fails. Only little thing is that it duplicates the code because it has the same block of code (inside elsif). What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #13 from Jonathan Druart --- All fixed, thanks a lot, Owen! This patch is simply doing what the bug title is describing, nothing else. I found it when I was opening a new one. We could still move to select2 later, it will be easier with this move anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #12 from Jonathan Druart --- Created attachment 136044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136044=edit Bug 30578: Fix multi-terms search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #11 from Jonathan Druart --- Created attachment 136043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136043=edit Bug 30578: Remove ajaxSetup from checkouts.js It was a IE fix apparently commit f021b52e71deaac0b46992fa33ef02f2b001e56d Bug 11703 [QA Followup] - Stop IE from caching ajax request -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #10 from Jonathan Druart --- Created attachment 136042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136042=edit Bug 30578: Fix on-select for 2 occurrences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #9 from Jonathan Druart --- Created attachment 136041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136041=edit Bug 30578: Restore highlighting of patrons from the logged-in library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951 Katrin Fischer changed: What|Removed |Added Severity|enhancement |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29605] DB structure may not be synced with kohastructure.sql
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Katrin Fischer changed: What|Removed |Added Blocks||30951 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951 [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30951] Duplicate entry 'ar' for key 'PRIMARY'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30951 Katrin Fischer changed: What|Removed |Added Depends on||29605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 [Bug 29605] DB structure may not be synced with kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Shi Yao Wang changed: What|Removed |Added Attachment #112724|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Shi Yao Wang changed: What|Removed |Added CC||shi-yao.w...@inlibro.com Attachment #112725|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 --- Comment #64 from Shi Yao Wang --- Created attachment 136040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136040=edit Bug 14784: Fix checkin message for restricted patrons Test plan: Before 1) Select a user with active indefinite or definite restrictions (manual restriction works) 2) Make sure finesday=0 for the user category. See [1] 3) Checkout and return an item (not overdue) A previous restriction reminder will appear 4) Checkout and return an overdue item (change the date at cehckout) No previous restriction reminder will appear After applying patch: Same steps, but a reminder should appear for step 4) [1] The "finesday" setting is called "Suspension in days" in the web interface, if you're searching for it like I did... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard --- Sorry Kyle, now it's saving all the calendar entries as if they are due at the moment I downloaded the iCal file. All items due at the same minute. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #8 from Owen Leonard --- In case there's any confusion based on my previous comment, I'm not saying that this patch should be switched to use Select2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 --- Comment #10 from Kyle M Hall --- I think this latest revision satisfies everyone. With it, all items due at midnight will be all day events, and all items due at a specific time will be instantaneous events! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard --- > I basically wondered if Select2 > was the better option for at least some of the occurrences where we were > using this customer ysearch service. As I said to Martin in IRC, if Select2 can do everything we need I'm in favor of switching. That would mean we wouldn't have to add another JS library when we're ready to get rid of jQueryUI altogether. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall changed: What|Removed |Added Attachment #136038|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 136039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136039=edit Bug 30927 - Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. Test Plan: 0) Make sure your time zone in Koha is set correctly in koha-conf.xml 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout is an "instantaneous" event at the date and time the item is due -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #6 from Owen Leonard --- I found a couple of issues: - The colored highlighting of patrons from the user's logged-in branch isn't working anymore - The circulation and patron header searches don't do anything when you click one of the autocomplete results - The search doesn't work with more than one term. With the old ysearch I could type "leonard owen" or "owen leonard" and get the correct result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall changed: What|Removed |Added Attachment #135907|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 136038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136038=edit Bug 30927 - Improve formatting or iCal files for checkout due dates We got some feedback from a patron regarding the default notifications on the iCal export for the patron checkout summary in the OPAC. The notifications send 1 minute before the event (the due date), which is midnight. Test Plan: 0) Make sure your time zone in Koha is set correctly in koha-conf.xml 1) Apply this patch 2) Restart all the things! 3) Make a checkout due at 23:59 4) Make a checkout due at 11:00 5) Download the iCal file from the OPAC 6) Import this file into Calendar 7) Note the first checkout is an all day event 8) Note the second checkout is an "instantaneous" event at the date and time the item is due -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30927] Improve formatting or iCal files for checkout due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30927 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #24 from Lucas Gass --- Created attachment 136037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136037=edit Bug 10950: (follow-up) fix typo in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29952] Filter Paid Transactions Broken on Transactions tab in Staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 --- Comment #17 from Katrin Fischer --- Sure :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29952] Filter Paid Transactions Broken on Transactions tab in Staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29952 --- Comment #16 from Victor Grousset/tuxayo --- I should still be able to backport and push to the branch. Does that help? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30957] Koha link blocked in all MARC bibliographic framewoks subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30957 Katrin Fischer changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30957] Koha link blocked in all MARC bibliographic framewoks subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30957 --- Comment #1 from Katrin Fischer --- Hi Mercedes, this is not a bug, but could maybe be handled a little in the GUI. Koha links are now solely set from Administration > Koha to MARC mappings. Then you'll see the mapping in the framework configuration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30931] Handling of items.dateaccessioned in the item editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov --- Comment #7 from Heather --- Hi! Thank you for bringing this bug to the attention of the Koha-US CatSIG! I don't have a strong opinion on this behavior, but I'll monitor this bug & see if discussion is generated, and be sure that any discussion on the CatSIG email list makes its way into comments here--and if there isn't any discussion and the bug is still under discussion by our next meeting (July 7, 2022), I'll bring it up in the meeting to call additional attention to it & encourage commenting here. Cheerio! h2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30578] We should drop circ/ysearch.pl in preference to using the REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578 --- Comment #5 from Martin Renvoize --- Interesting; I will have to take a deeper look at what you've done here. When I first submitted this bug I was working on the bookings submission and I opted to use Select2 for patron selection. I basically wondered if Select2 was the better option for at least some of the occurrences where we were using this customer ysearch service. I felt there was a clear mix of two things.. actual autocomplete in a search box and what was really just a select in a form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #36 from Owen Leonard --- This is working well, but I think we ought to wait and rework the autocomplete parts of it after Bug 30578 makes progress. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #35 from Owen Leonard --- Created attachment 136036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136036=edit Bug 25498: Transfer ownership shared list on OPAC Test plan: Pick or create a shared list. Login as owner. Transfer to one of the other members. Verify that you do no longer have Transfer, but see Remove share. Login as the other member. Transfer it back. Bonus: Working with two tabs, you can open the Transfer form and in the meantime delete the list, the patron or remove the share. Or change permissions. Submit after that and check the error message. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #34 from Owen Leonard --- Created attachment 136035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136035=edit Bug 25498: Show transfer button for shared lists on OPAC Test plan: Pick or create a shared list. Verify that OPAC only shows the Transfer button when you are the owner of a shared list. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 --- Comment #33 from Owen Leonard --- Created attachment 136034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136034=edit Bug 25498: Add a transfer form for public lists Test plan: [1] Valid transfer: Log in with staff patron C having edit_public_lists. Pick a public list. Choose Transfer. Select a patron. Submit and check if transfer was successful. [2] Permission problem: Pick a staff user D. Temporary enable edit_public_lists. Add another private tab. Login with D. Pick a public list. Transfer. Choose another patron. Wait. Switch tab: remove added permission from D. Switch tab again: Submit transfer form. Error? Close tab. [3] Bonus test - Shelf disappeared: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete the selected public list. Close tab. Submit the transfer. Not exist error? [4] Bonus test - Patron not found: Pick a public list. Transfer. Choose another patron. Wait. Open another tab. Delete selected patron. Close tab. Submit transfer. Patron not found error? Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Owen Leonard changed: What|Removed |Added Attachment #136008|0 |1 is obsolete|| Attachment #136009|0 |1 is obsolete|| Attachment #136010|0 |1 is obsolete|| Attachment #136011|0 |1 is obsolete|| --- Comment #32 from Owen Leonard --- Created attachment 136033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136033=edit Bug 25498: Add transfer button on intranet Note: Adjusting shelves_results template too for not allowing delete when you do not have delete_public_lists (or higher). If you are the owner, you are allowed to edit or delete. But transfer specifically needs edit_public_lists (or higher). Note: Removed a few useless POD lines to make qa tools happy. Test plan: Check if you see the transfer button on public lists only when having permission edit_public_lists (or higher). And never on private lists. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25498] Allow to change owner of public or shared list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30780] Librarians with only "place_holds" permissions can not update holds data via REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30780 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30780] Librarians with only "place_holds" permissions can not update holds data via REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30780 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30780] Librarians with only "place_holds" permissions can not update holds data via REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30780 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Kyle M Hall from comment #5) > Would be nice to see unit tests to prove the minimum user permissions needed > work. Good catch, done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30780] Librarians with only "place_holds" permissions can not update holds data via REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30780 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 136032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136032=edit Bug 30780: Librarians with only "place_holds" permissions can not update holds data via REST API This patch enables librarians with only "place_holds" permissions to cancel, suspend and resume holds via REST API. Test plan: 1) Try to cancel or suspend a hold with only "place_holds" permissions 2) See that it is forbidden. 3) Apply the patch 4) Cancel a hold again 5) The cancellation succeeds 6) prove t/db_dependent/api/v1/holds.t Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30780] Librarians with only "place_holds" permissions can not update holds data via REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30780 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 136031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136031=edit Bug 30780: Regression tests This patch lowers the used permissions on the suspend/resume tests, and adds tests for fine-grained permissions on cancelling a hold. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30780] Librarians with only "place_holds" permissions can not update holds data via REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30780 Tomás Cohen Arazi changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30780] Librarians with only "place_holds" permissions can not update holds data via REST API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30780 Tomás Cohen Arazi changed: What|Removed |Added Attachment #135946|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30900] "Error searching for analytic records"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30900 John Yorio changed: What|Removed |Added CC||jyo...@equinoxinitiative.or ||g -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 Tomás Cohen Arazi changed: What|Removed |Added Assignee|janus...@gmail.com |jonathan.druart+koha@gmail. ||com CC||tomasco...@gmail.com Keywords||rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #16 from Katrin Fischer --- Hi Aleisha, sorry for taking so long to give feedback on this patch. It took a while to wrap my head around and I hope my notes make sense. > Thanks Katrin - the host item feature isn't something I've used before so > some context and more specific feedback would be useful! I'll try! We'd create an analytical record a litle different than in your test plan, as we can't use the EasyAnalytics feature that relies on creating 773 fields in the MARC record. For our records the union catalog is the primary database and the link between the record and its host item would be created there. This would resemble our workflow a little better in Koha: * Search for a serial or monograph record in the staff interface * From the detail page: New > New child record * This opens a new record in the cataloguing editor with a 773 created from the information of its 'parent' record. If you are using controlnumber for linking, the 001 of the host will be in $w of the child used for linking by ID. * Add 773$g with information on the location of the 'child' within the 'parent' (i.e. volume, issue, pages) Example: $g 13(1917), 12, p. 98-104 There is sample record set on bug 11175, that's a good starting point. For testing I have added $g and removed $w in some records. =XSLT based displays (list view in OPAC)= * I think currently the result page uses a copy of the 773 code from the detail page, but they have fallen out of sync. For example missing the change from bug 20277. Could you please move the code into MARC21slimUtils.xsl as a new template, so we can use the same logic in detail and result page? Nick did something similar on bug 5927. * We should probably note in the test plan that the changes to the XSLT will also apply to the normal result list in the catalog and staff interface. =TT based displays (cart detail, list detail, cart email, list email)= You used get_marc_host for finding the host record and the include for displaying the title here, which I think is a neat approach. I really like that it allows us to create a direct link using the biblionumber instead of the more complicated search link using $w or $a$t. But as usual, there are some caveats with libraries. :( At the moment the 773 will only show when the library has been using $w/001 for linking, which is often not the case. We also have some cases, where an 'unlinked' 773 without $w will be added/imported in our catalogs. * It would be nice if we could still be using get_marc_host somehow, but we might need at least a fallback to create the display using 773$atg directly. 773 should only display if there is at least a $t. I think when there is no $w just displaying the plain text without a link would be ok and still a nice improvement. * Can you please add 773$g to display? It looks like get_marc_host will return it if called in list context. * virtualshelves/sendshelf.pl still has $biblio->get_host_item_entries, maybe from a previous version of this patch? * Release notes and test plan also mention $biblio->get_host_item_entries, but I think it was replaced by get_marc_host. * The FOREACH in the templates might not be needed if we keep using get_marc_host as it only looks at the first 773. * The 'label' for 773 is usually "In:" in the detail and other views. Can you please make the TT views match? Currently they are using 'Host item entry' or 'Host item entries' or 'Source' (XSLT results). About comment#14 from David: * I couldn't test the email part, apart from reading the code, but maybe you could check the the links? I'll certainly try his test plan for email next iteration :) * I didn't have the issue with the cart in the staff interface that David noted, but I think the list issue is due to the wrong method name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 --- Comment #12 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30904] (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30904 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30798] Columns Home library and Checked out from in wrong order on table settings for account_fines table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30798 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30798] Columns Home library and Checked out from in wrong order on table settings for account_fines table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30798 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30957] New: Koha link blocked in all MARC bibliographic framewoks subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30957 Bug ID: 30957 Summary: Koha link blocked in all MARC bibliographic framewoks subfields Change sponsored?: --- Product: Koha Version: 22.05 Hardware: PC OS: Windows Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: mportu...@ign.gob.ar QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Created attachment 136030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136030=edit Shows Koha link being blocked in Marc subfield There was no way in which we could unblocked Koha link in MARC subfields in version 22.05 and 21.11. They are present in all MARC fields but we want to use it particullary in 76x-78x LINKING MARC FIELDS. I add two images to help you see the problem. We are using Koha link in the 17 old version with no difficulty. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912 Tomás Cohen Arazi changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Keywords||rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912
Nick Clemens changed:
What|Removed |Added
Attachment #136028|0 |1
is obsolete||
--- Comment #16 from Nick Clemens ---
Created attachment 136029
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136029=edit
Bug 30912: Fix db rev 21.12.00.016
This is a mix of Nick's patch and Jonathan's comment on it. I tested it
with KTD using MySQL 8 and it works correctly.
To test:
1. Launch KTD with bells and whistles:
$ docker compose -f docker-compose.yml \
-f docker-compose.mysql8.0.yml \
up -d
2. Inside of it, do:
$ koha-mysql kohadev
> update systempreferences set value="21.1200015" where variable="version";
> \q
$ restart_all
$ updatedatabase
=> SUCCESS: All good :-D
3. Run:
$ koha-mysql kohadev
> update systempreferences set value="21.1200015" where variable="version";
> ALTER TABLE user_permissions DROP PRIMARY KEY;
> \q
$ updatedatabase
=> FAIL: You get:
Upgrade to 21.12.00.016 [12:47:09]: Bug 30060 - Update user_permissions to add
primary key and remove null option from code column
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You have an error
in your SQL syntax; check the manual that corresponds to your MySQL server
version for the right syntax to use near 'IF EXISTS `PRIMARY`' at line 1 at
/kohadevbox/koha/C4/Installer.pm line 739
4. Apply this patch
5. Run:
$ updatedatabase
=> SUCCESS: Update goes well
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30912] Database update fails for 21.12.00.016 Bug 30060
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30912
Nick Clemens changed:
What|Removed |Added
Attachment #135958|0 |1
is obsolete||
Attachment #136024|0 |1
is obsolete||
--- Comment #15 from Nick Clemens ---
Created attachment 136028
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136028=edit
Bug 30912: Fix db rev 21.12.00.016
This is a mix of Nick's patch and Jonathan's comment on it. I tested it
with KTD using MySQL 8 and it works correctly.
To test:
1. Launch KTD with bells and whistles:
$ docker compose -f docker-compose.yml \
-f docker-compose.mysql8.0.yml \
up -d
2. Inside of it, do:
$ koha-mysql kohadev
> update systempreferences set value="21.1200015" where variable="version";
> \q
$ restart_all
$ updatedatabase
=> SUCCESS: All good :-D
3. Run:
$ koha-mysql kohadev
> update systempreferences set value="21.1200015" where variable="version";
> ALTER TABLE user_permissions DROP PRIMARY KEY;
> \q
$ updatedatabase
=> FAIL: You get:
Upgrade to 21.12.00.016 [12:47:09]: Bug 30060 - Update user_permissions to add
primary key and remove null option from code column
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: You have an error
in your SQL syntax; check the manual that corresponds to your MySQL server
version for the right syntax to use near 'IF EXISTS `PRIMARY`' at line 1 at
/kohadevbox/koha/C4/Installer.pm line 739
4. Apply this patch
5. Run:
$ updatedatabase
=> SUCCESS: Update goes well
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28371] Improve performance of XSLTParse4Display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28371 --- Comment #46 from Martin Renvoize --- 30920 is where the real performance improvement comes from now.. 30848 is just some code cleaning to allow wider adoption of the value expansion code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30924] Fix recalls-related errors in transfers and cancelling actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 --- Comment #17 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30924] Fix recalls-related errors in transfers and cancelling actions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30924 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30914] cleanup_database.pl --transfers --old-reserves --confirm does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30914 --- Comment #5 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30914] cleanup_database.pl --transfers --old-reserves --confirm does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30914 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30883] Authorities merge is limited to 100 biblio with Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30883 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
