[Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

--- Comment #7 from Alex Buckley  ---
Created attachment 138111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138111=edit
Bug 31217: OPAC coce.js is not hiding the coce-coverimg div for single-pixel
images

This is because opac-detail.tt has coce-coverimg as an ID, but OPAC
coce.js targets coce-coverimg as a class.

opac-detail.tt should be changed to have coce-coverimg as a class.

Test plan:
1. Set your system preferences:
- CoceHost = https://coce.mykoha.co.nz
- CoceProviders = Select all
- OpacCoce = Enable

2. Add the ISBN of '9780262336499' to a biblio

3. Open a "Incognito" window in your browser (recommended to use Google
Chrome to test this)

4. View the biblio detail page in the OPAC. Observe a 'Coce image from
Amazon' box loads with a spinner

5. Apply patch and restart services

6. Clear your browser cache

7. Reload the same biblio detail page in the OPAC. Observe no image is
displayed.

8. View another OPAC biblio detail page that does have a successfully
loading coce image and confirm the source of that image is listed: For
example 'Coce image from Amazon.com' is displayed

Sponsored-by: Toi Ohomai Institute of Technology, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

Alex Buckley  changed:

   What|Removed |Added

 Attachment #138070|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #50 from Aleisha Amohia  ---
(In reply to Katrin Fischer from comment #48)

> I have created 3 orders:
> 2022-07-30
> 2022-07-19
> NULL - calculated from 10 days in vendor: 2022-07-29
> 
> When I search for:
> - 2022-07-01 - 2022-07-30  - OK, all show
> - 2022-07-01 - 2022-07-29  - NOT OK, still all three show, but 30 should not
> - 2022-07-01 - 2022-07-27  - NOT OK, 30t and 19 show, but 29, the calculated
> one does not
> 
> I've tried the dd.mm. and the -mm-dd Dateformat settings and the
> behaviour is the same. Can you help?
> 

Still working on this

> Are moddelivery.tt/.pl fallbacks for no JavaScript?

Yes, it matches the behaviour of the internal and vendor notes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348

--- Comment #49 from Aleisha Amohia  ---
Created attachment 138110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138110=edit
Bug 15348: (follow-up) Fix modal to edit delivery date

This allows you to empty the delivery date and ensures the current date
shows

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31212] Datelastseen should be a datetime

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212

Andreas Roussos  changed:

   What|Removed |Added

 CC||a.rous...@dataly.gr

--- Comment #3 from Andreas Roussos  ---
Hi Michal,

I concur with Sally; your patch, as it stands, does not work 100%.
However, fear not! The Community is here to help! ;-)

Since you're changing a column definition in the DB, you may want
to have a look at these guidelines:
https://wiki.koha-community.org/wiki/Database_updates

The gist of it is that when you alter the database schema, you need
to accommodate for both
a) new installations (which you did by modifying the installer's DB
   structure in installer/data/mysql/kohastructure.sql), *and*
b) existing installations by means of creating an atomicupdate file.

Also, since the DATETIME column will now be able to store the exact
time the item was last seen down to the second, you'll have to ensure
the timestamp is stored with the correct accuracy in the DB.

Finally, don't forget the unit tests whenever you want to submit a
patch, as they can help you find oversights in your submitted code.
As usual, the details are in the Wiki:
https://wiki.koha-community.org/wiki/Unit_Tests#Good_practices_for_running_tests

I hope this helps!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30988] Add generic OpenIDConnect client implementation

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30988

--- Comment #51 from David Cook  ---
(In reply to Katrin Fischer from comment #50)
> (In reply to David Cook from comment #47)
> > (In reply to Katrin Fischer from comment #43)
> > > We are happy to have you for this cycle too if you are interested. In the
> > > summer time (Europe etc.) we are always struggling a bit more.
> > 
> > Sounds good to me. Do we need to do anything for me to re-gain my QA genie
> > powers?
> 
> I think adding yourself to the roles page will suffice ;)
> https://wiki.koha-community.org/wiki/Roles_for_22.11

Ah right. I think I meant to add myself for 23.05 but accidentally added myself
to 22.11 previously. Happy accident!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields)

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412

--- Comment #11 from David Cook  ---
(In reply to David Cook from comment #10)
> On the topic of standards, I think that this is my favourite MARC field:
> 
> 887 - Non-MARC Information Field (R)
> https://www.loc.gov/marc/bibliographic/bd887.html
> 
> I think it was probably intended for XML data outside the MARC schema, but
> I've seen some wild things in there before...

Technically, I would say that XHTML is allowed in the 887 at least.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields)

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412

--- Comment #10 from David Cook  ---
On the topic of standards, I think that this is my favourite MARC field:

887 - Non-MARC Information Field (R)
https://www.loc.gov/marc/bibliographic/bd887.html

I think it was probably intended for XML data outside the MARC schema, but I've
seen some wild things in there before...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23412] HTML should be allowed in MARC notes. (5xx fields)

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23412

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #9 from David Cook  ---
(In reply to Lucas Gass from comment #8)
> (In reply to Katrin Fischer from comment #7)
> > I am still not sure we should bend the standard like that... especially as
> > it will break things like the sample below with the <> as part of the text.
> 
> I think you are correct and we should not bend the standard like this,
> marking this as wont fix.

I'm not sure I follow. Which standard would be bent by allowing HTML?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272

--- Comment #69 from Peter Vashchuk  ---
Created attachment 138109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138109=edit
Bug 27272: Add search_ordered sub to order items with extra conditions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel cover images in both the staff client detail and results pages

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

--- Comment #4 from Alex Buckley  ---
(In reply to Jonathan Druart from comment #3)
> That's certainly the best we can do, yes.
> We could also search for the ID and fallback to class if it does not exist.
> 
> The main challenge in my opinion is to keep both opac and staff code as
> similar as possible (ie. switch to class for the OPAC if we decide so for
> staff)

Ahh yep, thanks for that Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31211] Check slips and notices for valid Template Toolkit and report errors

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

--- Comment #6 from Katrin Fischer  ---
Created attachment 138108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138108=edit
Bug 31211: (QA follow-up) Add class to new list element for error

To allow additional styling the class template_toolkit_error was
added to the list element.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31211] Check slips and notices for valid Template Toolkit and report errors

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31211] Check slips and notices for valid Template Toolkit and report errors

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137985|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 138107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138107=edit
Bug 31211: Check slips and notices for valid Template Toolkit and report errors

It would be useful for Koha to run a basic TT validation test and report back
errors.
That way if somebody misses an END tag or something of that nature, it will be
easy to find and fix.

Test Plan:
1) Apply this patch
2) Edit a notice, change the content to simply "[% END %]"
   or some other invalid Template Toolkit
3) Choose "Save and continue editing"
4) Note the new "Template Toolkit error" field that displays the error
   message

Signed-off-by: Sally 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31211] Check slips and notices for valid Template Toolkit and report errors

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31211] Check slips and notices for valid Template Toolkit and report errors

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31211

--- Comment #4 from Katrin Fischer  ---
As I was recently suffering a lot from "Internal server error" on testing
notices, I really like the idea of this.

Of course, the errors are English only and quite technical. And maybe the error
could stand out a bit more. 

I have added a CSS class to the new list element in a follow-up, so libraries
will be able to do additional styling or even hide it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31225] Spine label formatting in PDF is not rendering correctly

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31225

--- Comment #1 from Katrin Fischer  ---
The callnumbers running into each other could be an issue with your template
settings. There are also currently some other open bugs about label printing,
like bug 29994. Maybe you could check if it relates to your issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31231] Link authorities automatically does not always work

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31231

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31185

--- Comment #1 from Katrin Fischer  ---
Hi Holly, I believe this sounds very similar to bug 31185 that has a patch now.
Could you have a look and verify?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31231

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15349] Problem with email pattern check on forms

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349

Katrin Fischer  changed:

   What|Removed |Added

 CC||tgoat...@gmail.com

--- Comment #14 from Katrin Fischer  ---
*** Bug 31205 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31205] Adding Custom name to the 'From' field in email notices

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31205

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Katrin Fischer  ---
I believe this is a dupliate (not the first) to bug 15349.

*** This bug has been marked as a duplicate of bug 15349 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #128 from David Nind  ---
Thanks Shi Yao, the patches now apply!

However, I've changed the status to Failed QA as there are:

1. Error traces after the patches are applied:

   a. See error traces for the staff interface - see [1], [2], and [3] (occurs
if the 'XSL - Simple Export' option for OpacExportOptions is either selected or
not selected).

   b. See error traces for the OPAC - see [4].

2. If the 'XSL - Simple Export' option for OpacExportOptions is not selected,
it still appears in the staff interface record details page as a save option.

3. The t/XSLT.t tests fail - see [5].

There is no option in the OPAC cart and lists to download as 'XSL - Simple
Export' - I'm not sure whether there should be or not...

Consolidated test plan so far:
1. Before applying the patches run the tests - these should pass:
   a. prove -l t/XSLT.t
   b. prove -l t/db_dependent/XSLT.t
2. Check current download and save options:
   a. OpacExportOptions system preference: all options selected, note that
there is no 'XSL - Simple Export' option.
   b. for both the OPAC and the staff interface:
  (i) search and add some selected items to the cart: check the download
options - there is no 'XSL - Simple Export' option
  (ii) search and add some items to a new list: check the download lists
options - there is no 'XSL - Simple Export' option
  (iii) from the details page for a record in the OPAC: check the save
record options in the right sidebar, there is no 'XSL - Simple Export' option
  (iv) from the details page for a record in the staff interface: check the
save record options from the menu bar, there is no 'XSL - Simple Export' option
4. Apply the patches and reload everything (flush_memcached, restart_all, clear
your browser cache (or use an incognito/private window)).
5. For the OpacExportOptions system preference, select the new option 'XSL -
Simple Export'.
6. Repeat step 2 - there should now be an 'XSL - Simple Export' option
available for download or saving.
7. Select the 'XSL - Simple Export' in all the paces it appears in the OPAC and
 staff interface - an HTML file should be downloaded.
8. Open the HTML file - you should see the record's information.
9. Run the tests - they should pass:
   a. prove -l t/XSLT.t
   b. prove -l t/db_dependent/XSLT.t

[1] Error trace after clicking on the cart in the staff interface: 

Undefined subroutine
::Compile::ROOT::kohadevbox_koha_basket_basket_2epl::CustomXSLTExportList
called at /kohadevbox/koha/basket/basket.pl line 120


[2] Error trace when accessing the lists from the staff interface:

Undefined subroutine
::Compile::ROOT::kohadevbox_koha_virtualshelves_shelves_2epl::CustomXSLTExportList
called at /kohadevbox/koha/virtualshelves/shelves.pl line 381


[3] Error trace when selecting Save > XSL - Simple Export from a record's
details page in the staff interface:

Undefined subroutine
::Compile::ROOT::kohadevbox_koha_catalogue_export_2epl::GetMarcBiblio
called at /kohadevbox/koha/catalogue/export.pl line 95


[4] Error trace when selecting Save record > XSL - Simple Export from a
record's details page in the OPAC:

Undefined subroutine ::Biblio::GetMarcBiblio called at
/kohadevbox/koha/opac/opac-export.pl line 145


[5] Failed tests for t/XSLT.t

prove -l t/XSLT.t
t/XSLT.t .. 2/12 
#   Failed test 'CustomXSLTExportList finds custom XSLTs'
#   at t/XSLT.t line 107.

#   Failed test 'Title is specified in root node'
#   at t/XSLT.t line 108.
Use of uninitialized value in string eq at t/XSLT.t line 109.

#   Failed test 'Title is filename if not specified'
#   at t/XSLT.t line 109.
# Looks like you failed 3 tests of 12.
t/XSLT.t .. Dubious, test returned 3 (wstat 768, 0x300)
Failed 3/12 subtests 

Test Summary Report
---
t/XSLT.t (Wstat: 768 Tests: 12 Failed: 3)
  Failed tests:  10-12
  Non-zero exit status: 3
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.01 sys +  3.46 cusr  0.19
csys =  3.68 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de
   |ity.org |
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138075|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 138106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138106=edit
Bug 21982: Circulation statistics wizard does not count deleted items

By default statistic assistant filter is set on the
existing items and doesn't mind about deleted items.
The patch corrects this. Items belong to the same library.

Test plan:
1)Make sure to have at least 1 or more item(s) in deleteditems database table
2)Home > Reports > Circulation statistics
3)Fill up 'Issuing library', 'Home library' and 'Holding library'
4)Submit
5)Notice that only statistics for active items are shown
6)Apply patch and repeat from 2) to 5)
7)Now active items and deleted items are shown

Signed-off-by: Sally 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21982] Circulation statistics wizard does not count deleted items

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21982

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11083] Authority search result display in staff interface should be XSLT driven

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
  Documentation||Caroline Cyr La Rose
contact||
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/575

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31229] Column visibility broken on patron search view

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138074|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 138105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138105=edit
Bug 31229: (bug 30063 follow-up) fix column visibility

Fix bad conflict resolution with bug 29648.

Test plan:
Confirm that the "Columns" button is displayed on the patron result view
and that it works as expected.

Signed-off-by: Sally 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31229] Column visibility broken on patron search view

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31229] Column visibility broken on patron search view

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31229

Katrin Fischer  changed:

   What|Removed |Added

Version|unspecified |master
Summary|column visibility broken on |Column visibility broken on
   |patron search view  |patron search view
 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30982] Use the REST API for background job list view

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30982

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #19 from Katrin Fischer  ---
Applied the patches, restart_all:

* The page loads ok, table is empty in my installation
* I check the "Only include jobs started in the last hour" checkbox:
  Error: Something went wrong when loading the table.
  500: Internal Server Error

In my background_jobs table I have several entries, one for
batch_item_record_modification and several update_elastic_index. All are
finished.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30462] Should the background job list view hide index tasks by default?

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30462

--- Comment #27 from Katrin Fischer  ---
Can I please have a test plan for this one? I don't know much about the
background jobs yet, so I wonder what the best way would be to ensure I have a
completed and a queued job?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31154] Batch item modification fails when "Use default values" is checked

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31154

Katrin Fischer  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #4 from Katrin Fischer  ---
Hi Emmi,
yes, that's it:

* Update default framework 952 and add a default value
  Example: Add REF as default for 952$8 with standard sample data
* Collect some barcodes
* Go to Tools > Batch item modification
* Enter barcodes and check checkbox for using default values
* Submit form and boom!

Can't call method "field" on an undefined value at
/kohadevbox/koha/Koha/UI/Form/Builder/Item.pm line 165

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31132] Add button to clear the cataloguing authority plugin form

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31132

--- Comment #6 from Katrin Fischer  ---
The feature itself works nicely, but I am not sure about the placement of the
link as it 'breaks the rule' of the Cancel link always being next to the submit
button.

Looking at the Z39.50 search pop-up, the clear form links is placed inside the
form. Maybe we should do the same here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31227] Provide option to protect user permissions on patron import

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31227

Aleisha Amohia  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #2 from Aleisha Amohia  ---
Yes that sounds good! Will close this

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #11 from Katrin Fischer  ---
You are right, Caroline, the patch is missing the database update bits.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31227] Provide option to protect user permissions on patron import

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31227

--- Comment #1 from Katrin Fischer  ---
Hi Aleisha, 

I am not sure which version it was added in, but there is now a feature to
preserve values on import that includes "System permissions" (flags). You can
find it on the patron import page collapsed as "Preserve existing values".

I think this should work or would be a bug otherwise - do you agree?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30214] Send WELCOME notice for new patrons added via self registration

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214

Ed Veal  changed:

   What|Removed |Added

 CC||ev...@mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19693] update of an authority record creates inconsistency when the heading tag is changed

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19693

Janusz Kaczmarek  changed:

   What|Removed |Added

Summary|authtypefrom incorrectly|update of an authority
   |set when updating auth recs |record creates
   |from file   |inconsistency when the
   ||heading tag is changed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00)

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/575
  Documentation||Caroline Cyr La Rose
contact||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31237] Automatic item modifications by age needs a way to test rules from the front end

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31237

Liz Rea  changed:

   What|Removed |Added

Summary|Automatic item  |Automatic item
   |modifications by age needs  |modifications by age needs
   |a run button|a way to test rules from
   ||the front end
 CC||wizzy...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31237] New: Automatic item modifications by age needs a run button

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31237

Bug ID: 31237
   Summary: Automatic item modifications by age needs a run button
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

There needs to be a way to test an Automatic item modifications by age rule. 
Currently, you have to wait for the conditions to occur naturally and via cron.
 It would be great if there were a way to test a rule against a record, and
also a way to see a preview of results if you don't want the rules to apply
immediately.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #10 from Caroline Cyr La Rose  ---
I tried to test this on a sandbox, but even if I "Refresh Schema", there is no
deleted_on column in deleteditems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #135 from Benjamin Daeuber  ---
Moved my comments to the github issues board.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #134 from Benjamin Daeuber  ---
The search bar is always returning to "Check Out". If I do a catalog search,
the bar will return to "Check out" and I need to manually return it to "Search
Catalog" each time. Also, I think the entry in that bar should persist even as
you switch contexts (so if I type something in and realize it's on Check out, I
should be able to switch to Search and not retype).

The floating search header bar has a transparent background, meaning that as
items scroll underneath it, you can no longer read the bar properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice  changed:

   What|Removed |Added

   Assignee|solene.desv...@biblibre.com |julian.maur...@biblibre.com
 Status|Failed QA   |ASSIGNED

--- Comment #133 from Julian Maurice  ---
I have done a bit of cleanup in the patch and split it in more logical patches.
I tried to remove all template changes that were not necessary. Hopefully it
will be easier to review.

There are some changes too (non-exhaustive list):
- The search bar in the header has been "fixed". It's still the same with the
same accessibility issues mentioned earlier, but at least it should be
displayed correctly on all pages, even when the search form have more than one
input. There was some JS code used to fix sizes and positioning, it's gone. All
positioning is done in CSS only now
- The main page regained its old appearance (only colors are different).
- The circulation home page went back to old boring links (still WIP)
- There was some "UIKit" icons added in the previous patch, but only two of
those were used, and those two have an equivalent icon in FontAwesome
(arrow-right and sliders). I decided to remove all UIKit icons from the patch
and use FontAwesome instead.
- QA tests are green :)

There is still work to do, but you can already have a look at it on the
sandbox: https://staff-bug30952.sandboxes.biblibre.eu (user/password as usual)

I also set up a github repository here:
https://github.com/jajm/koha-staff-interface-redesign
I think it can be useful to organize feedbacks/decisions:
  - If you see something that need to be fixed you can open an issue
https://github.com/jajm/koha-staff-interface-redesign/issues/new
  - If you want to discuss something, you can create a new discussion
https://github.com/jajm/koha-staff-interface-redesign/discussions/new

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only for Zebra

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||Caroline Cyr La Rose
contact||
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/576
  Text to go in the||This enhancement adds a
  release notes||note to the
   ||FacetLabelTruncationLength
   ||system preference
   ||description that it only
   ||works with Zebra. When
   ||using ElasticSearch, facets
   ||are displayed in full.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31236] Add ability to send custom item fields via SIP using Template Toolkit

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31236] Add ability to send custom item fields via SIP using Template Toolkit

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236

--- Comment #1 from Kyle M Hall  ---
Created attachment 138104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138104=edit
Bug 31236: Add ability to send custom item fields via SIP using Template
Toolkit

Koha has been able to send arbitrary item fields via the "item_field" parameter
in the config. We have partners that need the ability to created custom item
fields from templates, as the item_fields feature cannot accomplish what they
need. We need to add a templated custom field feature for items, similar to
what we have for patrons.

Test Plan:
1) Apply this patch
2) Choose a SIP login to use, edit that account and add the following
   *inside* the login section:
   
3) Restart SIP
4) Run an item information query
5) Note the itemnumber is sent in the IN field!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31236] Add ability to send custom item fields via SIP using Template Toolkit

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31236] New: Add ability to send custom item fields via SIP using Template Toolkit

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31236

Bug ID: 31236
   Summary: Add ability to send custom item fields via SIP using
Template Toolkit
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Koha has been able to send arbitrary item fields via the "item_field" parameter
in the config. We have partners that need the ability to created custom item
fields from templates, as the item_fields feature cannot accomplish what they
need. We need to add a templated custom field feature for items, similar to
what we have for patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #132 from Julian Maurice  ---
Created attachment 138103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138103=edit
Bug 30952: The rest of CSS changes

There is still work to do to split this patch correctly into several
more logical patches. Consider this patch a WIP.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #128 from Julian Maurice  ---
Created attachment 138099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138099=edit
Bug 30952: Change login page style

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #130 from Julian Maurice  ---
Created attachment 138101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138101=edit
Bug 30952: Change default button style

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #131 from Julian Maurice  ---
Created attachment 138102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138102=edit
Bug 30952: Change tables style

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #127 from Julian Maurice  ---
Created attachment 138098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138098=edit
Bug 30952: Change MARC tags toolbar style

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #129 from Julian Maurice  ---
Created attachment 138100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138100=edit
Bug 30952: Change sysprefs nav menu style

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #126 from Julian Maurice  ---
Created attachment 138097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138097=edit
Bug 30952: Small adjustments in search results page

- Move Z39.50 search button to a toolbar
- Use btn and btn-link classes for "Select all" and "Clear all" buttons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #124 from Julian Maurice  ---
Created attachment 138095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138095=edit
Bug 30952: Change checkout, checkin and renew forms

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #125 from Julian Maurice  ---
Created attachment 138096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138096=edit
Bug 30952: Staff interface redesign (main page)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #123 from Julian Maurice  ---
Created attachment 138094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138094=edit
Bug 30952: Staff interface redesign (toolbar)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #122 from Julian Maurice  ---
Created attachment 138093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138093=edit
Bug 30952: Move "Go to advanced/item search" link to toolbar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

--- Comment #121 from Julian Maurice  ---
Created attachment 138092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138092=edit
Bug 30952: Add Poppins font assets

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New interface for staff client

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Julian Maurice  changed:

   What|Removed |Added

 Attachment #137744|0   |1
is obsolete||
 Attachment #137775|0   |1
is obsolete||
 Attachment #137776|0   |1
is obsolete||
 Attachment #137994|0   |1
is obsolete||

--- Comment #120 from Julian Maurice  ---
Created attachment 138091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138091=edit
Bug 30952: Staff interface redesign (header)

What this patch does:
- change the navigation bar style
- change the breadcrumbs style
- change the "last borrower" link style
- move the search bar inside the navigation bar
- move the help link to the same row as the breadcrumbs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only for Zebra

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

--- Comment #8 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31191] Specify FacetLabelTruncationLength is only for Zebra

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31191

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26549] Show value of global system preferences on subscription form

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549

--- Comment #8 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26549] Show value of global system preferences on subscription form

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22276] Add client storage of user-selected DataTables configuration

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Patch doesn't apply

--- Comment #11 from Tomás Cohen Arazi  ---
Please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|n...@bywatersolutions.com   |paul.dersch...@lmscloud.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31223] Batch edit items - not working anymore in 22.05

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Jonathan Druart  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31223] Batch edit items - not working anymore in 22.05

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #7 from Isabel Pineda  ---
(In reply to Jonathan Druart from comment #6)
> Do you see the two koha-worker processes?
> 
>   ps aux | grep koha-worker

I get this output:
bibliot+   21230  0.0  0.0   8468   156 ?SJul04   0:00 daemon
--name=biblioteca-koha-worker
--errlog=/var/log/koha/biblioteca/worker-error.log
--stdout=/var/log/koha/biblioteca/worker.log
--output=/var/log/koha/biblioteca/worker-output.log
--pidfiles=/var/run/koha/biblioteca/ --verbose=1 --respawn --delay=30
--user=biblioteca-koha.biblioteca-koha --
/usr/share/koha/bin/background_jobs_worker.pl --queue default
biblio   4191795  0.0  0.0   9208  2216 pts/0S+   07:46   0:00 grep
--color=auto koha-worker


I have just looked into the worker-error logfile, but it is empty. The
worker-output logfile gives this output:
Can't call method "GetPlugins" on an undefined value at
/usr/share/koha/lib/Koha/BackgroundJob.pm line 402.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #126 from Jonathan Druart  ---
(In reply to Tomás Cohen Arazi from comment #125)
> Follow-ups pushed to master. We owe you some beers Jonathan. Thanks!

I broke, I fix ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4134] add bibliographic tagging to staff interface

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4134

Holly  changed:

   What|Removed |Added

 CC||h...@interleaf.ie

--- Comment #1 from Holly  ---
I'm currently working on 21.11.09 and I think this would be a useful feature to
have.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31223] Batch edit items - not working anymore in 22.05

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #6 from Jonathan Druart  ---
Do you see the two koha-worker processes?

  ps aux | grep koha-worker

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31223] Batch edit items - not working anymore in 22.05

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #5 from Isabel Pineda  ---
(In reply to Jonathan Druart from comment #3)
> Identify the id of the job in the URL and request the DB
> 
> select * from background_jobs where id=X

Sorry, I forgot one field:

id: 357
status: new
size: 2
borrowernumber: 2
type: batch_item_record_modification
queue: default
data:
{"exclude_from_local_holds_priority":null,"regex_mod":null,"record_ids":["38409","42755"],"new_values":{"itemnotes":"test","dateaccessioned":"2022-07-25"}}
enqueued_on: 2022-07-25 07:14:34

The other fields are empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31223] Batch edit items - not working anymore in 22.05

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #4 from Isabel Pineda  ---
(In reply to Jonathan Druart from comment #3)
> Identify the id of the job in the URL and request the DB
> 
> select * from background_jobs where id=X

Ok. This is the content that I get in the fields:
id: 357
status: new
size: 2
borrowernumber: 2
type: batch_item_record_modification
queue: default
data:
{"exclude_from_local_holds_priority":null,"regex_mod":null,"record_ids":["38409","42755"],"new_values":{"itemnotes":"test","dateaccessioned":"2022-07-25"}}

The other fields are empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15913] It should be possible to restrict a problem patron from editing their record or adding comments / tags to records

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15913

Holly  changed:

   What|Removed |Added

 CC||h...@interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31223] Batch edit items - not working anymore in 22.05

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #3 from Jonathan Druart  ---
Identify the id of the job in the URL and request the DB

select * from background_jobs where id=X

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #125 from Tomás Cohen Arazi  ---
Follow-ups pushed to master. We owe you some beers Jonathan. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords|additional_work_needed  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #124 from Jonathan Druart  ---
(In reply to Tomás Cohen Arazi from comment #123)
> Created attachment 138090 [details] [review]
> Bug 29697: Fix t/db_dependent/Search.t
> 
> Signed-off-by: Tomas Cohen Arazi 

I have looked at the wrong data apparently, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31223] Batch edit items - not working anymore in 22.05

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #2 from Isabel Pineda  ---
(In reply to Katrin Fischer from comment #1)
> Hi Isabel, there could be a time delay while the job is processed by the
> background jobs. If you go to Aministration > Background jobs, do you see
> any finished/unfinished jobs of type "Batch item record modification" there?

Hi Katrin.

I have just tried: When I click on the link to view the details of the queued
job, I get a 500 error.
The intranet-error logfile gives this output:

AH01215: CGI::param called in list context from
/usr/share/koha/intranet/cgi-bin/catalogue/detail.pl line 622, this can lead to
vulnerabilities. See the warning in "Fetching the value or values of a single
named parameter" at /usr/share/perl5/CGI.pm line 415.:
/usr/share/koha/intranet/cgi-bin/catalogue/detail.pl, referer:
https://biblioteca-intra.ds.edu.sv/cgi-bin/koha/tools/batchMod.pl

AH01215: Use of uninitialized value $mode in string ne at
/usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl line 886.:
/usr/share/koha/intranet/cgi-bin/cataloguing/addbiblio.pl, referer:
https://biblioteca-intra.ds.edu.sv/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=18080

AH01215: CGI::param called in list context from
/usr/share/koha/intranet/cgi-bin/catalogue/detail.pl line 622, this can lead to
vulnerabilities. See the warning in "Fetching the value or values of a single
named parameter" at /usr/share/perl5/CGI.pm line 415.:
/usr/share/koha/intranet/cgi-bin/catalogue/detail.pl, referer:
https://biblioteca-intra.ds.edu.sv/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=18080

AH01215: Can't use an undefined value as an ARRAY reference at
/usr/share/koha/lib/Koha/BackgroundJob/BatchUpdateItem.pm line 175.:
/usr/share/koha/intranet/cgi-bin/admin/background_jobs.pl, referer:
https://biblioteca-intra.ds.edu.sv/cgi-bin/koha/tools/batchMod.pl
End of script output before headers: background_jobs.pl, referer:
https://biblioteca-intra.ds.edu.sv/cgi-bin/koha/tools/batchMod.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #138081|0   |1
is obsolete||

--- Comment #123 from Tomás Cohen Arazi  ---
Created attachment 138090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138090=edit
Bug 29697: Fix t/db_dependent/Search.t

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #122 from Jonathan Druart  ---
Created attachment 138089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138089=edit
Bug 29697: tracklinks should not explode on invalid marc record

Caught by t/db_dependent/www/regressions.t

#   Failed test '404 for itemnumber containing different URI'
#   at t/db_dependent/www/regressions.t line 124.
#  got: '500'
# expected: '404'

#   Failed test '302 for itemnumber with matching URI'
#   at t/db_dependent/www/regressions.t line 126.
#  got: '500'
# expected: '302'

#   Failed test '404 for itemnumber containing different URI'
#   at t/db_dependent/www/regressions.t line 139.
#  got: '500'
# expected: '404'

#   Failed test '302 for itemnumber with matching URI'
#   at t/db_dependent/www/regressions.t line 141.
#  got: '500'
# expected: '302'
# Looks like you failed 4 tests of 36.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
 CC||shi-yao.w...@inlibro.com

--- Comment #127 from Shi Yao Wang  ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #138037|0   |1
is obsolete||

--- Comment #126 from Shi Yao Wang  ---
Created attachment 138088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138088=edit
Bug 17385: Fixing display for XSL-Simple Export in OPAC

This attachment correct the placement of XSL-Simple Export in the OPAC's page.
It is now displayed in the "Save record" dropdown menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #138036|0   |1
is obsolete||

--- Comment #125 from Shi Yao Wang  ---
Created attachment 138087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138087=edit
Bug 17385: Correction of opac-detail-sidebar.inc

This patch reverts the changes made in opac-detail-sidebar.inc, so the sidebar
is
displayed as wanted. Tests are now passing properly.

TEST PLAN:
1- Apply the patch and search for a record in the OPAC.
2- Click on "Save record". Notice that the dropdown menu is unchanged.
3- Run t/db_dependent/XSLT.t (All tests should pass)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #138035|0   |1
is obsolete||

--- Comment #124 from Shi Yao Wang  ---
Created attachment 138086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138086=edit
Bug 17385: Add custum export format option when saving a record

This patch adds "XSL-Simple Export" when saving a bibliographic
record. Previous patches are combined into this one.

To test:
1) Search for a record in the intranet.
2) Click on the "Save" button and observe the dropdown menu.
3) Notice that "XSL- Simple Export" is not in the menu.
4) Apply the patch.
5) Repeat the steps 1 and 2.
6) Notice that "XSL - Simple Export" is in the menu.
7) Click on "XSL - Simple Export". A .html file should be downloaded.
8) Open the .html file. You should see the record's informations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #138034|0   |1
is obsolete||

--- Comment #123 from Shi Yao Wang  ---
Created attachment 138085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138085=edit
Bug 17385: Add tests for CustomXSLTExportList

Tests are now in one patch.
One test does not pass and I am not able to fix it.

The test who fails :


$ prove -l t/db_dependent/XSLT.t
t/db_dependent/XSLT.t .. 1/3
#   Failed test 'This list comes from the cache and that is fine'
#   at t/db_dependent/XSLT.t line 122.
#  got: '1'
# expected: '2'
# Looks like you failed 1 test of 1.

 #   Failed test 'CustomXSLTExportList: Caching'
 #   at t/db_dependent/XSLT.t line 124.
 # Looks like you failed 1 test of 3.
t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
---
t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=3,  3 wallclock secs ( 0.03 usr  0.00 sys +  1.74 cusr  0.14
csys =  1.91 CPU)
Result: FAIL


This one works fine :


$ prove -l t/XSLT.t
t/XSLT.t .. ok
All tests successful.
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.55 cusr  0.17
csys =  2.74 CPU)
Result: PASS


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #138033|0   |1
is obsolete||

--- Comment #122 from Shi Yao Wang  ---
Created attachment 138084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138084=edit
Bug 17385: (QA follow-up) Add caching

Performance: We should add caching in CustomXSLTExportList.

Note: This resolves the lack of an intranet test in the former patch too.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #138032|0   |1
is obsolete||

--- Comment #121 from Shi Yao Wang  ---
Created attachment 138083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138083=edit
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder

Performance: We need to return an empty list if OpacExportOptions does not
contain Custom.  No need to scan the directory for custom files, if we are not
using them at all.

Note: The test only pertains to OPAC now, since the pref should not control
intranet behavior. We have no intranet counterpart. See further next follow-up.

Test plan:
Run t/db_dependent/XSLT.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #138031|0   |1
is obsolete||

--- Comment #120 from Shi Yao Wang  ---
Created attachment 138082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138082=edit
Bug 17385: Add custom export XSLT

Rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #9 from Jonathan Druart  ---
So yes, it's what the patch does :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #121 from Jonathan Druart  ---
Created attachment 138081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138081=edit
Bug 29697: Fix t/db_dependent/Search.t

FIXME This does not seem correct.
I bet it was coming from a problem in our test data but apparently all
the items in
t/db_dependent/data/marc21/zebraexport/biblio/exported_records have a
952$9

I don't fully understand why we reach this code without itemnumber.

Not sure this is the correct fix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #120 from Jonathan Druart  ---
Created attachment 138080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138080=edit
Bug 29697: Fix t/Search.t

#   Failed test 'No tests run for subtest "searchResults PassItemMarcToXSLT
test"'
 #   at t/Search.t line 208.
 Undefined subroutine ::Biblio::EmbedItemsInMarcBiblio called at t/Search.t
line 194.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #119 from Jonathan Druart  ---
Created attachment 138079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138079=edit
Bug 29697: Reintroduce wrongly removed import

#   Failed test 'No tests run for subtest "CancelHold"'
 #   at t/db_dependent/ILSDI_Services.t line 806.
 Undefined subroutine ::ILSDI::Services::CanReserveBeCanceledFromOpac called
at /kohadevbox/koha/C4/ILSDI/Services.pm line 941.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697

--- Comment #118 from Jonathan Druart  ---
Created attachment 138078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138078=edit
Bug 29697: Fix t/db_dependent/Exporter/Record.t

Not sure about the warn, we shouldn't need it as we are raising an
exception. But better (for now) than introducing regressions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30392] Add a deleted_on column to deleteditems

2022-07-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30392

--- Comment #8 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Katrin Fischer from comment #6)
> > Maybe NULL is better, we messed with the date in a recent update, so they
> > are most likely wrong. We can still use COALESCE in reports if needed.
> 
> What does the patch then.

Not sure I understand. The idea is to give a reliable date, that is not
accidentally overwritten by changes to deleteditems (as we did in the last
update, which triggered the timestamp).

And we start with NULL for the old entries (would be my suggestion)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >