[Koha-bugs] [Bug 22276] Add client storage of user-selected DataTables configuration

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

Owen Leonard  changed:

   What|Removed |Added

 Attachment #133717|0   |1
is obsolete||
 Attachment #133718|0   |1
is obsolete||

--- Comment #12 from Owen Leonard  ---
Created attachment 138172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138172=edit
Bug 22276: Add client storage of user-selected DataTables configuration

This patch enables use of DataTables' built-in session storage of table
configurations. DataTables by default uses the browser's localstorage
feature to store the state of each DataTable, including which columns
have been hidden by the user.

Our table settings system has always overridden this saved state. This
patch adds a check for a saved configuration state and if present loads
the saved state instead of the default state.

The system is enabled in this patch on the libraries administration
page. To test, apply the patch and open go to Administration ->
Libraries.

- Use the "Columns" button to change the visibility setting of multiple
  columns.
- Navigate away from the page and then back to test that the visibility
  settings have been kept.
- Go to Administration -> Table settings -> Administration and change
  the visibility settings for the "libraries" table in a way that it
  differs from the visibility settings you set manually.
- Return to the libraries administration page and confirm that your
  manual settings are still being loaded instead of the defaults from
  table settings.

Signed-off-by: Solène Desvaux 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31244] Logout when not logged in raise a 500

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||30588


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588
[Bug 30588] Add the option to require 2FA setup on first staff login
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20476] Two factor authentication for the staff client - omnibus

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20476

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Depends on||31240


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31240
[Bug 31240] Search bar disappears on tow_factor_auth page
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22276] Add client storage of user-selected DataTables configuration

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276

--- Comment #14 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30899] Upgrade sometimes fails at "Upgrade to 21.11.05.004"

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30899

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|22.11.00, 22.05.x   |22.11.00,22.05.01
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data from drop-down menu not stored

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

Fridolin Somers  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m
   Severity|enhancement |major
 Status|NEW |ASSIGNED
Version|21.11   |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31243] Misleading tests in api/v1/two_factor_auth.t

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31243

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #1 from Jonathan Druart  ---
Well, bug 28787 is not pushed yet. Adding the patch there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28269] Order search should be possible with ISSN too

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28269

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #134428|0   |1
is obsolete||

--- Comment #17 from ByWater Sandboxes  ---
Created attachment 138186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138186=edit
Bug 28269: Add tests for Acquisitions Orders search by ISSN

also with SearchWithISSNVariations on and off

Signed-off-by: KIT Library Germany 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25870] Add a q_ccl query parameter to /biblios

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870

--- Comment #21 from David Cook  ---
(In reply to David Cook from comment #20)
> (In reply to Paul Derscheid from comment #7)
> > That's right but at LMSCloud we need this as a public route and tcohen also
> > wants this to be public, so the simple approach doesn't fly. 
> > 
> > Thanks for the pointers, I'll have a look in a bit.
> 
> I'd like this as a public route as well, as I'd like to point a third-party
> at it, so that they can search Koha in an event-driven way.

Although for my use case I could go with a non-public route and just give them
a "catalogue" authorized user like Kyle suggested. 

But that wouldn't work if we wanted opac-search.pl to use it.

But... we could start with non-public and then add public later if we're
concerned. They could probably share the controller even.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31244] Logout when not logged in raise a 500

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31244

--- Comment #1 from Jonathan Druart  ---
Created attachment 138147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138147=edit
Bug 31244: Fix 500 if logout and not logged in

Can't use an undefined value as a HASH reference at /kohadevbox/koha/C4/Auth.pm
line 985
C4::Auth::checkauth('CGI=HASH(0x5603b7dc4300)', 0,
'HASH(0x5603b2633238)', 'intranet', undef, 'intranet-main.tt') called at
/kohadevbox/koha/C4/Auth.pm line 186
C4::Auth::get_template_and_user('HASH(0x5603b7b83d08)') called at
/kohadevbox/koha/mainpage.pl line 40

Test plan:
Open a private window
Hit /cgi-bin/koha/mainpage.pl?logout.x=1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data from drop-down menu not stored

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

--- Comment #3 from Fridolin Somers  ---
Created attachment 138145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138145=edit
Bug 31234: SubfieldsToAllowForRestrictedEditing - data from drop-down menu not
stored

Problem with items restricted edition, restriced fields with a drop-down
menu are not stored, since 21.11.

This comes from a change by Bug 28445 in items edition form :
  https://git.koha-community.org/Koha-community/Koha/src/commit/fc919fc796df42c29e73cd527d3c425377fcc27a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js#L112

I propose we use "select.input_marceditor".

Test plan :
1. A librarian with 'edit_items_restricted' permission set
2. Item subfield not authorized for editing
(SubfieldsToAllowForRestrictedEditing). In Marc framework, this subfield is
linked to an authorized value (= drop-down menu). For exemple homebranch.
3. When adding/editing item, this subfield has a default value from drop-down
menu and is not editable (OK).
4. Save item
=> Without patch : the subfield is empty, it should have the value from
drop-down menu.
=> With patch : the subfield is saved with the value from drop-down menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #132554|0   |1
is obsolete||

--- Comment #3 from Emmi Takkinen  ---
Created attachment 138168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138168=edit
Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only
the notforloan values description

This can be used to instruct staff how the item should handled when
it's checked in. For example items notforloan status has been
changed as "Invoiced item" while item has been on loan. When it's
checked in staff sees that they should put item aside for further
processing.

To test:
1. Apply patch and update database if needed
2. Set items notforloan status as -1 (or create new one)
3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin
4. Check item out for patron.
5. Check item in.
=> Description of notforloan status should be displayed.
=> Confirm notforloan status hasn't changed.

Also prove t/db_dependent/Circulation/issue.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data from drop-down menu not stored

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

--- Comment #5 from Fridolin Somers  ---
BTW : 
The system preference 'SubfieldsToAllowForRestrictedEditing' edition is quite
strange, why enter itemsfield 952/995 when it is obvious.
Could be simply subfields separated with a comma : a,b,c

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data from drop-down menu not stored

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

--- Comment #1 from Fridolin Somers  ---
This comes from a change by Bug 28445 in items edition form :
  https://git.koha-community.org/Koha-community/Koha/src/commit/fc919fc796df42c29e73cd527d3c425377fcc27a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js#L112

I propose we use "select.input_marceditor".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31240] New: Search bar disappears on tow_factor_auth page

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31240

Bug ID: 31240
   Summary: Search bar disappears on tow_factor_auth page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The search bar that is always at the top of the page in the staff interface
disappears when we access the 'Manage two-factor authentication' page in our
account.

To test:
1- Enable the TwoFactorAuthentication syspref
2- Go to your account (click username at the top right and choose 'My account')
3- Go to More > Manage two-factor authentication
   --> Search bar is not visible anymore

Similar to bug 31153? In that case the include file was not the right one...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28787] Send a notice with the TOTP token

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||30588


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588
[Bug 30588] Add the option to require 2FA setup on first staff login
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31241] New: PDF export of ANY label is NOT functioning.

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31241

Bug ID: 31241
   Summary: PDF export of ANY label is NOT functioning.
 Change sponsored?: ---
   Product: Koha
   Version: 22.05
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Label/patron card printing
  Assignee: cnighswon...@foundations.edu
  Reporter: stdominic.novi...@gmail.com
QA Contact: testo...@bugs.koha-community.org

I've been experimenting and no label type of any kind works when exported as a
pdf. Either it is completely jumbled or massive amounts of the data are
missing. I've tried batch and selected exporting, redoing the layouts and
templates. This is for Patron, barcode, and spine label. I have a similar bug
concerning the spine label, but this seems to be a more widespread problem than
I first thought. If I try to export a singly selected or any other number that
is not the full batch I get an Error 500 message, and if it's the full bath the
label is garbled. Thanks for your time looking into this!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

--- Comment #169 from Jonathan Druart  ---
(In reply to Caroline Cyr La Rose from comment #168)
> I added a section in the manual. This type of more technical thing is a bit
> outside my expertise and I'm not 100% sure I have the right vocabulary. So
> please let me know of any corrections I need to make. 
> 
> https://gitlab.com/koha-community/koha-manual/-/merge_requests/578

Read good, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30588] Add the option to require 2FA setup on first staff login

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30588

--- Comment #6 from Jonathan Druart  ---
Created attachment 138165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138165=edit
Bug 30588: Add selenium tests

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28787] Send a notice with the TOTP token

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #64 from Jonathan Druart  ---
Created attachment 138158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138158=edit
Bug 28787: (follow-up) Typo and additional test

Adding a test for a 403 status when lowering authorization.
The Auth mock for check_cookie_auth is not needed here.
Reading back the session after flush either.

Signed-off-by: Marcel de Rooy 

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28787] Send a notice with the TOTP token

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #57 from Jonathan Druart  ---
Created attachment 138151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138151=edit
Bug 28787: Typo authenticaction

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marcel de Rooy 

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28787] Send a notice with the TOTP token

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787

--- Comment #62 from Jonathan Druart  ---
Created attachment 138156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138156=edit
Bug 28787: Mock send_or_die

To make the tests pass even if no SMTP server is defined.

Signed-off-by: Marcel de Rooy 

Sponsored-by: Rijksmuseum, Netherlands

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29994] Single label PDF export not working

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

--- Comment #11 from Chris Nighswonger  ---
(In reply to Chris Nighswonger from comment #9)
> (In reply to Lucas Gass from comment #8)
> 
> > This is the error I see:
> > Can't locate object method "get_attr" via package "-2" (perhaps you forgot
> > to load "-2"?) at /kohadevbox/koha/labels/label-create-pdf.pl line 127
> 
> See the comment here:
> 
> https://github.com/Koha-Community/Koha/blob/master/C4/Creators/Batch.pm#L156
> 
> What is being passed in as the batch id?

The URL to create the PDF should similar to this:

https://jl-staff.campus.foundations.edu/cgi-bin/koha/labels/label-create-pdf.pl?batch_id=858_id=1_id=5_label=1label_id=25498

If batch_id is non-existent or an invalid value, C4::Creators::Batch->retrieve
will return -2.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

Emmanuel Bétemps  changed:

   What|Removed |Added

 CC||e.bete...@gmail.com

--- Comment #9 from Emmanuel Bétemps  ---
Nice cataloging page !

Note that if  EnableAdvancedCatalogingEditor is set on "Don't enable", the
title of the "New" section is displayed although this section is empty.

Perhaps the "New record" and "New from Z39.50..." buttons could be in this
section rather than above, in their own menu.

Is this what you mean with :
> I'm not sure how to try and handle the other toolbar buttons.. the Framework
> selection lends itself to a button.. I was considering a fieldset with
> buttons but that also feels a bit weird.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31241] PDF export of ANY label is NOT functioning.

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31241

Chris Nighswonger  changed:

   What|Removed |Added

   Severity|blocker |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data from drop-down menu not stored

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

Fridolin Somers  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data from drop-down menu not stored

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

--- Comment #4 from Fridolin Somers  ---
Important /!\ :

There are other places with JS calling 'field_value', we should check if there
are other bugs :

 > git grep 'name..field_value'
 > git grep 'name..field_value' -- koha-tmpl/
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt:  
 
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt:
   
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt:
   
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt:if(!
$(subfield_div).children("input[type='text'][name='field_value']").val() ){
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt:   
$(subfield_div).children("input[type='text'][name='field_value']").val($("#serialseq"
+ serialId).val());
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt:   
  
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt:
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt:   
  
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt:
koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt:   

koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt:  
 with value 
koha-tmpl/intranet-tmpl/prog/js/additem.js:   
.prevAll("[name='field_value']")[0];
koha-tmpl/intranet-tmpl/prog/js/additem.js:   
$(original).find("input[name='field_value']").each(function(){
koha-tmpl/intranet-tmpl/prog/js/additem.js:   
$(clone).find("div[id^='"+id+"'] input[name='field_value']").val(value);
koha-tmpl/intranet-tmpl/prog/js/additem.js:   
$(original).find("select[name='field_value']").each(function(){
koha-tmpl/intranet-tmpl/prog/js/additem.js:   
$(clone).find("div[id^='"+id+"'] select[name='field_value']").val(value);
koha-tmpl/intranet-tmpl/prog/js/additem.js:var input =
$(this).prevAll("input[name='field_value']")[0];

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31242] Add rate-limiting to the REST API

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31242

--- Comment #1 from David Cook  ---
On Bug 25870, Tomas suggested Apache for rate-limiting, while Kyle suggested
Plack middleware to keep the rate-limiting in the Koha app.

I'll throw some API Gateway options into the mix:
https://konghq.com/
https://www.krakend.io/

(I use Kong for managing complex security requirements around APIs on other
projects. I've been wanting to try out KrakenD for a while as it apparently is
faster and lighter weight overall.)

--

Overall, I'd say that Apache - in its role as reverse proxy to Starman - is the
place to do rate limiting. It's almost certainly going to be more efficient
than Starman, and there's no point letting in traffic to Starman if we're just
going to block it.

That said, a quick Google doesn't really show any good Apache options. I think
mod_security might be one way which is available but it has a questionable past
and future I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29994] Single label PDF export not working

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

Lucas Gass  changed:

   What|Removed |Added

Version|21.11   |unspecified
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #137758|0   |1
is obsolete||

--- Comment #8 from ByWater Sandboxes  ---
Created attachment 138141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138141=edit
Bug 31162: Add a cataloging module home page

This patch adds a new cataloging-home template and controller and
replaces most cases of links to addbooks.  This servers to provide a new
cataloging home page for the cataloging module and keeps it distinct
from the current addbooks page it partially replaces as a stating point
for cataloging.

Signed-off-by: KIT 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12029] Patrons should be able to delete their patron messages

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31234] SubfieldsToAllowForRestrictedEditing : data from drop-down menu not stored

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31234

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Depends on||28445


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28445
[Bug 28445] Use the task queue for the batch delete and update items tool
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31223] Batch edit items explodes if plugins disabled

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31223

--- Comment #18 from Kyle M Hall  ---
Created attachment 138143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138143=edit
Bug 31223: Do not explode if plugins disabled

This patch makes the code skip calculating the plugin-related task
codes => class mapping if plugins are entirely disbaled.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Plugins/BackgroundJob.t
=> FAIL: Tests explode with: Can't call method "GetPlugins" on an
undefined value at... Koha/BackgroundJob.pm line 424.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
  Documentation||Caroline Cyr La Rose
contact||
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/578

--- Comment #168 from Caroline Cyr La Rose  
---
I added a section in the manual. This type of more technical thing is a bit
outside my expertise and I'm not 100% sure I have the right vocabulary. So
please let me know of any corrections I need to make. 

https://gitlab.com/koha-community/koha-manual/-/merge_requests/578

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29994] Single label PDF export not working

2022-07-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29994

--- Comment #12 from Chris Nighswonger  ---
(In reply to Lucas Gass from comment #8)
> I am able to recreate this in current master. 
> 
> 1. Make a label batch. 
> 2. Go to 'label-edit-batch.pl' and select at least one item in the table. (
> #batcht )

batch_id originates from element_id passed in to label-edit-batch.pl. ie.

https://jl-staff.campus.foundations.edu/cgi-bin/koha/labels/label-edit-batch.pl?op=edit_id=858

> 3. Use the 'Export' button to export at one item. 
> 4. Choose template/layout etc.

The fact that you are able to get this far would seem to indicate that a valid
batch_id is being passed in to this point.

> 5. Download as PDF
> 
> This is the error I see:
> Can't locate object method "get_attr" via package "-2" (perhaps you forgot
> to load "-2"?) at /kohadevbox/koha/labels/label-create-pdf.pl line 127

It appears that by the time you get to this point, the batch_id has become
corrupted somehow.

Please post both the label-edit-batch.pl URL and the label-create-pdf-pl URL
for your failure case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/