[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #275 from Victor Grousset/tuxayo --- If I recall correctly testing was most of what this patch needed. To check if stuff was broken in many parts of Koha. At the time, it was possible to test it (except crons) using the sandboxes, so non-programmers could have helped a lot without much being limited. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #164 from Victor Grousset/tuxayo --- (In reply to Nick Clemens from comment #140) > patch needs minor rebase Here it is, hope that helps ^^ (Bug 31272 caused a bit of trouble with date stuff but it was solvable reliably :) ) > That's all I can touch right now. If you do not object to this becoming an > omnibus and breaking it apart I will work through it in sections. I am happy > to create the new bugs to help. I'm not Jonathan but to help: how could this be split? Like having a 1st ticket with the common work. And including a minor "Remove GetItemsInfo from XXX" And then having several tickets each with a large "Remove GetItemsInfo from XXX" And the minor ones grouped into a ticket. Would that work well? To have less ticket management overhead and simplify the maintenance during the review (the many rebases!), would it work well to keep everything here and have multiple people review it? Like you could focus on only some of the "Remove GetItemsInfo from XXX" patches. The signed-off lines would keep track on the which patches are QAed and which aren't. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222
Rachael changed:
What|Removed |Added
Attachment #138038|0 |1
is obsolete||
--- Comment #6 from Rachael ---
Created attachment 138737
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138737=edit
Bug 31222: Reduce query size for batchMod
The object search is currently:
Koha::Items->search({ barcode => \@contentlist }
Which generate code like:
barcode = 1 OR barcode = 2 OR barcode = 3
This can get quite large
We can reduce the query size by using -in:
Koha::Items->search({ barcode => { -in => \@contentlist } }
Which generates code like:
barcode in ( 1, 2, 3 )
To test:
1 - Apply patch
2 - Perform batch modifications
3 - Confirm nothing has changed
Signed-off-by: Rachael Laritz
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 Rachael changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #73 from Victor Grousset/tuxayo --- > We build our own packages, maybe that could have something to do with it? Maybe somehow it's not in the dependencies. Otherwise it would have been installed. VS the official package that indeed installs it, since when using ktd it is installed by default. So something up when making the list of deps. You also build the perl deps I suppose? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138636|0 |1 is obsolete|| --- Comment #163 from Victor Grousset/tuxayo --- Created attachment 138736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138736=edit Bug 27272: Fix library display on routing slip - to squash -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138635|0 |1 is obsolete|| --- Comment #162 from Victor Grousset/tuxayo --- Created attachment 138735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138735=edit Bug 27272: Fix availability - OPAC Has to move some code to a method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138634|0 |1 is obsolete|| --- Comment #161 from Victor Grousset/tuxayo --- Created attachment 138734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138734=edit Bug 27272: Call search_ordered when GetItemsInfo was called before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138633|0 |1 is obsolete|| --- Comment #160 from Victor Grousset/tuxayo --- Created attachment 138733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138733=edit Bug 27272: Add tests for search_ordered -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138632|0 |1 is obsolete|| --- Comment #159 from Victor Grousset/tuxayo --- Created attachment 138732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138732=edit Bug 27272: Allow to pass params and attributes to search_ordered -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138631|0 |1 is obsolete|| --- Comment #158 from Victor Grousset/tuxayo --- Created attachment 138731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138731=edit Bug 27272: Add search_ordered sub to order items with extra conditions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138630|0 |1 is obsolete|| --- Comment #157 from Victor Grousset/tuxayo --- Created attachment 138730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138730=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138629|0 |1 is obsolete|| --- Comment #156 from Victor Grousset/tuxayo --- Created attachment 138729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138729=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138628|0 |1 is obsolete|| --- Comment #155 from Victor Grousset/tuxayo --- Created attachment 138728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138728=edit Bug 27272: Remove GetItemsInfo from virtualshelves/sendshelf.pl And GetItemsLocationInfo from shelves.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138627|0 |1 is obsolete|| --- Comment #154 from Victor Grousset/tuxayo --- Created attachment 138727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138727=edit Bug 27272: Remove GetItemsInfo from tags/list.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138626|0 |1 is obsolete|| --- Comment #153 from Victor Grousset/tuxayo --- Created attachment 138726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138726=edit Bug 27272: Remove GetItemsInfo from serials/routing-preview -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138624|0 |1 is obsolete|| --- Comment #151 from Victor Grousset/tuxayo --- Created attachment 138724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138724=edit Bug 27272: Remove GetItemsInfo from opac-sendbasket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138625|0 |1 is obsolete|| --- Comment #152 from Victor Grousset/tuxayo --- Created attachment 138725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138725=edit Bug 27272: Remove GetItemsInfo import from opac-tags -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138623|0 |1 is obsolete|| --- Comment #150 from Victor Grousset/tuxayo --- Created attachment 138723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138723=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from moredetail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138622|0 |1 is obsolete|| --- Comment #149 from Victor Grousset/tuxayo --- Created attachment 138722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138722=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138621|0 |1 is obsolete|| --- Comment #148 from Victor Grousset/tuxayo --- Created attachment 138721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138721=edit Bug 27272: Remove 'already_reserved' flag from opac-reserve.pl It was never set (was set before 14695) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138620|0 |1 is obsolete|| --- Comment #147 from Victor Grousset/tuxayo --- Created attachment 138720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138720=edit Bug 27272: Remove GetItemsInfo from opac-detail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138619|0 |1 is obsolete|| --- Comment #146 from Victor Grousset/tuxayo --- Created attachment 138719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138719=edit Bug 27272: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl Hum... Item2Marc ok here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138618|0 |1 is obsolete|| --- Comment #145 from Victor Grousset/tuxayo --- Created attachment 138718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138718=edit Bug 27272: Remove GetItemsInfo labels/label-item-search It was commented anyway -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138617|0 |1 is obsolete|| --- Comment #144 from Victor Grousset/tuxayo --- Created attachment 138717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138717=edit Bug 27272: Remove GetItemsInfo from catalogue/imageviewer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138616|0 |1 is obsolete|| --- Comment #143 from Victor Grousset/tuxayo --- Created attachment 138716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138716=edit Bug 27272: Remove GetItemsInfo from basket/sendbasket Why are we display with $raw? Why are we display the location code instead of the AV's lib? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138615|0 |1 is obsolete|| --- Comment #142 from Victor Grousset/tuxayo --- Created attachment 138715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138715=edit Bug 27272: Remove GetItemsInfo from basket/basket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #138614|0 |1 is obsolete|| --- Comment #141 from Victor Grousset/tuxayo --- Created attachment 138714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138714=edit Bug 27272: Remove type= from detail.pl This is not related to anything known.. was it "itype" at some point? `git log -p` will tell you that it's there for a looong time already -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222 --- Comment #5 from Nick Clemens --- (In reply to Rachael from comment #4) > (In reply to Nick Clemens from comment #3) > > (In reply to Rachael from comment #2) > > > Batch modifications changes each item. Ex. Modifying the Source of > > > classification or shelving scheme to Dewey Decimal Classification gets > > > applied. > > > > Hi Rachel, I am not sure what you mean here? Batch modification should > > update each item, is it updating more fields than intended? > > Hi Nick, > No, nothing else changes, just the fields that I specified. Should I sign it > off then? If everything works as expected with the patch, yes, please :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30499] Keyboard shortcuts broken on several pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30499 --- Comment #10 from Tim McMahon --- Will this be added to 21.11? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30650] Add a curbside pickup module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30650 Benjamin Daeuber changed: What|Removed |Added CC||bdaeu...@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31300] New: Regression parcel.pl no longer totals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31300 Bug ID: 31300 Summary: Regression parcel.pl no longer totals Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdo...@gmail.com QA Contact: testo...@bugs.koha-community.org Prior to 21.11 parcel.pl would show the total for an order Total tax excl 10.00 Tax 1.00 Total tax incl 11.00 In 21.11 you get Total tax excl 10.00 Tax 1.00 Total tax incl 10.00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 --- Comment #2 from Fridolin Somers --- This can generate some huge outputs ^^ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299
--- Comment #1 from Fridolin Somers ---
Created attachment 138713
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138713=edit
Bug 31299: Fix duplicate output in search_for_data_inconsistencies.pl
In search_for_data_inconsistencies.pl when there are several inconsistencies on
same framework, the second output of items contains the first one.
Looks like it is since Bug 21466
Test plan using koha-testing-docker :
1) Create 2 inconsistencies on the same item via SQL :
update items set itemlost = 9 where itemnumber=900;
update items set notforloan = 8 where itemnumber=900;
2) Without patch
3) Run ./misc/maintenance/search_for_data_inconsistencies.pl
=> You see duplicate output :
== Wrong values linked to authorised values ==
* The Framework *BKS* is using the authorised value's category
*NOT_LOAN*, but the following items.notforloan do not have a value defined
({itemnumber => value }):
{900 => 8}
* The Framework *BKS* is using the authorised value's category *LOST*,
but the following items.itemlost do not have a value defined ({itemnumber =>
value }):
{900 => 8} {900 => 9}
4) Apply patch
5) Run ./misc/maintenance/search_for_data_inconsistencies.pl
=> Fixed :D
== Wrong values linked to authorised values ==
* The Framework *BKS* is using the authorised value's category *LOST*,
but the following items.itemlost do not have a value defined ({itemnumber =>
value }):
{900 => 9}
* The Framework *BKS* is using the authorised value's category
*NOT_LOAN*, but the following items.notforloan do not have a value defined
({itemnumber => value }):
{900 => 8}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 Fridolin Somers changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Fridolin Somers changed: What|Removed |Added Blocks||31299 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 Fridolin Somers changed: What|Removed |Added Depends on||21466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 Fridolin Somers changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31239] search_for_data_inconsistencies.pl fails for Koha to MARC mapping using biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31239 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31299 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31299] Duplicate output in search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31239 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31299] New: Duplicate output in search_for_data_inconsistencies.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31299 Bug ID: 31299 Summary: Duplicate output in search_for_data_inconsistencies.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz In search_for_data_inconsistencies.pl when there are several inconsistencies on same framework, the second output of items contains the first one. Looks like it is since Bug 21466 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31239] search_for_data_inconsistencies.pl fails for Koha to MARC mapping using biblio table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31239 --- Comment #2 from Fridolin Somers --- (In reply to Katrin Fischer from comment #1) > Which mapping caused the error? biblio.medium on 200$b UNIMARC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31179] Duplicate item is duplicating internal item fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31179 Sara Brown changed: What|Removed |Added CC||sbr...@bywatersolutions.com --- Comment #11 from Sara Brown --- +1 - backporting would be helpful! Libraries might not notice the internal duplication until after the fact, which may make cleanup difficult. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 --- Comment #9 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 --- Comment #29 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30874] Simplify patron category handling in memberentry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 --- Comment #23 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29971] Remember selections across patron search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29971] Remember selections across patron search pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #131434|0 |1 is obsolete|| --- Comment #13 from Andrew Fuerste-Henry --- Created attachment 138712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138712=edit Bug 27265: Enable message queue cron to accept multiple codes and types It would be nice to be able to combine several types in a single run, but exclude others, without having to have multiple cron lines Test Plan: 1) Apply this patch 2) Run process_message_queue.pl with a single -c parameter 3) Note behavior is unchanged 4) Run process_message_queue.pl with multiple -c parameters 5) Note all the codes specified are processed 6) Repeat 2-5 with -t for type limits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29983] Display the return claims column in the circulation overdues page (overdue.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29983 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #22 from Tomás Cohen Arazi --- There's a false-positive error detected by QA tools: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL valid_template modal-claims-js: not found noting here only for documentation purposes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23012] Possibility to mark processing fee by default refund when item is found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23012 Sara Brown changed: What|Removed |Added CC||sbr...@bywatersolutions.com --- Comment #3 from Sara Brown --- Agreed - this would be useful for a lot of libraries! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #72 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #71) > when doing apt search libemail-address-perl, do you have results? And is it > installed? Already fixed now by installing it, so I assume it wasn't. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16002] MULTI choices in report dropdowns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002 --- Comment #6 from Christopher Brannon --- (In reply to Katrin Fischer from comment #1) > Hi Christopher, I think the problem is in how to make this work with the SQL > query. <> is usually used with =, multi could be used with 'in > ()', but not sure how how to make an 'all' work in a good way. It seems like if you could do something like: homebranch IN (<>) If Koha could detect the parameter was in an IN statement, maybe it could use a dropdown that allows multiple selections. And if the all selection is made, all the selections would be in the IN statement. There would just need to be some logic to handle what to do if ALL was one of the multiple selections so it doesn't create strange results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #274 from Christopher Brannon --- What would it mean to have many people focus on it? Previously you asked for more eyes and feedback. I'm not setup to get into the development side of things, but if there is anything several non-programmers can do to help and give feedback, I'm sure we can generate interest and people to do what they can. Can you be more specific on what is needed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19372] Selecting MARC framework doesn't work when adding to basket from an external source
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19372 Sara Brown changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31298 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31298] Framework defaults don't work when adding records to basket from external source
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31298 Sara Brown changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19372 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31298] New: Framework defaults don't work when adding records to basket from external source
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31298 Bug ID: 31298 Summary: Framework defaults don't work when adding records to basket from external source Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: sbr...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org In 21.11.05, it appears that framework defaults aren't working properly when adding records to a basket from an external source. To test: 1) Set the following framework/942$c defaults: ACQ/NEW, Default/BOOK, SR/MAG 2) Set UseACQFrameworkForBiblioRecords to "Use the framework 'ACQ' for bibliographic records fields" 3) Create a basket, and add to it 'From an external source' 4) Select the SR framework prior to searching via z39.50 5) Bring in your record, and view the bib - note that 942$c is blank 6) Repeat steps 3-5 with Default and ACQ frameworks selected - the result is the same. The same thing happens when steps 3-6 are repeated with UseACQFrameworkForBiblioRecords set to "Don't use". At least as recently as 20.05, selecting a specific framework in step 4 above would override the ACQ framework when UseACQFrameworkForBiblioRecords was set to "use". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30321] Order receive page dies if quantity received is more than 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30321 --- Comment #9 from Nick Clemens --- (In reply to Emmi Takkinen from comment #8) > Still seeing this on 21.11. > > To test: > 1. Find order with one item and with quantity received as 1. > 2. Navigate to receive this order from parcel.pl. > 3. Click "Receive". > OR > 4. Use direct link to the order: > /cgi-bin/koha/acqui/orderreceive. > pl?ordernumber== > => error 500 is raised Can you describe the basket settings? When are items being created? I could use a full walkthrough from basket creation to error as I am not overly familiar with acquisitions workflows -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com |ity.org | Status|NEW |Needs Signoff Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31292] Untranslatable string in sample_notices.yaml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31292 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 138711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138711=edit Bug 31292 - Untranslatable string in sample_notices.yaml This patch removes a regex that discard lines in multiline YAML values On close inspection, there is no need for it. To test: 1) go to misc translator, update some language ./translate update fr-CA 2) check missing string egrep "You may pick up your article" po/fr-CA-installer.po from sample_notices.yaml 3) apply the patch, repeat 1) 4) repeat 2), verify the string is present in the translation file 5) translate the new string, install the language, verify string is present in the translated file ./translate install fr-CA check fr-CA/mandatory/sample_notices.yml There are three new strings msgid "%sDear %s %s,%s" msgid "%s%s%sTitle: %s" msgid "%sYou may pick up your article at %s.%sYou can download the scanned materials via the following url(s): %s.%s" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #140 from Nick Clemens --- patch needs minor rebase opac-details: Template process failed: undef error - The method Koha::Item->transfertwhen is not covered by tests! --from item-status-schema-org Itemtype icons no longer displaying in staff interface That's all I can touch right now. If you do not object to this becoming an omnibus and breaking it apart I will work through it in sections. I am happy to create the new bugs to help. This is fairly large in current state - I have some slight concerns about increased db fetches with this change and would like to be bale to focus on smaller bits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #139 from Victor Grousset/tuxayo --- oh I missed it, thanks, I'll apply it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29330] Koha cannot send emails with attachments using Koha::Email and message_queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29330 --- Comment #71 from Victor Grousset/tuxayo --- when doing apt search libemail-address-perl, do you have results? And is it installed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16002] MULTI choices in report dropdowns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com --- Comment #5 from he...@bywatersolutions.com --- This would be a great addition to reporting and a request I've been seeing a lot of recently in reports. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Katrin Fischer changed: What|Removed |Added Status|In Discussion |Passed QA --- Comment #8 from Katrin Fischer --- Article request is only one column - so I think we should not start the discussion here. Having separate for all suspension/fine, holds, recalls etc. would certainly make sense, but this is a small enhancement that fits the current pattern well. The other is reopening the discussion on a new editor for circulation rules, which is needed, but out of scope. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer --- Hm, I think think this doesn't fix what was reported as the bug initially: comment#1 The seasonal (season, day and month) prediction it doesn't change according the locale defined in the patterns, the pattern uses always the language of the staff user interface. I believe that the expectation here is that it should work like months/day of week do. You should be able to use the Locale setting of the subscription to determine the language used for the generated strings, so that it matches with what is printed on the issue. These are not meant to be multi-lingual, but to match the 'original' printed version. What this patch does is actually the bug: It makes the description switch depending on the GUI language used. Before this patch (tested in 20.11): Staff interface: German Locale: German Preview pattern: German Serial collection: German Edit serials: English OPAC: English Database: English With this patch set: Staff interface: *English* Locale: Spanish Preview pattern: English Serial collection: English Edit serials: English OPAC: English Database: English Update translations, switch interface to German: Staff interface: *German* Locale: Spanish Preview pattern: German Subscription detail view: German Serial collection German Edit serials: English (!) (input fields) Database: English Staff detail view: German Late issues/claims: German OPAC detail page - Subscription: English OPAC brief history: English Full history: English Conclusion: 1) This makes the display more consistent in the staff interface. OPAC has been missed and should work the same as staff. 2) Locale setting is ignored for seasons. This makes seasons work different to the other formatted strings. This doesn't sit well with me, because it's also an inconsistency, but I am not sure there is a fix as I believe the library used for other strings just doesn't support seasons. :( If we agree on the different behavior we should document it. Suggestion: Extend the hint below the Locale pull down by: "Not used for seasons." 3) Removing the limited support for abbreviated seasons is a little issue. We can hardly remove the setting if libraries have used it, but is it really useful if it works only for English? A compromise could be to add a hint to the entry in the formatting pull down: "Name of season (abbreviated, English)" What could help here in the future would be a feature to define your own "formatted strings" as a list of authorised values (thought I had filed that... but can't find it). Codes would be numerical, AV would be the string used and we could use them to extend the list of available formats. I had requests for Roman numbering and we could also imagine someone wanting to do Japanese numbering or similar. This could help solve that issue. (I'll file later if people like it :) ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31272] Show library name not code when placing item level holds in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31272 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into account when configuring curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264 --- Comment #6 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31264] CalendarFirstDayOfWeek not taken into account when configuring curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31264 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not log to action_logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249 --- Comment #4 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31249] update_patrons_category.pl cron does not log to action_logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31249 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30992] Hard to translate single word strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 --- Comment #15 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30992] Hard to translate single word strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30992 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 --- Comment #8 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30500] Add option to allow user to change the pickup location while a hold is in transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30500 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #58 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27497] Display Koha version in staff interface home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31289] Hide Article requests column in circulation rules when ArticleRequests syspref is disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31289 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |In Discussion CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #6) > This makes things more consistent and simplifies for those not using Article > requests, so I am going to pass it. > > There might be some discussion to be had if it makes sense to be able to > configure a feature without having it exposed to users immediately. But > that's complicated and should probably be a general decision (maybe > something like having 3 options for the prefs? (Enable config|Enable > feature|Disable) With the new table (circulation_rules) and the granularity it provides, I think we should move article requests-specific rules to their own section, and probably collapse them by default if the feature is disabled, but editable. For the same reasons you mentioned. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new patrons added at first login via LDAP/SAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646 --- Comment #8 from Kyle M Hall --- Created attachment 138710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138710=edit Bug 30646: (follow-up) Set to send immediately Other welcome notices send immediately rather than waiting on the queue to be processed.. these one's should too. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new patrons added at first login via LDAP/SAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646 --- Comment #7 from Kyle M Hall --- Created attachment 138709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138709=edit Bug 30646: Add welcome email support to SAML2 This patch adds the ability to enable the welcome email notice for new users added via the Shibboleth autocreate option. Test plan 1) Configure Shibboleth for authentication 2) Enable the welcome email by adding '1' to your shibboleth config block 3) Confirm you have autocreate enabled for your Shibboleth config 4) Attempt to login with an entirely new user to Koha using the shibboleth connection (with a user who has a valid email address mapped to Koha borrower fields) 5) Confirm the email is sent by looking at the notices for the new user. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new patrons added at first login via LDAP/SAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646 Kyle M Hall changed: What|Removed |Added Attachment #136171|0 |1 is obsolete|| Attachment #136172|0 |1 is obsolete|| Attachment #136173|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 138708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138708=edit Bug 30646: Add welcome email support to LDAP This patch adds the ability to enable the welcome email notice for new users added via the LDAP replicate option. Test plan 1) Configure LDAP for authentication 2) Enable the welcome email by adding '1' to your ldap config block 3) Confirm you have replicate enabled for your LDAP config 4) Attempt to login with an entirely new user to Koha using the LDAP connection (with a user who has a valid email address mapped to Koha borrower fields) 5) Confirm the email is sent by looking at the notices for the new user. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30646] Add option to send WELCOME notice for new patrons added at first login via LDAP/SAML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30646 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #75 from Kyle M Hall --- Created attachment 138704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138704=edit Bug 28787: Comment selenium test that will fail if no SMTP server is defined This is a deadlock I think. Any ideas how we could continue to test that in any conditions? Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #78 from Kyle M Hall --- Created attachment 138707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138707=edit Bug 28787: (QA follow-up) Remove unused variable Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #77 from Kyle M Hall --- Created attachment 138706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138706=edit Bug 28787: Fix misleading tests in two_factor_auth.t We were having a "Patron is not authenticated yet" comment, but it was not correct, we set 'number' and 'id' in session, and waiting-for-2FA was not set => the patron is fully authenticated. The test returned 401 because we fully authenticated user cannot request an otp token when not waiting for the second auth step. This situation is already covered (last test of the subtest). Test plan: prove t/db_dependent/api/v1/two_factor_auth.t must return green Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #76 from Kyle M Hall --- Created attachment 138705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138705=edit Bug 28787: (follow-up) Typo and additional test Adding a test for a 403 status when lowering authorization. The Auth mock for check_cookie_auth is not needed here. Reading back the session after flush either. Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #74 from Kyle M Hall --- Created attachment 138703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138703=edit Bug 28787: Mock send_or_die To make the tests pass even if no SMTP server is defined. Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #73 from Kyle M Hall --- Created attachment 138702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138702=edit Bug 28787: Don't request a token if no email address defined Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #72 from Kyle M Hall --- Created attachment 138701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138701=edit Bug 28787: Don't send the notice if we are not waiting for 2FA If we are fully logged-in or haven't pass the password phase, don't send the notice! Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #71 from Kyle M Hall --- Created attachment 138700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138700=edit Bug 28787: Rename the REST API route to /auth/otp/token_delivery Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #70 from Kyle M Hall --- Created attachment 138699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138699=edit Bug 28787: Fix t/db_dependent/api/v1/two_factor_auth.t Changing flags to 20 to include the required Staff access for intranet login. This changes the http status. The API raises an exception now. Test plan: Run t/db_dependent/api/v1/two_factor_auth.t Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #69 from Kyle M Hall --- Created attachment 138698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138698=edit Bug 28787: Typo authenticaction Signed-off-by: Marcel de Rooy Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28787] Send a notice with the TOTP token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28787 --- Comment #68 from Kyle M Hall --- Created attachment 138697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138697=edit Bug 28787: (follow-up) Changes in API auth, moved otp out of Letters Signed-off-by: Marcel de Rooy Sponsored-by: Rijksmuseum, Netherlands Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
