[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 --- Comment #13 from Marcel de Rooy --- (In reply to Joonas Kylmälä from comment #12) > Signed-off-by: Joonas Kylmälä Thx Joonas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 --- Comment #28 from Aleisha Amohia --- Created attachment 139937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139937=edit Bug 31051: (follow-up) Tests for get_savings and more - Added tests in t/db_dependent/Koha/Patron.t - Added wording to OPACShowSavings syspref about anonymised checkout history - Added IDs to the savings messages on the OPAC Sponsored-by: Horowhenua Libraries Trust -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #27 from Alex Buckley --- (In reply to Katrin Fischer from comment #22) > Hi Alex, > > I provided 2 follow-ups, but then I got stuck: The new check doesn't take > AnonSuggestions into account. When you click on the link in OPAC navigation > now, you get a 404 if logged in and Can't call method "category" on an > undefined value at /kohadevbox/koha/opac/opac-suggestions.pl line 97 if you > are logged out. > > I believe if AnonSuggestions is set, we need to always allow suggestions > independent of the other settings (should not matter if logged in or logged > out). Hi Katrin, I have attached a follow-up patch that should, hopefully, resolve the problems you raised. Now regardless of any other setting if the AnonSuggestions & suggestion syspref is enabled then a patron can create an OPAC suggestion. I tested on master and found if you have AnonSuggestions enabled, but suggestion disabled, then opac-suggestions.pl re-directs to the 404 page. You'll notice I also tweaked C4::Auth->get_template_and_user() so it now checks whether AnonSuggestions is enabled before passing the suggestion variable to the template. As I've added that I have tweaked your check on opac-results.tt, I hope that is alright. Ready for testing again. Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333
--- Comment #26 from Alex Buckley ---
Created attachment 139936
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139936=edit
Bug 31333: (follow-up) Handle anonymous patrons making suggestions
Test plan:
1. Enable suggestion & AnonSuggestions sysprefs and set AnonymousPatron = 1
2. Visit the OPAC without logging in
3. Confirm you can successfully create a suggestion from:
- Item detail page
- Search result page
- Masthead under the 'Library catalogue' search box
4. Disable the AnonSuggestions syspref
5. Confirm you cannot see links to make purchase suggestions on the
following pages:
- Item detail page
- Search result page
- Masthead under the 'Library catalogue' search box
6. Confirm if you try visiting /cgi-bin/koha/opac-suggestions.pl page
you are re-directed to a login page
7. Select the category of your user in the suggestionPatronCategoryExceptions
syspref
8. Log into the OPAC
9. Confirm you cannot see links to make purchase suggestions on the
following pages:
- Item detail page
- Search result page
- Masthead under the 'Library catalogue' search box
- opac-user.pl ('Your summary') page
10. Confirm if you try visiting /cgi-bin/koha/opac-suggestions.pl page
you are re-directed to a 404 error page
11. Enable AnonSuggestions syspref
12. Confirm you can successfully create a suggestion from:
- Item detail page
- Search result page
- Masthead under the 'Library catalogue' search box
- opac-user.pl ('Your summary') page
13. Disable AnonSuggestions syspref and un-check your category from
suggestionPatronCategoryExeptions syspref
14. Confirm you can create a suggestion from:
- Item detail page
- Search result page
- Masthead under the 'Library catalogue' search box
- opac-user.pl ('Your summary') page
Sponsored-by: Catalyst IT, New Zealand
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Alex Buckley changed: What|Removed |Added Attachment #139935|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 --- Comment #25 from Alex Buckley --- Created attachment 139935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139935=edit Bug 31333: (follow-up) Handle anonymous patrons making suggestions Test plan: 1. Enable AnonSuggestions syspref and set AnonymousPatron = 1 2. Visit the OPAC without logging in 3. Confirm you can successfully create a suggestion from: - Item detail page - Search result page - Masthead under the 'Library catalogue' search box 4. Disable the AnonSuggestions syspref 5. Confirm you cannot see links to make purchase suggestions on the following pages: - Item detail page - Search result page - Masthead under the 'Library catalogue' search box 6. Confirm if you try visiting /cgi-bin/koha/opac-suggestions.pl page you are re-directed to a login page Sponsored-by: Catalyst IT, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29882] Remove unrequired package definitions in list-deps script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29882 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- I take it that this is due to these deps being picked up out of the cpanfile? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26692] Add barcode image generator service for OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26692 --- Comment #33 from David Cook --- (In reply to Kyle M Hall from comment #0) > Some libraries would like to add a scannable barcode to the patron self > service area of the opac for patrons who do not have their library cards > with them. While developing the plugin, I've realized that many libraries might be using laser barcode scanners which are unlikely to work when scanning barcodes on a mobile phone screen... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31480] New: OAI-PMH Identify response missing "Repository identifier" and "Sample identifier"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31480 Bug ID: 31480 Summary: OAI-PMH Identify response missing "Repository identifier" and "Sample identifier" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org If you go to /cgi-bin/koha/oai.pl?verb=Identify, you'll see that "Repository identifier" and "Sample identifier" are blank. The ./koha-tmpl/opac-tmpl/xslt/OAI.xslt makes it seem that they should be at oai:description/oai_id:oai-identifier/oai_id:repositoryIdentifier/text() and oai:description/oai_id:oai-identifier/oai_id:sampleIdentifier/text() but there is no oai:description in the XML response. I imagine that someone must've written that XSLT with purpose once upon a time but that data has been lost to the ages... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Aleisha Amohia changed: What|Removed |Added Text to go in the|This enhancement adds an|This enhancement adds an release notes|option to skip the check|option to skip the check |for leftover atomic updates |for leftover atomic updates |when building custom|when building custom |packages. This is |packages. This is |particularly useful for |particularly useful for |Koha providers or anyone|Koha providers or anyone |else building Koha packages |else building Koha packages |manually. |manually. | | |In practice,|In practice, |this could be run like: |this could be run like: |sudo CUSTOM_PACKAGE=1 |sudo CUSTOM_PACKAGE=1 |./debian/build-git-snapshot |./debian/build-git-snapshot |-r ~/debian -v 21.11.01git |-r ~/debian -v 21.11.01git |-d |-d -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Aleisha Amohia changed: What|Removed |Added Text to go in the||This enhancement adds an release notes||option to skip the check ||for leftover atomic updates ||when building custom ||packages. This is ||particularly useful for ||Koha providers or anyone ||else building Koha packages ||manually. || ||In practice, ||this could be run like: ||sudo CUSTOM_PACKAGE=1 ||./debian/build-git-snapshot ||-r ~/debian -v 21.11.01git ||-d -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 --- Comment #1 from Aleisha Amohia --- Created attachment 139934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139934=edit Bug 31479: Option to skip t/00-check-atomic-updates.t when building custom packages This enhancement adds an option to skip the check for leftover atomic updates when building custom packages. This is particularly useful for Koha providers or anyone else building Koha packages manually. In practice, this could be run like: sudo CUSTOM_PACKAGE=1 ./debian/build-git-snapshot -r ~/debian -v 21.11.01git -d This test plan should all take place within the shell. 0. sudo koha-shell kohadev 1. Run prove t/00-check-atomic-updates.t and confirm the test passes 2. Add a fake atomic update to installer/data/mysql/atomicupdate/ . You can use the example from https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file 3. Run prove t/00-check-atomic-updates.t and notice the test fails 4. Set the CUSTOM_PACKAGE environment variable so we can test this. You can either set on the commandline (using export) or in /etc/environment (remember to run source /etc/environment so the changes are accessed) 5. Run prove t/00-check-atomic-updates.t and the test should now pass. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31468] Koha::Logger should prefix interface with 'plack'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31468 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 Aleisha Amohia changed: What|Removed |Added Blocks||31479 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 [Bug 31479] Provide an option to skip the test for atomic updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31479] Provide an option to skip the test for atomic updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Aleisha Amohia changed: What|Removed |Added Depends on||31108 Assignee|ch...@bigballofwax.co.nz|alei...@catalyst.net.nz Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31108 [Bug 31108] rename ./t/00-check-atomic-updates.pl extension to *.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31479] New: Provide an option to skip the test for atomic updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31479 Bug ID: 31479 Summary: Provide an option to skip the test for atomic updates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Since t/00-check-atomic-updates.t was fixed in Bug 31108, if there are any atomic updates left when building a package manually, the test and build will fail. Koha providers like Catalyst may keep atomic updates when building packages for customisations. Sometimes these are just temporary, while we wait for custom work to get upstreamed (in which case we can remove the atomic updates), but sometimes these are necessary customisations which must be kept for the library. So an option to skip this test when building a custom package would be useful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Alex Buckley changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #24 from Alex Buckley --- (In reply to Katrin Fischer from comment #22) > Hi Alex, > > I provided 2 follow-ups, but then I got stuck: The new check doesn't take > AnonSuggestions into account. When you click on the link in OPAC navigation > now, you get a 404 if logged in and Can't call method "category" on an > undefined value at /kohadevbox/koha/opac/opac-suggestions.pl line 97 if you > are logged out. > > I believe if AnonSuggestions is set, we need to always allow suggestions > independent of the other settings (should not matter if logged in or logged > out). Hi Katrin, Thanks for QA, I will work on a fix for this. Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #3 from Joonas Kylmälä --- Trivial fix, straight to PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177 Joonas Kylmälä changed: What|Removed |Added Attachment #137825|0 |1 is obsolete|| --- Comment #2 from Joonas Kylmälä --- Created attachment 139933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139933=edit Bug 31177: Fix misplaced import in C4::ILSDI::Services Signed-off-by: Tomas Cohen Arazi Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31177] Misplaced import in C4::ILSDI::Services
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31177 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 --- Comment #4 from Joonas Kylmälä --- Created attachment 139932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139932=edit Bug 29409: Check for data that violates a constraint to avoid update problems https://bugs.koha-community.org/show_bug.cgi?id=29049 Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 Joonas Kylmälä changed: What|Removed |Added Attachment #127275|0 |1 is obsolete|| Attachment #127276|0 |1 is obsolete|| --- Comment #3 from Joonas Kylmälä --- Created attachment 139931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139931=edit Bug 29409: Check for existence of constraint before deletion https://bugs.koha-community.org/show_bug.cgi?id=29049 Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29409] Update for bug 25333 can fail due to bad data or constraints
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29409 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24975] Refactor database translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24975 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi Status|Needs Signoff |Patch doesn't apply --- Comment #85 from Joonas Kylmälä --- (In reply to Martin Renvoize from comment #84) > Ready for testing.. Martin, I assume the patches attached to this bug report from you are the latest. They don't apply anymore. Could you do a rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||joonas.kylm...@iki.fi --- Comment #120 from Joonas Kylmälä --- Lari, will you continue working on this? Currently the patches don't apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658
Joonas Kylmälä changed:
What|Removed |Added
Attachment #139126|0 |1
is obsolete||
--- Comment #12 from Joonas Kylmälä ---
Created attachment 139930
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139930=edit
Bug 29658: Fix crash on cancelling cancelled order
Found this crash in our 20.11 logs:
Cannot insert order: Mandatory parameter biblionumber is missing at
/usr/share/koha/acqui/cancelorder.pl line 60.
at /usr/share/perl/5.28/Carp.pm line 289
Carp::croak('Cannot insert order: Mandatory parameter biblionumber is
missing') called at /usr/share/koha/Koha/Acquisition/Order.pm line 79
Koha::Acquisition::Order::store('Koha::Acquisition::Order=HASH(0x55f3760e2860)')
called at /usr/share/koha/Koha/Acquisition/Order.pm line 189
Koha::Acquisition::Order::cancel('Koha::Acquisition::Order=HASH(0x55f3760e2860)',
'HASH(0x55f375a17ec0)') called at /usr/share/koha/acqui/cancelorder.pl line 60
Not sure how to reproduce this one as it happened. But might be related to
repeated clicking, backspacing etc.
Test plan:
Create a new basket and order.
Open this same basket in two browser tabs.
Cancel the order line (delete catalog record) in tab 1.
Go to second tab, try again.
Without this patch, it will crash. With this patch, an error message.
Signed-off-by: Marcel de Rooy
Signed-off-by: Joonas Kylmälä
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29658] Crash on cancelling cancelled order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29658 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31356] Itiva outbound script doesn't respect calendar when calculating expiration date for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31356 Joonas Kylmälä changed: What|Removed |Added Attachment #139072|0 |1 is obsolete|| --- Comment #4 from Joonas Kylmälä --- Created attachment 139929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139929=edit Bug 31356: Use hold expiration date instead of adding days to the waiting date The Talking Tech outbound script currently just adds the ReservesMaxPickUpDelay to the waiting date to calculate the "expiration date", but it should use the actual hold expiration date which may differ from this naive calculation based on various system preference values. Test Plan: 1) Create a holiday for tomorrow 2) Set ReservesMaxPickUpDelay to 5 3) Set "Days mode" to "Same week day" 4) Enable ExcludeHolidaysFromMaxPickUpDelay 5) Enable TalkingTechItivaPhoneNotification 6) Create a hold and fill the hold so it is waiting 7) Enable "Hold filled" phone notices for that patron 8) Create a 'phone' version of the HOLD notice 9) Run ./misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl --type RESERVE -w 0 10) Note the output has the expiration date ( 15th colume ) 5 days from now which is *not* the hold's expiration date 11) Apply this patch 12) Repeat the command from step 9 13) Note the expiration date column now matches the holds actual expiration date! Signed-off-by: Kyle Hall Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31356] Itiva outbound script doesn't respect calendar when calculating expiration date for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31356 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31356] Itiva outbound script doesn't respect calendar when calculating expiration date for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31356 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | CC||joonas.kylm...@iki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #199 from Joonas Kylmälä --- Trivial removal of unused subroutines, fast forwarding directly to PQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä changed: What|Removed |Added Attachment #138832|0 |1 is obsolete|| --- Comment #198 from Joonas Kylmälä --- Created attachment 139928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139928=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo With the different bug reports we removed the calls for those 3 subroutines. We can remove them now. Test plan: git grep their names and you should not find any occurrences in the code base Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com --- Comment #133 from Andrew Nugged --- Some remnants in the master branch (I am trying to combine (oh that's the challenge!) these changes with Bug 20447, that's why giving some parallel feedback): I see this left: C4/Biblio.pm: 56: EmbedItemsInMarcBiblio I think that line is the only one that we have across all codebase, so just the remnants. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 Joonas Kylmälä changed: What|Removed |Added QA Contact|k...@bywatersolutions.com |joonas.kylm...@iki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31465] 21.11 manual says it is 20.05 manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31465 Katrin Fischer changed: What|Removed |Added CC||l...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com --- Comment #1 from Katrin Fischer --- The versions of the different branches look correct in git. I wonder if there is something wrong with building the manuals? https://gitlab.com/koha-community/koha-manual/-/blob/master/source/index.rst https://gitlab.com/koha-community/koha-manual/-/blob/manual21.11.x/source/conf.py -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 --- Comment #5 from Joonas Kylmälä --- Created attachment 139927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139927=edit Bug 31315: (QA follow-up) Show itemtype description instead of database code This restores the previous definition for itype that displayed the description instead of itemtype. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 Joonas Kylmälä changed: What|Removed |Added Attachment #138897|0 |1 is obsolete|| --- Comment #4 from Joonas Kylmälä --- Created attachment 139926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139926=edit Bug 31315: Remove GetHostItemsInfo and GetItemsInfo from moredetail Bug 27272 is going to remove C4::Items::GetItemsInfo in favour of Koha::Items->search. Here we are going to deal with catalogue/moredetail Test plan: List items on the modified view and confirm that all the info is displayed correctly Signed-off-by: Owen Leonard Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 Joonas Kylmälä changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30641] Authority detail page shows wrong number of records using the authority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30641 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #13 from Katrin Fischer --- (In reply to Magnus Enger from comment #12) > (In reply to Katrin Fischer from comment #10) > > ... and we'll probably need a unit test > > Should this be "Failed QA" then? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31470] Incorrect selector for relationship dropdown used in members.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31470 --- Comment #2 from Katrin Fischer --- Hi Emmi, could you please add a test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31436] AllowRenewalIfOtherItemsAvailable should not take suspended holds into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31436 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi Resolution|--- |FIXED Status|Needs Signoff |RESOLVED --- Comment #2 from Joonas Kylmälä --- The bug 31112, dependency for this bug already fixed this issue. Closing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 --- Comment #10 from Joonas Kylmälä --- Created attachment 139925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139925=edit Bug 30483: (DBIx schema) Changes to Issue.pm Compare with results of update_dbix_class_files.pl. Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Joonas Kylmälä changed: What|Removed |Added Attachment #139682|0 |1 is obsolete|| Attachment #139683|0 |1 is obsolete|| --- Comment #9 from Joonas Kylmälä --- Created attachment 139924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139924=edit Bug 30483: Make issues.borrowernumber and itemnumber NOT NULL Note: This change does NOT apply to old_issues, where constraints may result in nullifying these columns. Test plan: Run dbrev. Try checkout, checkin. Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30483] Do not allow NULL in issues.borrowernumber and issues.itemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30483 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #54 from Joonas Kylmälä --- Passing QA. Added one more patch, the last one, to remove an unused variable in the opac-reserve.pl file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #53 from Joonas Kylmälä --- Created attachment 139923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139923=edit Bug 30847: Remove unused variable Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #52 from Joonas Kylmälä --- Created attachment 139922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139922=edit Bug 30847: Consolidate code to check if patron can place holds and exit if they cannot This will save us fetching more info if we are denying the holds Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #51 from Joonas Kylmälä --- Created attachment 139921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139921=edit Bug 30847: Don't get biblio/item info when placing holds The only bit we get form the hash is the rank and title We can simply fetch the biblio once to calculate no need to fetch all the info as we don't display or use it Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #50 from Joonas Kylmälä --- Created attachment 139920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139920=edit Bug 30847: Don't declare undef variable for assignment New holds have found set to undef - we can do this directly Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #49 from Joonas Kylmälä --- Created attachment 139919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139919=edit Bug 30847: Avoid fetching biblio object Here the items biblionumber is either equal to the biblionumber passed in or it is not and should be - we can just assign directly from the item in all cases Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #48 from Joonas Kylmälä --- Created attachment 139918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139918=edit Bug 30847: Don't fetch patron twice Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #47 from Joonas Kylmälä --- Created attachment 139917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139917=edit Bug 30847: Remove unused OPACShowHoldQueueDetails Search for the variables, they aren't used! Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 --- Comment #46 from Joonas Kylmälä --- Created attachment 139916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139916=edit Bug 30847: Remove unused noreserve parameter This is defined but never used To test: 1 - git grep noreserve 2 - only one ocurrence 3 - Apply patch 4 - repeat, no ocurrence 5 - Note the plural has a few uses Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Joonas Kylmälä changed: What|Removed |Added Attachment #139628|0 |1 is obsolete|| Attachment #139629|0 |1 is obsolete|| Attachment #139630|0 |1 is obsolete|| Attachment #139631|0 |1 is obsolete|| Attachment #139632|0 |1 is obsolete|| Attachment #139633|0 |1 is obsolete|| Attachment #139634|0 |1 is obsolete|| Attachment #139635|0 |1 is obsolete|| --- Comment #45 from Joonas Kylmälä --- Created attachment 139915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139915=edit Bug 30847: Cleanup calculation of holds and rank Currently we loop over all the holds on the record to get a count of the reserves not waiting and a rank for the upcoming hold We can simply count the number of nont waiting holds and add 1 Note: Before this patch the count of holds included the new hold we were going to place which meant rank and count were the same. I believe countaing existing holds and our upcoming rank is the correct behavior To test: 1 - Set OPACShowHoldQueueDetails system preference to 'Show holds and their priorty level' 2 - Place a few holds on a bib on the staff side 3 - Mark 1 waiting 4 - Attempt to place hold on the bib on the opac 5 - Note 'Your priority' and 'Number of holds' are the same number 6 - Place another hold, confirm both increase 7 - Set another hold waiting, confirm both decrease 8 - Apply patch 9 - Confirm 'Your priority' is now 1 greater than Number of holds 10 - Place a hold, set a hold waiting, confirm numbers adjust as appropriate Signed-off-by: Owen Leonard Rebased-by: Victor Grousset/tuxayo Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Joonas Kylmälä changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30847] Cleanup opac-reserve.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 Joonas Kylmälä changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23849] Update the list of sysprefs to share with Hea
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23849 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #27 from Katrin Fischer --- This works nicely and I quite like the idea! Only one real blocker and some notes/suggestions: 1) +=head3 get_savings (blocker) We need some unit tests here. 2) issues + old_issues (not blocker) A lot of libraries nowadays choose to anonymize the checkout history rather fast. So as we look at issues and old_issues here, the amount saved will go up and down quite a bit. I wonder if it could make sense to add a note to the pref so libraries have this in mind when activating the feature. 3) Wording (follow-up patch added) I have provided another follow-up for the reading history page following Owen's suggestion as this will also ease translation (combined constructs like x catalog are always a little hard) 4) id (not blocker) It could be nice to have a specific id on the message in the summary page and reading history in case libraries want to do some formatting or rephrasing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 --- Comment #26 from Katrin Fischer --- Created attachment 139914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139914=edit Bug 31051: (QA follow-up) Simplify savings wording for reading history Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Katrin Fischer changed: What|Removed |Added Attachment #139410|0 |1 is obsolete|| --- Comment #25 from Katrin Fischer --- Created attachment 139913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139913=edit Bug 31051: (follow-up) Simplify savings wording for OPAC Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Katrin Fischer changed: What|Removed |Added Attachment #139409|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 139912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139912=edit Bug 31051: Show patron savings on the OPAC This new feature shows a patron how much they have saved by using the library rather than purchasing items. Savings are calculated based on item replacement prices. The system preference allows you to choose where to display the savings - the user page, the summary box on the OPAC homepage, or the checkout history page. To test: 1. Update database and restart services 2. Confirm the new OPACShowSavings system preference is found in the OPAC tab of Administration -> global system preferences. There should be no options selected. 3. Find a patron with a checkout history, or check out a few items to a patron. 4. Test with different values of OPACShowSavings and confirm that savings are shown in the expected places. Sponsored-by: Horowhenua Libraries Trust Signed-off-by: Marie-Luce Signed-off-by: Axelle Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051 Katrin Fischer changed: What|Removed |Added Attachment #139408|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 139911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139911=edit Bug 31051: Add OPACShowSavings system preference Signed-off-by: Marie-Luce Signed-off-by: Axelle Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31474] Patron category system preferences cannot be unselected completely
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31474 Katrin Fischer changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31333 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31333 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31333] Add the ability to limit purchase suggestions by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31333 Katrin Fischer changed: What|Removed |Added See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=31474 |?id=31364 --- Comment #23 from Katrin Fischer --- (In reply to Katrin Fischer from comment #19) > I am starting QA here, also filed bug 31474 for the general bug Rhonda found. Missed that Rhonda had already filed it: bug 31364 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- *** Bug 31474 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31474] Patron category system preferences cannot be unselected completely
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31474 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 31364 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31364] Saving preferences with a dropdown with check boxes doesn't save in the case where all the checks are removed.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31364 Katrin Fischer changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31254] Add additional fields for accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 --- Comment #7 from Katrin Fischer --- This works as described and I think it will be a nice addition to the additional field system. I'd be interested in use cases for this - Julian, maybe you can share what triggered this development? Also, any plans to revive Bug 11844 - Additional fields for order lines? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31254] Add additional fields for accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 Katrin Fischer changed: What|Removed |Added Attachment #139604|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 139910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139910=edit Bug 31254: Add additional fields for accountlines Test plan: 1. Go to Admin » Additional fields There are two new categories: "Account lines (credit)" and "Account lines (debit)" 2. Create fields for both categories, with and without an authorized value category 3. Go to a user's accounting page 4. Create a manual invoice. Verify that all "debit" fields are there, put a value in them and save 5. Create a manual credit. Verify that all "credit" fields are there, put a value in them and save 6. Make a payment. Verify that all "credit" fields are there, put a value in them and save 7. Go to the transactions tab, click on the "Details" button for the lines you just created and verify that the additional fields are there Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31254] Add additional fields for accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31254] Add additional fields for accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31254 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with GetMarcUrls for whitespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Katrin Fischer changed: What|Removed |Added Attachment #139817|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 139909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139909=edit Bug 30262: Trim whitespace off tracklinks.pl URLs This patch trims whitespace off tracklinks.pl URLs so that the URL is in the same format as the URLs returned by C4::Biblio::GetMarcUrls, which is used by tracklinks.pl internally. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 2. Add a 856 with $u of 'https://koha-community.org ' (note the space at the end0 3. Save record 4. Change 'TrackClicks' syspref to 'Track' 5. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 6. Click on the online resource (eg http://localhost:8080/cgi-bin/koha/tracklinks.pl?uri=https%3A%2F%2Fkoha-community.org%20=29 ) 7. Note you are redirected to https://koha-community.org Signed-off-by: Magnus Enger Added the link with a space at the end. Verified that without the patch, clickin on "Click here to access online" gives a 404. After applying the patch the redirect works as expected. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with GetMarcUrls for whitespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30262] opac/tracklinks.pl inconsistent with GetMarcUrls for whitespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #60 from Katrin Fischer --- Please note the follow-up for the typo! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #59 from Katrin Fischer --- Hi Lucas, 1) Changes to patron name display in general I am a bit hesitant about the changes to koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc. To me the pronouns don't feel like a part of the name and therefore I'd prefer to keep them separate from the common name include. My suggestion would be to show them separately but prominently in the brief patron information on the left side of patron account in the staff interface instead. At the moment we create a very long display string, even with 'short' name parts. But this is certainly something we could argue about and feel free to ask others for their opinions please! To give some examples: Headings in the patron account: Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559) Staff detail: Checked out to Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559) : due 09/02/2022 Accounting tab: Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559) has no outstanding fines. Notices tab, h1: Sent notices for Mr Floyd Middle (Other_name) Delgado(he/him) (23529000809559) .. if you insist, there are 2 things in the include: 1) Do we need pronouns for organisations? :) type = I is organisations often used for libraries or schools. I think pronouns would not be required here: [%- IF data.category_type == 'I' -%] -[%- data.surname | html %] [% IF data.othernames %] ([% data.othernames | html %])[% END -%] +[%- data.surname | html %] [% IF data.othernames %] ([% data.othernames | html %])[% END -%] [% IF data.pronouns %]([% data.pronouns | html %])[% END %] 2) Missing space We are also missing a space: Floyd Middle (Other_name) Delgado(he/him) 3) Details tab in staff And unrelated: currently pronouns show up under "contact information", but that doesn't feel quite right for placement and I don't like the quotes for some reason: Contact information “she/her” 6661 Library Rd. Springfield, MA 44224 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10950] Add preferred pronoun field to patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 --- Comment #58 from Katrin Fischer --- Created attachment 139908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139908=edit Bug 10950: (QA follow-up) Fix typo in hidden check in OPAC patron form definded => defined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA Keywords||release-notes-needed --- Comment #47 from Katrin Fischer --- I like the concept of having a cataloguing start page to get our modules closer in terms of a standard UI. I think the problem I see here is that we need to put in more work to fix the discrepancies caused by moving tools to cataloguing (where they rightly belong). At the moment if you click on those links the breadcrumbs, URL and sidebar switch to tools. Also: the permissions are in tools. I feel like we should do more steps in moving these tools. * Sidebar will be fixed by bug 31417. * Breadcrumbs could be fixed after. * URLs - I am not completely sure about moving the files thb. but something to think about. I have created 2 follow-ups for you to check and a couple of linked bugs with suggestions. And I have one more thing I'd like to see "fixed" before we push this as a first step in restructuring: The extra click for catalogers. At the moment, using the split button you an get right into the framework you want. We remove this option. And I think that will make people grumpy. * Default takes a while to load compared with the smaller frameworks. * It's an extra click to switch. * Switching frameworks when using default values can be problmatic. A default once added to a field, doesn't update when switching frameworks (say s for serials in LDR was added). Being able to choose the framework right away is important I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #46 from Katrin Fischer --- Created attachment 139907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139907=edit Bug 31162: (QA follow-up) Change Automations to Automation This was suggested by David Nind in testing and I agree that it sounds a litle nicer. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 --- Comment #45 from Katrin Fischer --- Created attachment 139906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139906=edit Bug 31162: Fix help link on catalouging start page Now the link goes to the cataloguing chapter start page of the manual instead of the less specific manual start page. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What|Removed |Added Attachment #139652|0 |1 is obsolete|| --- Comment #44 from Katrin Fischer --- Created attachment 139905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139905=edit Bug 31162: Move Rotating Collections and Upload Covers This patch moves the 'Rotating Collections' link from 'Cataloging' to 'Circulation' on the 'Tools' home page and moves the 'Upload local cover image' link to the 'Cataloging' home page. This removes the 'Cataloging' tools section entirely and as such the template is adapted to a two column layout to compensate. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What|Removed |Added Attachment #139650|0 |1 is obsolete|| --- Comment #43 from Katrin Fischer --- Created attachment 139904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139904=edit Bug 31162: More conditionals for sections This adds missing conditionals to the section headings in the new cataloging homepage. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What|Removed |Added Attachment #139597|0 |1 is obsolete|| --- Comment #42 from Katrin Fischer --- Created attachment 139903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139903=edit Bug 31162: Remove duplicates from tools-home This patch removes cataloging tools from the tools-home page where they are now listed on the cataloging home page. This leaves just two options in the 'Cataloging' section of the tools home page, 'Rotating collections' and 'Upload local cover images'. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What|Removed |Added Attachment #139596|0 |1 is obsolete|| --- Comment #41 from Katrin Fischer --- Created attachment 139902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139902=edit Bug 31162: (follow-up) 3 Column layout This patch converts to a 3 column layout as suggested by David. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What|Removed |Added Attachment #139595|0 |1 is obsolete|| --- Comment #40 from Katrin Fischer --- Created attachment 139901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139901=edit Bug 31162: Remove toolbar This patch removes the existing toolbar with 'New record' and 'New from Z39.50/SRU' and replaces the functionality with simple buttons on the page. We lose the ability to select the Framework or Z39.50/SRU server at this stage but one can still select these options from the resulting dialogues. Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What|Removed |Added Attachment #139594|0 |1 is obsolete|| --- Comment #39 from Katrin Fischer --- Created attachment 139900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139900=edit Bug 31162: Add a cataloging module home page This patch adds a new cataloging-home template and controller and replaces most cases of links to addbooks. This servers to provide a new cataloging home page for the cataloging module and keeps it distinct from the current addbooks page it partially replaces as a stating point for cataloging. Signed-off-by: KIT Signed-off-by: Emmanuel Bétemps Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What|Removed |Added Blocks||31478 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31478 [Bug 31478] Standardize upload/download icons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31478] New: Standardize upload/download icons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31478 Bug ID: 31478 Summary: Standardize upload/download icons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Depends on: 31162 The new cataloging start page uses the upload/download icons for: * stage records for import (down) * export catalog (up) * upload local cover images (up) I feel like the icons for the first 2 should be switched. Export is a 'download' while staging is an 'upload'. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What|Removed |Added Blocks||31477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31477 [Bug 31477] Switch icon for inventory -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31477] New: Switch icon for inventory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31477 Bug ID: 31477 Summary: Switch icon for inventory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Depends on: 31162 The 'chart' icon doesn's quite capture inventory for me. I think list-check or ballot-check would capture the tool's purpose better. You are working through your items and check what's there or missing... https://fontawesome.com/icons/clipboard-check?s=solid Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31162] Add a clear cataloguing module home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 Katrin Fischer changed: What|Removed |Added Blocks||31476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31476 [Bug 31476] Add tool tips to the buttons on the circulation start page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31476] New: Add tool tips to the buttons on the circulation start page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31476 Bug ID: 31476 Summary: Add tool tips to the buttons on the circulation start page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Depends on: 31162 With the move from the tools page to the circulation start page we lost the short explanations that appeared under each tool. I think it would be nice to bring them back as tool tips like we do for some (sadly not all) buttons on the circulation start page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31162 [Bug 31162] Add a clear cataloguing module home page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
