[Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #2 from David Nind  ---
The patch adds the title to the list of fields and is in red, however it can't
be made optional - that is, it is still mandatory.

Happy to sign off if this is what is intended.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24127] Remove dropdown option of shelving location from advanced search in staff

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #15 from David Nind  ---
I've tested the 2 patches separately, and they both work.

I have signed off on Nick's patch as it clarifies what is required, instead of
removing the option.

Happy to sign off Katrin's patch if that is the preferred option.

One will need to be obsoleted!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24127] Remove dropdown option of shelving location from advanced search in staff

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127

David Nind  changed:

   What|Removed |Added

 Attachment #140867|0   |1
is obsolete||

--- Comment #14 from David Nind  ---
Created attachment 140966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140966=edit
Bug 24127: Add 'code' and title to shelving location search

This patch attempts to clarify the 'Shelving location' option in the
staff side dropdown, as it requires searching the shelving location code, not
the values. i.e. 'FIC' not 'Fiction'

This patch adds (code) to the option and adds a title, visible on hover

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24127] Remove dropdown option of shelving location from advanced search in staff

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31614] Add configurable timeout for Zebra connections

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31614

David Nind  changed:

   What|Removed |Added

 Attachment #140881|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 140965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140965=edit
Bug 31614: Adds a koha-conf.xml config to set Zebra connection timeout

This patch adds 30
to the koha-conf.xml file.

Sometimes, a Zebra search might take longer than 30 seconds. If it does,
Koha will say that 0 records have been found. While slow searching
is not desirable, it's more desirable to get the result set regardless.

Test plan:
0. Apply patch
1. Add .1 to
your relevant koha-conf.xml file (e.g. /etc/koha/sites/kohadev/koha-conf.xml)
2. echo 'flush_all' | nc -q 1 memcached 11211
3. koha-plack --restart kohadev
4. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test
5. Note that no results are returned
6. Change zebra_connection_timeout to 30
7. echo 'flush_all' | nc -q 1 memcached 11211
8. koha-plack --restart kohadev
9a. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test
9b. Note that 3 results are returned
10. Remove zebra_connection_timeout from koha-conf.xml
11. echo 'flush_all' | nc -q 1 memcached 11211
12. koha-plack --restart kohadev
13a. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test
13b. Note that 3 results are returned
14. Celebrate

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31614] Add configurable timeout for Zebra connections

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31614

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31609] JavaScript error on Additional contents main page

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31609

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Failed QA

--- Comment #2 from David Nind  ---
Failed QA because after applying the patch and go to go Tools > Additional
contents:
- error no longer appears when language is English
- switch to another language installed: the error message reappears.

Steps to reproduce (tested using KTD):
1. Install another language: koha-translate --install fr-CA
2. Add an additional contents entry.
3. Replicate the error as per the test plan.
4. Apply the patch - leave language as English, flush_memcached, restart_all,
clear browser cache.
5. From the home page, go to Tools > Additional contents - there should be no
error in the browser console.
6. Switch language to Français.
7. The error message is back! (Note that it doesn't happen when you switch back
to English.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31579] Improve reserve/request.pl to avoid mistakes with pick up locations

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31579

geraud.frapp...@inlibro.com changed:

   What|Removed |Added

 Attachment #140907|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31621] aqbooksellers.deliverytime should not be nullable

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31621

Fridolin Somers  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31621] aqbooksellers.deliverytime should not be nullable

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31621

Fridolin Somers  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29310] Add timestamp, updated_on to aqbooksellers

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29310

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=31621

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31621] aqbooksellers.deliverytime should not be nullable

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31621

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29310

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31621] New: aqbooksellers.deliverytime should not be nullable

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31621

Bug ID: 31621
   Summary: aqbooksellers.deliverytime should not be nullable
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

The column aqbooksellers.deliverytime is actually :
`deliverytime` int(11) DEFAULT NULL

But it is used in several places as an integer.
Defaut value should be 0 and not nullable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29671] Dropbox mode is unchecked after check in confirm on item with Materials specified

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671

geraud.frapp...@inlibro.com changed:

   What|Removed |Added

 CC||geraud.frapp...@inlibro.com
 Attachment #128374|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29671] Dropbox mode is unchecked after check in confirm on item with Materials specified

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671

--- Comment #2 from geraud.frapp...@inlibro.com ---
Created attachment 140964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140964=edit
Bug 29671: Dropbox mode is unchecked after check in confirm on item with
Materials specified

Suggested patch

steps to reproduce :

1) Enable System preference CirConfirmItemParts
2) Go to Circulation > Check in
3) Enable Dropbox mode (Book drop mode) in the Checkin settings
4) Enter a barcode of an item having the 'Materials specified' field not empty
5) A Popup is shown, click the confirm button
6) The Dropbox mode (Book drop mode) is now unchecked, but should stay checked.

In the template, the modal window lacks the dropboxmode input, so that it stays
on the next page. I attached a patch with my suggested correction.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30237] Rename/rephrase AutoEmailOpacUser/ACCTDETAILS feature to clarify intended use

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30237

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/589
   Keywords|Manual, |
   |release-notes-needed|
  Documentation||Caroline Cyr La Rose
contact||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31620] New: Dropbox mode is unchecked after check in confirm on item with Materials specified

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31620

Bug ID: 31620
   Summary: Dropbox mode is unchecked after check in confirm on
item with Materials specified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: geraud.frapp...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

-Author

Being not able to apply the patch made by Christophe TORIN. BUG 29671

Here is a new bug report where the community will be able to sign-off the patch
by Christophe Torin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30752] Show hint on Library transfer limits admin page, when UseBranchTransferLimits is inactive

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30752

Owen Leonard  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31256] Circ rules batch modification

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256

--- Comment #4 from George Williams (NEKLS)  ---
Circ rules batch modification would be a huge help.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31256] Circ rules batch modification

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256

Michael Adamyk  changed:

   What|Removed |Added

 CC||mada...@ckls.org

--- Comment #3 from Michael Adamyk  ---
Absolutely! This would make life for consortiums much easier.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31256] Circ rules batch modification

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256

--- Comment #2 from George Williams (NEKLS)  ---
Circ rules batch modification would be a huge help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31256] Circ rules batch modification

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31256

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619

Galen Charlton  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619

--- Comment #1 from Galen Charlton  ---
Created attachment 140963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140963=edit
Bug 31619: add title back to list of OPACSuggestionMandatoryFields options

This patch fixes a regression introduced by bug 29695 that prevented
setting the title as a required field when setting the
OPACSuggestionMandatoryFields to a non-default value.

To test:

[1] Set OPACSuggestionMandatoryFields in the system preferences
editor and note that 'title' is not listed in the modal
that is displayed.
[2] Apply the patch.
[3] Revist the system preference editor and note that 'title'
is now displayed as an option.

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8305] Add an icon for iOS home screens

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8305

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #140340|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 140962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140962=edit
Bug 8305: Added an icon for iOS home screen

1. Bookmark the Koha OPAC on an iOS device
2. See if an icon is formed on the home screen
   of the device

Signed-off-by: Petro Vashchuk 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8305] Add an icon for iOS home screens

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8305

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31619] Cannot select title when setting non-default value for OPACSuggestionMandatoryFields

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619

Galen Charlton  changed:

   What|Removed |Added

   Severity|enhancement |minor
   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31619] New: Cannot select title when setting non-default value for OPACSuggestionMandatoryFields

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31619

Bug ID: 31619
   Summary: Cannot select title when setting non-default value for
OPACSuggestionMandatoryFields
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: gmcha...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Possibly because of a timing issue when the patches for bug 29695 were merged,
"title" is no longer listed as an option on the value list for
OPACSuggestionMandatoryFields.

As a consequence, if that system preference is set to any non-default value, it
becomes impossible to have the title field be mandatory on the OPAC purchase
suggestion form.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31496] SCO slip uses data of patron's home library instead of the SCO staff users's library

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #140267|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 140961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140961=edit
Bug 31496: Fix branch in printslip.pl to logged in staff user's library

When you print a receipt slip in SCO, the library/branch you are at
in should be fetched from the logged in staff member's data (staff login
done before entering SCO view) instead of the patron's own who has signed
in to the SCO. Printing a slip shows patron's own home branch in the slip
as the branch they're in. This causes confusion with patrons who want to
print receipts/slips.

Test plan:
1) Make sure the staff user's library (used to login into SCO patron
   view) is not the same as the patron's who is logging into SCO
2) Print a slip in SCO and notice patron's home library printed on the slip
3) Apply patch
4) Print a slip in SCO and notice the library is now the staff user's library
   used to sign in to SCO patron view.

Signed-off-by: Katrin Fischer 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31496] SCO slip uses data of patron's home library instead of the SCO staff users's library

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31496

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25812] Display overdue fines for the item on SIP checkin

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25812

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #7 from Kyle M Hall  ---
I like this, but I think it needs to be optional. It would be nice if the
feature accepted a TT template so the message could be translated, but even a
simple on/off switch would suffice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Remove remainders of unfinished reqholdnotes functionality

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #139947|0   |1
is obsolete||

--- Comment #45 from Kyle M Hall  ---
Created attachment 140960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140960=edit
Bug 15545: Remove reqholdnotes from opac-reserve

This never really made it. So let's remove all traces.

Test plan:
Look at code changes and git grep reqholdnotes.
Bonus: Place a hold with/without hold notes.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15545] Remove remainders of unfinished reqholdnotes functionality

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29100] Add checkouts data loop to predue notices script ( advance_notices.pl )

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29100

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #12 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #11)
> I fully support having an TT based option besides items.content for these
> notices. It's about time! But I am still a bit confused about this patch :(
> 
> What information can I get from issue or issues? (which tables?) We'll
> definitely need to document. As it has the title in your example, I assume
> it's not just a line from the issues table, but more than that.
> 
> https://wiki.koha-community.org/wiki/
> Notices_with_Template_Toolkit#Variables_available_in_each_notice
> 
> Terminology: We really should be using checkout instead of issue.
> 
> If we use checkout(s), will it be the same as the one available in other
> notices?

Yes, that is correct. It gives that notice access to the checkout object, which
means the library can can then have much greater ability to customize the
format of the notice than with items.content. The library gets access to the
checkout, the bib and the item data ( among others ).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31566] 'Patrons selected' counter doubles on 'Select all'

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566

--- Comment #3 from David Nind  ---
Noted when testing:

- The dropdown list for 'Show X entries' has the options: 10 20 (default) 20 50
100 All 

- Note that 20 is repeated.

- This was there before the patch was applied, so not related to this bug and I
should probably log as a separate one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31566] 'Patrons selected' counter doubles on 'Select all'

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566

David Nind  changed:

   What|Removed |Added

 Attachment #140923|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 140959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140959=edit
Bug 31566: 'Patrons selected' counter doubles on 'Select all'

This patch refines the JavaScript which is run when the "Select all"
or "Clear all" controls are clicked. The script now checks to see
whether the checkbox is checked before triggering the change function.

To test, apply the patch and perform a patron search in the staff
interface which will return multiple results.

- After the patron search results are displayed, test the "Select
  all" control. The visible search results should all be checked,
  and the "Patrons selected" counter at the top should be
  incremented correctly.
- Clicking the "Select all" control again should have no effect.
  The "Patrons selected" counter should not increment again.
- Test the "Clear all" control to confirm that checkboxes are
  unchecked and the counter updates correctly.
- Test with multiple pages of patron search results to confirm
  that the controls work correctly on any page of results..

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31566] 'Patrons selected' counter doubles on 'Select all'

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31602] Replace Try::Tiny with something faster

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31602

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #1 from Tomás Cohen Arazi  ---
Well, this is interesting! Thanks Kyle

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31203] Cronjobs should log completion as well as logging begin

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31203

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31606] Enhance acquisitions to allow ordering on next year's budget when still in current year.

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31606

--- Comment #7 from Rhonda Kuiper  ---
Created attachment 140958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140958=edit
a mockup of the change to the add to basket

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31606] Enhance acquisitions to allow ordering on next year's budget when still in current year.

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31606

--- Comment #6 from Rhonda Kuiper  ---
I can't think of a way to get the fund id in the grid coming from the vendor.
I have been brain storming with Nick at KohaCon about this and an idea he had
was
- For the cases where we are add to a basket from 'a new file' or 'a staged
file' that there would be a dropdown next to 'a new file' or 'a staged file' to
allow selecting the budget the basket is for.
- When receiving, always use the current year's budget because that will be the
year that it will be paid for. The budgets have the dates and Koha could use
that information. 
I have attached a mockup for the 'add to a basket' part.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7972] GUI for Crons

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972

Kim Gnerre  changed:

   What|Removed |Added

 CC||kgne...@hotchkiss.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25901] Add option for ClaimsReturnedWarningThreshold to count only unresolved claims

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901

Kim Gnerre  changed:

   What|Removed |Added

 CC||kgne...@hotchkiss.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25901] Add option for ClaimsReturnedWarningThreshold to count only unresolved claims

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25901] Add option for ClaimsReturnedWarningThreshold to count only unresolved claims

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25733] Return claims attention can't be cleared

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25733

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30411] Add separate shelving location column to Holds Queue

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30411

Juliet Heltibridle  changed:

   What|Removed |Added

 CC||jheltibri...@rcplib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31419] Add accesskeys to recall modal

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #139562|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 140957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140957=edit
Bug 31419: Add accesskeys for modals

This patch simply adds accesskey elements to the buttons, and changes an icon
to be
consistent with bug 26626

For tips on how to access the accesskeys:
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey

To test:
1 - Generate a recall
2 - Fill it/check in
3 - Note modal now has hints "Confirm (Y)"
4 - Test with Y,P,I keys (may need to recreate recalls)
5 - Confirm the recall and test waiting recall modal too

Signed-off-by: Katrin Fischer 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31419] Add accesskeys to recall modal

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Needs Signoff   |Signed Off

--- Comment #9 from Victor Grousset/tuxayo  ---
Changing to Signed-off then. Thanks Marie-Luce :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31579] Improve reserve/request.pl to avoid mistakes with pick up locations

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31579

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28841] Canceling holds from 'Holds awaiting pickup' should follow return policies regarding transfers

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28841

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #140901|0   |1
is obsolete||

--- Comment #8 from ByWater Sandboxes  ---
Created attachment 140956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140956=edit
Bug 25503: Add option to export items bundle contents in checkouts table

Test plan:
1. Enable system preference ExportCircHistory
2. Create an item bundle (see bug 28854 comment 458)
3. Check out the item bundle
4. In the checkouts table, check the box in column "Export",
   choose export format 'MARC with items', check "Export items bundle
   contents" and click on "Export" button
   The exported file should contain the biblio and item created at step
   2, but also the biblio and items that are part of the bundle

Signed-off-by: Marie-Luce 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29606] Include items from host record in XML for XSLT processing

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #3 from Kyle M Hall  ---
Can you add a unit test for the change to buildKohaItemsNamespace?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375

Nick Clemens  changed:

   What|Removed |Added

 Attachment #127582|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 140955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140955=edit
Bug 28375: Inefficiencies in fetching COinS

This patchset adds an 'interface' parameter to XSLTParseForDisplay to avoid
fetching
coins when not needed

Additionally we move some logic from the scripts to searchResults to avoid an
extra fetch fo the biblio object

To test:
1 - Enable  COinSinOPACResults syspref
2 - Also enable  OPACShowOpenURL  and  OPACOpenURLItemTypes  - adding an
itemtype that you can find
3 - Perform a search on the OPAC and confirm coins are included and openurl
shown
4 - Perform a search on staff client and confirm openurls do not show
5 - Apply patch
6 - Results should be the same

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503

--- Comment #7 from Marie-Luce Laflamme  ---
It's work with these steps
Test plan:
1. Apply bug 25503
2. Enable system preference ExportCircHistory
2. Create an item bundle (see bug 28854 comment 458)
3. Check out the item bundle
4. In the checkouts table, check the box in column "Export",
   Below the checkout lists, choose export format 'MARC with items', check
"Export items bundle contents" and click on "Export" button
The exported file should contain the biblio and item created at step
2, but also the biblio and items that are part of the bundle.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28375] Inefficiencies in fetching COinS

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28375

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

--- Comment #22 from Nick Clemens  ---
This will at least apply now - with the exception of Owen's last patch - I
think it needs some cleanup though - could you take a look Owen?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

--- Comment #21 from Nick Clemens  ---
Created attachment 140954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140954=edit
Bug 30579: (follow-up) Update layout to make hold any vs. hold item clearer

This patch alters the structure of the hold for a little more in order
to make it clear that "Hold next available" and "Hold specific item" are
two mutually-exclusive options.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Perform the same tests as before:

- Confirm you can successfully place single or multiple items on hold
- Confirm that when placing a single hold the next available options
  are grouped
- Confirm pickup location, specific item type, and number of holds all
  work for next available
- Confirm item level holds save pickup location correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

--- Comment #20 from Nick Clemens  ---
Created attachment 140953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140953=edit
Bug 30579: Group next available hold options, and disable when item is chosen

This patch rearranges options that only apply to next available holds
and disables them when an item is checked. This is intended to make it
more obvious which parts of the form apply to this selection

To test:
1 - Apply patches
2 - Confirm you can successfully place single or multiple items on hold
3 - Confirm that when placing a single hold the next available options are
grouped
4 - Confirm pickup location, specific item type, and number of holds all work
for next available
5 - Confirm item level holds save pickup location correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

--- Comment #19 from Nick Clemens  ---
Created attachment 140952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140952=edit
Bug 30579: Whitespace

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Nick Clemens  changed:

   What|Removed |Added

 Attachment #134491|0   |1
is obsolete||
 Attachment #134492|0   |1
is obsolete||
 Attachment #134893|0   |1
is obsolete||

--- Comment #18 from Nick Clemens  ---
Created attachment 140951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140951=edit
Bug 30579: Disentangle multi-hold and single bib forms

This patch simply groups the forms so that multi-hold and single
hold are each in their own section

While there is some duplication from this, it makes the sections easier to read
and allows for more variation in the two forms

To test:
1 - Place a single bib and multi bib hold in staff client
2 - Apply this patch
3 - Repeat and confirm nothing changes with this patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31185] Link authorities automatically doesn't detect duplicate authorities

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31185

--- Comment #8 from Martin Renvoize  ---
I'd love to see this one move forward.. but I'm not sure I can pick up adding
the tests myself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #131 from Martin Renvoize  ---
(In reply to Owen Leonard from comment #106)
> This seems to be working well but I've found one bug:
> 
> The "Hide resolved" control doesn't work -- I get a JavaScript error in the
> console.

This was a rebase issue.. now fixed inline in the refreshed patches

> Some cosmetic issues that I'd like to see resolved:
> 
> - The page title updated to match the breadcrumbs
> - The tools sidebar should be included on the page
> - The tools sidebar should be updated to include the link to Concerns

Fixed in line in `(QA follow-up) This is a 'tool'`

>Also, this file is updated:
>
>koha-tmpl/intranet-tmpl/prog/en/includes/cat-menu.inc
>
>Is it used anywhere?

It was, but got removed again in the above mentioned patch.. I've reset it in
the original patch again now.. it will be done in the cataloging home page
stuff instead.

> One more: The new system preferences should link to each other instead of 
> showing the preference in plain text, e.g. `OpacCatalogConcerns`. It should 
> be a link. See UsageStatsLibraryName for example.

Done, see final patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

--- Comment #130 from Martin Renvoize  ---
Created attachment 140950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140950=edit
Bug 31028: Crosslink preferences

This patch adds crosslinks to the CatalogConcerns and
OpacCatalogConcerns system preferences.

We also slightly update the wording of OpacCatalogConcerns to clarify
intent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140793|0   |1
is obsolete||

--- Comment #129 from Martin Renvoize  ---
Created attachment 140949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140949=edit
Bug 31028: Add concerns tab to biblio details display

This patch adds a 'Concerns' tab to the catalogue/detail display

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140783|0   |1
is obsolete||

--- Comment #128 from Martin Renvoize  ---
Created attachment 140948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140948=edit
Bug 31028: Use additional_contents for help block

This patch updates the modal to use the additional_contents system for
the modals help block

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140782|0   |1
is obsolete||

--- Comment #127 from Martin Renvoize  ---
Created attachment 140947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140947=edit
Bug 31028: (QA follow-up) Table configuration

This patch properly adds the table configuration options to the catalog
concerns table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140781|0   |1
is obsolete||

--- Comment #126 from Martin Renvoize  ---
Created attachment 140946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140946=edit
Bug 31028: (QA follow-up) This is a 'tool'

At the moment, this feature is accessible under tools rather
than cataloging. Whilst we await the new cataloging homepage
and sidebar this patch replaces the breadcrumb and title with
'Tools', replaces the 'cat-menu' include with 'tools-menu'
and adds the 'Catalog concerns' tool to the tools-menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140780|0   |1
is obsolete||

--- Comment #125 from Martin Renvoize  ---
Created attachment 140945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140945=edit
Bug 31028: Add trigger and notice to resolve

This patch adds a sample notice and sets up the trigger to notify the
concern reporter when a concern is marked as resolved.  The notification
itself is optional at resolve time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140779|0   |1
is obsolete||

--- Comment #124 from Martin Renvoize  ---
Created attachment 140944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140944=edit
Bug 31028: Add notice trigger for catalog concerns

This patch adds a new system prefernce, `CatalogerEmails`. If set with a
valid email address adding a new catalog concern should produce a
notification email sent to that address.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140778|0   |1
is obsolete||

--- Comment #123 from Martin Renvoize  ---
Created attachment 140943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140943=edit
Bug 31028: Add 'Add catalog concern' to cataloguing toolbar

This patch moves the add concern modal js and template markup into their
own files and then references them to add the 'Add concern' option to
the cataloguing toolbar.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140777|0   |1
is obsolete||

--- Comment #122 from Martin Renvoize  ---
Created attachment 140942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140942=edit
Bug 31028: Add resolve action

This patch adds a resolution workflow to the catalog concerns management
page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140776|0   |1
is obsolete||

--- Comment #121 from Martin Renvoize  ---
Created attachment 140941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140941=edit
Bug 31028: Add resolution endpoint

This patch adds a /resolve endpoint to the catalog concerns endpoints.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140775|0   |1
is obsolete||

--- Comment #120 from Martin Renvoize  ---
Created attachment 140940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140940=edit
Bug 31028: Add filters to concerns management

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29744] Harmonize psgi/plack detection methods

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29744

--- Comment #25 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #24)
> Created attachment 140922 [details] [review]
> Bug 29744: (QA follow-up) Only consider PLACK_ENV for underscore
> 
> When run under certain circumstances (in jenkins, for example) some ENV
> variables are set for convenience, like PLACK_WORKERS and
> PLACK_MAX_REQUESTS and is causing some tests to fail (notably, shib
> ones).
> 
> This patch makes the regex only consider PLACK_ENV when testing for the
> underscore case.
> 
> Tests are updated accordingly, and they are also rewritten to test for
> boolean values instead of empty string, or zero or one, etc. The
> implementation shouldn't matter as long as the boolean evaluation is
> correct and it is clearer for devs what to expect.
> 
> Signed-off-by: Tomas Cohen Arazi 

Thx for following up. I will still have a look next week. This might break
something else again? ;)
As done in one of those tests, we may just need to localize $ENV in Shibboleth
tests?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140774|0   |1
is obsolete||

--- Comment #119 from Martin Renvoize  ---
Created attachment 140939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140939=edit
Bug 31028: Add 'special:undefined' to handle passing 'null'

We can't pass 'null' to the column.search as it gets stringified.

This patch adds a special string 'special:undefined' to denote that we
want to search on undef for the field in question.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140773|0   |1
is obsolete||

--- Comment #118 from Martin Renvoize  ---
Created attachment 140938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140938=edit
Bug 31028: Add a catalog concerns management page

This patch adds a new cataloguing concerns page to the staff client for
managing reported catalog concerns.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140772|0   |1
is obsolete||

--- Comment #117 from Martin Renvoize  ---
Created attachment 140937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140937=edit
Bug 31028: Tie OPAC display to logged in state

This is an alternative to th previous patch.. we can't easily redirect
back to the right location after login from our modal.

It would be preferable to display the button and prompt a login if we
don't have a valid session.. but that's not trivial using the API's and
our login flows at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140771|0   |1
is obsolete||

--- Comment #116 from Martin Renvoize  ---
Created attachment 140936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140936=edit
Bug 31028: Trigger login modal when not logged in

This isn't perfect, we detect if there is a logged in user on the OPAC
and replace the concern report modal with the login modal if we don't
find a valid session.

Unfortunelty, we can't then trigger a redirect back to the record
details as that's not how our get_template_and_user authentication
system works.. instead we end up back at opac-user.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140770|0   |1
is obsolete||

--- Comment #115 from Martin Renvoize  ---
Created attachment 140935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140935=edit
Bug 31028: Add 'Report a concern' to OPAC details

This patch adds a new 'Report a concern' option to the right sidebar on
the opac detail page.

On clicking the link, a modal will display allowing the user to enter a
short message regarding their concerns and then submission will record
said message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140769|0   |1
is obsolete||

--- Comment #114 from Martin Renvoize  ---
Created attachment 140934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140934=edit
Bug 31028: Add Public API endpoint

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140768|0   |1
is obsolete||

--- Comment #113 from Martin Renvoize  ---
Created attachment 140933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140933=edit
Bug 31028: Add relations to Catalog::Concern

This patch adds the reporter, resolver and biblio relations to the
Catalog::Concern class and exposes them to the API as appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140767|0   |1
is obsolete||

--- Comment #112 from Martin Renvoize  ---
Created attachment 140932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140932=edit
Bug 31028: Add catalog concerns endpoints

This patch adds the staff accessible REST API endpoints for catalog
concerns.

New endpoints available:
* POST /catalog/concerns
* GET /catalog/concerns
* GET /catalog/concerns/{concern_id}
* PUT /catalog/concerns/{concern_id}
* DELETE /catalog/concenrs/{concern_id}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140766|0   |1
is obsolete||

--- Comment #111 from Martin Renvoize  ---
Created attachment 140931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140931=edit
Bug 31028: Add `CatalogConcerns` and `OpacCatalogConcerns` preferences

This patch adds the `CatalogConcerns` and `OpacCatalogeConcerns` system
preferences to enable/disable the catalog concerns feature on the OPAC
and Staff client interfaces.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140765|0   |1
is obsolete||

--- Comment #110 from Martin Renvoize  ---
Created attachment 140930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140930=edit
Bug 31028: DBIC Schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31028] Add 'Report a concern' feature for patrons to report concerns about catalog records

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31028

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #140764|0   |1
is obsolete||

--- Comment #109 from Martin Renvoize  ---
Created attachment 140929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140929=edit
Bug 31028: Add catalog_concerns table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

--- Comment #55 from David Gustafsson  ---
Fixed the issues, but will test some more next week before ready for signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

--- Comment #54 from David Gustafsson  ---
Created attachment 140928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140928=edit
Bug 29440: replace usage of removed GetMarcBiblio

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

David Gustafsson  changed:

   What|Removed |Added

 Attachment #140906|0   |1
is obsolete||

--- Comment #53 from David Gustafsson  ---
Created attachment 140927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140927=edit
Bug 29440: defer biblio autolinking until records are indexed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

David Gustafsson  changed:

   What|Removed |Added

 Attachment #140905|0   |1
is obsolete||

--- Comment #52 from David Gustafsson  ---
Created attachment 140926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140926=edit
Bug 29440: Fix QA-tool issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

David Gustafsson  changed:

   What|Removed |Added

 Attachment #140904|0   |1
is obsolete||

--- Comment #51 from David Gustafsson  ---
Created attachment 140925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140925=edit
Bug 29440: Make authorities import behavior consistent with biblios

The current behavior for when importing authorities, when match
option is enabled, is to insert as a new authority fetching from db
fails. This is both a bit confusing and not consistent with the biblio
case where an error is generated. Also clean up error and log messages
so both messages/errors and when messages/errors are issued are more
consistent for the biblio and authority case.

Signed-off-by: Frank Hansen 

The patch works fine for me.
Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

David Gustafsson  changed:

   What|Removed |Added

 Attachment #140903|0   |1
is obsolete||

--- Comment #50 from David Gustafsson  ---
Created attachment 140924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140924=edit
Bug 29440: Refactor and clean up bulkmarcimport.pl

To test:
1) Import biblios using ./bulkmarcimport.pl -v -b -file biblios.mrc -insert
-update -c=MARC21 -match "control-number,001" -n=1 -l "/tmp/import.log"
2) Verify in /tmp/import.log that one biblio has been inserted
3) Import again without the "-n" option, verify that one biblio has been
   updated and the rest inserted
4) In the staff interface search the catalog for some string appearing in
   the imported biblios to verify records have been indexed
5) View/edit some of the biblios the staff interface to very have been
   properly imported
6) Import authorities using ./bulkmarcimport.pl -v -m=MARCXML -a -file
authorities.xml -insert -update -c=MARC21 -keepids="024a" -match
"heading-main,100a" -l "/tmp/import.log" -yaml="/tmp/ids.yml"
7) Go to the authorities page and find the imported authority by for example
search for a
   400 or 100 field value. Verify that the 001 field of the incoming record has
been moved to 024a.
   Also check that the value of 024a appear as a key in /tmp/ids.yml.
8) Edit the authorities.xml file and change the value of field 400a
9) Import authorities again using the same options
10) Verify that the 400a field of the authority in Koha has not been
   updated (the import was skippped since revision did not change)
11) Edit authorities.xml, replace the value of field 005 in the file with field
005
of the authority in Koha incremented by one
12) Import again with the same options
13) Verify that the 400a field of the authority in Koha now have been
updated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31566] 'Patrons selected' counter doubles on 'Select all'

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566

--- Comment #1 from Owen Leonard  ---
Created attachment 140923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140923=edit
Bug 31566: 'Patrons selected' counter doubles on 'Select all'

This patch refines the JavaScript which is run when the "Select all"
or "Clear all" controls are clicked. The script now checks to see
whether the checkbox is checked before triggering the change function.

To test, apply the patch and perform a patron search in the staff
interface which will return multiple results.

- After the patron search results are displayed, test the "Select
  all" control. The visible search results should all be checked,
  and the "Patrons selected" counter at the top should be
  incremented correctly.
- Clicking the "Select all" control again should have no effect.
  The "Patrons selected" counter should not increment again.
- Test the "Clear all" control to confirm that checkboxes are
  unchecked and the counter updates correctly.
- Test with multiple pages of patron search results to confirm
  that the controls work correctly on any page of results..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31566] 'Patrons selected' counter doubles on 'Select all'

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31617] Allow manual editing of suggestions.biblionumber

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31617

Amanda Campbell  changed:

   What|Removed |Added

 CC||acampb...@hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503

Marie-Luce Laflamme  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

David Gustafsson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #49 from David Gustafsson  ---
Discovered some issues after rebase so setting to failed until these are fixed
(will probably have to wait until Monday).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31566] 'Patrons selected' counter doubles on 'Select all'

2022-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31566

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >