[Koha-bugs] [Bug 30260] Script which checks index should also check if the zebraqueue has uncommitted records

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30260

--- Comment #6 from Aleisha Amohia  ---
How should I get that patch into the global repo?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31391] Staff-side recalls

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391

Aleisha Amohia  changed:

   What|Removed |Added

   Priority|P5 - low|P3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #66 from Katrin Fischer  ---
I am afraid I am not the right QA person for this one, but also it does no
longer apply :(

error: sha1 information is lacking or useless (Koha/Patron.pm).
error: could not build fake ancestor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library or library group

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
   Keywords|rel_22_05_candidate |rel_22_11_candidate

--- Comment #381 from Katrin Fischer  ---
Hi Kyle, could you please rebase? I was hoping someone else would look into the
case we disagreed about, but now ready to try and tackle this again.

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20256: Update database
Applying: Bug 20256: Add new permission to editor
Applying: Bug 20256: Refactor subs for rights to view patrons to make them
generic for general use
Applying: Bug 20256: Add new methods for checking item editing permissions
Applying: Bug 20256: Update groups editor
Applying: Bug 20256: Use new methods
Using index info to reconstruct a base tree...
M   Koha/Item.pm
M   Koha/UI/Table/Builder/Items.pm
M   catalogue/detail.pl
M   catalogue/moredetail.pl
M   cataloguing/additem.pl
M   koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
M   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
M   tools/batchMod.pl
Falling back to patching base and 3-way merge...
Auto-merging tools/batchMod.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
Auto-merging cataloguing/additem.pl
Auto-merging catalogue/moredetail.pl
CONFLICT (content): Merge conflict in catalogue/moredetail.pl
Auto-merging catalogue/detail.pl
CONFLICT (content): Merge conflict in catalogue/detail.pl
Auto-merging Koha/UI/Table/Builder/Items.pm
CONFLICT (content): Merge conflict in Koha/UI/Table/Builder/Items.pm
Auto-merging Koha/Item.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 20256: Use new methods

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #10 from Katrin Fischer  ---
Hi, thx for the patch!

Some things:

1) The database update is not idempotent, meaning that you cannot run it a
second time without it causing an error:

DEV atomic update
/kohadevbox/koha/installer/data/mysql/atomicupdate/bz27136-Add_languages_for_facet.pl
 [22:55:29]: Bug 27136 - Add missing language information for facets
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate entry
'cr-language' for key 'uniq_lang' at /kohadevbox/koha/C4/Installer.pm line 739

As we had some issues with that in recent update (bug 30951), I think it would
be better to implement some kind of check.

2) Next time it would be better to have these in 2 separate bugs:
* Add languages
* Avoid displaying nothing in facets

Both are distinct issues and in separate patches it gives better advertising in
release notes and better chances one or the other might get backported. A
strategy of small granular steps usually also works to make your patches move
faster.

Maybe a suggestion: We could make this one about adding the languages only as
the patches are nice and separate. I tihnk I agree with Nick about not
displayin the empty ones, as they can't be searched for - but this discussion
could be continued on bug 29561. OK?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #137785|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #65 from Katrin Fischer  ---
Sorry to repeat history here :( Too late again.

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 17170: DB Updates
Applying: Bug 17170: DO NOT PUSH - Schema Updates
Applying: Bug 17170: Update schema for boolean
Applying: Bug 17170: Add API route for SearchFilters
Applying: Bug 17170: Add search filters to staff and opac interfaces
Applying: Bug 17170: Handle search filters in query builders
Applying: Bug 17170: Add admin page for filters and ability to edit/save
existing filters
Applying: Bug 17170: Unit tests
Applying: Bug 17170: (follow-up) Display search filters admin links when
apprropriate
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc).
error: could not build fake ancestor
Patch failed at 0001 Bug 17170: (follow-up) Display search filters admin links
when apprropriate
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-17170-follow-up-Display-search-filters-admin-l-O7ZVwo.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30310] Replace Moment.js with Day.js

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30310

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #18 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #17)
> After applying my console has an error:
> Uncaught TypeError: t is undefined ... dayjs.min_22.0600035.js:1:6455

I tested on Tools > Calendar. In Firefox I have the same error. In Chromium I
see:

dayjs.min_22.0600054.js:1 Uncaught TypeError: Cannot read properties of
undefined (reading '$i')

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30556] OPAC shows "Place hold" button on available items even if on shelf holds aren't allowed

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30556

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #29 from Katrin Fischer  ---
In your code I see:

+my $currentbranch = C4::Context->userenv ? C4::Context->userenv->{branch} :
undef;
+$is_available = IsAvailableForItemLevelRequest($item, $patron,
$currentbranch)
+  unless $is_available;

But when I look at the POD for IsAvailableForItemLevelRequest the third
parameter is supposed to be the pick-up location, not the logged-in user's
branch:

https://git.koha-community.org/Koha-community/Koha/src/commit/9408a443c24a5424828f62b48fa1dda04fdf3512/C4/Reserves.pm#L1323

my $is_available = IsAvailableForItemLevelRequest( $item_record,
$borrower_record, $pickup_branchcode );

I believe this isn't correct. A system might allow you to place a hold for
pickup at the item's home library, which might not be the patron's home
library.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24860] Add ability to place item group level holds

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #135 from Katrin Fischer  ---
Created attachment 141215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141215=edit
Bug 24860: (QA follow-up) Terminology and translation fixes

* Fixes a single to a double underscore for translation in holds.js
* Fixes item_group to item group in API description
* Fixes volume hold to item group hold in syspref db descrpitions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24860] Add ability to place item group level holds

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #134 from Katrin Fischer  ---
Created attachment 141214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141214=edit
Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24860] Add ability to place item group level holds

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #133 from Katrin Fischer  ---
1) Unit tests

> I've not seeing what module is missing tests. I've added tests for
> AddReserve already! Is there one I missed? 

Doing some code review and... there are some more *hides*

Maybe discuss with Martin which ones should be included in tests:

* C4/HoldsQueue.pm 
  * GetHoldsQueueItems 
  * GetPendingHoldRequestsForBib
  * MapItemsToHoldRequests 

C4/Reserves.pm
  * AddReserve (covered)
  * CheckReserves
  * _Findgroupreserve

Koha/Hold.pm
  * item_group
  * forced_hold_level

Koha/REST/V1/Holds.pm
  * add

2) Fixes some smaller stuff in 2 follow-ups, please have a look!

3) Holds to pull is off

First my test case: 
* Added 9 items to a record, 3 each for vol. 1-3 in enumchron 
* Grouped them into 3 item groups
* In the OPAC, I placed a hold onto the volume 2 group

In /circ/pendingreserves.pl it shows wrong information:
* 305776 or any available.
* Available enumchron: vol. 1, vol. 2, vol. 3
* There is no information that only volume 2 is wanted.

4) Holds queue 

Explodes:
C4::HoldsQueue::GetHoldsQueueItems(): DBI Exception: DBD::mysql::st execute
failed: Unknown column 'item_group_items.item_group_id' in 'on clause' at
/kohadevbox/koha/circ/view_holdsqueue.pl line 51
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

I've run a dbic and a restart_all, but the problem remains. The column exists
in my database:

describe item_group_items;
+-+-+--+-+-++
| Field   | Type| Null | Key | Default | Extra  |
+-+-+--+-+-++
| item_group_items_id | int(11) | NO   | PRI | NULL| auto_increment |
| item_group_id   | int(11) | NO   | MUL | 0   ||
| item_id | int(11) | NO   | UNI | 0   ||
+-+-+--+-+-++

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24860] Add ability to place item group level holds

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

--- Comment #10 from Katrin Fischer  ---
Created attachment 141213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141213=edit
Bug 30407: (QA follow-up) Replace message with description

Switches "not for loan message" to "not for loan description" to
stay closer to the usual terminology for AV values also used
when managing them.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

--- Comment #9 from Katrin Fischer  ---
Created attachment 141212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141212=edit
Bug 30407: (QA follow-up) Fix missing TT filter

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #138171|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 141211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141211=edit
Bug 30407: Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only
the notforloan values description

This can be used to instruct staff how the item should handled when
it's checked in. For example items notforloan status has been
changed as "Invoiced item" while item has been on loan. When it's
checked in staff sees that they should put item aside for further
processing.

To test:
1. Apply patch and update database if needed
2. Set items notforloan status as -1 (or create new one)
3. Add line "-1: ONLYMESSAGE" to UpdateNotForLoanStatusOnCheckin
4. Check item out for patron.
5. Check item in.
=> Description of notforloan status should be displayed.
=> Confirm notforloan status hasn't changed.

Also prove t/db_dependent/Circulation/issue.t

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Sally 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19318] Add ability to use custom file upload paths

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #36 from Katrin Fischer  ---
I have decided to move this to 'In discussion' for now. My reasoning:

The patch set does appear to do much more than is written on the 'tin': It
claims to allow for custom upload paths, but it does a lot more than that.
There are unresolved questions about some of the design decisions and how we
can deal with the consequences:

* While Kyle had originally proposed using an AV in the initial description,
this patch set moves everything away from the GUI into the koha-conf.xml. In
doing so, it removes the UPLOAD AV. 
If this is proven to be the right path, it would require more work to remove
the AV category properly and ensure a clean upgrade path (see comment#34,
comment#29).
But we also should discuss if this is a required step as it takes away control
from libraries that often don't have easy access to server side configuration. 
Personally this feels contrary to what I see in other work (like making a GUI
for SMTP servers).

* Adds other extra features, like: 
> hash_filename: Whether to prepend hashvalue to the filename or not.
I wonder if some of these features would be better suited as follow-ups to keep
the initial bug smaller. (comment#35)

My feeling is that these conceptual questions cannot be resolved in QA, but
need to be resolved before it reaches the QA step with a clear test
plan/upgrade path/reasoning of changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #96 from Katrin Fischer  ---
I tried testing this, but have run into 2 dead ends:

* Manually added a HOLD_CANCELLATION notice
* Added email address to my patron, created a bunch of holds
* Verified the AV exists and has values
* Verified my patron has a primary email set

1) From the patron account
* Switch No to Yes for cancelling a hold
* Choose reason, leave notify patron checked
* Cancelled hold
* Hold was cancelled, but: No notice was created

2) Record detail page, holds tab:
* Click on "garbage can" - modal comes up without cancellation reason pull down
or notify option

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

--- Comment #95 from Katrin Fischer  ---
Created attachment 141210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141210=edit
Bug 26282: (QA follow-up) Fix typo recieve

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29824] Allow for quick spine labels to be editable for printing

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29824

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|Needs documenting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30184] Create statistical items that are returned immediately

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30184

--- Comment #3 from Katrin Fischer  ---
Can be solved using a plugin and the checkout hook if someone runs into this as
a requirement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25657] Remove username from default value form in patron import

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657

Katrin Fischer  changed:

   What|Removed |Added

Version|19.11   |master
Summary|Import Patron fails without |Remove username from
   |userid - not stated as  |default value form in
   |required field in notes |patron import

--- Comment #13 from Katrin Fischer  ---
Hi Elaine, thx for not giving up investigating here. I agree that
userid/username does not really make sense on this form. I have changed the bug
description accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13545] Add barcode image generator service

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

--- Comment #19 from Katrin Fischer  ---
CLOSED FIXED > Needs Documenting doesn't work, but:
RESOLVED FIXED > Needs Documenting does :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894
Bug 20894 depends on bug 13545, which changed state.

Bug 13545 Summary: Add barcode image generator service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be printed without text

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676
Bug 20676 depends on bug 13545, which changed state.

Bug 13545 Summary: Add barcode image generator service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27013] Display an image of barcode on slips

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27013
Bug 27013 depends on bug 13545, which changed state.

Bug 13545 Summary: Add barcode image generator service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

   What|Removed |Added

 Status|RESOLVED|Needs documenting
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13545] Add barcode image generator service

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|Needs documenting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894
Bug 20894 depends on bug 13545, which changed state.

Bug 13545 Summary: Add barcode image generator service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be printed without text

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676
Bug 20676 depends on bug 13545, which changed state.

Bug 13545 Summary: Add barcode image generator service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27013] Display an image of barcode on slips

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27013
Bug 27013 depends on bug 13545, which changed state.

Bug 13545 Summary: Add barcode image generator service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13545] Add barcode image generator service

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Needs Signoff   |RESOLVED

--- Comment #18 from Katrin Fischer  ---
I was trying to set this to 'needs documenting' but I can't reach the status it
seems :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13545] Add barcode image generator service

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

Katrin Fischer  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20894] Add barcode size parameters to /svc/barcode

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20894
Bug 20894 depends on bug 13545, which changed state.

Bug 13545 Summary: Add barcode image generator service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20676] svc/barcode should allow barcode to be printed without text

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676
Bug 20676 depends on bug 13545, which changed state.

Bug 13545 Summary: Add barcode image generator service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27013] Display an image of barcode on slips

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27013
Bug 27013 depends on bug 13545, which changed state.

Bug 13545 Summary: Add barcode image generator service
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13545] Add barcode image generator service

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545

Katrin Fischer  changed:

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14783] Allow patrons to change pickup location for non-waiting holds

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783

--- Comment #32 from Katrin Fischer  ---
Hi Björn, will you have time to work on the fixes Nick asked for? 
I'd really like to see this one in :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|tomasco...@gmail.com|katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30966] Record overlay rules - can't use Z39.50 filter

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #9 from Katrin Fischer  ---

It looks like the * (all) case might not be covered properly yet:

My overlay rules:
* source * 245 Protect Skip...
* source Z39.50 100 Protect Skip...

* Download and save from LOC control number 9162774.
  Verify it has 245 and 100 set
* Edit record
* Replace record via Z39.50 search
  * 245: was updated
  * 100: remained unchanged
* Save record
  * 245: was updated
  * 100: was protected

Hopefully an easy fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30966] Record overlay rules - can't use Z39.50 filter

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966

Katrin Fischer  changed:

   What|Removed |Added

Summary|Record Overlay Rules -  |Record overlay rules -
   |can't use Z39.50 filter |can't use Z39.50 filter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30966] Record Overlay Rules - can't use Z39.50 filter

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30966

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31660] MARC preview for authority search results comes up empty

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31660

Katrin Fischer  changed:

   What|Removed |Added

Summary|MARC preview for authority  |MARC preview for authority
   |search results has hidden   |search results comes up
   |contents|empty

--- Comment #5 from Katrin Fischer  ---
Nice catch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31660] MARC preview for authority search results has hidden contents

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31660

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #141127|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 141209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141209=edit
Bug 31660: MARC preview for authority search results has hidden contents

This patch makes the contents of the MARC preview for authority search
results visible.

To test:
1)  Go to the Authorities page in the staff interface
2)  Click Submit to do a search
3)  Click on Actions to the right of an authority
4)  Select MARC preview
5)  Observe that the modal appears empty
6)  Apply patch
7)  Hold down the shift key when you reload the page, clear the cache,
or use another web browser
8)  Do another authority search and look at a MARC preview
9)  Observe that the MARC preview contains the MARC record

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31660] MARC preview for authority search results has hidden contents

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31660

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31660] MARC preview for authority search results has hidden contents

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31660

Katrin Fischer  changed:

   What|Removed |Added

Version|22.05   |master
 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30944] Fix single cancel recall button in recalls tab in staff interface and correctly handle cancellations with branch transfers

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944

Katrin Fischer  changed:

   What|Removed |Added

Summary|Recalls - action buttons to |Fix single cancel recall
   |cancel recall on various|button in recalls tab in
   |pages do not work   |staff interface and
   ||correctly handle
   ||cancellations with branch
   ||transfers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944

--- Comment #10 from Katrin Fischer  ---
Created attachment 141208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141208=edit
Bug 30944: Undo change to ILS-DI documentation

The service not implemented by Koha is CancelRecall
as specified in:
https://old.diglib.org/architectures/ilsdi/DLF_ILS_Discovery_1.0.pdf

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #140411|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 141207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141207=edit
Bug 30944: Fix cancel recalls actions

This patch fixes the 'cancel selected recalls' button on the biblio
details Recalls page, and ensures a correct cancellation reason is
logged when cancelling a recall in transit.

To test:
1) Ensure UseRecalls is enabled and relevant recalls circulation rules
are set
2) Check out Item A to Patron B
3) Log into OPAC as Patron A
4) Search for Item A and place a recall
5) Go back to the staff interface and search for Item A. When viewing
the biblio record, go to the recalls tab.
6) Check the checkbox for your recall, and click the button to cancel
selected recalls.
7) Confirm your recall is successfully removed and you're redirected to
the correct recalls page for this biblio.
8) Go back to the OPAC and place a recall again. This time set the
pickup location to a different library, one that you're not logged in at
9) Back in the staff interface, check in Item A and confirm the recall
and transfer
10) Go to Circulation -> Recalls to pull. Your recall should show here.
Click the button to cancel the recall and revert the transfer
11) Confirm the recall has been cancelled
12) Go to Reports and create a new SQL report with the following SQL:
select * from branchtransfers b join items i on
b.itemnumber=i.itemnumber where i.barcode = <>
13) Run the report and paste the barcode of Item A in the field
14) Confirm there are two rows returned - the transfer triggered when
the recall was confirmed, with a reason of 'Recall' and a cancellation
reason of 'RecallCancellation, and the transfer sending the item back
home when the recall was cancelled, with a reason of
'RecallCancellation'.

Sponsored-by: Catalyst IT

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944

--- Comment #8 from Katrin Fischer  ---
Ok, took a while to work through this, but now I think I got it:

* Bug 30924 added RecallCancellation to the branchtransfers.reason, but now we
are also adding it to cancellation_reason. Makes sense.

* The changes to the ilsdi files are not correct. The listings refer to the
service defined in the ILS-DI documentation. It is called CancelRecall and
should remain like that. See:
https://old.diglib.org/architectures/ilsdi/DLF_ILS_Discovery_1.0.pdf. I am
providing a follow-up for this.

* I've run through the test plan without the change and didn't manage to create
an entry to branchtransfers with CancelRecall so no more clean-up should be
needed (it looked like the entries were not created properly at all)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30944] Recalls - action buttons to cancel recall on various pages do not work

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30944

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28854] Add ability to create bundles of items for circulation

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854

--- Comment #508 from Katrin Fischer  ---
I notice a lot of nice additions to this are hiding in the 'Blocks' list here!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

--- Comment #11 from Katrin Fischer  ---
This works nicely. Maybe the UI could improved a little bit to separate the
options visually a little better, but not a blocker here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #140956|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 141206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141206=edit
Bug 25503: Add option to export items bundle contents in checkouts table

Test plan:
1. Enable system preference ExportCircHistory
2. Create an item bundle (see bug 28854 comment 458)
3. Check out the item bundle
4. In the checkouts table, check the box in column "Export",
   choose export format 'MARC with items', check "Export items bundle
   contents" and click on "Export" button
   The exported file should contain the biblio and item created at step
   2, but also the biblio and items that are part of the bundle

Signed-off-by: Marie-Luce 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25503] Add option to export items bundle contents in checkouts table

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31663] Item not showing transit status on detail page in staff interface

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31663

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |
Summary|Item not showing transit|Item not showing transit
   |status on   |status on detail page in
   |catalogue/detail.pl |staff interface

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31663] Item not showing transit status on catalogue/detail.pl

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31663

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #141132|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 141205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141205=edit
Bug 31663: Item transfers are not correctly displayed on item details page

To test:
1 - Set an item in transit and confirm the transfer
2 - View details page for biblio
3 - Item shows 'Available'
4 - Apply patch
5 - Restart_all, reload page
6 - Item appears in transit

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31663] Item not showing transit status on catalogue/detail.pl

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31663

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31593] Remove Test::DBIx::Class from Context.t

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31593

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #140818|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 141204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141204=edit
Bug 31593: Remove Test::DBIx::Class from Context.t

No need to keep it.
Fixing a test description too.

Test plan:
Run t/db_dependent/Context.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31593] Remove Test::DBIx::Class from Context.t

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31593

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31594] Report results count of shown can be incorrect on last page

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31594

--- Comment #4 from Katrin Fischer  ---
Small logical fix, nice enhancement - love :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31594] Report results count of shown can be incorrect on last page

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31594

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #140827|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 141203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141203=edit
Bug 31594: Use ount of results for displaying number shown

To test:
1 - Create a report with a number of results that is not a multiple of 20
SELECT barcode FROM items
2 - Run the report
3 - Go to the final page
4 - Note report says 20 shown, but there are less
5 - Apply patch
6 - Reload and confirm correct number of shown is shown :-)

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31594] Report results count of shown can be incorrect on last page

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31594

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31594] Report results count of shown can be incorrect on last page

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31594

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

--- Comment #20 from Katrin Fischer  ---
Overall I am not super happy about the way we rely on a regex here, but have
not managed to break behavior in my tests. So this fix works and that's the
most important as this bug has been there for too long causing potential data
loss.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #140193|0   |1
is obsolete||

--- Comment #19 from Katrin Fischer  ---
Created attachment 141202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141202=edit
Bug 30517: Translation breaks editing parent type circulation rule fix

Test plan:
1. Install another language in the staff interface
   1. in commandline: `cd misc/translator/; ./translate install xx-XX`
   2. Check the box of the language in the 'language' system preference
and save
   3. Refresh and you should be able to choose languages
2. Create an item type with a parent
   1. Go to Administration > Item types
   2. Create a new item type or modify an existing one, assigning a parent type
(I created a 'Children's books' type and assigned 'Books' as its parent)
3. Create a circulation rule for the parent type (I created All/Books, with 10
checkouts allowed)
4. Create a circulation rule for All/All (I created All/All with 30 checkouts
allowed)
5. In English, click on "Edit" next to the parent type rule (All/Books)
--> Note that the item type in the bottom row (the modifiable row) is changed
to 'Books (All)'
6. Modify the number of checkouts allowed (e.g. 99)
--> The All/Books rule is modified
7. Switch the interface to the other language
8. Click on "Edit" next to the parent type rule (All/Books)
--> Note that the item type in the bottom row stays on 'All'
9. Modify the number of checkouts allowed (e.g. 88)
--> The All/All rule is modified
10. Apply the patch, translate again and refresh the page
11. Do step 8-9 again and notice it now behaves as it should

Signed-off-by: Emmanuel Bétemps 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30517] Translation breaks editing parent type circulation rule

2022-10-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30517

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/