[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30403] Update notforloan status also on check out

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30403

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #9 from Victor Grousset/tuxayo  ---
> I tested this patch once (Koha 21.05 or 21.11, I don't remember)

How did you test it on 21.05 or 21.11? The sandboxes can't work if trying to
get an older version of Koha.

Anyway, setting this to "patch does not apply" since that's the current
blocker. Don't hesitate to do this if when applying a patch in a sandbox you
get "CONFLICT (content): Merge conflict"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||31631


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631
[Bug 31631] Optionally choose for tax-exclusive values to be used for
calculating fund values (spent, ordered)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31631] Optionally choose for tax-exclusive values to be used for calculating fund values (spent, ordered)

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31631

Aleisha Amohia  changed:

   What|Removed |Added

 Depends on||31840
 CC||alei...@catalyst.net.nz


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840
[Bug 31840] Incorrect warning that order total amount exceeds allowed budget
when editing existing order
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840

Aleisha Amohia  changed:

   What|Removed |Added

  Text to go in the||This patch deducts the
  release notes||current cost of an order if
   ||modifying it, so that the
   ||current cost isn't counted
   ||when checking whether the
   ||updated cost will take the
   ||order total amount above
   ||the allowed budget.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840

--- Comment #1 from Aleisha Amohia  ---
Created attachment 141949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141949=edit
Bug 31840: Consider current cost if modifying order

This patch deducts the current cost of an order if modifying it, so that
the current cost isn't counted when checking whether the updated cost
will take the order total amount above the allowed budget.

To test:
1. Add an active budget of $1,000
2. Attach a fund of $1,000. Set the fund to warn at 98% and $900.
3. Add an order to a basket, give it a vendor price of $500 with no
discount or tax and Save
4. Modify the order and change the vendor price to $450 and Save
5. Notice you get a warning that this order total amount will exceed the
allowed budget - this is incorrect.
6. Apply the patch and cancel the change so you're redirected back to
the basket
7. Modify the order and change the vendor price to $450 and Save
8. You should be able to Save without requiring confirmation
9. Add another order to the basket, give it a vendor price of $100 with
no discount or tax and Save. This should save normally, confirming we
can add new orders that do not exceed the allowed budget
10. Add another order to the basket, give it a vendor price of $500 with
no discount or tax and Save. This should trigger the warning that you
will exceed the allowed budget, as expected.

Sponsored-by: Waikato Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction'

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Version(s)|22.11.00, 22.05.01  |22.11.00, 22.05.01,
released in||21.05.20

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction'

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #78 from Victor Grousset/tuxayo  ---
Backported: Pushed to 21.05.x branch for the upcoming release (21.05.20)

Nothing to document.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29325] commit_file.pl error 'Already in a transaction'

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29325

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #77 from Victor Grousset/tuxayo  ---
Test plan is missing something:

> 3. Apply this patch
> 4. Repeat 2
> => SUCCESS: Commit succeeds
> 5. Sign off :-D

step 1 should be repeated as well. Otherwise there is nothing to commit and no
error. And when repeating step two, change --batch-number from 1 to 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840

Aleisha Amohia  changed:

   What|Removed |Added

Version|22.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31840] Incorrect warning that order total amount exceeds allowed budget when editing existing order

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31840] New: Incorrect warning that order total amount exceeds allowed budget when editing existing order

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31840

Bug ID: 31840
   Summary: Incorrect warning that order total amount exceeds
allowed budget when editing existing order
 Change sponsored?: ---
   Product: Koha
   Version: 22.05
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

We've noticed that we're getting a warning that the order total amount exceeds
the allowed budget when we shouldn't be.

To reproduce:

1. Add an active budget of $1,000
2. Attach a fund of $900
3. In Acquisitions, add an order to a basket, give it a vendor price of $500
with no discount and Save
4. Modify the order and change the vendor price to $450. Save the order
5. Notice the warning that we'll exceed the allowed budget, even though this is
the only order using this fund and it does not exceed $900.

Koha does a weird 500+450 calculation and thinks we've now ordered more than
$900 but it is not considering that we've modified an existing order.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31473] Test about bad OpacHiddenItems conf fragile

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31473

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30779] Do not need to remove items from import biblios marc

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30779

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED
 CC||vic...@tuxayo.net

--- Comment #11 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31217] Fix Coce JavaScript to hide single-pixel cover images in the OPAC lightbox gallery

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31217

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

--- Comment #21 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31222] DBIC queries for batch mod can be very large

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31222

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED
 CC||vic...@tuxayo.net

--- Comment #18 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29782] Additional contents: Fix handling records without title or content

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29782

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 CC||vic...@tuxayo.net
 Resolution|--- |FIXED

--- Comment #16 from Victor Grousset/tuxayo  ---
Missing dependencies for 21.05.x, it shouldn't be affected, no backport.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31228] Fix Coce JavaScript to hide single-pixel cover images in both the staff client detail and results pages

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31228

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 CC||vic...@tuxayo.net
 Resolution|--- |FIXED

--- Comment #18 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19540] opac-reserve does not correctly warn of too_much reserves

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19540

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

--- Comment #17 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26632] BatchStageMarcRecords passes a random number to AddBiblioToBatch / AddAuthToBatch

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26632

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #11 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31294] Article requests: Mandatory subfields in OPAC don't show they are required

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31294

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED

--- Comment #6 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31297] Cannot add new subscription patterns from edit subscription page

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31297

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31302] Spelling: You can download the scanned materials via the following url(s):

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31302

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||vic...@tuxayo.net
 Status|Pushed to stable|RESOLVED

--- Comment #6 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28012] Error on Saving new numbering pattern

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes the serials new
  release notes||numbering pattern input
   ||form so that the name and
   ||numbering formula fields
   ||are marked as required.
   ||Before this, there was no
   ||indication that these
   ||fields were required and
   ||error trace messages were
   ||displayed if these were not
   ||completed - saving a new
   ||pattern or editing an
   ||existing pattern would also
   ||silently fail.
   ||
   ||NOTE:
   ||Making the description
   ||field optional will be
   ||fixed in bug 31297. Until
   ||this is done, a value needs
   ||to be entered into this
   ||field - even though it
   ||doesn't indicate that it is
   ||required.
 CC||da...@davidnind.com

--- Comment #19 from David Nind  ---
Testing notes (using koha-testing-docker) - I hope I got this right!

Replicate the issue:
1. Go to Serials > Manage numbering patterns.
2. Add a new numbering pattern, but leave the description field blank (copy an
existing numbering pattern such as Number) - note that no fields are marked as
required:
   ==> C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI
Exception: DBD::mysql::st execute failed: Incorrect integer value: '' for
column `koha_kohadev`.`subscription_numberpatterns`.`add2` at row 1 at
/kohadevbox/koha/serials/subscription-numberpatterns.pl line 70
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77
3. Repeat step 2 but leave the display order field blank:
   ==> C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI
Exception: DBD::mysql::st execute failed: Incorrect integer value: '' for
column `koha_kohadev`.`subscription_numberpatterns`.`displayorder` at row 1 at
/kohadevbox/koha/serials/subscription-numberpatterns.pl line 70
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77
4. Repeat step 2, leaving name or numbering formula fields blank:
   ==> adding the new numbering pattern silently fails - you are return to the
list of numbering patterns and the your new numbering pattern is not saved.
5. Fill in all the fields (name, description, numbering formula, and display
order) and save:
   ==> C4::Serials::Numberpattern::AddSubscriptionNumberpattern(): DBI
Exception: DBD::mysql::st execute failed: Incorrect integer value: '' for
column `koha_kohadev`.`subscription_numberpatterns`.`add2` at row 1 at
/kohadevbox/koha/serials/subscription-numberpatterns.pl line 70
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77
6. Edit an existing pattern with the various combinations from steps 2-5 (for
example, the existing number pattern) - no fields are marked as required, you
get these results:
   . Name: C4::Serials::Numberpattern::ModSubscriptionNumberpattern(): DBI
Exception: DBD::mysql::st execute failed: Column 'label' cannot be null at
/kohadevbox/koha/serials/subscription-numberpatterns.pl line 95
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77
  . Numbering formula:
C4::Serials::Numberpattern::ModSubscriptionNumberpattern(): DBI Exception:
DBD::mysql::st execute failed: Column 'numberingmethod' cannot be null at
/kohadevbox/koha/serials/subscription-numberpatterns.pl line 95
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77
  . Description: C4::Serials::Numberpattern::ModSubscriptionNumberpattern():
DBI Exception: DBD::mysql::st execute failed: Column 'description' cannot be
null at /kohadevbox/koha/serials/subscription-numberpatterns.pl line 95  at
/usr/share/perl5/DBIx/Class/Exception.pm line 77
  . Display order: can make blank or renumber

This fixes the new numbering pattern input form so that the name and numbering
formula fields are marked as required. Before this, there was no indication
that these fields were required and error trace messages were 

[Koha-bugs] [Bug 28012] Error on Saving new numbering pattern

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012

David Nind  changed:

   What|Removed |Added

 Attachment #140322|0   |1
is obsolete||

--- Comment #18 from David Nind  ---
Created attachment 141948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141948=edit
Bug 28012: Creating numbering pattern: mark mandatory fields required

If any of these fields were missing, notably the Numbering formula
then saving the new numbering pattern silently failed, it didn't give
any error but it didn't save any new pattern either.

Note that there is a plan to make description field optional, so even
if it currently is mandatory on the DB level we leave it optional
here (and due to people using production DB's in non-strict mode which
allows this to be optional).

To test:
  1) After applying this patch make sure all the 3 fields must be
  filled in
  /cgi-bin/koha/serials/subscription-numberpatterns.pl?op=new
  page and it cannot be saved without those.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28012] Error on Saving new numbering pattern

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012

David Nind  changed:

   What|Removed |Added

 Attachment #140196|0   |1
is obsolete||

--- Comment #17 from David Nind  ---
Created attachment 141947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141947=edit
Bug 28012: Use definedness test instead of bool when checking whether to null
fields

Saving a new numbering pattern didn't work without having to fill all
the fields, even those that are not mandatory.

To test:
 1) Go to /cgi-bin/koha/serials/subscription-numberpatterns.pl
and try creating a new pattern, notice that only Name and
Description are mandatory after applying this patch
 2) Make sure editing existing numbering patterns still works

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28012] Error on Saving new numbering pattern

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31839] New: Error 500 in normal administrative interface view

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31839

Bug ID: 31839
   Summary: Error 500 in normal administrative interface view
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: Linux
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: ricvargas...@gmail.com
QA Contact: testo...@bugs.koha-community.org

In Koha 21.11.12, when having the localcoverimages preference active and
uploading a cover page of a record, it saves it correctly but in the normal
view it marks error 500 and does not allow to consult the information, the
MARC, tagged MARC and items view works correctly.

If the localcoverimages preference is deactivated, the record is visible in the
normal view, but without its cover page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738

David Nind  changed:

   What|Removed |Added

 Attachment #141935|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 141946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141946=edit
Bug 31738: Fix untanslatable string for recalls

To test translation:
1. Apply patch and update your po files using:
  
https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation
2. Verify the string appears in po files now and translate it
3. Install the language

To test functionality:
1. Turn on recalls
   1.1. In Administration > Global system preferences, enable UseRecalls
   1.2. Add recalls permissions in your circulation rules
2. In the OPAC, log in as a patron
3. Find a record with checked out items and place a recall
4. In the intranet, go to the patron file of the patron who currently has that
item checked out
--> In the Checkouts table at the bottom of the page, there is a red message
next to the recalled title

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31738] Unstranslatable string in checkouts.js for recalls

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31738

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31276] Report results are limited to 999, 999 no matter the actual number of results

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31276

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||vic...@tuxayo.net
 Status|Pushed to stable|RESOLVED

--- Comment #9 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31325] Fix koha-preferences get

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31325

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880)

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032

giuseppe.angile...@ct.infn.it changed:

   What|Removed |Added

   Priority|P5 - low|P4

--- Comment #1 from giuseppe.angile...@ct.infn.it ---
It would be desirable that also Alternate graphic representation (880) for
Content (505, particularly 505$t) were displayed in the OPAC and intranet
detail pages

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31281] Overdue notices reply-to email address of a branch not respected

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31281

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to stable|RESOLVED
 CC||vic...@tuxayo.net

--- Comment #14 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23032] Add 264 to Alternate Graphic Representation (MARC21 880)

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23032

giuseppe.angile...@ct.infn.it changed:

   What|Removed |Added

 CC||giuseppe.angile...@ct.infn.
   ||it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31346] On the OPAC detail page some Syndetics links are wrong

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31346

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 CC||vic...@tuxayo.net
 Resolution|--- |FIXED

--- Comment #8 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.

Nothing to document it seems, marking resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all places

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |
Summary|Add a permission to control |Add a permission to control
   |the ability to change the   |the ability to change the
   |logged in branch|logged in library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in branch

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #22 from Katrin Fischer  ---
There is a change on set-library.tt causing a conflict that I am not sure
enough about to resolve. Can you please rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28967] Patrons with no checkouts report shows patrons from other libraries with IndependentBranches

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #140973|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer  ---
Created attachment 141945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141945=edit
Bug 28967: Patrons with no checkouts report shows patrons from other libraries
with IndependentBranches

When IndependentBranches is activated and a non-superlibrarian user looks at
the "Patrons with no checkouts" report, it shows patrons from other libraries.

To recreate:
1) Activate IndependentBranches, IndependentBranchesPatronModifications and
IndependentBranchesTransfers
2) Create a staff user with limited permissions (NOT a superlibrarian),
including reports permissions. Here are mine as an example
  - circulate (all)
  - catalogue
  - borrowers
- delete_borrowers
- edit_borrowers
  - reserveforothers (all)
  - reports (all)
3) Create (or make sure you already have) a patron in another branch (if using
an existing patron, make sure they have no checkouts or checkout history)
4) Log in as your limited staff patron
5) Go to Reports > Inactive > Patrons who haven't checked out
6) Don't put in any limitations and click Submit
-- The patron from the other library appears in the list
7) Try to search for that other patron in the patron module
-- The patron from the other library is inaccessible
8) Apply the patch
9) Notice that the limited patron can only see patrons from his own
library

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28967] Patrons with no checkouts report shows patrons from other libraries with IndependentBranches

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28967] Patrons with no checkouts report shows patrons from other libraries with IndependentBranches

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

--- Comment #15 from Katrin Fischer  ---
This does exactly what the bug description says, but it leaves us with some
other cases that are not taken into account. 

We do have a more complex system for visibility of patron data now, using
permissions and library groups. I am not sure how that could be moved into the
report, maybe by creating a list of allowed branchcodes to limit on? Filtering
the result list before display? Filed: bug 31838.

Also: if you have access to reports... can you be stopped from seeing data you
shouldn't? Guided and SQL reports cannot be limited to my knowledge.

I am inclined to pass QA on this one anyway as it's also a matter of
convenience. If you have independent branches, you might only want to take care
of your own users.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31838] New: Patrons with no checkouts report should only display patrons you are allowed to see

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31838

Bug ID: 31838
   Summary: Patrons with no checkouts report  should only display
patrons you are allowed to see
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Bug 28967 implements a check on IndependentBranches, but there are more
criteria that determine if you should see information about a patron (thinking
of permissions and library group functionalities). 

Should we not have the pre-built reports reflect these?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28967] Patrons with no checkouts report shows patrons from other libraries with IndependentBranches

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28967

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611

--- Comment #8 from Katrin Fischer  ---
Hm. testing this, I don't see the 'select on loan' filter without the patch
either... So maybe this was just removing dead code?

I think bringing back the option to remove all records from the list that have
items checked out could still be useful to bring back. So maybe we should keep
the code and file a new bug?

Alex, could you have a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31757] Add 'page-section' where it's missing

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||31837


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837
[Bug 31837] Add page-section to batch record deletion (tools)
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||31837


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837
[Bug 31837] Add page-section to batch record deletion (tools)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31837] New: Add page-section to batch record deletion (tools)

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31837

Bug ID: 31837
   Summary: Add page-section to batch record deletion (tools)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 30952
Blocks: 31757

When receiving a shipment, the list of pending and then received orders (table
below the first one) requires the treatment with page-section classes.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31611] More visibly highlight records that cannot be batch deleted/modified

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31611

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |
 Status|Signed Off  |Failed QA

--- Comment #7 from Katrin Fischer  ---
2 small things:

1) QA test tools failure:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
   FAIL   forbidden patterns
forbidden pattern: tab char (line 283)

2) The removed bit Jonathan noted, maybe a rebase issue?

-
Select all | 
Clear all | Clear on loan
+
Select all | 
Clear all

-$("#clearonloanbutton").click(function () {
-$("#itemst
input[name='itemnumber'][data-is-onloan='1']").each(function () {
-$(this).prop('checked', false);
-});
-return false;
-});

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun)

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #141939|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 141944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141944=edit
Bug 31807: Context for translation: Filter (verb) vs. Filter (noun)

This patch add the context 'noun' to the 'Filter' string in
marc-overlay-rules.tt. This will separate that instance of 'Filter' from
the other ones, where it is meant as a verb.

To test:
1. Apply patch
2. Visit Administration > MARC overlay rules, make sure the page works
(no errors) and that there is a column called 'Filter'
3. Update the po files

gulp po:update --lang xx-XX

for example, gulp po:update --lang fr-CA

4. Check the xx-XX-messages.po file (e.g.
misc/translator/po/fr-CA-messages.po), there should be an entry for
'Filter', with a line msgctxt that gives the 'noun' context
5. Update the file with a random word for the 'Filter' translation
for example, I translated 'Filter' by 'Filter as a noun', just to see
the difference

\#: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:83
msgctxt "noun"
msgid "Filter"
msgstr "Filter as a noun"

6. Install a new language
6.1. Run the following commands in the terminal, replacing xx-XX with
the language code (e.g. fr-CA)

cd misc/translator
./translate install xx-XX

6.2. In the Koha staff interface, go to Administration > Global system
preferences
6.3. Search for language
6.4. Check the box next to the new language
6.5. Save

7. View the MARC overlay rules page in the new language, the 'Filter'
column heading should be whatever you put in step 5

Optional test
8. In the staff interface in English, view one or more of these pages,
the 'Filter' should be unchanged
- Acquisitions > Late orders (Filter button)
- Aquisitions > Search for vendor > Receive shipments (Filter heading on
the left and Filter button)
- Acquisitions > Search for vendor > Click vendor's name > Uncertain
prices (Filter button)
- Administration > Budgets > Click budget's name > Planning > Plan by
... (any option) (Filter heading on the left)
- Reports > Use saved (Filter heading on the left)
- Reports > Acquisitions statistics wizard (Filter column heading)
- Reports > Patrons statistics wizard (Filter column heading)
- Reports > Catalog statistics wizard (Filter column heading)
- Reports > Circulation statistics wizard (Filter column heading)
- Reports > Holds statistics wizard (Filter column heading)
- Reports > Average loan time (Filter column heading)
- Tools > News (Filter heading on the left)

9. View these same pages in the other language, the Filter should NOT be
changed to whatever you put in step 5

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun)

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31807] Context for translation: Filter (verb) vs. Filter (noun)

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31807

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31626] Add letter ID to the message queue table

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #141006|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 141943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141943=edit
Bug 31626: Add letter id to the message queue table

It can be useful to know exactly what template was used to generate a notice.
To this end, it would be useful to store the letter id as a foreign key in the
message queue table.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Restart all the things!
4) Run an action that will send a notice to a patron
5) Note the letter id is now in the message_queue table for that notice!

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31626] Add letter ID to the message queue table

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #141005|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 141942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141942=edit
Bug 31626: Update Schema Files [DO NOT PUSH]

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31626] Add letter ID to the message queue table

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31626] Add letter ID to the message queue table

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626

--- Comment #8 from Katrin Fischer  ---
My first thought was: isn't the letter code not enough? But indeed... it isn't.
we can have the same code for different branches, while it's not the same text.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31626] Add letter ID to the message queue table

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed
Summary|Add letter id to the|Add letter ID to the
   |message queue table |message queue table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31626] Add letter id to the message queue table

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24860] Add ability to place item group level holds

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_22_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24860] Add ability to place item group level holds

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24860] Add ability to place item group level holds

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #154 from Katrin Fischer  ---
1) All the new and old tests pass.

But: I did a reset_all to have a clean starting page before applying these
patches. And my branches are all mangled after running the tests:

I end up with 36 branches on the sample database, a lot of those generated ones
like: brW5iS. 

There are also a ton of generated patrons...

I am not completely sure it's the new tests here, but could you please check
your clean-up?

3) Holds queue is looking good now:

a1 or any item from item_group A

Just please remove the _ :)

2) Pending holds / Holds to pull

> I don't think Holds to pull is the tool a library should be using if they
> are using item group holds. This same is true for the holds itemtype filter,
> which has been in Koha since 16.05. I'm finding the holds to pull interface
> doesn't display data well. For instance, if I place one item level hold, and
> one biblio level hold for the same record, holds to pull doesn't really
> indicate that. If you can can tell me what you'd like to see, I'll see what
> I can do!

I don't think we can argue that, unless we hid the report once the item group
holds are activated... and that might create quite some complaints. I know
single branch libraries like to use the report, also the less busy ones. Maybe
it would be worth adding a note to the system preference? "Might not go well
with..." or so? In general the page needs work, I agree with you on that!

I did some more testing:
a) If there is a record level hold only: Only 311418
b) If there is an item level hold only: 305097 or any available.
c) If there is a group level hold only: 305097 or any available.

For a start, could we catch the third case and have a correct message display?
Similar to the one on holds queue?
I'd be ok with that as a solution for this patch set.

For the future 2 ideas (just to get your opinion, will file later):

* If there are different types of holds we could display this as a note:
"Different types of holds, please check holds page"?
* We could repeat the information for every hold, maybe deduplicated. At the
moment it looks like we only get the info for the first hold placed. Maye
something like: 
  * Only 311418 (1 hold)
  * 305097 or any available (2 holds)


To summarize:
* Verify/make sure tests clean up their created data
* Remove _ from message on holds queue page
* Adapt message when only a item group hold exists on holds to pull

OK?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||31836


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31836
[Bug 31836] Formatting issue on checkin modal
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31836] New: Formatting issue on checkin modal

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31836

Bug ID: 31836
   Summary: Formatting issue on checkin modal
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 30952

Created attachment 141941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141941=edit
Screenshot of checkin modal for hold found

Best seen on the screenshot: The yellow section no longer spans the full width
of the modal.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31757] Add 'page-section' where it's missing

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||31835


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835
[Bug 31835] Add page-section to holds queue
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||31835


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835
[Bug 31835] Add page-section to holds queue
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31835] New: Add page-section to holds queue

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31835

Bug ID: 31835
   Summary: Add page-section to holds queue
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/circ/view_holdsqueue.pl
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 30952
Blocks: 31757

The table on the holds queue page needs to be a page-section.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31734] Hooks for account, recall, indexing and more actions for holds.

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31734

--- Comment #2 from Katrin Fischer  ---
Hi Stefan, in general it's recommended to break up work into smaller granular
features. They usually go in much faster, the smaller the change is, as a
question or problem doesn't cause a hold up so easily.
In this case, I think it would have made sense to have separate bugs for holds,
accounts, indexing and recalls.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31147] Recalls due date to the minute rather than 23:59

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31147

Katrin Fischer  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31750] Need more padding in cataloguing

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31750

--- Comment #3 from Katrin Fischer  ---
I tihnk a little bit of padding would not hurt, but need to keep the floating
toolbar in mind.

I'd also like to have the "Section 4" heading not stick to the section border.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31769] We need a clear guideline regarding how to display 'filters' and 'sidebar nav' at the same time

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31769

--- Comment #1 from Katrin Fischer  ---
A good example might be the suggestions page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30869] Stock rotation rotas cannot be deleted

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30869

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |normal

--- Comment #2 from Katrin Fischer  ---
Confirmed on master with my superlibrarian user:

* Enable StockRotation system preference
* Tools > Stock rotation > New rota
* Enter Name, save.
* There is no delete button visible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31773] Add 'page-section' to manage MARC import page

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31773

--- Comment #7 from Katrin Fischer  ---
(In reply to Martin Renvoize from comment #6)
> I spotted a table inconsistency like that somewhere else yesterday.. can't
> for the life of me remember where.  I didn't submit a big for it yet, got
> distracted, but we probably should report such bugs as and when we spot
> them..  I imagine it's yet another small inconsistency with our markup which
> should be fixed rather than further targeted class rules being added.

I've created an omnibus with a first linked bug for this one:

Bug 31833 - [Omnibus] Fix table inconsistencies
Bug 31834 - Inconsistent table formatting for list of MARC imports

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31833] [Omnibus] Fix table inconsistencies

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||31834


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834
[Bug 31834] Inconsistent table formatting for list of MARC imports
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31834] New: Inconsistent table formatting for list of MARC imports

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31834

Bug ID: 31834
   Summary: Inconsistent table formatting for list of MARC imports
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Blocks: 31833

The table has a line on top of the header line, which is inconsistent with
other pages.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833
[Bug 31833] [Omnibus] Fix table inconsistencies
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22794] [Omnibus] Improve and extend logging in Koha

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794

Katrin Fischer  changed:

   What|Removed |Added

Summary|Omnibus: Improve and extend |[Omnibus] Improve and
   |logging in Koha |extend logging in Koha

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||31833


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833
[Bug 31833] [Omnibus] Fix table inconsistencies
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31833] New: [Omnibus] Fix table inconsistencies

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31833

Bug ID: 31833
   Summary: [Omnibus] Fix table inconsistencies
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 30952


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||31778


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31778
[Bug 31778] action logs for administrative tasks
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31778] action logs for administrative tasks

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31778

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||22794


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794
[Bug 22794] Omnibus: Improve and extend logging in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24860] Add ability to place item group level holds

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||31832


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31832
[Bug 31832] Add reference for EnableItemGroups to EnableItemGroupHolds system
preference
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31832] Add reference for EnableItemGroups to EnableItemGroupHolds system preference

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31832

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||24860


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860
[Bug 24860] Add ability to place item group level holds
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31832] New: Add reference for EnableItemGroups to EnableItemGroupHolds system preference

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31832

Bug ID: 31832
   Summary: Add reference for EnableItemGroups to
EnableItemGroupHolds system preference
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Item group holds only make sense if the library allows item groups in the first
place. We should add a note to the system preference linking them together.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24860] Add ability to place item group level holds

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860

--- Comment #153 from Katrin Fischer  ---
Having another look here...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||31831


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831
[Bug 31831] Make inactive search options font slightly bigger
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31831] New: Make inactive search options font slightly bigger

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31831

Bug ID: 31831
   Summary: Make inactive search options font slightly bigger
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 30952

Increase font size for 'inactive' search options in top search bar.

It looks like the inactive ones are a little smaller than the selected one, it
would be nicer to have them slightly bigger, to make them easier to read.

The active one is also in front and bold, I think that should be enough to make
it stand out without the difference in font size.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #11 from Katrin Fischer  ---
I am sorry, but I found another regression:

If the user doesn't have permission for a fund, it doesn't show in the list. So
far so good.

But: if the order has been made for a fund the user has no permission for,
currently we have an entry in the list as: Keep current ...

With the patch set applied, the list jumps to the first 'allowed' fund in the
list, so on saving you will change the fund and cannot keep the existing one.

I was recently made aware of this feature, which is quite cool as we avoid data
loss here in an efficient way. We need to keep doing that.

For testing: make sure you remove budget_manage_all permission, then you can
limit some funds to a library for example.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31757] Add 'page-section' where it's missing

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||31830


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830
[Bug 31830] Add page-section to budgets and funds table on acq start page (acq)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||31830


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830
[Bug 31830] Add page-section to budgets and funds table on acq start page (acq)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31830] New: Add page-section to budgets and funds table on acq start page (acq)

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31830

Bug ID: 31830
   Summary: Add page-section to budgets and funds table on acq
start page (acq)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/acqui/acqui-home.pl
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 30952
Blocks: 31757

The budget and funds table on the acq start page should have a page-section
class.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||31829


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829
[Bug 31829] Change password form in patron account is misaligned
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31829] New: Change password form in patron account is misaligned

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31829

Bug ID: 31829
   Summary: Change password form in patron account is misaligned
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 30952

As a side effect of the redesign work the "change password" form on the patron
account in staff is misaligned.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31459] Order receive page is slow on systems with many budgets

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31459

--- Comment #10 from Katrin Fischer  ---
Thank you, Nick :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31757] Add 'page-section' where it's missing

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||31828


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828
[Bug 31828] Add page-section to list of open invoices on receive shipment page
(acq)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||31828


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828
[Bug 31828] Add page-section to list of open invoices on receive shipment page
(acq)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31828] New: Add page-section to list of open invoices on receive shipment page (acq)

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31828

Bug ID: 31828
   Summary: Add page-section to list of open invoices on receive
shipment page (acq)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/acqui/parcels.pl?booksellerid=1
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
Depends on: 30952
Blocks: 31757

When receiving a shipment and you have existing open invoices for this vendor,
they show in a list above the form for entering the new invoice number. This
area needs a page-section.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952
[Bug 30952] New design for staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757
[Bug 31757] Add 'page-section' where it's missing
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #48 from Katrin Fischer  ---
Giving this another round of testing:

I have made the FA framework my default. This worked nicely.

1) Open a record that has been saved with ACQ framework. Try to switch to
Default. The "Change framework" list will have the checkmark at "FA", but the
display will be the default framework. Switching to other frameworks works, so
it might have to do with the "" of default.

2) I feel we should fix that one David found and that I confirmed within this
patch set. There are 2 'major' ways to create a new record (from cataloguing
module and form detail page) and as this is one of them, I think it makes sense
to have it part here:

I did note that in the staff interface when on the details page for an existing
record, you have the option of New > New record - this defaults to the default
framework even if another framework is set as the default.

3) When a new record is created with "order from new" in acq, and
UseACQFrameworkForBiblioRecords  is set to Don't use, the record will be using
"default". This is less blocker than 2, but if it's not an easy fix, we should
file a bug for it.

We've just recently had a request for this on the German mailing list, would
love to see this make it into 22.11 :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31757] Add 'page-section' where it's missing

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||31827


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827
[Bug 31827] Add page-section to list to log viewer
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30952] New design for staff interface

2022-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||31827


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31827
[Bug 31827] Add page-section to list to log viewer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >