[Koha-bugs] [Bug 32280] Export method ImportBreedingAuth from C4::Breeding

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280

--- Comment #1 from Fridolin Somers  ---
Created attachment 144086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144086=edit
Bug 32280: Export method ImportBreedingAuth from C4::Breeding

In C4::Breeding method ImportBreedingAuth() should be exported to be used for
example by plugins.

No test plan needed i bet.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32280] Export method ImportBreedingAuth from C4::Breeding

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280

Fridolin Somers  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32280] New: Export method ImportBreedingAuth from C4::Breeding

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32280

Bug ID: 32280
   Summary: Export method ImportBreedingAuth from C4::Breeding
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

In C4::Breeding method ImportBreedingAuth() should be exported to be used for
example by plugins.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports of C4::AuthoritiesMarc

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

--- Comment #2 from Fridolin Somers  ---
Created attachment 144085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144085=edit
Bug 32279: Add GetAuthorizedHeading method export C4::AuthoritiesMarc

C4::AuthoritiesMarc method GetAuthorizedHeading is not exported thus it is
called in other modules :
 > git grep GetAuthorizedHeading
C4/AuthoritiesMarc.pm:=head2 GetAuthorizedHeading
C4/AuthoritiesMarc.pm:  $heading = ({ record => $record,
authid => $authid })
C4/AuthoritiesMarc.pm:sub GetAuthorizedHeading {
C4/Breeding.pm:$heading =
C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marcrecord });
C4/ImportBatch.pm:$row->{'authorized_heading'} =
C4::AuthoritiesMarc::GetAuthorizedHeading( { authid =>
$row->{'candidate_match_id'} } );
C4/ImportBatch.pm:my $authorized_heading =
C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marc_record });

This patch adds it to be exported.
For example for use in Koha plugins.

Test plan :
Check import of authorities from a file is OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports of C4::AuthoritiesMarc

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

Fridolin Somers  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports of C4::AuthoritiesMarc

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

--- Comment #1 from Fridolin Somers  ---
The main cause for us it that we want to call it in our plugin :
https://github.com/biblibre/koha-plugin-idref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32279] GetAuthorizedHeading missing from exports of C4::AuthoritiesMarc

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

Fridolin Somers  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Severity|enhancement |normal
   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32279] New: GetAuthorizedHeading missing from exports of C4::AuthoritiesMarc

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32279

Bug ID: 32279
   Summary: GetAuthorizedHeading missing from exports of
C4::AuthoritiesMarc
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

C4::AuthoritiesMarc method GetAuthorizedHeading is not exported thus it is
called in other modules :
 > git grep GetAuthorizedHeading
C4/AuthoritiesMarc.pm:=head2 GetAuthorizedHeading
C4/AuthoritiesMarc.pm:  $heading = ({ record => $record,
authid => $authid })
C4/AuthoritiesMarc.pm:sub GetAuthorizedHeading {
C4/Breeding.pm:$heading =
C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marcrecord });
C4/ImportBatch.pm:$row->{'authorized_heading'} =
C4::AuthoritiesMarc::GetAuthorizedHeading( { authid =>
$row->{'candidate_match_id'} } );
C4/ImportBatch.pm:my $authorized_heading =
C4::AuthoritiesMarc::GetAuthorizedHeading({ record => $marc_record });

It should be exported.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32276] Customize notice recipients

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32276

--- Comment #2 from Christopher Brannon  ---
Yes, thinking through this more, it would be a matter of determining for each
template if the notice is going through the owning library, the issuing
library, or the patron's home branch, and then determining the staff associated
with that template and particular branch.

I could envision a page that lists the available templates based on the
selected library, and then setting settings/e-mails for each particular
template.  One could assume that the staff e-mails and selections associated
with a template would be based on however the notice originally is sent to the
patron (from owning library, the issuing library, or the patron's home branch).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32242] The job has not been sent to the message broker: (Wide character in syswrite ... )

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32242] The job has not been sent to the message broker: (Wide character in syswrite ... )

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|ASSIGNED|Passed QA

--- Comment #17 from Tomás Cohen Arazi  ---
(In reply to Tomás Cohen Arazi from comment #16)
> This broke tests:
> 
> kohadev-koha@kohadevbox:/kohadevbox/koha$ prove
> t/db_dependent/Koha/BackgroundJobs.t
> t/db_dependent/Koha/BackgroundJobs.t .. 1/15
> #   Failed test 'No jobs found without userenv'
> #   at t/db_dependent/Koha/BackgroundJobs.t line 135.
> #  got: '2'
> # expected: '0'
> # Looks like you failed 1 test of 3.
> 
> #   Failed test 'search_limited'
> #   at t/db_dependent/Koha/BackgroundJobs.t line 142.
> ...
> 
> Reverting makes tests pass:
> 
> git revert 022034a1c7b91adac539c7ed16fc7b48d566912e
> 
> Please take your time to fix it for the release.

I was wrong. My bisect was flawed because of the reset_all I was using.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

--- Comment #27 from Michael Hafen  ---
(In reply to Caroline Cyr La Rose from comment #26)
> Wow, thanks for the quick rebase Michael!
> 
> I tested and I only have one fine, Fine (Returned), now.

You're welcome.  Thanks for the sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

--- Comment #26 from Caroline Cyr La Rose  ---
Wow, thanks for the quick rebase Michael!

I tested and I only have one fine, Fine (Returned), now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

--- Comment #25 from Caroline Cyr La Rose  ---
Created attachment 144084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144084=edit
Bug 18855: Don't create duplicate overdue fines if an issue is returned

This includes Jonathan's followup

If cronjobs/fines.pl is running during circulation hours, then an issue may
be considered for having it's overdue fine updated after the issue has been
returned and it's fine status flipped from 'UNRETURNED' to 'RETURNED'.  In
this case UpdateFine will create a duplicate fine because it can't find the
specific accountline for the (formerly) overdue issue.

This changes cronjobs/fines.pl to double check the issue before updating
the fine.  If the issue has changed between starting the script and updating
the fine, then the script will skip it.

There is a small amount of time between the check and calling UpdateFine
where the issue can be changed and this problem can reoccure.  The chance
of that happening is so small that it's probably fine to leave as is.

It is also possible that the fine won't be updated because the issue was
returned.  In this case the fine payed by the patron will be lower, but that
is better then the patron finding later that there is more to a fine they
thought they had paid all of.

Test plan (by Caroline):
0. Preliminary settings
   0.1. finesMode system preference must be set to Calculate and charge
   0.2. There must be a circulation rule that will charge fines (beware of bug
32271)
   0.3. In Tools > Calendar, today must not be a holiday

1. Make a lot of overdue checkouts - I used the batch checkout feature, but if
your system already has a lot of overdue checkouts, you can skip to step 2

   1.1. Enable batch checkouts
1.1.1. Go to Administration > Global system preferences
1.1.2. Search for BatchCheckouts
1.1.3. Set BatchCheckouts to Allow
1.1.4. Select all categories in BatchCheckoutsValidCategories
1.1.5. Click "Save all Circulation preferences"

   1.2. Get a list of barcodes
1.2.1. Go to Reports
1.2.2. Click "Create from SQL"
1.2.3. Give the report a name
1.2.4. For the SQL query, enter

   SELECT barcode FROM items WHERE onloan IS NULL LIMIT 60;

1.2.5. Click "Save report"
1.2.6. Click "Run report"
1.2.7. Click "Download" > "Tab separated text"

   1.3. Go to a patron's file
1.3.1. Go to Patrons
1.3.2. Click on "Search"
1.3.3. Click on a patron's name

   1.4. Do a batch checkout with a due date in the past
1.4.1. Click on the "Batch check out" tab on the left
1.4.2. In "Use a file", click "Choose file"
1.4.3. Choose the file downloaded from the report
1.4.4. In "Hard due date", choose a date in the past
1.4.5. Click "Check out"
1.4.6. Click "Checkout or renew"

2. Find the last issue in the database

   2.1. In the database (or in reports), type the following query

SELECT issues.*, items.itype as itemtype, items.homebranch,
items.barcode, items.itemlost, items.replacementprice, items.biblionumber FROM
issues  LEFT JOIN items USING (itemnumber) WHERE date_due < NOW() \G;

   2.2. Copy the barcode from the last entry

3. Set up so that you can run fines.pl and check in the item at the same time
(or very close to the same time)

   3.1. In Koha, click the "Check in" option in the search bar at the top of
the page
   3.2. Paste the barcode in the search bar BUT DO NOT PRESS ENTER OR THE ARROW
RIGHT AWAY
   3.3. In a terminal, enter the fines.pl command

./misc/cronjobs/fines.pl

   3.4. Execute the command and immediately click on the arrow in the staff
interface to check in the item

4. Check the patron's fines

4.1. Click on the patron's name in the check in screen
4.2. Go to the Accounting tab on the left
4.3. In the search box just above the table, paste in the returned item's
barcode

--> Without the patch, there are two fines, one Fine (Accruing) and one
Fine (Returned) for the same item at the same time
--> With the patch, there is only one fine, Fine (Returned)

Signed-off-by: Caroline Cyr La Rose 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32278] Batch modifications from the biblio page can cause 414 URI too long when attempting to modify many items

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32278

Liz Rea  changed:

   What|Removed |Added

Summary|Batch modifications from|Batch modifications from
   |the biblio page can cause   |the biblio page can cause
   |415 URI too long when   |414 URI too long when
   |attempting to modify many   |attempting to modify many
   |items   |items
 CC||wizzy...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32278] New: Batch modifications from the biblio page can cause 415 URI too long when attempting to modify many items

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32278

Bug ID: 32278
   Summary: Batch modifications from the biblio page can cause 415
URI too long when attempting to modify many items
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wizzy...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

We had a library attempt to request the following uri from the detail page with
a "select all -> modify" type of workflow. They could do up to about 400 items
(I presume because their biblionumbers are of this specific length) but not 500
or 800, response from apache is 414 Request URI too long.

We will likely up the limit for this but wondering if there is something that
can be done to make this work a little better at scale.

https://staff.partner.kohaprovider.com/cgi-bin/koha/tools/batchMod.pl?op=show=48432=48433=48434=48435=48436=48437=48438=48439=48440=48441=48442=48443=48444=48445=48446=48447=48448=48449=48450=48451=48452=48453=48454=48455=48456=48457=48458=48459=48460=48461=48462=48463=48464=48465=48466=48467=48468=48469=48470=48471=48472=48473=48474=48475=48476=48477=48478=48479=48480=48481=48482=48483=48484=48485=48486=48487=48488=48489=48490=48491=48492=48493=48494=48495=48496=48497=48498=48499=48500=48501=48502=48503=48504=48505=48506=48507=48508=48509=48510=48511=48512=48513=48514=48515=48516=48517=48518=48519=48520=48521=48522=48523=48524=48525=48526=48527=48528=48529=48530=48531=48532=48533=48534=48535=48536=48537=48538=48539=48540=48541=48542=48543=48544=48545=48546=48547=48548=48549=48550=48551=48552=48553=48554=48555=48556=48557=48558=48559=48560=48561=48562=48563=48564=48565=48566=48567=48568=48569=48570=48571=48572=48573=48574=48575=48576=48577=48578=48579=48580=48581=48582=48583=48584=48585=48586=48587=48588=48589=48590=48591=48592=48593=48594=48595=48596=48597=48598=48599=48600=48601=48602=48603=48604=48605=48606=48607=48608=48609=48610=48611=48612=48613=48614=48615=48616=48617=48618=48619=48620=48621=48622=48623=48624=48625=48626=48627=48628=48629=48630=48631=48632=48633=48634=48635=48636=48637=48638=48639=48640=48641=48642=48643=48644=48645=48646=48647=48648=48649=48650=48651=48652=48653=48654=48655=48656=48657=48658=48659=48660=48661=48662=48663=48664=48665=48666=48667=48668=48669=48670=48671=48672=48673=48674=48675=48676=48677=48678=48679=48680=48681=48682=48683=48684=48685=48686=48687=48688=48689=48690=48691=48692=48693=48694=48695=48696=48697=48698=48699=48700=48701=48702=48703=48704=48705=48706=48707=48708=48709=48710=48711=48712=48713=48714=48715=48716=48717=48718=48719=48720=48721=48722=48723=48724=48725=48726=48727=48728=48729=48730=48731=48732=48733=48734=48735=48736=48737=48738=48739=48740=48741=48742=48743=48744=48745=48746=48747=48748=48749=48750=48751=48752=48753=48754=48755=48756=48757=48758=48759=48760=48761=48762=48763=48764=48765=48766=48767=48768=48769=48770=48771=48772=48773=48774=48775=48776=48777=48778=48779=48780=48781=48782=48783=48784=48785=48786=48787=48788=48789=48790=48791=48792=48793=48794=48795=48796=48797=48798=48799=48800=48801=48802=48803=48804=48805=48806=48807=48808=48809=48810=48811=48812=48813=48814=48815=48816=48817=48818=48819=48820=48821=48822=48823=48824=48825=48826=48827=48828=48829=48830=48831=48832=48833=48834=48835=48836=48837=48838=48839=48840=48841=48842=48843=48844=48845=48846=48847=48848=48849=48850=48851=48852=48853=48854=48855=48856=48857=48858=48859=48860=48861=48862=48863=48864=48865=48866=48867=48868=48869=48870=48871=48872=48873=48874=48875=48876=48877=48878=48879=48880=48881=48882=48883=48884=48885=48886=48887=4=48889=48890=48891=48892=48893=48894=48895=48896=48897=48898=48899=48900=48901=48902=48903=48904=48905=48906=48907=48908=48909=48910=26604=CATALOGUING

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

Michael Hafen  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

Michael Hafen  changed:

   What|Removed |Added

 Attachment #131304|0   |1
is obsolete||
 Attachment #131961|0   |1
is obsolete||

--- Comment #24 from Michael Hafen  ---
Created attachment 144083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144083=edit
Bug 18855: Don't create duplicate overdue fines if an issue  is returned

[rebased Nov. 13, 2022]
[includes Jonathan's followup]

Test plan (by Caroline):
0. Preliminary settings
   0.1. finesMode system preference must be set to Calculate and charge
   0.2. There must be a circulation rule that will charge fines (beware of bug
32271)
   0.3. In Tools > Calendar, today must not be a holiday

1. Make a lot of overdue checkouts - I used the batch checkout feature, but if
your system already has a lot of overdue checkouts, you can skip to step 2

   1.1. Enable batch checkouts
1.1.1. Go to Administration > Global system preferences
1.1.2. Search for BatchCheckouts
1.1.3. Set BatchCheckouts to Allow
1.1.4. Select all categories in BatchCheckoutsValidCategories
1.1.5. Click "Save all Circulation preferences"

   1.2. Get a list of barcodes
1.2.1. Go to Reports
1.2.2. Click "Create from SQL"
1.2.3. Give the report a name
1.2.4. For the SQL query, enter

   SELECT barcode FROM items WHERE onloan IS NULL LIMIT 60;

1.2.5. Click "Save report"
1.2.6. Click "Run report"
1.2.7. Click "Download" > "Tab separated text"

   1.3. Go to a patron's file
1.3.1. Go to Patrons
1.3.2. Click on "Search"
1.3.3. Click on a patron's name

   1.4. Do a batch checkout with a due date in the past
1.4.1. Click on the "Batch check out" tab on the left
1.4.2. In "Use a file", click "Choose file"
1.4.3. Choose the file downloaded from the report
1.4.4. In "Hard due date", choose a date in the past
1.4.5. Click "Check out"
1.4.6. Click "Checkout or renew"

2. Find the last issue in the database

   2.1. In the database (or in reports), type the following query

SELECT issues.*, items.itype as itemtype, items.homebranch,
items.barcode, items.itemlost, items.replacementprice, items.biblionumber FROM
issues  LEFT JOIN items USING (itemnumber) WHERE date_due < NOW() \G;

   2.2. Copy the barcode from the last entry

3. Set up so that you can run fines.pl and check in the item at the same time
(or very close to the same time)

   3.1. In Koha, click the "Check in" option in the search bar at the top of
the page
   3.2. Paste the barcode in the search bar BUT DO NOT PRESS ENTER OR THE ARROW
RIGHT AWAY
   3.3. In a terminal, enter the fines.pl command

./misc/cronjobs/fines.pl

   3.4. Execute the command and immediately click on the arrow in the staff
interface to check in the item

4. Check the patron's fines

4.1. Click on the patron's name in the check in screen
4.2. Go to the Accounting tab on the left
4.3. In the search box just above the table, paste in the returned item's
barcode

--> There are two fines, one Fine (Accruing) and one Fine (Returned) for
the same item at the same time

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

--- Comment #23 from Michael Hafen  ---
(In reply to Caroline Cyr La Rose from comment #22)
> Hi all,
> I'm curious to know the usefulness of having the fines.pl cron run during
> library operation hours... If anyone can enlighten me on this, I would be
> very grateful.
> 

The fines.pl is part of the daily cron job, which starts around 2:30 on my
system. (as per /etc/crontab)
By the time the daily cron job gets done with fines it's after 6, which is when
some of my libraries open (I'm running Koha for a School District).

It's probably not intended to be run during operation hours, it just happens to
for me.

I'll rebase the patch for current master and upload it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18855] Fines cronjob can cause duplicate fines if run during active circulation

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18855

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #22 from Caroline Cyr La Rose  ---
Hi all,
I'm curious to know the usefulness of having the fines.pl cron run during
library operation hours... If anyone can enlighten me on this, I would be very
grateful.

I was able to recreate the problem on master, and I created a detailed test
plan, if you're interested (see below). However, the patches don't apply on the
current master, so I was not able to test them.

Here is my detailed test plan (I know it's a lot but I figured that I already
wrote it, so might as well share it!)

0. Preliminary settings
   0.1. finesMode system preference must be set to Calculate and charge
   0.2. There must be a circulation rule that will charge fines (beware of bug
32271)
   0.3. In Tools > Calendar, today must not be a holiday

1. Make a lot of overdue checkouts - I used the batch checkout feature, but if
your system already has a lot of overdue checkouts, you can skip to step 2

   1.1. Enable batch checkouts
1.1.1. Go to Administration > Global system preferences
1.1.2. Search for BatchCheckouts
1.1.3. Set BatchCheckouts to Allow
1.1.4. Select all categories in BatchCheckoutsValidCategories 
1.1.5. Click "Save all Circulation preferences"

   1.2. Get a list of barcodes
1.2.1. Go to Reports
1.2.2. Click "Create from SQL"
1.2.3. Give the report a name
1.2.4. For the SQL query, enter

   SELECT barcode FROM items WHERE onloan IS NULL LIMIT 60;

1.2.5. Click "Save report"
1.2.6. Click "Run report"
1.2.7. Click "Download" > "Tab separated text"

   1.3. Go to a patron's file
1.3.1. Go to Patrons
1.3.2. Click on "Search"
1.3.3. Click on a patron's name

   1.4. Do a batch checkout with a due date in the past
1.4.1. Click on the "Batch check out" tab on the left
1.4.2. In "Use a file", click "Choose file"
1.4.3. Choose the file downloaded from the report
1.4.4. In "Hard due date", choose a date in the past
1.4.5. Click "Check out"
1.4.6. Click "Checkout or renew"

2. Find the last issue in the database

   2.1. In the database (or in reports), type the following query

SELECT issues.*, items.itype as itemtype, items.homebranch,
items.barcode, items.itemlost, items.replacementprice, items.biblionumber FROM
issues  LEFT JOIN items USING (itemnumber) WHERE date_due < NOW() \G;

   2.2. Copy the barcode from the last entry

3. Set up so that you can run fines.pl and check in the item at the same time
(or very close to the same time)

   3.1. In Koha, click the "Check in" option in the search bar at the top of
the page
   3.2. Paste the barcode in the search bar BUT DO NOT PRESS ENTER OR THE ARROW
RIGHT AWAY
   3.3. In a terminal, enter the fines.pl command

./misc/cronjobs/fines.pl


   3.4. Execute the command and immediately click on the arrow in the staff
interface to check in the item

4. Check the patron's fines

4.1. Click on the patron's name in the check in screen
4.2. Go to the Accounting tab on the left
4.3. In the search box just above the table, paste in the returned item's
barcode

--> There are two fines, one Fine (Accruing) and one Fine (Returned) for
the same item at the same time

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31025] Reports with too many params can exceed length limit of URI

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31025

--- Comment #2 from Liz Rea  ---
We had a library try to use the following - we're going to try to increase the
limit but perhaps we can make this work differently so that it works a little
more consistently at this scale?

https://staff.partner.bywatersolutions.com/cgi-bin/koha/tools/batchMod.pl?op=show=48432=48433=48434=48435=48436=48437=48438=48439=48440=48441=48442=48443=48444=48445=48446=48447=48448=48449=48450=48451=48452=48453=48454=48455=48456=48457=48458=48459=48460=48461=48462=48463=48464=48465=48466=48467=48468=48469=48470=48471=48472=48473=48474=48475=48476=48477=48478=48479=48480=48481=48482=48483=48484=48485=48486=48487=48488=48489=48490=48491=48492=48493=48494=48495=48496=48497=48498=48499=48500=48501=48502=48503=48504=48505=48506=48507=48508=48509=48510=48511=48512=48513=48514=48515=48516=48517=48518=48519=48520=48521=48522=48523=48524=48525=48526=48527=48528=48529=48530=48531=48532=48533=48534=48535=48536=48537=48538=48539=48540=48541=48542=48543=48544=48545=48546=48547=48548=48549=48550=48551=48552=48553=48554=48555=48556=48557=48558=48559=48560=48561=48562=48563=48564=48565=48566=48567=48568=48569=48570=48571=48572=48573=48574=48575=48576=48577=48578=48579=48580=48581=48582=48583=48584=48585=48586=48587=48588=48589=48590=48591=48592=48593=48594=48595=48596=48597=48598=48599=48600=48601=48602=48603=48604=48605=48606=48607=48608=48609=48610=48611=48612=48613=48614=48615=48616=48617=48618=48619=48620=48621=48622=48623=48624=48625=48626=48627=48628=48629=48630=48631=48632=48633=48634=48635=48636=48637=48638=48639=48640=48641=48642=48643=48644=48645=48646=48647=48648=48649=48650=48651=48652=48653=48654=48655=48656=48657=48658=48659=48660=48661=48662=48663=48664=48665=48666=48667=48668=48669=48670=48671=48672=48673=48674=48675=48676=48677=48678=48679=48680=48681=48682=48683=48684=48685=48686=48687=48688=48689=48690=48691=48692=48693=48694=48695=48696=48697=48698=48699=48700=48701=48702=48703=48704=48705=48706=48707=48708=48709=48710=48711=48712=48713=48714=48715=48716=48717=48718=48719=48720=48721=48722=48723=48724=48725=48726=48727=48728=48729=48730=48731=48732=48733=48734=48735=48736=48737=48738=48739=48740=48741=48742=48743=48744=48745=48746=48747=48748=48749=48750=48751=48752=48753=48754=48755=48756=48757=48758=48759=48760=48761=48762=48763=48764=48765=48766=48767=48768=48769=48770=48771=48772=48773=48774=48775=48776=48777=48778=48779=48780=48781=48782=48783=48784=48785=48786=48787=48788=48789=48790=48791=48792=48793=48794=48795=48796=48797=48798=48799=48800=48801=48802=48803=48804=48805=48806=48807=48808=48809=48810=48811=48812=48813=48814=48815=48816=48817=48818=48819=48820=48821=48822=48823=48824=48825=48826=48827=48828=48829=48830=48831=48832=48833=48834=48835=48836=48837=48838=48839=48840=48841=48842=48843=48844=48845=48846=48847=48848=48849=48850=48851=48852=48853=48854=48855=48856=48857=48858=48859=48860=48861=48862=48863=48864=48865=48866=48867=48868=48869=48870=48871=48872=48873=48874=48875=48876=48877=48878=48879=48880=48881=48882=48883=48884=48885=48886=48887=4=48889=48890=48891=48892=48893=48894=48895=48896=48897=48898=48899=48900=48901=48902=48903=48904=48905=48906=48907=48908=48909=48910=26604=CATALOGUING

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051

Hammat wele  changed:

   What|Removed |Added

 Attachment #143384|0   |1
is obsolete||

--- Comment #34 from Hammat wele  ---
Created attachment 144082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144082=edit
Bug 31051: (follow-up) Tests for get_savings and more

- Added tests in t/db_dependent/Koha/Patron.t
- Added wording to OPACShowSavings syspref about anonymised checkout
history
- Added IDs to the savings messages on the OPAC
- Prevent explosion if a checked out item has been deleted

Sponsored-by: Horowhenua Libraries Trust
Signed-off-by: Hammat Wele 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31051] Show patron's 'savings' on the OPAC

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31051

Hammat wele  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

David Nind  changed:

   What|Removed |Added

 Attachment #144074|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 144081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144081=edit
Bug 32254: (follow-up) Add missing div around "Older transactions"

To test:

- Tools -> Cash summary for  and Tools -> Transaction history
  for 
  - In the "Older transactions" section, submit start and end dates
which will return results.
  - The table of results should be styled correctly.

Signed-off-by: David 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

David Nind  changed:

   What|Removed |Added

 Attachment #144026|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 144080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144080=edit
Bug 32254: (follow-up) Add page section to Cashup history

Adds one missing page section on the last table of the
POS transactions page.

Signed-off-by: Katrin Fischer 

Signed-off-by: David 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

David Nind  changed:

   What|Removed |Added

 Attachment #144025|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 144079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144079=edit
Bug 32254: Add 'page-section' to various tools pages

This patch adds a .page-section div to various pages in the tools
section in order to provide a consistent page structure.

Also changed: Corrected a couple of templates which were missing some
 tags.

This patch includes indentation changes, so please ignore whitespace
when looking at the diff.

To test, apply the patch and view the following pages to confirm that
the primary page content is wrapped in a container with a white
background:

- Tools -> Access files
- Tools -> HTML customizations
  - Additional contents, news or pages-- all use the same template.
  - Check the list of existing entries.
- Tools -> Batch extend due dates
  - Choose a set of criteria that will return results and click
   "Continue".
  - Check the list of checkouts to be updated.
- Tools -> Batch patron modification
  - Submit a batch of patrons for modification.
  - Check the list of patrons to be modified.
- Tools -> Upload patron images
  - Upload one or more patron images
  - Check the view of results
- Tools -> Upload
  - Upload a file and view the results, or perform a search and check
the view of results.
- Tools -> Patron card creator -> New patron card batch.
  - Submit a set of patrons and check the display of patrons in the
resulting batch.
- Tools -> Cash summary for  and Tools -> Transaction history
  for 
  - Confirm that the table of data looks correct

Signed-off-by: Katrin Fischer 

Signed-off-by: David 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30700] Patrons who can log into staff client should be able to change their own password

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700

Hammat wele  changed:

   What|Removed |Added

 CC||hammat.w...@inlibro.com
 Status|Needs Signoff   |Failed QA

--- Comment #17 from Hammat wele  ---
After apply this patch:
- When i click on the menu with my username 'Patran A' in the top-right there
is no link 'Change password' as expected.
- I can directly access to
http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=X and
change the 'Patran A' password
- But i can also access to
http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=X of other
users and i'm not redirected to a 404 page as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31025] Reports with too many params can exceed length limit of URI

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31025

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #1 from Liz Rea  ---
This same thing also happens with batch modification from the detail page - our
example was someone trying to modify more than 400 items from the detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32276] Customize notice recipients

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32276

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

--- Comment #1 from Andrew Fuerste-Henry  ---
This seems like a hard idea to implement with how Koha thinks about notices
now. Generally, some event prompts Koha to go look for a letter with a given
code and a borrower with a given borrowernumber, then send that letter to that
borrower. So there'd need to be some mechanism for the letter-based value
you've suggested to override the originally-intended recipient.

Maybe instead there could be a new page in administration that lists events
that trigger notices and allows one to set whether those go to patron or to
staff? OR to both, actually, that could be helpful. We'd have to somehow tell
it *which* staff.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28515] Make it easy to run batch modification on "all"

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28515

Liz Rea  changed:

   What|Removed |Added

 CC||wizzy...@gmail.com

--- Comment #1 from Liz Rea  ---
I love the danger of this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32242] The job has not been sent to the message broker: (Wide character in syswrite ... )

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32242

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed to master|ASSIGNED
   Keywords|rel_22_11_candidate |additional_work_needed

--- Comment #16 from Tomás Cohen Arazi  ---
This broke tests:

kohadev-koha@kohadevbox:/kohadevbox/koha$ prove
t/db_dependent/Koha/BackgroundJobs.t
t/db_dependent/Koha/BackgroundJobs.t .. 1/15
#   Failed test 'No jobs found without userenv'
#   at t/db_dependent/Koha/BackgroundJobs.t line 135.
#  got: '2'
# expected: '0'
# Looks like you failed 1 test of 3.

#   Failed test 'search_limited'
#   at t/db_dependent/Koha/BackgroundJobs.t line 142.
...

Reverting makes tests pass:

git revert 022034a1c7b91adac539c7ed16fc7b48d566912e

Please take your time to fix it for the release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32277] New: Widget dashboard

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32277

Bug ID: 32277
   Summary: Widget dashboard
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

It would be great if we could develop a panel above the news panel on the staff
interface that would serve as a widget dashboard in which we could activate
future developed widgets.

For example, I currently use jQuery mods to move the #area-pending element that
houses the patron suggestions patrons requesting modifications up above the
news.  I've also recently added a panel to show upcoming library closures.

Maybe in the future those could be turned into option widgets that could be
added to this dashboard.  And maybe others could be developed to show libraries
that are closed, show the number of holds waiting to be pulled at your library,
show curbside statuses, etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32276] New: Customize notice recipients

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32276

Bug ID: 32276
   Summary: Customize notice recipients
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

It would be great, if in the notices, we had options for who receives notices.

For example, what if, in each notice template, there were options of sending
the notice to any combination of patron, library, or other e-mails (filled in
on a field on that template).

Perhaps we could indicate if each recipient should be a CC or BCC?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32270] Add Page Section to Cataloguing - Label Creator - Manage Labels

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32270] Add Page Section to Cataloguing - Label Creator - Manage Labels

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #144075|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 144078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144078=edit
Bug 32270: add page section to label management

Test plan:
Navigate to Cataloguing - Label Creator - Manage Labels
Observe the missing page section surrounding the table
Apply patch
Observe that missing page section has now appeared

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32167] When adding an order from a a staged file without item fields we only add price if there is a vendor discount

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32167] When adding an order from a a staged file without item fields we only add price if there is a vendor discount

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32167

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #143704|0   |1
is obsolete||

--- Comment #3 from ByWater Sandboxes  ---
Created attachment 144077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144077=edit
Bug 32167: (bug 14860 follow-up) Populate price fields even if no discount on
vendor

On bug 14860 an 'else' was removed, assuming the price fields were set before
discount,
this was incorrect. This patch renames the variable and always set the price,
only discounting
ecost if a discount, but setting the values even if not

To test:
 0 - Have a vendor with a discount of 0% specified (no discount)
 1 - Export a record from your Koha
 2 - Stage the record for import and match on biblionumber
 3 - Add to a basket in acq from the staged file
 4 - Select the title, and set order price to $10 and do not fill the discount
field
 5 - Add the order - note $0 order line
 6 - Repeat with another vendor with a 10% discount and confirm that is correct
 7 - Apply patch
 8 - Repeat 2-4
 9 - Add the order and confirm $10 price
10 - Repeat with discounted vendor, confirm prices are set discounted correctly

https://bugs.koha-community.org/show_bug.cgi?id=14680

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32275] New: Fill blank record in basic editor using ISBN with Google Books API

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32275

Bug ID: 32275
   Summary: Fill blank record in basic editor using ISBN with
Google Books API
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jr...@sekls.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Bug 14242 added the ability to fill the OPAC purchase suggestion form with data
from the Google Books API by entering an ISBN.

My catalogers would be ecstatic if that functionality could be used to populate
the relevant fields on a blank bib record in the basic editor as a starting
point for creating records from scratch. This would save a substantial amount
of time entering data.

Logical mappings would be:
volumeInfo.title > 245$a
volumeInfo.subtitle > 245$b
volumeInfo.authors > 100$a
volumeInfo.publisher > 264$a
volumeInfo.publishedDate > 264$c
volumeInfo.pageCount > 300$a
volumeInfo.dimensions.height > 300$c
volumeInfo.description > 500$a

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17350] Add option to delete data stored in saved_reports

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17350

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

--- Comment #3 from Andrew Fuerste-Henry  ---
+1 on this. It'd be good to have a way to delete these manually from the staff
interface and also a way to set cleanup_database to do so.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5463] limit to available shows on hold items

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #7 from Christopher Brannon  ---
+1

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30931] Handling of items.dateaccessioned in the item editor

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30931

Hammat wele  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||hammat.w...@inlibro.com

--- Comment #19 from Hammat wele  ---
Test Plan:

1. Apply patch

2. Add an item to a biblio record. Notice there is a hint message for Date
acquired field.

3. Edit an existing item. Notice there is no hint message displaying for the
Date acquired field.

4. Batch modify an item by submitting an item barcode into Tools > Batch item
modification. Notice no hint message is displayed for the Date acquired.

5. Receive a Serial edition by changing status of issue to 'Arrived'. Notice
there is a hint message for Date acquired field.

6. But When ordering a purchase suggestions (Acquisitions) there is no hint
message displaying for the Date acquired field. The hint message should be
displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32274] New: Add option for repeating calendar closings on the nth weekday of the month

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32274

Bug ID: 32274
   Summary: Add option for repeating calendar closings on the nth
weekday of the month
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jr...@sekls.org
QA Contact: testo...@bugs.koha-community.org

It would be very helpful if closings could be scheduled to repeat on a specific
occurrence of a weekday each month (i.e. repeat closing each 2nd Saturday of
every month).

My use scenario here is a library that's only open the first Saturday of the
month. Currently the fastest way to pull that off is a weekly repeated holiday
on Saturday, and then manually placing exceptions each first Saturday which
requires ongoing manual upkeep.

Double bonus points if it could also limit to a specific month (i.e. repeat
closing every 4th Thursday in November). Currently those "Unique" holidays have
to be added at the start of each year despite their yearly repetition on a
predictable schedule.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30986] Improve responsiveness of DataTable toolbar

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30986

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Owen Leonard  ---
These changes ended up in Bug 31754.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #140646|0   |1
is obsolete||
 Attachment #140647|0   |1
is obsolete||

--- Comment #59 from Kyle M Hall  ---
Created attachment 144076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144076=edit
Bug 24194: Add ReserveExpiration system preference to disable expiration date
options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm you can
see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and confirm you
can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user.
Check it in and set the reserve as waiting. Notice that an expiration date has
now been generated for this reserve.
5) Attempt to check out the item you reserved to some other borrower. Revert
waiting status. Notice that the expiration date that was generated remains.
6) Go to Administration -> system preferences and set ReserveExpiration system
preference to 'Disable'
7) Refresh the hold request page in the intranet. Confirm the expiration date
field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration date field
disappears.
9) Place another reserve. Check it in and set the reserve as waiting. Notice
that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower. Revert
waiting status. The expiration date should remain null.
11) Confirm tests pass
t/db_dependent/Hold.t
t/db_dependent/Reserves.t
12) Go to Admin -> System preferences and search for ReserveExpiration.
Confirm related system preferences have a reference to ReserveExpiration
and the links all work
13) Text the cancel_expired_holds.pl cronjob and confirm it works with
ReserveExpiration enabled, and does nothing when disabled
14) Confirm all instances where hold expiration dates are set or
referenced are shown or hidden correctly, depending on
ReserveExpiration

Pages in the staff interface:

- Check out to a patron and check the holds tab
- View patron details and check the holds tab
- Patron hold history
- Patron details -> Print -> Print summary
- Place a hold on a title which already has at least one hold on it,
  check the table of existing holds.
- Circulation -> Holds awaiting pickup

Pages in the OPAC:

- Log in to the OPAC as a patron with holds
  - Your summary -> Holds tab
  - Your holds history (OPACHoldsHistory must be enabled).

Sponsored-by: Horowhenua Library Trust

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32270] Add Page Section to Cataloguing - Label Creator - Manage Labels

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

--- Comment #1 from jacob.om...@ptfs-europe.com ---
Created attachment 144075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144075=edit
Bug 32270: add page section to label management

Test plan:
Navigate to Cataloguing - Label Creator - Manage Labels
Observe the missing page section surrounding the table
Apply patch
Observe that missing page section has now appeared

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32270] Add Page Section to Cataloguing - Label Creator - Manage Labels

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

jacob.om...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24194] Add system preference to disable the use of expiration dates for holds

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29145] Allow patrons to have overdue items that would not result in debarment when removing overdue debarments

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29145

Kyle M Hall  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

--- Comment #5 from Owen Leonard  ---
Created attachment 144074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144074=edit
Bug 32254: (follow-up) Add missing div around "Older transactions"

To test:

- Tools -> Cash summary for  and Tools -> Transaction history
  for 
  - In the "Older transactions" section, submit start and end dates
which will return results.
  - The table of results should be styled correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32254] Add 'page-section' to various tools pages

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32254

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups list

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #143295|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 144073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144073=edit
Bug 30963: Automatically refresh the curbside pickups list

Librarians would like the page to be automatically refreshed every X minutes.

This patch is suggesting to have a checkbox at the top of the page to
let the user refresh the page given the delay they want.

We could later improve this by setting this value in a localStorage
variable.

Test plan:
Go to the curbside pickup page
Notice the new checkbox at the top
Notice that the "Refresh" button has been moved at the top as well
Play with the checkbox and the input, and confirm that the behaviour is
consistent

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups list

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30963] Automatically refresh the curbside pickups list

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30963

Kyle M Hall  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   Assignee|alexbuck...@catalyst.net.nz |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28235] Custom cover images are very large in staff search results and OPAC details

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28235

--- Comment #4 from Owen Leonard  ---
Created attachment 144072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144072=edit
Bug 28235: Correct CSS governing max width of custom cover images

Images shown in the OPAC and staff interface when the
OPACCustomCoverImages and  CustomCoverImages preferences are enabled
should be getting a max-width set in the current CSS, but the order of
the declarations is preventing the correct specificity.

This patch moves the CSS to the correct place in each file so that the
max-width is applied.

To test, apply the patch and rebuild both the staff and OPAC CSS. If you
get an error during the build process you may need to run 'yarn
install.'

- Go to Administration -> System preferences, and enable the
  OPACCustomCoverImages and  CustomCoverImages preferences.
- If you're testing with the default test database you can set the
  CustomCoverImagesURL preference to
  https://static.myacpl.org/public/covers/{normalized_isbn}.jpg
- Perform a catalog search in both OPAC and staff client limiting by
  itemtype = 'Book'.
- The search results in both interface should show several covers
  supplied from the external URL.
- In the staff client, these images should be limited to 140px wide even
  if the source image is larger.
- In the OPAC, view the detail page for one of the results with cover
  images. The image shown on the detail page should be constrained to
  140px wide even if the source image is larger.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28235] Custom cover images are very large in staff search results and OPAC details

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28235

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32273] New: Unable to set author subfields in Elastic search configuration

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32273

Bug ID: 32273
   Summary: Unable to set author subfields in Elastic search
configuration
 Change sponsored?: ---
   Product: Koha
   Version: 21.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: laura.escami...@bywatersolutions.com

In a situation in which you have 2 authors that are both named Barnaby Conrad
but one has the authorized name of dates 1922-2013 and the other has III,
1952-. If you click on one of their names for a search from a record where they
are the author, results for both show up as the search just does au:"Conrad,
Barnaby,". Configuring subfields in the Elastic search do not resolve the
problem. Current work around is to enable 'UseAuthoritiesForTracing.'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32255] Cannot use file upload in batch record modification

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32255

Blou  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32271] Overdue fines cap (amount) set to 0.00 when editing rule

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271

--- Comment #1 from Caroline Cyr La Rose  ---
I noticed this as far back as 22.05 (did not check 21.11, but 21.05 is OK).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31315] Remove GetItemsInfo from moredetail

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315

Nick Clemens  changed:

   What|Removed |Added

 Blocks||32272


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272
[Bug 32272] Last borrower and previous borrower display on moredetail.pl is
broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32272] Last borrower and previous borrower display on moredetail.pl is broken

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272

Nick Clemens  changed:

   What|Removed |Added

 Depends on||31315


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315
[Bug 31315] Remove GetItemsInfo from moredetail
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32272] New: Last borrower and previous borrower display on moredetail.pl is broken

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32272

Bug ID: 32272
   Summary: Last borrower and previous borrower display on
moredetail.pl is broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Bug 31315 removed GetItemsInfo from moredetail.pl

In the template we expected the item to contain the borrowernumber and
cardnumber for last three borrowers from old issues:

341 [% IF ( ITEM_DAT.card0 ) %]Last
borrower: [% ITEM_DAT.card0 | html %][% END
%]
342 [% IF ( ITEM_DAT.card1 ) %]Previous
borrower: [% ITEM_DAT.card1 | html %][% END
%]
343 [% IF ( ITEM_DAT.card2 ) %]Previous
borrower: [% ITEM_DAT.card2 | html %][% END
%]


We should either fix this, or remove this display

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32270] Add Page Section to Cataloguing - Label Creator - Manage Labels

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

Matt Blenkinsop  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |jacob.om...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32271] New: Overdue fines cap (amount) set to 0.00 when editing rule

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32271

Bug ID: 32271
   Summary: Overdue fines cap (amount) set to 0.00 when editing
rule
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

I noticed that when I add a circulation rule, if I leave the Overdue fines cap
(amount) field empty, it is displayed as 0.00. If I later edit this rule, the
Overdue fines cap (amount) field is *set to* 0.00, even if that's not what I
wanted. This causes the fines.pl script to charge no fine at all.

To test:

0. Preliminary settings
   0.1. finesMode system preference must be set to Calculate and charge
   0.2. MaxFine system preference must be empty
   0.3. In Tools > Calendar, today must not be a holiday

1. Add a circulation rule with fines but no fines cap
   1.1. Go to Administration > Circulation and fines rules
   1.2. Add or modify a circulation rule, make sure
-  There is a quantity in "Current checkouts allowed"
-  There is a number of days in "Loan period"
-  There is an amount in "Fine amount"
-  There is a number in "Fine charging interval" (usually 1)
-  "Overdue fines cap (amount)" is **empty**
   1.3. Save the circulation rule
   --> Note that the amount in "Overdue fines cap (amount)" is displayed as
0.00

2. Checkout an item with a date in the past to create an overdue
   2.1. Find an item barcode
2.1.1. Go to Item search
2.2.2. Click Search
2.2.3. Copy a barcode from the search results
   2.2. Go to a patron's file
2.2.1. Go to Patrons
2.2.2. Click on "Search"
2.2.3. Click on a patron's name
   2.3. Click on the "Check out" tab on the left of the patron's file
   2.4. Click on the settings icon in the "Enter item barcode" field
   2.5. Pick a due date in the past
   2.6. Paste the item barcode in the field
   2.7. Click "Check out" or press Enter
   2.8. Click "Yes, check out"
   --> Patron should have an overdue

3. Run fines.pl
   3.1. In a terminal, run

   ./misc/cronjobs/fines.pl

4. Check that the patron has fines
   4.1. Go to the patron's file
   4.2. Click on the "Accounting" tab on the left
   --> Patron should have a fine (accruing)

5. Modify the circulation rule, change any field except "Overdue fines cap
(amount)" (let's say the quantity of current checkouts has gone up)
   5.1. Go to Administration > Circulation and fines rules
   5.2. Click "Edit" next to the rule created in step 1
   --> Note that the amount in "Overdue fines cap (amount)" is 0.00
   5.3. Change any setting except "Overdue fines cap (amount)", e.g. change
Current checkouts allowed to another number
   5.4. Click "Save"
   --> Note that the amount in "Overdue fines cap (amount)" is displayed as
0.00

6. Redo step 2

7. Redo step 3

8. Redo step 4
--> Note that the patron has no fine

If Overdue fines cap (amount) is empty, it should display as empty (or
"Unlimited"), and when we edit the rule, the field should still be empty and
save as empty.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32270] New: Add Page Section to Cataloguing - Label Creator - Manage Labels

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32270

Bug ID: 32270
   Summary: Add Page Section to Cataloguing - Label Creator -
Manage Labels
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: matt.blenkin...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

We need to add page section divs to Cataloguing - Label Creator - Manage Labels
to ensure proper contrast of even odd rows in tables.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31378] Add a generic OAuth2/OIDC client implementation

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378

--- Comment #272 from Tomás Cohen Arazi  ---
Created attachment 144071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144071=edit
Bug 31378: (QA follow-up) Defer store until JSON fields are populated

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266

Hammat wele  changed:

   What|Removed |Added

 CC||hammat.w...@inlibro.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #15 from Hammat wele  ---
error: sha1 information is lacking or useless
(koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt).
error: could not build fake ancestor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

--- Comment #3 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

--- Comment #3 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

--- Comment #11 from Tomás Cohen Arazi  ---
Pushed to master for 22.11.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||22.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32178] query parameters in check_api_auth lets anyone assume a user id

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32178

--- Comment #20 from Tomás Cohen Arazi  ---
Created attachment 144070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144070=edit
Bug 32178: (QA follow-up) Correct modules import

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32178] query parameters in check_api_auth lets anyone assume a user id

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32178

--- Comment #19 from Tomás Cohen Arazi  ---
Created attachment 144069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144069=edit
Bug 32178: Adapt tests to new auth.session params

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Hammat wele  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||hammat.w...@inlibro.com

--- Comment #10 from Hammat wele  ---
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
error: Failed to merge in the changes.Patch failed at 0001 Bug 30418: Template
and JavaScript changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31748] Restore progress bar on record import

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31748

--- Comment #2 from Kyle M Hall  ---
Created attachment 144068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144068=edit
Bug 31748: Restore progress bar on record import

Test Plan:
1) Apply this patch
2) Upload a marc batch
3) Import the marc batch
4) Note that under the message "The job has been enqueued! It will be processed
as soon as possible."
   There is now a functioning progress bar and the page no longer redirects
automatically.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31748] Restore progress bar on record import

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31748

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32269] Circulation.t is failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

--- Comment #1 from Jonathan Druart  ---
Created attachment 144067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144067=edit
Bug 32269: Prevent Circulation.t to fail randomly

Highlighted by Bug 32030: fix test builder for boolean

#   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
#   at t/db_dependent/Circulation.t line 343.
#  got: '2022-11-18T14:16:12'
# expected: '2022-12-02T00:00:00'

#   Failed test 'Checkouts with auto-renewal can be renewed earliest on due
date if no renewalbefore'
#   at t/db_dependent/Circulation.t line 349.
#  got: '2022-11-18T14:16:12'
# expected: '2022-12-02T23:59:00'
# Looks like you failed 2 tests of 5

We were reaching return $now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32269] Circulation.t is failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||32269


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269
[Bug 32269] Circulation.t is failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32269] New: Circulation.t is failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32269

Bug ID: 32269
   Summary: Circulation.t is failing randomly
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: jonathan.druart+k...@gmail.com
  Reporter: jonathan.druart+k...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Blocks: 25551

21:28:55 koha_1   | #   Failed test 'Checkouts with auto-renewal can be
renewed earliest on due date if no renewalbefore'
21:28:55 koha_1   | #   at t/db_dependent/Circulation.t line 5683.
21:28:55 koha_1   | #  got: '2022-11-17T20:25:30'
21:28:55 koha_1   | # expected: '2022-12-01T00:00:00'
21:28:55 koha_1   | 
21:28:55 koha_1   | #   Failed test 'Checkouts with auto-renewal can be
renewed earliest on due date if no renewalbefore'
21:28:55 koha_1   | #   at t/db_dependent/Circulation.t line 5689.
21:28:55 koha_1   | #  got: '2022-11-17T20:25:30'
21:28:55 koha_1   | # expected: '2022-12-01T23:59:00'
21:28:55 koha_1   | # Looks like you failed 2 tests of 5.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551
[Bug 25551] [OMNIBUS] Some tests are failing randomly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #144063|0   |1
is obsolete||

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 144066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144066=edit
Bug 32268: Prevent XSLT.t to fail randomly

Can't call method "itemnumber" on an undefined value at
/kohadevbox/koha/Koha/Recall.pm line 343.

We should set item_level and not let TestBuilder pick a value.

This may have been caught (make it more obvious) by the recent change to
TestBuilder for boolean (Bug 32030: fix test builder for boolean)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32268] t/db_dependent/XSLT.t is failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32268

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #142914|0   |1
is obsolete||

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 144065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144065=edit
Bug 32010: Make sure the alert will be displayed after the ajax call

There is a missing wait_for_ajax call at after we click but wait_for_ajax
is waiting for the return of success, and the alert is there.

22:01:57 koha_1   | STRACE: /usr/share/perl5/Try/Tiny.pm:123 in
Selenium::Remote::Driver::catch {...}
22:01:57 koha_1   | /usr/share/perl5/Selenium/Remote/Driver.pm:361
in Try::Tiny::try
22:01:57 koha_1   | (eval 541):1 in
Selenium::Remote::Driver::__ANON__
22:01:57 koha_1   | (eval 543):2 in
Selenium::Remote::Driver::__ANON__
22:01:57 koha_1   | /usr/share/perl5/Selenium/Remote/Driver.pm:654
in Selenium::Remote::Driver::_execute_command
22:01:57 koha_1   |
t/db_dependent/selenium/authentication_2fa.t:282 in
Selenium::Remote::Driver::get_alert_text
22:01:57 koha_1   | /usr/share/perl/5.32/Test/Builder.pm:334 in
main::__ANON__
22:01:57 koha_1   | /usr/share/perl/5.32/Test/Builder.pm:334 in
(eval)
22:01:57 koha_1   | /usr/share/perl/5.32/Test/More.pm:809 in
Test::Builder::subtest
22:01:57 koha_1   |
t/db_dependent/selenium/authentication_2fa.t:291 in Test::More::subtest
22:01:57 koha_1   |
22:01:57 koha_1   | # Looks like you planned 7 tests but ran 4.
22:01:57 koha_1   |
22:01:57 koha_1   | #   Failed test 'Enforce 2FA setup on first login'
22:01:57 koha_1   | #   at t/db_dependent/selenium/authentication_2fa.t
line 291.
22:01:57 koha_1   | Error while executing command: no such alert at
/usr/share/perl5/Selenium/Remote/Driver.pm line 411.
22:01:57 koha_1   |  at /usr/share/perl5/Selenium/Remote/Driver.pm line
356.
22:01:57 koha_1   | # Looks like your test exited with 255 just after 4.
22:01:57 koha_1   | [20:59:37] t/db_dependent/selenium/authentication_2fa.t

Test plan:
Confirm that the test pass (execute it in a loop, hundreds of times)
Confirm that the behaviour of 2FA "enforced" (see bug 30588) is still
working as expected.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32010] selenium/authentication_2fa.t is failing randomly

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32010

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

--- Comment #27 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #26)
> +item_group_id => $item->item_group
> 
> in t/db_dependent/Circulation.t

This is the cause of the new warning "Odd number of elements in anonymous hash"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31447] "Please confirm checkout" message uses patron's home library not holds pick up library

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31447

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #26 from Jonathan Druart  ---
+item_group_id => $item->item_group

in t/db_dependent/Circulation.t

Looks wrong.

And please, perltidy your code!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28235] Custom cover images are very large in staff search results and OPAC details

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28235

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
   Keywords|additional_work_needed  |

--- Comment #86 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #85)
> Changed status to get attention from RM for last two follow-ups. Thx.

Thanks for the follow-ups, Marcel.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 144064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144064=edit
Bug 32267: (bug 32154 follow-up) Fix Agreements.t

#   Failed test at t/db_dependent/Koha/ERM/Agreements.t line 111.
# Structures begin differing at:
#  $got->[0]{user_role_id} = '2'
# $expected->[0]{user_role_id} = Does not exist
# Looks like you failed 1 test of 4.

Another fix may be better, please suggest if you disagree

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #144062|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32267] Koha/ERM/Agreements.t is failing

2022-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32267

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >