[Koha-bugs] [Bug 24401] REST API: Check-in

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

Danyon Sewell  changed:

   What|Removed |Added

 CC||danyonsew...@catalyst.net.n
   ||z
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24401] REST API: Check-in

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

--- Comment #3 from Danyon Sewell  ---
Created attachment 151109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151109=edit
Bug 24401: REST API: Check-in WIP

 Updating files to include API endpoints for check-ins

 Test plan:

 1) Apply bug 23336 as there are dependencies in there required for this to
work

 2) Apply this patch

 3) Run unit tests in t/db_dependent/api/v1/checkouts.t

 4) Make POST request to http://yourlibrary/api/v1/checkouts with request body
containing 'item_id' & 'library_id' properties.
- Observe returned data and HTTP code
  - 201 for item checked in
  - 403 for check in not allowed
  - 409 for Item not found
  - 400 for item not checked out

Sponsored-by: Auckland University of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33009] bump Standards-Version to 4.6.2

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33009

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||vic...@tuxayo.net

--- Comment #7 from Victor Grousset/tuxayo  ---
If I understand correctly this is just bumping the version while the package
isn't in accordance to the standards. We might be okay with this if the changes
needed are tedious without much value. Since it's not about having an official
Koha package in Debian's repo.
But what would be the needed changes? To actually choose what to pick or not.
To not miss on something important that might cause issues in the future. I
never did Debian packaging so maybe it's totally irrelevant, you tell us Mason.
By any chance, does a compliance tool exists so the assessment itself isn't a
big task?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23336] Add an API endpoint for issuing an item to a patron

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23336

Danyon Sewell  changed:

   What|Removed |Added

 CC||danyonsew...@catalyst.net.n
   ||z

--- Comment #18 from Danyon Sewell  ---
Going to be working on the check-in API endpoint now just in case there is
already work being done on it, I really should have checked for duplicates
before working on the checkout one too but oh well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC"

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267

--- Comment #60 from David Cook  ---
(In reply to Mengu Yazicioglu from comment #59)
> We upgraded from Debian 9 to Debian 11 and Mariadb 10.1 to 10.5 and it is
> not possible to bypass to change related tables row_format to DYNAMIC.

I don't understand what you're saying here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28980] Add temporary passwords which must be reset after first login

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28980

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33462

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28980

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722

--- Comment #1 from Lucas Gass  ---
Created attachment 151107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151107=edit
Bug 33722: Make public lists viewable for users on
virtualshelves/addbybiblionumber.pl

To test:
1. Have two users with staff access and lists permissions. ( User A and User B)
2. Create some public lists with User A. Make some that are for staff only and
some for everyone.
3. Make sure you create at least 10 different public lists.
4. Log in to the staff interface as user B and search the catalog.
5. Select a few titles and in the toolbar click 'Add to list'.
6. Here you should properly see your lists and any public lists which you can
edit.
7. If you have more than 10 lists you won't see them all in this dropdown.
8. At the bottom of the dropdown you should see 'More lists', click it.
9. Notice here you cannot select any of the existing public lists which User B
should be able to edit.
10. APPLY PATCH
11. Repeate steps 5 - 8. Now you should be able to edit public lists.
12. Create some private lists with User A and make sure User B cannot see them.
13. PLay with some new lists for User A and change 'Allow changes to contents
from' and make sure User B can see the ones they should.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722

Lucas Gass  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33722] New: Cannot see existing public lists from virtualshelves/addbybiblionumber.pl

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722

Bug ID: 33722
   Summary: Cannot see existing public lists from
virtualshelves/addbybiblionumber.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To recreate:

1. Have two users with staff access and lists permissions. ( User A and User B)
2. Create some public lists with User A. Make some that are for staff only and
some for everyone.
3. Make sure you create at least 10 different public lists.
4. Log in to the staff interface as user B and search the catalog. 
5. Select a few titles and in the toolbar click 'Add to list'.
6. Here you should properly see your lists and any public lists which you can
edit.
7. If you have more than 10 lists you won't see them all in this dropdown.
8. At the bottom of the dropdown you should see 'More lists', click it.
9. Notice here you cannot select any of the existing public lists which User B
should be able to edit.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884

--- Comment #18 from Janusz Kaczmarek  ---
I'm not sure if I would like to have one preference (even if in two
incarnations: OPAC and staff) switching off all the ES wildcard and truncation
special characters... From some months of experience with Koha + ES I would
say, it is '/' and '?' (sometimes also '!') that are problematic.  There is no
problem with most useful '*' or '~' -- even if unconsciously used by a user.  

From my perspective it would be best to have the special meaning of '?', '/',
'!' switched off by default, while '*' and '~' enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind  changed:

   What|Removed |Added

 Attachment #151099|0   |1
is obsolete||

--- Comment #162 from David Nind  ---
Created attachment 151106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151106=edit
Bug 17385: (Fix) Add custum export format option to the cart and the lists and
fix tests for CustomXSLTExportList

This patch adds 'XSL-Simple Export' to the cart and the lists and correct the
fail test in t/XSLT.t
it contains Add custum export format option when saving a record

TO TEST:

Before applying:
1) Search for a record in the intranet.
2) Click on the 'Save' button and observe the dropdown menu.
--> There is no 'XSL- Simple Export' in the dropdown menu.
3) Apply the patch.
4) In System preferences search for OpacExportOptions and enable XSL
5) Repeat the steps 1 and 2.
---> There is now 'XSL- Simple Export'  option in the dropdown menu
6) Click on 'XSL - Simple Export'. a .html file should be downloaded.
7) Open the .html file. You should see the record's informations.
8) Add some items to your Cart
9) Open the Cart
10) Click on the 'Download' and 'XSL - Simple Export'.
> a .html file should be downloaded.
> you should see the record's informations in the downloaded file.
11) Add some items to a List
12) Open the List
13) Click on the 'Download' and 'XSL - Simple Export'.
> a .html file should be downloaded.
> you should see the record's informations in the downloaded file.
14) Do the same steps in OPAC
> a .html file should be downloaded.
> you should see the record's informations in the downloaded file.
15) In System preferences search for OpacExportOptions and disable XSL
16) Repeat all steps
17) Notice that 'XSL - Simple Export' is no more in the menus.
18) Run prove -l t/XSLT.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind  changed:

   What|Removed |Added

 Attachment #151098|0   |1
is obsolete||

--- Comment #161 from David Nind  ---
Created attachment 151105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151105=edit
Bug 17385: Add tests for CustomXSLTExportList

Tests are now in one patch.
One test does not pass and I am not able to fix it.

The test who fails :


$ prove -l t/db_dependent/XSLT.t
t/db_dependent/XSLT.t .. 1/3
#   Failed test 'This list comes from the cache and that is fine'
#   at t/db_dependent/XSLT.t line 122.
#  got: '1'
# expected: '2'
# Looks like you failed 1 test of 1.

 #   Failed test 'CustomXSLTExportList: Caching'
 #   at t/db_dependent/XSLT.t line 124.
 # Looks like you failed 1 test of 3.
t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
---
t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=3,  3 wallclock secs ( 0.03 usr  0.00 sys +  1.74 cusr  0.14
csys =  1.91 CPU)
Result: FAIL


This one works fine :


$ prove -l t/XSLT.t
t/XSLT.t .. ok
All tests successful.
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.55 cusr  0.17
csys =  2.74 CPU)
Result: PASS


Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind  changed:

   What|Removed |Added

 Attachment #151097|0   |1
is obsolete||

--- Comment #160 from David Nind  ---
Created attachment 151104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151104=edit
Bug 17385: (QA follow-up) Add caching

Performance: We should add caching in CustomXSLTExportList.

Note: This resolves the lack of an intranet test in the former patch too.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind  changed:

   What|Removed |Added

 Attachment #151096|0   |1
is obsolete||

--- Comment #159 from David Nind  ---
Created attachment 151103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151103=edit
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder

Performance: We need to return an empty list if OpacExportOptions does not
contain Custom.  No need to scan the directory for custom files, if we are not
using them at all.

Note: The test only pertains to OPAC now, since the pref should not control
intranet behavior. We have no intranet counterpart. See further next follow-up.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind  changed:

   What|Removed |Added

 Attachment #151095|0   |1
is obsolete||

--- Comment #158 from David Nind  ---
Created attachment 151102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151102=edit
Bug 17385: Add custom export XSLT

Rebase

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #8 from David Nind  ---
Testing notes (using KTD):

1. I had to enable AutoLinkBiblios to get the error message in step 2 (see
comment 59 in bug 33277).

2. Tests pass with no errors after applying the patch.

3. For step 4, I ran: git grep -l mock_config | xargs -i{} prove {}
   => lots of tests are run and these should all pass except for t/lib/Mocks.pm 

  t/lib/Mocks.pm .. No subtests run 

  Test Summary Report
  ---
  t/lib/Mocks.pm (Wstat: 0 Tests: 0 Failed: 0)
Parse errors: No plan found in TAP output
  Files=1, Tests=0,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.16 cusr  0.03
csys =  0.20 CPU)
  Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718

David Nind  changed:

   What|Removed |Added

 Attachment #151075|0   |1
is obsolete||

--- Comment #7 from David Nind  ---
Created attachment 151101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151101=edit
Bug 33718: Fix the mock of Koha::Config->get in mock_config

It should not mock calls for other sections than 'config' in
koha-conf.xml.

Test plan:
Without this patch:
[1] Enable CatalogModuleRelink and LinkerRelink. This will trigger
a SearchAuthorities call when creating a sample biblio.
Note: SearchAuthorities calls Zconn and gets back information from
a wrong part of koha-conf.xml.
[2] Run t/db_dependent/Koha/Pseudonymization.t
You should see something like:
  {UNKNOWN}: Can't use string ("authorities") as a HASH ref while "strict refs"
in use at /usr/share/koha/C4/Context.pm line 587. at
/usr/share/koha/C4/Biblio.pm line 302

With this patch:
[3] Run t/db_dependent/Koha/Pseudonymization.t. Should pass now.
[4] git grep -l mock_config | xargs -i{} prove {}
Exclude Mocks.pm.

Signed-off-by: Marcel de Rooy 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32994] Remove compiled files from src (2)

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32994
Bug 32994 depends on bug 32975, which changed state.

Bug 32975 Summary: Error in package.json's definition of css:build vs 
css:build:prod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32978] 'npm install' fails in ktd on aarch64, giving unsupported architecture error for node-sass

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32978
Bug 32978 depends on bug 32975, which changed state.

Bug 32975 Summary: Error in package.json's definition of css:build vs 
css:build:prod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32975] Error in package.json's definition of css:build vs css:build:prod

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32975

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||caroline.cyr-la-rose@inlibr
   ||o.com
 Status|Needs documenting   |RESOLVED

--- Comment #10 from Caroline Cyr La Rose  ---
This seems to be backend stuff, nothing to be added to the manual. I will
close, but feel free to add details as to what needs to be documented, and I
will add it to the manual.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29935] Add option to search in archive to all information tabs

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29935

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/681
 CC||caroline.cyr-la-rose@inlibr
   ||o.com
  Documentation||Caroline Cyr La Rose
contact||
 Resolution|--- |FIXED
 Status|Needs documenting   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33721] New: Show inactive funds in invoice.tt out of order

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33721

Bug ID: 33721
   Summary: Show inactive funds in invoice.tt out of order
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 151100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151100=edit
Screenshot of the invoice section with the fund line

When viewing an invoice, the elements in the 'Fund' line are out of order.

The is the 'Fund:' label, followed by 'Show inactive:' label, then the fund
drop-down and then the show inactive checkbox.

The order should be 'Fund:' label, fund drop-down, 'Show inactive:' label, show
inactive checkbox.


To recreate:
1. In acquisitions, create an order and close the basket
2. Click 'Receive shipment' and receive the order
3. Click 'Finish receiving'
   --> The Fund line in invoice.tt is out of order

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884

--- Comment #17 from Galen Charlton  ---
And to clarify what I mean, a new system preference that is just about the ES
wildcard/truncation characters and permits different behavior in staff and
OPAC?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7840] Remove from manual Koha as a CMS (or add it to master)

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Needs documenting   |RESOLVED

--- Comment #15 from Caroline Cyr La Rose  ---
This has been done for a while, closing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

--- Comment #157 from Hammat wele  ---
Created attachment 151099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151099=edit
Bug 17385: (Fix) Add custum export format option to the cart and the lists and
fix tests for CustomXSLTExportList

This patch adds 'XSL-Simple Export' to the cart and the lists and correct the
fail test in t/XSLT.t
it contains Add custum export format option when saving a record

TO TEST:

Before applying:
1) Search for a record in the intranet.
2) Click on the 'Save' button and observe the dropdown menu.
--> There is no 'XSL- Simple Export' in the dropdown menu.
3) Apply the patch.
4) In System preferences search for OpacExportOptions and enable XSL
5) Repeat the steps 1 and 2.
---> There is now 'XSL- Simple Export'  option in the dropdown menu
6) Click on 'XSL - Simple Export'. a .html file should be downloaded.
7) Open the .html file. You should see the record's informations.
8) Add some items to your Cart
9) Open the Cart
10) Click on the 'Download' and 'XSL - Simple Export'.
> a .html file should be downloaded.
> you should see the record's informations in the downloaded file.
11) Add some items to a List
12) Open the List
13) Click on the 'Download' and 'XSL - Simple Export'.
> a .html file should be downloaded.
> you should see the record's informations in the downloaded file.
14) Do the same steps in OPAC
> a .html file should be downloaded.
> you should see the record's informations in the downloaded file.
15) In System preferences search for OpacExportOptions and disable XSL
16) Repeat all steps
17) Notice that 'XSL - Simple Export' is no more in the menus.
18) Run prove -l t/XSLT.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Attachment #141160|0   |1
is obsolete||

--- Comment #156 from Hammat wele  ---
Created attachment 151098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151098=edit
Bug 17385: Add tests for CustomXSLTExportList

Tests are now in one patch.
One test does not pass and I am not able to fix it.

The test who fails :


$ prove -l t/db_dependent/XSLT.t
t/db_dependent/XSLT.t .. 1/3
#   Failed test 'This list comes from the cache and that is fine'
#   at t/db_dependent/XSLT.t line 122.
#  got: '1'
# expected: '2'
# Looks like you failed 1 test of 1.

 #   Failed test 'CustomXSLTExportList: Caching'
 #   at t/db_dependent/XSLT.t line 124.
 # Looks like you failed 1 test of 3.
t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
---
t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=3,  3 wallclock secs ( 0.03 usr  0.00 sys +  1.74 cusr  0.14
csys =  1.91 CPU)
Result: FAIL


This one works fine :


$ prove -l t/XSLT.t
t/XSLT.t .. ok
All tests successful.
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.55 cusr  0.17
csys =  2.74 CPU)
Result: PASS


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Attachment #141159|0   |1
is obsolete||

--- Comment #155 from Hammat wele  ---
Created attachment 151097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151097=edit
Bug 17385: (QA follow-up) Add caching

Performance: We should add caching in CustomXSLTExportList.

Note: This resolves the lack of an intranet test in the former patch too.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Attachment #141158|0   |1
is obsolete||

--- Comment #154 from Hammat wele  ---
Created attachment 151096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151096=edit
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder

Performance: We need to return an empty list if OpacExportOptions does not
contain Custom.  No need to scan the directory for custom files, if we are not
using them at all.

Note: The test only pertains to OPAC now, since the pref should not control
intranet behavior. We have no intranet counterpart. See further next follow-up.

Test plan:
Run t/db_dependent/XSLT.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Attachment #141157|0   |1
is obsolete||

--- Comment #153 from Hammat wele  ---
Created attachment 151095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151095=edit
Bug 17385: Add custom export XSLT

Rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29252] Document the uses of 942c (MARC21)

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29252

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Caroline Cyr La Rose  ---
This was done a while ago.
https://koha-community.org/manual/23.05/en/html/cataloging.html#c-koha-item-type

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 22839] Manual screenshots and description in Acquisition (Funds) are outdated

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22839

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #1 from Caroline Cyr La Rose  ---
I'm closing this since I recently redid all screenshots in the acquisitions
module. (and also because I cannot find the cited text
https://koha-community.org/manual/23.05/en/html/acquisitions.html)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Attachment #141164|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Attachment #141163|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Attachment #141162|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Attachment #141161|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25655] Additionally store actual cost in foreign currency and currency from the invoice

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

--- Comment #52 from Caroline Cyr La Rose  ---
Not sure what needs documenting here. It seems to be only backend changes. I'll
close, but feel free to add details if the manual needs to be changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32705] Display actual cost in foreign currency and currency from the invoice

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32705
Bug 32705 depends on bug 25655, which changed state.

Bug 25655 Summary: Additionally store actual cost in foreign currency and 
currency from the invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33053] Tables item_groups and recalls have a biblio_id column with a default of 0

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33053

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 151094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151094=edit
Bug 33053: Handle invalid biblio_id more robustly

This patch addresses the fact the invalid FK error might differ under
some circumstances. We could try to catch the exception adding another
case, but I think this pattern is cleaner and the authors didn't provide
a fix.

We can discuss it later, as this controller class has several things to
review.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28884] ElasticSearch: Question mark in title search returns no results

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28884

Galen Charlton  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #16 from Galen Charlton  ---
Since this remains a definite usability issue, would it be sufficient to get a
fix in place by adding a system preference?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33093] (Bug 27546 follow-up) With ES searching within results does not work for 'Keyword' and 'Keyword as phrase'

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33093

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462

--- Comment #3 from Christopher Brannon  ---
Probably the easiest way to implement this would be to have both a global and
patron category enable/disable setting for new patrons created by staff option.
 If enabled, when you are entering a new patron on the staff side, the password
expiration date would be defaulted to expired as the account is created.  Any
other edits would ignore this setting.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27976] Add Granular options to CircConfirmItemParts

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27976

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

--- Comment #4 from Rebecca Coert  ---
This would be an extremely helpful feature!  Agree with the group that limiting
by itemtype would be the preferred way to do this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29335] CheckinSlip should be configurable to prpvide only checkouts in a time period

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29335

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

--- Comment #2 from Rebecca Coert  ---
Agreed!  This would be a useful feature for both the CHECKINSLIP and
ISSUEQSLIP.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #132 from Tomás Cohen Arazi  ---
Created attachment 151093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151093=edit
Bug 8179: Fund required

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #131 from Tomás Cohen Arazi  ---
Created attachment 151092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151092=edit
Bug 8179: Cosmetic changes

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #151090|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117

--- Comment #31 from Laura Escamilla  ---
Created attachment 151091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151091=edit
Bug 33117: Adding new system preference for patron searching

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32988] Cannot clear guarantor with clear link

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32988

Christopher Brannon  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Christopher Brannon  ---
Never mind.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33480] Improve display of the vendor aliases in the ERM module

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33480
Bug 33480 depends on bug 33103, which changed state.

Bug 33103 Summary: Add vendor aliases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33104] Add vendor interfaces

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104
Bug 33104 depends on bug 33103, which changed state.

Bug 33103 Summary: Add vendor aliases
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33103] Add vendor aliases

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33103

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
 Resolution|--- |FIXED
 Status|Needs documenting   |RESOLVED
  Documentation||Caroline Cyr La Rose
contact||
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/681

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33117] Patron checkout search not working if searching with second surname

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33117

Laura Escamilla  changed:

   What|Removed |Added

 Attachment #150898|0   |1
is obsolete||

--- Comment #30 from Laura Escamilla  ---
Created attachment 151090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151090=edit
Bug 33117: New System Preference PatronAutoCompleteSearchMethod

Still working on this --

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073

--- Comment #38 from Thomas Dukleth  ---
Wiki account creation bypassing the ConfirmAccount extension was possible when
email from the container was working due to a bug for which ConfirmAccount is
incompatible with the current version of MediaWiki.  Yesterday, I applied the
workaround to add to LocalSettings.php.

$wgGroupPermissions['*']['createaccount'] = false;

Broken email service for the wiki because of complications authenticating to
the SMTP server from the Docker container in addition to previous testing
configuration remaining  in LocalSettings.php meant that there were very few
spam accounts created which were actually functional.  If the accounts had been
functional, we would have found the problem shortly after the upgraded wiki
went live.

Given the similarity of spam messages and timing there may have only been one
or two spammers or spambots even with hundreds of suspicious non-working
accounts created.

There were about 20 spam accounts which had mostly just created some spam
content in the wiki user page for the account and some which created a spam
wiki page.  5 accounts before May which did not attract much notice and about
15 from 3 and 4 May which made the problem obvious.  All spam content has been
deleted and the accounts blocked.  Spam accounts were included in recent
created users with contributions,
https://wiki.koha-community.org/wiki/Special:ListUsers?username===1=1=1==mw-listusers-form=50
.

Thanks to Katrin Fischer and especially David Nind for blocking a few hundred
accounts which had almost all likely never functioned but had been created
automatically until the bug in ConfirmAccount had the workaround applied and
could have been activated.  I paused after the first hundred or so such
accounts.  Suspected spam accounts were included in all recently created users,
https://wiki.koha-community.org/wiki/Special:ListUsers?username===1=1==mw-listusers-form=50
.  We used a manual process one account at a time to block suspicious accounts.
 Legitimate accounts with contributions could be recognised but it is possible
that we inadvertently blocked a legitimate user account which had not yet been
used to create content.  David Nind proposed to write a message to the mailing
list informing anyone who might have been inadvertently affected to raise
attention to their account being improperly blocked.

The Wikimedia Foundation uses the UserCheck extension to help manage spam
account blocking but it is not working properly inside the Koha Docker
container where all users appear to have logged in from the same local IP
address instead of an external IP address.  Other extensions which had helped
in combating WikiMedia spam no longer function or do not scale better than the
manual process which we used.  Direct database manipulation to block accounts
could be possible but would need extra careful checking and the problem was
small enough to manage manually via the web user interface.  Using Docker is
nice but there are some Docker specific bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33390] Expand links to authorized values interface when an authval is mentioned in preferences

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33390

--- Comment #13 from Lucas Gass  ---
(In reply to Katrin Fischer from comment #12)
> I tried to provide some more context in a few spots. Lucas, if you hate it,
> please feel free to obsolete :)

It looks great to me!! Thanks for the follow-ups!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060

--- Comment #13 from David Gustafsson  ---
And about 3. above, it was poorly formulated, I meant that using $self->$column
results in the page taking 40% longer to generate, not that $self->$column is
%40 more expensive than get_column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33718] _new_Zconn crashes on a bug in t::lib::Mocks::mock_config

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33718

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060

--- Comment #12 from David Gustafsson  ---
Accidentally omitted
goto &{$AUTOLOAD};
which should be on the last line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060

--- Comment #11 from David Gustafsson  ---
This actually speeds speeds up so that calling the property method directly is
as fast as$self->_result()->get_column($column)

   if ( grep { $_ eq $method } @columns ) {
#if ( @_ ) {
#   $self->_result()->set_column( $method, @_);
#   return $self;
#} else {
#   my $value = $self->_result()->get_column( $method );
#   return $value;
#}
no strict 'refs';
*{$AUTOLOAD} = sub {
my $self = shift;
if ( @_ ) {
$self->_result()->set_column( $method, @_);
return $self;
} else {
my $value = $self->_result()->get_column( $method );
return $value;
}
};
This lazily defined new methods in the symbol table, and next time that method
will be called instead of AUTOLOAD. Will have a look at creating another bug
for this change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to stable|Needs documenting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33466] Link vendor name in list of licenses

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to stable|Needs documenting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32924] Filter agreements by logged in librarian

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to stable|Needs documenting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491

--- Comment #21 from Martin Renvoize  ---
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33491] EBSCO Packages - Add new agreement UI has some issues

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.05.00|23.05.00,22.11.06
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483

--- Comment #34 from Martin Renvoize  ---
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33483] Cannot link EBSCO's package with local agreement

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.05.00|23.05.00,22.11.06
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33466] Link vendor name in list of licenses

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466

--- Comment #10 from Martin Renvoize  ---
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33466] Link vendor name in list of licenses

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)|23.05.00|23.05.00,22.11.06
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33066] We need a KohaTable Vue component

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066

--- Comment #104 from Martin Renvoize  ---
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33066] We need a KohaTable Vue component

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)|23.05.00|23.05.00,22.11.06
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32924] Filter agreements by logged in librarian

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924

--- Comment #12 from Martin Renvoize  ---
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32924] Filter agreements by logged in librarian

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|23.05.00|23.05.00,22.11.06
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33466] Link vendor name in list of licenses

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33466

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs documenting   |Pushed to master

--- Comment #9 from Martin Renvoize  ---
For 22.11.06 I've decided to incorporate the majority of ERM improvements.. a
lot of work has gone into improving ERM this cycle and for long term
maintenance I think it makes sense to include these changes at this stage.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32924] Filter agreements by logged in librarian

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924

--- Comment #11 from Martin Renvoize  ---
For 22.11.06 I've decided to incorporate the majority of ERM improvements.. a
lot of work has gone into improving ERM this cycle and for long term
maintenance I think it makes sense to include these changes at this stage.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32924] Filter agreements by logged in librarian

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32924

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs documenting   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33713] Report batch operations should open in new tab

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33713

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060

--- Comment #10 from David Gustafsson  ---
No, the loop is not it, I think AUTOLOAD in itself is slow, perhaps parsing of
method name etc. I think there are techniques to speed this up by lazily
defining actual setter/getter methods on AUTOLOAD, and could be worth looking
into.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33700] Allow setting for CircConfirmItemParts to checkout via self check

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33700

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30995] Bug 29504 - Confirm item parts requires force_checkout permission (batch checkout)

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30995

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30519] Regression: using sys pref CircConfirmItemParts prevents checkin from moremember.pl and circulation.pl

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27976] Add Granular options to CircConfirmItemParts

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27976

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #130 from Tomás Cohen Arazi  ---
Created attachment 151089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151089=edit
Bug 8179: Fix JS indentation in parcel.tt

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33406] Searching for authority with hyphen surrounded by spaces causes error 500 (with ES)

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33406

--- Comment #2 from Janusz Kaczmarek  ---
Jonathan, thank you for the patch.  I'll test it and it most probably will do
its job.

At the same time, I'm not quite sure if all we can do is to catch error.  IMHO
it will be rather surprising for an librarian to see information about an error
and a prompt to try again while searching (with default settings) for an
existing authority (and hyphens surrounded by spaces normally occur e.g. in
corporate names or in series titles). 

Couldn't we, retaining the catching mechanism, also add somehow a correction
like this:

--- a/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
+++ b/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
@@ -1228,6 +1228,8 @@ sub _split_query {

 # Filter out empty values
 @tokens = grep( /\S/, @tokens );
+# Filter out some known isolated trouble makers: -, ^, \, ~, +
+@tokens = grep( !/^[-\^\\~\+]*$/, @tokens );

 return @tokens;
 }


[The auth 'contains' query goes always through _split_query which is called by
_truncate_terms]

This would prevent most known issues to emerge.  (I was unable, due to lack of
time, to prepare the official patch by myself).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #129 from Tomás Cohen Arazi  ---
Created attachment 151088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151088=edit
Bug 8179: Remove leftover/not used embed definitions

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #128 from Tomás Cohen Arazi  ---
Created attachment 151087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151087=edit
Bug 8179: Remove commented code

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32060] Improve performance of Koha::Item->columns_to_str

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32060

--- Comment #9 from David Gustafsson  ---
(In reply to Jonathan Druart from comment #8)
> 1. Then I would C4::Biblio::GetFrameworkCode and cache there.
> 
> 2. -my $tagslib = C4::Biblio::GetMarcStructure(1, $frameworkcode);
> +my $tagslib = C4::Biblio::GetMarcStructure( 1, $frameworkcode, { unsafe
> => 1 } );
> 
> Yes, definitely.
> 
> 3. -my $value = $self->$column;
> +my $value = $self->_result()->get_column($column);
> 
> Really faster?

1. Could do that, but that change is a little bit scarier as we don't expire
the cache and  GetFrameworkCode is used extensively in other places. But could
be done in ModBiblio, which is simple enough I guess. Would also speed up other
calls to GetFrameworkCode, doubt would have much impact as it's already pretty
fast and columns_to_str most likely the only place it makes much of a
difference, but you never know.

3. I'm quite surprised myself, but using $self->$column is about 1.4x slower
for a biblio with 1400 items. My guess the offending line of code is:

if ( grep { $_ eq $method } @columns ) {

in AUTOLOAD. Looping over @columns has O(n) time complexity but using a
columns_info hash where columns can be looked in O(1) time. Could be wworth
looking into in another bug to generally speed up accessing of properties in
Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #127 from Tomás Cohen Arazi  ---
Created attachment 151086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151086=edit
Bug 8179: Make partial receive work correctly

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #151084|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 151085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151085=edit
Bug 33362: Allow return claims to be resolved even if the issue has since been
delete from the database

Test Plan:
1) Check out an item
2) Claim return on it, moving it to the old_issues table
3) Delete the old_issue via koha-mysql or Use cleanup_database.pl
4) Attempt to resolve the claim
5) Note the error
6) Apply this patch set
7) Restart all the things!
8) Attempt to resolve the claim
9) No errors!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29431] Hold queue does not consider expiration date

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29431

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362

--- Comment #1 from Kyle M Hall  ---
Created attachment 151084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151084=edit
Bug 33362: Allow return claims to be resolved even if the issue has since been
delete from the database

Test Plan:
1) Check out an item
2) Claim return on it, moving it to the old_issues table
3) Delete the old_issue via koha-mysql or Use cleanup_database.pl
4) Attempt to resolve the claim
5) Note the error
6) Apply this patch set
7) Restart all the things!
8) Attempt to resolve the claim
9) No errors!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33362] Return claims can be un-resolvable if issue_id is set but no issue is found in issues or old_issues

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33362

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33335] MARC overlay rules broken because of "categorycode.categorycode " which contains "-"

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #9 from Marcel de Rooy  ---
Two things:

As already commented, we lost the * => * now. Please add it back.
And the To.JSON approach does not guarantee a correct sort order which we did
have.
If you add the *,* in js you will probably loose the sort order which you could
not lean on anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl

2023-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890

Michaela Sieber  changed:

   What|Removed |Added

 CC||michaela.sie...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >