[Koha-bugs] [Bug 33353] Add compatibility with Elasticsearch 8

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33353

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27452] Create GUI for patron_emailer cron

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27452

--- Comment #4 from David Cook  ---
(In reply to Katrin Fischer from comment #3)
> Hm, that's odd as it's one of the most popular plugins. I left a note for
> Nick on IRC.

Thanks, Katrin :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677

--- Comment #12 from Victor Zuniga  ---
(In reply to David Nind from comment #11)
> I was able to install with: koha-translate --install es-ES
> 
> If I used the same command as you did, including the instancename (in my
> case, koha-translate --install es-ES kohadev), I got the same error as you
> did:
> 
>Error: the selected language is not currently available.
> 
> I'm not sure why this is. Maybe there is something wrong with the
> koha-translate package command (the help says you should include the
> instance name), or it is something to do with permissions.

Thanks for testing.

I tried running the command without the instance name and got the following
message:

Error: the selected language is already installed. Try --update if you want to
re-install it.


I tried using the --update command instead and basically got the same message
(Package is already installed).

Do you know what level of permissions should be attributed to the po packages?

Thanks,

Victor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

--- Comment #41 from Alex Buckley  ---
(In reply to Marcel de Rooy from comment #40)
> (In reply to Alex Buckley from comment #39)
> > Hi Marcel, 
> > 
> > According to comment #36 this enhancement (bug 30418) was pushed to master
> > around 2023-05-16 09:28:06 UTC, however, the list permission problems in bug
> > 33722 were reported earlier at 2023-05-11 23:16:42 UTC 
> > 
> > Also, noting that if you checkout 2928c1cf634c97041ea3b1268dcc27a550feb2ca
> > 'Bug 32775: (QA follow-up) remove useless empty line' (the commit in log
> > before bug 30418 was pushed) the problem reported in bug 33722 can be
> > replicated then. 
> > 
> > Alex
> 
> Might be false alarm indeed. Sorry for the confusion.

No worries, thanks Marcel

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Text to go in the|This adds the option to add |This adds the option to add
  release notes|additional user defined |additional user defined
   |fields to the order lines   |fields to the order lines
   |in the acquisition module.  |in the acquisition module.
   |The fields can be yet up as |The fields can be set up as
   |free text fields or pull|free text fields or pull
   |down lists driven by|down lists driven by
   |authorised values. They can |authorised values. They can
   |also pull information from  |also pull information from
   |the MARC record or allow|the MARC record or allow
   |you to create and edit a|you to create and edit a
   |field in the MARC record.   |field in the MARC record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||Caroline Cyr La Rose
contact||
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/691

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21330] Add XSLT for authority detail page in OPAC

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21330

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||Caroline Cyr La Rose
contact||
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

Maryse Simard  changed:

   What|Removed |Added

 Attachment #144267|0   |1
is obsolete||

--- Comment #32 from Maryse Simard  ---
Created attachment 151452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151452=edit
Bug 17983: Add minutes loan to DiscreteCalendar

This is an additional feature to our new Discrete Calendar.
Theses patches add the possibility to choose the loan unit as minutes in
circulations rules.

Test plan:
- Apply patch of Bugzilla 17015
- Apply this patch.
- Run test t/db_dependent/minutes_loan.t
- Create new item type for the new rule.
- Create circulation rule and fill the fields, make sure the unit is set to :
minutes, choose the item type of the one created above.-
- Checkout an item that follow the circulation rule and set due date in the
past.

- Run fines.pl.
- Check if the correct amount was calculated.
- Note: make sure to factor in the fine grace period if set and the system
preference FinesIncludeGracePeriod.fixed patch tests and minor adjustments

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776

Blou  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |philippe.blo...@inlibro.com
   |ity.org |
   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #2 from Blou  ---
Not sure how this can be signed off.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776

--- Comment #1 from Blou  ---
Created attachment 151451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151451=edit
Bug 33776: Additional default plugin repo in koha-conf-site.xml.in

Solutions inLibro started formating its repository to be found by Bug
23975.  This patch adds it to the default list in the config template.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33776] Add inLibro in default plugin repositories

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33776] New: Add inLibro in default plugin repositories

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33776

Bug ID: 33776
   Summary: Add inLibro in default plugin repositories
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

We reorganized our plugin repository in order to be able to take advantage of
bug 23975. Since there are three companies in the default  tag,
we'd like to be included also.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

--- Comment #2 from Barbara Johnson  ---
Agreed - I think having the outline will reduce mistakes and increase
efficiency for our staff.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #348 from Maryse Simard  ---
Created attachment 151450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151450=edit
Bug 17015: Corrections for tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #347 from Maryse Simard  ---
Created attachment 151449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151449=edit
Bug 17015: Miscellaneous corrections

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #144273|0   |1
is obsolete||

--- Comment #346 from Maryse Simard  ---
Created attachment 151448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151448=edit
Bug 17015: Always uncheck "Copy all librairies" when opening edit page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #144272|0   |1
is obsolete||

--- Comment #345 from Maryse Simard  ---
Created attachment 151447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151447=edit
Bug 17015: UI tweaks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #144271|0   |1
is obsolete||

--- Comment #344 from Maryse Simard  ---
Created attachment 151446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151446=edit
Bug 17015: Add minDate restrictions for pairs of date selectors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #144270|0   |1
is obsolete||

--- Comment #343 from Maryse Simard  ---
Created attachment 151445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151445=edit
Bug 17015: Add an option to view past holiday details in table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #144269|0   |1
is obsolete||

--- Comment #342 from Maryse Simard  ---
Created attachment 151444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151444=edit
Bug 17015: Allow holiday edits to be applied to all branches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #144268|0   |1
is obsolete||

--- Comment #341 from Maryse Simard  ---
Created attachment 151443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151443=edit
Bug 17015: Add description field

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #144264|0   |1
is obsolete||

--- Comment #340 from Maryse Simard  ---
Created attachment 151442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151442=edit
Bug 17015: Use branchcode when adding or modifying a holiday

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #144262|0   |1
is obsolete||

--- Comment #339 from Maryse Simard  ---
Created attachment 151441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151441=edit
Bug 17015: Install scripts for DiscreteCalendar

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #144261|0   |1
is obsolete||

--- Comment #338 from Maryse Simard  ---
Created attachment 151440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151440=edit
Bug 17015: DatePicker/TimePicker to Flatpickr

Changed all datepicker/timepicker to flatpickr + some small fixes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #144260|0   |1
is obsolete||

--- Comment #337 from Maryse Simard  ---
Created attachment 151439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151439=edit
Bug 17015: Tests for DiscreteCalendar

Signed-off-by: Michal Denar 

Bug 17015: Rebase and tests for discrete calendar

This patch is a rebase of all the previous patches in order to show the
discrete calendar.

TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass)

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Maryse Simard  changed:

   What|Removed |Added

 Attachment #144259|0   |1
is obsolete||

--- Comment #336 from Maryse Simard  ---
Created attachment 151438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151438=edit
Bug 17015: DiscreteCalendar UI, Back-End and necessary scripts

Signed-off-by: Michal Denar 

Bug 17015: When using book drop mode, set check in time as closing hours

Signed-off-by: Michal Denar 

Bug 17015: Automatically update calendar when creating or deleting a branch

Signed-off-by: Michal Denar 

Bug 17015: Rebase and tests for discrete calendar

This patch is a rebase of all the previous patches in order to show the
discrete calendar.

TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Run t/db_dependent/DiscreteCalendar.t (All tests should pass)

Signed-off-by: Michal Denar 

Bug 17015: DiscreteCalendar->new() method is now in a HASH

This patch adds missing curly brackets in all new() calls.
All tests in t/ should pass too (The one that don't pass are not passing before
the patch)

TEST PLAN:
1- Apply the patch
2- Run installer/data/mysql/updatedatabase.pl
3- Run misc/cronjobs/add_days_discrete_calendar.pl
4- Check that the max date is today + 1 day
5- Attempt a checkout
 ~ The error "Can't use string ("branchcode") as a HASH ref while
   "strict refs" in use at /kohadevbox/koha/Koha/DiscreteCalendar.pm line 79"
is no longer here
5- Run t/db_dependent/DiscreteCalendar.t (prove -l
t/db_dependent/DiscreteCalendar.t)
6- Run all koha test in t/ (prove t). All tests should pass
7- Use Discrete Calendar in Tools->Calendar

USING THE DISCRETE CALENDAR:
1- New UI
  a) Calendar on the left
  b) Holidays list on the right
2- New color system for holiday types:
  a) Working day : white
  b) Unique holiday: red
  c) Holiday repeating weekly: yellow
  d) Holiday repeating yearly: orange
  e) Floating holiday: green
  f) Need validation: blue
3- When clicking on a date in the calendar, opening, closing hours and holiday
type are displayed.
4- All the fields are editable
5- New radio button to Edit selected dates or Copy to different dates
6- Option to copy the calendar to another branch

Bug 17015: Fixing QA tools failures

This patch fixes tests that fails with the QA tool.

To test, run the QA tool
All tests should say OK except 2 that fails.

Bug 17015: Check out with the useDaysMode preference

When checking out with useDaysMode preference set to "Use the calendar to push
the due date to the next open day",
an error 500 appears. This patch fixes this error.

To test:
1. Go in Administration->useDaysMode
2. Set this preference t0 "Use the calendar to push the due date to the next
open day"
3. Make sure you have a patron and a item (note the patron's category and the
item's type)
4. Make sure you have a circulation rule with the patron's category and the
item type in step 3
5. Attempt a checkout
6. An error 500 appears
7. Apply the patch
8. The error is no longer there

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32677] Spanish language not displaying on the staff or opac interface

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32677

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #11 from David Nind  ---
I was able to install with: koha-translate --install es-ES

If I used the same command as you did, including the instancename (in my case,
koha-translate --install es-ES kohadev), I got the same error as you did:

   Error: the selected language is not currently available.

I'm not sure why this is. Maybe there is something wrong with the
koha-translate package command (the help says you should include the instance
name), or it is something to do with permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33775] New: Different/no results between Check Out and Search Patron when searching for names with spaces

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33775

Bug ID: 33775
   Summary: Different/no results between Check Out and Search
Patron when searching for names with spaces
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bwsdo...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

For the patron first name Jane surname Van Allen - in Check out, entering Van
Allen will bring up the patron record, entering Van Allen in the Search Patron
brings no results.  The search needs to be the same in both.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30418] Add permission and setting for public lists to allow staff with permission to edit contents

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30418

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||Caroline Cyr La Rose
contact||
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/691
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33774] Loading club table in every tab in patron details

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774

David Nind  changed:

   What|Removed |Added

   Severity|enhancement |major
 CC||da...@davidnind.com
Version|unspecified |master

--- Comment #1 from David Nind  ---
I checked this on 22.11.05, and it is not doing this.

So, at the moment the bug is limited to master.

I changed the importance to major, as the details area is used frequently - and
I don't think you would want this bug showing in a new release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30579] When placing item level hold, some options that are not used are not disabled

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30579

Sam Lau  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||sama...@gmail.com

--- Comment #34 from Sam Lau  ---
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33473] Allow to send email receipts for payments/writeoff manually instead of automatically

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33473
Bug 33473 depends on bug 31448, which changed state.

Bug 31448 Summary: Add option to re-send email receipt when UseEmailReceipts is 
enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31448] Add option to re-send email receipt when UseEmailReceipts is enabled

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31448

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Documentation||Caroline Cyr La Rose
contact||
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/691
 Status|Needs documenting   |RESOLVED
 CC||caroline.cyr-la-rose@inlibr
   ||o.com
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32373] Show date of restriction on patron screen

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32373

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
 Resolution|--- |FIXED
  Documentation||https://gitlab.com/koha-com
 submission||munity/koha-manual/-/merge_
   ||requests/691
  Documentation||Caroline Cyr La Rose
contact||
 Status|Needs documenting   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33722] Cannot see existing public lists from virtualshelves/addbybiblionumber.pl

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33722

--- Comment #11 from David Nind  ---
(In reply to Marcel de Rooy from comment #9)
> (In reply to David Nind from comment #3)
> > The only thing I noticed was that you can choose to make a list Private and
> > choose Nobody for allow changes to content.
> > 
> > You then lose access to the list, and even a super librarian can't see it.
> > 
> > This is also the case in master, so I think this is a separate bug.
> 
> I thought that I saw it too. But cannot reproduce anymore now somehow. Could
> you give the exact steps to reproduce?

I can't reproduce it on master now either - maybe I was mixing up my different
browser windows with different staff users.

Apologies for the noise...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33773] Possible CSS adjustments for the header search usability improvement

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33773

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33774] New: Loading club table in every tab in patron details

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33774

Bug ID: 33774
   Summary: Loading club table in every tab in patron details
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

When clubs are defined, the clubs table loads in all tabs at the bottom of the
patrons details page.

To recreate:
1. Create a club
   1.1. Go to Tools > Patron clubs
   1.2. Click 'New club template'
   1.3. Enter a name
   1.4. Click 'Save'
   1.5. Click 'New club' and choose the template
   1.6. Enter a name
   1.7. Click 'Save'

2. Go to Patrons and go in any patron's account
   --> At the bottom of the page, the 'Checkouts' tab says 'Loading...'

3. Click any other tab in that bottom section (Holds, Claims, Restrictions,
Article requests, Recalls)
   --> All say 'Loading...'

4. Click the Clubs tab
   --> The table loads finally

5. Click back in any other tab
   --> The Clubs table shows in all tabs https://snipboard.io/0tBYLM.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527

Katrin Fischer  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #8 from Katrin Fischer  ---
Missing test plan = Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33773] Possible CSS adjustments for the header search usability improvement

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33773

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

--- Comment #1 from George Williams (NEKLS)  ---
The button highlighting is much appreciated.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33772] Header search input no longer has an outline when focused

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

--- Comment #1 from George Williams (NEKLS)  ---
I agree.  Adding an outline when focused would be helpful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639

Sam  changed:

   What|Removed |Added

 CC||sama...@gmail.com
 Status|Signed Off  |Failed QA

--- Comment #8 from Sam  ---
When adding a new item, a group is already preselected in the dropdown box,
which makes the enumchron box empty by default, even though a group is
selected. Had to deselect the group and then reselect it in order for the
enumchron to be filled.

Another issue was that when the new item was added, the selected group did not
show up in the group column, instead, the group column was left empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28527] Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28527

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED
 CC||Laura.escamilla@bywatersolu
   ||tions.com

--- Comment #7 from Laura Escamilla  ---
Blocking for now until a test plan is available for sign offs. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33773] New: Possible CSS adjustments for the header search usability improvement

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33773

Bug ID: 33773
   Summary: Possible CSS adjustments for the header search
usability improvement
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jr...@sekls.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 151437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151437=edit
Search header css adjustments

The header search post-redesign is a little claustrophobic. Some of my
libraries are staffed by people who struggle with mousing and keyboarding and
will have trouble with accidentally hitting top nav bar links when attempting
to click into the search input.

I've made some css tweaks on my system to give it a little more breathing room
and improve usability -- sharing in case others might find any of the changes
beneficial enough to make them standard.

The attached gif shows what the css below does.

#header_search {
  padding: 0.6em;
}

#header_search .form-title {
  background-color: #6FAF42;
  padding: 0 16px;
  border-radius: 16px;
}

#header_search .form-title label {
  margin: 0 auto;
}

#header_search .nav-tabs>li>a {
  padding: 0.3em 0.5em;
}

#header_search .nav-tabs>li.active a, #header_search .nav-tabs>li.active
a:hover {
cursor: default;
padding: 0.3em .5em;
border: 2px solid #7CBB51;
background-color: #7CBB51;
border-radius: 16px;
}

#header_search .nav-tabs>li>a:hover, #header_search .nav-tabs>li>a:focus {
background-color: #408540;
border: 2px solid #408540;
border-bottom-color: #6faf44;
padding: 0.3em .5em;
text-decoration: none;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26053] Adding more details to the manual about Patron Restrictions

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26053

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
  Component|Documentation   |Patrons

--- Comment #9 from Caroline Cyr La Rose  ---
I think this has moved from documentation to enhancement request?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675

Nick Clemens  changed:

   What|Removed |Added

 Attachment #151036|0   |1
is obsolete||

--- Comment #10 from Nick Clemens  ---
Created attachment 151436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151436=edit
Bug 33675: Add CSRF protection to OAuth/OIDC authentication

This patch makes the OAuth/OIDC client pass a `state` parameter with a
CSRF protection token, to be validated back when the flow returns to
Koha.

Ideally, the Mojolicious::Plugin::OAuth2 library should deal with this
implicitly, probably making use of JWT. But as of now, this is the best
way to implement it.

To test:
1. Have a working SSO solution (ktd --sso)
2. Click to login using SSO
=> SUCCESS: Notice a 'state' parameter on the URL, looks like a random
thing
3. When you login, no error is reported

Signed-off-by: David Cook 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33675] Add CSRF protection to OAuth/OIDC authentication

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33675

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33772] New: Header search input no longer has an outline when focused

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33772

Bug ID: 33772
   Summary: Header search input no longer has an outline when
focused
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jr...@sekls.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 151435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151435=edit
Comparison of header search pre and post 22.11

Prior to the staff interface redesign, the input box in the header search had a
black outline to indicate focus. This no longer appears post-redesign so it is
easy to miss when the input is in or out of focus.

This is also an accessibility concern:
https://developer.mozilla.org/en-US/docs/Web/CSS/:focus#accessibility_concerns

A possible workaround is to add an inset box-shadow:

#header_search .form-content:focus-within {
box-shadow: inset 0 0 0px 3px #ffc32b;
}

The attachment includes the before and after, as well as how the above css
looks.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33758] Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758

--- Comment #2 from Nicolas Giraud  ---
Created attachment 151434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151434=edit
Simple plugin to test the patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33195] Reindent the bibliographic details page

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195

Owen Leonard  changed:

   What|Removed |Added

 Blocks||33526


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526
[Bug 33526] Use template wrapper for tabs: Bibliographic detail page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33526] Use template wrapper for tabs: Bibliographic detail page

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526

Owen Leonard  changed:

   What|Removed |Added

 Depends on||33195


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195
[Bug 33195] Reindent the bibliographic details page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33195] Reindent the bibliographic details page

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195

--- Comment #2 from Owen Leonard  ---
Created attachment 151433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151433=edit
Bug 33195: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33195] Reindent the bibliographic details page

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195

--- Comment #1 from Owen Leonard  ---
Created attachment 151432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151432=edit
Bug 33195: Reindent the bibliographic details page

This patch reindents the bibliographic details template so that
it has consistent indentation. These changes should have no visible
effect on the page.

To test, apply the patch and view the detail page for a bibliographic
record. Test as many variations as you can:

- With and without cover images enabled
- With FRBRizeEditions enabled (and multiple editions in your catalog)
- With LocalCoverImages enabled
- With AcquisitionDetails enabled
- With a serial record
- With a record with component parts
- With EnableItemGroups enabled
- Wtih CatalogConcerns enabled
- With HTML5MediaEnabled and a record with media links

Viewing the diff while ignoring whitespace changes should show only
places where a line break was added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33195] Reindent the bibliographic details page

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Text to go in the||This development changes
  release notes||the order receive page so
   ||multiple orders can be
   ||selected and processed at
   ||once.
   ||
   ||Selected orders can
   ||be browsed using the added
   ||'Next order' and 'Previous
   ||order' buttons.
   ||
   ||After
   ||editing each order, without
   ||reloading the page or
   ||having to search for them
   ||again, a convenient
   ||'Confirm' button allows us
   ||to receive all orders at
   ||once.
   ||
   ||This opens the door
   ||for new enhancements like
   ||adding default actions on
   ||all selected orders, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #154 from Tomás Cohen Arazi  ---
Pushed the last follow-up for the sake of having the strings in place. Lucas
was looking at styling it better. Remaining issues should be handled in
follow-up bugs for clarity.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

--- Comment #153 from Tomás Cohen Arazi  ---
Created attachment 151431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151431=edit
Bug 8179: (follow-up) Restore funds dropdown and checkbox

This patch reintroduces the dropdown that got lost in some refactoring
of the patchset. It also introduces a couple minor fixes.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771

--- Comment #3 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #151429|0   |1
is obsolete||

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 151430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151430=edit
Bug 33771: Fix markup errors in orderreceive.tt

This patch fixed the following on orderreceive.tt:

-One of the  is closed with a 
-The #jobpanel element div is not properly closed
-Style tags are in the HTML body and they should be in the HTML head
-The #modal-order-main needs a class of 'row', this has been added.

Apply the pacth and follow the steps in 8179 until you get to the
orderreceive.tt. There should be no visual changes but the markup has been
corrected.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766

--- Comment #7 from Katrin Fischer  ---
But doesn't the screen reader indicate if something is a link or button? Just
wondering because login seems a very common field label. And I worry with login
ID people will overthink it. Would be great to get more opinions/eyes on this
one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29002] Add ability to book items ahead of time

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

--- Comment #29 from Martin Renvoize  ---
All excellent feedback, thanks for testing Caroline.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8838] Digest option for HOLD notice

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838

mspin...@clamsnet.org changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771

Lucas Gass  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771

--- Comment #1 from Lucas Gass  ---
Created attachment 151429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151429=edit
Bug 33771: Fix markup errors in orderreceive.tt

This patch fixed the following on orderreceive.tt:

-One of the  is closed with a 
-The #jobpanel element div is not properly closed
-Style tags are in the HTML body and they should be in the HTML head
-The #modal-order-main needs a class of 'row', this has been added.

Apply the pacth and follow the steps in 8179 until you get to the
orderreceive.tt. There should be no visual changes but the markup has been
corrected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766

--- Comment #6 from Laura Escamilla  ---
(In reply to Katrin Fischer from comment #5)
> Sorry, but have to veto here: we picked login on purpose as Koha accepts
> both, the username and the cardnumber. So login was the best fit we found
> that was not indicating one or the other only.

Maybe we can update it to "Login ID"? That way patrons will understand that
it's intended to be a username/cardnumber field and not the Login button
itself?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8179] Receiving multiple order lines at once

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

Lucas Gass  changed:

   What|Removed |Added

 Blocks||33771


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771
[Bug 33771] Markup errors on orderreceive.tt after 8179
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33771] Markup errors on orderreceive.tt after 8179

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771

Lucas Gass  changed:

   What|Removed |Added

 Depends on||8179
   Severity|enhancement |normal


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179
[Bug 8179] Receiving multiple order lines at once
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33771] New: Markup errors on orderreceive.tt after 8179

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33771

Bug ID: 33771
   Summary: Markup errors on orderreceive.tt after 8179
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: lu...@bywatersolutions.com
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

I am opening this bug to address so HTML markup errors on orderreceive.tt.

-One of the  is closed with a 
-The #jobpanel element div is not properly closed 
-Style tags are in the HTML body and they should be in the HTML head 
-The following is invalid

-


It should be:

+

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||Laura.escamilla@bywatersolu
   ||tions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #151383|0   |1
is obsolete||

--- Comment #7 from ByWater Sandboxes  ---
Created attachment 151428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151428=edit
Bug 33639: Fix selectors for adding to item group

To test:
Apply patch
1 - Browse to details page for a record
2 - Create or ensure the record has item group(s)
3 - Click New->New item
4 - Note the bottom of the page has a form to attach to existing group
5 - Note when a group is selected the enumchron field is populated if it is
blank
6 - Note that the enumchron field is NOT update is there is a an existing value
7 - Confirm item is saved to group when saved

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766

--- Comment #5 from Katrin Fischer  ---
Sorry, but have to veto here: we picked login on purpose as Koha accepts both,
the username and the cardnumber. So login was the best fit we found that was
not indicating one or the other only.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #151416|0   |1
is obsolete||

--- Comment #4 from ByWater Sandboxes  ---
Created attachment 151427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151427=edit
Bug 33766: Fix ambiguous "Login" field

This patch changes the use of "Login" to "Username" to assist with screen
reading

Test plan:
1) On the OPAC homepage, click on Lists in the top left
2) Click Log in to create your own lists
3) The login form should have the first field labelled as Username, not Login

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33766] Accessibility: Fix ambiguous form-field in opac-auth.tt

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33766

Laura Escamilla  changed:

   What|Removed |Added

 CC||Laura.escamilla@bywatersolu
   ||tions.com

--- Comment #3 from Laura Escamilla  ---
(In reply to Owen Leonard from comment #2)
> (In reply to Matt Blenkinsop from comment #0)
> > has been flagged as non-compliant in an accessibility report
> > carried out for the British Museum.
> 
> What is problematic screen reader behavior? It seems wrong to me that the
> screen reader should care what name or id the field has as long as it has an
> associated label.

It's not so much an issue with the screen reader device, but with the patrons
using the device to login into our Opac. Since the field is currently named
"Login" it might confuse patrons using the screen reader since they might not
understand that it is the "Username" field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32173] Add count of total titles in list to staff interface

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32173

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add count of total titles   |Add count of total titles
   |in list to staff client |in list to staff interface
   |view|
  Component|Staff interface |Lists
 CC||m.de.r...@rijksmuseum.nl
  Text to go in the||With this the number of
  release notes||entries on a list will show
   ||in the detail page of a
   ||list in the staff
   ||interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30624] Add a permission to control the ability to change the logged in library

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30624

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This enhancement adds a new |This enhancement adds a new
  release notes|permission, |`loggedinlibrary`
   |loggedinlibrary, to allow   |permission to allow or
   |or prevent staff members to |prevent staff members to
   |set the library where they  |set the library where they
   |log in. |log in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33607] Show framework on record details page

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33607

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the||With this patch the MARC
  release notes||framework shows at the end
   ||of the bibliographic
   ||description on the catalog
   ||detail page in the staff
   ||interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|release-notes-needed|
  Text to go in the||We have been able to define
  release notes||SMTP servers in the staff
   ||interface for a while now.
   ||But to utilize them you had
   ||to set the SMTP server for
   ||each library individually.
   ||With this you can now chose
   ||to apply an SMTP server as
   ||default to all your
   ||libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33758] Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758

Nicolas Giraud  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33758] Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758

Nicolas Giraud  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33758] Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758

--- Comment #1 from Nicolas Giraud  ---
Created attachment 151426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151426=edit
Bug 33758 - Add a parameter to use the
intranet_catalog_biblio_enhancements_toolbar_button Plugin hook

This patch adds a parameter to call the method
intranet_catalog_biblio_enhancements_toolbar_button with a biblionumber in the
page catalogue/detail.pl.

Modification of cat-toolbar.inc to display new buttons correctly.

To test :
1. Apply the patch
2. Take a plugin who implements the method
intranet_catalog_biblio_enhancements_toolbar_button
3. Check if the parameter "biblionumber" is passed correctly at this method
4. Create the new button in HTML in the plugin method
(button must be like the ones that are in the toolbar of the page detail.pl)
5. Go to the page in browser and check if the new button is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 27775] Add hint about drag and drop feature on framework subfield edit

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the||The sequence subfields
  release notes||appear when cataloguing
   ||bibliographic records,
   ||auhority records or items
   ||can be changed for each
   ||framework. To make this
   ||feature more visible a note
   ||was added to the framework
   ||administration page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33765] Accessibility: Fix ambiguous form-field in opac-main.tt

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765

Laura Escamilla  changed:

   What|Removed |Added

 CC||Laura.escamilla@bywatersolu
   ||tions.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33765] Accessibility: Fix ambiguous form-field in opac-main.tt

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33765

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #151415|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 151425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151425=edit
Bug 33765: Fix ambiguous "Login" field

This patch changes the use of "Login" to "Username" to assist with screen
reading

Test plan:
1) On the OPAC main page, the log in form should now have the first field
labelled as Username, not Login

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29002] Add ability to book items ahead of time

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #28 from Caroline Cyr La Rose  ---
Ok I tested this and it's very interesting! Especially for schools. However,
I'm not sure it's ready for release yet... Here are my conmments, and I
apologize, I know there's a lot... I tried to separate into actual bugs vs
comments.
I tested in the sandbox provided.

Bugs:

-  The patron search doesn't work in the modal when you click the Place booking
button when in "Item" tab https://snipboard.io/EDpzBr.jpg

-  When you click on the Bookings tab, MARC and ISBD view disapears. 

-  In the bookings tab, the months appear in french (in the sandbox, which I
assume only has english installed). https://snipboard.io/fCPapt.jpg Does it
take the language from my computer? My Ubuntu is in English, and so is my
Chrome...

-  It seems the next day after a booking is not available? Also the calendar
view and the table don't show the same dates.
   To recreate:
   1. Click Place booking
   2. Place a booking for two days, for example May 22 and 23
   3. Click Place booking again for the same item
  --> Note that 22, 23 and 24 are greyed out
   4. Place the booking for May 25-26
   5. In the bookings tab, move the second booking to May 24-25
  --> It worked
   6. In the table, the dates are not updated
  --> First booking in the calendar is 22-23, in the table it's 22-24
  --> The second booking (the one that was moved) in the calendar is 24-25,
in the table it's 25-27

-  If you checkout early to the correct patron, the due date is still the start
of the booking?
   To recreate:
   1. Place a booking for a couple days in the future, for example May 22-23
   2. Attempt to check out to the same patron
   3. Confirm early collection
   4. Click Show checkotus
  --> Due date is May 22

Usability comments:

-  The patron search is not the same as elsewhere. I don't mind this version
but for usability I think it would be best to have the same search everywhere.
   (Summary of IRC discussions 
   - Martin said the traditional search doesn't work well with modals
   - Katrin said the traditional search works better for large datasets, so you
can limit by library or category
   - Martin said he'd work on a middle ground)
   Maybe an alternative would be to make it work like the holds, i.e. send to a
page with the form, the calendar and the table...

-  I didn't catch right away that you had to choose two dates. It's nifty once
you know, but elsewhere in Koha there are two field "From:" and "To:".

-  Will it eventually be possible to limit the number of days a patron can book
for? Right now, a patron can hog an item for a very long time... I know you
said circulation rules will be added later, is that what you meant?

-  The Holds tab shows how many holds there are, maybe the bookings tab should
show if there are bookings and how many?

-  In the bookings tab, the calendar shows the booking id (?). This id is not
displayed in the table, so it's not very clear what it refers to. I think it
would be better to show the patron's name and cardnumber. Maybe with a hover
display for short bookings.

-  The calendar should show a fixed number of days. Right now it tries to adapt
to the bookings, but if you have a long one or one in the far future, it's all
scrunched up https://snipboard.io/5Acelp.jpg I think the next 30 days is
sufficient, and we can scroll as needed.

-  In the bookings tab, in the table, not sure why there is a search box for
the Actions columns...

-  I would also like the patron's name to have their cardnumber, and maybe a
link to their file like in the Holds tab

-  Not sure how I triggered the "It worked" message
https://snipboard.io/0KNJzp.jpg I think it was by moving a booking around in
the calendar, but I also got it while scrolling in the calendar (although I
think the latter was a belated message for the former)
   If it was for updating a booking, it could say "Booking updated".

-  Bookings are not shown in the patron file?

Maybe for later versions...

Maybe in a later version, but it would be nice to be able to choose a period
within a day. For example, I have a class from 8 to 12 for which I need some
special equipment. I could book the equipment for those hours only and someone
else could have it in the afternoon.

Another nice to have would be to be able to book recurrently. If I have my
class every Tuesday from september to december, I could book the equipment
"every tuesday" or "every other tuesday", etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org

[Koha-bugs] [Bug 33764] Accessibility: Fix ambiguous form-field in masthead.inc

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764

Laura Escamilla  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||Laura.escamilla@bywatersolu
   ||tions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33764] Accessibility: Fix ambiguous form-field in masthead.inc

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33764

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #151412|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 151424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151424=edit
Bug 33764: Fix ambiguous "Login" field

This patch changes the use of "Login" to "Username" to assist with screen
reading

Test plan:
1) In the masthead, click Log in to your account
2) On the modal, the first input should be labelled Username

Signed-off-by: Laura Escamilla 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||33770


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33770
[Bug 33770] Rephrase note on advanced search for IncludeSeeFromInSearches
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33770] New: Rephrase note on advanced search for IncludeSeeFromInSearches

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33770

Bug ID: 33770
   Summary: Rephrase note on advanced search for
IncludeSeeFromInSearches
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
Depends on: 31338

It currently reads:
 See from (non-preferred form) headings are included 

I feel that this could be more user friendly, maybe talking about alternative
name forms, spelling and pseudonnyms?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338
[Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31338] Show in advanced search when IncludeSeeFromInSearches is used

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31338

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the||When
  release notes||`IncludeSeeFromInSearches`
   ||is activated, there will be
   ||a note below the first
   ||search form on the advanced
   ||search in staff interface
   ||and OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved'

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769

--- Comment #3 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33769] Terminology: 'Warning: Item {barcode} is reserved'

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33769

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress"

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046

--- Comment #32 from Tomás Cohen Arazi  ---
Pushed to master for 23.05.

Nice work everyone, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29046] Allow libraries to specify email order for "AutoEmailPrimaryAddress"

2023-05-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29046

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Version(s)||23.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >