[Koha-bugs] [Bug 33880] "Enable two-factor authentication" fails if patron's library branchname is too long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33880 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33884] Remove unused Koha::RDF code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33884 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26700] Remove unused C4/SIP/t directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33702] Patrons should only see their own ILLs in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33702 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33702] Patrons should only see their own ILLs in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33702 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33702] Patrons should only see their own ILLs in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33702 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33702] Patrons should only see their own ILLs in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33702 Jonathan Druart changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33702] Patrons should only see their own ILLs in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33702 Jonathan Druart changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33702] Patrons should only see their own ILLs in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33702 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_11_candidate,| |rel_22_05_candidate,| |rel_22_11_candidate,| |rel_23_05_candidate | --- Comment #18 from Jonathan Druart --- Still missing in 21.05 then? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33702] Patrons should only see their own ILLs in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33702 Jonathan Druart changed: What|Removed |Added Resolution|--- |FIXED Version(s)|22.11.06,22.05.13 |23.05.00,22.11.06,22.05.13, released in||21.11.21 Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33884] Remove unused Koha::RDF code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33884 Jonathan Druart changed: What|Removed |Added Attachment #151959|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 151967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151967=edit Bug 33884: Remove unused Koha::RDF code This patch removes the unused Koha::RDF module and its associated unit test. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33884] Remove unused Koha::RDF code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33884 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33880] "Enable two-factor authentication" fails if patron's library branchname is too long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33880 --- Comment #1 from Jonathan Druart --- What about using branchcode instead of branchname? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26700] Remove unused C4/SIP/t directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 --- Comment #6 from Jonathan Druart --- Created attachment 151966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151966=edit Bug 26700: Remove occurrences in Makefile.PL As well as other 2 non existing paths -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26700] Remove unused C4/SIP/t directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 Jonathan Druart changed: What|Removed |Added Attachment #151960|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 151965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151965=edit Bug 26700: Remove unused C4/SIP/t directory This patch removes the unused C4/SIP/t directory. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26700] Remove unused C4/SIP/t directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32402] "Modification date" missing from OPAC lists table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32402 --- Comment #8 from David Cook --- (In reply to Tomás Cohen Arazi from comment #5) > Please rebase ASAP. Took the liberty of moving it back to "Passed QA" as it was a fairly trivial rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32402] "Modification date" missing from OPAC lists table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32402 David Cook changed: What|Removed |Added Attachment #144764|0 |1 is obsolete|| --- Comment #7 from David Cook --- Created attachment 151964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151964=edit Bug 32402: Add "Modification date" to OPAC Lists table This change adds a "Modification date" column to the OPAC Lists table, so that you can see when a list was last modified. Test plan: 1. Apply patch 2. Create a public list and a private list 3. Go to http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=list=1 4. Note that "Modification date" appears in the relevant date format on both the "Your lists" and "Public lists" tabs Signed-off-by: David Nind Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32402] "Modification date" missing from OPAC lists table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32402 David Cook changed: What|Removed |Added Attachment #151963|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32402] "Modification date" missing from OPAC lists table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32402 David Cook changed: What|Removed |Added Attachment #144764|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32402] "Modification date" missing from OPAC lists table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32402 David Cook changed: What|Removed |Added Attachment #144764|0 |1 is obsolete|| --- Comment #6 from David Cook --- Created attachment 151963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151963=edit Bug 32402: Add "Modification date" to OPAC Lists table This change adds a "Modification date" column to the OPAC Lists table, so that you can see when a list was last modified. Test plan: 1. Apply patch 2. Create a public list and a private list 3. Go to http://localhost:8080/cgi-bin/koha/opac-shelves.pl?op=list=1 4. Note that "Modification date" appears in the relevant date format on both the "Your lists" and "Public lists" tabs Signed-off-by: David Nind Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32402] "Modification date" missing from OPAC lists table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32402 David Cook changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31050] Standardize session setup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31050 David Cook changed: What|Removed |Added Status|RESOLVED|REOPENED Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun ||ity.org Resolution|DUPLICATE |--- --- Comment #8 from David Cook --- Then again... C4::Auth::create_basic_session() is only used for the OIDC auth, so I guess we still do have a ways to go... But I don't think I'll be working on it any time soon. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32178] query parameters in check_api_auth lets anyone assume a user id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32178 --- Comment #23 from David Cook --- *** Bug 31050 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31050] Standardize session setup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31050 David Cook changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #7 from David Cook --- Bug 32178 implements enough of the functionality to close out this one I think *** This bug has been marked as a duplicate of bug 32178 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33832] Can't change a patron's username without entering passwords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33832 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- Should we perhaps change this script so that it just changes the password and doesn't affect the username? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23817] Normalize phone number when searching patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 --- Comment #26 from David Cook --- Created attachment 151962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151962=edit Bug 23817: Include all phone numbers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23817] Normalize phone number when searching patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 --- Comment #25 from David Cook --- Created attachment 151961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151961=edit Bug 23817: Normalize phone number when searching This patch rewrites the phone number DBIC query when sent from DataTables like in the Patron module. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify=circ=51 2. Input '1-(234)-567-8901' into the 'Primary phone' field 3. Note on the next screen the phone number is shown as '1-(234)-567-8901' 4. Go to http://localhost:8081/cgi-bin/koha/members/members-home.pl 5. Choose "Search field" of "All phones" 6. Search for '12345678901' 7. Note you are taken to http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 8. Try out different permutations like '234 567 8901' or '5678901' 9. Note that every permutation works to find the borrower -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23817] Normalize phone number when searching patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23817 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9842] SIP tests : fix for 07hold.t on Cancel Hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9842 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #4) > I am not sure how to set up the config files in order to make these tests > pass (or not). Could someone else confirm if they are still failing or not > maybe? I don't know if anyone even uses them anymore. In Bug 26700, I propose that we remove them. If someone is using them, they need to move them into the t/ directory I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26700] Remove unused C4/SIP/t directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 --- Comment #4 from David Cook --- Created attachment 151960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151960=edit Bug 26700: Remove unused C4/SIP/t directory This patch removes the unused C4/SIP/t directory. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26700] Remove unused C4/SIP/t directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33884] Remove unused Koha::RDF code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33884 --- Comment #1 from David Cook --- Created attachment 151959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151959=edit Bug 33884: Remove unused Koha::RDF code This patch removes the unused Koha::RDF module and its associated unit test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33884] Remove unused Koha::RDF code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33884 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18586] Create module to mint RDF subject URIs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 David Cook changed: What|Removed |Added Blocks||33884 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33884 [Bug 33884] Remove unused Koha::RDF code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33884] Remove unused Koha::RDF code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33884 David Cook changed: What|Removed |Added Depends on||18586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18586 [Bug 18586] Create module to mint RDF subject URIs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21359] Add RDF support to OAI-PMH harvester
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21359 Bug 21359 depends on bug 18713, which changed state. Bug 18713 Summary: Add support for named graphs and rfds:seeAlso to Koha::RDF https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18713] Add support for named graphs and rfds:seeAlso to Koha::RDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18713 David Cook changed: What|Removed |Added Resolution|--- |INVALID Status|In Discussion |RESOLVED --- Comment #36 from David Cook --- Going to remove Koha::RDF. Future RDF work can be based off something else. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33884] New: Remove unused Koha::RDF code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33884 Bug ID: 33884 Summary: Remove unused Koha::RDF code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl The Koha::RDF code was added with the hope that further RDF work would proceed, but it never did. I think it makes sense to remove this unused code. The REST API could be used in lieu of this anyway. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21098] Add missing budget optgroups to parcels.tt and newemptyorder.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21098 --- Comment #15 from David Cook --- Still relevant but I think the failure is still relevant too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26248] Simplify keep_text Javascript function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26248 David Cook changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #11 from David Cook --- I don't recall why I cared about this in the first place... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28477] INTRANET and OPAC loggers should print to STDERR instead of to file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28477 David Cook changed: What|Removed |Added Resolution|--- |INVALID Status|In Discussion |RESOLVED --- Comment #8 from David Cook --- Koha has changed its Plack logging since this was reported -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33167] Cleanup staff interface catalog details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33167 --- Comment #30 from Mason James --- (In reply to Barry Cannon from comment #29) > I am still seeing this error, even after upgrading to 22.11.06-3. hi Barry can you paste your error message? it should be different from above also try rebuilding your languages, with koha-translate tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33780] Multi-line TT comment: [%% item.object.itemnotes.replace('\n', '
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33780 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au Status|Signed Off |Failed QA --- Comment #8 from David Cook --- The effect of the patch is different to the issue description. Note that before the patch, you could include HTML in the item note field. After the patch, the HTML is escaped. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32341] Some OPAC tables are not displayed well in mobile mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 --- Comment #26 from David Cook --- Oh looks like I can't QA this one, but it's a very useful one... would be great to get this done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33803] Some scripts contain info about tab width
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33803 David Cook changed: What|Removed |Added Attachment #151596|0 |1 is obsolete|| --- Comment #3 from David Cook --- Created attachment 151958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151958=edit Bug 33803: Remove comment about tab width Signed-off-by: Owen Leonard Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33803] Some scripts contain info about tab width
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33803 David Cook changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33859] Use the phrase 'Identity providers' instead of 'Authentication providers'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 David Cook changed: What|Removed |Added Attachment #151886|0 |1 is obsolete|| --- Comment #5 from David Cook --- Created attachment 151957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151957=edit Bug 33859: Use the phrase 'Identity providers' instead of 'Authentication providers' This patch updates instances in the code and templates where the term "Authentication providers" is used, replacing it with the preferred "Identity provider." Most of the instances of this change are in module or API documentation, but you can see a couple of the changes in the interface: - Administration -> Identity providers: - The sidebar menu should show "Identity providers" instead of "Authentication providers." - Patrons -> Patron details -> More -> Set permissions - Under " Manage Koha system settings (Administration panel)" you should see "Manage identity providers (manage_identity_providers)" Signed-off-by: Sam Lau Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33859] Use the phrase 'Identity providers' instead of 'Authentication providers'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33859 David Cook changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33875] Missing closing tag a in API key management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 David Cook changed: What|Removed |Added Attachment #151950|0 |1 is obsolete|| --- Comment #4 from David Cook --- Created attachment 151956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151956=edit Bug 33875: Fix missing closing tag a in API key management page In API key management page, anchor closing tag is missing in message "No keys defined for the current patron". This patch fixes that. Also changes display with link on a new line. Translatable text is on purpose surrounded by span or div. Test plan : 1) Enable system preference RESTOAuth2ClientCredentials 2) Go to a patron page 3) Click More > Manage API Keys 4) Look at page source HTML code => Check code is OK Signed-off-by: Sam Lau Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33875] Missing closing tag a in API key management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 David Cook changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33883] "Make sure to copy your API secret" message overlaps text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33875 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33875] Missing closing tag a in API key management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33883 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33883] New: "Make sure to copy your API secret" message overlaps text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33883 Bug ID: 33883 Summary: "Make sure to copy your API secret" message overlaps text Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org After you generate an API key for a patron, the grey border around the message "Make sure to copy your API secret now. You won’t be able to see it again!" overlaps the "Description: " text below it. It's hard to see but it does look bad when you notice it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33702] Patrons should only see their own ILLs in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33702 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #17 from Mason James --- (In reply to Lucas Gass from comment #16) > Backported to 22.05.x for 22.05.13 hi team, all 3 following packages include the 3x 33702 patches 22.11.06 22.05.13 21.11.21 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 David Nind changed: What|Removed |Added Text to go in the||This fixes the export of release notes||inventory results when ||"Check barcodes list for ||items shelved out of order" ||is selected. Currently, the ||problem column is blank for ||items shelved out of order ||when it should be "Shelved ||out of order". CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 David Nind changed: What|Removed |Added Attachment #151779|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 151955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151955=edit Bug 22135: Display 'shelved out of order' error in inventory CSV export When using the inventory tool with an uploaded barcode file and checking the "Compare barcodes list to results", "Check barcodes list for items shelved out of order" and "Export to CSV file" checkboxes, the resulting CSV file showed a blank in the "problem" column for items with out of order callnumbers. With this patch, you'll see "Shelved out of order". To test: * Create 3 items with callnumbers and barcodes a, b, and c * Go to Cataloguing > Inventory * Enter a c b (each on its own line) into the barcode field * Check "Compare barcodes list to results" * Check "Check barcodes list for items shelved out of order" * Check "Export to CSV file" (at the bottom) * Verify the file has empty lines in the problem column * Apply patch * Repeat test, the empty lines should now read: "Shelved out of order" Note: Also fixes "problem" to "Problem" to make capitalization consistent. All those strings are currently not translatable, this will be filed separately. Co-authored-by: Mark Alexander Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22135] Inventory tool doesn't export "out of order" problem to CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22135 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33882] member.tt Date of birth column makes it difficult to hide the age hint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33882
Sam Lau changed:
What|Removed |Added
Attachment #151953|0 |1
is obsolete||
--- Comment #2 from Sam Lau ---
Created attachment 151954
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151954=edit
Bug 33882: Add spans in dateofbirth column on member.tt
To test:
1 Apply patch
2 Do a patron search that will return multiple patrons.
3 Look at the date of birth column and notice the text is now wrapped in a
class called 'dateofbirth'
4. Notice that the age hint is wrapped in a class called 'agehint'.
5. Add '.agehint { display: none }' to intranetusercss.
6. Now notice the date of birth still displays but no age information.
Signed-off-by: Sam Lau
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33882] member.tt Date of birth column makes it difficult to hide the age hint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33882 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33757] Help manual link in Label Creator points to wrong place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33757 --- Comment #2 from Katrin Fischer --- Accidentally fixed by bug 33790 :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33790] Fix and add various links to the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33790 Katrin Fischer changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #5 from Katrin Fischer --- *** Bug 33757 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33757] Help manual link in Label Creator points to wrong place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33757 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Will be fixed by bug bug 33790 *** This bug has been marked as a duplicate of bug 33790 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22959] Using the help feature when in the Patron Category Admin page, should bring user to that section in the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22959 Katrin Fischer changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Tested in 23.05 and it's fixed :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15003] Help should be a wiki, not translatable via po-files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15003 Katrin Fischer changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Closing this one as the suggestions were based on the old help system that used templates in Koha. Remaining issues could be filed as new bugs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33882] member.tt Date of birth column makes it difficult to hide the age hint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33882 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch Severity|enhancement |minor Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33882] member.tt Date of birth column makes it difficult to hide the age hint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33882
--- Comment #1 from Lucas Gass ---
Created attachment 151953
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151953=edit
Bug 33882: Add spans in dateofbirth column on member.tt
To test:
1 Apply patch
2 Do a patron search that will return multiple patrons.
3 Look at the date of birth column and notice the text is now wrapped in a
class called 'dateofbirth'
4. Notice that the age hint is wrapped in a class called 'agehint'.
5. Add '.agehint { display: none }' to intranetusercss.
6. Now notice the date of birth still displays but no age information.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33882] member.tt Date of birth column makes it difficult to hide the age hint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33882 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33882] New: member.tt Date of birth column makes it difficult to hide the age hint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33882 Bug ID: 33882 Summary: member.tt Date of birth column makes it difficult to hide the age hint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When doing a patron search ( member.tt) there is a column for Date of Birth. That column also includes a hint about the age of the patron. Example: (67 years) Some libraries don't want to show information about the patron's age. Currently that info. is difficult to hide with CSS. If we wrapped it in an it would be much easier. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Sam Lau changed: What|Removed |Added CC||sama...@gmail.com Status|Needs Signoff |Failed QA --- Comment #38 from Sam Lau --- I'm in the process of testing this and so far shortening the loan period seems to be working for me, but extending the loan period isn't working as expected. Steps taken to replicate my issue 1) Set library opening time to 8:30am closing time to 9pm 2) set loan period to be 3 hours. 3) Set the "ConsiderLibraryHoursWhenIssuing" preference to the extend option. 4) checked out an item. My checkout time and date was 06/01/2023 19:07 - with the loan period I selected (3 hours), the book would be due on 06/01/2023 @ 22:07, but since the library closes at 9pm (21:00), the due date should be extended to the next day at opening time. 5) The shown due date is 06/03/2023 at 08:30 - The due date that was expected was 06/02/2023 at 08:30 so it skipped over a day for some reason. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33790] Fix and add various links to the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33790 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- Testing notes (using KTD): 1. I amended the patch (instead of adding a follow-up) for SMTP servers: 'admin/smtp-servers' should be 'admin/smtp_servers' (underscore instead of a dash in the URL). 2. I did try to see if the more specific URLs and links could be added for Cataloging > Tools > Label creator > Manage [Label batches|Layouts|Label templates|Printer profiles], as they each have their own section in the manual. However, the URLs for the specific manage options all start with 'label-manage.pl?label-element=', and there doesn't appear to be a way to map a page with a ? to a specific bookmark in the manual. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33790] Fix and add various links to the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33790 David Nind changed: What|Removed |Added Attachment #151790|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 151952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151952=edit Bug 33790: Fix and add various links to the manual * Makes the move from tools to cataloguing for the pages linked from the cataloguing start page * Adds missing help links to admin and tools pages * Fix other existing links To test: * Best is to look at the patch, you'll see the pages you need to test on the left. * Open the page and access the help page through the help link Note: for a few links you'll need to update the version in the URL to 23.05 (identity providers is one) as the page doesn't exist yet in the 22.11 manual Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33790] Fix and add various links to the manual
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33790 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33809] Accessibility: OPAC results page needs more descriptive links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33809 Ray Delahunty changed: What|Removed |Added CC||r.delahu...@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33786] ILL requests table pagination in patron ILL history is transposing for different patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33786 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #17 from Tomás Cohen Arazi --- This is missing a signature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 --- Comment #18 from Nick Clemens --- (In reply to Marcel de Rooy from comment #16) > (In reply to Marcel de Rooy from comment #15) > > > # Failed test 'Screen message includes related fines total' > > # at t/db_dependent/SIP/Patron.t line 331. > > # 'Greetings from Koha. Og_K_qe88A -- Patron blocked > > by fines (11.11) on guaranteed accounts -- Patron owes 11.00' > > # doesn't match '(?^u:Patron blocked by fines \(22\.22\) on > > guaranteed accounts)' > > If I debug on $patron->account->lines, I only see that 11 euro. > Do you miss a few assumptions in the mocking or so still? Yes, not setting the type meant it was randomly a type that was counted in non-issues-charges or not. Should be fixed now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33411] SIP2 includes other guarantees with the same guarantor when calculating against NoIssuesChargeGuarantees
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33411 --- Comment #17 from Nick Clemens --- Created attachment 151951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151951=edit Bug 33411: (follow-up) Set debit type for mocked fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33875] Missing closing tag a in API key management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Sam Lau changed: What|Removed |Added Attachment #151888|0 |1 is obsolete|| --- Comment #3 from Sam Lau --- Created attachment 151950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151950=edit Bug 33875: Fix missing closing tag a in API key management page In API key management page, anchor closing tag is missing in message "No keys defined for the current patron". This patch fixes that. Also changes display with link on a new line. Translatable text is on purpose surrounded by span or div. Test plan : 1) Enable system preference RESTOAuth2ClientCredentials 2) Go to a patron page 3) Click More > Manage API Keys 4) Look at page source HTML code => Check code is OK Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33875] Missing closing tag a in API key management page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33875 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33364] Stop Holds to Pull report showing items that have been allocated to a recall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33364 Sam Lau changed: What|Removed |Added CC||sama...@gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32011] 2FA - Problem with qr_code generation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011 Pedro Amorim changed: What|Removed |Added Blocks||33880 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33880 [Bug 33880] "Enable two-factor authentication" fails if patron's library branchname is too long -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33880] New: "Enable two-factor authentication" fails if patron's library branchname is too long
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33880 Bug ID: 33880 Summary: "Enable two-factor authentication" fails if patron's library branchname is too long Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org, jake.de...@ptfs-europe.com, jonathan.druart+k...@gmail.com, jonathan.fi...@ptfs-europe.com, m.de.r...@rijksmuseum.nl, martin.renvo...@ptfs-europe.com, ryan.hender...@ptfs-europe.com Depends on: 32011 To reproduce, on ktd: 1) Enable TwoFactorAuthentication system preference 2) Go to "Administration->Libraries" edit the library's name "Institut Protestant de Théologie" to "Institut Protestant de Théologie and another word" 3) Go to "My account" in the top right corner menu 4) Click the "Edit" button in the "Library use" box and set the library to the above library 5) Go back to "My account" and click "More" button, select "Manage two-factor authentication" 6) Click "Enable two-factor authentication" button 7) It explodes Error logs: [ERROR] POST /api/v1/auth/two-factor/registration: unhandled exception (Mojo::Exception)<> This is the same (or very similar) issue discussed in bug 32011 Bumping the version from 10 to something higher in GD::Barcode::new on Koha/Auth/TwoFactorAuth.pm works around this issue, but I think we should discuss and come up with a permanent solution. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32011 [Bug 32011] 2FA - Problem with qr_code generation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33702] Patrons should only see their own ILLs in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33702 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|22.11.06|22.11.06,22.05.13 released in|| --- Comment #16 from Lucas Gass --- Backported to 22.05.x for 22.05.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33876] item-note-nonpublic and item-note-public are difficult to customize in the checkout table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33876 Sam Lau changed: What|Removed |Added Attachment #151891|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 151949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151949=edit Bug 33876: Add class for styling To test: 1. Checkout and item that has a public and nonpublic note. 2. In the checkout table ( Title column ) notice the notes display. If you use the browser dev tools to inspect you'll notice a "-" outside of any HTML element. 3. Apply patch. 4. See the '-' is now inside of a html element with class of seperator. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33876] item-note-nonpublic and item-note-public are difficult to customize in the checkout table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33876 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Sam Lau changed: What|Removed |Added Attachment #151911|0 |1 is obsolete|| --- Comment #191 from Sam Lau --- Created attachment 151948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151948=edit Bug 17499: Replace Koha::MessageAttribute(s) with Koha::Patron::MessagePreference::Attribute(s) To test: 1. prove t/db_dependent/Illrequests.t 2. grep -rn 'Koha::MessageAttribute', observe no results in Koha code Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Sam Lau changed: What|Removed |Added Attachment #151910|0 |1 is obsolete|| --- Comment #190 from Sam Lau --- Created attachment 151947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151947=edit Bug 17499: (follow-up) Add $patron->messaging_preferences accessor To test: 1. prove t/db_dependent/Koha/Patron.t Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Sam Lau changed: What|Removed |Added Attachment #151909|0 |1 is obsolete|| --- Comment #189 from Sam Lau --- Created attachment 151946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151946=edit Bug 17499: (follow-up) Rename to Koha::Patron::MessagePreference Koha::Patron::Message refers to "messages" table that is used for circulation messages. MessagePreference now refers to a messaging preference that is used for enqueued notifications. To test: 1. prove t/db_dependent/Koha/Patron/MessagePreference/Attributes.t 2. prove t/db_dependent/Koha/Patron/MessagePreference/Transport/Preferences.t 3. prove t/db_dependent/Koha/Patron/MessagePreference/Transport/Types.t 4. prove t/db_dependent/Koha/Patron/MessagePreference/Transports.t 5. prove t/db_dependent/Koha/Patron/MessagePreferences.t Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Sam Lau changed: What|Removed |Added Attachment #151908|0 |1 is obsolete|| --- Comment #188 from Sam Lau --- Created attachment 151945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151945=edit Bug 17499: (follow-up) Contact information vs. mtt validation This patch adds a subroutine that handles message transport type validation by first checking related patron contact information. As an example, if there is no email address, we shouldn't let email be selected as a messaging transport type. The reason to isolate logic into a separate subroutine is that C4/Reserves.pm _koha_notify_reserve() also uses the same logic and we should not duplicate it. C4::Reserves::_koha_notify_reserve() will be adjusted to use this new sub in Bug 18595. To test: 1. prove t/db_dependent/Koha/Patron/Message/Preferences.t Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Sam Lau changed: What|Removed |Added Attachment #151907|0 |1 is obsolete|| --- Comment #187 from Sam Lau --- Created attachment 151944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151944=edit Bug 17499: (follow-up) Validate phone and itiva transport types Message transport types 'phone' and 'itiva' were not validated unlike 'email' and 'sms'. This patch adds equivalent checks to the missing mtts. To test: 1. prove t/db_dependent/Koha/Patron/Message/Preferences.t Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Sam Lau changed: What|Removed |Added Attachment #151906|0 |1 is obsolete|| --- Comment #186 from Sam Lau --- Created attachment 151943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151943=edit Bug 17499: (follow-up) Fix warning Fix warning DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single. Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Sam Lau changed: What|Removed |Added Attachment #151905|0 |1 is obsolete|| --- Comment #185 from Sam Lau --- Created attachment 151942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151942=edit Bug 17499: (follow-up) More explicit exceptions Adds and throws more detailed exceptions. This is useful for APIs and generating translatable errors in GUI. In short, replaces Koha::Exceptions::BadParameter with: Koha::Exceptions::Patron::NotFound Koha::Exceptions::Patron::Category Koha::Exceptions::Patron::Category::NotFound Koha::Exceptions::Patron::Message::Preference Koha::Exceptions::Patron::Message::Preference::AttributeNotFound Koha::Exceptions::Patron::Message::Preference::DaysInAdvanceOutOfRange Koha::Exceptions::Patron::Message::Preference::DaysInAdvanceNotAvailable Koha::Exceptions::Patron::Message::Preference::DigestNotAvailable Koha::Exceptions::Patron::Message::Preference::DigestRequired Koha::Exceptions::Patron::Message::Preference::EmailAddressRequired Koha::Exceptions::Patron::Message::Preference::NoTransportType Koha::Exceptions::Patron::Message::Preference::SMSNumberRequired To test: 1. prove t/db_dependent/Koha/Patron/Message/Preferences.t Sponsored-by: The National Library of Finland Signed-off-by: Michal Denar Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Sam Lau changed: What|Removed |Added Attachment #151904|0 |1 is obsolete|| --- Comment #184 from Sam Lau --- Created attachment 151941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151941=edit Bug 17499: (QA follow-up) Fix POD errors Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Sam Lau changed: What|Removed |Added Attachment #151903|0 |1 is obsolete|| --- Comment #183 from Sam Lau --- Created attachment 151940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151940=edit Bug 17499: (QA follow-up) Fix Licence Statements Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Sam Lau changed: What|Removed |Added Attachment #151902|0 |1 is obsolete|| --- Comment #182 from Sam Lau --- Created attachment 151939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151939=edit Bug 17499: Replace test subroutines with build_object This patch replaces subroutines used to build test objects with call to $builder->build_object. To test prove that tests are still running with: prove t/db_dependent/Koha/Patron/Message/* Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Sam Lau changed: What|Removed |Added Attachment #151901|0 |1 is obsolete|| --- Comment #181 from Sam Lau --- Created attachment 151938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151938=edit Bug 17499: Define koha_object(s)_class where needed This patch adds koha_object(s)_class for needed modules to fix issues with tests. Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499
Sam Lau changed:
What|Removed |Added
Attachment #151900|0 |1
is obsolete||
--- Comment #180 from Sam Lau ---
Created attachment 151937
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151937=edit
Bug 17499: Add Koha-objects for messaging preferences
This patch adds Koha-objects for messaging preferences.
Adds simple validation for messaging preferences.
The validation includes
- throw exception if both borrowernumber or categorycode is given for a new
pref
- throw exception if patron for the given borrowernumber is not found
- throw exception if category for the given categorycode is not found
- throw exception if days in advance cannot be configured but is given
- throw exception if days in advance configuration is invalid (value between
0-30)
- throw exception if digest is not available but attempted to set on
- throw exception if digest must be enabled but attempted to set off
- throw exception on duplicate messaging preference
Adds a method for getting available messaging options.
Adds a method for setting default messaging preferenes.
$patron->set_default_messaging_preferences (where $patron is a Koha::Patron)
...or...
Koha::Patron::Message::Preference->new_from_default({
borrowernumber => 123,
categorycode => "ABC",
message_attribute_id => 1,
});
Since messaging preference is a feature that has multiple related database
tables,
usage via Koha-objects is sometimes frustrating. This patch adds easy access to
message transport types via
$preference->message_transport_types (for
getting)
$preference->set({ message_transport_types => ['email', 'sms'] }) (for
setting)
(also supports other calling conventions, see documentation for more)
Adds optional parameter message_name for
Koha::Patron::Message::Preferences->find
and ->search. Simplifies the Koha-object usage by allowing developer to skip
joins
and / or querying the message name via attribute_id from message_attributes
table.
Includes test coverage for basic usage.
To test:
1. prove t/db_dependent/Koha/Patron/Message/*
Following Bug 17499, check also Bug 18595 that replaces C4::Members::Messaging
with these new Koha-objects.
Signed-off-by: Dominic Pichette
Signed-off-by: David Nind
Signed-off-by: Martin Renvoize
Signed-off-by: Katrin Fischer
Signed-off-by: Michal Denar
Signed-off-by: Sam Lau
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17499] Koha objects for messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33873] ILL requests with linked biblio_id that no longer exists causes table to not render
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33873 --- Comment #10 from Pedro Amorim --- (In reply to Katrin Fischer from comment #8) > I vote for removing the FK again OR cleaning up the old ill_requests... > either this data should not exist or it should. > > I vote for: it should exist and remove FK. And we could show the number not > linked when there is no record in the table. I don't see any issue with that, but again would like Martin and Tomas to chip in. However, the fix provided here in this bug (33873) is required, regardless of whatever decision we go down with regarding the FK. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22440] Improve ILL page performance by moving to server side filtering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #25 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #24) > (In reply to Katrin Fischer from comment #23) > > (In reply to Katrin Fischer from comment #22) > > > (In reply to Katrin Fischer from comment #19) > > > > Hm, I am not so happy about the FK change hidden/sneaked in with this > > > > bug. > > > > Especially since it's now without documentation/warning to users and can > > > > create data loss. > > > > > > > > If you don't store all information also in ILL request attributes it > > > > will be > > > > hard to determine what has been ordered for making acq decisions and > > > > creating reports. > > > > > > > > Also: there already was as specific bug for this change, stuck in > > > > discussion > > > > for these reasons: bug 21983 > > > > > > I'd have loved to at least get a comment/reaction. The fix mentioned seems > > > to be to enforce the change I marked as critical. > > > > Also, if you really want to do this, because it needs to be done: what's > > with the old ill_requests? It caused bug 33873. > > Should we do the same we did for orderlines? A database table has the option to use COALESCE, so that might be an option. We could also then shift the existing data. I am not sure what the technical requirement for the FK was, so can't tell if removing it again might be a valid option. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
