[Koha-bugs] [Bug 34276] upgrading 23.05 to 23.05.002
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34276 Jonathan Druart changed: What|Removed |Added Severity|enhancement |blocker CC||jonathan.druart+koha@gmail. ||com --- Comment #14 from Jonathan Druart --- Tomas, Pedro, can you take care of this one please? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34276] upgrading 23.05 to 23.05.002
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34276 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.druart+koha@gmail. |koha-b...@lists.koha-commun |com |ity.org QA Contact||testo...@bugs.koha-communit ||y.org Product|Project Infrastructure |Koha Component|Bugzilla|Installation and upgrade ||(command-line installer) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34276] upgrading 23.05 to 23.05.002
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34276 --- Comment #13 from Jonathan Druart --- *** Bug 34268 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34268] while updating from 23.05 to 23.05.02
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34268 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 34276 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34276] upgrading 23.05 to 23.05.002
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34276 --- Comment #12 from SOS --- My query got resolved through ChatGPT instructions, kindly copy-paste the error and ask for solution, it will guide tofurther steps. Maybe it will ask you to drop Foreign key. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33645] koha-foreach always returns 1 if --chdir not specified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33645 Danyon Sewell changed: What|Removed |Added CC||danyonsew...@catalyst.net.n ||z Version(s)|23.05.00,22.11.06,22.05.14 |23.05.00,22.11.06,22.05.14, released in||21.11.22 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #7 from Danyon Sewell --- Backported to 21.11.x for upcoming 21.11.22. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33196] Terminology: rephrase Pseudonymization system preference to be more general
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33196 Danyon Sewell changed: What|Removed |Added CC||danyonsew...@catalyst.net.n ||z Version(s)|23.05.00,22.11.06,22.05.14 |23.05.00,22.11.06,22.05.14, released in||21.11.22 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #9 from Danyon Sewell --- Backported to 21.11.x for upcoming 21.11.22. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31405] Set focus for cursor to setSpec input when adding a new OAI set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31405 Danyon Sewell changed: What|Removed |Added CC||danyonsew...@catalyst.net.n ||z Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.06,22.05.14 |23.05.00,22.11.06,22.05.14, released in||21.11.22 --- Comment #12 from Danyon Sewell --- Backported to 21.11.x for upcoming 21.11.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34335] Run Koha plugin method from CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335
David Cook changed:
What|Removed |Added
Attachment #153747|0 |1
is obsolete||
--- Comment #6 from David Cook ---
Created attachment 153749
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153749=edit
Bug 34335: Add a script to run Koha plugin methods from the CLI
This change adds a script which allows you to run a method from
a Koha plugin.
Test plan:
0. Apply patch
1. Upload test plugin
2. Run the following:
perl misc/run_koha_plugin.pl --class
Koha::Plugin::Prosentient::CustomMethodPlugin \
--method awesome_method --params '{"msg": "this is awesome"}'
3. Note the following CLI messages:
This is a custom method that you're seeing on the CLI!
We got a message: this is awesome
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34335] Run Koha plugin method from CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335 --- Comment #5 from David Cook --- Created attachment 153748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153748=edit test plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34335] Run Koha plugin method from CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335
David Cook changed:
What|Removed |Added
Attachment #153746|0 |1
is obsolete||
--- Comment #4 from David Cook ---
Created attachment 153747
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153747=edit
Bug 34335: Add a script to run Koha plugin methods from the CLI
This change adds a script which allows you to run a method from
a Koha plugin.
Test plan:
0. Apply patch
1. Upload test plugin
2. Run the following:
perl misc/run_koha_plugin.pl --class
Koha::Plugin::Prosentient::CustomMethodPlugin \
--method awesome_method --params '{"msg": "this is awesome"}'
3. Note the following CLI messages:
This is a custom method that you're seeing on the CLI!
We got a message: this is awesome
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34335] Run Koha plugin method from CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335 --- Comment #3 from David Cook --- It might be nice to be able to handle method parameters as well... maybe I'll have a little look at that... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34335] Run Koha plugin method from CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335 --- Comment #2 from David Cook --- Created attachment 153746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153746=edit Bug 34335: Add a script to run Koha plugin methods from the CLI This change adds a script which allows you to run a method from a Koha plugin. Test plan: 0. Apply patch 1. Upload test plugin 2. Run the following: perl misc/run_koha_plugin.pl --class Koha::Plugin::Prosentient::CustomMethodPlugin --method awesome_method 3. Note the following CLI message: This is a custom method that you're seeing on the CLI! at /var/lib/koha/kohadev/plugins/Koha/Plugin/Prosentient/CustomMethodPlugin.pm line 42. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34335] Run Koha plugin method from CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34335] Run Koha plugin method from CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335 --- Comment #1 from David Cook --- *** Bug 26169 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26169] Run plugins from the CLI / as a script
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26169 David Cook changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from David Cook --- *** This bug has been marked as a duplicate of bug 34335 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34335] Run Koha plugin method from CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34335] New: Run Koha plugin method from CLI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34335 Bug ID: 34335 Summary: Run Koha plugin method from CLI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org There are times where it would be nice to run a Koha plugin method from the CLI. This can actually be achieved with very little code thanks to Koha::Plugins::Handler->run(). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30745] ES : Search never return result using after-date and/or before-date in labels/label-item-search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30745 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #12 from Fridolin Somers --- Patches need rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34333] Add cancellation request information embed option to the holds endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34333 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 153745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153745=edit Bug 34333: Add embed option for `cancellation_requested` for holds This patch adds the `cancellation_requested` attribute to the hold object definition, and allows embeding it as on the different holds endpoints that migt be useful. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t \ t/db_dependent/api/v1/*holds.t => SUCCESS: Tests pass! 3. Play with your REST tool (Postman?) on the following endpoints: GET http://localhost:8081/api/v1/holds GET http://localhost:8081/api/v1/patrons/:patron_id/holds on both, pass and not pass the `x-koha-embed` header with `cancellation_requested` on it. => SUCCESS: It is easy! You see the attribute and you don't, and the content makes sense! 4. Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34333] Add cancellation request information embed option to the holds endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34333 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 153744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153744=edit Bug 34333: Add Koha::Hold->cancellation_requested This patch adds a helper method for telling if a hold has cancellation requests. To be used for embedding such information. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: Tests pass, the new method is covered by tests. 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34333] Add cancellation request information embed option to the holds endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34333 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31652] Add geo-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652
--- Comment #5 from David Cook ---
Comment on attachment 153720
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153720
Bug 31652: Add geo-search
Review of attachment 153720:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=31652=153720)
-
::: Koha/SearchEngine/Elasticsearch/Indexer.pm
@@ +117,4 @@
> }
>
> my $documents = $self->marc_records_to_documents($records);
> +
It looks like this file might not be altered beyond whitespace? Looks like the
whitespace change could be removed to simplify the overall patch.
::: Koha/SearchEngine/Elasticsearch/Search.pm
@@ +93,5 @@
> my $elasticsearch = $self->get_elasticsearch();
> +
> +# XXX investigate where empty query_string is coming from
> +delete $query->{query}->{query_string} if
> + $query->{query}->{query_string} && !%{$query->{query}->{query_string}};
Is this a pre-existing problem or introduced in this patch?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33964] Use Email::Sender::Transport::SMTP::Persistent for sending email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33964 --- Comment #17 from David Cook --- (In reply to Marcel de Rooy from comment #15) > I was still looking for some kind of confirmation that it really works as > advertised using one connection. You can use tcpdump to watch the SMTP port. I've set messaging preferences for check in and check out and generated 2 pending emails. I then manually run ./misc/cronjobs/process_message_queue.pl Without the patch, I'm seeing 2 different TCP connections (one for each email). With the patch, I'm seeing only 1 TCP connection and both emails go out. Looks good to me. Looking forward to this one going in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34333] Add cancellation request information embed option to the holds endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34333 Tomás Cohen Arazi changed: What|Removed |Added Summary|Add cancellation requests |Add cancellation request |count embed option to the |information embed option to |holds endpoint |the holds endpoint -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20252] If an EDI orderline is cancelled send a cancellation message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20252 Rhonda Kuiper changed: What|Removed |Added CC||rkui...@roundrocktexas.gov --- Comment #1 from Rhonda Kuiper --- This would be fantastic function to have for EDI ordering -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20454] Suspend Holds if patron wouldn't be able to check items out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20454 Wally DesChamps changed: What|Removed |Added CC||wdescha...@prospertx.gov --- Comment #2 from Wally DesChamps --- I agree with the system preference and/or toggle in an alert box. I'd even settle for a RED alert line in the hold pop-up box and in the Holds queue listing that alerted that the account has a "flag" of some kind before we invest time to search the library to pull the hold and potentially "confirm" the hold notifying the patron they have a hold they can't have...which takes it out of circulation if even briefly. For smaller libraries that have limited staff and limited copies of items, this is huge. Scenarios (especially for smaller libraries): 1) Patron has maxed out their check-out limit, or they have overdue items, fines, or card will expire prior to the standard loan period, the system would not recognize the hold as available for that patron until all circ rules are met; i.e., we would not even see their hold in queue until their account had room or was "in good standing" again. 2) If #1 occurred and the item had multiple holds, the system would poll the accounts in the holds list (in order) and "process" the hold of the first account that meets circ rule eligibility. The idea is that the hold is not "suspended" to a specific date (like we would manually), but would be "suspended" in the background until the account meets the criteria to allow the hold and check-out of that item to occur. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34334] Item(s) in MARCdetail untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 --- Comment #1 from Caroline Cyr La Rose --- I tried adding a span tag around the word in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt (line 146), but it's still not picking it up... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34334] New: Item(s) in MARCdetail untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34334 Bug ID: 34334 Summary: Item(s) in MARCdetail untranslatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr I'm trying to find the string Item(s) for the items tab in the MARC view in the staff interface and it doesn't look like it's in the po files anymore. To get there: 1. View any record in the staff interface 2. Click "MARC" on the left --> Item(s) tab 3. Install new language 3.1. Run the following commands in the terminal (replace fr-CA by any language code) cd misc/translator ./translate install fr-CA 3.2. In the staff interface, go to Administration > System preferences 3.3. Search for language 3.4. Check the box for the new language 3.5. Click Save all I18N//L10N preferences 4. Switch the staff interface to the new language 5. Refresh the MARC view page --> Item(s) tab still in English 6. In the terminal, search the .po files for the "Item(s)" string --> String not in the files -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34332] Syntax error in Point of Sale email template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34332 Laura Escamilla changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #2 from Laura Escamilla --- Temporarily removing "Needs signoff" status for further testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34076] [ALTERNATE] [DOCS] Automated screenshots using Cypress.io testing framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34076 --- Comment #18 from Caroline Cyr La Rose --- I redid step 5 after removing all the additional languages in my Koha and they were all green! I don't remember exactly which command ended up working, but I think it was git clean -fxd -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31787] [DOCS] Add description and examples to membership_expiry.pl about --where option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31787 Marie-Luce Laflamme changed: What|Removed |Added Assignee|da...@davidnind.com |marie-luce.laflamme@inlibro ||.com --- Comment #3 from Marie-Luce Laflamme --- I've added the info in the manual - merge request pending -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32890] Add DataTables to curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32890 --- Comment #3 from Caroline Cyr La Rose --- Much better! Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32890] Add DataTables to curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32890 Caroline Cyr La Rose changed: What|Removed |Added Attachment #153740|0 |1 is obsolete|| --- Comment #2 from Caroline Cyr La Rose --- Created attachment 153743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153743=edit Bug 32890: Add DataTables to curbside pickups This patch modifies the curbside pickups page in the staff interface so that each table is a DataTable with configurable columns. The patch also replaces the patron name output with patron-title.inc for consistency and to display names 'surname, firstname' for correct column sorting. To test, apply the patch and restart services. - Enable the CurbsidePickup system preference if necessary. - Properly testing requires testing data. You can run this command to REPLACE your curbside pickup data with sample data: bash <(curl -s https://gitlab.com/-/snippets/2572579/raw/main/test_curbside_pickups.sh) - Go to Circulation -> Curbside pickups. - Test DataTable functionality under each tab: sorting, paging, filtering, column visibility, and export. - Go to Administration -> Table settings -> Circulation -> Curbside pickup - Confirm that changes made to the configuration of each of the 4 curbside pickup tables is correctly applied on the curbside pickups page. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32890] Add DataTables to curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32890 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34333] Add cancellation requests count embed option to the holds endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34333 Tomás Cohen Arazi changed: What|Removed |Added Summary|Add cancellation requests |Add cancellation requests |count to the holds endpoint |count embed option to the ||holds endpoint -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34333] New: Add cancellation requests count to the holds endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34333 Bug ID: 34333 Summary: Add cancellation requests count to the holds endpoint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com CC: tomasco...@gmail.com When rendering holds tables either in Koha, or in external systems consuming the API, it would be handy to have this information, to give special handling and links to those holds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34310] Input prompt in datatables column search boxes untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34310 --- Comment #3 from Caroline Cyr La Rose --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34310] Input prompt in datatables column search boxes untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34310 Caroline Cyr La Rose changed: What|Removed |Added Attachment #153717|0 |1 is obsolete|| --- Comment #2 from Caroline Cyr La Rose --- Created attachment 153742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153742=edit Bug 34310: Input prompt in datatables column search boxes untranslatable This patch corrects the internationalization function wrapped around the "% search" string in datatables.js. It should be the double-underscore function instead of the single-underscore. To test, apply the patch and test that the placeholder string is translatable. In this example I'm testing fr-FR: - Update a translation: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from JavaScript e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from prog/js/datatables.js for translation, e.g.: \#: koha-tmpl/intranet-tmpl/prog/js/datatables.js:894 \#, javascript-format msgid "%s search" msgstr "%s recherche" - Install the updated translation: > perl translate install fr-FR In the staff interface, test a page that has column header filters, e.g. patron search. Confirm that the table of search results shows the translated string in the column header placeholders. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34310] Input prompt in datatables column search boxes untranslatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34310 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671 --- Comment #34 from Jeremiah --- That worked, Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34332] Syntax error in Point of Sale email template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34332 --- Comment #1 from Laura Escamilla --- Created attachment 153741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153741=edit Bug 34332: Removed extra parenthesis that was causing an error To test: 1. Configure your Koha to enable the point of sale system. 2. Go to Tools > Notices and Slips > Point of Sale Receipt 3. View the Email template - the error “file error - parse error - input text line 16: unexpected token ()) [% payment.library.branchname) | html %]” is showing 4. Apply patch 5. Error has been resolved and email notices can be sent. 6. Sign off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34332] Syntax error in Point of Sale email template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34332 Laura Escamilla changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34332] Syntax error in Point of Sale email template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34332 Laura Escamilla changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34332] New: Syntax error in Point of Sale email template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34332 Bug ID: 34332 Summary: Syntax error in Point of Sale email template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: laura.escami...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1. Configure your Koha to enable the point of sale system. 2. Go to Tools > Notices and Slips > Point of Sale Receipt 3. View the Email template - the error “file error - parse error - input text line 16: unexpected token ()) [% payment.library.branchname) | html %]” is showing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34276] upgrading 23.05 to 23.05.002
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34276
Jeremiah changed:
What|Removed |Added
CC||jhender...@nsd.org
--- Comment #11 from Jeremiah ---
Hi,
I am having the same problem as SOS.
Upgrade to 23.05.00.002 [11:09:02]: Bug 21983 - Deleted biblio handling on ILL
ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Duplicate key name
'illrequests_bibfk' at /usr/share/koha/lib/C4/Installer.pm line 741
I am coming from 22.05 I believe.
I tried their suggestion:
"ALTER TABLE illrequests DROP KEY illrequests_bibfk;"
I got: Cannot drop index 'illrequests_bibfk': needed in a foreign key
constraint
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32890] Add DataTables to curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32890 --- Comment #1 from Owen Leonard --- Created attachment 153740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153740=edit Bug 32890: Add DataTables to curbside pickups This patch modifies the curbside pickups page in the staff interface so that each table is a DataTable with configurable columns. The patch also replaces the patron name output with patron-title.inc for consistency and to display names 'surname, firstname' for correct column sorting. To test, apply the patch and restart services. - Enable the CurbsidePickup system preference if necessary. - Properly testing requires testing data. You can run this command to REPLACE your curbside pickup data with sample data: bash <(curl -s https://gitlab.com/-/snippets/2572579/raw/main/test_curbside_pickups.sh) - Go to Circulation -> Curbside pickups. - Test DataTable functionality under each tab: sorting, paging, filtering, column visibility, and export. - Go to Administration -> Table settings -> Circulation -> Curbside pickup - Confirm that changes made to the configuration of each of the 4 curbside pickup tables is correctly applied on the curbside pickups page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32890] Add DataTables to curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32890 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30981] Add option to configure preferred pronouns as a pull down
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30981 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com --- Comment #4 from Sarah Cornell --- We were excited to see a pronoun field in the borrowers table in 22.11, but will be waiting to fix up our existing pronoun workaround until there is an authorized value option for the field. So our vote is definitely for the optional application of auth values to the pronoun field. We'd rather not wait for the issue in Bug 33397 to be resolved, and we're okay with only having preset values, rather than being able to select authorized values *or* enter free text. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34331] New: Point of Sale Transaction history is showing the wrong register information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34331 Bug ID: 34331 Summary: Point of Sale Transaction history is showing the wrong register information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: laura.escami...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1. Enable the "EnablePointofSale" syspref. 2. Set the "UseCashRegisters" syspref to use. 3. Create 3 new registers (Register A, B and C) with a float amount of $25. 4. Under POS, configure 3 new debit types (i.e. Copies, Earbuds, Friends Donation) -- You can leave the default amounts blank, or add an amount if desired. -- Set "Can be manually invoiced?" and "Can be sold?" 5. Under point of sale make a $5 sale of copies under Register A. 6. Under point of sale make a $10 sale of earbuds under Register B. 7. Under point of sale make a $100 sale of Friends Donation under Register C. 8. At circ/set-library.pl set your register to Register A. 9. Go back to POS and view the "Transaction history for Register A" - it shows the correct amount of $5 sold in copies. 10. Go back to circ/set-library.pl and change your register to Register B. 11. Go back to POS and view the "Transaction history for Register B" - it shows the incorrect transaction history. It is showing the transaction history for Register A. 12. Go back to circ/set-library.pl and change your register to Register C. 13. Go back to POS and view the "Transaction history for Register C" - it shows the incorrect transaction history. It is showing the transaction history for Register A. Setting a register as Default ensures that the correct transaction history is shown. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34330] Saving while leaving 942 $c blank (required field) in fast cataloging causes random redirection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34330 --- Comment #1 from Esther Melander --- Happening with 22.11.07 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33573] Add public endpoint for cancelling holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33573 Tomás Cohen Arazi changed: What|Removed |Added Keywords|rel_23_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34330] New: Saving while leaving 942 $c blank (required field) in fast cataloging causes random redirection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34330 Bug ID: 34330 Summary: Saving while leaving 942 $c blank (required field) in fast cataloging causes random redirection Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl To replicate 1. Ensure fast add framework has at least two required fields. 245 $a Title and 942 $c item type 2. Go to cataloging module and fast cataloging 3. Choose a title already existing in the system in order to trigger a duplicate warning. 4. Enter a title only and leave 942 $c blank 5. Get a Duplicate record suspected warning with the option to Yes, edit exiting items or No, save as new record. Select No, save as new record. From here random things happen depending on the permissions of the patron. If the patron has full cataloging permissions it will open a new Add MARC record blank form, skipping the warning about a blank required field. If the patron only has fast cataloging permission it will log the patron out of the system. What should happen in both cases is a block with a warning that the 942 $c is blank. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34329] Broken Save button when adding record via Fast Add framework from checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34329 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi --- Works in master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34329] Broken Save button when adding record via Fast Add framework from checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34329 --- Comment #1 from Esther Melander --- Likely broken in 22.11.07, worked in 22.11.06 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28164] Sorting on POS register details transactions table is not working right
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28164 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov --- Comment #3 from Barbara Johnson --- We are just now testing the POS system. None of the columns for transaction history are sorting for us. It would be helpful to us to sort by the transaction date as well as by the description of the items sold. It would be great if we could revisit this issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34076] [ALTERNATE] [DOCS] Automated screenshots using Cypress.io testing framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34076
--- Comment #17 from Caroline Cyr La Rose ---
With Jonathan's help, I was finally able to run KTD and Cypress. I don't
know/remember all the problems we ran into, but I apparently have to delete
/kohadevbox/Cypress from the docker (or something) because it doesn't work on
my computer (because I'm not 1000 or something).
docker exec -it koha-koha-1 bash
rm -rf /kohadevbox/Cypress
And I also needed to disable Wayland. Cypress opened with the long multi-line
command in step 2, but the window was just white with nothing else. Jonathan
found this
https://github.com/cypress-io/cypress/issues/20891#issuecomment-1375410342 I
needed to edit the /etc/gdm3/custom.conf file to uncomment #WaylandEnable=false
and then restart my computer. So far I haven't had side-effects from this
(crossed fingers).
I also ran in the same problem as Philip on step 0b (see comment #6). I had to
update node. I had to install nvm. I tried a lot of different things, cursed a
little bit too, so I'm not sure what worked in the end, but here are the
commands I did (found here https://blog.hubspot.com/website/update-node-js),
insert curses anywhere you see fit
node --version
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh |
bash
source ~/.bashrc
nvm -v
nvm install 18
yarn install
On step 5, all the tests end up red (they were all green in step 3), and I only
have 3 screenshots. I have a lot of languages installed on my Koha, I don't
know if that's why. I only enabled the 4 languages in the preferences on step
1c (en, fr-CA, fr-FR, es-ES), but I have like 6 or 7 language options in total.
Error in 0-language-ui.ts https://snipboard.io/NZo0Lm.jpg
Error in 1-sysprefs.ts https://snipboard.io/im6WlB.jpg
Error in 2-checkouts.ts https://snipboard.io/OJ6wVE.jpg
Error in 3-patrons.ts https://snipboard.io/4yj2w8.jpg
On step 6, removing the "first libraries 'it'" is lines 7 to 9 (it wasn't clear
to me where the element ended, so I had to go by trial and error).
1 describe("Libraries", function () {
2 beforeEach(() => {
3 cy.login();
4 cy.set_cookie_lang();
5 });
6
7 it("librarylist", function () {
8 assert(true);
9 });
10
11 /* Test Created with Cypress Studio */
12 it('librarylist', function() {
13 /* Generated with Cypress Studio */
14 cy.get(':nth-child(2) > .biglinks-list > :nth-child(6) >
.icon_general').click();
15 cy.get(':nth-child(1) > :nth-child(4) > :nth-child(1) >
a').click();
16 cy.get('main').should('be.visible');
17 /* End Cypress Studio */
18 });
19 });
In step 6 still, the first commit command didn't work for me, I think because
the file did not exist before (nothing added to commit but untracked files
present (use "git add" to track)), so I did
git add 4-library.ts
git commit -m "auto librarylist"
I did this in ktd --shell, but I think it might have worked in my host too, I'm
not sure.
Haven't tried step 7 yet...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34329] New: Broken Save button when adding record via Fast Add framework from checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34329 Bug ID: 34329 Summary: Broken Save button when adding record via Fast Add framework from checkout screen Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melan...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl To reproduce: 1. Ensure a Fast Add framework exists with some required fields 2. Pull up a patron and their checkout screen. 3. Scan a barcode or type a title that is not in the system to trigger the Barcode not found warning. 4. Click +Add record using fast cataloging 5. Fill in Fast Add form 6. Try to save and see nothing happens. Work around is to open a second tab and go to Cataloging Module, Fast Add Cataloging. The Save button appears to work there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33286] 'Catalog record' should be 'Bibliographic record'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286 Sam Lau changed: What|Removed |Added Attachment #153735|0 |1 is obsolete|| --- Comment #4 from Sam Lau --- Created attachment 153739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153739=edit Bug 33286: Update 'catalog' to 'bibliographic' in preferences Correct the terminology to make it clear catalog concerns only concerns bibliographic records at the moment, not authority records too. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33286] 'Catalog record' should be 'Bibliographic record'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33379] virtualshelfcontents.flags seems useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33379 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33379] virtualshelfcontents.flags seems useless
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33379 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Sam Lau changed: What|Removed |Added Attachment #153695|0 |1 is obsolete|| --- Comment #7 from Sam Lau --- Created attachment 153738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153738=edit Bug 30362: Fix GetSoonestRenewDate to really return soonest renew date This change fixes GetSoonestRenewDate so that it returns the soonest renew date as calculated using "No Renewal Before" and "NoRenewalBeforePrecision". In the past, it would only return the soonest renew date if "$now" was lesser than it, which would typically only happen when using an "exact" precision rather than a "date" precision. Test plan: 0. Apply the patch 1. prove t/db_dependent/Circulation.t Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Sam Lau changed: What|Removed |Added Attachment #153694|0 |1 is obsolete|| --- Comment #6 from Sam Lau --- Created attachment 153737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153737=edit Bug 30362: Fix unit test Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Sam Lau changed: What|Removed |Added Attachment #132248|0 |1 is obsolete|| --- Comment #5 from Sam Lau --- Created attachment 153736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153736=edit Bug 30362: Unit test Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30362] GetSoonestRenewDate is technically wrong when NoRenewalBeforePrecision set to date soonest renewal is today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30362 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28970] Create runtime parameters on the fly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28970 Lisette Scheer changed: What|Removed |Added CC||lisette.scheer@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33286] 'Catalog record' should be 'Bibliographic record'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32542] Coce images not appearing in staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33286] 'Catalog record' should be 'Bibliographic record'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33286 --- Comment #3 from Martin Renvoize --- Created attachment 153735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153735=edit Bug 33286: Update 'catalog' to 'bibliographic' in preferences Correct the terminology to make it clear catalog concerns only concerns bibliographic records at the moment, not authority records too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34320] Hold reordering arrows look broken after Font Awesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 Sam Lau changed: What|Removed |Added Attachment #153715|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 153734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153734=edit Bug 34320: Hold reordering arrows look broken after Font Awesome upgrade This patch makes minor CSS corrections to the arrows on the place hold page in the staff interface. The corrections are necessary because of changes in the display of icons in Font Awesome 6. To test, apply the patch and locate a bibliographic record in the staff interface to place a hold on. - Place at least one hold on that title. - After placing the hold, you should see a table of all the existing holds on that record. - The arrow control links should look correct, with the "move to top" and "move to bottom" arrows having an extra border to differentiate them from the others. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34320] Hold reordering arrows look broken after Font Awesome upgrade
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34320 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33471] Improve performance of hold pickup location verification for next available holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471 Nick Clemens changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33471] Improve performance of hold pickup location verification for next available holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33471 --- Comment #9 from Nick Clemens --- (In reply to Jonathan Druart from comment #8) > Why not doing the caching in Koha::Item->pickup_locations? You could cache > the branchcodes and return them. Less performance but more robust IMO. > > Please ask for more feedback before implementing anything else, I am not > 100% certain it's making sense. Yeah, I can see that - use the L1 Cache in pickup locations, then if the routine it should be visible that the cache would need to be changed But certainly we can improve what we are doing right now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34322] Correct icon triggering more fund search options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Sam Lau changed: What|Removed |Added Attachment #153719|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 153733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153733=edit Bug 34322: Correct icon triggering more fund search options This patch updates the budget/fund administration header search form so that it uses the "fa-slider" Font Awesome icon instead of a folder icon. This makes it consistent with other search forms which have a similar set of additional options. To test, apply the patch and go to Administration -> Budgets. - The "Search funds" form should have the "fa-sliders" icon. - Clicking it should trigger the expansion of the additional search options. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34322] Correct icon triggering more fund search options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34322 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31427] Automatic renewal errors should come before many other renewal errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Sam Lau changed: What|Removed |Added Attachment #153696|0 |1 is obsolete|| --- Comment #11 from Sam Lau --- Created attachment 153732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153732=edit Bug 31427: Get auto renewal errors before other renewal errors This patch changes CanBookBeRenewed so that automatic renewal errors pop up before other renewal errors. This means that a book will be considered "auto_too_soon" before things like "too_many" or "restricted". (Otherwise, you'll get an email saying you can't renew a book the day after using your last auto renewal, even though the earliest renewal isn't available until later.) Test plan: 0. Apply patch 1. prove t/db_dependent/Circulation.t 2. prove t/db_dependent/Holds.t 3. prove t/db_dependent/Koha/Account/Line.t 4. prove t/db_dependent/Koha/Account.t Additional tests: 5. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search=RestrictionBlockRenewing 6. Change to "block" 7. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab==search=AutoRenewalNotices 8. Change to "according to patron messaging preferences" 9. Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl 10. Set "Automatic renewal" to "Yes" and "No renewal before" to 4 11. Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 12. Checkout 301310 with a due date 4 days in the future 13. Add a manual restriction 14. Run `perl ./misc/cronjobs/automatic_renewals.pl` 15. Note that it says something like the following: Issue id: 1237 for borrower: 51 and item: 73 would not be renewed. (auto_too_soon) Instead of something like the following: Issue id: 1237 for borrower: 51 and item: 73 would not be renewed. (restriction) Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31427] Automatic renewal errors should come before many other renewal errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31427 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed|additional_work_needed --- Comment #71 from Jonathan Druart --- (In reply to Jonathan Druart from comment #69) > Created attachment 153731 [details] [review] > Bug 33105: Fix Auth/Permissions.t Still need to be pushed. I am not sure those tests are really useful... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #70 from Jonathan Druart --- (In reply to Jonathan Druart from comment #68) > Created attachment 153730 [details] [review] > Bug 33105: (follow-up) DB changes > > boooh! > > Signed-off-by: Jonathan Druart This has been pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #69 from Jonathan Druart --- Created attachment 153731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153731=edit Bug 33105: Fix Auth/Permissions.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33105] Add vendor issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33105 --- Comment #68 from Jonathan Druart --- Created attachment 153730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153730=edit Bug 33105: (follow-up) DB changes boooh! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34328] Scottish Gaelic is missing from the language_rfc4646_to_iso639 table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 Martin Renvoize changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com, ||m.de.r...@rijksmuseum.nl, ||nason.bi...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34328] Scottish Gaelic is missing from the language_rfc4646_to_iso639 table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34021] Add option to search within results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Sam Lau changed: What|Removed |Added Attachment #153693|0 |1 is obsolete|| --- Comment #2 from Sam Lau --- Created attachment 153729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153729=edit Bug 34021: Add 'search within' to OPAC This change adds a "Search within results" box to the OPAC, which complements the feature already in the staff interface. Test plan: 0. Apply the patch 1. Go to http://localhost:8080/cgi-bin/koha/opac-main.pl 2. Type "e" in the search box and click the search button 3. Click the "Books" value for the "Item types" facet, and note there are fewer search results 4. Type "test" into the "Search within results" box and click the Search button next to the box 5. Note that now there are only 2 results. 6. Also note that the "Books" facet is still selected Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34021] Add option to search within results in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34021 Sam Lau changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34328] Scottish Gaelic is missing from the language_rfc4646_to_iso639 table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 --- Comment #1 from Martin Renvoize --- Created attachment 153728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153728=edit Bug 34328: Add Scottish Gaelic to languages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33974] Add ability to search biblios endpoint any biblioitem attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33974 Tomás Cohen Arazi changed: What|Removed |Added Blocks||33556 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 [Bug 33556] $c->validation should be avoided -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 Tomás Cohen Arazi changed: What|Removed |Added Depends on||33974 --- Comment #18 from Tomás Cohen Arazi --- Minor rebase against bug 33974 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33974 [Bug 33974] Add ability to search biblios endpoint any biblioitem attribute -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 --- Comment #17 from Tomás Cohen Arazi --- Created attachment 153727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153727=edit Bug 33556: Easy ERM-related changes I left the (easy) ERM cases out because it throws this when running the QA script: Processing files before patches |>| 51 / 51 (100.00%) An error occurred : Inconsistent hierarchy during C3 merge of class 'Koha::REST::V1::ERM::EHoldings::Titles::Local': current merge results [ Koha::REST::V1::ERM::EHoldings::Titles::Local, ] merging failed on 'Mojolicious::Controller' at /kohadevbox/qa-test-tools/koha-qa.pl line 112. and didn't want this to pollute the rest of the changes. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556
--- Comment #16 from Tomás Cohen Arazi ---
Created attachment 153726
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153726=edit
Bug 33556: Avoid relying on $c->validation
Talking to the OpenAPI plugin maintainer, he mentioned the use of
$c->validation->output should be avoided as the plugin is not designed to have
a stable behavior there, and he even thought of just removing the method.
That method returns an internal data structure the plugin uses to validate
things, and then updates the request itself.
Take the following example:
GET /patrons/123
x-koha-embed: checkouts,library
without the OpenAPI plugin, requesting the header like this:
$c->req->headers->header('x-koha-embed')
would return a scalar, the string 'checkouts,library'.
When using the plugin, and with `x-koha-embed` being defined as
collectionFormat: csv, that header is entirely replaced by an arrayref.
That's how the plugin works and how it is expected to be used. So we need to
replace the uses of $c->validation format, with normal Mojo usage to avoid
future headaches.
This patch changes:
* $c->validation->param => $c->param
* $c->validation->param('body') => $c->req->json
To test:
1. Run:
$ ktd --shell
k$ prove t/db_dependent/api/v1/*.t
=> SUCCESS: Tests pass!
2. Apply this patches
3. Repeat 1
=> SUCCESS: Tests still pass!
4. Sign off :-D
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 Tomás Cohen Arazi changed: What|Removed |Added Attachment #152693|0 |1 is obsolete|| Attachment #152694|0 |1 is obsolete|| Attachment #152695|0 |1 is obsolete|| --- Comment #15 from Tomás Cohen Arazi --- Created attachment 153725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153725=edit Bug 33556: Path parameters are handled explicitly in the controllers In the case of $c->objects->search_rs, the variable is just not used. In the case of /acq/orders, it's a leftover from when we removed in the helper. Check there are tests with path params everywhere (including orders) and it has no effect. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33556] $c->validation should be avoided
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33556 Tomás Cohen Arazi changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34327] maintenance mode after upgrade to 23.05.01-1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34327 Owen Leonard changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32890] Add DataTables to curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32890 Owen Leonard changed: What|Removed |Added Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34328] New: Scottish Gaelic is missing from the language_rfc4646_to_iso639 table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34328 Bug ID: 34328 Summary: Scottish Gaelic is missing from the language_rfc4646_to_iso639 table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org For languages to appear in the advanced search options they must appear in the language_rfc4646_to_iso639 table. Scottish Gaelic is missing, iso639 code gd and rfc4646 code gla. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34327] New: maintenance mode after upgrade to 23.05.01-1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34327 Bug ID: 34327 Summary: maintenance mode after upgrade to 23.05.01-1 Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: afran...@gmail.com QA Contact: testo...@bugs.koha-community.org Opac dispalys maintenance mode after upgrading to 23.05.01-1 Staff portal is asking for onboarding -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34117] Duplicate patron sets dateenrolled incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34117 --- Comment #12 from Jonathan Druart --- If the change fixes the problem originally describe here, we should make the change here, and obsolete the existing patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34326] Add forbidden notforloan status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34326 Thibaud Guillot changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |thibaud.guil...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
