[Koha-bugs] [Bug 32853] Fix cataloguing/value_builder/unimarc_field_125.pl

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32853

Phil Ringnalda  changed:

   What|Removed |Added

 CC||p...@chetcolibrary.org

--- Comment #5 from Phil Ringnalda  ---
What's the path forward here?

All three of unimarc_field_124.pl, unimarc_field_125.pl, and
unimarc_field_126.pl are the exact same thing, most likely from someone copying
100 and then realizing they needed separate ones for each subfield and
forgetting to remove the non-subfield ones. Julian's patch for the 124 copy has
already been pushed, and nothing bad has happened in the last five months as a
result.

Are we going to file a bug to remove all three plugins, or remove them in these
bugs (including essentially reopening bug 32850 to remove 124), or push the
patches here and in bug 32856 and then think about removing them?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

Emily Lamancusa  changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply

--- Comment #63 from Emily Lamancusa  
---
I'd love to see this move forward soon! It needs a minor rebase and fixes for
the two issues I noticed the last time I tested, but then I think I'll be able
to sign off on it.

I was able to fix the first issue locally by making the following change in
circulation.pref:

- 690yes: Revert
- 691no: "Don't revert"

+ 6901: Revert
+ 6910: "Don't revert"

The issue was that the code in most places checked the syspref as follows:
if ( C4::Context->preference('RevertLostBibLevelHolds') )
which evaluates to true for both "yes" and "no". (The default was put into the
database as 0, so the odd behavior only occurs after the pref has been
changed.)



For the second issue - do moredetail.tt and additem.tt have access to the
syspref value in any way? It's not clear to me whether either of the template
files is taking the value of the syspref into account when determining whether
to display the confirmation alert for handling a lost item-level hold. However,
all of the .pl files in the patches perform the actual handling of lost
item-level holds inside of a conditional that checks the syspref. I assume the
templates should be checking that data somehow as well, so as to display the
alert only if the syspref is set to "revert"?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34522] Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522

Lucas Gass  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34522] Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|oleon...@myacpl.org |lu...@bywatersolutions.com
Version|22.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34522] Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522

--- Comment #2 from Lucas Gass  ---
Created attachment 154393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154393=edit
Bug 34522: Pass the suggestion branchcode, not the suggeter branchcode

To test:
1. Turn on OPACViewOthersSuggestions
2. Log into OPAC as patron of Branch A
3. Make purchase suggestion for Branch B
4. Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to
have been made for Branch A
5. View suggestion from staff client - See that it accurately reflects
suggestion having been made for Branch B
6. Apply patch and try steps 2 - 5 again, this time you should see the proper
branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34522] Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34522] Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #1 from Lucas Gass  ---
The column that displays inaccurately is "Suggested for" which requires the
system preference OPACViewOthersSuggestions to be turned on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34522] New: Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522

Bug ID: 34522
   Summary: Suggestion for purchase displays wrong branch in OPAC
display if patron suggests for non-home branch code
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: he...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Observed in 22.11
To recreate:
Log into OPAC as patron of Branch A
Make purchase suggestion for Branch B
Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to
have been made for Branch A
View suggestion from staff client
See that it accurately reflects suggestion having been made for Branch B

This display is confusing (and inaccurate) for patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34457] Add card number to hold details page

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us
 Status|Needs Signoff   |Signed Off

--- Comment #10 from Rebecca Coert  ---
Works as described!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31652] Add geo-search

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652

--- Comment #8 from Thomas Klausner  ---
The latest patch has some warnings/errors reported from koha-qa.pl. Plus I'm
not totally happy with the way the search params are handled. So I guess it
will need a bit more work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517

Nick Clemens  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517

--- Comment #4 from Nick Clemens  ---
Created attachment 154392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154392=edit
Bug 34517: Add option search patron attributes by default

This patch moves form any staff_searchable attribute being automatically
included in the the Standard patron serch, to allowing the librarian to choose.
Current searchable attributes will be marked as 'searched_by_default'

To test:
1 - Add a searchable patron attribute type
2 - Add some values
3 - Confirm they are searched in a 'Standard' patron search
4 - Apply patch
5 - Go to admin - >patron attribute types
6 - Note new 'Searching' column
7 - Confirm attribute is 'Searched by default'
8 - Confirm searches work as before
9 - Edit the attribute type
10 - Uncheck 'searched_by_default'
11 - Save
12 - Confirm attribute not searched in 'Standard' search
13 - Select the attribute in patron search dropdowns
14 - Confirm it is correctly searched

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517

--- Comment #3 from Nick Clemens  ---
Created attachment 154391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154391=edit
Bug 34517: Add boolean to search columns for schema

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517

--- Comment #2 from Nick Clemens  ---
Created attachment 154390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154390=edit
Bug 34517: DO NOT PUSH - Schema Updates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517

--- Comment #1 from Nick Clemens  ---
Created attachment 154389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154389=edit
Bug 34517: DB updates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916

Nick Clemens  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Nick Clemens  ---
*** Bug 31868 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31868] Add search options for searchable patron attributes to pull down list

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31868

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||n...@bywatersolutions.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Nick Clemens  ---


*** This bug has been marked as a duplicate of bug 26916 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31652] Add geo-search

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31652

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #153720|0   |1
is obsolete||

--- Comment #7 from Thomas Klausner  ---
Created attachment 154388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154388=edit
Bug 31652: Add geo-search

This patch adds geosearch to Koha (using Elasticsearch 7). ElasticSearch
search_mappings get new types to store lat/lon, which can be indexed
from MARC 034$s and 034$t. There is a small change to the DB to allow a
new value in search_field.type ENUM.

The QueryBuilder is extended to allow for building advanced
ElasticSearch Querys (eg geo_distance) that cannot be represented in a
simple string query.

We added a new SystemPreference `GeoSearchEnabled`. If it is set to
`true`, we show a new advanced search field that allows for input of lat/lng
and distance (radius). On the search result page, a we render a map
using leaflet.js with pins for each found item. Therefor we also added a
new api endpoint that returns lat/lng for each biblio in the selection.

Test Plan:

* make sure you're running ElasticSearch 7
  (eg via `curl http://es:9200?pretty | grep number`)
* apply patch
* Set system preference "SearchEngine" to "Elasticsearch"
* got to a Framework, check Editor for 034$s and 034$t and save
* got to some books (in the correct framework) and enter some lat and lon into
034$s and 034$t (for example lat=48.216, lon=16.395)
* Run the elasticsearch indexer, maybe limited on the books you edited (-bn 123
-bn 456):
  misc/search_tools/rebuild_elasticsearch.pl -b -v
* You can check if the indexing worked by inspecting the document in
elasticsearch:
  * get the biblionumber (eg 123)
  * curl http://es:9200/koha_kohadev_biblios/_doc/123?pretty | grep -A5
geolocation
  * You should get back a JSON fragment containing the lat/lon you stored
* You can query elasticsearch directly:
  * Run the following curl command, but adapt the value for lat/lng and/or the
distance (in meters)
  * curl -X GET "http://es:9200/koha_kohadev_biblios/_search?pretty; -H
'Content-Type: application/json' -d '{"query":
{"bool":{"must":{"match_all":{}},"filter":{"geo_distance":{"distance":10,"geolocation":{"lat":48.2,"lon":16.4}}'
* To run the search via Koha:
  * Set system preference "GeoSearchEnabled" to "true"
  * got to OPAC / Advanced Search
  * There is a new input box "Geographic Search" where you can enter
lat/long/radius, for example lat=48.2, lng=16.3, distance=100km
  * On the search result page a map is shown with pins for each found
biblioitem

Sponsored-by: ZAMG - Zentralanstalt für Meterologie und Geodynamik, Austria -
https://www.zamg.ac.at/

Authors: Mark Hofstetter , Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33374] Holds captured at different branch when pickup branch has a copy on shelf can create long wait times for patrons

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33374

Carolyn Hughesman  changed:

   What|Removed |Added

 CC||chughes...@cclsny.org

--- Comment #1 from Carolyn Hughesman  ---
+1  This would be very useful to us!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34457] Add card number to hold details page

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34457

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #154295|0   |1
is obsolete||

--- Comment #9 from ByWater Sandboxes  ---
Created attachment 154387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154387=edit
Bug 34457: Added cardnumber view to hold details page

Signed-off-by: Rebecca Coert 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30031] Add lists to table settings

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031

Todd Goatley  changed:

   What|Removed |Added

 CC||tgoat...@gmail.com

--- Comment #17 from Todd Goatley  ---
What does this bug need to move forward? It shows signed off but FailedQA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25667] Add field for items.notforloan_on to record when a notforloan status is applied

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667

--- Comment #3 from Rebecca Coert  ---
+1 - This would be a useful addition for us!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25667] Add field for items.notforloan_on to record when a notforloan status is applied

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34458] It should be possible to change the pickup location for in transit holds

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34458

--- Comment #2 from Rebecca Coert  ---
I was excited to see the OPACAllowUserToChangeBranch in 22.11 but immediately
wondered why there wasn't also an option for this in the staff interface. 
Thanks for opening this bug and discussion!

I agree that this should be made available on the staff side, and I'd like to
request that it be available for adjustment on the Holds tab of the borrower's
record, as well as on the Holds tab of the Bib record.  Staff here would
appreciate not having to jump between screens to accomplish this task.

I think adding re-routing information to the /transferstoreceive.pl page would
be useful, especially if things went missing while in transit.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34521] New: Claim Return should be controlled by system preference

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34521

Bug ID: 34521
   Summary: Claim Return should be controlled by system preference
 Change sponsored?: ---
   Product: Koha
   Version: 22.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: catr...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

There is no longer a way to remove the claim return tab from a patron account,
even if the library does not have a LOST value set for claims return and
ClaimReturnedLostValue system preference is NULL. There should be an option for
libraries who do not want to use claim returns to turn it off via system
preference so the tab no longer shows on the patron account rather than having
to hide it with CSS.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34458] It should be possible to change the pickup location for in transit holds

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34458

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34024] REST API should not allow changing the pickup location on found holds

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34024

Rebecca Coert  changed:

   What|Removed |Added

 CC||rco...@arlingtonva.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916

--- Comment #3 from Nick Clemens  ---
Created attachment 154386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154386=edit
Bug 26916: Adjust unit tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916

--- Comment #2 from Nick Clemens  ---
Created attachment 154385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154385=edit
Bug 26916: Show searchable patron attributes in patron search dropdown

This patch adds attributes that have been marked searchable to the patron
search dropdowns

To test:
1 - Define some new patron attribute types and make then staff_searchable
2 - Add some values to patrons
3 - Confirm they are searched in 'Standard' search, but there is no other way
to search them
4 - Apply patch
5 - Confirm the fields now show in patorn search dropdowns
6 - Search using 'standard' and confirm the searhc works
7 - Search specific attributes and confirm the searhc works

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26916] Show searchable patron attributes in patron search dropdown

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34520] New: Database update 22.06.00.078 breaks update process

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520

Bug ID: 34520
   Summary: Database update 22.06.00.078 breaks update process
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pablo.bian...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Trying to upgrade from 22.05.15-1, 10.6.14-MariaDB, Debian 11:

Upgrade to 22.06.00.078  [13:21:46]: Bug 24860 - Add ability to place item
group level holds
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Can't create table
`koha_myinstance`.`reserves` (errno: 150 "Foreign key constraint is incorrectly
formed") at /usr/share/koha/lib/C4/Installer.pm line 741

I had some issues (bug 33671 comments 14-19) that it seems are now fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33671] Database update 22.06.00.048 breaks update process

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33671

--- Comment #35 from Pablo AB  ---
I upgraded MariaDB from 10.1 to 10.6 and tried to upgrade (from 22.05) again. I
successfully passed through the `Bug 30472` section!
Still having issues, now on Bug 24860 (Can't create table
`koha_myinstance`.`reserves` (errno: 150 "Foreign key constraint is incorrectly
formed")). I'll file a new bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519

--- Comment #3 from Nick Clemens  ---
Created attachment 154384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154384=edit
Bug 34519: Ensure we always have an array

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

--- Comment #173 from Hammat wele  ---
Rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Attachment #151381|0   |1
is obsolete||

--- Comment #172 from Hammat wele  ---
Created attachment 154383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154383=edit
Bug 17385: (Fix) Add custum export format option to the cart and the lists and
fix tests for CustomXSLTExportList

This patch adds 'XSL-Simple Export' to the cart and the lists and correct the
fail test in t/XSLT.t
it contains Add custum export format option when saving a record

TO TEST:

Before applying:
1) Search for a record in the intranet.
2) Click on the 'Save' button and observe the dropdown menu.
--> There is no 'XSL- Simple Export' in the dropdown menu.
3) Apply the patch.
4) In System preferences search for OpacExportOptions and enable XSL
5) Repeat the steps 1 and 2.
---> There is now 'XSL- Simple Export'  option in the dropdown menu
6) Click on 'XSL - Simple Export'. a .html file should be downloaded.
7) Open the .html file. You should see the record's informations.
8) Add some items to your Cart
9) Open the Cart
10) Click on the 'Download' and 'XSL - Simple Export'.
> a .html file should be downloaded.
> you should see the record's informations in the downloaded file.
11) Add some items to a List
12) Open the List
13) Click on the 'Download' and 'XSL - Simple Export'.
> a .html file should be downloaded.
> you should see the record's informations in the downloaded file.
14) Do the same steps in OPAC
> a .html file should be downloaded.
> you should see the record's informations in the downloaded file.
15) In System preferences search for OpacExportOptions and disable XSL
16) Repeat all steps
17) Notice that 'XSL - Simple Export' is no more in the menus.
18) Run prove -l t/XSLT.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Attachment #151380|0   |1
is obsolete||

--- Comment #171 from Hammat wele  ---
Created attachment 154382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154382=edit
Bug 17385: Add tests for CustomXSLTExportList

Tests are now in one patch.
One test does not pass and I am not able to fix it.

The test who fails :


$ prove -l t/db_dependent/XSLT.t
t/db_dependent/XSLT.t .. 1/3
#   Failed test 'This list comes from the cache and that is fine'
#   at t/db_dependent/XSLT.t line 122.
#  got: '1'
# expected: '2'
# Looks like you failed 1 test of 1.

 #   Failed test 'CustomXSLTExportList: Caching'
 #   at t/db_dependent/XSLT.t line 124.
 # Looks like you failed 1 test of 3.
t/db_dependent/XSLT.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests

Test Summary Report
---
t/db_dependent/XSLT.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=3,  3 wallclock secs ( 0.03 usr  0.00 sys +  1.74 cusr  0.14
csys =  1.91 CPU)
Result: FAIL


This one works fine :


$ prove -l t/XSLT.t
t/XSLT.t .. ok
All tests successful.
Files=1, Tests=12,  4 wallclock secs ( 0.02 usr  0.00 sys +  2.55 cusr  0.17
csys =  2.74 CPU)
Result: PASS


Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Attachment #151379|0   |1
is obsolete||

--- Comment #170 from Hammat wele  ---
Created attachment 154381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154381=edit
Bug 17385: (QA follow-up) Add caching

Performance: We should add caching in CustomXSLTExportList.

Note: This resolves the lack of an intranet test in the former patch too.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Attachment #151378|0   |1
is obsolete||

--- Comment #169 from Hammat wele  ---
Created attachment 154380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154380=edit
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder

Performance: We need to return an empty list if OpacExportOptions does not
contain Custom.  No need to scan the directory for custom files, if we are not
using them at all.

Note: The test only pertains to OPAC now, since the pref should not control
intranet behavior. We have no intranet counterpart. See further next follow-up.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Hammat wele  changed:

   What|Removed |Added

 Attachment #151377|0   |1
is obsolete||

--- Comment #168 from Hammat wele  ---
Created attachment 154379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154379=edit
Bug 17385: Add custom export XSLT

Rebase

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34501] Patron Purchase Suggestion table should include the non-public note

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34501

Lisette Scheer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||lisette.scheer@bywatersolut
   ||ions.com

--- Comment #3 from Lisette Scheer  ---
Worked as expected!
Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34501] Patron Purchase Suggestion table should include the non-public note

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34501

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #154323|0   |1
is obsolete||

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 154378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154378=edit
Bug 34501: Added Non-public notes to the member purchase suggestion table

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34095] Shipping cost should default to a blank box instead of 0.00

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34095

--- Comment #1 from Laura Escamilla  ---
Created attachment 154377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154377=edit
Bug 34095: Adjust logic so that shipment cost is empty if the receiving
shipment cost is blank.

To test:
1. Create a new basket (Orders are not standing, and items are created when
placing an order)
2. Add a record to the basket. 
3. Close the basket. 
4. Receive the shipment - when creating the invoice leave the shipment cost as
blank and then receive the item you added to the basket.  
5. View the invoice and notice that the Shipping Cost is showing as “0.00” 
6. Apply the patch and restart_all
7. Repeat steps 1-5
8. View the invoice and notice that the Shipping Cost is now blank. 
9. Repeat steps 1-5 but this time add a shipment cost when creating the
invoice. When you view the invoice confirm that the shipping cost does show up. 
10. Sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34095] Shipping cost should default to a blank box instead of 0.00

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34095

Laura Escamilla  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34095] Shipping cost should default to a blank box instead of 0.00

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34095

Laura Escamilla  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |Laura.escamilla@bywatersolu
   |ity.org |tions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7972] GUI for Crons

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7972

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519

Nick Clemens  changed:

   What|Removed |Added

 Blocks||34517


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517
[Bug 34517] Add option to search patron attribute in standard search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34517] Add option to search patron attribute in standard search

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517

Nick Clemens  changed:

   What|Removed |Added

 Depends on||34519


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519
[Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch
searchable patron attributes
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519

--- Comment #2 from Nick Clemens  ---
Created attachment 154376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154376=edit
Bug 34519: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519

--- Comment #1 from Nick Clemens  ---
Created attachment 154375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154375=edit
Bug 34519: Add a template plugin for fetch searchable patron attributes

This patch moves code form scripts to a template plguin and unifies the calls

To test:
1 - Add a searchable patron attribute type
2 - Add values to several patrons and test patron searching from
Patrons home
Patrons search results
Holds request screen
Article request screen
Patron search sidebar
3 - Apply patch
4 - Confirm results are the same

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #154371|0   |1
is obsolete||

--- Comment #18 from Thibaud Guillot  ---
Created attachment 154374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154374=edit
Bug 31550: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #154370|0   |1
is obsolete||

--- Comment #17 from Thibaud Guillot  ---
Created attachment 154373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154373=edit
Bug 31550: (follow-up) fix bareword issue

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550

--- Comment #16 from Thibaud Guillot  ---
Created attachment 154372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154372=edit
Bug 31550: Add fields to get opac description on ILSDI web service

Test plan

1) Active your ILS-DI syspref
2) Have some authorised values linked to one or more concern
fields
3) Choose an item and go to
'cgi-bin/koha/opac/ilsdi.pl?service=GetRecords='
4) The XML file contains item fields with some of them the code associated to
the authorized values.
5) Apply this patch
6) Repeat step 3 and see the new fields with specific "_description"
suffix added and contains opac description from authorized values

https://bugs.koha-community.org/show_bug.cgi?id=31550

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550

--- Comment #15 from Thibaud Guillot  ---
Created attachment 154371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154371=edit
Bug 31550: Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #145041|0   |1
is obsolete||
 Attachment #145042|0   |1
is obsolete||

--- Comment #14 from Thibaud Guillot  ---
Created attachment 154370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154370=edit
Bug 31550: (follow-up) fix bareword issue

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31550] ILS-DI: Add OPAC description for some item fields

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31550

Thibaud Guillot  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34519] New: Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519

Bug ID: 34519
   Summary: Add a template plugin for ExtendedAttributeTypes to
fetch searchable patron attributes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Currently we fetch the searchable attributes in several scripts

Moving to a plugin allows us to make a single call from the patron search
template

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34095] Shipping cost should default to a blank box instead of 0.00

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34095

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34518] "Renew all" button doesn't work in OPAC

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34518

--- Comment #1 from Pedro Amorim  ---
Created attachment 154369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154369=edit
Bug 34518: Fix 'Renew all' button in OPAC

Test plan:
- Checkout an item to koha user (42)
- Log-in to OPAC and visit user summary to see check-outs
- Press 'Renew all' button at the bottom, notice it doesn't work.
- Apply patch. Repeat and verify it now works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34518] "Renew all" button doesn't work in OPAC

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34518

Pedro Amorim  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31735] Avoid re-fetching objects from database by passing them down instead of object ids

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735

Pedro Amorim  changed:

   What|Removed |Added

 Blocks||34518


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34518
[Bug 34518] "Renew all" button doesn't work in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34518] New: "Renew all" button doesn't work in OPAC

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34518

Bug ID: 34518
   Summary: "Renew all" button doesn't work in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: pedro.amo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: andrew.a...@ptfs-europe.com, da...@davidnind.com,
katrin.fisc...@bsz-bw.de, k...@bywatersolutions.com,
martin.renvo...@ptfs-europe.com,
n...@bywatersolutions.com
Depends on: 31735

I believe this regression was introduced in patch "Bug 31735: Optimize OPAC
checkouts view".

To reproduce, on k-t-d:
- Checkout an item to koha user (42)
- Log-in to OPAC and visit user summary to see check-outs
- Press 'Renew all' button at the bottom, notice it doesn't work.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735
[Bug 31735] Avoid re-fetching objects from database by passing them down
instead of object ids
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34517] New: Add option to search patron attribute in standard search

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517

Bug ID: 34517
   Summary: Add option to search patron attribute in standard
search
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Currently if a patron attribute is marked 'staff_searchable' it is always
searched when using a 'standard search' 

It should be possible to make attributes searchable without searching them by
default

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23641] Checkout via camera on device

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23641

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30979] Add ability for OPAC users to checkout to themselves

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30979

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34479] Clear saved patron search selections after certain actions

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34507] Add configuration for renaming of terms on the staff interface

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34507

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428

--- Comment #9 from Nick Clemens  ---
Created attachment 154368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154368=edit
Bug 33428: Adjust Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428

Nick Clemens  changed:

   What|Removed |Added

 Attachment #154355|0   |1
is obsolete||

--- Comment #8 from Nick Clemens  ---
Created attachment 154367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154367=edit
Bug 33428: Parse search fields in buildPatronSearchQuery

This patch moves the parsing of standard search_field into the buildPatronQuery
subroutine
and adds a check for 'standard' field before adding attributes to the search

To test:
1 - Add a new attribute type and make it searchable
2 - Add a value to a patron
3 - Search for this value using 'Standard' fields, confirm you get the patron
4 - Search for the value using 'Cardnumber' field, confirm you get the patron -
BAD!
5 - Apply patch
6 - Repeat cardnumebr search, confirm patron not found - Yay!
7 - Search standard, confirm patron is found
8 - Add a new field to 'DefaultPatronSearchFields
9 - Confirm it appears in patron search dropdown
10 - Confirm a search of this field with the attribute value does not return
the patron

Signed-off-by: Fridolin Somers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822

Nick Clemens  changed:

   What|Removed |Added

 Blocks||33428


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428
[Bug 33428] Should only search in searchable patron attributes if searching in
standard fields
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18094] Patron search filters are broken by searchable attributes

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094

Nick Clemens  changed:

   What|Removed |Added

 Blocks|33428   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428
[Bug 33428] Should only search in searchable patron attributes if searching in
standard fields
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428

Nick Clemens  changed:

   What|Removed |Added

 Depends on|18094   |29822


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18094
[Bug 18094] Patron search filters are broken by searchable attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822
[Bug 29822] Use table column selection modal for DefaultPatronSearchFields
preference
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822

--- Comment #82 from Nick Clemens  ---
Created attachment 154366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154366=edit
Bug 29822: (QA follow-up) Use pipe for all field separators

- Tidy atomic update

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822

--- Comment #81 from Nick Clemens  ---
Created attachment 154365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154365=edit
Bug 29822: Update unit tests

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822

--- Comment #80 from Nick Clemens  ---
Created attachment 154364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154364=edit
Bug 29822: Database and Preference description updates

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822

--- Comment #79 from Nick Clemens  ---
Created attachment 154363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154363=edit
Bug 29822: Update code to reference by pipe

Moving to modalselect also has the effect of moving from comma delimited
to pipe delimitation for the preference contents

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822

--- Comment #78 from Nick Clemens  ---
Created attachment 154362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154362=edit
Bug 29822: Use the modal

As requested by Katrin.. switch to the modal and expose all fields from
the borrowers database table

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822

Nick Clemens  changed:

   What|Removed |Added

 Attachment #153442|0   |1
is obsolete||
 Attachment #153443|0   |1
is obsolete||
 Attachment #153444|0   |1
is obsolete||
 Attachment #153445|0   |1
is obsolete||
 Attachment #153446|0   |1
is obsolete||
 Attachment #153447|0   |1
is obsolete||

--- Comment #77 from Nick Clemens  ---
Created attachment 154361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154361=edit
Bug 29822: Update 'DefaultPatronSearchFields' to a select list

This patch updates the `DefaultPatronSearchFields` preference from
freetext expecting a comma delimited list of borrower fields to a
multi-select with a sensible list of fields available.

I opted to not use the Modal approach with all borrower fields listed as
I felt it made more sense to only expose a more limited subset of the
fields available to us.

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33759] Typo: Thankyou

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759

Alexander Wagner  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||alexander.wag...@desy.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33759] Typo: Thankyou

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759

Alexander Wagner  changed:

   What|Removed |Added

 Attachment #154358|0   |1
is obsolete||

--- Comment #3 from Alexander Wagner  ---
Created attachment 154360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154360=edit
Bug 33759: Fix typo 'Thankyou' in sample notices

This fixes the typo 'Thankyou' in some of the sample notices.

To test:
* With the sample data
* Create and run a report:
  SELECT code,content FROM letter where content LIKE "%Thankyou%";
* Verify 3 notices contain 'Thankyou'
* Apply patch
* Drop your database
* Run the web installer
* Run report again, you should no longer get any results

Signed-off-by: Alexander Wagner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822

--- Comment #76 from Nick Clemens  ---
This and 33428 are going to clash, happy to rebase mine on top of this

Would it be better to leave the fields from the pref as pipe, and just move the
other fields 'full_address', 'all_emails' etc to use the pipe too? Then we
don't have to replace in the one instance for splitting.

I don't understand the comment:
+ effectively replace 'standard', don't display it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33428] Should only search in searchable patron attributes if searching in standard fields

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29822

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29822] Use table column selection modal for DefaultPatronSearchFields preference

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=33428
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34119] After redesign, print.css no longer hides things at the top of report results

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34119] After redesign, print.css no longer hides things at the top of report results

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34119

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED

--- Comment #9 from Katrin Fischer  ---
Better to avoid "In Discussion" unless there is an argument that needs more
people to be resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34506] After deleting record from a search result the link 'Go back to the results' has disappeared

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34506

Mark Hofstetter  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34506] After deleting record from a search result the link 'Go back to the results' has disappeared

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34506

--- Comment #1 from Mark Hofstetter  ---
Created attachment 154359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154359=edit
Bug 34506: After deleting record from a search result the link 'Go back to the
results' has disappeared

This patch fixes the regression of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428
introduced in 22.11.x

Test plan see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5428

To test:
0 - Perform a search in the staff client
1 - Click a title to go to the details page for a record
2 - Click the 'Edit' button and select 'Edit items in a batch'
3 - Note the searchid is in the url
4 - Make a change and hit 'Save'
5 - Note the 'Return the the record' link at the top, and the button on the
bottom include searchid in URL
6 - Click one and note the brwoser is stil there
7 - Click 'Edit' and select 'Delete items in a batch'
8 - Delete one item
9 - Click return to record
10 - Browser is there
11 - Click 'Delete items in a batch again
12 - Select all and check 'Delete records if no items remain'
13 - Delete them
14 - Note you have a link to 'Go back to the results'

Sponsored-by: Steiermärkische Landesbibliothek

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34506] After deleting record from a search result the link 'Go back to the results' has disappeared

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34506

Mark Hofstetter  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@trust-box.at
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33759] Typo: Thankyou

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759

--- Comment #2 from Katrin Fischer  ---
Created attachment 154358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154358=edit
Bug 33759: Fix typo 'Thankyou' in sample notices

This fixes the typo 'Thankyou' in some of the sample notices.

To test:
* With the sample data
* Create and run a report:
  SELECT code,content FROM letter where content LIKE "%Thankyou%";
* Verify 3 notices contain 'Thankyou'
* Apply patch
* Drop your database
* Run the web installer
* Run report again, you should no longer get any results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33759] Typo: Thankyou

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33759

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29930] Auth with LDAP: Update tag leads to unwanted updates

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29930

Alexander Wagner  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #7 from Alexander Wagner  ---
**Note** `card number` is a mandatory field. Setting

```xml

1 

```

will now happily create a user without assign a card number with this patch
applied. It seems simple to change it to the old behaviour and assign the
ldap-id in case a new user is created.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32306] Hold modifications don't log correctly

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32306

--- Comment #12 from Emmi Takkinen  ---
I think it's save to say that this bug is a duplicate of bug 25159?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out

2023-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #70 from Frédéric Demians  ---
It would be nice to have this functionnality with more granularity, not with a
global system preference, but with a SIPconfig.xml parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/