[Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #68 from Victor Grousset/tuxayo --- (In reply to Lucas Gass from comment #64) > Merge conflicts with 22.05.x, please rebase. Here is a rebase :) Test plan done to check that it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #67 from Victor Grousset/tuxayo --- Created attachment 154482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154482=edit Bug 28267: [22.05] Simplify things We don't need: * a separate Koha::Installer module when we already have C4::Installer * the tests as they are actually modifying the DB structure without rolling back * An unecessary complicated subroutine, just make is simple WNC amended patch: Remove change to Koha.pm Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi (cherry picked from commit f394bf61cf7e60058afd9856f7ae8dda8afb385b) Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28267] Older databases fail to upgrade due to having a row format other than "DYNAMIC"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28267 --- Comment #66 from Victor Grousset/tuxayo --- Created attachment 154481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154481=edit Bug 28267: [22.05] Add warnings for database row formats This patch adds a warning on about.pl regarding database row formats other than "DYNAMIC". It points to the Koha community wiki for more information on how to resolve the problem. This patch also stops the installer if there are any database tables with a row format other than "DYNAMIC". It points to the Koha community wiki for more information on how to resolve the problem. Test plan: 0a. Apply the patch 0b. koha-plack --restart kohadev 1a. koha-mysql kohadev 1b. ALTER TABLE tags ROW_FORMAT=COMPACT; 2. Go to http://localhost:8081/cgi-bin/koha/about.pl 3. Note that there is a warning about database row formats 4a. koha-mysql kohadev 4b. ALTER TABLE tags ROW_FORMAT=DYNAMIC; 5. Go to http://localhost:8081/cgi-bin/koha/about.pl 6. Note that there is no warning about database row formats 7a. Manually change the version in Koha.pm to a higher version 7b. koha-plack --restart kohadev 8a. koha-mysql kohadev 8b. ALTER TABLE tags ROW_FORMAT=COMPACT; 9. Go to http://localhost:8081/ 10. Log into the web installer and click through until you reach a warning telling you that you have database row formats other than 'DYNAMIC' 11. Note that you can't progress with the installer until this problem is resolved 12a. koha-mysql kohadev 12b. ALTER TABLE tags ROW_FORMAT=DYNAMIC; 13. Refresh the page or redo the web installer process 14. Note that you're no longer blocked from running the installer due to database row format 15. Undo your change to Koha.pm 16. Profit Note: Due to bug 32665 you'll see an unrelated warning on step 3 Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi (cherry picked from commit b76fb9cf466dd4cc4eb4d382c4bfb9fa78a1fce6) Rebased-by: Victor Grousset/tuxayo Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 --- Comment #5 from David Cook --- Note that there's no warnings anywhere that any stripping occurred. We probably should log to file and show something on the screen for users... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34551 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34551 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34551] Don't allow Z39.50 import if MARC can't be converted to MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34551 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34014, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34549 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34551] New: Don't allow Z39.50 import if MARC can't be converted to MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34551 Bug ID: 34551 Summary: Don't allow Z39.50 import if MARC can't be converted to MARCXML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl As I note on bug 34014 and bug 34549, if you've got the wrong encoding on your Z39.50 server, you can wind up importing MARC data that contains invalid data (like control characters). During copy cataloguing, there should be a warning that there's a problem with the data (possibly because of Z39.50 server config). That way we have librarians raising the flag that there's a problem before the data is in Koha rather than us doing cleanup after it's been imported. (Of course, bulk loaded MARC will still be a problem, but baby steps...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #15 from David Cook --- Bug 34549 came about because I had a library that was able to import and save MARC data which couldn't be parsed as MARCXML. We could warn or fail earlier. In their case, they had the encoding wrong on their Z39.50 server config. As soon as I fixed that, the problem went away. So perhaps we should put more thought into treating the root cause and not just the symptom... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 --- Comment #14 from David Cook --- Hmm after reviewing this one again... perhaps a combination of this and bug 34549 make sense... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 --- Comment #4 from David Cook --- Created attachment 154480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154480=edit Bug 34549: Strip non-XML chars during TransformHtmlToMarc This patch strips non-XML characters from inputs during TransformHtmlToMarc. To test: 0. Apply patch 1. koha-plack --restart kohadev 2. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl 3. Fill out record and use the text from "Text file containing control characters" as the title 4. Click Save 5. Note that your record displays without any warnings like the following: Error: invalid data, cannot decode metadata object parser error : PCDATA invalid Char value 27 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34014] There is no way to fix records with broken MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34549 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34014 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 --- Comment #3 from David Cook --- Actually, it looks like you can just go straight to https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154479 and copy the text from there in the web browser and that will break your MARC record via the cataloguing editor. Click "Save and view record" for the most obvious results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 --- Comment #2 from David Cook --- Created attachment 154479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154479=edit Text file containing control characters On Windows, open this file with Notepad or Notepad++. I haven't tried other OSes but use a graphical text editor. Copying and pasting this into a MARC record via the cataloguing editor will generate this kind of warning: "PCDATA invalid Char value 27" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34549] The cataloguing editor allows you to input invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 --- Comment #1 from David Cook --- Ok Bugzilla won't print that non-printable character so that's going to make this harder. I'll look at adding a text attachment where you can just copy the text and paste it into Koha to get it to break. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34549] New: The cataloguing editor allows you to input invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 Bug ID: 34549 Summary: The cataloguing editor allows you to input invalid data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl I had a library using UTF-8 encoding instead of MARC-8 encoding, and they were able to import records into the cataloguing editor and save them into Koha. Then when they tried to view, edit, or delete the records, Koha would throw fatal errors. You can duplicate this by copying and pasting the following character into your cataloguing editor in say the 245$a field: -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25023] Claims returned dates not formatted according to dateformat preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25023 --- Comment #7 from Victor Grousset/tuxayo --- Oh okay :o No problem then. Crazy that it's identical and relies on position for which one to do what. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34029] Import breaks when data exceeds size of mapped database columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34029 David Cook changed: What|Removed |Added Blocks||34548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34548 [Bug 34548] Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34548] Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34548 David Cook changed: What|Removed |Added Depends on||34029 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34029 [Bug 34029] Import breaks when data exceeds size of mapped database columns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34548] Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34548 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au, ||katrin.fisc...@bsz-bw.de, ||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34548] Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34548 --- Comment #2 from mjn...@gmail.com --- Actions I took: DROP INDEX `publishercode` ON `koha_instance`.`biblioitems` DROP INDEX `publishercode` ON `koha_instance`.`deletedbiblioitems` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34548] Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34548 --- Comment #1 from mjn...@gmail.com --- The error was something like: "column 'publishercode' used in key specification without a key length" Sorry I don't have the full output. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34548] New: Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34548 Bug ID: 34548 Summary: Upgrade failed on conversion of publishercode from varchar to text on biblioitems and deletedbiblioitems due to existing indexes Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs@lists.koha-community.org Reporter: mjn...@gmail.com QA Contact: testo...@bugs.koha-community.org Changes in: /usr/share/koha/intranet/cgi-bin/installer/data/mysql/db_revs/230501003.pl to convert publishercode to text on both tables resulted in an upgrade error. Manually deleted the indexes from the tables allowed the [Try again] to proceed without incident. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28499] Add support for no-UI / administrative plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 --- Comment #7 from David Cook --- (In reply to David Cook from comment #6) > Actually, I think it would need to be a flag, because you might want to > distribute a third-party plugin via a shared directory to many Koha > instances and not want 1 Koha admin to be able to uninstall it for > everyone... But the problem with the flag is that often plugins are installed from the CLI like this: koha-shell kohadev -c "/usr/share/koha/bin/devel/install_plugins.pl" So there would need to be some other way of preventing uninstall... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #54 from David Cook --- I would still like a way to prevent "Uninstall" as well for plugins installed via the CLI, but I think that can be its own thing. I'm also less worried about people uninstalling plugins than installing problematic plugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #53 from David Cook --- Adding my SO and leaving "Signed Off" since I wrote some of these patches. Kyle, should we consider your SO as QA, or do you want to have another look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25370] Create allowlist of plugins allowed to be installed by Web UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25370 --- Comment #5 from David Cook --- Going forward I'll probably just rely on bug 25672 so I doubt I'll work on this... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Attachment #154468|0 |1 is obsolete|| --- Comment #52 from David Cook --- Created attachment 154478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154478=edit Bug 25672: Convert to restricting to listed repositories only I think instead of a plain on/off switch we should use it in combination with the plugin_repo's and set it to restrict to only those repos' (i.e. disable uploads entirely if no repo's are listed, or just allow those repo's when there are). This patch achieves that, but only if plugins are installed via the plugin browser method. We disable all direct upload avenues, so install is blocked for other cases. Signed-off-by: Kyle M Hall Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Attachment #154467|0 |1 is obsolete|| --- Comment #51 from David Cook --- Created attachment 154477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154477=edit Bug 25672: Prevent uninstall when plugin browser upload disabled When plugin browser upload is disabled, also prevent plugin browser uninstall. Signed-off-by: Kyle M Hall Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Attachment #154466|0 |1 is obsolete|| --- Comment #50 from David Cook --- Created attachment 154476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154476=edit Bug 25672: (QA follow-up) Hide install after search button If plugin upload is disabled, but there are git repositories listed in the config for plugin searching, then you can search for a plugin and attempt to install it. The install leads to an error page. This patch removes the actions column and install button should the enable_browser_upload option be disabled Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Attachment #154465|0 |1 is obsolete|| --- Comment #49 from David Cook --- Created attachment 154475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154475=edit Bug 25672: Enable enable_plugin_browser_upload by default This patch enables enable_plugin_browser_upload by default, since the current behaviour for Koha is to enable browser upload when enable_plugins is 1. Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Attachment #154464|0 |1 is obsolete|| --- Comment #48 from David Cook --- Created attachment 154474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154474=edit Bug 25672: use enable_plugin_browser_upload flag to control plugin upload This patch adds a enable_plugin_browser_upload flag to koha-conf.xml, which controls whether or not Koha intranet users can upload Koha plugins via their browser. Like "enable_plugins", it defaults to 0 for new installs. This is useful when you want to provide Koha intranet users with plugins that are pre-installed by administrators (by CLI) or restricting them to plugins from a Github repo. See the following for more information: Bug 23975 - Add ability to search and install plugins from GitHub Bug 23191 - Administrators should be able to install plugins from the command line To test: 1) Apply the patch 2) Set 1 in koha-conf.xml 3) Add 0 in koha-conf.xml 4) restart_all (in koha-testing-docker) 5) Go to /cgi-bin/koha/plugins/plugins-home.pl and note that you don't see an option to upload plugins 6) Go to /cgi-bin/koha/plugins/plugins-upload.pl and note that it says "Plugin browser upload disabled!" and gives instructions on how to enable browser upload 7) Install a plugin from the CLI using koha-shell kohadev -c "/usr/share/koha/bin/devel/install_plugins.pl" 8) Note that the Uninstall option for the plugin does not appear 9) Enable Koha plugin git repos and search for "coverflow" 10) Note that you can find the plugin but you cannot install it 11) Change enable_plugin_browser_upload back to 1 and "restart_all" 12) Note that you can not upload plugins, uninstall plugins, and install plugins from Git repos Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28499] Add support for no-UI / administrative plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28499 --- Comment #6 from David Cook --- (In reply to Tomás Cohen Arazi from comment #3) > (In reply to David Cook from comment #2) > > Would the plugin itself denote itself as non-accessible to users, or would > > it be a flag used when installing via the CLI? > > I think both use cases are valid and interesting. I was pointing more to the > first one in an initial approach, as the second one has interesting edge > cases, like users installing a new version, etc. > > What do you think it would be best? Actually, I think it would need to be a flag, because you might want to distribute a third-party plugin via a shared directory to many Koha instances and not want 1 Koha admin to be able to uninstall it for everyone... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34543] Content block accessibility helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34543 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- It's an interesting idea. I've been adding element/attribute filtering to the HTML Content blocks, so the UI for this is certainly on my mind these days... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- I'm signing off on this one, since it works as described. However, I'm not sure about the approach. I think adding a warning in the logs is a very good idea, but generating an internal server error seems suboptimal. It might be better to generate a more graceful error message on the screen. That said, an ISE is probably better than what we have at the moment. Failing early and noisy would get the situation fixed ASAP I suspect. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 David Cook changed: What|Removed |Added Attachment #154469|0 |1 is obsolete|| --- Comment #2 from David Cook --- Created attachment 154473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154473=edit Bug 34545: Koha should die with an error if AutoSelfCheckID is invalid If AutoSelfCheckID is an not valid ( either by deleting the patron or by changing the patron's userid ), self-checkout will display the login screen and no error will be generated in any logs. Test Plan: 1) Apply this patch 2) Verify AutoSelfCheckID is working as expected 3) Change AutoSelfCheckID to an invalid userid 4) Restart all the things! 5) Verify visiting sco-main.pl generates an error! Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- We did have some folk struggle due to the change in permissions, although the description for "edit_borrowers" is "Add, modify and view patron information" and the patron search results does show patron information for all patrons. I'm not sure requiring "edit_borrowers" was the right way to go, but I can understand wanting to make it more restricted too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Phil Ringnalda changed: What|Removed |Added Attachment #154471|0 |1 is obsolete|| --- Comment #7 from Phil Ringnalda --- Created attachment 154472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154472=edit Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. Signed-off-by: Barbara Johnson Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 --- Comment #6 from Lucas Gass --- (In reply to Phil Ringnalda from comment #4) > Looks like you accidentally included something from work on another patch, > since the hunk commenting out part of > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt doesn't fit > this bug. Good catch Phil, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Lucas Gass changed: What|Removed |Added Attachment #153522|0 |1 is obsolete|| --- Comment #5 from Lucas Gass --- Created attachment 154471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154471=edit Bug 34275: Add toggle switch for basic/advanced cataloging editors To test: 1. Apply patch and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 2. Turn on EnableAdvancedCatalogingEditor. 3. Go to cataloging > 'New record' 4. In the upper left notice a new toggle switch labeled 'Editor:'. 5. Try toggling the switch back and forth to move between editors. Verify it works correecly. 6. Try editing an existing record and make sure the toggle works well when editing records. 7. Try the other method of switch editors, Settings > Switch to basic/advanced editor. Make sure it works the same as always 8. Turn off EnableAdvancedCatalogingEditor, make sure the toggle button is no longer present. Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34547] Add transfer reason to returns.pl table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34547 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34547] Add transfer reason to returns.pl table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34547 --- Comment #1 from Lucas Gass --- Created attachment 154470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154470=edit Bug 34547: Add transfer reason to checkedintable on returns.tt To test: 1. Apply patch, restart_all 2. Check some items out and prepare some reasons that would initiate a branchtransfer. According the schema it can be any of the following: 'Manual', 'StockrotationAdvance', 'StockrotationRepatriation', 'ReturnToHome', 'ReturnToHolding', 'RotatingCollection', 'Reserve', 'LostReserve', 'CancelReserve', 'TransferCancellation', 'Recall', 'RecallCancellation. 3. CHeck in some the items and notice the 'Transfer reason' column in the table. Make sure the reasons are acurate and make sense. 4. To go Table settings and find the 'checkedintable'. Make sure you can properly hide the column from the display. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34547] Add transfer reason to returns.pl table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34547 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30230] Search for patrons in checkout should not require edit_borrowers permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30230 he...@bywatersolutions.com changed: What|Removed |Added CC||he...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34547] New: Add transfer reason to returns.pl table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34547 Bug ID: 34547 Summary: Add transfer reason to returns.pl table Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: he...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be nice for the reason for branch transfers (branchtransfers.reason) to be a configurable column on returns.pl, so libraries know which checkins may need more attention in the case of a dismissed modal or receipt printing issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34546] New: Report group code should only contain ASCII chars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34546 Bug ID: 34546 Summary: Report group code should only contain ASCII chars Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org When creating a new report, one can create a new report group. Since its code will be used in tab id attribute, it should be tested to contain only ASCII chars (and no space) : [a-zA-Z0-9_-] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23003] Accessibility improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 David Nind changed: What|Removed |Added CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 --- Comment #1 from Kyle M Hall --- Created attachment 154469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154469=edit Bug 34545: Koha should die with an error if AutoSelfCheckID is invalid If AutoSelfCheckID is an not valid ( either by deleting the patron or by changing the patron's userid ), self-checkout will display the login screen and no error will be generated in any logs. Test Plan: 1) Apply this patch 2) Verify AutoSelfCheckID is working as expected 3) Change AutoSelfCheckID to an invalid userid 4) Restart all the things! 5) Verify visiting sco-main.pl generates an error! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34545] AutoSelfCheckID fails silently if userid is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com, ||l...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34545] New: AutoSelfCheckID fails silently if userid is invalid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34545 Bug ID: 34545 Summary: AutoSelfCheckID fails silently if userid is invalid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org If AutoSelfCheckID is an not valid ( either by deleting the patron or by changing the patron's userid ), self-checkout will display the login screen and no error will be generated in any logs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32306] Hold modifications don't log correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32306 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30031] Add lists to table settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30031 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 --- Comment #32 from Phil Ringnalda --- Do things typically become not-FQA from reasons outside the bug? The patches in this bug have always chosen to implement move with insert_grouped_field, which puts a 600 after a 690, rather than insert_field_ordered, which puts a 600 with 600s, before 610. Nobody has ever responded with a reason why, going back to 2020, only asked "is this still FQA?" Nick's update of the patches included a change to the behavior of copy and replace, from replace the first n to replace all, in a patch called "Unit test." No response as to why, or even whether it was intentional or accidental. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24480] Fields added with MARC modifications templates are not added in an ordered way
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #31 from Lucas Gass --- Should this still be FQA? I'd like to see it move along! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34544] New: Add file option to delete_items.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34544 Bug ID: 34544 Summary: Add file option to delete_items.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: slod...@knoxlib.org QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Writeoff_debts.pl and delete_patrons.pl can both be run with input from a file. Please add this option to delete_items.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24073] Allow suggestion management page to default to all libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24073 --- Comment #5 from Andrew Fuerste-Henry --- (In reply to Lucas Gass from comment #4) > I am wondering if this problem has been solved by Bug 26833 since now we can > see both the logged in branches suggestions and all libraries suggestions on > /cgi-bin/koha/mainpage.pl. This issue is not particularly solved by Bug 26833. If I follow the link to All Library suggestions from the homepage, I go to /cgi-bin/koha/suggestion/suggestion.pl?branchcode=__ANY__#ASKED and see all suggestions. But if I move off of that page in order to edit a suggestion, all of the avenues back to the main Suggestions page will end up just taking me to /cgi-bin/koha/suggestion/suggestion.pl, where I'll see only my logged-in branch suggestions. We need a way to make the page always default to all branches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6419] Add customizable areas to intranet home pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Andrew Fuerste-Henry changed: What|Removed |Added CC||andre...@dubcolib.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34543] Content block accessibility helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34543 --- Comment #1 from Martin Renvoize --- TinyMCE actually have an accessability checker tool.. though it looks like a premium plugin to me.. likely licensed? https://www.tiny.cloud/docs/tinymce/6/a11ychecker/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23003] Accessibility improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Martin Renvoize changed: What|Removed |Added Depends on||34543 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34543 [Bug 34543] Content block accessibility helpers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34543] New: Content block accessibility helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34543 Bug ID: 34543 Summary: Content block accessibility helpers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Blocks: 23003 With the ability to enter almost anything into the HTML Content blocks, and especially the WYSIWYG editor used.. it's very, very easy to break the accessibility of your OPAC. We should look into options for hinting at correct headings level start point in the editor and perhaps add options for adding simple styled blocks that conform to Koha best practices (Like the use of page-sections in intranet blocks for example) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23003] Accessibility improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Martin Renvoize changed: What|Removed |Added Depends on||34542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34542 [Bug 34542] Add tests for '.maincontent' presence to the QA tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to main content' link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Martin Renvoize changed: What|Removed |Added Blocks||34542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34542 [Bug 34542] Add tests for '.maincontent' presence to the QA tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34542] New: Add tests for '.maincontent' presence to the QA tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34542 Bug ID: 34542 Summary: Add tests for '.maincontent' presence to the QA tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org Depends on: 22807 Blocks: 23003 We added the 'Skip to main content' feature in bug 22807. It relies heavily on the present of a .maincontent class being found on every OPAC page. We have a coding guidline around this, but to date I don't think we have a QA script test for it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 [Bug 22807] Accessibility: Add 'Skip to main content' link https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23003] Accessibility improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Martin Renvoize changed: What|Removed |Added Depends on|22807 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 [Bug 22807] Accessibility: Add 'Skip to main content' link -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to main content' link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Martin Renvoize changed: What|Removed |Added Blocks|23003 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23003] Accessibility improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Martin Renvoize changed: What|Removed |Added Depends on||28469 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28469 [Bug 28469] Move "Skip to main content" link to top of page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28469] Move "Skip to main content" link to top of page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28469 Martin Renvoize changed: What|Removed |Added Blocks||23003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23003] Accessibility improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Martin Renvoize changed: What|Removed |Added Depends on||33886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33886 [Bug 33886] Flatpickr calendar - year controls for date of birth on memberentry.pl are not intuitive -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33886] Flatpickr calendar - year controls for date of birth on memberentry.pl are not intuitive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33886 Martin Renvoize changed: What|Removed |Added Blocks||23003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 [Bug 23003] Accessibility improvements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26994] Display list of names in alphabetical order when using the Suggestion information filter in Suggestions management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26994 Shi Yao Wang changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34424] Update release team on about page for new QA team member
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34424 Martin Renvoize changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29523] Add a way to prevent embedding objects that should not be allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #104 from Martin Renvoize --- I think I've mentioned it before.. but I think the solution likely lies in redaction rather than outright removal of results.. I think we probably need a way to identify what fields should be redacted for the redacted case at each object level and then obviously a way to know when to call a redaction function to clear out the fields for the API response. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14179] Field width for currency is wrong in the GUI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14179 Martin Renvoize changed: What|Removed |Added Keywords||Academy CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704 Mengu Yazicioglu changed: What|Removed |Added CC||me...@devinim.com.tr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 30999] Add a script to manage plugins from the command line
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30999 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25672 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30999 Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #47 from Kyle M Hall --- Created attachment 154468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154468=edit Bug 25672: Convert to restricting to listed repositories only I think instead of a plain on/off switch we should use it in combination with the plugin_repo's and set it to restrict to only those repos' (i.e. disable uploads entirely if no repo's are listed, or just allow those repo's when there are). This patch achieves that, but only if plugins are installed via the plugin browser method. We disable all direct upload avenues, so install is blocked for other cases. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #46 from Kyle M Hall --- Created attachment 154467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154467=edit Bug 25672: Prevent uninstall when plugin browser upload disabled When plugin browser upload is disabled, also prevent plugin browser uninstall. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #45 from Kyle M Hall --- Created attachment 154466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154466=edit Bug 25672: (QA follow-up) Hide install after search button If plugin upload is disabled, but there are git repositories listed in the config for plugin searching, then you can search for a plugin and attempt to install it. The install leads to an error page. This patch removes the actions column and install button should the enable_browser_upload option be disabled Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #44 from Kyle M Hall --- Created attachment 154465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154465=edit Bug 25672: Enable enable_plugin_browser_upload by default This patch enables enable_plugin_browser_upload by default, since the current behaviour for Koha is to enable browser upload when enable_plugins is 1. Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Kyle M Hall changed: What|Removed |Added Attachment #154423|0 |1 is obsolete|| Attachment #154424|0 |1 is obsolete|| Attachment #154425|0 |1 is obsolete|| Attachment #154426|0 |1 is obsolete|| Attachment #154455|0 |1 is obsolete|| --- Comment #43 from Kyle M Hall --- Created attachment 154464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154464=edit Bug 25672: use enable_plugin_browser_upload flag to control plugin upload This patch adds a enable_plugin_browser_upload flag to koha-conf.xml, which controls whether or not Koha intranet users can upload Koha plugins via their browser. Like "enable_plugins", it defaults to 0 for new installs. This is useful when you want to provide Koha intranet users with plugins that are pre-installed by administrators (by CLI) or restricting them to plugins from a Github repo. See the following for more information: Bug 23975 - Add ability to search and install plugins from GitHub Bug 23191 - Administrators should be able to install plugins from the command line To test: 1) Apply the patch 2) Set 1 in koha-conf.xml 3) Add 0 in koha-conf.xml 4) restart_all (in koha-testing-docker) 5) Go to /cgi-bin/koha/plugins/plugins-home.pl and note that you don't see an option to upload plugins 6) Go to /cgi-bin/koha/plugins/plugins-upload.pl and note that it says "Plugin browser upload disabled!" and gives instructions on how to enable browser upload 7) Install a plugin from the CLI using koha-shell kohadev -c "/usr/share/koha/bin/devel/install_plugins.pl" 8) Note that the Uninstall option for the plugin does not appear 9) Enable Koha plugin git repos and search for "coverflow" 10) Note that you can find the plugin but you cannot install it 11) Change enable_plugin_browser_upload back to 1 and "restart_all" 12) Note that you can not upload plugins, uninstall plugins, and install plugins from Git repos Signed-off-by: Nicolas Legrand Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25672] Administrators should be able to restrict client-side plugin upload to trusted sources
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34313] Make password validation endpoint return patron IDs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34313 Nick Clemens changed: What|Removed |Added Attachment #153788|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 154463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154463=edit Bug 34313: Add patron information in pass validation response This patch makes the password validation response return the following patron attributes to the API consumer: * cardnumber * userid This will give hints on what was used to validate in the fallback bahvior the endpoint has. To test: 1. Apply the unit tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/password_validation.t => FAIL: The endpoint doesn't return this valuable data 3. Apply this patch 4. Repeat 2 => SUCESS: Tests pass! We got the cardnumber and the userid! 5. Sign off :-D Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34313] Make password validation endpoint return patron IDs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34313 Nick Clemens changed: What|Removed |Added Attachment #153787|0 |1 is obsolete|| --- Comment #10 from Nick Clemens --- Created attachment 154462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154462=edit Bug 34313: Unit tests Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34313] Make password validation endpoint return patron IDs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34313 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34541] New: MARC authority framework doesn't work if there is only one tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34541 Bug ID: 34541 Summary: MARC authority framework doesn't work if there is only one tab Change sponsored?: --- Product: Koha Version: 22.11 Hardware: PC OS: Windows Status: NEW Severity: minor Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: alejoja...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 154461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154461=edit Authority framework console error MARC authority framework is not working when all MARC fields are on the same tab. It doesn't allow saving the record. I attach a screenshot of console error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33920] Improve translation of title tags: Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33920 Owen Leonard changed: What|Removed |Added Attachment #152309|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 154460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154460=edit Bug 33920: Improve translation of title tags: Patrons This patch updates patron module templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following patron-related pages have the correct title tags: - Patrons home page - Patron search -> - Select two patrons -> Merge selected - Add patron -> - Add a patron with the same name and email address -> - Click "View existing record" in "Duplicate patron record?" dialog. - Patron details - Manage API keys (must have RESTOAuth2ClientCredentials enabled) - Accounting - Transactions - Print fee receipt - Print invoice - Make a payment - Create manual invoice - Create manual credit - Routing lists (must have RoutingSerials enabled) - Circulation history - Notices - Statistics - Files (must have EnableBorrowerFiles enabled) - Purchase suggestions - Discharges (must have useDischarge enabled) - Housebound (must have HouseboundModule enabled) - ILL requests history (must have ILLModule enabled) - Set permissions - Change password - Print summary - Print account balance - Two-factor authentication (must have TwoFactorAuthentication enabled) - Edit patron - Update child to adult patron: - Must have more than one "adult" type category defined - Locate a patron with a "child" type category - Choose More -> Update child to adult patron - Delete patron (confirmation page) - Pending discharge requests - Patrons requesting modifications -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33920] Improve translation of title tags: Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33920 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24638] UNIMARC Authorities update from IFLA for new Koha installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24638 Igor A. Sychev changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10762] Make it possible to adjust the barcode height and width on labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
