[Koha-bugs] [Bug 34621] Patron import option to 'Renew existing patrons' 'from the current membership expiry date' not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34621 David Nind changed: What|Removed |Added Text to go in the|This fixes the option when |This fixes the option when release notes|importing patrons so that |importing patrons so that |for the expiry date is |the expiry date is updated |updated for existing|for existing patrons (Tools |patrons (Tools > Patrons > |> Patrons > Import patrons |Import patrons > Preserve |> Preserve existing values |existing values > Overwrite |> Overwrite the existing |the existing one with this |one with this > Renew |> Renew existing patrons - |existing patrons - from the |from the current membership |current membership expiry |expiry date). |date). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34621] Patron import option to 'Renew existing patrons' 'from the current membership expiry date' not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34621 David Nind changed: What|Removed |Added Text to go in the||This fixes the option when release notes||importing patrons so that ||for the expiry date is ||updated for existing ||patrons (Tools > Patrons > ||Import patrons > Preserve ||existing values > Overwrite ||the existing one with this ||> Renew existing patrons - ||from the current membership ||expiry date). CC||da...@davidnind.com --- Comment #4 from David Nind --- Testing notes using KTD: 1. I used this data, saved as a CSV file, to test: cardnumber surname branchcode categorycode 23529000651225 Burton CPL PT 2. Before the patch was applied and after importing the patron data, the expiry date remained as 12/31/2099. 3. After the patch was applied and after importing the patron data, the expiry date was 03/31/2108 - adding 99 months (8 years and 3 months) for the Patron (PT) category. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #124 from Hammat wele --- Created attachment 154857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154857=edit Bug 12532: (follow-up) Send email to guarantor using the CC field In This patch the CC field is used to send the message to the guarantors. If the «to» field is empty (the guarantee has no address) we send the message «to» the garantors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele changed: What|Removed |Added Attachment #151029|0 |1 is obsolete|| --- Comment #123 from Hammat wele --- Created attachment 154856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154856=edit Bug 12532: (QA follow-up) Clean up notice_email_address Reduce some of the code duplication -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele changed: What|Removed |Added Attachment #151028|0 |1 is obsolete|| --- Comment #122 from Hammat wele --- Created attachment 154855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154855=edit Bug 12532: (QA follow-up) Undo changes to Koha::Email The changes here aren't required (Email::Address already deals with lists of addresses internally) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Hammat wele changed: What|Removed |Added Attachment #150256|0 |1 is obsolete|| --- Comment #121 from Hammat wele --- Created attachment 154854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154854=edit Bug 12532: Send email to guarantee and guarantor This patch allows guarantors to receive emails sended to their guarentees. This patch is a rebase of the previous patches. I took all the content of previous commit and put it in one commit. TO TEST: Before applying: 1) Search, or create, a patron with guarantor. 2) For both guarantors and guarantees: - Add an email address - Update the 'Patron messaging preferences' section so that an email is sent for item checkouts 3) Checkout an item. An email should be sent only to the guarantee. 4) Apply the patch. 5) Run updatedatabase.pl 6) Run prove t/db_dependent/Members.t and prove t/db_dependent/Letters.t 7) Enable 'RedirectGuaranteeEmail' 8) Run misc/cronjobs/process_message_queue.pl 9) Notice that the email should be sended to both the guarantee AND the guarantor. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34621] Patron import option to 'Renew existing patrons' 'from the current membership expiry date' not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34621 David Nind changed: What|Removed |Added Attachment #154842|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 154853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154853=edit Bug 34621: implement Patron import option to 'Renew existing patrons' 'from the current membership expiry date' Test Plan: 1) Test importing a patron with the "from the current membership expiry date" option, note it does not work 2) Apply this patch 3) Restart all the things! 4) Re-test, note the expiration was renewed from the patron's current expiration date! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34621] Patron import option to 'Renew existing patrons' 'from the current membership expiry date' not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34621 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #120 from Hammat wele --- (In reply to Martin Renvoize from comment #116) > Sorry, I also meant to say I think the guarantor email should go in the cc > field rather than to field (unless the to field is empty in which case just > put guarantor in to). This complicates things a little but I feel it's the > right behaviour (In reply to Martin Renvoize from comment #118) > I agree Marcel.. It was late last night. > > So.. In short, I'd like some explanations from the original author as to why > they picked the changes they did.. I still don't understand a number of them. > > I think hooking into _send_message_by_email in C4::Letters is starting to > feel like it might be the right place... but setting a `cc` rather than > additional `to` Hi martin, The main goal here was to send email to both the guarantor and the guarantee either we use the to or cc field. But I agree with you, we should use the cc field to send the message to the garantors instead adding garantor addresses to the to field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31035] Script to update OPACSuppression field depending on hidden items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31035 --- Comment #8 from Fridolin Somers --- Currently we use this script but not for OpacSuppress feature in Koha's OPAC. The script is used to set special field 099$o to 1 when all items are hidden. This allows to define an OAI set with 099$o != 1. This set is used for portal import of records, skipping unwanted records. May also be used to filter records export to portal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31035] Script to update OPACSuppression field depending on hidden items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31035 --- Comment #7 from Fridolin Somers --- Created attachment 154852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154852=edit Bug 31035: (follow-up) handle broken MARCXML Plus show progress each 1000 records -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34275] Add a button to easily toggle between advanced/basic cataloging editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34275 Lucas Gass changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #9 from Lucas Gass --- (In reply to Martin Renvoize from comment #8) > Whilst the functionality here works nicely, I'm not sure about the styling > myself. > > I think I'd either prefer a 'Switch to X editor' button that contextually > sets 'X' or an 'Advanced editor: TOGGLE' with a narrower simple toggle > switch rather than the large toggle the includes the text within it. > > Tagging Owen for that more artistic eye ;P That makes sense. I'll come back to this one ASAP. For now I'll set to FQA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34626] Add waiting since date to holdswaiting patron message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34626 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34626] Add waiting since date to holdswaiting patron message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34626 --- Comment #1 from Lucas Gass --- Created attachment 154851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154851=edit Bug 34626: Add waitingdate to holdswaiting patron message To test: 1. Apply patch 2. Place 2 or more holds for a patron and trigger them so they are waiting holds. 3. Now go to both moremember.tt and circulation.tt for that patron. 4. Confirm that you now see a 'Waiting here since' message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34626] Add waiting since date to holdswaiting patron message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34626 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34626] New: Add waiting since date to holdswaiting patron message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34626 Bug ID: 34626 Summary: Add waiting since date to holdswaiting patron message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com On moremember.tt and ciculation.tt there will be a message if the patron has any waiting holds. This message displays the date the hold was placed on (reserves.reservedate) and the date it will wait until ( reservedate.expirationdate ). Some libraries would like to add the 'Waiting since' date. ( reservedate.waitingdate ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34620] Writeoff causes 500 error if RequirePaymentType is on.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34620 David Nind changed: What|Removed |Added Text to go in the||This fixes writing off a release notes||charge when the ||RequirePaymentType system ||preference is set to ||required. The write-off now ||completes successfully ||without generating an error ||page (Patrons > [patron ||account] > Accounting > ||Make a payment > Write off ||an individual charge). CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34620] Writeoff causes 500 error if RequirePaymentType is on.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34620 David Nind changed: What|Removed |Added Attachment #154835|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 154850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154850=edit Bug 34620: Do not throw expection if payment type is writeoff To test: 1. Turn on RequirePaymentType 2. Create a manual invoice and then attempt to write it off. 3. 500 error 4. Turn of RequirePaymentType, no error. 5. Apply patch, restart_all 6. Try step 2 again, you should not get an error 7. prove t/db_dependent/Koha/Account.t 8. Make sure tests pass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34620] Writeoff causes 500 error if RequirePaymentType is on.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34620 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34625] Search engine configuration tables header problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34625 Fridolin Somers changed: What|Removed |Added Depends on||33180 --- Comment #1 from Fridolin Somers --- I bet it is since Bug 33180 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33180 [Bug 33180] Use template wrapper for tabs: Budgets and Search engine configuration -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33180] Use template wrapper for tabs: Budgets and Search engine configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33180 Fridolin Somers changed: What|Removed |Added Blocks||34625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34625 [Bug 34625] Search engine configuration tables header problem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34625] New: Search engine configuration tables header problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34625 Bug ID: 34625 Summary: Search engine configuration tables header problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org Created attachment 154849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154849=edit Screenshot of problem Search engine configuration, when selecting second tab you seen no header. When going down you see the floating header of first tab o_O -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33910] Improve translation of title tags: Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 --- Comment #7 from Owen Leonard --- Created attachment 154848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154848=edit Bug 33910: (follow-up) Remove mistaken addition of 'USE raw' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34408] Inconsistencies in SMTP servers page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34408 Owen Leonard changed: What|Removed |Added Attachment #154836|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 154847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154847=edit Bug 34408: Inconsistencies in SMTP servers page titles, breadcrumbs, and header This patch updates the SMTP servers administration page in order to make the page title, breadcrumb navigation, and page headings consistent with each other. The patch also adds a space between the delete button icon and the text. To test apply the patch and go to Administration -> SMTP servers. - Confirm that the page header, breadcrumb navigation, and page headings are consistent on each view of the page: - Main page - New SMTP server - Edit SMTP server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Owen Leonard changed: What|Removed |Added Blocks||34408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34408 [Bug 34408] Inconsistencies in SMTP servers page titles, breadcrumbs, and header -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34408] Inconsistencies in SMTP servers page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34408 Owen Leonard changed: What|Removed |Added Depends on||34616 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 [Bug 34616] "Edit SMTP server" page shows unintended dialog -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #11 from Owen Leonard --- Created attachment 154846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154846=edit Bug 34616: Move default server info outside the Also DRY current default information dialog block Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #10 from Owen Leonard --- Created attachment 154845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154845=edit Bug 34616: Fix showing default server info on edit SMTP server page Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Owen Leonard changed: What|Removed |Added Attachment #154838|0 |1 is obsolete|| Attachment #154839|0 |1 is obsolete|| Attachment #154840|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 154844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154844=edit Bug 34616: Add native bootstrap behaviour to default server dialog Test plan: Create a new SMTP server Tick the 'default server' checkbox Verify it now has a backdrop, closes if u click the backdrop or press 'esc' The Yes and No buttons are now styled properly Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34624] Many header search forms lack for attribute for label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 --- Comment #1 from Owen Leonard --- Created attachment 154843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154843=edit Bug 34624: Add "for" attribute to label in header search forms which lack it This patch adds a "for" label to header search forms labels which lack it. To test, apply the patch and test the affected pages to confirm that clicking the label corresponding to the active search form can be clicked to move cursor focus to that input field. As you activate each search form, the cursor focus will automatically be moved to the input. Click outside of the field to remove the focus, and then click the label to test that it is correctly tied to the field. - Staff interface home page: - Checkout, Check in, Renew, Search patrons, and Search catalog. - Acquisitions: Vendor search and orders search - Acquisitions -> Vendor search -> Vendor -> Contracts: Contract search - Acquisitions -> Vendor search -> Vendor -> Basket -> Add to basket -> From a suggestion: Search suggestions - Authorities: Main heading ($a only), Main heading, All headings, and Entire record. - Administration -> Budgets: Search funds - Administration -> Cities & towns: City search - Administration -> Currencies: Currencies search - Administration -> Desks: Search desks * With UseCirculationDesks enabled - Administration -> Patron categories: Search patron categories - Administration -> System preferences: Search system preferences - Administration -> Z39.50 servers -> Z39.50 server search - Cataloging: Cataloging search - E-resource management: Search agreements, Search licenses, Search packages, and Search titles * With ERMModule enabled - Patrons -> Search patrons - Serials: Search subscriptions - Tools -> Notices & slips: Search notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34624] Many header search forms lack for attribute for label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34609] Holds history errors 500 if old_reserves.biblionumber is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34609 --- Comment #4 from Martin Renvoize --- There's some prior art for tests for this . I hate writing them as they feel like over repetition... but they would have caught this regression.. so... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27920] Add ability to update patron expiration dates when importing patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 Kyle M Hall changed: What|Removed |Added Blocks||34621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34621 [Bug 34621] Patron import option to 'Renew existing patrons' 'from the current membership expiry date' not implemented -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34621] Patron import option to 'Renew existing patrons' 'from the current membership expiry date' not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34621 Kyle M Hall changed: What|Removed |Added Depends on||27920 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27920 [Bug 27920] Add ability to update patron expiration dates when importing patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34624] New: Many header search forms lack for attribute for label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34624 Bug ID: 34624 Summary: Many header search forms lack for attribute for label Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: accessibility Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org In the header search forms, we have a label which is associated with the form field, but in many cases the label doesn't have a "for" attribute. This is a problem for HTML validity and for accessibility. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34621] Patron import option to 'Renew existing patrons' 'from the current membership expiry date' not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34621 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34621] Patron import option to 'Renew existing patrons' 'from the current membership expiry date' not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34621 Kyle M Hall changed: What|Removed |Added Attachment #154841|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 154842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154842=edit Bug 34621: implement Patron import option to 'Renew existing patrons' 'from the current membership expiry date' Test Plan: 1) Test importing a patron with the "from the current membership expiry date" option, note it does not work 2) Apply this patch 3) Restart all the things! 4) Re-test, note the expiration was renewed from the patron's current expiration date! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34621] Patron import option to 'Renew existing patrons' 'from the current membership expiry date' not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34621 --- Comment #1 from Kyle M Hall --- Created attachment 154841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154841=edit Bug 34621: implement Patron import option to 'Renew existing patrons' 'from the current membership expiry date' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34621] Patron import option to 'Renew existing patrons' 'from the current membership expiry date' not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34621 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34609] Holds history errors 500 if old_reserves.biblionumber is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34609 --- Comment #3 from Lucas Gass --- Thanks Pedro, this works! Do you think we need unit tests for this change? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34609] Holds history errors 500 if old_reserves.biblionumber is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34609 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #2 from Lucas Gass --- *** Bug 34603 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34603] Deleted biblio causes holdshistory.tt to explode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34603 Lucas Gass changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Lucas Gass --- *** This bug has been marked as a duplicate of bug 34609 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #8 from Pedro Amorim --- Created attachment 154840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154840=edit Bug 34616: Move default server info outside the Also DRY current default information dialog block -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #7 from Pedro Amorim --- Created attachment 154839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154839=edit Bug 34616: Fix showing default server info on edit SMTP server page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #6 from Pedro Amorim --- Created attachment 154838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154838=edit Bug 34616: Add native bootstrap behaviour to default server dialog Test plan: Create a new SMTP server Tick the 'default server' checkbox Verify it now has a backdrop, closes if u click the backdrop or press 'esc' The Yes and No buttons are now styled properly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34400] Inconsistencies in OAI sets page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34400 Owen Leonard changed: What|Removed |Added Severity|enhancement |minor Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #5 from Pedro Amorim --- (In reply to Owen Leonard from comment #2) > I can reproduce the problem. The template shows a "default configuration" > dialog inside the SMTP server entry form. I don't know why. > > Was the intention for this dialog to show above the form? Or should it not > display at all? Wait, I stand corrected. It seems this is intended to show on servers that are not tagged as the "is_default" SMTP Server. But the styling seems to have gone crazy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #4 from Pedro Amorim --- (In reply to Owen Leonard from comment #2) > I can reproduce the problem. The template shows a "default configuration" > dialog inside the SMTP server entry form. I don't know why. > > Was the intention for this dialog to show above the form? Or should it not > display at all? Wait, I stand corrected. It seems this is intended to show on the "is_default" SMTP Server. But the styling seems to have gone crazy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34622] SMTP server edit page unsets is_default if editing default server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34622 --- Comment #1 from Pedro Amorim --- Created attachment 154837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154837=edit Bug 34622: Fix store default query Exclude self smtp server from all the servers being updated to not default if self is_default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34622] SMTP server edit page unsets is_default if editing default server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34622 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34622] New: SMTP server edit page unsets is_default if editing default server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34622 Bug ID: 34622 Summary: SMTP server edit page unsets is_default if editing default server Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: dc...@prosentient.com.au, gmcha...@gmail.com, katrin.fisc...@bsz-bw.de, k...@bywatersolutions.com, martin.renvo...@ptfs-europe.com, n...@bywatersolutions.com, tomasco...@gmail.com Depends on: 27424 To reproduce: 1) Create a new SMTP Server (tick "Default server" checkbox). Save. 2) Now edit that same SMTP Server, don't change anything. Save. 3) Notice how it no longer is default, from the list or by editing again, or by querying SELECT is_default from smtp_servers -> returns is_default:0 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 [Bug 27424] One should be able to assign an SMTP server as the default -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Pedro Amorim changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34622 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27424] One should be able to assign an SMTP server as the default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27424 Pedro Amorim changed: What|Removed |Added Blocks||34622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34622 [Bug 34622] SMTP server edit page unsets is_default if editing default server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34621] New: Patron import option to 'Renew existing patrons' 'from the current membership expiry date' not implemented
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34621
Bug ID: 34621
Summary: Patron import option to 'Renew existing patrons' 'from
the current membership expiry date' not implemented
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Tools
Assignee: koha-bugs@lists.koha-community.org
Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
On bug 27920 the interface got a new option to extend the patron's renewal from
the current membership expiry date by setting the variable 'update_dateexpiry'
to 'dateexpiry'
The code in tools/import_borrowers.pl however only checks for value 'now':
127 update_dateexpiry=> $update_dateexpiry ? 1 : 0,
And in Koha/Patrons/Import.pm - we either use the value from the import file,
or today's date:
176 my $expiration_start_date = $update_dateexpiry_from_today ?
dt_from_string : $borrower{dateenrolled};
We should either implement or remove this option
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34408] Inconsistencies in SMTP servers page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34408 --- Comment #1 from Owen Leonard --- Created attachment 154836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154836=edit Bug 34408: Inconsistencies in SMTP servers page titles, breadcrumbs, and header This patch updates the SMTP servers administration page in order to make the page title, breadcrumb navigation, and page headings consistent with each other. The patch also adds a space between the delete button icon and the text. To test apply the patch and go to Administration -> SMTP servers. - Confirm that the page header, breadcrumb navigation, and page headings are consistent on each view of the page: - Main page - New SMTP server - Edit SMTP server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34408] Inconsistencies in SMTP servers page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34408 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34620] Writeoff causes 500 error if RequirePaymentType is on.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34620 Lucas Gass changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | Severity|enhancement |normal Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34620] Writeoff causes 500 error if RequirePaymentType is on.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34620 --- Comment #1 from Lucas Gass --- Created attachment 154835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154835=edit Bug 34620: Do not throw expection if payment type is writeoff To test: 1. Turn on RequirePaymentType 2. Create a manual invoice and then attempt to write it off. 3. 500 error 4. Turn of RequirePaymentType, no error. 5. Apply patch, restart_all 6. Try step 2 again, you should not get an error 7. prove t/db_dependent/Koha/Account.t 8. Make sure tests pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34620] Writeoff causes 500 error if RequirePaymentType is on.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34620 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34552] Statistics wizards : Cash register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 --- Comment #3 from Nick Clemens --- Created attachment 154834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154834=edit Bug 34552: Don't exclude payments with no status Bug 29664 removed payments with a void status, however, the query also removed any payments with no status set Test Plan: 1 - Set up your cash registers and enable POS and add a debit type that is able to be sold 2 - Take 2 payments via POS 3 - Void one payment 4 - Go to Reports->Statistics wizards->Cash register 4) Verify neither shows for the "All payments to the library" and "Payment" transaction type filters 5) Apply this patch 6) Restart all the things! 7) Verify the non-voided fee shows for the "All payments to the library" and "Payment" transaction type filters and the voided fee does not -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34552] Statistics wizards : Cash register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34408] Inconsistencies in SMTP servers page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34408 Owen Leonard changed: What|Removed |Added Severity|enhancement |minor Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34617] Patron expiration dates not updated during import when there is no dateexpiry column in the file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Joseph Alway changed: What|Removed |Added CC||jbal...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29664] Do not show voided payments in cash register statistics wizard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Nick Clemens changed: What|Removed |Added Blocks||34552 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 [Bug 34552] Statistics wizards : Cash register -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34552] Statistics wizards : Cash register
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | Depends on||29664 CC||n...@bywatersolutions.com Severity|minor |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 [Bug 29664] Do not show voided payments in cash register statistics wizard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33608] Allow to get statistics about found/recovered books
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33608 --- Comment #76 from Andrew Fuerste-Henry --- If we're recording this in statistics, I'd love to see it included in what we also enter in pseudonymized_transactions. Otherwise this data is lost when/if libraries delete their old statistics lines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #49 from Marcel de Rooy --- (In reply to Pedro Amorim from comment #48) > Marcel, please take a look at my patches for SO, or mark obsolete if you > don't agree! Thx Pedro. I certainly will. But it sounds very promising! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33176] Improve enforcing of RequirePaymentType
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 Lucas Gass changed: What|Removed |Added Blocks||34620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34620 [Bug 34620] Writeoff causes 500 error if RequirePaymentType is on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34620] Writeoff causes 500 error if RequirePaymentType is on.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34620 Lucas Gass changed: What|Removed |Added Depends on||33176 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33176 [Bug 33176] Improve enforcing of RequirePaymentType -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34620] New: Writeoff causes 500 error if RequirePaymentType is on.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34620 Bug ID: 34620 Summary: Writeoff causes 500 error if RequirePaymentType is on. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org To recreate: 1. Turn on RequirePaymentType 2. Create a manual invoice and then attempt to write it off. 3. 500 error 4. Turn of RequirePaymentType, no error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34619] New: Show debug mode column in list of SMTP servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34619 Bug ID: 34619 Summary: Show debug mode column in list of SMTP servers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org On the SMTP server page we indicate that a server has debug mode enabled by changing the color of the text in the row, but that doesn't naturally convey any meaning. I think it would be good to add a column showing whether debug mode is on or off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33910] Improve translation of title tags: Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 --- Comment #6 from Katrin Fischer --- (In reply to Owen Leonard from comment #5) > (In reply to Katrin Fischer from comment #4) > > Only one little question, why the USE raw? > > > +[% USE raw %] > > +[% PROCESS 'i18n.inc' %] > > Just a copy-paste error I think Could you provide a quick follow-up to remove that line? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 --- Comment #3 from Pedro Amorim --- (In reply to Owen Leonard from comment #2) > I can reproduce the problem. The template shows a "default configuration" > dialog inside the SMTP server entry form. I don't know why. > > Was the intention for this dialog to show above the form? Or should it not > display at all? It's so weird, cause I can't reproduce it intentionally every time. It sometimes happens and other times it doesn't, at least for me! The intention, I believe, is not display at all in that edit form. That dialog should only display in the SMTP servers list page afaik. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Owen Leonard changed: What|Removed |Added Status|REOPENED|NEW Severity|enhancement |normal Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34616] "Edit SMTP server" page shows unintended dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34616 Owen Leonard changed: What|Removed |Added Resolution|INVALID |--- Status|RESOLVED|REOPENED --- Comment #2 from Owen Leonard --- I can reproduce the problem. The template shows a "default configuration" dialog inside the SMTP server entry form. I don't know why. Was the intention for this dialog to show above the form? Or should it not display at all? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m --- Comment #48 from Pedro Amorim --- Marcel, please take a look at my patches for SO, or mark obsolete if you don't agree! For reference, here is what I did to follow the test plan: 1) configured in koha-conf.xml 2) configured an smtp server with my own google account app password 3) did an OPAC password reset which prompted an entry in the message_queue table 4) duplicated that message entry a couple times: INSERT INTO message_queue (letter_id, borrowernumber, subject, content, letter_code, message_transport_type, status, to_address) SELECT letter_id, borrowernumber, subject, content, letter_code, message_transport_type, 'pending', 'pedro.amo...@ptfs-europe.com' FROM message_queue; 5) Run: perl misc/cronjobs/process_message_queue.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #47 from Pedro Amorim --- Created attachment 154833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154833=edit Bug 33537: (QA follow-up) Improve process_message_queue warning message Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #46 from Pedro Amorim --- Created attachment 154832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154832=edit Bug 33537: (QA follow-up) Add 'SMTP Servers' button to domain limits page Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #45 from Pedro Amorim --- Created attachment 154831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154831=edit Bug 33537: (QA follow-up) Update kohastructure.sql to match atomic update script Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #44 from Pedro Amorim --- Created attachment 154830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154830=edit Bug 33537: (QA follow-up) Use bootstrap modal native functions Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 --- Comment #43 from Pedro Amorim --- Created attachment 154829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154829=edit Bug 33537: (QA follow-up) Modal UI fixes: Use ol instead of ul in modal fieldset inputs: This ol->ul change makes the UI inputs more spaced and overall more in line with other modals in Koha. Use 'btn-primary' on 'Save' button to have it be shown yellow as other confirmation buttons in Koha. Add a11y attributes to modal form Also prettied HTML code: git show --ignore-all-space Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim changed: What|Removed |Added Attachment #154779|0 |1 is obsolete|| --- Comment #42 from Pedro Amorim --- Created attachment 154828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154828=edit Bug 33537: (QA follow-up) Resolve forbidden pattern in REST API Resolving: FAIL Koha/REST/V1/Config/SMTP/DomainLimits.pm FAIL forbidden patterns forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 57) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 75) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 103) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 106) forbidden pattern: Use of $c->validation in API controllers should be avoided (bug 33556) (line 133) Test plan: Run t/db_dependent/api/v1/domain_limits.t Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim changed: What|Removed |Added Attachment #154778|0 |1 is obsolete|| --- Comment #41 from Pedro Amorim --- Created attachment 154827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154827=edit Bug 33537: (QA follow-up) Tidy updated blocks in various files Resolving: WARN C4/Installer.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 170, now: 171) FAIL Koha/Exceptions/DomainLimit.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 4) WARN Koha/MailDomainLimit.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 1) WARN Koha/Notice/Util.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 26, now: 31) WARN admin/domain_limits.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 1) WARN installer/data/mysql/atomicupdate/bug33537.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 5) WARN t/db_dependent/Installer.t WARN tidiness The file is less tidy than before (bad/messy lines before: 18, now: 19) WARN t/db_dependent/Koha/MailDomainLimits.t WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 3) WARN t/db_dependent/Koha/Notice_Util.t WARN tidiness The file is less tidy than before (bad/messy lines before: 37, now: 38) WARN t/db_dependent/api/v1/domain_limits.t WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 7) WARN t/lib/TestBuilder.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 211, now: 212) FAIL Koha/REST/V1/Config/SMTP/DomainLimits.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 32) Test plan: Run qa tools. Note: Forbidden pattern warns in Koha/REST/V1/Config/SMTP/DomainLimits.pm are handled in next patch. Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim changed: What|Removed |Added Attachment #154777|0 |1 is obsolete|| --- Comment #40 from Pedro Amorim --- Created attachment 154826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154826=edit Bug 33537: Connect the dots Use Koha::MailDomainLimits in Koha::Notice::Util->load_domain_limits. Only use koha-conf as fallback when table is still empty. (This is just like SMTP servers.) The test is adjusted accordingly and has moved more to the database oriented side, first proving that both approaches return the same. Test plan: Run t/db_dependent/Koha/Notice_Util.t NOTE: Replace A and B hereunder by two domains of your own choice. Add a limit to KOHA-CONF: domain A, 1 per 1 hour. Add another limit in WEB CONFIG: domain B, 1 per 1 hour Send 2 notices to domain B. Is 1 message delayed? Remove the table entry for B. Run process_message_queue.pl. Is the delayed notice to B sent? Send 2 notices to domain A. Is 1 delayed (using koha-conf fallback)? Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim changed: What|Removed |Added Attachment #154776|0 |1 is obsolete|| --- Comment #39 from Pedro Amorim --- Created attachment 154825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154825=edit Bug 33537: Add staff template and script Test plan: Go to Administration/SMTP Servers. Click Domain limits. Do some CRUD operations. Bonus: Add another tab with domain limits. Edit or remove records on tab 1. Try CRUD on changed or removed records on tab 2. Signed-off-by: Marcel de Rooy [EDIT] Added some preventDefault calls, as suggested by JD. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537
Pedro Amorim changed:
What|Removed |Added
Attachment #154775|0 |1
is obsolete||
--- Comment #38 from Pedro Amorim ---
Created attachment 154824
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154824=edit
Bug 33537: REST API endpoints
Test plan:
Run t/db_dependent/api/v1/domain_limits.t
List, add (post), get, update (put) and delete domain limit(s).
Using the paths:
- api/v1/smtp/domain_limits
- api/v1/smtp/domain_limits/{SOME_ID}
Signed-off-by: Marcel de Rooy
Signed-off-by: Pedro Amorim
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim changed: What|Removed |Added Attachment #154774|0 |1 is obsolete|| --- Comment #37 from Pedro Amorim --- Created attachment 154823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154823=edit Bug 33537: Add Koha objects Test plan: Run t/db_dependent/Koha/MailDomainLimits.t Signed-off-by: Marcel de Rooy [EDIT] Run perltidy on MailDomainLimits.t Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim changed: What|Removed |Added Attachment #154773|0 |1 is obsolete|| --- Comment #36 from Pedro Amorim --- Created attachment 154822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154822=edit Bug 33537: Add undefined default value for belongs_to in TestBuilder Test plan: See next patch. It calls build_object without specifying belongs_to. Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim changed: What|Removed |Added Attachment #154772|0 |1 is obsolete|| --- Comment #35 from Pedro Amorim --- Created attachment 154821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154821=edit Bug 33537: [DBIx] Schema changes for mail_domain_limits Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim changed: What|Removed |Added Attachment #154771|0 |1 is obsolete|| --- Comment #34 from Pedro Amorim --- Created attachment 154820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154820=edit Bug 33537: Database revision, adding table mail_domain_limits Test plan: Run dbrev or new install. Verify that table is created as expected. Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim changed: What|Removed |Added Attachment #154770|0 |1 is obsolete|| --- Comment #33 from Pedro Amorim --- Created attachment 154819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154819=edit Bug 33537: Fix some POD in Installer.pm Test plan: Run qa tools. Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim changed: What|Removed |Added Attachment #154769|0 |1 is obsolete|| --- Comment #32 from Pedro Amorim --- Created attachment 154818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154818=edit Bug 33537: Add better named table_exists alias in Installer module Test plan: Run dbrev later. It is using table_exists. Run t/db_dependent/Installer.t Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33537] Move domain limits from koha-conf to staff SMTP configuration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33537 Pedro Amorim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34617] Patron expiration dates not updated during import when there is no dateexpiry column in the file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Nick Clemens changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33910] Improve translation of title tags: Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 --- Comment #5 from Owen Leonard --- (In reply to Katrin Fischer from comment #4) > Only one little question, why the USE raw? > +[% USE raw %] > +[% PROCESS 'i18n.inc' %] Just a copy-paste error I think -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34617] Patron expiration dates not updated during import when there is no dateexpiry column in the file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 --- Comment #3 from Nick Clemens --- Note, a workaround is simply to include a dateexpiry column in the file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34617] Patron expiration dates not updated during import when there is no dateexpiry column in the file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34617] Patron expiration dates not updated during import when there is no dateexpiry column in the file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34617 --- Comment #2 from Nick Clemens --- Created attachment 154817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154817=edit Bug 34617: Preserve calculated expiration dates if set to update on import whether column included or not To test: 1 - Setup a csv with column headers: surname firstname branchcode categorycodecardnumber dateenrolled 2 - add values Acosta EdnaCPL PT 23529001000463 02/01/2013 3 - Set PT catgeory enrollement period to a specific date in the future 4 - Import the file and overwrite patrons and update dateexpiration 5 - Check Edna, note her date is not correct 6 - Apply patch 7 - Repeat 8 - Expiration date is now set as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
