[Koha-bugs] [Bug 35629] Redundant code in includes/patron-search.inc

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35629

--- Comment #8 from Jonathan Druart  ---
Definitely a bad rebase conflict resolution. Thanks, Pedro!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35614] Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614

--- Comment #7 from Jonathan Druart  ---
libjson-validator-perl

buster (oldoldstable) 3.06+dfsg-1: all
bullseye (oldstable)  4.14+dfsg-1: all
bookworm (stable) 5.14+dfsg-1: all
trixie (testing)  5.14+dfsg-1: all
sid (unstable)5.14+dfsg-1: all

focal (20.04LTS) 3.23+dfsg-1: all
jammy (22.04LTS) 5.05+dfsg-1: all
lunar (23.04)5.13+dfsg-1: all
mantic (23.10)   5.14+dfsg-1: all 

libmojolicious-plugin-openapi-perl

bullseye (oldstable) 3.41-1: all
bookworm (stable)5.09-1: all
trixie (testing) 5.09-1: all
sid (unstable)   5.09-1: all

focal (20.04LTS) 2.21-1: all
jammy (22.04LTS) 5.02-1: all
lunar (23.04)5.09-1: all
mantic (23.10)   5.09-1: all 


So we still need to package our own.

Mason, are you ok with that? We would need to remove the '-really' and provide
JSON::Validator 5.14 and Mojolicious::Plugin::OpenAPI 5.09

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35614] Update cpanfile for Mojolicious::Plugin::OpenAPI v5.09

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35614

--- Comment #6 from Jonathan Druart  ---
What does it mean for the package manager? We need more info here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35625] Add support for system flag to additional fields

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35625

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.druart+koha@gmail.
   ||com

--- Comment #9 from Jonathan Druart  ---
The purpose of this table/ft was to add specific data. Flagging a fields as "is
mandatory for the system to work correctly" is wrong by design IMO. It should
be a column in the original table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35697] New: Checkingout books causes a error 500

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35697

Bug ID: 35697
   Summary: Checkingout books causes a error 500
 Change sponsored?: ---
   Product: Koha
   Version: 23.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jmpinpin@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 160509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160509=edit
Error 500 upon check out of book/library material

KOHA VER. 23.11.00 - January update
Checkingout books causes a error 500,
pressing the "Check out" botton with a blank barcode causes to redirect to
print issuequick slip.

I tested this on our system, and replicated the same issue on KOHA Demo
website.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681

--- Comment #18 from Martin Renvoize  ---
That sounds trivial, but is actually rather difficult due to the way they're
created. I'd like to eventually switch them to use the standard bookstrap
classes,  it right now there no way to achieve it with the library we're using
to convert ansi to html.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
  Text to go in the||This enhancement adds
  release notes||support for colored
   ||messages for Koha database
   ||updates, in both the
   ||terminal and browser.
   ||
   ||These new CSS classes are
   ||used:
   ||.updatedatabase-report-red
   ||for warnings
   ||.updatedatabase-report-gree
   ||n  for ?
   ||.updatedatabase-report-yell
   ||ow  where action is
   ||required
   ||.updatedatabase-report-blue
   || for information

--- Comment #17 from David Nind  ---
Testing notes (using KTD):

1. To get the colours to show in the browser update after applying the patches:
yarn build

2. Not a biggy, or a showstopper, but maybe the class names could be more
semantic? Not sure if there are any rules/guidelines for this.
   .updatedatabase-report-red  -warning
   .updatedatabase-report-green -? (not sure for this one)
   .updatedatabase-report-yellow -action-required
   .updatedatabase-report-blue -information

3. Also, there is no class .updatedatabase-report-white

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695

--- Comment #1 from Lucas Gass  ---
Created attachment 160508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160508=edit
Bug 35695: Remove useless JS from cataloging_additem.js

To test:
1. APPLY PATCH
2. Turn on EnableItemGroups
3. Go to a record with item groups, or create some.
4. Add an item, making sure items can be added to a group. ( Bug 33639 must be
applied )

If I am wrong and this code should stay, tell me. I'll fix the jQuery instead
of removing it. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35696] New: Transit status not properly updated for items advanced in Stock Rotation tool

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35696

Bug ID: 35696
   Summary: Transit status not properly updated for items advanced
in Stock Rotation tool
 Change sponsored?: ---
   Product: Koha
   Version: 23.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: heat...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 160507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160507=edit
Transit status of stock rotation items 23.05.06

While using the stock rotation tool in the Cataloging module, when items in
rotas are advanced to the next stage, the status is not updating properly. In a
proper status update for advancing items, the status reads "Transit pending
from XX branch to YY branch since mm/dd/" which displays in 22.11.10. In
23.05.06, the status updates to show "Transit is pending from XX branch to YY
branch since Available".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33639] Adding item to item group from 'Add item' screen doesn't work

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639

Lucas Gass  changed:

   What|Removed |Added

 Blocks||35695


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695
[Bug 35695] Remove useless item group code from cataloging_additem.js
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35695] Remove useless item group code from cataloging_additem.js

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695

Lucas Gass  changed:

   What|Removed |Added

 Depends on||33639


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33639
[Bug 33639] Adding item to item group from 'Add item' screen doesn't work
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35695] New: Remove useless item group code from cataloging_additem.js

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35695

Bug ID: 35695
   Summary: Remove useless item group code from
cataloging_additem.js
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

As I worked on Bug 33639 I noticed some code in cataloging_additem.js that
doesn't work/isn't needed:

137 $('#item-group-add-or-create-form-select').on('change', function() {
138 if ( ! $('input.items-enumchron').val() ) {
139 let item_group_selector = '#item-group-' + $(this).val();
140 let enumchron = $(item_group_selector).val();
141 $('input.items-enumchron').val( enumchron );
142 }
143 });


The selectors are bad and it would be easy to make them work. But I don't see
any reason why item groups should be updating the items.enumchron field.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681

David Nind  changed:

   What|Removed |Added

 Attachment #160473|0   |1
is obsolete||

--- Comment #16 from David Nind  ---
Created attachment 160506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160506=edit
Bug 35681: Use CSS class instead of inline style

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681

David Nind  changed:

   What|Removed |Added

 Attachment #160449|0   |1
is obsolete||

--- Comment #15 from David Nind  ---
Created attachment 160505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160505=edit
Bug 35681: Add new perl dependancy

Signed-off-by: Pedro Amorim 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681

David Nind  changed:

   What|Removed |Added

 Attachment #160448|0   |1
is obsolete||

--- Comment #14 from David Nind  ---
Created attachment 160504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160504=edit
Bug 35681: Allow for ANSI color in database updates

This patch adds support for colored output in database updates.

Signed-off-by: Pedro Amorim 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681

David Nind  changed:

   What|Removed |Added

 Attachment #160447|0   |1
is obsolete||

--- Comment #13 from David Nind  ---
Created attachment 160503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160503=edit
Bug 35681: [TEST ONLY]: This is a dummy dbrev to force an update

This patch adds an atomic update file and also an equivilent db_rev and
increments the Koha.pm version too.

Use it to test the output of updatedatebase, run via console or via the
browser.

Test plan
1) Start KTD without the patches applied.
2) Apply this test patch
3) Run the detabase updates via the console and confirm it looks
   reasonable and is colored.
4) Reset the database version in ktd
   `koha-mysql kohadev`
   `UPDATE systempreferences SET value = '23.122';`
5) Run the database updates via the browser;
  
`http://localhost:8081/cgi-bin/koha/installer/install.pl?step=3=updatestructure`
6) Confirm the presence of weird looking escape characters on screen.
7) Apply the next patch and run through steps 3 to 5 again, this time
   confirming the browser output looks good.

Signed-off-by: Pedro Amorim 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35694] New: Give pages the option to be a page or modal

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35694

Bug ID: 35694
   Summary: Give pages the option to be a page or modal
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

Currently, you can only display pages as pages.  However, there is a preview
button that shows the content in a modal.  I think that some of the content
would be better as a modal.  It would be great if we could specify whether the
content is displayed as a page or as a modal.

I do get that this depends on the page it is linked from, but would imagine
there are ways to deal with this.  I've created modals on pages via jQuery with
no problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31617] Allow manual editing of suggestions.biblionumber

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31617

Kris  changed:

   What|Removed |Added

 CC||kbec...@jcls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35693] New: Granular Permissions to Everything

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35693

Bug ID: 35693
   Summary: Granular Permissions to Everything
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

I don't know exactly how to file this.  Koha is growing all the time and new
features are always being added, but they are often being added with very
little permission granularity.  Often the permissions are too broad.  For
example, the newer pages under additional-contents.pl is under the entire
umbrella of one permission for the user, and gives them access to ALL pages,
ALL news, and ALL HTML customizations.

I am hoping that Koha will start thinking more about roles in the library, and
allowing us to give specific people access to specific pages, customizations,
etc.  This goes even further with who can override things.  We don't have a lot
of control over who can do what specific things.

Maybe there is a bug on this topic already?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28844] Suggestion from existing title can alert patron in error

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28844

--- Comment #50 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #49)
> (In reply to Katrin Fischer from comment #48)
> > Maybe we could extend the relationship later. At the moment we create an
> > order from a suggestion, so a 1:1 makes sense.
> > 
> > When I tested this my main concern was to ensure that the suggestions
> > existing previously to this fix would still work, patrons receiving emails
> > etc. Did you take a look at that aspect?
> 
> Yes, but didn't fix it. Seen comment 35?

Yes, but ... 

I think we need to fix this, but I also think we can't break existing
suggestions especially since it involves a service the library provides to
their patrons and they can't really fix it in the GUI either.

Too late today, but we should give this some more thought.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35658] Typo in /patrons/:patron_id/holds

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35658

--- Comment #3 from Katrin Fischer  ---
I am sorry, holidays got in the way - it's next on my 'push list' already.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692

David Nind  changed:

   What|Removed |Added

 Attachment #160500|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 160502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160502=edit
Bug 35692: Do not update not for loan status if ONLYMESSAGE is provided

To test:
1 - Set UpdateNotForLoanStatusOnCheckin to:
_ALL_:
  -1: ONLYMESSAGE
2 - Set an item in the catalog as -1/Ordered
3 - Check the item in
4 - Confirm you see the message
5 - View the record details
6 - Item is now for loan
7 - Check item in again, no message
8 - Apply patch, restart all
9 - Set item as not for loan -1/Ordered
10 - Check item in, you see the message
11 - Check it in again, still see message
12 - Check the detail page, item still marked as ordered

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692

David Nind  changed:

   What|Removed |Added

 Attachment #160499|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 160501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160501=edit
Bug 35692: Unit test

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34200] Lists and merge catalog records

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34200

--- Comment #10 from Christopher Brannon  ---
I agree that this is an incomplete merge, and is a bug.  It is definitely not a
desired (and I doubt intended) result.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21314] Koha enforces three (3) character password length even if RequireStrongPassword is disabled

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21314

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #16 from Christopher Brannon  ---
(In reply to Marcel de Rooy from comment #10)
> +if ( C4::Context->preference('RequireStrongPassword') ) {
> +$minPasswordLength = 3 if $minPasswordLength < 3;
> +}
> 
> How strong is that? LOL
> Imo we should enforce at least 8 chars or so, and educate users that
> security has a price.

Our library practices similar methods, and we've run into this issue as well. 
I've never liked software that tells users how to enforce their security.  The
options should be there, and how secure or insecure they choose to run it
should be up to them.  However, there are bugs, like
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 that focus on
improving things in another way, which would give us more flexibility and
options.

It just feels like libraries are being forced to bend to the will of
programmers based on personal opinions.  There are a lot of minimum values that
could be forced on libraries and their patrons, but that should be the choice
of the library, not the program.

Imo, our default passwords SHOULD be stronger.  But I don't get to make that
decision, so why should a developer?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35672] Update and Run SQL button should save changes even if report fails to run

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672

Dave  changed:

   What|Removed |Added

 CC||ddagh...@mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34575] Patron search results: Customise the fields displayed in Name column

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34575

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35666] Make it possible to cancel the transfer of the item

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35666

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz

--- Comment #3 from Alex Buckley  ---
Hi Nick, 

I noticed that too!

I submitted a patchset in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 but happy for
your patchset to be upstreamed instead :)

Thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692

--- Comment #2 from Nick Clemens  ---
Created attachment 160500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160500=edit
Bug 35692: Do not update not for loan status if ONLYMESSAGE is provided

To test:
1 - Set UpdateNotForLoanStatusOnCheckin to:
_ALL_:
  -1: ONLYMESSAGE
2 - Set an item in the catalog as -1/Ordered
3 - Check the item in
4 - Confirm you see the message
5 - View the record details
6 - Item is now for loan
7 - Check item in again, no message
8 - Apply patch, restart all
9 - Set item as not for loan -1/Ordered
10 - Check item in, you see the message
11 - Check it in again, still see message
12 - Check the detail page, item still marked as ordered

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692

--- Comment #1 from Nick Clemens  ---
Created attachment 160499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160499=edit
Bug 35692: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only the notforloan values description

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407

Nick Clemens  changed:

   What|Removed |Added

 Blocks||35692


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692
[Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not
honored
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560

Nick Clemens  changed:

   What|Removed |Added

 Blocks||35692


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692
[Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not
honored
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692

Nick Clemens  changed:

   What|Removed |Added

 Depends on||30407, 25560
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560
[Bug 25560] Define itemtype specific rules in the
UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30407
[Bug 30407] Add ability to syspref UpdateNotForLoanStatusOnCheckin to show only
the notforloan values description
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35692] New: ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692

Bug ID: 35692
   Summary: ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin
is not honored
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

It looks like between bug 30407 and bug 25560 we lost the line that made the
update conditional:

 $item->notforloan($rules->{$key})->store({ log_action => 0, skip_record_index
=> 1, skip_holds_queue => 1 }) unless $rules->{$key} eq 'ONLYMESSAGE';

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26912] Expired staff accounts can still log in to Koha staff intranet, SIP, API, etc.

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26912

Michael Adamyk  changed:

   What|Removed |Added

 CC||mada...@ckls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35690] Searching patrons with contains does not provide relevant results

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35690

Michael Adamyk  changed:

   What|Removed |Added

 CC||mada...@ckls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648

Lucas Gass  changed:

   What|Removed |Added

 Attachment #160495|0   |1
is obsolete||

--- Comment #5 from Lucas Gass  ---
Created attachment 160498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160498=edit
Bug 35648: Allow sorting of patron categories in Overdue notice/status triggers

This patch adds a basic DataTables configuration to the table of patron
categories on the Overdue notice/status triggers page. The table can be
sorted by patron category and can be filtered.

To test, apply the patch and go to Tools -> Overdue notice/status
triggers.

- Confirm that the table of patron categories is sorted by default by
   patron category
- Other columns should not be sortable
- You should see a search field above the table which works to filter by
  patron category.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35691] Remove the AUTO_RENEWALS notice in favor of AUTO_RENEWALS_DGST

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35691

Lucas Gass  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35691] New: Remove the AUTO_RENEWALS notice in favor of AUTO_RENEWALS_DGST

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35691

Bug ID: 35691
   Summary: Remove the AUTO_RENEWALS notice in favor of
AUTO_RENEWALS_DGST
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

In my opinion the AUTO_RENEWALS notice is unnecessary since we have the
digestible version (AUTO_RENEWALS_DGST).

In my experience almost nobody wants the non-digestible version and many
patrons are annoyed when they are sent multiple notifications undigested. 

And less emails per recipient is good. 


However, maybe I am missing a good use case for non-digestible auto renewal
notices?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461

--- Comment #15 from David Nind  ---
(In reply to Kyle M Hall from comment #12)

> Nope, the unit test was missing a comma causing it to fail all the time and
> in my haste I didn't re-test the "fixed" version against the patch to ensure
> it passed afterward! It's ready to test again!

Those pesky commas! 8-; Thanks Kyle. Now signed off!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461

David Nind  changed:

   What|Removed |Added

 Attachment #160454|0   |1
is obsolete||

--- Comment #14 from David Nind  ---
Created attachment 160497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160497=edit
Bug 35461: Fix function call parameters causing the HASH to show in the renew
all responses

"Renew All" -function aka. 65-66-messages work like this: 66-return messages
has renewed items in BM-fields and non-renewables go into BN-fields.

If all items were renewable, then the reply message looks like:

Reply:
13.07.2022 10:06:17:530 OUTESTI1 661000520220713
100616AOOUPK|BM564N15977171|BM564N09203960|BM564N23261720|BM564N25161958|BM564N23455012|C4::SIP::SIPServer=HASHC4::SIP::SIPServer=HASHAY6AZCEFE

If items include renewables and non-renewables, the response includes the
renewed  items first, then a HASH mixed into the first BN-field, then rest of
the renewed ones like they should show in BN-fields and after that, anohter
HASH:

13.07.2022 14:41:32:610 OUTESTI1 6610003000420220713
144130AOOUPK|BM564N23455012|BM564N23261720|BM564N25161958|C4::SIP::SIPServer=HASHBN564N09203960|BN564N04191259|BN564N15977171|BN564N13788332|C4::SIP::SIPServer=HASHAY8AZC7C5

If all loans were unrenewable (this test included just one item), you first get
a HASH in a BN-field, and another at the end.

13.07.2022 14:49:00:037 OUTESTI1 661000120220713
144858AOOUPK|C4::SIP::SIPServer=HASHBN564N19874533|C4::SIP::SIPServer=HASHAY9AZDD3B

Our self checkout/checkin machine can handle/parse these reply messages
correctly, but this might not be the case with all self checkout/checkin
devices.

Test Plan:
1) Unit test patch
2) prove t/db_dependent/SIP/Message.t
3) Note failures
4) Apply this patch
5) prove t/db_dependent/SIP/Message.t
6) Tests pass!

Signed-off-by: Kyle M Hall 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461

David Nind  changed:

   What|Removed |Added

 Attachment #160453|0   |1
is obsolete||

--- Comment #13 from David Nind  ---
Created attachment 160496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160496=edit
Bug 35461: Add unit tests

Signed-off-by: Kyle M Hall 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35461] Renew All 66 SIP server response messages produce HASH content in replies

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35461

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648

Owen Leonard  changed:

   What|Removed |Added

 Attachment #160455|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 160495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160495=edit
Bug 35648: Allow sorting of patron categories in Overdue notice/status triggers

This patch adds a basic DataTables configuration to the table of patron
categories on the Overdue notice/status triggers page. The table can be
sorted by patron category and can be filtered.

To test, apply the patch and go to Tools -> Overdue notice/status
triggers.

- Confirm that the table of patron categories is sorted by default by
   patron category
- Other columns should not be sortable
- You should see a search field above the table which works to filter by
  patron category.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35690] New: Searching patrons with contains does not provide relevant results

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35690

Bug ID: 35690
   Summary: Searching patrons with contains does not provide
relevant results
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: laura.escami...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Example:

In this example the library has the PatronSearchMethod system preference set to
'contains'.

They attempted to search for a patron named 'Don Smith' but the primary search
results are showing names such as 'Brandon Smith' and patrons who are located
at their 'Smith Public Library' such as 'Madonna Jones - Smith Public Library'. 

It would be ideal if the search results showed relevant patrons first before
suggesting patrons located at their 'Smith Public Library'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35672] Update and Run SQL button should save changes even if report fails to run

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672

Barbara Johnson  changed:

   What|Removed |Added

 CC||barbara.johnson@bedfordtx.g
   ||ov

--- Comment #2 from Barbara Johnson  ---
+1 as well

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35672] Update and Run SQL button should save changes even if report fails to run

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

--- Comment #1 from George Williams (NEKLS)  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35672] Update and Run SQL button should save changes even if report fails to run

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35672

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35648] Allow sorting of patron categories in Overdue notice/status triggers

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35648

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #3 from Owen Leonard  ---
Thanks Lucas, that was a dumb oversight. I will redo the patch and correct the
ID error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 32968] Create granular permissions for ERM

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32968

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35676] OPAC search results - link for "Check for suggestions" generates a blank page

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35676

Owen Leonard  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org
   Severity|minor   |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35509] Make SQL autocomplete an optional feature

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35509

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35646] Allow using the publication date parts for serial numbering

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35646

Dani Elder  changed:

   What|Removed |Added

 CC||danielle.elder@law.utexas.e
   ||du

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31572] E-mail and SMS verification

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31572

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19501] New list category to restrict specific lists to staff & hide from OPAC

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31572] E-mail and SMS verification

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31572

koha-US bug tracker  changed:

   What|Removed |Added

 CC||bugzi...@koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349

--- Comment #10 from Martin Renvoize  ---
Rebased, added proper commit lines and signed off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #132130|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #132128|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #132127|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349

--- Comment #9 from Martin Renvoize  ---
Created attachment 160494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160494=edit
Bug 30349: More double dashes

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349

--- Comment #8 from Martin Renvoize  ---
Created attachment 160493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160493=edit
Bug 30349: Use double dash for multi character option names

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349

--- Comment #7 from Martin Renvoize  ---
Created attachment 160492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160492=edit
Bug 30349: Tidy bulkmarcimport.pl to fix indentations

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||30349


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349
[Bug 30349] Cleanup bulkmarcimport.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30349] Cleanup bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30349

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||25539
 CC||martin.renvoize@ptfs-europe
   ||.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539
[Bug 25539] Remove AddBiblio "defer_marc_save" option
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29654] Add option to bulkmarimport.pl for matching on original id

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29654

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|BLOCKED |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35075] "bulkmarcimport" source missing in Marc Overlay Rules settings page

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35075

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|BLOCKED |RESOLVED

--- Comment #5 from Martin Renvoize  ---


*** This bug has been marked as a duplicate of bug 25539 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539

--- Comment #78 from Martin Renvoize  ---
*** Bug 35075 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com
 Status|BLOCKED |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160160|0   |1
is obsolete||

--- Comment #77 from Martin Renvoize  ---
Created attachment 160491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160491=edit
Bug 25539: Enable bulkmarcimport overlay context

Signed-off-by: Michał Kula <148193449+mk...@users.noreply.github.com>
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160159|0   |1
is obsolete||

--- Comment #76 from Martin Renvoize  ---
Created attachment 160490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160490=edit
Bug 25539: Strip items when adding new biblio to preserve previous behaviour of
the script

Signed-off-by: Michał Kula <148193449+mk...@users.noreply.github.com>
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25539] Remove AddBiblio "defer_marc_save" option

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25539

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160158|0   |1
is obsolete||

--- Comment #75 from Martin Renvoize  ---
Created attachment 160489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160489=edit
Bug 25539: Remove AddBiblio option "defer_marc_save"

Items are no longer embedded in the MARCXML and because of this the MARC data
does not need to be saved once more after changing record items data.
The "defer_marc_save" is no longer needed since bulkmarcimport.pl was the only
place this option was utilized in order to resave MARC data after possibly
changing
items data. There is also a bug bulkmarcimport.pl where the record data is
re-saved
without stripping items if duplicate items are found and the dedup barcodes
option is enabled that is resolved by this change.

This change enables MARC Overlay rules to be enabled for bulkmarkcimport.pl as
using
the defer_marc option would previously effectively bypass any defined rules.

To test
1) Apply patch 29440 (which this depends on), but no not yet apply this
   patch
2) Remove comments around "bulkmarcimport: _("bulkmarcimport.pl"),"
   in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt
   line 463
3) Enable MARC overlay rules and add a rule (with source => "*" or
   'bulkmarcimport') to protect some field.
4) Import a biblio using the bulkmarcimport script. Overlay rules will
   only be applied on updates so a match condition matching the
   record in Koha when bulkmarcimport.pl is run the next time for the same
   record needs to be supplied (for example -match "control-number,001")
5) Edit the imported biblio and change the value of the protected field
6) Run bulkmarcimport with the same parameters as in 4) and verify the
   the field that should have been protected has been overwritten
7) Revert changes for line 463 in marc-overlay-rules.tt (or will result in
   conflict applying the patch), apply the patch and repeat steps 4-5,
   verify that the field now was protected from being overwritten.

Signed-off-by: Michał Kula <148193449+mk...@users.noreply.github.com>
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34284] Customize the Accountlines Description: Lost Items

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34284

Sryan  changed:

   What|Removed |Added

 CC||sr...@lewistonschools.net

--- Comment #2 from Sryan  ---
Amending this feature (overdue fine description notice) to include lost and
damaged items would be incredibly helpful in a consortium to maintain more
information after items are deleted. Would love to see this come to fruition.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34585] "When to charge" columns value not copied when editing circulation rule

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34585

Lucas Gass  changed:

   What|Removed |Added

 Attachment #160370|0   |1
is obsolete||

--- Comment #7 from Lucas Gass  ---
Created attachment 160488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160488=edit
Bug 34585: Fix behaviour of select dropdowns when editing circulation rules

When chancing rule to edit via "Edit" button in circulation rules table,
dropdown values aren't always changed correctly. Pressing "Edit" first time
works, but after that previous rules values persist. Same happens when one
tries to clear edit row, values aren't set to default values. This happens
with every input with a dropdown in it. This mostly happanes because we set
attribute "selected" to selected options, but never clear them which leads
to values persisting. In columns "Patron category" and "Itemtype" value "All",
or "*" as it is in code, doesn't match to any existing values from database
and can't be changed via pressing "Edit" button.

To reproduce:
1. Select a rule to edit and then select another rule to edit.
2. Repeat this couple of times and observe what values dropdowns fields display
in edit row.
=> Selected values in dropdowns aren't always changed based on rule that you
are
currently editing. Instead after changing rule couple of times value doesn't
change at all.
3. Press "Clear" button to return edit rows values back to default values.
=> Values in dropdowns aren't set back as default, instead they have same
values as rule
you edited before pressing "Clear".

After reproducing problem, apply this patch and proceed to test "Clear" and
"Edit" buttons.

To test "Edit" button:
1. Again, select a rule to edit and then select a another rule to edit.
2. Observe what values dropdowns fields display in edit row.
=> Confirm that values are changed based on rule that you are currently editing
and this behaviour doesn't change after selecting new rule to edit couple of
times.

To test "Clear" button:
1. Press "Clear" button.
=> Values in dropdowns should now be set as default values.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34585] "When to charge" columns value not copied when editing circulation rule

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34585

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28012] Error on saving new numbering pattern

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28012

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|24.05.00|24.05.00,23.11.02
released in||

--- Comment #31 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35618] catalogue/showelastic.pl uses deprecated/removed parameter "type"

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35618

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|24.05.00|24.05.00,23.11.02
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable

--- Comment #7 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #99 from Martin Renvoize  ---
Happy new year.. Passing QA at last.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

--- Comment #98 from Martin Renvoize  ---
Created attachment 160487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160487=edit
Bug 29440: (QA follow-up) Fix tidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160157|0   |1
is obsolete||

--- Comment #97 from Martin Renvoize  ---
Created attachment 160486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160486=edit
Bug 29440: Fix AddBiblio/ModBiblio options args

Signed-off-by: Michał Kula <148193449+mk...@users.noreply.github.com>
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160156|0   |1
is obsolete||

--- Comment #96 from Martin Renvoize  ---
Created attachment 160485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160485=edit
Bug 29440: Replace removed syspref BiblioAddsAuthorities with AutoLinkBiblios

Signed-off-by: Michał Kula <148193449+mk...@users.noreply.github.com>
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160155|0   |1
is obsolete||

--- Comment #95 from Martin Renvoize  ---
Created attachment 160484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160484=edit
Bug 29440: Only log items has been inserted if actually have been so, and
remove extra out of place logging of record insertion

Signed-off-by: Michał Kula <148193449+mk...@users.noreply.github.com>
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160154|0   |1
is obsolete||

--- Comment #94 from Martin Renvoize  ---
Created attachment 160483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160483=edit
Bug 29440: Rename $modify_biblio_marc_options to $mod_bilbio_options

This variable actually contains ModBibio options and
ModifyBiblioMarc accepts a subset of these

Signed-off-by: Michał Kula <148193449+mk...@users.noreply.github.com>
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160153|0   |1
is obsolete||

--- Comment #93 from Martin Renvoize  ---
Created attachment 160482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160482=edit
Bug 29440: Remove pointless call to _strip_item_fields

Signed-off-by: Michał Kula <148193449+mk...@users.noreply.github.com>
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160152|0   |1
is obsolete||

--- Comment #92 from Martin Renvoize  ---
Created attachment 160481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160481=edit
Bug 29440: replace usage of removed GetMarcBiblio

Signed-off-by: Michał Kula <148193449+mk...@users.noreply.github.com>
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160151|0   |1
is obsolete||

--- Comment #91 from Martin Renvoize  ---
Created attachment 160480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160480=edit
Bug 29440: defer biblio autolinking until records are indexed

Signed-off-by: Michał Kula <148193449+mk...@users.noreply.github.com>
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160150|0   |1
is obsolete||

--- Comment #90 from Martin Renvoize  ---
Created attachment 160479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160479=edit
Bug 29440: Fix QA-tool issues

Signed-off-by: Michał Kula <148193449+mk...@users.noreply.github.com>
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160149|0   |1
is obsolete||

--- Comment #89 from Martin Renvoize  ---
Created attachment 160478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160478=edit
Bug 29440: Make authorities import behavior consistent with biblios

The current behavior for when importing authorities, when match
option is enabled, is to insert as a new authority fetching from db
fails. This is both a bit confusing and not consistent with the biblio
case where an error is generated. Also clean up error and log messages
so both messages/errors and when messages/errors are issued are more
consistent for the biblio and authority case.

Signed-off-by: Frank Hansen 
Signed-off-by: Michał Kula <148193449+mk...@users.noreply.github.com>
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29440] Refactor/clean up bulkmarcimport.pl

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #160148|0   |1
is obsolete||

--- Comment #88 from Martin Renvoize  ---
Created attachment 160477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160477=edit
Bug 29440: Refactor and clean up bulkmarcimport.pl

To test:
1) Import biblios using ./bulkmarcimport.pl -v -b -file biblios.mrc -insert
-update -c=MARC21 -match "control-number,001" -n=1 -l "/tmp/import.log"
2) Verify in /tmp/import.log that one biblio has been inserted
3) Import again without the "-n" option, verify that one biblio has been
   updated and the rest inserted
4) In the staff interface search the catalog for some string appearing in
   the imported biblios to verify records have been indexed
5) View/edit some of the biblios the staff interface to very have been
   properly imported
6) Import authorities using ./bulkmarcimport.pl -v -m=MARCXML -a -file
authorities.xml -insert -update -c=MARC21 -keepids="024a" -match
"heading-main,100a" -l "/tmp/import.log" -yaml="/tmp/ids.yml"
7) Go to the authorities page and find the imported authority by for example
search for a
   400 or 100 field value. Verify that the 001 field of the incoming record has
been moved to 024a.
   Also check that the value of 024a appear as a key in /tmp/ids.yml.
8) Edit the authorities.xml file and change the value of field 400a
9) Import authorities again using the same options
10) Verify that the 400a field of the authority in Koha has not been
   updated (the import was skippped since revision did not change)
11) Edit authorities.xml, replace the value of field 005 in the file with field
005
of the authority in Koha incremented by one
12) Import again with the same options
13) Verify that the 400a field of the authority in Koha now have been
updated

Signed-off-by: Michał Kula <148193449+mk...@users.noreply.github.com>
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35588] marcrecord2csv retrieves authorised values incorrectly for fields

2024-01-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35588

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|24.05.00|24.05.00,23.11.02
released in||
 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >