[Koha-bugs] [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #9 from David Cook  ---
This is an interesting one. I've had people thinking it's a bug since it's
showing some duplicate information:

For example:
Vol. 47, No. 2 (Dec 2023) -- Vol. 47, No. 2 (01/12/2023)

I could maybe understand wanting to do that on the staff interface but not the
OPAC... it just looks bad on the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36665] Autolocation and IP Recognition

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665

--- Comment #2 from David Cook  ---
Wait... I think I understand you. You mean you weren't using AutoLocation to
try to restrict logins?

You were just trying to use AutoLocation to force the branch of the session to
the branch of the physical location (as designated by the IP address).

So arguably that desired functionality would be AutoLocation and the
restricting by IP address would be renamed as per bug 26176.

--

That's an interesting idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36665] Autolocation and IP Recognition

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36665

--- Comment #1 from David Cook  ---
At a glance, it looks like AutoLocation is working the same. Can you be more
specific about the issue you're having?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30598] Replacement cost is not copied from retail price when ordering from file

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30598

Lucas Gass  changed:

   What|Removed |Added

 Attachment #165349|0   |1
is obsolete||

--- Comment #11 from Lucas Gass  ---
Created attachment 165351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165351=edit
Bug 30598: remove all the console.log redundancies

Please test the patch. Thank you!

Signed-off-by: Matt Blenkinsop 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30598] Replacement cost is not copied from retail price when ordering from file

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30598

Lucas Gass  changed:

   What|Removed |Added

 Attachment #165348|0   |1
is obsolete||

--- Comment #10 from Lucas Gass  ---
Created attachment 165350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165350=edit
Bug 30598: Replacement cost is not copied from retail price when ordering from
file

Test plan :
To test :
1- In Acquisitions, create a basket
2- Add an order from a new (empty) record
 --> Note that when you enter the "vendor price", it is copied in the
"replacement cost" field
3- Add an order from a new file
 --> Note that when you enter the "price", the "replacement price" field stays
empty
4- Apply the batch
5- Redo step 3 and notice that when you change the 'price', the
'replacement price' syncs with it

Signed-off-by: Matt Blenkinsop 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30598] Replacement cost is not copied from retail price when ordering from file

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30598

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34352] It would be great to have a generic flatpickr based input for datatables column filters

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34352

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #5 from Lucas Gass  ---
Doesn't apply. I'd be happy to revisit this myself if I can ever get Bug 33703
in. :P

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36372] Allow privileged users to set the 'record source' on cataloguing

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36372

--- Comment #1 from Arthur Suzuki  ---
+1 that would be handy!
Also, tomas forgot to mention, the api may set the record source upon creation
of a record (which is great) but there is no way to change it (even with the
api) once it's created.
Then the only way to change it is through a direct access to the database.
In some use-cases it may be needed that a librarian "unlock" a record to let a
fellow edit the record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25901] Add option for ClaimsReturnedWarningThreshold to count only unresolved claims

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25901

vste...@myokaloosa.com changed:

   What|Removed |Added

   Priority|P5 - low|P3
 CC||vste...@myokaloosa.com
   Severity|enhancement |normal

--- Comment #6 from vste...@myokaloosa.com ---
This would be a blessing. Right now, it is misleading to staff to see what they
believe is an issue to be worked. They waste time at customer contact point
researching it, only to find it has been resolved. Definitely in favor of
adding this as a system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972

Emily Lamancusa  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #19 from Emily Lamancusa  
---
*** Bug 29348 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 29348] GetOtherReserves fails to mark holds as waiting or in-transit

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29348

Emily Lamancusa  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov
 Status|NEW |RESOLVED

--- Comment #1 from Emily Lamancusa  ---


*** This bug has been marked as a duplicate of bug 34972 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35765] No permissions to create Public Lists

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35765

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34568] Add ability to undo an import in ERM

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34568

Maude  changed:

   What|Removed |Added

 CC||maude.boudr...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35095] Bibliographic record from local title only has 245$a

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35095

Maude  changed:

   What|Removed |Added

 CC||maude.boudr...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34788] Add the ability to import KBART files to ERM

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788

Maude  changed:

   What|Removed |Added

 CC||maude.boudr...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30598] Replacement cost is not copied from retail price when ordering from file

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30598

Phan Tung Bui  changed:

   What|Removed |Added

 Attachment #165110|0   |1
is obsolete||

--- Comment #9 from Phan Tung Bui  ---
Created attachment 165349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165349=edit
Bug 30598: remove all the console.log redundancies

Please test the patch. Thank you!

Signed-off-by: Matt Blenkinsop 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30598] Replacement cost is not copied from retail price when ordering from file

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30598

Phan Tung Bui  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30598] Replacement cost is not copied from retail price when ordering from file

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30598

Phan Tung Bui  changed:

   What|Removed |Added

 Attachment #165109|0   |1
is obsolete||

--- Comment #8 from Phan Tung Bui  ---
Created attachment 165348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165348=edit
Bug 30598: Replacement cost is not copied from retail price when ordering from
file

Test plan :
To test :
1- In Acquisitions, create a basket
2- Add an order from a new (empty) record
 --> Note that when you enter the "vendor price", it is copied in the
"replacement cost" field
3- Add an order from a new file
 --> Note that when you enter the "price", the "replacement price" field stays
empty
4- Apply the batch
5- Redo step 3 and notice that when you change the 'price', the
'replacement price' syncs with it

Signed-off-by: Matt Blenkinsop 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36132] Allow users to delete multiple patron_lists at once on any page

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36132

Phan Tung Bui  changed:

   What|Removed |Added

 CC||phan-tung@inlibro.com,
   ||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

David Nind  changed:

   What|Removed |Added

 Attachment #165335|0   |1
is obsolete||

--- Comment #40 from David Nind  ---
Created attachment 165347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165347=edit
Bug 36111: fixed extra space

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

David Nind  changed:

   What|Removed |Added

 Attachment #165236|0   |1
is obsolete||

--- Comment #39 from David Nind  ---
Created attachment 165346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165346=edit
Bug 36111: 856$h should not appear as a link in detailed record

Test plan:
1. Add 856$h to MARC editor
   1.1. Go to Administration > MARC bibliographic frameworks
   1.2. Next to Default framework, click Actions > MARC structure
   1.3. Search for field 856
   1.4. Click Actions > Edit subfields
   1.5. Click h
   1.6. Check the Editor box
   1.7. Click Save changes
2. Catalog a new record with a random URL in 856$h
   2.1. Go to Cataloging
   2.2. Click New record
   2.3. Fill out the mandatory fields (000, 003, 005, 008, 040$c,
245$a, 942$c)
   2.4. Go to tab 8 and enter a value in 856$h
   2.5. Click Save (No need to add an item)
3. Search for the title in the staff interface (a large enough
   search to have more than one result)
   --> Notice it says "Online resources: Click here to access online"
   3.1. Try to click the link
--> Blank page
4. Access the detailed record in the staff interface
   --> Notice it says "Online resources: Click here to access online"
   4.1. Try to click the link
--> Blank page
5. Search for the title in the opac (a large enough search to have
   more than one result)
   --> Notice it says "Online resources: Click here to access online"
   5.1. Try to click the link
--> Blank page
6. Access the detailed record in the opac
   --> Notice it says "Online resources: Click here to access online"
   6.1. Try to click the link
--> Blank page
7. Edit the item and add a text in field 856$y
8. Access the detailed record in the staff interface
   --> Notice it says what you put in 856$y field
9. Apply the patch
10. Replay steps 3 through 6, but this time, the "Online resources"
   field should not be present.
11. Replay steps 7 through 8, but this time, what you put in 856$y
   field should not be present.
12. Edit the item and add a url in field 856$u
13. Replay steps 3 through 6, but this time, clicking on the link
should take you to the URL specified in the 856$u field.
14. Replay steps 7 through 8, but this time, what you put in 856$y
   field should be present and
   clicking on the link should take you to the URL specified in the 856$u
field.

Signed-off-by: Roman Dolny 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

--- Comment #38 from David Nind  ---
(In reply to Matthias Le Gac from comment #37)
> I fixed the problem when "online resources" is not displayed. There is no
> longer an extra space between fields. 
> 
> As for the second problem, it's not related to this bz because the
> difference is that it's remapped depending on the page. This is present
> between any field and whether the patch is applied or not.

Thanks Matthias!

Sign off on the way.

Hope QA goes smoothly!

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36182] Add booksellerid column to holdings table

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

--- Comment #13 from Lucas Gass  ---
(In reply to Pedro Amorim from comment #12)
> (In reply to Lucas Gass from comment #11)
> > Needs rebased now that we have Bug 36182.
> 
> Patch applies for me, double-checking: have you applied interactively and
> commented the [23.11] one?

My mistake, I only noticed the 23.11 patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

--- Comment #32 from Brendan Lawlor  ---
(In reply to Lucas Gass from comment #28)
> This changes the :all option into from a single select dropdown to a multi
> one. I don't think that is necessarily bad, could be handy actually!

Good catch Lucas!

I think that this should not happen because it would change how current reports
work. There could be cases where you only want a parameter to be single choice
or the all option but not multi select.

The original patch relied on the value of the template variable always being
put in the html tag as either the attribute 'multiple' or as an empty string
for single selects. My understanding is that causes a problem with
translations.

I changed one conditional so that only selects that should be multi will get
the multiple attribute and it doesn't have invalid TT inside the select tag so
it passes the test too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34899] Circulation rules: Only allow "Local use" patron category to place holds on specific library's items

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34899

Alex Carver  changed:

   What|Removed |Added

 CC||a...@rcls.org

--- Comment #8 from Alex Carver  ---
+1 from Ramapo Catskill Library System. We are also struggling to restrict our
"Local Use" patrons to items owned by their Home Libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Brendan Lawlor  changed:

   What|Removed |Added

 Attachment #165334|0   |1
is obsolete||

--- Comment #31 from Brendan Lawlor  ---
Created attachment 165345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165345=edit
Bug 35746: (follow-up) Fix invalid tt in html tag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36182] Add booksellerid column to holdings table

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

Pedro Amorim  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #12 from Pedro Amorim  ---
(In reply to Lucas Gass from comment #11)
> Needs rebased now that we have Bug 36182.

Patch applies for me, double-checking: have you applied interactively and
commented the [23.11] one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

Roman Dolny  changed:

   What|Removed |Added

 CC||roman.do...@jezuici.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36659] Authorities search tab keeps defaulting to main heading ($a only)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|agustinmoy...@theke.io  |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36668] Excessive whitespace/newlines in circulation rules editor may cause slow loads with large rules sets

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36668

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36673

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36672] Circulation rules are performing too many lookups

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36672

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36673

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36447] Circ rules slow to load when many itemtypes and categories

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36447

Nick Clemens  changed:

   What|Removed |Added

 Blocks||36673


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36673
[Bug 36673] Limit search for used categories and item types to current branch
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36673] Limit search for used categories and item types to current branch

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36673

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36672,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36668
 Depends on||36447


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36447
[Bug 36447] Circ rules slow to load when many itemtypes and categories
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36673] Limit search for used categories and item types to current branch

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36673

--- Comment #1 from Nick Clemens  ---
Created attachment 165344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165344=edit
bug 36673: Filter used categories and item types to current branch

To test:
1 - Define some circulation rules for default and specific branches
2 - Apply patch
3 - Confirm rules display as before

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36673] Limit search for used categories and item types to current branch

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36673

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36673] New: Limit search for used categories and item types to current branch

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36673

Bug ID: 36673
   Summary: Limit search for used categories and item types to
current branch
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Bug 36447 limited the categories looped on the smart-rules page to those
currently used - we can go a bit further and limit them to the current branch
we are loading

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36672] Circulation rules are performing too many lookups

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36672

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36672] New: Circulation rules are performing too many lookups

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36672

Bug ID: 36672
   Summary: Circulation rules are performing too many lookups
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

See bug 36668 - it tackles the size of the circulation page but doesn't
significantly increase load time. Profiling it seems we spend about 50% of the
loading time on Koha::Template::Plugin::CirculationRules::Search

Looking at the template, for every section after the main rules block we loop
over categories or itemtypes, and lookup the value for each rule name.

In systems with large numbers of categories and item types this becomes very
slow.

In the rules section, we have already built a hash of rules by category and
itemtype - we should continue to use this throughout the page.

Additionally, we don't need to use all category/item types, we can use the
'used_categories' array from bug 36447 to only attempt categories that  we know
have rules

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36658] Rotating collections: Check-in of items does not prompt offer to initiate transfer

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36658

Heather Rommens  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36582] Add option to set library, desk, and register from user menu

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36582

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671

Lucas Gass  changed:

   What|Removed |Added

 Attachment #165332|0   |1
is obsolete||

--- Comment #6 from Lucas Gass  ---
Created attachment 165343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165343=edit
Bug 31671: Add print slip button to transfer page

This patch reimplements/rebases Lucas' patch and adds a style
modification to the button.

To test:
1. Apply patch
2. Go to Circulation / Transfer
3. Try transfering some items and notice the 'Print slip'
   button
4. Try clicking on it and make sure it generates correctly and with the
   correct information on the slip

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36671] Reindent item transfer template (branchtransfers.tt)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Attachment #165329|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36671] Reindent item transfer template (branchtransfers.tt)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671

--- Comment #5 from Lucas Gass  ---
Created attachment 165342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165342=edit
Bug 36671: (follow-up) remove stray anchor tag

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36671] Reindent item transfer template (branchtransfers.tt)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671

Lucas Gass  changed:

   What|Removed |Added

 Attachment #165330|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 165341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165341=edit
Bug 36671: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36671] Reindent item transfer template (branchtransfers.tt)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671

--- Comment #3 from Lucas Gass  ---
Created attachment 165340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165340=edit
Bug 36671: Reindent item transfer template (branchtransfers.tt)

This patch reindents the item transfer template so that it has
consistent indentation, with tab indentation coverted to space.

To test, apply the patch and go to Circulation -> Transfer. Test some
transfers, including transfers which trigger a hold notification.
Everything should work correctly.

If you view the diff while ignoring whitespace the only changes should
be places where line breaks were introduced.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36671] Reindent item transfer template (branchtransfers.tt)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123

Lucas Gass  changed:

   What|Removed |Added

 Attachment #165331|0   |1
is obsolete||

--- Comment #17 from Lucas Gass  ---
Created attachment 165339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165339=edit
Bug 30123: Set desk default to logged-in-desk-id on sety library page

This patch refactors the javascript that runs on the set library page. If the
logged in user branch code is the same as the seleceted library, default the
desk selection to the current logged in desk id. Otherwise set the default desk
selection to the first option for the current branch.

Test plan:

1. Turn on UseCirculationDesks
2. Create a few desks with unique names for a few different libraries
3. Set your library and desk
4. Reload set-library.pl and notice that the desk always defaults to the last
option for the library selected
5. Apply patch and restart_all
6. Reload set-library.pl and notice that the desk selection defaults to your
current logged in desk
7. Try changing the library selection to libraries with and without desks
8. Notice that the desk selection defaults to the first option available for
the selected library
9. Notice that the desk selection defaults to the --- no desk for libraries
without desks
10. Notice the desk selection defaults to the currenty logged in desk if you
select the library you are currently logged into

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36670] Add a button to intranet detail for a biblio to enable "Reindex this record now"

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36670

Roman Dolny  changed:

   What|Removed |Added

 CC||roman.do...@jezuici.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36659] Authorities search tab keeps defaulting to main heading ($a only)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659

Lucas Gass  changed:

   What|Removed |Added

 Attachment #165250|0   |1
is obsolete||

--- Comment #3 from Lucas Gass  ---
Created attachment 165338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165338=edit
Bug 36659: Show correct tab after conducting an Authorities search

To test:

1. In the staff interface, go to Authorities
2. Do a search for each tab, i.e. 'Main heading' and 'Entire record'
3. Notice every search has the 'Main heading ($a only)' tab selected when the
results page loads.

4. Apply patch and restart services

5. Repeat step 2 and confirm the appropriate tab is selected by default after
each search.

Sponsored-by: Education Services Australia SCIS
Signed-off-by: David Nind 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36659] Authorities search tab keeps defaulting to main heading ($a only)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36659] Authorities search tab keeps defaulting to main heading ($a only)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36659

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34792] CookieConsentBar content feels mis-aligned

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792

Lucas Gass  changed:

   What|Removed |Added

 Attachment #165263|0   |1
is obsolete||

--- Comment #13 from Lucas Gass  ---
Created attachment 165337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165337=edit
Bug 34792: Improve flexibility of CookieConsentBar layout

This patch makes CSS and markup changes to the CookieConsentBar, in both
the OPAC and staff interface, so that the layout of custom text and
buttons works better with varying text content and varying browser widths.

The patch also adds some JavaScript to the OPAC so that the cookie
consent bar interacts better with the language selection footer. When
the language selection footer is visible, the cookie consent bar should
"stick" to the bottom of the viewport except when the page is scrolled
all the way down. When the page is scrolled all the way to the bottom
the cookie consent bar should move to the top of the language selection
footer.

To test, apply the patch and rebuild the OPAC and staff interface CSS.

- Go to Administration -> System preferences and enable the
  CookieConsent preference if necessary.
- Follow the link in the preference description to HTML customizations.
- Create an HTML customization in the CookieConsentBar display location.
  Add a paragraph of text.
- Go to the OPAC. If you don't see the cookie consent bar at the bottom
  of the screen you may need to clear your browser cookies and local
  storage.
- Confirm that the text flows well in relation to the buttons: With a
  lot of text, the text expands to fill the width of the cookie consent
  bar and the buttons are below. With a small amount of text, the text
  and buttons should be side by side.
- Test that this layout adapts well to various browser widths.

- Perform the same tests in the staff interface.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34792] CookieConsentBar content feels mis-aligned

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792

Lucas Gass  changed:

   What|Removed |Added

 Attachment #159185|0   |1
is obsolete||

--- Comment #12 from Lucas Gass  ---
Created attachment 165336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165336=edit
Bug 34792: (Preparation) Run stylelint fixes on cookie consent CSS

This patch applies automated stylelint fixes to the OPAC CSS which was
added when the Cookie Consent feature was added. No other CSS has been
changed.

Signed-off-by: David Nind 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34792] CookieConsentBar content feels mis-aligned

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

--- Comment #37 from Matthias Le Gac  ---
I fixed the problem when "online resources" is not displayed. There is no
longer an extra space between fields. 

As for the second problem, it's not related to this bz because the difference
is that it's remapped depending on the page. This is present between any field
and whether the patch is applied or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

--- Comment #36 from Matthias Le Gac  ---
Created attachment 165335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165335=edit
Bug 36111: fixed extra space

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36111] 856$h should not appear as a link in detailed record

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36111

Matthias Le Gac  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34792] CookieConsentBar content feels mis-aligned

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792

Lucas Gass  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com
   |y.org   |
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30598] Replacement cost is not copied from retail price when ordering from file

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30598

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #7 from Lucas Gass  ---
This is working fine, code looks good. Just fix your commit messages please! 

* Commit title does not start with 'Bug X: ' - 8c0e31674b
* Commit title does not start with 'Bug X: ' - 21e58343d1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30598] Replacement cost is not copied from retail price when ordering from file

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30598

Lucas Gass  changed:

   What|Removed |Added

   Assignee|matt.blenkinsop@ptfs-europe |phan-tung@inlibro.com
   |.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30598] Replacement cost is not copied from retail price when ordering from file

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30598

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30598] Replacement cost is not copied from retail price when ordering from file

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30598

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |matt.blenkinsop@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36182] Add booksellerid column to holdings table

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36182

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||lu...@bywatersolutions.com

--- Comment #11 from Lucas Gass  ---
Needs rebased now that we have Bug 36182.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Lucas Gass  changed:

   What|Removed |Added

 Attachment #165276|0   |1
is obsolete||

--- Comment #30 from Lucas Gass  ---
Created attachment 165334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165334=edit
Bug 35746: (follow-up) Fix invalid TT syntax inside html tag

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Lucas Gass  changed:

   What|Removed |Added

 Attachment #163921|0   |1
is obsolete||

--- Comment #29 from Lucas Gass  ---
Created attachment 165333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165333=edit
Bug 35746: add multiselect to report dropdowns

Rebased for changes to guided_reports_start.tt

This patch adds the ability to use multi select in report dropdowns.

It uses syntax similar to using a list and when using the :all option
WHERE i.homebranch in <>

Test plan:
1. Create an SQL report with with new syntax for multi select
SELECT
i.homebranch,
count(*)
FROM items i
WHERE i.homebranch in <>
GROUP BY i.homebranch
2. Save the report
3. Note that you get the error
The authorized value category (branches:in) you selected does not exist.
4. Apply the patch and repeat steps 1 and 2
5. Note the report saves successfully
6. Run the report
7. Note the select dropdown is now a multiselect
8. Run the report with multiple selections
10. Click show SQL and note that multi select parameters get inserted into the
query like:
 WHERE i.homebranch in ('CPL', 'FFL', 'FPL')
11. Test other types of queries with multiple multi selects and lists etc

Sponsored-by: CLAMS

Signed-off-by: Andrew Fuerste-Henry 
Signed-off-by: Nick Clemens 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35919] Add record sources CRUD

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #73 from Kyle M Hall  ---
> 5) Apache config?
> 
> When trying to access the admin/record_sources I have a 404 error.

I applied the patch, did a restart_all, and it looks to be working for me!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35746] Multiple selections for parameters used in the IN function

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35746

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #28 from Lucas Gass  ---
This changes the :all option into from a single select dropdown to a multi one.
I don't think that is necessarily bad, could be handy actually!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671

Owen Leonard  changed:

   What|Removed |Added

 Attachment #142571|0   |1
is obsolete||
   Assignee|lu...@bywatersolutions.com  |oleon...@myacpl.org
 Status|Failed QA   |Needs Signoff

--- Comment #5 from Owen Leonard  ---
Created attachment 165332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165332=edit
Bug 31671: Add print slip button to transfer page

This patch reimplements/rebases Lucas' patch and adds a style
modification to the button.

To test:
1. Apply patch
2. Go to Circulation / Transfer
3. Try transferring some items and notice the 'Print slip'
   button
4. Try clicking on it and make sure it generates correctly and with the
   correct information on the slip

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123

--- Comment #16 from Brendan Lawlor  ---
This new patch changes the fewest number of lines and doesn't have the weird
auto formatting issue so it's more clear to see what it does.

It also includes the markup fix that Owen suggested.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123

Brendan Lawlor  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123

Brendan Lawlor  changed:

   What|Removed |Added

 Attachment #164390|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30123] On set library page, desk always defaults to last in list instead of desk user is signed in at

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30123

--- Comment #15 from Brendan Lawlor  ---
Created attachment 165331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165331=edit
Bug 30123: Set desk default to logged-in-desk-id on sety library page

This patch refactors the javascript that runs on the set library page. If the
logged in user branch code is the same as the seleceted library, default the
desk selection to the current logged in desk id. Otherwise set the default desk
selection to the first option for the current branch.

Test plan:

1. Turn on UseCirculationDesks
2. Create a few desks with unique names for a few different libraries
3. Set your library and desk
4. Reload set-library.pl and notice that the desk always defaults to the last
option for the library selected
5. Apply patch and restart_all
6. Reload set-library.pl and notice that the desk selection defaults to your
current logged in desk
7. Try changing the library selection to libraries with and without desks
8. Notice that the desk selection defaults to the first option available for
the selected library
9. Notice that the desk selection defaults to the --- no desk for libraries
without desks
10. Notice the desk selection defaults to the currenty logged in desk if you
select the library you are currently logged into

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 21059] callback function in OPAC

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21059

Lucas Gass  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |WONTFIX
 CC||lu...@bywatersolutions.com

--- Comment #2 from Lucas Gass  ---
I am going to resolve this bug, I don't think this is something we need at this
point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36670] Add a button to intranet detail for a biblio to enable "Reindex this record now"

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36670

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36671] Reindent item transfer template (branchtransfers.tt)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36671] Reindent item transfer template (branchtransfers.tt)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671

--- Comment #2 from Owen Leonard  ---
Created attachment 165330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165330=edit
Bug 36671: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36671] Reindent item transfer template (branchtransfers.tt)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671

--- Comment #1 from Owen Leonard  ---
Created attachment 165329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165329=edit
Bug 36671: Reindent item transfer template  (branchtransfers.tt)

This patch reindents the item transfer template so that it has
consistent indentation, with tab indentation converted to space.

To test, apply the patch and go to Circulation -> Transfer. Test some
transfers, including transfers which trigger a hold notification.
Everything should work correctly.

If you view the diff while ignoring whitespace the only changes should
be places where line breaks were introduced.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35565] "LinkerOptions: broader_headings" works in an unexpected way with name headings

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35565

--- Comment #5 from Esther Melander  ---
I ran some tests on a test site where LinkerOptions was disabled. LinkerModule
was set to first match. AutoLinkBiblios set to Do. I had these authorities:

Auth ID=50 110 $aChurch of Jesus Christ of Latter-Day Saints $d Presidents
Auth ID=51 110 $aChurch of Jesus Christ of Latter-Day Saints

Added a new authority to a record to match AuthID 51. Upon saving the record it
correctly linked to Authority 51. No other authorities in the record linked
incorrectly.

Repeated the above but enabled LinkerOptions with broader_headings and deleted
$9. Got these results:

110 $aChurch of Jesus Christ of Latter-Day Saints $9 51
610 $aChurch of Jesus Christ of Latter-Day Saints $vHymns $9 51

The 610 authority was not in the system. So possibly LinkerOptions is
interfering with LinkerModule, though it seems like LinkerOptions did what it
was supposed to do linking an authority because it did match the broader
heading.

Repeated the test again with LinkerOptions enabled on the same record and
deleted $9. I added the Presidents topical term to the record and added an
authority for the Hymns and got these results:

110 _ _ ‡aChurch of Jesus Christ of Latter-Day Saints‡9 51
610 _ 0 ‡aChurch of Jesus Christ of Latter-Day Saints‡vHymns‡9 52
610 _ _ ‡aChurch of Jesus Christ of Latter-Day Saints‡xPresidents‡9 51

Disabled LinkerOptions again, deleted $9 and got these results (which are
correct):

110 _ _ ‡aChurch of Jesus Christ of Latter-Day Saints‡9 51
610 _ 0 ‡aChurch of Jesus Christ of Latter-Day Saints‡vHymns‡9 52
610 _ _ ‡aChurch of Jesus Christ of Latter-Day Saints‡xPresidents‡9 50

The short answer is that LinkerOptions is linking in unexpected ways, and
possibly conflicting with LinkerModule.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 31671] Add a "Print transfer slip" button to /cgi-bin/koha/circ/branchtransfers.pl

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671

Owen Leonard  changed:

   What|Removed |Added

 Depends on||36671


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671
[Bug 36671] Reindent item transfer template (branchtransfers.tt)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36671] New: Reindent item transfer template (branchtransfers.tt)

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36671

Bug ID: 36671
   Summary: Reindent item transfer template (branchtransfers.tt)
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 31671

I would like to update circ/branchtransfers.tt so that it has consistent
indentation.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31671
[Bug 31671] Add a "Print transfer slip" button to
/cgi-bin/koha/circ/branchtransfers.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides items table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co
   |ity.org |m
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides items table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

Lucas Gass  changed:

   What|Removed |Added

 Attachment #165324|0   |1
is obsolete||

--- Comment #13 from Lucas Gass  ---
Created attachment 165328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165328=edit
Bug 36663: Hide specific inner elements, not the whole top pager container

1- Enable StaffDetailItemSelection
2- Visit a biblio page:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
3- Notice there are no table configuration options on the top right (Columns,
Export, Configure).
4- Click the "Show filters" link, notice the table configuration options now
show, as well as top and bottom pagers, column filter inputs and search input.
5- Disable StaffDetailItemSelection
6- Visit a biblio page:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
7- Notice that the table configurations options are visible, as well as top and
bottom pagers, and search input.
8- Click the "Show filters" link, notice it now only governs the column filter
inputs, the other elements mentioned in step 7 are always visible.
9- Apply patches, run yarn css:build
10- Repeat 1 and 2.
11- Notice the table configuration options are shown on the top right, and no
other table options exist.

Further testing:
Test clicking hide/show filters
Test with StaffDetailItemSelection enabled/disabled
Test other datatables in other pages

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides items table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

Lucas Gass  changed:

   What|Removed |Added

 Attachment #165323|0   |1
is obsolete||

--- Comment #12 from Lucas Gass  ---
Created attachment 165327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165327=edit
Bug 36663: Update alignment of datatable buttons

Pack items from the end

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides items table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

Lucas Gass  changed:

   What|Removed |Added

 Attachment #165322|0   |1
is obsolete||

--- Comment #11 from Lucas Gass  ---
Created attachment 165326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165326=edit
Bug 36663: Adjust datatable button selector

This change makes the selector apply specifically to the 'clear filter' button,
instead of whatever is the first button as 'clear filter' may or may not exist.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides items table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides items table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

Pedro Amorim  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #10 from Pedro Amorim  ---
(In reply to Lucas Gass from comment #9)
> Doesn't apply now.

Meant to obsolete the original patch but forgot to.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides items table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #165266|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36654] Add template toolkit function to get arbitrary Koha::Objects

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36654

Pedro Amorim  changed:

   What|Removed |Added

 CC||pedro.amo...@ptfs-europe.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36668] Excessive whitespace/newlines in circulation rules editor may cause slow loads with large rules sets

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36668

--- Comment #1 from Kyle M Hall  ---
Created attachment 165325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165325=edit
Bug 36668: Excessive whitespace/newlines in circulation rules editor may cause
slow loads with large rules sets

Simply put we have a lot of SET lines and such in our circ rules editor
template. For large rule sets all the newlines add up and can balloon the
rendered html size to many megabytes! We should add a newline chomper to these
lines.

1) Generate a large number of circ rules with the following perl script

use Koha::CirculationRules;
use Koha::Patron::Categories;
use Koha::ItemTypes;

use t::lib::TestBuilder;
my $builder = t::lib::TestBuilder->new();
$builder->build( { source => 'Category' } ) for 0 .. 80;
$builder->build( { source => 'Itemtype' } ) for 0 .. 80;

C4::Context->dbh->do("
INSERT IGNORE INTO circulation_rules ( branchcode, categorycode, itemtype,
rule_name, rule_value )
SELECT NULL, categories.categorycode, itemtypes.itemtype, 'issuelength', 5
FROM categories JOIN itemtypes;"
);

2) Open the network debugging on your web browser
3) Load smart-rules.pl
4) Notice the size of the file
5) Apply this patch
6) Restart all the things!
7) Reload smart-rules.pl
8) Note the file size has been drastically reduced!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36668] Excessive whitespace/newlines in circulation rules editor may cause slow loads with large rules sets

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36668

Kyle M Hall  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides items table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #9 from Lucas Gass  ---
Doesn't apply now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36416] Check out using CirculateILL is broken

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36416

Pedro Amorim  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36670] New: Add a button to intranet detail for a biblio to enable "Reindex this record now"

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36670

Bug ID: 36670
   Summary: Add a button to intranet detail for a biblio to enable
"Reindex this record now"
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff interface
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: wizzy...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Sometimes there's a reason a record needs to be Reindexed Right Now (es queue
is backded up, librarian is impatient, pick something). 

It would be nice to have a button on the detail page to request an es index
"right now" for a single given record.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36663] Biblio detail page - StaffDetailItemSelection hides items table elements inconsistently

2024-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36663

--- Comment #8 from Pedro Amorim  ---
Created attachment 165324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165324=edit
Bug 36663: Hide specific inner elements, not the whole top pager container

1- Enable StaffDetailItemSelection
2- Visit a biblio page:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
3- Notice there are no table configuration options on the top right (Columns,
Export, Configure).
4- Click the "Show filters" link, notice the table configuration options now
show, as well as top and bottom pagers, column filter inputs and search input.
5- Disable StaffDetailItemSelection
6- Visit a biblio page:
http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76
7- Notice that the table configurations options are visible, as well as top and
bottom pagers, and search input.
8- Click the "Show filters" link, notice it now only governs the column filter
inputs, the other elements mentioned in step 7 are always visible.
9- Apply patches, run yarn css:build
10- Repeat 1 and 2.
11- Notice the table configuration options are shown on the top right, and no
other table options exist.

Further testing:
Test clicking hide/show filters
Test with StaffDetailItemSelection enabled/disabled
Test other datatables in other pages

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   4   >