[Koha-bugs] [Bug 36741] New: AUTO_RENEWALS_DGST should skip auto_too_soon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36741 Bug ID: 36741 Summary: AUTO_RENEWALS_DGST should skip auto_too_soon Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org I think it's debateable that auto_too_soon items should show up in the AUTO_RENEWALS_DGST at all, but I can think of reasons why they would be useful to show (you might want to show which items weren't renewed because it was too soon). But at the moment, the AUTO_RENEWALS_DGST doesn't account for them. It just prints out the title and barcode, which looks ridiculous. We need a default. Either to skip auto_too_soon in that loop, or to say that it's too soon for it to be renewed. I'm in favour of the former. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36740] New: Add a 'Uniform title' index to the staff interface advanced search dropdown
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36740 Bug ID: 36740 Summary: Add a 'Uniform title' index to the staff interface advanced search dropdown Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In both Zebra and Elasticsearch there is a 'title-uniform' index which searches a bunch of tags, including: * 130 * 240 * 730 It would be great to add this option to the staff interface advanced search dropdown to make the index accessible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723 Danyon Sewell changed: What|Removed |Added Attachment #165940|0 |1 is obsolete|| --- Comment #3 from Danyon Sewell --- Created attachment 165941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165941=edit bug 36723: Add musical presentation to Elasticsearch index mappings Have written a patch to allow Musical Presentation to be a search option within Elasticsearch index mappings Test plan: 1. Apply this patch 2. Ensure MARC index 254 (Musical Presentation) is visible to edit on the default MARC bibliographic framework Koha Administration > MARC Bibliographic framework > Actions (under default framework) > MARC structure > Search 254 and actions->edit subfield > tick box for visibility should have OPAC, Staff Interface and Editor ticked. 3. Edit a record using the default MARC bibliographic framework and put a search term under index 254 and save. 4. Head back to the home page and go to Advanced Search 5. under the Search for dropdown select Musical presentation and in the search field enter the search term you used in step 3. Your results should appear Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723 Danyon Sewell changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723 Danyon Sewell changed: What|Removed |Added Attachment #165938|0 |1 is obsolete|| --- Comment #2 from Danyon Sewell --- Created attachment 165940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165940=edit bug 36723: Add musical presentation to Elasticsearch index mappings Have written a patch to allow Musical Presentation to be a search option within Elasticsearch index mappings Test plan: 1. Apply this patch 2. Ensure MARC index 254 (Musical Presentation) is visible to edit on the default MARC bibliographic framework Koha Administration > MARC Bibliographic framework > Actions (under default framework) > MARC structure > Search 254 and actions->edit subfield > tick box for visibility should have OPAC, Staff Interface and Editor ticked. 3. Edit a record using the default MARC bibliographic framework and put a search term under index 254 and save. 4. Head back to the home page and go to Advanced Search 5. under the Search for dropdown select Musical presentation and in the search field enter the search term you used in step 3. Your results should appear -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Attachment #165717|0 |1 is obsolete|| --- Comment #67 from Aleisha Amohia --- Created attachment 165939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165939=edit Bug 33260: (follow-up) Fix search forms on notices mgmt page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33260] Show message queue on staff interface and make notices printable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36723] Add musical presentation to Elasticsearch index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36723 --- Comment #1 from Danyon Sewell --- Created attachment 165938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165938=edit bug 36723: Add musical presentation to Elasticsearch index mappings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36435] Prevent warnings from interrupting koha-run-backups when deleting old backup files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435 --- Comment #11 from Aleisha Amohia --- (In reply to David Nind from comment #8) > I'm getting a sha1/fake ancestor error when trying to apply the pacth 8-(... > > git bz apply 36435 > > Bug 36435 - Prevent warnings from interrupting koha-run-backups when > deleting old backup files > > 164491 - Bug 36435: Always delete old backup files > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 36435: Always delete old backup files > .git/rebase-apply/patch:23: trailing whitespace. > > error: sha1 information is lacking or useless > (debian/scripts/koha-run-backups). > error: could not build fake ancestor > Patch failed at 0001 Bug 36435: Always delete old backup files > > Testing notes (using KTD): > > 1. I used the script in bug 30627#c9 to create the backups with different > dates. > > 2. I couldn't replicate the issue, as the backup with the sample data in KTD > runs too fast! Is there a way to slow down the backup? I've attached Andreas' suggestion as an alternative patch, and fixed Danyon's patch. I think from memory the only way we were able to write to the logs fast enough was by accessing the OPAC so the opac-access.log or opac-access-ssl.log was written to! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36435] Prevent warnings from interrupting koha-run-backups when deleting old backup files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435 Aleisha Amohia changed: What|Removed |Added Attachment #164491|0 |1 is obsolete|| --- Comment #10 from Aleisha Amohia --- Created attachment 165937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165937=edit Bug 36435: Always delete old backup files Recently this step was moved inside the condition so would only run if koha-dump returned a success status. If a log file is being written to while koha-dump runs tar, tar returns a warning and a non-zero exit status. When this happens, koha-dump still completes but the success status condition is not true, so the old backups files are not deleted. There is no nice way to ignore the non-zero exit status from tar, and large libraries receive enough traffic for the tar 'file changed as we read it' warning to cause enough problems that old backup files begin to fill up the disk. This patch removes the koha-dump conditional. This returns the script to the behaviour before it was changed in Bug 30627. Test plan: 1. Create a number of backups and edit their modify time to being older than 2 days 2. run the koha-run-backups script and try and write to one of the files it includes while it's being backed up (you'll trigger a warning from tar saying the file changed as it was being read) 3. verify that the older backups are not being cleaned up and deleted despite new backups being made. 4. Apply this patch 5. Complete steps 1-2 again and then go and look to see if the older backups are being deleted. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36435] Prevent warnings from interrupting koha-run-backups when deleting old backup files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435 --- Comment #9 from Aleisha Amohia --- Created attachment 165936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165936=edit Bug 36435: [alternative] Catch harmless errors in koha-dump tar has exit status 1 if any file has changed while being read, which is likely to happen as the logfiles are included. this patch will catch these harmless errors so that koha-dump will still return a success code. Test plan: 1. Create a number of backups and edit their modify time to being older than 2 days 2. run the koha-run-backups script and try and write to one of the files it includes while it's being backed up (you'll trigger a warning from tar saying the file changed as it was being read) 3. verify that the older backups are not being cleaned up and deleted despite new backups being made. 4. Apply this patch 5. Complete steps 1-2 again and then go and look to see if the older backups are being deleted. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36435] Prevent warnings from interrupting koha-run-backups when deleting old backup files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36435] Prevent warnings from interrupting koha-run-backups when deleting old backup files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435 Aleisha Amohia changed: What|Removed |Added Keywords||rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34972] Canceling a waiting hold from the holds over tab can make the next hold unfillable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #20 from David Nind ---
I had a go at re-testing, but I found things a little confusing and then had
some errors (step 19).
The tests passed before and after the patches.
Testing notes (so far), using KTD:
- Step 4: When I cancel the hold, there is a message saying "Please retain this
item and check it in to process the hold." for Patron B.
- Steps 6, 4, and 5; then there is step 6 again - I'm assuming these can be
ignored. For example the SQL in the first step 6 says "Patron A's
borrowernumber", however there is only one row in the table and that is the
hold for Patron B.
- Step 11:
. For the Holds section of the bibliographic record it shows as an item level
hold, as per the test plan
. On the normal view: "In transit from Centerville to Midway since 04/30/2024
There is an item level hold on this item (priority = 1)."
. If I change the library to Midway, Circulation > Transfers > Transfers to
receive shows the transfer
. I cancelled the transfer and deleted the hold
- Step 15:
. No new modal popped up after selecting a cancellation reason the cancel
hold
. Normal view status: There is an item level hold on this item (priority =
1).
. Holds section details: Only item X
. Patron details: not showing as waiting for pickup
. Circulation > Holds awaiting pickup: no holds showing
- Step 19: repeat steps 1-6 - for step 2, I get this error:
Can't locate object method "damaged" via package "32" (perhaps you forgot to
load "32"?) at /kohadevbox/koha/C4/Reserves.pm line 858
in C4::Reserves::CheckReserves at /kohadevbox/koha/C4/Reserves.pm line 858
855:
856: return unless $item; # bail if we got nothing.
857:
858: return if ( $item->damaged &&
!C4::Context->preference('AllowHoldsOnDamagedItems') );
859:
860: # if item is not for loan it cannot be reserved either.
861: # except where items.notforloan < 0 : This indicates the item is
holdable.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] Koha not caching http://json-schema.org/draft-04/schema#
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36546 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36722 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #47 from David Cook --- (At some point, it could be interesting to look at resolving the API spec in a module which could be pre-loaded like in bug 36721, because that could deliver even further performance gains.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #46 from David Cook --- (In reply to Tomás Cohen Arazi from comment #43) > (In reply to David Cook from comment #28) > > Failing this for now, since it's not deployable. > > > > 1. We need package.json to include yarn api:bundle in build:prod. > > I'm having hard time understanding how we lost that line, which was included > on the first patch! I don't see any patch removing it by itself! The first patch added it to "build" but not to "build:prod". So nothing was lost. Just missed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #45 from David Cook --- (In reply to Katrin Fischer from comment #39) > When I run yarn:build locally it first complains about an outdated module > and then leaves me with an untracked file: > > api/v1/swagger/swagger_bundle.json You'll need to "rm -rf node_modules" and re-run "yarn install" to fix the outdated module issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] Koha not caching http://json-schema.org/draft-04/schema#
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 --- Comment #10 from David Cook --- When I reported and analyzed this one, I wasn't having any errors. I just wanted to make things faster/more efficient. The error for me was hypothetical only, so that's interesting that you did experience the error! To make it reliably fail, you can add the following to your /etc/hosts: 127.0.0.1 json-schema.org -- But yeah we should be able to fix this one by packaging (or by changing the cache paths and providing our own cached files). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36726] Add invalid ISBN to Elasticsearch index mappings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36726 --- Comment #3 from Aleisha Amohia --- Cool thank you! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36435] Prevent warnings from interrupting koha-run-backups when deleting old backup files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #8 from David Nind --- I'm getting a sha1/fake ancestor error when trying to apply the pacth 8-(... git bz apply 36435 Bug 36435 - Prevent warnings from interrupting koha-run-backups when deleting old backup files 164491 - Bug 36435: Always delete old backup files Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 36435: Always delete old backup files .git/rebase-apply/patch:23: trailing whitespace. error: sha1 information is lacking or useless (debian/scripts/koha-run-backups). error: could not build fake ancestor Patch failed at 0001 Bug 36435: Always delete old backup files Testing notes (using KTD): 1. I used the script in bug 30627#c9 to create the backups with different dates. 2. I couldn't replicate the issue, as the backup with the sample data in KTD runs too fast! Is there a way to slow down the backup? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33462] Force password change for new patrons entered by staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33462 Austin Shaver changed: What|Removed |Added CC||austins@ranchomiragelibrary ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36738 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36738] Date attributes follow-ups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36738 David Nind changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32610 CC||da...@davidnind.com --- Comment #3 from David Nind --- I amended the commit message so that the link to the original bug works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36738] Date attributes follow-ups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36738 David Nind changed: What|Removed |Added Attachment #165927|0 |1 is obsolete|| --- Comment #2 from David Nind --- Created attachment 165935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165935=edit Bug 36738: Date attributes follow-ups Make the repeatable date patron attribute empty when repeating the inputs to avoid date formatting problems (and keeping past date value after repeating is not something we want) Test plan: 1- create a patron attribute type with is a date and repeatable checked (administration -> patron attribute types) 2- add a couple of patron attribute of type date, notice the repeated inputs contain previous data 3- Apply the patch 4- redo step 2 and notice the repeated inputs are empty Follow up for bug 32610 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36738] Date attributes follow-ups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36738 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19768] Possibility to choose "Note" tab in OpacSerialDefaultTab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19768 Laura Escamilla changed: What|Removed |Added Attachment #165905|0 |1 is obsolete|| --- Comment #3 from Laura Escamilla --- Created attachment 165934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165934=edit Bug 19768: Add "Title notes" tab to OpacSerialDefaultTab preference This patch adds a "title notes tab" option to the opacSerialDefaultTab preference. To test, apply the patch and restart services. - Go to Administration -> System preferences -> opacSerialDefaultTab. - There should now be a new options, "title notes tab." - Set the preference to the new value. - Go to the OPAC and locate a bibliographic record which is associated with a subscription and which has data in a 5XX notes field. - On the bibliographic detail page the "Title notes" tab should be selected by default. - Test that the other system preference values still work correctly too. Sponsored-by: Athens County Public Libraries Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19768] Possibility to choose "Note" tab in OpacSerialDefaultTab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19768 Laura Escamilla changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36739] Unable to delete a budget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36739 --- Comment #1 from Caroline Cyr La Rose --- I noticed the budget name is not in the warning message in step 7, but the budget_period_id is in the URL, so I'm not sure what is happening. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Laura Escamilla changed: What|Removed |Added Attachment #165907|0 |1 is obsolete|| --- Comment #21 from Laura Escamilla --- Created attachment 165933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165933=edit Bug 22740: Write unit tests for automatic lost status switching This patch adds the unit tests for the new system preferences that will automatically change an items lost status to an authorised value defined in these preferences on payment or write off of outstanding balance. Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Laura Escamilla changed: What|Removed |Added Attachment #165906|0 |1 is obsolete|| --- Comment #20 from Laura Escamilla --- Created attachment 165932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165932=edit Bug 22740: Automatically change lost status when item is paid for This patch implements two new system preferences, "UpdateItemLostStatusWhenWriteOff" and "UpdateItemLostStatusWhenPaid" that allow you to specify the status to change an item to when the outstanding balance of a lost item is paid or written off. These preferences are tied to the LOST authorised values set. Test Plan: - Set one of the system preference to any of the available values - Set an item as lost - Make a manual invoice for your desired user and assign it to the barcode of the above item - Save and Pay - Select Pay/Write Off depending on the system preference you selected above - Pay - Note that the status of the item has changed to the status you set with the system preference - Repeat for all values of both system preferences - Check that when the system preference is left blank and no option is chosen, the lost status does not update. Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Laura Escamilla changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36739] New: Unable to delete a budget
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36739 Bug ID: 36739 Summary: Unable to delete a budget Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org I'm unable to delete a budget that has no funds, even with superlibrarian privileges. To recreate: 1. Go to Administration > Budgets 2. Click New budget 3. Enter a start and end date, a name and an amount (For the test, I entered April 1st, 2024 to April 30, 2024, named the budget "April", and gave it an amount of 100) 4. Click Save 5. Go to Inactive budgets 6. Click Actions next to the budget and choose the Delete option 7. Click Yes, delete 8. Go to Inactive budgets --> The budget is still there -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36735] Cannot revert the waiting status of a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #4 from David Nind --- (In reply to Emily Lamancusa from comment #2) > Submitting for feedback - this seems to work, but there are a couple of > things I'm not sure about: > - I kept the uri TT filters from the existing code. Should those be changed > to html instead since they're not being passed in the URL anymore? > > - I feel like there has to be a better way to handle the dependency between > the .inc file and the JS file, but including the JS asset directly in the > .inc file breaks things (I think because the include is added in the middle > of the page in request.tt, which violates the coding guideline of including > JS assets at the end?) I don't have any feedback on these points, as I don't know enough to knowledgeably comment 8-) However, I have signed off the bug, as I can replicate the issue and it is fixed as per the test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36735] Cannot revert the waiting status of a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735 David Nind changed: What|Removed |Added Attachment #165930|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 165931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165931=edit Bug 36735: Fix revert hold button Update the revert hold button to use the new include for submitting forms from link data with a POST request To test: 1. Place a hold on a biblio record 2. Check an item in to fill the hold 3. On the holds tab for the biblio record, click the "Revert waiting status" button for that hold --> The page reloads but the hold is still waiting 4. Apply patchset 5. Click to another page and then return to the holds tab (we don't want to refresh the page and resend the request) 6. Click the "Revert waiting status" button for that hold --> The hold should be reverted to pending status Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36735] Cannot revert the waiting status of a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36735] Cannot revert the waiting status of a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735 --- Comment #2 from Emily Lamancusa --- Submitting for feedback - this seems to work, but there are a couple of things I'm not sure about: - I kept the uri TT filters from the existing code. Should those be changed to html instead since they're not being passed in the URL anymore? - I feel like there has to be a better way to handle the dependency between the .inc file and the JS file, but including the JS asset directly in the .inc file breaks things (I think because the include is added in the middle of the page in request.tt, which violates the coding guideline of including JS assets at the end?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36735] Cannot revert the waiting status of a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735 Emily Lamancusa changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36735] Cannot revert the waiting status of a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735 Emily Lamancusa changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35766] Allow staff to adjust privacy settings for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35766 Chanel Wheeler changed: What|Removed |Added CC||chanel.whee...@yavapaiaz.go ||v --- Comment #2 from Chanel Wheeler --- We have the case in our rural libraries where patrons come in wanting to know a book they previously read but don't have the equipment or the tech-savviness to get it on their own. They just want the staff to help them. On the flip-side at our larger libraries, they definitely want reading history off unless the patron opts in. All of this is to say that it would helpful if staff could turn this feature on/off for the patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33393] Modify sentence above the order table in English 1-page order PDF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 --- Comment #39 from Alex Buckley --- (In reply to Katrin Fischer from comment #36) > I am going to push this as is with a tiny follow up to explain that this > only works for English 1-page. I think it would have been great to adapt all > the available notices as this won't be usable for libraries relying on the > German or French translations. Maybe I can persuade you to do a follow-up? Hi Katrin, Sorry for my delayed reply, I have been on leave. Firstly, thank you for pushing this enhancement. I have contacted our partner library who sponsored this enhancement to see if they would like to sponsor your suggested follow-up. I'll be in touch if they would like to proceed. Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36735] Cannot revert the waiting status of a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735 --- Comment #1 from Emily Lamancusa --- Created attachment 165930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165930=edit Bug 36735: Fix revert hold button Update the revert hold button to use the new include for submitting forms from link data with a POST request To test: 1. Place a hold on a biblio record 2. Check an item in to fill the hold 3. On the holds tab for the biblio record, click the "Revert waiting status" button for that hold --> The page reloads but the hold is still waiting 4. Apply patchset 5. Click to another page and then return to the holds tab (we don't want to refresh the page and resend the request) 6. Click the "Revert waiting status" button for that hold --> The hold should be reverted to pending status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36515] Amend MARC modification templates so control fields can be copied to subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36515 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #5 from Alex Buckley --- Ready for testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36738] Date attributes follow-ups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36738 Shi Yao Wang changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36738] Date attributes follow-ups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36738 Shi Yao Wang changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36515] Amend MARC modification templates so control fields can be copied to subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36515 --- Comment #4 from Alex Buckley --- Created attachment 165929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165929=edit Bug 36515: Add unit tests Test plan: 1. Run unit tests ktd --shell prove t/SimpleMARC.t Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36515] Amend MARC modification templates so control fields can be copied to subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36515 --- Comment #3 from Alex Buckley --- Created attachment 165928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165928=edit Bug 36515: Amend MARC modification templates so control fields can be copied to subfields Test plan: 1. Apply patch and restart services 2. Create a MARC modification template with the action: Copy and replace field 001 to 099$a unless 099$a exists 3. Perform a Batch record modification using your MARC modification template from #2 4. Confirm that the template has successfully moved the 001 control field value to the 099$a subfield Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36738] Date attributes follow-ups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36738 --- Comment #1 from Shi Yao Wang --- Created attachment 165927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165927=edit Bug 36738: Date attributes follow-ups Make the repeatable date patron attribute empty when repeating the inputs to avoid date formatting problems (and keeping past date value after repeating is not something we want) Test plan: 1- create a patron attribute type with is a date and repeatable checked (administration -> patron attribute types) 2- add a couple of patron attribute of type date, notice the repeated inputs contain previous data 3- Apply the patch 4- redo step 2 and notice the repeated inputs are empty https://bugs.koha-community.org/show_bug.cgi?id=32610 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 Shi Yao Wang changed: What|Removed |Added Attachment #165926|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36515] Amend MARC modification templates so control fields can be copied to subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36515 Alex Buckley changed: What|Removed |Added Attachment #165924|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 --- Comment #63 from Shi Yao Wang --- Sorry, wrong bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 --- Comment #62 from Shi Yao Wang --- Created attachment 165926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165926=edit Bug 36738: Date attributes follow-ups Make the repeatable date patron attribute empty when repeating the inputs to avoid date formatting problems (and keeping past date value after repeating is not something we want) Test plan: 1- create a patron attribute type with is a date and repeatable checked (administration -> patron attribute types) 2- add a couple of patron attribute of type date, notice the repeated inputs contain previous data 3- Apply the patch 4- redo step 2 and notice the repeated inputs are empty -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36722] Koha not caching http://json-schema.org/draft-04/schema#
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36722 --- Comment #9 from Tomás Cohen Arazi --- At some point I did ```shell ktd --shell sudo vim /usr/share/perl5/JSON/Validator/Schema/Draft4.pm ``` and replaced `http` with `https`on line 12. And it started working. But I'm not sure it is really it, as I cannot make it fail anymore :-P Just noting in case it is useful. I think the solution is on packaging as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 Shi Yao Wang changed: What|Removed |Added Blocks||36738 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36738 [Bug 36738] Date attributes follow-ups -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36738] Date attributes follow-ups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36738 Shi Yao Wang changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |shi-yao.w...@inlibro.com |ity.org | Depends on||32610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 [Bug 32610] Add ability to specify patron attribute as a date -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36738] New: Date attributes follow-ups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36738 Bug ID: 36738 Summary: Date attributes follow-ups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: shi-yao.w...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Continuation of bz32610 Make date attributes input empty when repeating. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #61 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #60) > Created attachment 165925 [details] [review] > Bug 32610: (follow-up) Adjust TestBuilder > > Signed-off-by: Tomas Cohen Arazi Pushed this trivial follow-up to clear the failing tests. Any place using testbuilder to generate attribute types would explode. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 --- Comment #60 from Tomás Cohen Arazi --- Created attachment 165925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165925=edit Bug 32610: (follow-up) Adjust TestBuilder Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #44 from Martin Renvoize --- Darn, I should have caught the gitignore regression during QA, apologies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28924] Allow NoIssuesCharge to be determined by patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28924 --- Comment #12 from Kristi --- I am using a ByWater sandbox to go through the test plan, and at step 6, the No Issues Charge, No Issues Charge Guarantees and No Issues Charge Guarantors With Guarantees are not present when I edit a patron type. Would I need to have taken other steps than using one of these test sandboxes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #43 from Tomás Cohen Arazi --- (In reply to David Cook from comment #28) > Failing this for now, since it's not deployable. > > 1. We need package.json to include yarn api:bundle in build:prod. I'm having hard time understanding how we lost that line, which was included on the first patch! I don't see any patch removing it by itself! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #42 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #39) > When I run yarn:build locally it first complains about an outdated module It 'lets you know' there's a newer version of the tool we use to bundle the spec. Not an error per-se. > and then leaves me with an untracked file: > api/v1/swagger/swagger_bundle.json That's the expected output for the command. It highlights the 'Use JSON instead' patch missed to change the file name on the .gitignore file. Follow-up submitted for fixing it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36737] New: Use translations in db_rev
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36737 Bug ID: 36737 Summary: Use translations in db_rev Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-r...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: f.demi...@tamil.fr, jonathan.dru...@gmail.com When something is inserted in the db through a db_rev, it is inserted in English. For most things, it doesn't really matter. But in the case of authorized values and letters in particular, this is problematic in installations that are not in English. From what I understand, people who have non-English installations correct these in an ad hoc fashion, sometimes through SQL UPDATE statements and other times manually in the interface. Since all the terms used in db_revs are also included in the installer yaml files, and those are translated, we should find a way to reuse the translations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #41 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #38) > I suspect this to have broken API driven things like patron search: > > Something went wrong when loading the table. > 404: Not Found. > > HELP. This is related to bug 36722. I was able to reproduce the failure, but at some point it started working again. So probably a networking issue with json-schema.org The right solution is on 36722. And should be done on packaging. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36515] Amend MARC modification templates so control fields can be copied to subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36515 Alex Buckley changed: What|Removed |Added Attachment #164575|0 |1 is obsolete|| --- Comment #2 from Alex Buckley --- Created attachment 165924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165924=edit Bug 36515: Amend MARC modification templates so control fields can be copied to subfields Test plan: 1. Apply patch and restart services 2. Create a MARC modification template with the action: Copy and replace field 001 to 099$a unless 099$a exists 3. Perform a Batch record modification using your MARC modification template from #2 4. Confirm that the template has successfully moved the 001 control field value to the 099$a subfield Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36546] Bundle API spec to speed up worker startup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36546 --- Comment #40 from Tomás Cohen Arazi --- Created attachment 165923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165923=edit Bug 36546: (QA follow-up) Add bundle spec to .gitignore Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36651] Add placeholder text to the search bar in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36651 Owen Leonard changed: What|Removed |Added Summary|Add hint text in the search |Add placeholder text to the |bar in the OPAC |search bar in the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Shi Yao Wang changed: What|Removed |Added Attachment #165913|0 |1 is obsolete|| --- Comment #142 from Shi Yao Wang --- Created attachment 165922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165922=edit Bug 27113: Fix input size of all searchbar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32610] Add ability to specify patron attribute as a date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 --- Comment #59 from Shi Yao Wang --- (In reply to Katrin Fischer from comment #57) > (In reply to Katrin Fischer from comment #56) > > I am not sure there is a use case for the repeated text - maybe we could do > > a really quick poll on Mattermost. I'll ask. > > Discussed with Caroline at least and I think clearing the data makes more > sense and is (hopefully) also easy to do? Looks like I'm a bit late, I just saw the message. Why is this already pushed? Isn't there still formatting/save problems? Didn't we want to clear the date attributes when repeating it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36735] Cannot revert the waiting status of a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735 Emily Lamancusa changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36605] TrackLastPatronActivity for SIP should track both patron status and patron information requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36605 --- Comment #6 from Nick Clemens --- TrackLastPatronActivityTriggers is only 23.11+ - 23.05 version supplied -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36605] TrackLastPatronActivity for SIP should track both patron status and patron information requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36605 --- Comment #5 from Nick Clemens --- Created attachment 165921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165921=edit Bug 36605: [23.05.x] Add update_lastseen to handle_patron_status for SIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #36 from Laura Escamilla --- Created attachment 165920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165920=edit Bug 27753: Tidy unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #35 from Laura Escamilla --- Created attachment 165919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165919=edit Bug 27753: Tidy Circulation.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #34 from Laura Escamilla --- Created attachment 165918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165918=edit Bug 27753: Tidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla changed: What|Removed |Added Attachment #165912|0 |1 is obsolete|| --- Comment #33 from Laura Escamilla --- Created attachment 165917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165917=edit Bug 27753: Follow up with updated unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla changed: What|Removed |Added Attachment #165911|0 |1 is obsolete|| --- Comment #32 from Laura Escamilla --- Created attachment 165916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165916=edit Bug 27753: Follow up updates to C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla changed: What|Removed |Added Attachment #163480|0 |1 is obsolete|| --- Comment #31 from Laura Escamilla --- Created attachment 165915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165915=edit Bug 27753: Unit tests Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla changed: What|Removed |Added Attachment #163479|0 |1 is obsolete|| --- Comment #30 from Laura Escamilla --- Created attachment 165914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165914=edit Bug 27753: Added new system preferences for automatically resolving claims To test: 1. Configure Claims returned 1. Go to Administration > Authorized Values > LOST 2. Add a new authorized value with value:6 and description:Claims returned 3. Go to Administration > System Preferences 4. Set ClaimReturnedLostValue to 6 and save 2. Check out an item to a patron. 1. Mark the item as claim returned 2. Check the item in. 3. A message stating that the item has been claimed as returned pops up with an option to resolve. 4. Resolve the claim. 3. Check out the item to the patron again. 1. Mark the item as claim returned. 2. Check out the item to a new patron. Select “Yes, check out” 3. Go back to the previous patron. Notice that their claim was not resolved. 4. Apply the patch. 1. Updatedatabase 2. restart_all 3. Go to the system preferences and set the system preference ‘AutoClaimReturnStatusOnCheckin’ to ‘Returned by patron’ 4. Set ‘AutoClaimReturnStatusOnCheckout’ to ‘Found in library’ 5. Redo step 2 1. When checking the claim returned item in you will now see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Returned by patron’ 6. Redo step 3 1. Upon checking the item out to another patron you will see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Found in library’. 7. Sign off and have a wonderful day! Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36736] Add ability to load DBIx::Class Schema files found in plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36736 --- Comment #1 from Kyle M Hall --- Forgot to mention, we probably need to do that search and load in Koha::Schema -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36736] Add ability to load DBIx::Class Schema files found in plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36736 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36736] New: Add ability to load DBIx::Class Schema files found in plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36736
Bug ID: 36736
Summary: Add ability to load DBIx::Class Schema files found in
plugins
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
Right now, it is not possible to create custom Koha::Object(s) for a plugin
without breaking things. For example we did this:
BEGIN {
my $path = Module::Metadata->find_module_by_name(__PACKAGE__);
$path =~ s!\.pm$!/lib!;
unshift @INC, $path;
require Koha::CurbsidePickupIssues;
require Koha::CurbsidePickupPolicies;
require Koha::CurbsidePickups;
require Koha::Schema::Result::CurbsidePickup;
require Koha::Schema::Result::CurbsidePickupIssue;
require Koha::Schema::Result::CurbsidePickupPolicy;
# register the additional schema classes
Koha::Schema->register_class(CurbsidePickup =>
'Koha::Schema::Result::CurbsidePickup');
Koha::Schema->register_class(CurbsidePickupPolicy =>
'Koha::Schema::Result::CurbsidePickupPolicy');
Koha::Schema->register_class(CurbsidePickupIssue =>
'Koha::Schema::Result::CurbsidePickupIssue');
# ... and force a refresh of the database handle so that it includes
# the new classes
Koha::Database->schema({ new => 1 });
}
In the curbside pickups plugin before it was integrated. The problem we've
found is that calling Koha::Database->schema({ new => 1 }); resets the database
connection and breaks any transactions you were in when the plugin was loaded!
We should be able to search for and load any schema files found in plugin
directories to make this all unnecessary.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36192] [OMNIBUS] CSRF Protection for Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 Emily Lamancusa changed: What|Removed |Added Depends on||36735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735 [Bug 36735] Cannot revert the waiting status of a hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36246] Have a centralized method for submitting a form via a link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36246 Emily Lamancusa changed: What|Removed |Added Blocks||36735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735 [Bug 36735] Cannot revert the waiting status of a hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36735] New: Cannot revert the waiting status of a hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36735 Bug ID: 36735 Summary: Cannot revert the waiting status of a hold Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamanc...@montgomerycountymd.gov QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 36246 Blocks: 36192 To reproduce: 1. Place a hold on a biblio record 2. Check an item in and confirm the hold 3. On the holds tab for the biblio record, click the "Revert waiting status" button for that hold --> The page reloads but the hold is still waiting Looking at the code for the button, I'm pretty sure it just needs to be updated for CSRF. I think this is one of the use cases bug 36246 is for, if I'm understanding it correctly? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36246 [Bug 36246] Have a centralized method for submitting a form via a link -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #141 from Shi Yao Wang --- Created attachment 165913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165913=edit Bug 27113: Fix input size of all searchbar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35681] Add support for colored messages in the output of updatedatabase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 --- Comment #45 from Katrin Fischer --- Thanks Mason, what is the next step here now? (who tests what?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 --- Comment #78 from Martin Renvoize --- I'd be more than happy with experimental and I will refine as bugfixes during the first month of the next cycle if that works for people? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #29 from Laura Escamilla --- Created attachment 165912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165912=edit Bug 27753: Follow up with updated unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #28 from Laura Escamilla --- Created attachment 165911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165911=edit Bug 27753: Follow up updates to C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27753] Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 --- Comment #12 from Martin Renvoize --- I've made the same fix for the OPAC now in the follow-up on bug 35977 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35559] Can't change the pickup date of holds on the last day of expiration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35559 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #24 from Martin Renvoize --- Thanks to Nick for helping me wrap my head around this and Emily for the clean code in bug 35559 which lead to the fix. This should be ready to go again now Katrin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 Martin Renvoize changed: What|Removed |Added Attachment #165725|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27113] Elasticsearch: Autocomplete in search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Koha collecto changed: What|Removed |Added CC||k...@collecto.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35977] Display current date in hold starts on when placing a hold in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35977 --- Comment #23 from Martin Renvoize --- Created attachment 165910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165910=edit Bug 35977: (follow-up) Cleaner working approach This patch removes the Date_from_syspref recently added and replaces it with the correct parseDate call as per bug 35559. We also clean up the code around setting the input value in the first place and use iso which is what the rest of flatpickr expects and now is handled correctly in futuredate pickers. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35657] Add ability to assign tickets to librarians for catalog concerns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35657 --- Comment #77 from Katrin Fischer --- I can't do more for today, but I will still review this for 24.05 end of the week. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
