[Koha-bugs] [Bug 36338] Capitalization: Card number or Userid may already exist.

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36338

David Nind  changed:

   What|Removed |Added

   Keywords||no-sandbox

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36338] Capitalization: Card number or Userid may already exist.

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36338

--- Comment #1 from David Nind  ---
Created attachment 166802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166802=edit
Bug 36338: Update onboarding error message when creating the Koha administrator
patron

Update the error message for the web installer onboarding
section when creating the Koha administrator patron (where
the card number or username already exists):
- Fix capitalization
- Use the same label in the error message as used in
  the form

Error message before: The patron has not been created!
Card number or Userid may already exist.

Error message after: The patron was not created! The
card number or username already exists.

Test plan:
1. Option 1:
   1.1 Review the diff for the patch and make sure that
   the updated text makes sense.
   . Previous text: The patron has not been created!
 Card number or Userid may already exist.
   . Updated text: The patron was not created! The
 card number or username already exists.
OR
2. Option 2:
   2.1 Access the database server:
   mysql -uroot -ppassword -hkoha-db-1
   2.2 Drop the koha_kohadev database:
   drop database koha_kohadev;
   2.3 Create the database: create database koha_kohadev;
   2.4 Add privileges (for a real installation this would
   be limited):
   grant all on koha_kohadev.* to koha_kohadev;
   2.5 Restart everything (there may be some errors listed):
   flush_memcached and then restart_all
   2.6 Access the web installer: go to 127.0.0.1:8081
   2.7 Use the database user name and password: get from
   /etc/koha/sites/kohadev/koha-conf.xml
   (default: koha_kohadev, password)
   2.8 Continue through the installation process until you
   reach 'Selecting default settings':
  . Make appropriate selections to use all the sample
data options and settings
   2.9 For the 'Onboarding' step - Create Koha
   administrator patron:
   . Surname: Acevedo
   . First name: Henry
   . Card number: make up a number that doesn't exist in
 the sample date, for example: 741852963
   . Library: Centerville
   . Patron category: Staff
   . Username: 2352935676 (this is an existing
 value already in the sample data)
   . Password: a valid password, for example:
 KohaCon2024
   . Confirm password: repeat password used
   . Submit
 ==> Error message before patch: The patron has not
 been created! Card number or Userid may
 already exist.
   2.10 Apply the patch.
   2.11 Repeat step 2.9
   2.12 The error message is now: The patron was not created!
The card number or username already exists.

3. Sign off.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36338] Capitalization: Card number or Userid may already exist.

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36338

David Nind  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36338] Capitalization: Card number or Userid may already exist.

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36338

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
   Assignee|oleon...@myacpl.org |da...@davidnind.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 34863] Allow definition of custom url for pages

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34863

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36866] Allow parent / child relationship for Pages

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36866

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
This could be cool

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
Testing notes (using KTD):

1. For step 5, I had to repeat the check in to get the 'Please return this item
to (Library B)' modal to appear. In general, it appeared every second check in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945

David Nind  changed:

   What|Removed |Added

 Attachment #166785|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 166801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166801=edit
Bug 13945: Prevent multiple dialog modals from popping up when capturing a hold
at checkin

1. Select/Create Library Branches:
- Select or create two library branches: Library A and Library B.

2. Locate/Create Item:
- Locate or create an item with the "Current library" and "Home library"
set to Library A.

3. Place Hold:
- Place a hold on the item for a patron whose pickup location is Library B.

4. Check-in at Library A - First Attempt:
- Check in the item at Library A.
- Verify that the 'Hold found' modal pops up.
- Click on 'Confirm hold and transfer'.

5. Check-in at Library A - Second Attempt:
- Check in the item at Library A again.
- Verify that the 'Hold found' modal pops up.
- Click on 'Ignore'.
- Verify that the 'Please return this item to (Library B)' modal has popped
up behind it.

6. Apply Patch and Restart:
- Apply the patch to the system.
- Restart all relevant services.

7. Repeat Check-in Process:
- Repeat steps 4 and 5.
- Verify that no matter how many times you check in the item and hit
'Ignore' or 'Confirm the hold', the second modal does not pop up.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36862] Cart window becomes unresponsive if checkboxes are manipulated in a certain order

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||da...@davidnind.com

--- Comment #3 from David Nind  ---
For me, the change works fine in the staff interface, but not in the OPAC. That
is, still experience the described issue.

Tested in Firefox Developer Edition and Chromium.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36589] Advanced cataloging - restore the correct height of the clipboard

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589

Phil Ringnalda  changed:

   What|Removed |Added

Summary|Advanced cataloging -   |Advanced cataloging -
   |Expand clipboard|restore the correct height
   ||of the clipboard
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36589] Advanced cataloging - Expand clipboard

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589

Phil Ringnalda  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |p...@chetcolibrary.org
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36873] Koha::Objects->delete should accept parameters and pass them through

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36873

David Nind  changed:

   What|Removed |Added

 Attachment #166791|0   |1
is obsolete||

--- Comment #4 from David Nind  ---
Created attachment 166800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166800=edit
Bug 36873: Make Koha::Objects->delete pass parameters to the underlying method

This patch makes the generic method pass any parameters it got passed to
the underlying `delete()` method.

To test:
1. Apply the unit tests patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Objects.t
=> FAIL: Tests fail, parameters are not passed
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36873] Koha::Objects->delete should accept parameters and pass them through

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36873

David Nind  changed:

   What|Removed |Added

 Attachment #166790|0   |1
is obsolete||

--- Comment #3 from David Nind  ---
Created attachment 166799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166799=edit
Bug 36873: Unit tests

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36873] Koha::Objects->delete should accept parameters and pass them through

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36873

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36694] Remove HC Sticky library in favor of CSS

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694

--- Comment #46 from David Nind  ---
(In reply to Lucas Gass from comment #45)
> I've addressed David's findings and have reset this to NSO.

Thanks Lucas!

I just re-tested the things I noted with potential issues.

With the patron permissions page:
- The correct toolbar is now shown
- However:
  . the Show all/Hide all buttons on the toolbar don't seem to be working now
  . the "Show details" link/button in the page doesn't expand to show the
permission details

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36557] Improve logic and display of OPAC cart, tag, and lists controls

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557

David Nind  changed:

   What|Removed |Added

 Attachment #166422|0   |1
is obsolete||

--- Comment #13 from David Nind  ---
Created attachment 166798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166798=edit
Bug 36557: Convert Cart and Lists controls to buttons and rework logic

This patch tries to address errors in the way features are displayed in
result lists so that controls for holds, tags, lists, etc. are shown or
hidden according to system preferences.

The patch converts the Cart/Lists dropdown to separate buttons, making
the display logic simpler and making the interface more consistent with
updates to the staff interface search results.

To test, apply the patch and rebuild the OPAC CSS.

- In the OPAC, test these pages:
  - Catalog search results
  - List contents
- Test with various combinations of these system preferences:
  - opacbookbag
  - DisplayMultiPlaceHold
  - virtualshelves
  - OPACHoldRequests
  - TagsEnabled
  - TagsInputOnList
  - UseRecalls
  - ArticleRequests

With each different combination of settings the right controls should
appear in the toolbar at the top (if present), and with each search
result.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36557] Improve logic and display of OPAC cart, tag, and lists controls

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36557] Improve logic and display of OPAC cart, tag, and lists controls

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36557

--- Comment #12 from David Nind  ---
(In reply to Owen Leonard from comment #11)
> (In reply to David Nind from comment #10)
> 
> > 2. After the patch, 'Request article' is not displayed in the search
> > results, record details page, or lists.
> 
> I'm not seeing this. In my testing the 'Request article' link shows up as
> expected on search results and lists with both settings of
> ArticleRequestsLinkControl.
> 
> My patch doesn't touch the record detail page, so if there's an issue with
> that it's separate.

Have re-tested and is now showing. My apologies Owen, there must have been
something wrong with my setup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36149] userenv stored in plack worker's memory and survive from one request to another

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36149

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36149] userenv stored in plack worker's memory and survive from one request to another

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36149

Tomás Cohen Arazi  changed:

   What|Removed |Added

Product|Koha security   |Koha
  Group|Koha security   |
  Component|Koha|Architecture, internals,
   ||and plumbing

--- Comment #42 from Tomás Cohen Arazi  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19613] Scrub borrowers fields: borrowernotes opacnote

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19613

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact||testo...@bugs.koha-communit
   ||y.org
  Group|Koha security   |
 CC||gmcha...@gmail.com,
   ||kyle.m.h...@gmail.com
Product|Koha security   |Koha
  Component|Koha|Patrons
 Status|Passed QA   |Pushed to main

--- Comment #16 from Tomás Cohen Arazi  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36532] Any authenticated OPAC user can run opac-dismiss-message.pl for any user/any message

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36532

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
  Component|Koha|OPAC
Product|Koha security   |Koha
  Group|Koha security   |

--- Comment #12 from Tomás Cohen Arazi  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36382] XSS in showLastPatron dropdown

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36382

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Group|Koha security   |
  Component|Koha|Templates
 Status|Passed QA   |Pushed to main
Product|Koha security   |Koha

--- Comment #20 from Tomás Cohen Arazi  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633

--- Comment #57 from Nick Clemens (kidclamp)  ---
(In reply to Katrin Fischer from comment #50)
> Sorting in the patron search results is a little off:
> 
> I have:
> 
> Katrin Fischer
> Katrina Fischer
> Cait Fischer (where Cait is preferred name)
> 
> I think the last should be the first entry?
> 
> Otherwise all fixes from last testing appear to be ok.

I still cannot fix this - patrons without a preferred_name sort before those
with one - we need some sort of conditional or function to make this sort
correctly afaict, and I can't seem to make that work. If someone with more
datatables or API knowledge can help I'd appreciate it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36623] Remove localhost reference from counter logs page

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36623

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi  ---
Follow up pushed to main. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633

--- Comment #56 from Nick Clemens (kidclamp)  ---
Created attachment 166794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166794=edit
Bug 28633: DO NOT PUSH Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633

--- Comment #55 from Nick Clemens (kidclamp)  ---
Created attachment 166793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166793=edit
Bug 28633: Add preferred name field to patrons

This patch adds a new field 'preferred_name' to the patron record.

Additionally it adds a method 'effective_name' to choose the preferred name if
present
and fall back to firstname

The 'firstname' is displayed as 'First name' on the details page, with id/class
patron_first_name to allow ajusting via JS/CSS if library wants to
highlight/hide
the non-preferred name

PatronAutoComplete/ysearch is updated to use 'effective_name' method

To test:
 1 - Apply patches
 2 - Update database and restart all, clear browser cache
 3 - Load a patron in staff module
 4 - Confirm you see and can add a preferred name
 5 - Confirm the preferred name and first name now displays on patron details
 6 - Remove first name from patron record and confirm it no longer shows
 7 - Edit sysprefs BorrowerMandatoryFields and BorrowerUnwantedFields to
confirm you can make
 new field required or hidden
 8 - Sign in as patron to opac
 9 - Confirm preferred name shows
10 - Edit account on opac and confirm field is present
11 - Verify DefaultPatronSearchFields contains 'preferredname' if your pref had
firstname
12 - Perform checkout and patron search using preferred_name, confirm patron is
found
13 - Enable PatronAutoComplete system preference
14 - Type patron's surname into Checkout or patron search but don't hit enter
15 - Confirm patron is displayed with 'preferred_name' in the preview

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #133958|0   |1
is obsolete||
 Attachment #133959|0   |1
is obsolete||
 Attachment #133960|0   |1
is obsolete||
 Attachment #133961|0   |1
is obsolete||
 Attachment #133962|0   |1
is obsolete||
 Attachment #133963|0   |1
is obsolete||
 Attachment #133964|0   |1
is obsolete||
 Attachment #133965|0   |1
is obsolete||

--- Comment #54 from Nick Clemens (kidclamp)  ---
Created attachment 166792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166792=edit
Bug 28633: DB update

This adds the field to necessary tables and updates API and columns def

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36470] Generate CHECKOUT, CHECKIN and HOLD digest notices should be generated at once, not amended over time

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36470

Cheryl  changed:

   What|Removed |Added

 CC||clack...@fargolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35254] Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35254

--- Comment #15 from Caroline Cyr La Rose  ---
Okay thanks! I thought maybe there was a problem with the patch that needed to
be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26654] Add item number column to item search results

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26654

Angela Berrett  changed:

   What|Removed |Added

 CC||angela.berrett@familysearch
   ||.org

--- Comment #8 from Angela Berrett  ---
This might be the same or at least linked to bug 15787.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35254] Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35254

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #14 from Nick Clemens (kidclamp)  ---
My fault, I did that for attention for backporting 

Closing now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35254] Adding files to basket from a staged file uses wrong inputs for order information when not all records are selected

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35254

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #13 from Caroline Cyr La Rose  ---
Why is this set to REOPENED?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15787] Show and export itemnumber and biblionumber via the item search

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15787

Angela Berrett  changed:

   What|Removed |Added

 CC||angela.berrett@familysearch
   ||.org

--- Comment #3 from Angela Berrett  ---
Agreed - this would be extremely helpful for collections that do not have
barcodes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24597] Add ability to add note on all payment/writeoff screens

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24597

Emily Lamancusa  changed:

   What|Removed |Added

 CC||emily.lamancusa@montgomeryc
   ||ountymd.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36873] Koha::Objects->delete should accept parameters and pass them through

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36873

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 166791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166791=edit
Bug 36873: Make Koha::Objects->delete pass parameters to the underlying method

This patch makes the generic method pass any parameters it got passed to
the underlying `delete()` method.

To test:
1. Apply the unit tests patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/Koha/Objects.t
=> FAIL: Tests fail, parameters are not passed
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36873] Koha::Objects->delete should accept parameters and pass them through

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36873

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 166790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166790=edit
Bug 36873: Unit tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36873] Koha::Objects->delete should accept parameters and pass them through

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36873

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36815] Add the option to 'Reset to default' in the notices editor

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36815

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36874] New: Confirming batch deletion of patrons seems to take as long as the initial search

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36874

Bug ID: 36874
   Summary: Confirming batch deletion of patrons seems to take as
long as the initial search
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org

When you confirm deletion of patrons in the batch patron deletion tool, it
seems like it takes a very long time.

I would assume when you set your criteria on the first page, it is gathering
all the records that meets that criteria and creating a list for you to
confirm.  But when you confirm, it seems like it takes just as long to finish. 
Even when I just deleted 9 patrons.  It seems like that should have gone fairly
quick.  Granted, I know there are probably a lot of tables and records to
touch.  But is the tool going through the entire patron database again, or is
it creating a list of qualifying patrons and only going through those records
and related tables?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36873] Koha::Objects->delete should accept parameters and pass them through

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36873

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||jonathan.dru...@gmail.com,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36873] Koha::Objects->delete should accept parameters and pass them through

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36873

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36873] New: Koha::Objects->delete should accept parameters and pass them through

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36873

Bug ID: 36873
   Summary: Koha::Objects->delete should accept parameters and
pass them through
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Taking `Koha::Item->delete` as an example, it accepts many parameters.
Calling `Koha::Items->delete` will find out there's a `delete()` method defined
in `Koha::Item` and loop through all items, calling that particular method.

It would be handy if we could pass on some parameters. As an example, the
following sequence:

```perl
$biblio->items->delete;
DelBiblio( $biblio->id);
```

would trigger reindexing the record for each item, and then when actually
deleting the biblio. With the current codebase, to avoid it, we could instead
do:

```perl
foreach my $item ($biblio->items->as_list) {
$item->delete( { skip_record_index } );
}
DelBiblio( $biblio->id);
```

But it would be great if we could just write:

```perl
$biblio->items->delete( { skip_record_index => 1 } );
DelBiblio( $biblio->id );
```

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36872] Untranslatable "Please make sure all selected titles have a pickup location set"

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36870] Don't ask for pickup location when there is only one library

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36870

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36872] New: Untranslatable "Please make sure all selected titles have a pickup location set"

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872

Bug ID: 36872
   Summary: Untranslatable "Please make sure all selected titles
have a pickup location set"
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: f.demi...@tamil.fr, jonathan.dru...@gmail.com

When placing a multi-hold, the error message that appears if you don't select a
pickup library is untranslatable.

To recreate the message:
1. In the staff interface, search the catalog with a term that will return a
couple of items (e.g. Shakespeare)
2. In the search results, select two or more results
3. Click Place hold
4. Search for a patron (e.g. Acevedo)
5. Click Place holds
   --> Error "Please make sure all selected titles have a pickup location set" 

To get po files:

ktd --shell

cd misc/translator/po

gulp po:update --lang fr-CA

git grep "Please make sure all"
--> Returns nothing

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36870] Don't ask for pickup location when there is only one library

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36870

Caroline Cyr La Rose  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36871

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871

Caroline Cyr La Rose  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36870

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36871] New: DefaultHoldPickupLocation = logged in library on multi-holds

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871

Bug ID: 36871
   Summary: DefaultHoldPickupLocation = logged in library on
multi-holds
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

If DefaultHoldPickupLocation is set to logged in library, this should be taken
into account when placing multi-holds. 

To recreate:
0. Make sure the DefaultHoldPickupLocation system preference is set to logged
in library.
1. In the staff interface, search the catalog with a term that will return a
couple of items (e.g. Shakespeare)
2. In the search results, select two or more results
3. Click Place hold
4. Search for a patron (e.g. Acevedo)
   --> "Pickup at" and "Pickup location" are empty and the staff member must
select the library

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36811] JS error on all staff interface and OPAC pages - Uncaught TypeError Cannot read properties of null

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36811

David Nind  changed:

   What|Removed |Added

   Keywords|RM_priority |
   Severity|major   |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36811] JS error on all staff interface and OPAC pages - Uncaught TypeError Cannot read properties of null

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36811

--- Comment #3 from David Nind  ---
Created attachment 166789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166789=edit
Error message - Chromium browser

I've re-checked.

This only shows when using the Chromium browser (v124.0.6367.155).

It doesn't show when using Firefox or Google Chrome.

Will change status.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36870] New: Don't ask for pickup location when there is only one library

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36870

Bug ID: 36870
   Summary: Don't ask for pickup location when there is only one
library
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: caroline.cyr-la-r...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When placing multiple holds, DefaultHoldPickupLocation doesn't select a default
library (probably since items can have different home or holding libraries).
But in installations where there is only one library, it adds an unnecessary
step to select a pickup library.

To recreate:

0. If you have more than one library, you need to move the items and patrons to
one library and delete the others. For example, in KTD

ktd --dbshell

update borrowers set branchcode = 'CPL';

update items set homebranch = 'CPL', holdingbranch = 'CPL';

Then go to Administration > Libraries and delete all the libraries except
Centerville.

1. In the staff interface, search the catalog with a term that will return a
couple of items (e.g. Shakespeare)
2. In the search results, select two or more results
3. Click Place hold
4. Search for a patron (e.g. Acevedo)
   --> "Pickup at" and "Pickup location" are empty and the staff member must
select the library

These fields should default to the single library.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 33554] searching borrowers is a lot slower if there's searchable extended attributes.

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33554

sbar...@aacpl.net changed:

   What|Removed |Added

 CC||sbar...@aacpl.net

--- Comment #22 from sbar...@aacpl.net ---
I use a searchable extended attribute as part of a workflow for moving patrons
into different patron lists. Having the attribute available as a choice in the
Search field drop-down would work well.
We have over 277,000 patrons so this does have quite an impact.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20962] Overhaul to notices

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962

Cheryl  changed:

   What|Removed |Added

 CC||clack...@fargolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36862] Cart window becomes unresponsive if checkboxes are manipulated in a certain order

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36862] Cart window becomes unresponsive if checkboxes are manipulated in a certain order

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862

--- Comment #2 from Lucas Gass  ---
Created attachment 166788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166788=edit
Bug 36862: Remove jQuery change() event

To test:
1 - Search the catalog in the staff client and/or OPAC
2 - Add 3 or more titles to the cart
3 - Open the cart via the button in the top menu
4 - Click "Select all"
5 - Uncheck the first checkbox
6 - Click "Clear all"
7 - APPLY PATCH, clear browser cache
8 - Try again, the browser should not crash.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36862] Cart window becomes unresponsive if checkboxes are manipulated in a certain order

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36862] Cart window becomes unresponsive if checkboxes are manipulated in a certain order

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862

--- Comment #1 from Lucas Gass  ---
I believe this is happening when the change event is triggered in cart.js. 

I don't understand why change() is being used here and I don't think it is
necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36020] Port default recall notices to Template Toolkit

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36699] Use 'diff' option in actionlogs more widely.

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36699

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||andre...@dubcolib.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36862] Cart window becomes unresponsive if checkboxes are manipulated in a certain order

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36811] JS error on all staff interface and OPAC pages - Uncaught TypeError Cannot read properties of null

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36811

--- Comment #2 from Katrin Fischer  ---
Same for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35586] Add the collection to the location column in the OPAC cart

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35586

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com
 Version(s)|25.05   |24.05
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945

Laura Escamilla  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |Laura.escamilla@bywatersolu
   |ity.org |tions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945

--- Comment #1 from Laura Escamilla  ---
Created attachment 166785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166785=edit
Bug 13945: Prevent multiple dialog modals from popping up when capturing a hold
at checkin

1. Select/Create Library Branches:
- Select or create two library branches: Library A and Library B.

2. Locate/Create Item:
- Locate or create an item with the "Current library" and "Home library"
set to Library A.

3. Place Hold:
- Place a hold on the item for a patron whose pickup location is Library B.

4. Check-in at Library A - First Attempt:
- Check in the item at Library A.
- Verify that the 'Hold found' modal pops up.
- Click on 'Confirm hold and transfer'.

5. Check-in at Library A - Second Attempt:
- Check in the item at Library A again.
- Verify that the 'Hold found' modal pops up.
- Click on 'Ignore'.
- Verify that the 'Please return this item to (Library B)' modal has popped
up behind it.

6. Apply Patch and Restart:
- Apply the patch to the system.
- Restart all relevant services.

7. Repeat Check-in Process:
- Repeat steps 4 and 5.
- Verify that no matter how many times you check in the item and hit
'Ignore' or 'Confirm the hold', the second modal does not pop up.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945

Laura Escamilla  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36869] New: Add ability to start an acquisition order from a cart

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36869

Bug ID: 36869
   Summary: Add ability to start an acquisition order from a cart
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Some librarians would like the ability to start the acquisitions order process
from a cart.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36868] New: Add ability to automatically empty cart after placing holds ( staff interface and OPAC )

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868

Bug ID: 36868
   Summary: Add ability to automatically empty cart after placing
holds ( staff interface and OPAC )
 Change sponsored?: ---
   Product: Koha
   Version: Main
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lu...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Some librarians would like to have the cart automatically clear itself after
placing holds on items in the current cart. 

This would behave similar to how online retail/e-commerce sites work after one
has purchased items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36811] JS error on all staff interface and OPAC pages - Uncaught TypeError Cannot read properties of null

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36811

Brendan Lawlor  changed:

   What|Removed |Added

 CC||blaw...@clamsnet.org

--- Comment #1 from Brendan Lawlor  ---
Is this still valid? I can't reproduce in either the staff interface or OPAC.

I tried many different pages, saw some warnings about markup, but no js error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36020] Port default recall notices to Template Toolkit

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com
   Assignee|koha-b...@lists.koha-commun |lisette.scheer@bywatersolut
   |ity.org |ions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36020] Port default recall notices to Template Toolkit

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020

--- Comment #1 from Lisette Scheer  ---
Created attachment 166784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166784=edit
Bug 36020: Port default recall notices to Template Toolkit The following
notices relating to recalls all need to be updated to use Template Toolkit
syntax:

RETURN_RECALLED_ITEM
PICKUP_RECALLED_ITEM
RECALL_REQUESTER_DET

To test:
1) Observe the default notice contains <<>> tags
2) Apply the patch
3) reset_all
4) Check that the notice is now all in template toolkit [%  %] tags
5) Enable recalls
6) Check an item out to a patron
7) Make sure the patron has a primary email
8) Make sure a secondary patron has a primary email
9) Generate a recall on the checked out item for the second patron
10) Check the first patron's notices tab to confirm the return recalled item
notice generated properly.
11) Check the item back in and generate the recall slip and confirm it
generated correctly.
12) Check the second patron's notices tab to confirm the pickup recalled item
notice generated properly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36020] Port default recall notices to Template Toolkit

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020

Lisette Scheer  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35442] Script migration_tools/build_oai_sets.pl is missing ORDER BY

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35442

Lucas Gass  changed:

   What|Removed |Added

 Attachment #159367|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 166783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166783=edit
Bug 35442: Script migration_tools/build_oai_sets.pl add ORDER BY

Script migration_tools/build_oai_sets.pl is missing ORDER BY biblionumber.
This is a problem when using OFFSET and LIMIT, the results may be differenly
orderder between two calls of this script.

Test plan :
1) Create a OAI SET with all records
2) Run migration_tools/build_oai_sets.pl with the first half of records
3) Run migration_tools/build_oai_sets.pl with the second half of records
4) Check all records are in the OAI set

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35442] Script migration_tools/build_oai_sets.pl is missing ORDER BY

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35442

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35771] Unselecting titles when making multi-hold does not have any effect

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Needs Signoff   |Failed QA

--- Comment #4 from Lucas Gass  ---
With this patch applied I cannot place multi-hold's at all. 

I think we should also fix the problem of multiple ID's ( #holdable_bibs ) on
the same page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15279] Deprecate bespoke syntax for Slips and Notices

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||36815


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36815
[Bug 36815] Add the option to 'Reset to default' in the notices editor
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36815] Add the option to 'Reset to default' in the notices editor

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36815

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||15279


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279
[Bug 15279] Deprecate bespoke syntax for Slips and Notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35931] More preselected items in the renew column on details page and on checkout page

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35931

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35931] More preselected items in the renew column on details page and on checkout page

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35931

Lucas Gass  changed:

   What|Removed |Added

Version|22.11   |Main
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35931] More preselected items in the renew column on details page and on checkout page

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35931

Lucas Gass  changed:

   What|Removed |Added

 Attachment #166143|0   |1
is obsolete||

--- Comment #2 from Lucas Gass  ---
Created attachment 166782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166782=edit
Bug 35931: More preselected items in the renew column on patron checkouts

When viewing patron checkouts table from details or circulation page, overdue
checkouts
are preselected for renewals and the overdue dates are bolded and red. This
patch will enable
also preselecting checkouts that are due on the current day. The due dates for
these checkouts
will be bolded but not red.

Test plan:
1) See/create a patron with several checkouts: overdue, due today and due
later.
2) Note that only the overdue checkouts have a checkmark on Renew column when
loading the table.
3) Apply patch.
4) Load the checkouts table again. Note that now also the checkout due today
has a preselected renewal
   checkmark and the due date has been bolded.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35931] More preselected items in the renew column on details page and on checkout page

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35931

Lucas Gass  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36529] manage_additional_fields permission for more than acquisitions and serials

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529

Lucas Gass  changed:

   What|Removed |Added

 Attachment #166777|0   |1
is obsolete||

--- Comment #4 from Lucas Gass  ---
Created attachment 166781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166781=edit
Bug 36529: manage_additional_fields permission for more than acquisitions and
serials

This patch renames the manage_additional_fields permission to remove
the specificity of acquisitions orders and serial subscriptions.
Since each additional field requires a corresponding permission, I
wrote each of them next to it. It makes it very long, but right now
there isn't really a way to link permissions other than the permission
description.

To test:
1. Apply patch
2. Go to a patron account
3. Click More > Set permissions
4. Go to the Administration panel permissions and open the
   sub-permissions
5. Check that the manage_additional_fields permission description
   makes sense, check grammar and spelling, try the various
   combinations

Signed-off-by: Pedro Amorim 
Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36529] manage_additional_fields permission for more than acquisitions and serials

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529

Lucas Gass  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251

--- Comment #45 from David Cook  ---
(In reply to Katrin Fischer from comment #43)
> (In reply to David Cook from comment #40)
> > Reviewing about.pl and noticed the missing weasyprint on an upgraded system.
> > Like often happens, it looks like it's in debian/control.in but not
> > debian/control. We need to get better at managing packaged dependencies...
> 
> I just added it the other week - did you check main?

Ah cheers. I thought that I had an up-to-date main, but it appears that I
didn't! My bad.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36529] manage_additional_fields permission for more than acquisitions and serials

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529

Lucas Gass  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |caroline.cyr-la-rose@inlibr
   |ity.org |o.com
 CC||lu...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35931] More preselected items in the renew column on details page and on checkout page

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35931

Katariina Pohto  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35771] Unselecting titles when making multi-hold does not have any effect

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771

Katariina Pohto  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35771] Unselecting titles when making multi-hold does not have any effect

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771

--- Comment #3 from Katariina Pohto  ---
Created attachment 166780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166780=edit
Bug 35771: Unselecting titles when making multi-hold does not have any effect

This patch moves the holdable_bibs id and value to the checkmark input. It
doesn't do the same for the club multihold (which probably should be added),
and doesn't change the  field which lists the
biblios that end up on the URL query.

It might also be beneficial to change the placerequest.pl's redirect to
request.pl to use the holdable_bibs list instead of the biblionumber list, so
the unselected biblio wouldn't appear on request.pl page after the holds are
placed

Test plan:
1. Select several biblios and choose Place hold
2. Choose a patron
3. Select a pickup location for all biblios and unselect one of the checkmarks
4. Place holds and note that even the deselected holds was placed.
5. Repeat steps 1-2.
6. Leave pickup locations empty and try to place the holds.
7. Note alert: "Please make sure all selected titles have a pickup location
set"
8. Uncheck one of the biblios and add pickup locations to the checked biblios.
9. Try to place the holds and note that there is no alert, and you get an error
500.
10. Apply patch.
11. Repeat steps 1,2,8 and place holds.
12. Note that there is no error 500, and while all the biblios are shown on
page, only the checked biblios have a new hold placed on them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36866] Allow parent / child relationship for Pages

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36866

Chris Rowlands  changed:

   What|Removed |Added

 CC||chris.rowlan...@nhs.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251

--- Comment #44 from David Cook  ---
But I've also just been in an extra cranky mood today and commenting at 11:47pm
doesn't help .

I'll try to add some more positive comments...

I used wkhtmltopdf for years as a CLI tool, but I've found in recent years
Webkit doesn't render many webpages very well anymore. Complex
HTML/CSS/Javascript that looks good in Chrome often wouldn't look good in the
Webkit used by wkhtmltopdf. Still... a pretty good tool overall.

Headless Chrome is great, since it's the closest to the Chrome user experience,
but... as a CLI tool it's a bit limited in terms of options. 

My overall preference these days for HTML to PDF is either Puppeteer or
Playwright. While there are bindings out there (not for Perl though I think), I
use Node.js to control them, and I have them use Chrome under the head (stored
in their node_modules directory). I've found these tools to produce the most
accurate outputs. 

However, Puppeteer, Playwright, and Chrome are probably all too heavyweight for
Koha. While I moaned about weasyprint having 500MB of dependencies, they're
mostly Python libraries and low level libraries. And they're all packaged up. 

As Kyle said... if weasyprint works fine then I wouldn't rock the boat.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35771] Unselecting titles when making multi-hold does not have any effect

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35771

Katariina Pohto  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |trai...@koha-suomi.fi
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24424] Advanced editor - interface hangs as "Loading" when given an invalid bib number

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35442] Script migration_tools/build_oai_sets.pl is missing ORDER BY

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35442

Pedro Amorim  changed:

   What|Removed |Added

 CC||pedro.amo...@ptfs-europe.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36866] Allow parent / child relationship for Pages

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36866

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisette.scheer@bywatersolut
   ||ions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36529] manage_additional_fields permission for more than acquisitions and serials

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36529

Pedro Amorim  changed:

   What|Removed |Added

 CC||pedro.amo...@ptfs-europe.co
   ||m

--- Comment #3 from Pedro Amorim  ---
I wonder if we should consider something more generic like:
"Manage additional fields for tables that support it (may require additional
specific permissions for each table)"

The above wording could be improved but my point is that I can see this falling
out of sync again in the future as new tables start adopting additional fields
and this label is forgotten.
Just my 2 cents, definitely not a blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36864] Further improvements to holds request page

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

--- Comment #9 from Martin Renvoize  ---
Nice improvement, works as designed.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36864] Further improvements to holds request page

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36864

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #166769|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 166779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166779=edit
Bug 36864: Add a font awesome icon to indicate enabled

Signed-off-by: Owen Leonard 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >