[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16033


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16033
[Bug 16033] Quotes upload preview broken for 973 days
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Blocks||11923

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11605

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

--- Comment #59 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Too big to push in 3.14.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #55 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 25936
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25936action=edit
Bug 10558 [QA Follow-up 8]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #22064|0   |1
is obsolete||
  Attachment #22065|0   |1
is obsolete||
  Attachment #22066|0   |1
is obsolete||
  Attachment #22067|0   |1
is obsolete||
  Attachment #22068|0   |1
is obsolete||
  Attachment #23993|0   |1
is obsolete||
  Attachment #23995|0   |1
is obsolete||
  Attachment #25936|0   |1
is obsolete||

--- Comment #56 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 25937
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25937action=edit
Bug 10558 [QA Follow-up]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #57 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Galen Charlton from comment #54)
 Close, but there is a serious issue left: a regression on bug 2060.
 
 In particular, this patch regresses on the ability to properly display
 authority record batches.  Instead of linking to the authority details page
 for imported records, for example, it links to the *bibliographic* details
 page.

Fixed!

 Sorting by citation for authority batches is also broken --
 GetImportRecordsRange() is asked to sort by title when it should be sorting
 by authorized_heading.

Fixed!

 By the way, it would be preferable to me if GetImportRecordsRange() did not
 rely on dbh_quote_identifier() to sanitize the sorting column, which at
 present is passed directly from a CGI parameter.  It should instead set
 $order_by to one of a known set of values, similar to how you deal with
 $order_by_direction.

Fixed!

 A much more minor issue: tools/batch_records_ajax.pl asserts that it's both
 GPL2 and GPL3+.

Fixed!

 Please squash your QA follow-ups (but not Owen's) when you resubmit.

Done! New fixes published in followup 8 for easy analysis. All followups
squashed and resubmitted as one patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #54 from Galen Charlton gmcha...@gmail.com ---
Close, but there is a serious issue left: a regression on bug 2060.

In particular, this patch regresses on the ability to properly display
authority record batches.  Instead of linking to the authority details page for
imported records, for example, it links to the *bibliographic* details page.

Sorting by citation for authority batches is also broken --
GetImportRecordsRange() is asked to sort by title when it should be sorting by
authorized_heading.

By the way, it would be preferable to me if GetImportRecordsRange() did not
rely on dbh_quote_identifier() to sanitize the sorting column, which at present
is passed directly from a CGI parameter.  It should instead set $order_by to
one of a known set of values, similar to how you deal with $order_by_direction.

A much more minor issue: tools/batch_records_ajax.pl asserts that it's both
GPL2 and GPL3+.

Please squash your QA follow-ups (but not Owen's) when you resubmit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #50 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23993
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23993action=edit
Bug 10558 [QA Follow-up 6] - Use datatables.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #51 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23994
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23994action=edit
Bug 10558 [QA Follow-up 7] - Make strings translatable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #52 from Kyle M Hall k...@bywatersolutions.com ---
Setting to Passed QA again. Regression of 10170 resolved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23994|0   |1
is obsolete||

--- Comment #53 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23995
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23995action=edit
Bug 10558 [QA Follow-up 7] - Make strings translatable

Removed trailing whitespace

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #49 from Galen Charlton gmcha...@gmail.com ---
I like the general intent of this, but this patch causes an unnecessary
regression of bug 10170.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20183|0   |1
is obsolete||

--- Comment #41 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22062
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22062action=edit
Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable

Some libraries would like to sort by columns for the records of an
import batch. This seems like a good use of ajax DataTables.

Test plan:
1) Apply this patch
2) Import a record batch into Koha
   a) Use some form of matching
   b) Have some records that will match and some that won't
   c) Have at least 30 records so you can test the pager
3) Verify the new table is functionally equivilent to the old static one

Signed-off-by: Owen Leonard oleon...@myacpl.org

Tests fine and looks good with the exception of the corrections I put in
a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20184|0   |1
is obsolete||

--- Comment #42 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22063
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22063action=edit
Bug 10558 [Follow-up] Convert records table in manage-marc-import.pl to ajax
DataTable

This patch makes improvements to the default DataTables CSS and corrects
a couple of errors in the original patch. CSS for the full numbers
type pagination, used by this and the quotes editor, has been cleaned up
and made more visually consistent with the brief pagination style.

Also changed:

- removed some hard-coded paths containing http://staff.kohadev...;
- Added a column header to the column showing record match details. This
  provides both information and a clearer target for clicking to resort
- Expanding the default table pager controls for this page and the
  quotes editor (for consistency)
- Correction to quotes.css to fix pager display problem on wide screens

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20328|0   |1
is obsolete||

--- Comment #44 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22065
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22065action=edit
Bug 10558 [QA Follow-up 2] - Fix JavaScript Error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20185|0   |1
is obsolete||

--- Comment #43 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22064
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22064action=edit
Bug 10558 [QA Follow-up] Convert records table in manage-marc-import.pl to ajax
DataTable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20345|0   |1
is obsolete||

--- Comment #45 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22066
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22066action=edit
Bug 10558 [QA Follow-up 3] - Change GPL version number and add POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #20395|0   |1
is obsolete||

--- Comment #46 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22067
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22067action=edit
Bug 10558 [QA Follow-up 4] - switch $.getJSON to $.ajax

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #47 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22068
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22068action=edit
Bug 10558 [QA Follow-up 5] - Add Tamil copyrightwq

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #48 from Kyle M Hall k...@bywatersolutions.com ---
Setting to Passed QA under the assumption that this was the only QA issue left.
If it is not, then I am wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 CC||d...@randomnotes.org

--- Comment #38 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
*** Bug 11065 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #39 from Doug Kingston d...@randomnotes.org ---
This bug is now blocking a simpler fix (bug 11065) which will work and has no
licensing issues.  Lets get this one cleared to push or park it in favor of a
simpler but less flexibe fix. This was a high priority issue coming out of the
Cataloging roundtable at KohaCon13.  What precisely do we need to do to clear
this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #40 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Katrin Fischer from comment #37)
 (In reply to Jonathan Druart from comment #36)
  ping Kyle, we are close to finish!
  Is a rebased code from Tamil or the first patch contains a bad c/p of the
  license?
 
 Kyle, we need your feedback on this! :)

The file in question is based on a file Tamil wrote that I copied and then
completely re-wrote. However, if someone wants to add a followup to add a
copyright for Tamil to my the new file, I would be fine with that.

Kyle

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #37 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
(In reply to Jonathan Druart from comment #36)
 ping Kyle, we are close to finish!
 Is a rebased code from Tamil or the first patch contains a bad c/p of the
 license?

Kyle, we need your feedback on this! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #36 from Jonathan Druart jonathan.dru...@biblibre.com ---
ping Kyle, we are close to finish!
Is a rebased code from Tamil or the first patch contains a bad c/p of the
license?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Kyle M Hall from comment #30)
 Is this followup 3 what you are looking for? I examined the network access
 of the page and did find two calls to batch_records_ajax.pl, but the first
 was a 302 redirect that did not send any content, with the second one being
 a 200 that does send content.

The 2 calls get the records and return a JSON content.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com ---
Using $.ajax instead of $.getJSON (2 GET), there is only one call (1 POST) to
the ajax script:

-  $.getJSON( sSource, aoData, function (json) {
-  fnCallback(json)
-  } );
+  $.ajax({
+  'dataType': 'json',
+  'type': 'POST',
+  'url': sSource,
+  'data': aoData,
+  'success': function(json){
+  fnCallback(json);
+  }
+  });

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #33 from Kyle M Hall k...@bywatersolutions.com ---
Thanks Jonathan! I'll implement this change and add another followup shortly.

(In reply to Jonathan Druart from comment #32)
 Using $.ajax instead of $.getJSON (2 GET), there is only one call (1 POST)
 to the ajax script:
 
 -  $.getJSON( sSource, aoData, function (json) {
 -  fnCallback(json)
 -  } );
 +  $.ajax({
 +  'dataType': 'json',
 +  'type': 'POST',
 +  'url': sSource,
 +  'data': aoData,
 +  'success': function(json){
 +  fnCallback(json);
 +  }
 +  });

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #34 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20395
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20395action=edit
Bug 10558 [QA Follow-up 4] - switch $.getJSON to $.ajax

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #35 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 20345
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20345
Bug 10558 [QA Follow-up 3] - Change GPL version number and add POD

Review of attachment 20345:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10558attachment=20345)
-

::: tools/batch_records_ajax.pl
@@ +2,4 @@
  
  # This software is placed under the gnu General Public License, v2 
 (http://www.gnu.org/licenses/gpl.html)
  
 +# Copyright 2013 ByWater Solutions

Does the original code is from Tamil or is it a wrong copy/paste?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com ---
Kyle, the js error still occurred.

To reproduce:
- open firebug on the console tab
- go to tools/tools-home.pl
- click on the Staged MARC record management link

caused by tools/manage-marc-import.tt l. 49:
  aoData.push( { name: import_batch_id, value: [% import_batch_id %] } );

The import_batch_id var is not defined on this view.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #27 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20328
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20328action=edit
Bug 10558 [QA Follow-up 2] - Fix JavaScript Error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:

1/ There is no pod in the new file (yes I know, I am not the best person to
make this remark...).

2/ The license version should be replaced with the GPLv3.

3/ I don't know why but the ajax script is called twice! (maybe can you have a
look at my patch for bug 9811 where I use a script to populate a table with the
server side processing method).

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #29 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20345
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20345action=edit
Bug 10558 [QA Follow-up 3] - Change GPL version number and add POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #30 from Kyle M Hall k...@bywatersolutions.com ---
Is this followup 3 what you are looking for? I examined the network access of
the page and did find two calls to batch_records_ajax.pl, but the first was a
302 redirect that did not send any content, with the second one being a 200
that does send content.

(In reply to Jonathan Druart from comment #28)
 QA comment:
 
 1/ There is no pod in the new file (yes I know, I am not the best person to
 make this remark...).
 
 2/ The license version should be replaced with the GPLv3.
 
 3/ I don't know why but the ajax script is called twice! (maybe can you have
 a look at my patch for bug 9811 where I use a script to populate a table
 with the server side processing method).
 
 Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19692|0   |1
is obsolete||

--- Comment #25 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20185
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20185action=edit
Bug 10558 [QA Follow-up] Convert records table in manage-marc-import.pl to ajax
DataTable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19682|0   |1
is obsolete||

--- Comment #24 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20184
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20184action=edit
Bug 10558 [Follow-up] Convert records table in manage-marc-import.pl to ajax
DataTable

This patch makes improvements to the default DataTables CSS and corrects
a couple of errors in the original patch. CSS for the full numbers
type pagination, used by this and the quotes editor, has been cleaned up
and made more visually consistent with the brief pagination style.

Also changed:

- removed some hard-coded paths containing http://staff.kohadev...;
- Added a column header to the column showing record match details. This
  provides both information and a clearer target for clicking to resort
- Expanding the default table pager controls for this page and the
  quotes editor (for consistency)
- Correction to quotes.css to fix pager display problem on wide screens

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19674|0   |1
is obsolete||

--- Comment #23 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20183
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20183action=edit
Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable

Some libraries would like to sort by columns for the records of an
import batch. This seems like a good use of ajax DataTables.

Test plan:
1) Apply this patch
2) Import a record batch into Koha
   a) Use some form of matching
   b) Have some records that will match and some that won't
   c) Have at least 30 records so you can test the pager
3) Verify the new table is functionally equivilent to the old static one

Signed-off-by: Owen Leonard oleon...@myacpl.org

Tests fine and looks good with the exception of the corrections I put in
a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:

1/ On tools/manage-marc-import.pl, I got a JS error: 
  aoData.push( { name: import_batch_id, value:  } );
The table should not be displayed if there is no import_batch_id parameter.

2/ I got another JS error clicking on the title
  SyntaxError: syntax error: void()
Prefer a href=#

3/ The DT aLengthMenu parameter should contain an All entry (git grep
aLengthMenu.*All)

4/ Why do you comment lines in tools/manage-marc-import.pl instead of deleting
them?

5/ Why do you add a show_marc JS function instead of using the classic way
(link to showmarc.pl)?

6/ Permissions: manage-marc-import.pl needs the tools=manage_staged_marc
permission and the ajax script needs editcatalogue. Don't you think we should
have the same one in both?

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #17 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19692
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19692action=edit
Bug 10558 [QA Follow-up] Convert records table in manage-marc-import.pl to ajax
DataTable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #18 from Kyle M Hall k...@bywatersolutions.com ---
 1/ On tools/manage-marc-import.pl, I got a JS error: 
   aoData.push( { name: import_batch_id, value:  } );
 The table should not be displayed if there is no import_batch_id parameter.

Fixed!

 2/ I got another JS error clicking on the title
   SyntaxError: syntax error: void()
 Prefer a href=#

By bad, the call is supposed to be void(0). This appears to be the preferred
practice these days. The problem with href=# is that it causes the page to
jump back to the top when clicked. This isn't a problem when the page does not
scroll vertically, but in this case it often will.

 3/ The DT aLengthMenu parameter should contain an All entry (git grep
 aLengthMenu.*All)

Fixed!

 4/ Why do you comment lines in tools/manage-marc-import.pl instead of
 deleting them?

Fixed!

 5/ Why do you add a show_marc JS function instead of using the classic way
 (link to showmarc.pl)?

The classic way uses greybox, which isn't compatible with DataTables built
from an ajax source. On the plus side, I'm using jQuery UI instead, and if we
switched all of them to jQuery UI, we could drop greybox as a dependency.

 6/ Permissions: manage-marc-import.pl needs the tools=manage_staged_marc
 permission and the ajax script needs editcatalogue. Don't you think we
 should have the same one in both?

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #19 from Owen Leonard oleon...@myacpl.org ---
(In reply to Kyle M Hall from comment #18)
  5/ Why do you add a show_marc JS function instead of using the classic way
  (link to showmarc.pl)?
 
 The classic way uses greybox, which isn't compatible with DataTables built
 from an ajax source. On the plus side, I'm using jQuery UI instead, and if
 we switched all of them to jQuery UI, we could drop greybox as a dependency.

...which is something I would like to be able to do if we could (See Bug 8290).
I find that in this case the jQueryUI dialog works well. In other cases I have
found that it isn't as easy to implement as Greybox, hence the lack of progress
on that bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #20 from Owen Leonard oleon...@myacpl.org ---
(In reply to Kyle M Hall from comment #18)
 My bad, the call is supposed to be void(0). This appears to be the preferred
 practice these days. The problem with href=#

No, using javascript: is not the preferred practice. More frequently you'll
see return false added to the onclick (at least in cases where return false
is what you want).

The ideal way to handle something like this is to design the inserted markup so
that the click event can be moved into the main JavaScript block (even better,
into a separate JavaScript file). Then the outcome of the click event can be
handled by something like this:

http://css-tricks.com/return-false-and-prevent-default/

This isn't an issue that should block QA, but is something to think about next
time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Kyle M Hall from comment #18)
  1/ On tools/manage-marc-import.pl, I got a JS error: 
aoData.push( { name: import_batch_id, value:  } );
  The table should not be displayed if there is no import_batch_id parameter.
 
 Fixed!

Still got the JS error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19526|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19674
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19674action=edit
Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable

Some libraries would like to sort by columns for the records of an
import batch. This seems like a good use of ajax DataTables.

Test plan:
1) Apply this patch
2) Import a record batch into Koha
   a) Use some form of matching
   b) Have some records that will match and some that won't
   c) Have at least 30 records so you can test the pager
3) Verify the new table is functionally equivilent to the old static one

Signed-off-by: Owen Leonard oleon...@myacpl.org

Tests fine and looks good with the exception of the corrections I put in
a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19525|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19675
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19675action=edit
Bug 10558 [Follow-up] Convert records table in manage-marc-import.pl to ajax
DataTable

This patch makes improvements to the default DataTables CSS and corrects
a couple of errors in the original patch. CSS for the full numbers
type pagination, used by this and the quotes editor, has been cleaned up
and made more visually consistent with the brief pagination style.

Also changed:

- removed some hard-coded paths containing http://staff.kohadev...;
- Added a column header to the column showing record match details. This
  provides both information and a clearer target for clicking to resort
- Expanding the default table pager controls for this page and the
  quotes editor (for consistency)

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
I can replicate Jonathan's issue. Owen, do you think you can take a look at
that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #19675|0   |1
is obsolete||

--- Comment #13 from Owen Leonard oleon...@myacpl.org ---
Created attachment 19681
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19681action=edit
Bug 10558 [Follow-up] Convert records table in manage-marc-import.pl to ajax
DataTable

This patch makes improvements to the default DataTables CSS and corrects
a couple of errors in the original patch. CSS for the full numbers
type pagination, used by this and the quotes editor, has been cleaned up
and made more visually consistent with the brief pagination style.

Also changed:

- removed some hard-coded paths containing http://staff.kohadev...;
- Added a column header to the column showing record match details. This
  provides both information and a clearer target for clicking to resort
- Expanding the default table pager controls for this page and the
  quotes editor (for consistency)
- Correction to quotes.css to fix pager display problem on wide screens

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
Owen, the quote of the day table looks good in FireFox, but still looks like
Jonathan's screen cap in Chrome.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19681|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19682
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19682action=edit
Bug 10558 [Follow-up] Convert records table in manage-marc-import.pl to ajax
DataTable

This patch makes improvements to the default DataTables CSS and corrects
a couple of errors in the original patch. CSS for the full numbers
type pagination, used by this and the quotes editor, has been cleaned up
and made more visually consistent with the brief pagination style.

Also changed:

- removed some hard-coded paths containing http://staff.kohadev...;
- Added a column header to the column showing record match details. This
  provides both information and a clearer target for clicking to resort
- Expanding the default table pager controls for this page and the
  quotes editor (for consistency)
- Correction to quotes.css to fix pager display problem on wide screens

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 19547
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19547action=edit
Ergonomic issue on wide screen

Hi Owen and Kyle,

I got an ergonomic issue on my wide screen. Except that, sounds good :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19507|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19515
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19515action=edit
Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable

Some libraries would like to sort by columns for the records of an
import batch. This seems like a good use of ajax DataTables.

Test plan:
1) Apply this patch
2) Import a record batch into Koha
   a) Use some form of matching
   b) Have some records that will match and some that won't
   c) Have at least 30 records so you can test the pager
3) Verify the new table is functionally equivilent to the old static one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19515|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19516
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19516action=edit
Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable

Some libraries would like to sort by columns for the records of an
import batch. This seems like a good use of ajax DataTables.

Test plan:
1) Apply this patch
2) Import a record batch into Koha
   a) Use some form of matching
   b) Have some records that will match and some that won't
   c) Have at least 30 records so you can test the pager
3) Verify the new table is functionally equivilent to the old static one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19516|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19517
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19517action=edit
Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable

Some libraries would like to sort by columns for the records of an
import batch. This seems like a good use of ajax DataTables.

Test plan:
1) Apply this patch
2) Import a record batch into Koha
   a) Use some form of matching
   b) Have some records that will match and some that won't
   c) Have at least 30 records so you can test the pager
3) Verify the new table is functionally equivilent to the old static one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19517|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19520
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19520action=edit
Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable

Some libraries would like to sort by columns for the records of an
import batch. This seems like a good use of ajax DataTables.

Test plan:
1) Apply this patch
2) Import a record batch into Koha
   a) Use some form of matching
   b) Have some records that will match and some that won't
   c) Have at least 30 records so you can test the pager
3) Verify the new table is functionally equivilent to the old static one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #7 from Owen Leonard oleon...@myacpl.org ---
Created attachment 19525
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19525action=edit
Bug 10558 [Follow-up] Convert records table in manage-marc-import.pl to ajax
DataTable

This patch makes improvements to the default DataTables CSS and corrects
a couple of errors in the original patch. CSS for the full numbers
type pagination, used by this and the quotes editor, has been cleaned up
and made more visually consistent with the brief pagination style.

Also changed:

- removed some hard-coded paths containing http://staff.kohadev...;
- Added a column header to the column showing record match details. This
  provides both information and a clearer target for clicking to resort
- Expanding the default table pager controls for this page and the
  quotes editor (for consistency)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #19520|0   |1
is obsolete||

--- Comment #8 from Owen Leonard oleon...@myacpl.org ---
Created attachment 19526
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19526action=edit
[SIGNED-OFF] Bug 10558 - Convert records table in manage-marc-import.pl to ajax
DataTable

Some libraries would like to sort by columns for the records of an
import batch. This seems like a good use of ajax DataTables.

Test plan:
1) Apply this patch
2) Import a record batch into Koha
   a) Use some form of matching
   b) Have some records that will match and some that won't
   c) Have at least 30 records so you can test the pager
3) Verify the new table is functionally equivilent to the old static one

Signed-off-by: Owen Leonard oleon...@myacpl.org

Tests fine and looks good with the exception of the corrections I put in
a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19506
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19506action=edit
WIP - Bug 10558 - Convert records table in manage-marc-import.pl to ajax
DataTable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19506|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 19507
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19507action=edit
WIP - Bug 10558 - Convert records table in manage-marc-import.pl to ajax
DataTable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/