[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Didier Gautheron  changed:

   What|Removed |Added

 Blocks||27240


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27240
[Bug 27240] Export basket: remove spaces and don't export links
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the||This adds the internal
  release notes||note, vendor note, order
   ||number and ISBN to the late
   ||orders table. The notes are
   ||editable directly from the
   ||table using a modal dialog.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Joy Nelson  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

--- Comment #53 from Joy Nelson  ---
Enhancement not backported to 19.11.x branch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #52 from Joy Nelson  ---
Enhancement not backported to 19.11.x branch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #51 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||20.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #95440|0   |1
is obsolete||

--- Comment #48 from Katrin Fischer  ---
Created attachment 97429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97429=edit
Bug 12502: (QA follow-up) Remove the Save button

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #95439|0   |1
is obsolete||

--- Comment #47 from Katrin Fischer  ---
Created attachment 97428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97428=edit
Bug 12502: (follow-up) Use modal to add/edit order notes

Replace inputs to edit notes by a link opening a modal, similar
to the basket summary page. This makes it possible for the notes
to appear in the datatable exports.

Also fix exporting with the export as csv button at the bottom
of the page to export notes.

Test plan :
1) In the late orders table (acqui/lateorders.pl), a link should
appear in both the internal and vendor note column, following the
current value if it exist.
-> This link should read "Add ..." if there is no existing note
or "Edit ..." if there is.
2) Click on the link. A modal should appear. Confirm that saving a
note works as expected.
3) Try exporting to any format using either the button at the top
of the table or the one at the bottom of the page.
-> The three new columns and their values should appear in the
export.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #95441|0   |1
is obsolete||

--- Comment #49 from Katrin Fischer  ---
Created attachment 97430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97430=edit
Bug 12502: (follow-up) Adds formatting for datatables export

Add a format option to the datatables export that remove .noExport
elements present in a data cell, just as .noExport columns are
not exported.

To test:
1. For late orders (which uses .noExport elements in data cells) :
Export data in any format using the export button at the top
of the datatable.
=> data should exclude "Add/Edit note" label, but
otherwise look the same as before the patch.
2. Try exporting data in other datatables in Koha and make sure
exported data is the same before and after applying the patch.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #50 from Katrin Fischer  ---
Thx a lot for your patience with this one - I feel it works really nicely now!

Also passes prove t/db_dependent/Acquisition.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #95438|0   |1
is obsolete||

--- Comment #46 from Katrin Fischer  ---
Created attachment 97427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97427=edit
Bug 12502: Add vendor note, internal note, ordernumber and isbn to late orders
page

Test plan:

0) Make sure you have a late order
a) Create a test vendor unless you have one
b) Create a test basket unless you have one
c) Close the basket to mark the order as late
1) Go to the late orders table
Before patch : Orderno, ISBN, vendor notes, internal notes are absent
After patch: fields are present

2) Edit the vendor note and/or the internal note
3) Press the save notes button
4) Refresh page and cache (CTRL+F5), if notes have been correctly saved, your
modifications should be displayed.

Signed-off-by: Alex Buckley 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||24161


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
[Bug 24161] Late orders improvements - keeping track of claims
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=24162

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Séverine Queune  changed:

   What|Removed |Added

  Attachment #87236|0   |1
is obsolete||

--- Comment #41 from Séverine Queune  ---
Created attachment 95438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95438=edit
Bug 12502: Add vendor note, internal note, ordernumber and isbn to late orders
page

Test plan:

0) Make sure you have a late order
a) Create a test vendor unless you have one
b) Create a test basket unless you have one
c) Close the basket to mark the order as late
1) Go to the late orders table
Before patch : Orderno, ISBN, vendor notes, internal notes are absent
After patch: fields are present

2) Edit the vendor note and/or the internal note
3) Press the save notes button
4) Refresh page and cache (CTRL+F5), if notes have been correctly saved, your
modifications should be displayed.

Signed-off-by: Alex Buckley 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #38 from Maryse Simard  ---
Created attachment 95418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95418=edit
Bug 12502: (QA follow-up) Remove the Save button

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Maryse Simard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #40 from Maryse Simard  ---
Thank you for testing and for your comment.

I would say the different behaviors for the export buttons is expected since
the button as the top is a part of the datatables plugin and uses it's filters
to determine which row to export and the button at the bottom is part of Koha
and uses the checkboxes to filter rows to export. I agree this behavior might
be questionable, but I believe it is not in the scope of this bug which is
about order notes.

I did forget to remove the "Save notes" button, thank you for the catch.

I've also added a patch to remove the "Add/Edit note" label. It adds a new
formatting option to the datatables to accept the use of the .noExport class on
data cell elements to remove them from exported data.

It is now ready to be tested again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #39 from Maryse Simard  ---
Created attachment 95419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95419=edit
Bug 12502: (follow-up) Adds formatting for datatables export

Add a format option to the datatables export that remove .noExport
elements present in a data cell, just as .noExport columns are
not exported.

To test:
1. For late orders (which uses .noExport elements in data cells) :
Export data in any format using the export button at the top
of the datatable.
=> data should exclude "Add/Edit note" label, but
otherwise look the same as before the patch.
2. Try exporting data in other datatables in Koha and make sure
exported data is the same before and after applying the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Séverine Queune  changed:

   What|Removed |Added

  Attachment #95419|0   |1
is obsolete||

--- Comment #44 from Séverine Queune  ---
Created attachment 95441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95441=edit
Bug 12502: (follow-up) Adds formatting for datatables export

Add a format option to the datatables export that remove .noExport
elements present in a data cell, just as .noExport columns are
not exported.

To test:
1. For late orders (which uses .noExport elements in data cells) :
Export data in any format using the export button at the top
of the datatable.
=> data should exclude "Add/Edit note" label, but
otherwise look the same as before the patch.
2. Try exporting data in other datatables in Koha and make sure
exported data is the same before and after applying the patch.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Séverine Queune  changed:

   What|Removed |Added

  Attachment #91564|0   |1
is obsolete||

--- Comment #42 from Séverine Queune  ---
Created attachment 95439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95439=edit
Bug 12502: (follow-up) Use modal to add/edit order notes

Replace inputs to edit notes by a link opening a modal, similar
to the basket summary page. This makes it possible for the notes
to appear in the datatable exports.

Also fix exporting with the export as csv button at the bottom
of the page to export notes.

Test plan :
1) In the late orders table (acqui/lateorders.pl), a link should
appear in both the internal and vendor note column, following the
current value if it exist.
-> This link should read "Add ..." if there is no existing note
or "Edit ..." if there is.
2) Click on the link. A modal should appear. Confirm that saving a
note works as expected.
3) Try exporting to any format using either the button at the top
of the table or the one at the bottom of the page.
-> The three new columns and their values should appear in the
export.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Séverine Queune  changed:

   What|Removed |Added

  Attachment #95418|0   |1
is obsolete||

--- Comment #43 from Séverine Queune  ---
Created attachment 95440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95440=edit
Bug 12502: (QA follow-up) Remove the Save button

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #45 from Séverine Queune  ---
Thank you Maryse ! 
The new version is ok for me :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #37 from Séverine Queune  ---
I have some questions.

If I use the Export option at the top of the table, only the displayed datas
are exported (hide columns / perform a search). If I use the Export option at
the bottom, all datas for the selected orders are exported even the hidden
ones. Is that the expected behaviour ?

The "Save notes" button now seems useless as datas are automatically saved
using the modal, can you confirm ?

I agree with Pierre-Marc : the label of "Add / Edit note" should not be
exported.
I will open a new ticket to fix it on the basket export because it adds work
for the staff working on acquisition to suppress these informations before
sending the file to the vendor. Will you agree to suppress it in the present
patch ?

Except these points, patch works fine !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Maryse Simard  changed:

   What|Removed |Added

 CC||maryse.sim...@inlibro.com
 Status|Failed QA   |Needs Signoff

--- Comment #36 from Maryse Simard  ---
Used links + modal for editing the notes and fixed the exports.

However, as Pierre-Marc mentioned, when exporting, the labels for the links do
appear in the data ("Add internal note", ...). I feel that this is not optimal,
but since the same behavior is present in the basket page as well, I left it as
is.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #35 from Maryse Simard  ---
Created attachment 91564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91564=edit
Bug 12502: (follow-up) Use modal to add/edit order notes

Replace inputs to edit notes by a link opening a modal, similar
to the basket summary page. This makes it possible for the notes
to appear in the datatable exports.

Also fix exporting with the export as csv button at the bottom
of the page to export notes.

Test plan :
1) In the late orders table (acqui/lateorders.pl), a link should
appear in both the internal and vendor note column, following the
current value if it exist.
-> This link should read "Add ..." if there is no existing note
or "Edit ..." if there is.
2) Click on the link. A modal should appear. Confirm that saving a
note works as expected.
3) Try exporting to any format using either the button at the top
of the table or the one at the bottom of the page.
-> The three new columns and their values should appear in the
export.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #34 from Séverine Queune  ---
(In reply to Katrin Fischer from comment #29)
> Next time as a separate follow-up patch please! ;)
> 
> Looking at this again I have some issues, I am sorry to come up with this a
> little lately :(
> 
> 1) Usability
> There is visual indicator to tell apart an already stored from a
> changed/unsafed note. It's really easy to forget to press the button. 
> 
> If you happen to end your note with pressing "Enter" you trigger the error
> message "No order selected"
> 
> It really doen't work well for notes that are longer than the input field
> is. They don't display in full and it's hard to move around in the input
> field.
> 
> I think I'd like this much better following the existing design pattern with
> links and a modal (see basket summary). I am adding Owen in hope he has time
> to take a look.
> 
> 2) Search
> Searching on the notes column doesn't work.
> 
> 3) Export
> The notes are not exported, neither using the "Export as CSV" nor the new
> "Excel" export at the bottom of the table.

Sorry Pierre-Marc, all the issues Katrin noticed on comment 29 are still
present.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #33 from Pierre-Marc Thibault  ---
Patch rebased. I am still waiting for advises before continuing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Pierre-Marc Thibault  changed:

   What|Removed |Added

  Attachment #80602|0   |1
is obsolete||

--- Comment #32 from Pierre-Marc Thibault  ---
Created attachment 87236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87236=edit
Bug 12502: Add vendor note, internal note, ordernumber and isbn to late orders
page

Test plan:

0) Make sure you have a late order
a) Create a test vendor unless you have one
b) Create a test basket unless you have one
c) Close the basket to mark the order as late
1) Go to the late orders table
Before patch : Orderno, ISBN, vendor notes, internal notes are absent
After patch: fields are present

2) Edit the vendor note and/or the internal note
3) Press the save notes button
4) Refresh page and cache (CTRL+F5), if notes have been correctly saved, your
modifications should be displayed.

Signed-off-by: Alex Buckley 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Janet McGowan  changed:

   What|Removed |Added

 CC||janet.mcgowan@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Pierre-Marc Thibault  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Pierre-Marc Thibault  changed:

   What|Removed |Added

 CC||pierre-marc.thibault@inlibr
   ||o.com

--- Comment #31 from Pierre-Marc Thibault  ---
I quickly tried the solution of Owen. I'm in a state where CSV works, but only
the one from the top, I guess I should do something else to make it work.

I tried to add the modal and the links, the result looks fine, but there is
something I would like to ask about it. Should the description comes along with
the icon? When I add an icon to add or edit a note with the description (i.e.
Edit internal note), the description is exported as well. If the description is
not here, it's well exported. Since I don't find how to hide only the
description and am not even sure if it should be there in the first place, I
ask if the link's description should be added too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Koha Team Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #30 from Owen Leonard  ---
(In reply to Katrin Fischer from comment #29)

> 2) Search
> Searching on the notes column doesn't work.
> 
> 3) Export
> The notes are not exported, neither using the "Export as CSV" nor the new
> "Excel" export at the bottom of the table.

I think using the link + modal model from acqui/basket.pl would work well here.
I think it would solve both of these problems, each caused by the fact that the
table cell contains an input field instead of text.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||oleon...@myacpl.org

--- Comment #29 from Katrin Fischer  ---
Next time as a separate follow-up patch please! ;)

Looking at this again I have some issues, I am sorry to come up with this a
little lately :(

1) Usability
There is visual indicator to tell apart an already stored from a
changed/unsafed note. It's really easy to forget to press the button. 

If you happen to end your note with pressing "Enter" you trigger the error
message "No order selected"

It really doen't work well for notes that are longer than the input field is.
They don't display in full and it's hard to move around in the input field.

I think I'd like this much better following the existing design pattern with
links and a modal (see basket summary). I am adding Owen in hope he has time to
take a look.

2) Search
Searching on the notes column doesn't work.

3) Export
The notes are not exported, neither using the "Export as CSV" nor the new
"Excel" export at the bottom of the table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Blou  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Blou  changed:

   What|Removed |Added

  Attachment #80160|0   |1
is obsolete||

--- Comment #28 from Blou  ---
Created attachment 80602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80602=edit
Bug 12502: Add vendor note, internal note, ordernumber and isbn to late orders
page

Test plan:

0) Make sure you have a late order
a) Create a test vendor unless you have one
b) Create a test basket unless you have one
c) Close the basket to mark the order as late
1) Go to the late orders table
Before patch : Orderno, ISBN, vendor notes, internal notes are absent
After patch: fields are present

2) Edit the vendor note and/or the internal note
3) Press the save notes button
4) Refresh page and cache (CTRL+F5), if notes have been correctly saved, your
modifications should be displayed.

Signed-off-by: Alex Buckley 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #27 from Katrin Fischer  ---
You are not using the right repository (we moved a lot of them), last change
was only 3 weeks ago, see the link above and here:
https://gitlab.com/koha-community/qa-test-tools/commits/master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #26 from Blou  ---
My last commit:
Jonathan Druart : Make sure commit messages are correctly formatted (6 months
ago)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|

--- Comment #25 from Katrin Fischer  ---
Hi Blou,
that's trange. What's the latest commit you have? Did you move to the new
repository?
https://gitlab.com/koha-community/qa-test-tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #24 from Blou  ---
Hi Katrin, 
are you talking about koha-qa.pl ?  I seem to have the latest version, and am
not getting those messages.  Any parameter I'm missing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #23 from Katrin Fischer  ---
Can you please fix the issues pointed out by the QA script? I could fix the
filtes, but not sure about the first:

 FAIL   acqui/lateorders.pl
   FAIL   critic
# Variables::ProhibitUnusedVariables: Got 1 violation(s). 

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
   FAIL   filters
missing_filter at line 84 ([%
lateorder.ordernumber %])
missing_filter at line 143 ()
missing_filter at line 144 ([% lateorder.isbn
%])
missing_filter at line 142 ()
missing_filter at line 269 (   
$("#savenotes").after("
"+_("Loading")+"");)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Séverine Queune  changed:

   What|Removed |Added

  Attachment #79231|0   |1
is obsolete||

--- Comment #22 from Séverine Queune  ---
Created attachment 80160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80160=edit
Bug 12502: Add vendor note, internal note, ordernumber and isbn to late orders
page

Test plan:

0) Make sure you have a late order
a) Create a test vendor unless you have one
b) Create a test basket unless you have one
c) Close the basket to mark the order as late
1) Go to the late orders table
Before patch : Orderno, ISBN, vendor notes, internal notes are absent
After patch: fields are present

2) Edit the vendor note and/or the internal note
3) Press the save notes button
4) Refresh page and cache (CTRL+F5), if notes have been correctly saved, your
modifications should be displayed.

Signed-off-by: Alex Buckley 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Blou  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #21 from Blou  ---
Request and you shall receive.

Ran qa-test on it, fixed issues, squashed, but did not test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Blou  changed:

   What|Removed |Added

  Attachment #73501|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Blou  changed:

   What|Removed |Added

  Attachment #73503|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Blou  changed:

   What|Removed |Added

  Attachment #73502|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #20 from Blou  ---
Created attachment 79231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79231=edit
Bug 12502: Add vendor note, internal note, ordernumber and isbn to late orders
page

Test plan:

0) Make sure you have a late order
a) Create a test vendor unless you have one
b) Create a test basket unless you have one
c) Close the basket to mark the order as late
1) Go to the late orders table
Before patch : Orderno, ISBN, vendor notes, internal notes are absent
After patch: fields are present

2) Edit the vendor note and/or the internal note
3) Press the save notes button
4) Refresh page and cache (CTRL+F5), if notes have been correctly saved, your
modifications should be displayed.

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #19 from Katrin Fischer  ---
It would be great if this could be rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Charles Farmer  changed:

   What|Removed |Added

  Attachment #73500|0   |1
is obsolete||

--- Comment #17 from Charles Farmer  ---
Created attachment 73502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73502=edit
Bug 12502 - Add ordernumber and ISBN to late order

Adds ordernumber as 2nd column and ISBN as last

Followed test plan and patch worked as described. Also ran QA test tools
and all modified files passed

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Charles Farmer  changed:

   What|Removed |Added

  Attachment #72170|0   |1
is obsolete||

--- Comment #18 from Charles Farmer  ---
Created attachment 73503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73503=edit
Bug 12502: QA Follow-up

1) The method under C4 was deleted.

There wasn't any reason for a method under Koha, in the end, because it's a
simple update that requires no additional processing. If I had to do any
legwork with the data before updating the Order fields, I would've written a
wrapper. As it stands right now, the work can be done directly in the
controller without polluting the Koha/Acquisition/Orders.pm class.

2) Added the ISBN field to csv_header, and added that value to
lateorders-export

I've also changed the string internaldate to internalnote, small typo fix.

3) Made adjustements client-side and server-side.

In the browser, you can now see a small loading icon to inform the user that
the 'Save note' button actually triggered an action. A new alert message also
informs the user if something awry happened while updating the orders' notes. I
took a look at the user page, to see how notes were saved, but I was not
satisfied with the idea of mixing an Ajax call with a window.location.reload;
doesn't make sense in my mind to uselessly reload the page if the information
had already reached the
server, and since it was already coded that way, I felt like this change was
the best course of action.

Server-side, it is now possible to save an empty field. Before this patch,
'if($note)' would actually fail on an empty string, which meant you could never
erase a note, for any reason whatsoever.

After testing this patch, if the width of the input is still something that
you'd like to see changed, I'll have no problem reducing it a little, but
you'll have to tell me how large is _too_ large :)

4) Order no. -> Order line

5) Added the new columns to the admin/visibility yaml

6) It would be possible to also display an ISSN, but I won't make this patch
any large than it is for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Charles Farmer  changed:

   What|Removed |Added

  Attachment #73499|0   |1
is obsolete||

--- Comment #16 from Charles Farmer  ---
Created attachment 73501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73501=edit
Bug 12502 - Add vendor and internal note to late orders page

Followed test plan and patch worked as described. Also ran QA test tools
and all modified files passed.

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Charles Farmer  changed:

   What|Removed |Added

  Attachment #72169|0   |1
is obsolete||

--- Comment #15 from Charles Farmer  ---
Created attachment 73500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73500=edit
Bug 12502 - Add ordernumber and ISBN to late order

Adds ordernumber as 2nd column and ISBN as last

Followed test plan and patch worked as described. Also ran QA test tools
and all modified files passed

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Charles Farmer  changed:

   What|Removed |Added

  Attachment #72168|0   |1
is obsolete||

--- Comment #14 from Charles Farmer  ---
Created attachment 73499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73499=edit
Bug 12502 - Add vendor and internal note to late orders page

Followed test plan and patch worked as described. Also ran QA test tools
and all modified files passed.

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #13 from Séverine Queune  ---

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12502 - Add vendor and internal note to late orders page
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt
Failed to merge in the changes.
Patch failed at 0001 Bug 12502 - Add vendor and internal note to late orders
page
The copy of the patch that failed is found in:
   /var/repositories/koha/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-12502---Add-vendor-and-internal-note-to-late-o-KaZRtc.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Charles Farmer  changed:

   What|Removed |Added

  Attachment #67586|0   |1
is obsolete||

--- Comment #10 from Charles Farmer  ---
Created attachment 72168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72168=edit
Bug 12502 - Add vendor and internal note to late orders page

Followed test plan and patch worked as described. Also ran QA test tools
and all modified files passed.

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #12 from Charles Farmer  ---
Created attachment 72170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72170=edit
Bug 12502: QA Follow-up

1) The method under C4 was deleted.

There wasn't any reason for a method under Koha, in the end, because it's a
simple update that requires no additional processing. If I had to do any
legwork with the data before updating the Order fields, I would've written a
wrapper. As it stands right now, the work can be done directly in the
controller without polluting the Koha/Acquisition/Orders.pm class.

2) Added the ISBN field to csv_header, and added that value to
lateorders-export

I've also changed the string internaldate to internalnote, small typo fix.

3) Made adjustements client-side and server-side.

In the browser, you can now see a small loading icon to inform the user that
the 'Save note' button actually triggered an action. A new alert message also
informs the user if something awry happened while updating the orders' notes. I
took a look at the user page, to see how notes were saved, but I was not
satisfied with the idea of mixing an Ajax call with a window.location.reload;
doesn't make sense in my mind to uselessly reload the page if the information
had already reached the
server, and since it was already coded that way, I felt like this change was
the best course of action.

Server-side, it is now possible to save an empty field. Before this patch,
'if($note)' would actually fail on an empty string, which meant you could never
erase a note, for any reason whatsoever.

After testing this patch, if the width of the input is still something that
you'd like to see changed, I'll have no problem reducing it a little, but
you'll have to tell me how large is _too_ large :)

4) Order no. -> Order line

5) Added the new columns to the admin/visibility yaml

6) It would be possible to also display an ISSN, but I won't make this patch
any large than it is for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Charles Farmer  changed:

   What|Removed |Added

  Attachment #67587|0   |1
is obsolete||

--- Comment #11 from Charles Farmer  ---
Created attachment 72169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72169=edit
Bug 12502 - Add ordernumber and ISBN to late order

Adds ordernumber as 2nd column and ISBN as last

Followed test plan and patch worked as described. Also ran QA test tools
and all modified files passed

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #9 from Katrin Fischer  ---
*** Bug 16722 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #8 from Katrin Fischer  ---
Hi,

I like what this is trying to do, but at the moment it doesn't work and will
need more work in order to make it in.

1) This patch adds a new routine ModNotesOrder to the C4 namespace.
You should add it to the Koha namespace instead, for example:
Koha::Acq::Order->add_note. It also needs to be covered by unit tests.

2) You change the CSV header, but only add the 2 notes fields. Why not the
ISBN?

3) Entering/saving notes does currently not work for me at all. I think the
input fields in the table take up a lot of space and are not easy to handle. I
suggest taking a look at how adding messages in the patron account works
(button in the toolbar). The change should show immediately (Ajax) or the page
should reload automatically after entering a note (no need to F5).

4) Tiny: The order search uses 'order line' for 'Order no.' - I suggest to also
use order line here to make it consistent.

5) The late orders table can be configured using the column visibility
settings.  The new columns need to be added there as well so you can control
when and where they are visible.

6) Last is just an idea/question: If we are showing ISBN, should we show ISSN
too? Maybe a combined column?

1) and 5) are the biggest issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |david.bourga...@inlibro.com
   |ity.org |
Summary|Add a column for note,  |Add columns for note, order
   |order number ans ISBN in|number and ISBN to late
   |late order page |orders page

--- Comment #7 from Katrin Fischer  ---
David, don't forget to add you as Assignee when you plan to provide patches for
a bug!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/