[Koha-bugs] [Bug 13795] Delete unused columns from statistics table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Martin Renvoize changed: What|Removed |Added Version(s)||19.05.00 released in|| Status|Pushed to Master|RESOLVED Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com --- Comment #19 from Martin Renvoize --- Better safe than sorry I'm not going to backport this cleanup bug just in case anyone is using these fields locally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #18 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Katrin Fischer changed: What|Removed |Added Attachment #88234|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 88239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88239=edit Bug 13795: Make database update idempotent Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Katrin Fischer changed: What|Removed |Added Attachment #88235|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 88240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88240=edit Bug 13795: Remove occurences of unused columns in code These patch removes these two columns from backfill_statstics script and from columns.def - this file is used to create description in guided reports Test plan: 1. Run installer/data/mysql/backfull_statistics.pl --> without this patch, there are associatedborrower and usercode errors reported --> with patch, these two columns are not reported Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Katrin Fischer changed: What|Removed |Added Attachment #88233|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 88238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88238=edit Bug 13795: Delete unused columns from statistics table The following 2 fields are never used in the statistics table: associatedborrower usercode This patch removes them. To test: * check the database and make sure columns are gone Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | Summary|Delete unused columns from |Delete unused columns from |statistics table. |statistics table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Michal Denar changed: What|Removed |Added Attachment #86809|0 |1 is obsolete|| Attachment #86810|0 |1 is obsolete|| Attachment #86811|0 |1 is obsolete|| --- Comment #12 from Michal Denar --- Created attachment 88233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88233=edit Bug 13795: Delete unused columns from statistics table The following 2 fields are never used in the statistics table: associatedborrower usercode This patch removes them. To test: * check the database and make sure columns are gone Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 --- Comment #14 from Michal Denar --- Created attachment 88235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88235=edit Bug 13795: Remove occurences of unused columns in code These patch removes these two columns from backfill_statstics script and from columns.def - this file is used to create description in guided reports Test plan: 1. Run installer/data/mysql/backfull_statistics.pl --> without this patch, there are associatedborrower and usercode errors reported --> with patch, these two columns are not reported Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 --- Comment #13 from Michal Denar --- Created attachment 88234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88234=edit Bug 13795: Make database update idempotent Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Bug 13795 depends on bug 21683, which changed state. Bug 21683 Summary: Remove accountlines.accountno https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Josef Moravec changed: What|Removed |Added Attachment #47555|0 |1 is obsolete|| --- Comment #9 from Josef Moravec --- Created attachment 86809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86809=edit Bug 13795: Delete unused columns from statistics table The following 2 fields are never used in the statistics table: associatedborrower usercode This patch removes them. To test: * check the database and make sure columns are gone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Josef Moravec changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 --- Comment #10 from Josef Moravec --- Created attachment 86810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86810=edit Bug 13795: Make database update idempotent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 --- Comment #11 from Josef Moravec --- Created attachment 86811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86811=edit Bug 13795: Remove occurences of unused columns in code These patch removes these two columns from backfill_statstics script and from columns.def - this file is used to create description in guided reports Test plan: 1. Run installer/data/mysql/backfull_statistics.pl --> without this patch, there are associatedborrower and usercode errors reported --> with patch, these two columns are not reported -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Assignee|neng...@gmail.com |josef.mora...@gmail.com Depends on||21683 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 [Bug 21683] Remove accountlines.accountno -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Caroline Cyr La Rosechanged: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #8 from Caroline Cyr La Rose --- Could we use "usercode" to log the user/librarian who did the action? It would be useful especially for action types that are not logged in action_logs (i.e. issue renewals, payments, writeoffs) I just want to mention that I have a bunch of different values in proccode, but I have no idea what they mean. mysql> select distinct(proccode) from statistics; +--+ | proccode | +--+ | | | 10 | | 1005 | | 1064 | | 1073 | | 1093 | | 11 | | 1152 | | 12 | ... | 9| | 903 | | 918 | | 920 | | 932 | | 947 | | 98 | | 991 | | 996 | +--+ 220 rows in set (0,07 sec) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 M. Tompsettchanged: What|Removed |Added Attachment #36578|0 |1 is obsolete|| --- Comment #6 from M. Tompsett --- Created attachment 47555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47555=edit Bug 13795: Delete unused columns from statistics table The following 4 fields are never used in the statistics table: associatedborrower other proccode usercode This patch removes them. To test: * check the database and make sure columns are gone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 M. Tompsettchanged: What|Removed |Added Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 M. Tompsettchanged: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #7 from M. Tompsett --- I made it apply, but Bernardo Gonzalez Kriegel raises a valid problem in comment #5. $ git grep associatedborrower -- There is mention of it in installer/data/mysql/backfill_statistics.pl Is this script used at all? Obviously people aren't going to need it after upgrading from 2.x to 3.x versions. Perhaps safe to remove? Perhaps backfill_statistics.pl needs a rewrite? other is used in C4::Circulation::AddIssue related to SIP mode. In C4/Accounts.pm and C4/Circulation.pm (only places to use UpdateStats), the following fields are used: branch type amount other itemnumber itemtype borrowernumber ccode accountno schema says that usercode and associatedborrower is unused. Looking at C4/Stats.pm it becomes painfully clear (painful, because they shouldn't have renamed the field like that) that accountno is proccode. I wonder if people are expecting it to be longer than varchar(4). I would resubmit this modified with: 1) Just usercode and associatedborrower removed 2) an atomic update instead of a updatedatabase.pl (https://wiki.koha-community.org/wiki/Database_updates) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Failed QA |Needs Signoff --- Comment #4 from Katrin Fischer --- Hi Hector, those files are generated from the database - so all the columns will appear there, but it doesn't indicate that they are used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Bernardo Gonzalez Kriegelchanged: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||bgkrie...@gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel --- Patch does not apply. Besides, there are other places that reference some of this values e.g. proccode koha-tmpl/intranet-tmpl/prog/en/columns.def:Type of procedure t/db_dependent/Stats.t:is ($params-> {accountno}, $line->{proccode}, "UpdateStats save accountno param in proccode field of statistics table"); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Héctor Eduardo Castro Avaloschanged: What|Removed |Added CC||hector.hecax...@gmail.com --- Comment #3 from Héctor Eduardo Castro Avalos --- All this columns are used by module Koha/Schema/Result/Statistic.pm Inside the file it read # Created by DBIx::Class::Schema::Loader # DO NOT MODIFY THE FIRST PART OF THIS FILE and # Created by DBIx::Class::Schema::Loader v0.07025 @ 2013-10-14 20:56:21 # DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:THELVmdFFi1RCI4DfqwGIw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 --- Comment #1 from Nicole C. Engard neng...@gmail.com --- Created attachment 36578 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36578action=edit Bug 13795: Delete unused columns from stats table The following 4 fields are never used in the statistics table: associatedborrower other proccode usercode This patch removes them. To test: * check the database and make sure columns are gone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13795] Delete unused columns from statistics table.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Dobrica Pavlinusic dpav...@rot13.org changed: What|Removed |Added CC||dpav...@rot13.org Status|Needs Signoff |Failed QA --- Comment #2 from Dobrica Pavlinusic dpav...@rot13.org --- I have something in proccode, but nothing in others: mysql select distinct proccode from statistics;+--+ | proccode | +--+ | NULL | | | | 1| | 2| | 3| | 6| +--+ 6 rows in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/