[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #83 from Matt Blenkinsop  ---
Nice work everyone!

Pushed to stable for 22.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Matt Blenkinsop  changed:

   What|Removed |Added

 Version(s)|23.05.00|23.05.00,22.11.02
released in||
 Status|Pushed to master|Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #82 from Martin Renvoize  ---
Nice work everyone!

Pushed to 23.05.x for the next release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||23.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #81 from Kyle M Hall  ---
Created attachment 145321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145321=edit
Bug 14784: (follow-up) Unit tests

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #137727|0   |1
is obsolete||
 Attachment #137728|0   |1
is obsolete||

--- Comment #80 from Kyle M Hall  ---
Created attachment 145320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145320=edit
Bug 14784: Fix checkin message for restricted patrons

Test plan:
Before

1) Select a user with active indefinite or definite restrictions (manual
restriction works)
2) Make sure finedays=0 for the user category. See [1]
3) Checkout and return an item (not overdue)
   A previous restriction reminder will appear
4) Checkout and return an overdue item (change the date at checkout)
   No previous restriction reminder will appear

After applying patch:
Same steps, but a reminder should appear for step 4)

[1] The "finedays" setting is called "Suspension in days" in the web interface,
if you're searching for it like I did...

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #79 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #78)
> @Kyle: could you maybe weigh in here? IIRC you were the one to write a part
> of this code at least?

Yes, considering Koha::Paron::is_debarred checks that calculated field, I think
it's passible, but it would be best practice to search for patron restrictions
that have no time limit. We don't have classes for borrower_debarments at the
moment, so I think that would be a bit onerous to require.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #78 from Katrin Fischer  ---
@Kyle: could you maybe weigh in here? IIRC you were the one to write a part of
this code at least?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #77 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #75)
> Not sure about the date, actually:
> 
> If you create an unrestricted debarment you get:
> 
> borrowers_debarments.expiration = NULL
> borrowers.debarred = -12-31

Looking at the code, it checked borrowers.debarred:

+} elsif ($patron->debarred) {
+if ( $patron->debarred eq "-12-31") {

So this would be the correct checked for an unlimited restriction indeed. 

There is some history there as in that debarred and debarredcomment where kept
around when borrowers_debarments were added for backwards compatibility. It
should always contain the longest restriction at that moment with more than one
restriction. And it's also still used in patron import for adding a
restriction.

And in borrowers.debarred we can't use NULL to indicate an unlimited
debarment... as that would mean NO restriction. So the 'magic' date is still
used there.

Setting back to Signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #76 from Blou  ---
So, Signed Off or Failed QA ?
Seems the  is still a valid test, per Cate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #75 from Katrin Fischer  ---
Not sure about the date, actually:

If you create an unrestricted debarment you get:

borrowers_debarments.expiration = NULL
borrowers.debarred = -12-31

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #74 from Martin Renvoize  ---
Comment on attachment 137727
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137727
Bug 14784: Fix checkin message for restricted patrons

Review of attachment 137727:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14784=137727)
-

::: C4/Circulation.pm
@@ +2296,4 @@
>  if ( $issue and $issue->is_overdue($return_date) ) {
>  # fix fine days
>  my ($debardate,$reminder) = _debar_user_on_return( 
> $patron_unblessed, $item->unblessed, dt_from_string($issue->date_due), 
> $return_date );
> +if ($debardate and $debardate ne "-12-31") {

There really shouldn't be any -12-31 dates left for debardate.. we tried to
clean them all up back with the 3.15.00.029 database update.

@@ +2302,5 @@
> +} else {
> +$messages->{'Debarred'} = $debardate;
> +}
> +} elsif ($patron->debarred) {
> +if ( $patron->debarred eq "-12-31") {

As above

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Shi Yao Wang  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #73 from Shi Yao Wang  ---
Added tests and fixed some typos in main patch commit message.

Putting back to Signed Off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #72 from Shi Yao Wang  ---
Created attachment 137728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137728=edit
Bug 14784: (follow-up) Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #136327|0   |1
is obsolete||

--- Comment #71 from Shi Yao Wang  ---
Created attachment 137727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137727=edit
Bug 14784: Fix checkin message for restricted patrons

Test plan:
Before

1) Select a user with active indefinite or definite restrictions (manual
restriction works)
2) Make sure finedays=0 for the user category. See [1]
3) Checkout and return an item (not overdue)
   A previous restriction reminder will appear
4) Checkout and return an overdue item (change the date at checkout)
   No previous restriction reminder will appear

After applying patch:
Same steps, but a reminder should appear for step 4)

[1] The "finedays" setting is called "Suspension in days" in the web interface,
if you're searching for it like I did...

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #70 from Victor Grousset/tuxayo  ---
> The current patch is quite different than the previous one so I marked the 
> previous tests as obsolete.

Makes sense.
Tests on the new changes are still needed for this to be ready for QA. These
are not trivial changes and AddReturn() in Circulation.pm is like super
critical code ^^"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #69 from Shi Yao Wang  ---
The current patch is quite different than the previous one so I marked the
previous tests as obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #68 from Jonathan Druart  ---
Did we lose the tests?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #67 from David Nind  ---
My testing notes (using koha-testing-docker)

Step 1: To add a restriction:
. Select and edit a patron 
. Scroll down to the 'Patron restrictions' section
. Add a manual restriction

Step 2: In KTD "Suspension in days" is already set to 0 for the current default
rules.

Steps 3 and 4: Use the "Override restriction temporarily" when checking out an
item.

Tests should continue to pass: prove -v t/db_dependent/Circulation.t

See also comment #21.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Nind  changed:

   What|Removed |Added

 Attachment #136040|0   |1
is obsolete||

--- Comment #66 from David Nind  ---
Created attachment 136327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136327=edit
Bug 14784: Fix checkin message for restricted patrons

Test plan:
Before

1) Select a user with active indefinite or definite restrictions (manual
restriction works)
2) Make sure finesday=0 for the user category. See [1]
3) Checkout and return an item (not overdue)
   A previous restriction reminder will appear
4) Checkout and return an overdue item (change the date at cehckout)
   No previous restriction reminder will appear

After applying patch:
Same steps, but a reminder should appear for step 4)

[1] The "finesday" setting is called "Suspension in days" in the web interface,
if you're searching for it like I did...

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Katrin Fischer  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Shi Yao Wang  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|REOPENED

--- Comment #65 from Shi Yao Wang  ---
Here is a patch that fixes the missing checkin message without changing code in
_calculate_new_debar_dt or _debar_user_on_return. So it shouldn't affect other
functionality too much. It shouldn't cause additional test fails.

Only little thing is that it duplicates the code because it has the same block
of code (inside elsif).

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Shi Yao Wang  changed:

   What|Removed |Added

 Attachment #112724|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Shi Yao Wang  changed:

   What|Removed |Added

 CC||shi-yao.w...@inlibro.com
 Attachment #112725|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #64 from Shi Yao Wang  ---
Created attachment 136040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136040=edit
Bug 14784: Fix checkin message for restricted patrons

Test plan:
Before

1) Select a user with active indefinite or definite restrictions (manual
restriction works)
2) Make sure finesday=0 for the user category. See [1]
3) Checkout and return an item (not overdue)
   A previous restriction reminder will appear
4) Checkout and return an overdue item (change the date at cehckout)
   No previous restriction reminder will appear

After applying patch:
Same steps, but a reminder should appear for step 4)

[1] The "finesday" setting is called "Suspension in days" in the web interface,
if you're searching for it like I did...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #63 from Katrin Fischer  ---
Changing status to indicate more clearly that these patches haven't been
pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Florian  changed:

   What|Removed |Added

 CC||florian.bontemps@biblibre.c
   ||om

--- Comment #62 from Florian  ---
I concur with The Minh Luong, if I run the test plan without patching I don't
have any issues, but after patching, step 5 (running prove -l
t/db_dependent/Circulation.t) gets me not one, but 31 failed tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

The Minh Luong  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

The Minh Luong  changed:

   What|Removed |Added

 CC||the-minh.lu...@inlibro.com

--- Comment #61 from The Minh Luong  ---
I have tested before applying the patch and everything seems to work WITHOUT
it. The tests seems to work fine without the patch, but one fail when applying
the patch. 

Here is what I did: 

Before applying the patch:
1) Select a user with active restrictions (manual restriction works) and note
his category.
2) Make sure finesday=0 for the user's category noted in step 1. 
3) Checkout and return an item (not overdue).
   A previous restriction reminder will appear (Message in yellow box)
4) Checkout and return an overdue item (change the date at checkout)
   A previous restriction reminder will also appear (Message in yellow box)
5) Run prove -l t/db_dependent/Circulation.t (ALL tests should pass)

After applying patch:
Same steps from 1 to 5 , but at step 5, one test fails (AddReturn +
CumulativeRestrictionPeriods).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||da...@davidnind.com

--- Comment #60 from David Nind  ---
Patch still applies!

Failed test still though:
- not ok 30 - AddReturn + CumulativeRestrictionPeriods

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Blou  changed:

   What|Removed |Added

   Assignee|charles.far...@inlibro.com  |alexis.ripe...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #59 from Arthur Suzuki  ---
Hi Sonia,
Just managed to get my Koha testing environment up again.
Unfortunately, after applying both tests patch and fix patchs, some tests are
still failing.
Still a bit of work needed on that patch.
I see that assignee changed, is there someone working on that one?
King regards,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Koha Team University Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

--- Comment #58 from Koha Team University Lyon 3  ---
Hello,
does this one need new tests or is there just QA issues ?
Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Alexis Ripetti  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #57 from Alexis Ripetti  ---
So, I fixed the test that does not pass.
I also put the changes in the good patch.
When I apply both patches, I got this :


not ok 8

#   Failed test at t/db_dependent/Circulation.t line 2102.
#  got: '2020-11-17'
# expected: '2020-11-25'
# Looks like you failed 1 test of 8.
not ok 28 - AddReturn + CumulativeRestrictionPeriods

#   Failed test 'AddReturn + CumulativeRestrictionPeriods'
#   at t/db_dependent/Circulation.t line 2103.


Is this the one who should fail ?

I also got this :


not ok 14 - Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 0 (168h * 0.25u)

#   Failed test 'Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 0 (168h * 0.25u)'
#   at t/db_dependent/Circulation.t line 3554.
#  got: '47.75'
# expected: '42'
ok 15 - Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 0, for renewal (312h - 168h * 0.25u)
not ok 16 - Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 1 and closed Saturday (168h - 24h * 0.25u)

#   Failed test 'Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 1 and closed Saturday (168h - 24h * 0.25u)'
#   at t/db_dependent/Circulation.t line 3568.
#  got: '35.75'
# expected: '36'
ok 17 - Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 1 and closed Saturday, for renewal (312h - 168h
- 24h * 0.25u
not ok 18 - Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 1 (168h - 0h * 0.25u

#   Failed test 'Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 1 (168h - 0h * 0.25u'
#   at t/db_dependent/Circulation.t line 3582.
#  got: '41.75'
# expected: '42'
ok 19 - Hourly rental charge calculated correctly with
rentalcharge_hourly_calendar = 1, for renewal (312h - 168h - 0h * 0.25u)
# Looks like you failed 3 tests of 19.
not ok 42 - Incremented fee tests

#   Failed test 'Incremented fee tests'
#   at t/db_dependent/Circulation.t line 3592.


These failed tests are also here when I do not apply both patches.
Do you get the same errors?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #110763|0   |1
is obsolete||

--- Comment #55 from Alexis Ripetti  ---
Created attachment 112724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112724=edit
Bug 14784: Fix checkin message for debarred patrons

After thinking about it I changed the code's behavior to always display a
reminder if the patron was previously debarred.
This makes sense to me (it's only a reminder) and it correctly stacks with
other messages.

--

Test plan:
Before

1) Select a user with active restrictions (manual restriction works)
2) Make sure finesday=0 for the user category. See [1]
3) Checkout and return an item (not overdue)
   A previous restriction reminder will appear
4) Checkout and return an overdue item (change the date at cehckout)
   No previous restriction reminder will appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

[1] The "finesday" setting is called "Suspension in days" in the web interface,
if you're searching
for it like I did...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #110764|0   |1
is obsolete||

--- Comment #56 from Alexis Ripetti  ---
Created attachment 112725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112725=edit
Bug 14784: Add tests

This patch adds tests for PrevDebarred message of AddReturn when finesdays = 0.

To test:
1. Apply patches
2. prove -v t/db_dependent/Circulation.t

When applying only this patch, one test should fail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #54 from Arthur Suzuki  ---
Hi Alexis,
Sorry for the late reply...
After applying both patches I still get a failed tests:

root@kohadevbox:koha(master)$ prove t/db_dependent/Circulation.t 
t/db_dependent/Circulation.t .. 27/50 
#   Failed test 'AddReturn must have debarred the patron'
#   at t/db_dependent/Circulation.t line 89.
#  got: ''
# expected: '1'
# AddReturn returned message $VAR1 = {
#   'WasReturned' => 1
# };
# Looks like you failed 1 test of 29.
t/db_dependent/Circulation.t .. 29/50 
#   Failed test 'AddReturn + suspension_chargeperiod'
#   at t/db_dependent/Circulation.t line 2397.
t/db_dependent/Circulation.t .. 48/50 # Looks like you failed 1 test of 50.
t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/50 subtests 

Test Summary Report
---
t/db_dependent/Circulation.t (Wstat: 256 Tests: 50 Failed: 1)
  Failed test:  29
  Non-zero exit status: 1
Files=1, Tests=50, 22 wallclock secs ( 0.07 usr  0.01 sys + 17.66 cusr  1.62
csys = 19.36 CPU)
Result: FAIL


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #53 from Alexis Ripetti  ---
(In reply to Jonathan Druart from comment #52)
> 1. The second patch "Add tests" adds a change to the module, is that
> expected?
> 
> 2. You are modifying a test that is not (at first glance) directly related
> to your changes, why?
>
>3.


1. As I said in a previous comment, the change in the C4/Circulation.pm file
should have been applied on the main patch.

2. I was waiting for an answer of Arthur Suzuki about the test who should fail.
I think that I corrected this test to pass but it may need to fail ? I am still
waiting for an answer about the comment 49.

3. We can just modify the comment : # there's no overdue on the item but
borrower is debarred

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #52 from Jonathan Druart  
---
1. The second patch "Add tests" adds a change to the module, is that expected?

2. You are modifying a test that is not (at first glance) directly related to
your changes, why?

@@ -2094,7 +2094,7 @@ subtest 'AddReturn + CumulativeRestrictionPeriods' => sub
{
 is( scalar(@$debarments), 1 );
 $expected_expiration = output_pref(
 {
-dt => $now->clone->add( days => ( 5 - 1 ) * 2 + ( 10 - 1 ) * 2 ),
+dt => $now->clone->add( days => ( 10 - 1 ) * 2 ),

3. 

 # there's no overdue on the item but borrower had been previously
debarred
-} elsif ( $issue->date_due and $patron->debarred ) {
+if ( $patron->debarred ) {

Comment and code not kept in sync.

Please clarify.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #106808|0   |1
is obsolete||
 Attachment #110514|0   |1
is obsolete||

--- Comment #50 from Kyle M Hall  ---
Created attachment 110763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110763=edit
Bug 14784: Fix checkin message for debarred patrons

After thinking about it I changed the code's behavior to always display a
reminder if the patron was previously debarred.
This makes sense to me (it's only a reminder) and it correctly stacks with
other messages.

--

Test plan:
Before

1) Select a user with active restrictions (manual restriction works)
2) Make sure finesday=0 for the user category. See [1]
3) Checkout and return an item (not overdue)
   A previous restriction reminder will appear
4) Checkout and return an overdue item (change the date at cehckout)
   No previous restriction reminder will appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

[1] The "finesday" setting is called "Suspension in days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer 
Signed-off-by: Victor Grousset 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #51 from Kyle M Hall  ---
Created attachment 110764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110764=edit
Bug 14784: Add tests

This patch adds tests for PrevDebarred message of AddReturn when finesdays = 0.

To test:
1. Apply patches
2. prove -v t/db_dependent/Circulation.t

When applying only this patch, one test should fail.

Signed-off-by: Arthur Suzuki 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #49 from Alexis Ripetti  ---
(In reply to Arthur Suzuki from comment #48)
> Test patch works as expected (there is one test which doesn't pass when test
> patch is applied alone).
> However the test patch seems to change things in C4/Circulation as well,
> is this due to a change in the db structure,
> and shouldn't this change be in the main patch anyway?
> Other than this comment, happy to signoff :)

The change in the C4/Circulation.pm file should have been applied on the main
patch.
You previously said that a test should fail when patches are applied. But which
test does fail for you and which one is supposed to fail? Because when I apply
both patches every tests pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #48 from Arthur Suzuki  ---
Test patch works as expected (there is one test which doesn't pass when test
patch is applied alone).
However the test patch seems to change things in C4/Circulation as well,
is this due to a change in the db structure,
and shouldn't this change be in the main patch anyway?
Other than this comment, happy to signoff :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Arthur Suzuki  changed:

   What|Removed |Added

 Attachment #110485|0   |1
is obsolete||

--- Comment #47 from Arthur Suzuki  ---
Created attachment 110514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110514=edit
Bug 14784: Add tests

This patch adds tests for PrevDebarred message of AddReturn when finesdays = 0.

To test:
1. Apply patches
2. prove -v t/db_dependent/Circulation.t

When applying only this patch, one test should fail.

Signed-off-by: Arthur Suzuki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Arthur Suzuki  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Alexis Ripetti  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Alexis Ripetti  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
 CC||alexis.ripe...@inlibro.com

--- Comment #46 from Alexis Ripetti  ---

This patch adds tests for PrevDebarred message of AddReturn when finesdays = 0.
I also changed one thing that seemed weird to me in the C4/Circulation.pm file.

Test plan:
Before

1) Select a user with active restrictions
2) Make sure finesday=0 for the user category
3) Checkout and return an item (not overdue) : a previous restriction reminder
will appear
4) Checkout and return an overdue item : no previous restriction reminder will
appear

After applying patch:
Same steps, but a reminder should appear for step 4)

And finally:
5) prove -v t/db_dependent/Circulation.t


All the tests should now pass.

Waiting for your comments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #106809|0   |1
is obsolete||

--- Comment #45 from Alexis Ripetti  ---
Created attachment 110485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110485=edit
Bug 14784: Add tests

This patch adds tests for PrevDebarred message of AddReturn when finesdays = 0.

To test:
1. Apply patches
2. prove -v t/db_dependent/Circulation.t

When applying only this patch, one test should fail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Kelly McElligott  changed:

   What|Removed |Added

 CC||ke...@bywatersolutions.com

--- Comment #44 from Kelly McElligott  ---
Created attachment 107487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107487=edit
restriction

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #43 from Katrin Fischer  ---
I am sorry, but the tests are failing with the patch set applied:

t/db_dependent/Circulation.t .. 49/49 # Looks like you failed 1 test of 49.
t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/49 subtests 

Test Summary Report
---
t/db_dependent/Circulation.t (Wstat: 256 Tests: 49 Failed: 1)
  Failed test:  29
  Non-zero exit status: 1
Files=1, Tests=49, 34 wallclock secs ( 0.10 usr  0.00 sys + 24.89 cusr  2.61
csys = 27.60 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Maryse Simard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #42 from Maryse Simard  ---
(In reply to Katrin Fischer from comment #41)
> If the rebase was not too hard you can switch off back to Signed off
> usually. Also added tests are ok as a QA follow-up :)

Thank you for the reply! In that case, I'll set the status back to signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #41 from Katrin Fischer  ---
(In reply to Maryse Simard from comment #40)
> Rebased the patch and added a commit for unit tests.
> 
> I was unsure which status to set this to, so I've set it back to needs
> signoff.

If the rebase was not too hard you can switch off back to Signed off usually.
Also added tests are ok as a QA follow-up :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #79826|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #39 from Maryse Simard  ---
Created attachment 106809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106809=edit
Bug 14784: Add tests

This patch adds tests for PrevDebarred message of AddReturn when finesdays = 0.

To test:
1. Apply patches
2. prove -v t/db_dependent/Circulation.t

When applying only this patch, one test should fail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Maryse Simard  changed:

   What|Removed |Added

 CC||maryse.sim...@inlibro.com
 Status|Failed QA   |Needs Signoff

--- Comment #40 from Maryse Simard  ---
Rebased the patch and added a commit for unit tests.

I was unsure which status to set this to, so I've set it back to needs signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #38 from Maryse Simard  ---
Created attachment 106808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106808=edit
Bug 14784: Fix checkin message for debarred patrons

After thinking about it I changed the code's behavior to always display a
reminder if the patron was previously debarred.
This makes sense to me (it's only a reminder) and it correctly stacks with
other messages.

--

Test plan:
Before

1) Select a user with active restrictions (manual restriction works)
2) Make sure finesday=0 for the user category. See [1]
3) Checkout and return an item (not overdue)
   A previous restriction reminder will appear
4) Checkout and return an overdue item (change the date at cehckout)
   No previous restriction reminder will appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

[1] The "finesday" setting is called "Suspension in days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer 
Signed-off-by: Victor Grousset 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Arthur Suzuki  changed:

   What|Removed |Added

 CC||arthur.suz...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #37 from Katrin Fischer  ---
This makes changes to a core routine - AddReturn - so asking for tests is
normal and they should be provided by the patch author ideally - anyone can,
but it's not QA's job.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #36 from Fridolin SOMERS  ---
> Tests are missing anyhow
This is a very important code, if anyone is willing to provide tests, you are
welcome :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Niamh  changed:

   What|Removed |Added

 CC||niamh.walker-headon@it-tall
   ||aght.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #35 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #11)
> Tests are missing anyhow.

(In reply to Marcel de Rooy from comment #26)
> See Comment11 too. We still need additional unit testing.

And... still missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m
 Status|Needs Signoff   |Signed Off

--- Comment #34 from Victor Grousset/tuxayo  ---
Signed off and updated test plan:
- add "(manual restriction works)"
- update text 'called "Suspension in days"' to match the UI

Thanks Frido for guiding me :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #77683|0   |1
is obsolete||

--- Comment #33 from Victor Grousset/tuxayo  ---
Created attachment 79826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79826=edit
Bug 14784 - Fix checkin message for debarred patrons

After thinking about it I changed the code's behavior to always display a
reminder if the patron was previously debarred.
This makes sense to me (it's only a reminder) and it correctly stacks with
other messages.

--

Test plan:
Before

1) Select a user with active restrictions (manual restriction works)
2) Make sure finesday=0 for the user category. See [1]
3) Checkout and return an item (not overdue)
   A previous restriction reminder will appear
4) Checkout and return an overdue item (change the date at cehckout)
   No previous restriction reminder will appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

[1] The "finesday" setting is called "Suspension in days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer 
Signed-off-by: Victor Grousset 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Charles Farmer  changed:

   What|Removed |Added

  Attachment #69296|0   |1
is obsolete||

--- Comment #32 from Charles Farmer  ---
Created attachment 77683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77683=edit
Bug 14784 - Fix checkin message for debarred patrons

After thinking about it I changed the code's behavior to always display a
reminder if the patron was previously debarred.
This makes sense to me (it's only a reminder) and it correctly stacks with
other messages.

--

Test plan:
Before

1) Select a user with active restrictions
2) Make sure finesday=0 for the user category
3) Checkout and return an item (not overdue) : a previous restriction reminder
will appear
4) Checkout and return an overdue item : no previous restriction reminder will
appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

P.S.: The "finesday" setting is called "Suspension days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Charles Farmer  changed:

   What|Removed |Added

   Assignee|david.bourga...@inlibro.com |charles.far...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Amit Gupta  changed:

   What|Removed |Added

 CC||amitddng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #31 from Katrin Fischer  ---
Hi Frido, maybe you can sign-off again? I think David made changes after my
initial sign-off (would have been better in a little follow-up patch)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #30 from Fridolin SOMERS  ---
It also corrects a small bug, when restriction is infinite, the date
"31/12/" was displayed in return page.
This is because new code always checks for this infinite date and returns
message "ForeverDebarred" instead of "PrevDebarred".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #29 from Fridolin SOMERS  ---
(In reply to David Bourgault from comment #28)
> Signed-off-by: Katrin Fischer 

Is this patch signed off ?
Or does it need a second signing ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Fridolin SOMERS  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Fridolin SOMERS  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Bourgault  changed:

   What|Removed |Added

   Assignee|bouzid.ferg...@inlibro.com  |david.bourga...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Bourgault  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Bourgault  changed:

   What|Removed |Added

  Attachment #69295|0   |1
is obsolete||

--- Comment #28 from David Bourgault  ---
Created attachment 69296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69296=edit
Bug 14784 - Fix checkin message for debarred patrons

After thinking about it I changed the code's behavior to always display a
reminder if the patron was previously debarred.
This makes sense to me (it's only a reminder) and it correctly stacks with
other messages.

--

Test plan:
Before

1) Select a user with active restrictions
2) Make sure finesday=0 for the user category
3) Checkout and return an item (not overdue) : a previous restriction reminder
will appear
4) Checkout and return an overdue item : no previous restriction reminder will
appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

P.S.: The "finesday" setting is called "Suspension days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Bourgault  changed:

   What|Removed |Added

  Attachment #68132|0   |1
is obsolete||

--- Comment #27 from David Bourgault  ---
Created attachment 69295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69295=edit
Bug 14784 - Fix checkin message for debarred patrons

Tested and bug still exists, however previous patch did not apply and relied on
obsolete code.

Test plan:

Before

1) Select a user with active restrictions
2) Make sure finesday=0 for the user category
3) Checkout and return an item (not overdue) : a previous restriction reminder
will appear
4) Checkout and return an overdue item : no previous restriction reminder will
appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

P.S.: The "finesday" setting is called "Suspension days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #26 from Marcel de Rooy  ---
QA Comment:
Thx David for your brave changes. Looks good, still asking some attention.

-} elsif ( $issue->date_due and $patron->debarred ) {
+if ( $new_debar == 0 and $patron->debarred ) {
Why do you remove the test on date_due (might be just theoretical)?
Since you change the program flow by changing an elsif into an if, the game may
change here. 
The comment on top is no longer valid at least ("There is no overdue...");
seems ok for the rest.

Variable $is_a_reminder is no longer used.
# if borrower was already debarred but does not get an extra debarment
Your changes make this comment look bad.
Since _debar_user_on_return now seems to return new or extended debarment dates
only, please adjust POD.
In AddReturn adjust varname accordingly (like newdebardate or so )?
You do not need $debardate and $new_debar now; $newdebardate would be enough to
test.

See Comment11 too. We still need additional unit testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #25 from Marcel de Rooy  ---
Changing status. Comment follows.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #24 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #23 from Katrin Fischer  ---
Hi David, thx for the updated test plan. I reset my system since and I could
see the bug and confirm the fix now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67102|0   |1
is obsolete||

--- Comment #22 from Katrin Fischer  ---
Created attachment 68132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68132=edit
Bug 14784 - Fix checkin message for debarred patrons

Tested and bug still exists, however previous patch did not apply and relied on
obsolete code.

Test plan:

Before

1) Select a user with active restrictions
2) Make sure finesday=0 for the user category
3) Checkout and return an item (not overdue) : a previous restriction reminder
will appear
4) Checkout and return an overdue item : no previous restriction reminder will
appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

P.S.: The "finesday" setting is called "Suspension days" in the web interface,
if you're searching
for it like I did...

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Bourgault  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion
 CC||david.bourga...@inlibro.com

--- Comment #21 from David Bourgault  ---
Hi Katrin,

I can still reproduce the problem on my end... Maybe this more detailed test
plan can help :

0) Create a circulation rules under Koha > Admin > Circulation and fine rules
with the value "0" for "Suspension days" (this maps to finedays in the
database)
1) Select a test patron with the corresponding patron category.
2) Checkout an item (with the item_type corresponding to the rule set in step
#0)for this patron, setting a due date in the past.
3) Manually set an indefinite restriction on this user
4) Check-in the item.
5) There should be a warning reminding that the user is debarred/restricted,
but it is not there.

If finedays is > 0, the reminder (or the new suspension) appears.
If the item is not overdue, the reminder appears.
If the item is overdue AND finedays is 0, the reminder does not appear.

To answer your questions :
A) You can restrict the user before or after checking out, this does not affect
the result in my testing (but you will need to override the restriction).
B) You might manually restrict users for different reasons, regardless of your
circulation rules. This bug is only about a missing warning, not a missing
suspension.

The issue happens because of a "else if" which does not make sense if finedays
is set to 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #20 from Katrin Fischer  ---
Hi David,
I've tried several things, but I think we are missing something in the test
plan. That's what I've tried and I've always seen a message on check-in:

1) Created an manual indefinite restriction for the patron. 
2) Created a manual restriction with a date in 2 weeks. 


Question:
- You say checkout and checkin - I can only do so by overwriting the
restriction temporarily. Is that what you do as well?
- You say fines by days should be 0. I was testing with a manual restriction,
should this be a restriction of a certain type? If you want suspension, why
then fines in days = 0?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

David Bourgault  changed:

   What|Removed |Added

  Attachment #58227|0   |1
is obsolete||

--- Comment #19 from David Bourgault  ---
Created attachment 67102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67102=edit
Attachment to Bug 14784 - Missing checkin message for debarred patrons when
issuing rules 'fine days = 0'

Bug 14784 - Fix checkin message for debarred patrons

Tested and bug still exists, however previous patch did not apply and relied on
obsolete code.

Test plan:

Before

1) Select a user with active restrictions
2) Make sure finesday=0 for the user category
3) Checkout and return an item (not overdue) : a previous restriction reminder
will appear
4) Checkout and return an overdue item : no previous restriction reminder will
appear

After applying patch:
Same steps, but a reminder should appear for step 4)

I've also tested with finesday=1 with "no overdue", "grace period overdue" and
"long overdue" test
cases. The appropriate nessage appeared for each test.

P.S.: The "finesday" setting is called "Suspension days" in the web interface,
if you're searching
for it like I did...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Philippe Audet-Fortin  changed:

   What|Removed |Added

 CC||philippe.audet-fortin@inlib
   ||ro.com
 Status|Failed QA   |Signed Off

--- Comment #18 from Philippe Audet-Fortin  
---
I tested Bouzid scenarios and I was able to reproduce the problem so it seems
to be a real issue. 
After applying the patch I was able to see the message as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #17 from Owen Leonard  ---
Marking this Failed QA until we get some feedback on the testing results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #16 from Owen Leonard  ---
I don't think I am able to reproduce this bug. Either that or I misunderstand
what the bug is. As far as I can tell I'm getting the correct checkin messages
for restricted patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Baptiste  changed:

   What|Removed |Added

 CC||baptiste.wojtkowski@biblibr
   ||e.com

--- Comment #15 from Baptiste  ---
Hi,
The scenario 2 leads me to a message, even without patching

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Bouzid  changed:

   What|Removed |Added

   Assignee|remi.mayrand-provencher@inL |bouzid.ferg...@inlibro.com
   |ibro.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Bouzid  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Bouzid  changed:

   What|Removed |Added

 Status|CLOSED  |REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Bouzid  changed:

   What|Removed |Added

 CC||bouzid.ferg...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Bouzid  changed:

   What|Removed |Added

  Attachment #49377|0   |1
is obsolete||

--- Comment #14 from Bouzid  ---
Created attachment 58227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58227=edit
Bug14784 - Fix checkin message for debarred patrons

Hi All,
 According to my tests, the bug exist always
 Before apply patch:
  Scenario 1:
   1. Choose one borrower who have not a fines
   2. Checkout one document for this borrower(Example : choose return date
10 days after)
   3. Add restriction for this borrower (Example : 2 days after checkin).
   4. When Checkin in "cgi-bin/koha/circ/returns.pl" this document, you see
a message in red :
 Reminder: Patron was earlier restricted until <..>.
   Scenario 2:
1. Choose one borrower who have a fines
2. Checkout one document for this borrower
3. Add restriction for this borrower
4. When Checkin  in "cgi-bin/koha/circ/returns.pl" this document, you
haven't the message: Reminder: Patron was earlier restricted until
<..> , just a message of fines.
 when apply patch, you have the message in all situations when borrower is
debarred

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/