[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #108 from Magnus Enger --- *** Bug 14933 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #107 from Kyle M Hall --- (In reply to Joonas Kylmälä from comment #106) > Kyle, do you have the patch from Bug 25992? It fixed the issue at least for > me back in the time I created the patch. That fixes it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Fridolin Somers changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #106 from Joonas Kylmälä --- Kyle, do you have the patch from Bug 25992? It fixed the issue at least for me back in the time I created the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #105 from Jonathan Druart --- (In reply to Kyle M Hall from comment #104) > We are seeing this error as well. The patch I've attached should fix it. > > Should we file a separate bug report for this? Yes please. It's in stable already. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #104 from Kyle M Hall --- We are seeing this error as well. The patch I've attached should fix it. Should we file a separate bug report for this? (In reply to Joonas Kylmälä from comment #102) > The C4/SIP/Logger.pm module doesn't export set_logger and get_logger > subroutines, at least this fails on Debian 9. > > > Undefined subroutine ::SIP::SIPServer::set_logger called at > > /kohadevbox/koha/C4/SIP/SIPServer.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #103 from Kyle M Hall --- Created attachment 69 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69=edit Bug 15253: (Followup) Fully qualify calls to set_logger This should not be necessary, but does fix the isse that Joonas is seeing: Undefined subroutine ::SIP::SIPServer::set_logger called at /kohadevbox/koha/C4/SIP/SIPServer.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Tomás Cohen Arazi changed: What|Removed |Added Blocks||25992 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25992 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 [Bug 25992] SIP2 server doesn't start - Undefined subroutine set_logger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Joonas Kylmälä changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25992 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi --- Comment #102 from Joonas Kylmälä --- The C4/SIP/Logger.pm module doesn't export set_logger and get_logger subroutines, at least this fails on Debian 9. > Undefined subroutine ::SIP::SIPServer::set_logger called at > /kohadevbox/koha/C4/SIP/SIPServer.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added Blocks||25510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 [Bug 25510] Typo in koha-common.postinst causing shell errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #101 from Joy Nelson --- missing dependencies-not backported to 19.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Blocks||25464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25464 [Bug 25464] Add ability to specify client IP and SIP account used in SIP2 logging -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Martin Renvoize changed: What|Removed |Added Text to go in the|RMNOTE - Reverted, remove | release notes|from release notes | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate |Manual, ||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #100 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #99 from Jonathan Druart --- (In reply to Kyle M Hall from comment #90) I then decided to remove the specific logging output, we could deal with it correctly on a separate bug report. Patches rebased and PQA. If this is pushed to 20.05 we will need to make sure the log files' permissions are correct when the debian packages are used, and that the different scripts that use Koha::Logger works properly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #98 from Jonathan Druart --- Created attachment 104674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104674=edit Bug 15253: Remove specific logging output * We should not call Log::Log4perl directly * Not sure it is correct as I get from (comment 77): % koha-sip --restart [2020/04/23 11:23:27] [ERROR] [undef]@[undef]: Argument "0.33_01" isn't numeric in numeric lt (<) at /usr/share/perl5/Net/Server/Log/Sys/Syslog.pm line 42. C4::SIP::Trapper::PRINT /kohadevbox/koha/C4/SIP/Trapper.pm (24) Why "ERROR" when it's a warning? The [undef]@[undef] seems wrong here. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #95 from Jonathan Druart --- Created attachment 104671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104671=edit Bug 15253: Log trapped errors as log level 'warn' instead of 'error' Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #97 from Jonathan Druart --- Created attachment 104673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104673=edit Bug 15253: Add POD to C4/SIP/Logger.pm and C4/SIP/Trapper.pm Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #96 from Jonathan Druart --- Created attachment 104672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104672=edit Bug 15253: Convert all tabs into 4 spaces in affected files Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #94 from Jonathan Druart --- Created attachment 104670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104670=edit Bug 15253: Add log4perl conf updates for Debian packages * Add log4perl conf updates for Debian packages * Rename sip2.log to sip.log Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #93 from Jonathan Druart --- Created attachment 104669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104669=edit Bug 15253: Rename syslog() to siplog() Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #92 from Jonathan Druart --- Created attachment 104668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104668=edit Bug 15253: Move subs to a new module, allow unit tests to function Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added Attachment #103915|0 |1 is obsolete|| Attachment #103916|0 |1 is obsolete|| Attachment #103917|0 |1 is obsolete|| Attachment #103918|0 |1 is obsolete|| Attachment #103919|0 |1 is obsolete|| Attachment #103920|0 |1 is obsolete|| Attachment #103921|0 |1 is obsolete|| Attachment #104016|0 |1 is obsolete|| --- Comment #91 from Jonathan Druart --- Created attachment 104667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104667=edit Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Signed-off-by: Liz Rea Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #90 from Kyle M Hall --- (In reply to Jonathan Druart from comment #89) > (In reply to Kyle M Hall from comment #87) > > (In reply to Jonathan Druart from comment #77) > > > % koha-sip --restart > > > > > > and I get: > > > > > > [2020/04/23 11:23:27] [ERROR] [undef]@[undef]: Argument "0.33_01" isn't > > > numeric in numeric lt (<) at /usr/share/perl5/Net/Server/Log/Sys/Syslog.pm > > > line 42. > > > C4::SIP::Trapper::PRINT /kohadevbox/koha/C4/SIP/Trapper.pm (24) > > > > > > > > > Why "ERROR" when it's a warning? > > > The [undef]@[undef] seems wrong here. > > > > During normal SIP use, that will show the sip account used and the incoming > > ip address. For unit tests and such they appear as undefs. > > I was missing that they were variables defined in SIPServer.pm: > > +# Flush previous MDCs to prevent accidentally leaking incorrect > MDC-entries > +Log::Log4perl::MDC->put( "accountid", undef ); > +Log::Log4perl::MDC->put( "peeraddr", undef ); > > Is that correct to use directly Log::Log4perl here? Should not it be a > Koha::Logger method instead? I see little benefit in using Koha::Logger directly here, it would just add another layer of abstraction. However, I wouldn't be opposed either. It makes more sense to prevent scope creep here and make that encapsulation part of a future bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added Keywords||rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #89 from Jonathan Druart --- (In reply to Kyle M Hall from comment #87) > (In reply to Jonathan Druart from comment #77) > > % koha-sip --restart > > > > and I get: > > > > [2020/04/23 11:23:27] [ERROR] [undef]@[undef]: Argument "0.33_01" isn't > > numeric in numeric lt (<) at /usr/share/perl5/Net/Server/Log/Sys/Syslog.pm > > line 42. > > C4::SIP::Trapper::PRINT /kohadevbox/koha/C4/SIP/Trapper.pm (24) > > > > > > Why "ERROR" when it's a warning? > > The [undef]@[undef] seems wrong here. > > During normal SIP use, that will show the sip account used and the incoming > ip address. For unit tests and such they appear as undefs. I was missing that they were variables defined in SIPServer.pm: +# Flush previous MDCs to prevent accidentally leaking incorrect MDC-entries +Log::Log4perl::MDC->put( "accountid", undef ); +Log::Log4perl::MDC->put( "peeraddr", undef ); Is that correct to use directly Log::Log4perl here? Should not it be a Koha::Logger method instead? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #88 from Jonathan Druart --- Created attachment 104016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104016=edit Bug 15253: Remove unused use of Scalar::Util -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #87 from Kyle M Hall --- (In reply to Jonathan Druart from comment #77) > % koha-sip --restart > > and I get: > > [2020/04/23 11:23:27] [ERROR] [undef]@[undef]: Argument "0.33_01" isn't > numeric in numeric lt (<) at /usr/share/perl5/Net/Server/Log/Sys/Syslog.pm > line 42. > C4::SIP::Trapper::PRINT /kohadevbox/koha/C4/SIP/Trapper.pm (24) > > > Why "ERROR" when it's a warning? > The [undef]@[undef] seems wrong here. During normal SIP use, that will show the sip account used and the incoming ip address. For unit tests and such they appear as undefs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #83 from Kyle M Hall --- Created attachment 103918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103918=edit Bug 15253: Add log4perl conf updates for Debian packages * Add log4perl conf updates for Debian packages * Rename sip2.log to sip.log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #86 from Kyle M Hall --- Created attachment 103921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103921=edit Bug 15253: Add POD to C4/SIP/Logger.pm and C4/SIP/Trapper.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #84 from Kyle M Hall --- Created attachment 103919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103919=edit Bug 15253: Log trapped errors as log level 'warn' instead of 'error' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #85 from Kyle M Hall --- Created attachment 103920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103920=edit Bug 15253: Convert all tabs into 4 spaces in affected files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #82 from Kyle M Hall --- Created attachment 103917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103917=edit Bug 15253: Rename syslog() to siplog() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #81 from Kyle M Hall --- Created attachment 103916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103916=edit Bug 15253: Move subs to a new module, allow unit tests to function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Attachment #103499|0 |1 is obsolete|| Attachment #103500|0 |1 is obsolete|| Attachment #103501|0 |1 is obsolete|| Attachment #103502|0 |1 is obsolete|| Attachment #103503|0 |1 is obsolete|| Attachment #103599|0 |1 is obsolete|| --- Comment #80 from Kyle M Hall --- Created attachment 103915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103915=edit Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Signed-off-by: Liz Rea Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #79 from Jonathan Druart --- Kyle, I am still waiting for a patch to fix: (In reply to Jonathan Druart from comment #76) > (In reply to Kyle M Hall from comment #75) > > Created attachment 103503 [details] [review] [review] > > Bug 15253: Fix QA script issues > > This patch adds 3 spaces for indentation. Looks like the existing > indentation is not perfect but with this patch we make it worst. (In reply to Jonathan Druart from comment #77) > The [undef]@[undef] seems wrong here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #78 from Kyle M Hall --- Created attachment 103599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103599=edit Bug 15253: Log trapped errors as log level 'warn' instead of 'error' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #77 from Jonathan Druart --- % koha-sip --restart and I get: [2020/04/23 11:23:27] [ERROR] [undef]@[undef]: Argument "0.33_01" isn't numeric in numeric lt (<) at /usr/share/perl5/Net/Server/Log/Sys/Syslog.pm line 42. C4::SIP::Trapper::PRINT /kohadevbox/koha/C4/SIP/Trapper.pm (24) Why "ERROR" when it's a warning? The [undef]@[undef] seems wrong here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #76 from Jonathan Druart --- (In reply to Kyle M Hall from comment #75) > Created attachment 103503 [details] [review] > Bug 15253: Fix QA script issues This patch adds 3 spaces for indentation. Looks like the existing indentation is not perfect but with this patch we make it worst. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #73 from Kyle M Hall --- Created attachment 103501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103501=edit Bug 15253: Rename syslog() to siplog() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #75 from Kyle M Hall --- Created attachment 103503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103503=edit Bug 15253: Fix QA script issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #74 from Kyle M Hall --- Created attachment 103502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103502=edit Bug 15253: Add log4perl conf updates for Debian packages * Add log4perl conf updates for Debian packages * Rename sip2.log to sip.log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Attachment #103456|0 |1 is obsolete|| Attachment #103457|0 |1 is obsolete|| Attachment #103458|0 |1 is obsolete|| Attachment #103462|0 |1 is obsolete|| --- Comment #71 from Kyle M Hall --- Created attachment 103499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103499=edit Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Signed-off-by: Liz Rea Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #72 from Kyle M Hall --- Created attachment 103500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103500=edit Bug 15253: Move subs to a new module, allow unit tests to function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added Attachment #103459|0 |1 is obsolete|| --- Comment #70 from Jonathan Druart --- Created attachment 103462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103462=edit Bug 15253: Add log4perl conf updates for Debian packages * Add log4perl conf updates for Debian packages * Rename sip2.log to sip.log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #69 from Jonathan Druart --- Kyle, that does not work, I get Too many arguments for log at /kohadevbox/koha/C4/SIP/Sip.pm line 72, near "$field_id)" There are also a lot of QA failures. Please double check and I will get back to it asap. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added Depends on||25172 --- Comment #68 from Jonathan Druart --- Patches rebased on top of bug 25172. I also modified the first patch (and its commit message) to remove the 3 lines to the log4perl config +log4perl.appender.OPAC.create_at_logtime=true +log4perl.appender.OPAC.syswrite=true +log4perl.appender.OPAC.recreate=true If we need them, that must be done on a dedicated bug report. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25172 [Bug 25172] Koha::Logger init is failing silently -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #66 from Jonathan Druart --- Created attachment 103458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103458=edit Bug 15253: Rename syslog() to log() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #67 from Jonathan Druart --- Created attachment 103459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103459=edit Bug 15253: Add log4perl conf updates for Debian packages * Add log4perl conf updates for Debian packages * Rename sip2.log to sip.log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #65 from Jonathan Druart --- Created attachment 103457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103457=edit Bug 15253: Move subs to a new module, allow unit tests to function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added Attachment #102216|0 |1 is obsolete|| Attachment #102217|0 |1 is obsolete|| Attachment #102218|0 |1 is obsolete|| Attachment #102219|0 |1 is obsolete|| --- Comment #64 from Jonathan Druart --- Created attachment 103456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103456=edit Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Signed-off-by: Liz Rea Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #63 from Jonathan Druart --- *** Bug 16303 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added Status|Signed Off |BLOCKED See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25032 --- Comment #62 from Jonathan Druart --- Hi Kyle, (In reply to Kyle M Hall from comment #61) > (In reply to Jonathan Druart from comment #60) > > (In reply to Kyle M Hall from comment #55) > > > Also modifies the log4perl.conf to lazy-open filehandles to log files, > > > so the same config can be used with log-files needing different > > > permissions. > > > > Kyle, why do you need those changes? > > Isn't the SIP server running with the same user as Koha? > > That particular code was written by Olli. If you think it should be removed > please feel free to do so! I am planning to work on the Koha::Logger module in order to improve it a bit and make it usable. I am marking this one as blocked and will get back to it when bug 25172 will move forward, I would be happy to get your feedback there btw :) I should note that we also have bug 25032 that is coming soon (and will add an api entry in the log4perl config file). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Status|BLOCKED |Signed Off --- Comment #61 from Kyle M Hall --- (In reply to Jonathan Druart from comment #60) > (In reply to Kyle M Hall from comment #55) > > Also modifies the log4perl.conf to lazy-open filehandles to log files, > > so the same config can be used with log-files needing different > > permissions. > > Kyle, why do you need those changes? > Isn't the SIP server running with the same user as Koha? That particular code was written by Olli. If you think it should be removed please feel free to do so! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #60 from Jonathan Druart --- (In reply to Kyle M Hall from comment #55) > Also modifies the log4perl.conf to lazy-open filehandles to log files, > so the same config can be used with log-files needing different > permissions. Kyle, why do you need those changes? Isn't the SIP server running with the same user as Koha? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25172 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |BLOCKED --- Comment #59 from Jonathan Druart --- There are some things in this patch that do not look wrong (about the logger). I am trying to clean a bit this area on a separate bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #58 from Kyle M Hall --- Created attachment 102219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102219=edit Bug 15253: Add log4perl conf updates for Debian packages * Add log4perl conf updates for Debian packages * Rename sip2.log to sip.log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #57 from Kyle M Hall --- Created attachment 102218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102218=edit Bug 15253: Rename syslog() to log() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #56 from Kyle M Hall --- Created attachment 102217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102217=edit Bug 15253: Move subs to a new module, allow unit tests to function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Attachment #100062|0 |1 is obsolete|| Attachment #100063|0 |1 is obsolete|| Attachment #100379|0 |1 is obsolete|| --- Comment #55 from Kyle M Hall --- Created attachment 102216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102216=edit Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Also modifies the log4perl.conf to lazy-open filehandles to log files, so the same config can be used with log-files needing different permissions. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Based on original patches by Kyle Hall and additions by Olli-Antti Kivilahti. Signed-off-by: Liz Rea Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Depends on||24905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24905 [Bug 24905] log4perl-site.conf.in missing entries for the z39.50 server -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Tomás Cohen Arazi changed: What|Removed |Added Blocks|18227 | Depends on||18227 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227 [Bug 18227] Koha::Logger utf8 handling defeating "wide characters in print" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #54 from Tomás Cohen Arazi --- (In reply to Tomás Cohen Arazi from comment #53) > Kyle, your patches are missing entries for log4perl-site.conf.in, and you > should probably make it dependent on bug 24905, and patch > koha-common.postinst as well, otherwise people with configured SIP servers > will end up seeing it broken on upgrade. Ping @kyle -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #53 from Tomás Cohen Arazi --- Kyle, your patches are missing entries for log4perl-site.conf.in, and you should probably make it dependent on bug 24905, and patch koha-common.postinst as well, otherwise people with configured SIP servers will end up seeing it broken on upgrade. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #52 from Kyle M Hall --- Created attachment 100379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100379=edit Bug 15253: Rename syslog() to log() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #51 from Kyle M Hall --- (In reply to Martin Renvoize from comment #50) > This generally seems to work.. but I'm no SIP expert and the code is hard to > follow at the best of times. > > I would love to see the actually logging statements look more like elsewhere > in Koha... this will be the third form for calling a Koha::Logger based log > and is more confusing by the fact it keeps the 'syslog' name so if someone > is keen to add more statements they may go looking for Sys::Syslog > documentation and get mislead. I would be happy to change the subroutine name. We kept it up to this point just to make fewer cuts and reduce merge conflicts! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #50 from Martin Renvoize --- This generally seems to work.. but I'm no SIP expert and the code is hard to follow at the best of times. I would love to see the actually logging statements look more like elsewhere in Koha... this will be the third form for calling a Koha::Logger based log and is more confusing by the fact it keeps the 'syslog' name so if someone is keen to add more statements they may go looking for Sys::Syslog documentation and get mislead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #49 from Kyle M Hall --- Created attachment 100063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100063=edit Bug 15253: Move subs to a new module, allow unit tests to function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Attachment #87993|0 |1 is obsolete|| Attachment #88383|0 |1 is obsolete|| --- Comment #48 from Kyle M Hall --- Created attachment 100062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100062=edit Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Also modifies the log4perl.conf to lazy-open filehandles to log files, so the same config can be used with log-files needing different permissions. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Based on original patches by Kyle Hall and additions by Olli-Antti Kivilahti. Signed-off-by: Liz Rea Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Liz Rea changed: What|Removed |Added Status|Failed QA |Patch doesn't apply --- Comment #47 from Liz Rea --- This seems to no longer apply: Switched to a new branch 'bug15253-qa' Bug 15253 - Add Koha::Logger based logging for SIP2 87993 - Bug 15253: Add Koha::Logger based logging for SIP2 88383 - Bug 15253: Move subs to a new module, allow unit tests to function Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15253: Add Koha::Logger based logging for SIP2 Using index info to reconstruct a base tree... M C4/SIP/ILS.pm M C4/SIP/ILS/Item.pm M C4/SIP/ILS/Patron.pm M C4/SIP/ILS/Transaction/Checkout.pm M C4/SIP/SIPServer.pm M C4/SIP/Sip.pm M C4/SIP/Sip/MsgType.pm M Koha/Logger.pm M etc/log4perl.conf Falling back to patching base and 3-way merge... Auto-merging etc/log4perl.conf CONFLICT (content): Merge conflict in etc/log4perl.conf Auto-merging Koha/Logger.pm Auto-merging C4/SIP/Sip/MsgType.pm Auto-merging C4/SIP/Sip.pm Auto-merging C4/SIP/SIPServer.pm CONFLICT (content): Merge conflict in C4/SIP/SIPServer.pm Auto-merging C4/SIP/ILS/Transaction/Checkout.pm Auto-merging C4/SIP/ILS/Patron.pm Auto-merging C4/SIP/ILS/Item.pm Auto-merging C4/SIP/ILS.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 15253: Add Koha::Logger based logging for SIP2 The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-15253-Add-KohaLogger-based-logging-for-SIP2-oaPOUQ.patch You have new mail in /var/mail/vagrant -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #46 from Liz Rea --- I suppose we ought to go back and test this again for 19.11 - did we ever fix the tests? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Johanna Räisä changed: What|Removed |Added Blocks||18227 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18227 [Bug 18227] Koha::Logger utf8 handling defeating "wide characters in print" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Danielle Elder changed: What|Removed |Added CC||danielle@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Nick Clemens changed: What|Removed |Added Text to go in the||RMNOTE - Reverted, remove release notes||from release notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #45 from Martin Renvoize --- Tomas has corrected the config on the koha-testing-docker side to silence the warnings for us during testing now :). However, I asked Colin to take a look at these patches one last time whilst it's on the edge of being pushed again. He noted: 1) The followup actually breaks the SIPServer (simple fix, we're missing export from the newly introduced SIP::Logger.pm) 2) It looks like we're still initialising syslogd so there's a somewhat erratic behaviour as to where log messages are being directed. 3) It's a bit misleading having a 'syslog' call that doesn't actually go to syslog.. I personally would rather go through the code in a followup and clarify that method name to not match one that many people know and assume goes to the system syslogs ;) 4) The new format is great, but it's also considerably different and so any monitoring scripts already out there in the wild will need to be completely re-written. 5) Net::Server has a bunch of internal logging which could be passed a Log4Perl logger but we're not doing that here so that logging is not being included 6) You could configure logging via the sipserver config file before.. and it looks like you still can, but that's very confusing Colins working on a followup for me to correct the export and is quickly investigating the config side to see if we can reduce some of the impacts above. I'm keen to see this continue working it way through though so please don't read all the above as a blocker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #44 from Martin Renvoize --- Comment on attachment 87993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87993 Bug 15253: Add Koha::Logger based logging for SIP2 Review of attachment 87993: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15253=87993) - ::: Koha/Logger.pm @@ +159,5 @@ > if ( $l =~ /(OPAC|INTRANET)\.filename\s*=\s*(.*)\s*$/i ) { > > # we only check the two default logfiles, skipping additional > ones > +if ( !-w $2 ) { > +warn "Log file $2 is not writable!"; It's this line that's fireing.. I think we must have been talking at cross purposes. Because koha-testing-docker doesn't have a writable logdir by default if you apply this patch and then run any tests that happen to use a module that uses Koha::Logger you now spam the screen with the above warning. It's just noise rather than a failure.. but it can make the test results rather cumbersome to read.. that's what I'm getting at. I think Tomas is now on the case from the koha-testing-docker side. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #43 from Kyle M Hall --- (In reply to Martin Renvoize from comment #42) > I'm confused.. was that last patch a followup to silence the spurious > warnings on koha-testing-docker after this bug was applied? > > I get the feeling we should probably make the logpath writable in > koha-testing-docker as a resolution (I like being told loudly that logging > isn't working, which this bug actually introduced). > > Either way.. the followup doesn't appear to resolve the problem. The followup match stops the unit tests from failing and resolves circular dependencies. Can you post an example of the warnings you are seeing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Failed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #42 from Martin Renvoize --- I'm confused.. was that last patch a followup to silence the spurious warnings on koha-testing-docker after this bug was applied? I get the feeling we should probably make the logpath writable in koha-testing-docker as a resolution (I like being told loudly that logging isn't working, which this bug actually introduced). Either way.. the followup doesn't appear to resolve the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #41 from Kyle M Hall --- Created attachment 88383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88383=edit Bug 15253: Move subs to a new module, allow unit tests to function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #40 from Nick Clemens --- This broke a lot of tests, some routines need to be moved or adjusted to prevent this. Reverted from master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Nick Clemens changed: What|Removed |Added Status|Pushed to Master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #39 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Chris Cormack changed: What|Removed |Added Attachment #86574|0 |1 is obsolete|| --- Comment #38 from Chris Cormack --- Created attachment 87993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87993=edit Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Also modifies the log4perl.conf to lazy-open filehandles to log files, so the same config can be used with log-files needing different permissions. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Based on original patches by Kyle Hall and additions by Olli-Antti Kivilahti. Signed-off-by: Liz Rea Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Liz Rea changed: What|Removed |Added Attachment #86573|0 |1 is obsolete|| --- Comment #37 from Liz Rea --- Created attachment 86574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86574=edit Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Also modifies the log4perl.conf to lazy-open filehandles to log files, so the same config can be used with log-files needing different permissions. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Based on original patches by Kyle Hall and additions by Olli-Antti Kivilahti. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/