[Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #6 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #5 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #4 from Marcel de Rooy  ---
Great test plan :) And the speed is back !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #48633|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 48676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48676=edit
Bug 15968: Unnecessary loop in C4::Templates

From C4::Templates::output

 # add variables set via param to $vars for processing
 for my $k ( keys %{ $self->{VARS} } ) {
 $vars->{$k} = $self->{VARS}->{$k};
 }

This loop is not necessary, we could do the same with

 $vars = { %$vars, %{ $self->{VARS} } };

After a quick benchmark, it gains 100 microseconds when we pass 170 vars
to the template.

Test plan:
Do some clicks on the interface, everything should be ok.

Signed-off-by: Frédéric Demians 
  Perl idiosyncratic way of merging hash, clearer, if not quicker (not
  verified)

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #48617|0   |1
is obsolete||

--- Comment #2 from Frédéric Demians  ---
Created attachment 48633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48633=edit
Bug 15968: Unnecessary loop in C4::Templates

From C4::Templates::output

 # add variables set via param to $vars for processing
 for my $k ( keys %{ $self->{VARS} } ) {
 $vars->{$k} = $self->{VARS}->{$k};
 }

This loop is not necessary, we could do the same with

 $vars = { %$vars, %{ $self->{VARS} } };

After a quick benchmark, it gains 100 microseconds when we pass 170 vars
to the template.

Test plan:
Do some clicks on the interface, everything should be ok.

Signed-off-by: Frédéric Demians 
  Perl idiosyncratic way of merging hash, clearer, if not quicker (not
  verified)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15342


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342
[Bug 15342] Performance 3.22 - Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968

--- Comment #1 from Jonathan Druart  
---
Created attachment 48617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48617=edit
Bug 15968: Unnecessary loop in C4::Templates

>From C4::Templates::output

 # add variables set via param to $vars for processing
 for my $k ( keys %{ $self->{VARS} } ) {
 $vars->{$k} = $self->{VARS}->{$k};
 }

This loop is not necessary, we could do the same with

 $vars = { %$vars, %{ $self->{VARS} } };

After a quick benchmark, it gains 100 microseconds when we pass 170 vars to the
template.

Test plan:
Do some clicks on the interface, everything should be ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/