subject:"\[Koha\-bugs\] \[Bug 16686\] Fix \"Item in transit from since\" in Holds tab"

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2020-09-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Martin Renvoize  changed:

   What|Removed |Added

   Target Milestone|Oldversions |---
 Blocks||24295


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295
[Bug 24295] C4::Circulation::GetTransfers should be removed, use
Koha::Item->get_transfer instead
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-09-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr
 Status|Pushed to Master|Pushed to Stable

--- Comment #36 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-09-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #35 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #34 from Kyle M Hall  ---
Found the bug, unrelated. Fixed on followup to bug 16272.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #33 from Kyle M Hall  ---
Items.t fails if SearchEngine is set to Elastic:

prove t/db_dependent/Koha/Items.t
t/db_dependent/Koha/Items.t .. 1/5  problem with :564 : :1: parser error :
Start tag expected, '<' not found
tAw
^

tAw at /home/vagrant/kohaclone/C4/Biblio.pm line 1339.
# Looks like you planned 3 tests but ran 1.
Can't call method "field" on an undefined value at
/home/vagrant/kohaclone/Koha/ElasticSearch/Indexer.pm line 180.
# Looks like your test exited with 255 just after 4.
t/db_dependent/Koha/Items.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/5 subtests

Test Summary Report
---
t/db_dependent/Koha/Items.t (Wstat: 65280 Tests: 4 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 5 tests but ran 4.
Files=1, Tests=4,  1 wallclock secs ( 0.02 usr  0.00 sys +  1.30 cusr  0.13
csys =  1.45 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Nick Clemens  changed:

   What|Removed |Added

  Attachment #54130|0   |1
is obsolete||

--- Comment #31 from Nick Clemens  ---
Created attachment 54394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54394=edit
Bug 16686: Add Koha::Object based class for Koha::Item::Transfer[s]

Signed-off-by: Marc 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Nick Clemens  changed:

   What|Removed |Added

  Attachment #54131|0   |1
is obsolete||

--- Comment #32 from Nick Clemens  ---
Created attachment 54395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54395=edit
Bug 16686: Add test for Koha::Item::Transfer[s] and Koha::Item->get_transfer

Signed-off-by: Marc 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Nick Clemens  changed:

   What|Removed |Added

  Attachment #54128|0   |1
is obsolete||

--- Comment #29 from Nick Clemens  ---
Created attachment 54392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54392=edit
Bug 16686: Fix "Item in transit from since" in Holds tab

POC, tests needed.

Alternative patch works for me.
Signed-off-by: Marc Véron 

Signed-off-by: Marc 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Nick Clemens  changed:

   What|Removed |Added

  Attachment #54129|0   |1
is obsolete||

--- Comment #30 from Nick Clemens  ---
Created attachment 54393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54393=edit
Bug 16686: Rename the transfer method to get_transfer

Signed-off-by: Marc 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc Véron  changed:

   What|Removed |Added

  Attachment #53227|0   |1
is obsolete||

--- Comment #28 from Marc Véron  ---
Created attachment 54131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54131=edit
Bug 16686: Add test for Koha::Item::Transfer[s] and Koha::Item->get_transfer

Signed-off-by: Marc 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc Véron  changed:

   What|Removed |Added

  Attachment #53191|0   |1
is obsolete||

--- Comment #27 from Marc Véron  ---
Created attachment 54130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54130=edit
Bug 16686: Add Koha::Object based class for Koha::Item::Transfer[s]

Signed-off-by: Marc 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc Véron  changed:

   What|Removed |Added

  Attachment #53190|0   |1
is obsolete||

--- Comment #26 from Marc Véron  ---
Created attachment 54129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54129=edit
Bug 16686: Rename the transfer method to get_transfer

Signed-off-by: Marc 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc Véron  changed:

   What|Removed |Added

  Attachment #53084|0   |1
is obsolete||

--- Comment #25 from Marc Véron  ---
Created attachment 54128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54128=edit
Bug 16686: Fix "Item in transit from since" in Holds tab

POC, tests needed.

Alternative patch works for me.
Signed-off-by: Marc Véron 

Signed-off-by: Marc 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #24 from Marc Véron  ---
Test passes now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-08-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff
   Assignee|k...@bywatersolutions.com   |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-07-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #23 from Jonathan Druart  
---
(In reply to Marc Véron from comment #21)
> (In reply to Jonathan Druart from comment #19)
> > Created attachment 53192 [details] [review] [review]
> > Bug 16686: Add test for Koha::Item::Transfer[s] and Koha::Item->get_transfer
> 
> Hi Jonathan, I think there is a typo in the file name: Tranfers.t (schould
> be Transfers.t)
> If I run the test, I get a syntax error on line 37 (similar typo) and other
> errors.

Oops, sorry about that. I did not finish to write these tests!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-07-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53192|0   |1
is obsolete||

--- Comment #22 from Jonathan Druart  
---
Created attachment 53227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53227=edit
Bug 16686: Add test for Koha::Item::Transfer[s] and Koha::Item->get_transfer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-07-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #21 from Marc Véron  ---
(In reply to Jonathan Druart from comment #19)
> Created attachment 53192 [details] [review]
> Bug 16686: Add test for Koha::Item::Transfer[s] and Koha::Item->get_transfer

Hi Jonathan, I think there is a typo in the file name: Tranfers.t (schould be
Transfers.t)
If I run the test, I get a syntax error on line 37 (similar typo) and other
errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #20 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #16)
> (In reply to Jonathan Druart from comment #14)
> > Kyle, could you have a look at this counter-patch?
> > It seems easier to use the DBIC relationship than to create 3 new methods.
> 
> While I agree, I think it adds confusion. The method name 'transfer' is a
> verb, so it sounds like you would call $item->transfer() to initiate a
> transfer. Can you change the method name to get_latest_transfer or something
> like that?

Indeed, good idea!
I have chosen "get_transfer" which returns the current transfer, or undef if
the item is not in transit.

> I'm also a bit reticent about having a Koha Object return a DBIC object.
> Would you create Koha::Item::Transfer(s) and return that? It would also
> avoid a second db query just to get the branch name.

Done, but I am not sure to understand how it will avoid the second query. I now
use the Branches TT plugin to retrieve the branch name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53050|0   |1
is obsolete||
  Attachment #53053|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart  
---
Created attachment 53190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53190=edit
Bug 16686: Rename the transfer method to get_transfer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #19 from Jonathan Druart  
---
Created attachment 53192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53192=edit
Bug 16686: Add test for Koha::Item::Transfer[s] and Koha::Item->get_transfer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #18 from Jonathan Druart  
---
Created attachment 53191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53191=edit
Bug 16686: Add Koha::Object based class for Koha::Item::Transfer[s]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #16 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #14)
> Kyle, could you have a look at this counter-patch?
> It seems easier to use the DBIC relationship than to create 3 new methods.

While I agree, I think it adds confusion. The method name 'transfer' is a verb,
so it sounds like you would call $item->transfer() to initiate a transfer. Can
you change the method name to get_latest_transfer or something like that?

I'm also a bit reticent about having a Koha Object return a DBIC object. Would
you create Koha::Item::Transfer(s) and return that? It would also avoid a
second db query just to get the branch name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-07-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #15 from Marc Véron  ---
Created attachment 53084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53084=edit
Bug 16686: Fix "Item in transit from since" in Holds tab

POC, tests needed.

Alternative patch works for me.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-07-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #14 from Jonathan Druart  
---
Kyle, could you have a look at this counter-patch?
It seems easier to use the DBIC relationship than to create 3 new methods.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-07-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #13 from Jonathan Druart  
---
Created attachment 53053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53053=edit
[ALT] Bug 16686: Fix "Item in transit from since" in Holds tab

POC, tests needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-07-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-07-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc Véron  changed:

   What|Removed |Added

  Attachment #52898|0   |1
is obsolete||

--- Comment #12 from Marc Véron  ---
Created attachment 53050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53050=edit
Bug 16686 - Fix "Item in transit from since" in Holds tab

"From branch" and date do not show up in patron's "Holds" tab: "Item in
transit from since"

OPAC log:  opac-user.pl: No method frombranch! at
/usr/share/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
line 607

Test Plan:
1) Apply this patch
2) Create an in transit hold
3) Not the from library is displayed

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52183|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall  ---
Created attachment 52898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52898=edit
Bug 16686 - Fix "Item in transit from since" in Holds tab

"From branch" and date do not show up in patron's "Holds" tab: "Item in
transit from since"

OPAC log:  opac-user.pl: No method frombranch! at
/usr/share/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
line 607

Test Plan:
1) Apply this patch
2) Create an in transit hold
3) Not the from library is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #10 from Katrin Fischer  ---
Ran into this too - please fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #9 from Marc Véron  ---
Re-tested. I can no longer log-in to the OPAC with a patron who has the hold on
an item in transit.

[Fri Jun 17 14:16:40 2016] [error] [client 192.168.1.35] [Fri Jun 17 14:16:40
2016] opac-user.pl: Use of inherited AUTOLOAD for non-method
Koha::Item::GetTransfers() is deprecated at /usr/share/kohaclone/Koha/Item.pm
line 123., referer: http://192.168.1.35/
[Fri Jun 17 14:16:40 2016] [error] [client 192.168.1.35] [Fri Jun 17 14:16:40
2016] opac-user.pl: Template process failed: undef error - Can't call method
"_columns" without a package or object reference at
/usr/share/kohaclone/Koha/Object.pm line 266., referer: http://192.168.1.35/

Without patch, I can log in with this patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #8 from Marc Véron  ---
Now, if I log in to the OPAC with the user who triggers the transit-message, I
get:
Template process failed: undef error - Can't call method "_columns" without a
package or object reference at /usr/share/kohaclone/Koha/Object.pm line 266.


OPAC log:

[Wed Jun 08 16:13:10 2016] [error] [client 192.168.1.20] [Wed Jun  8 16:13:10
2016] opac-user.pl: The given value does not seem to be interpretable as a
Boolean value at /usr/share/kohaclone/C4/Context.pm line 545, referer:
http://192.168.1.35/cgi-bin/koha/opac-main.pl?logout.x=1

[Wed Jun 08 16:13:11 2016] [error] [client 192.168.1.20] [Wed Jun  8 16:13:11
2016] opac-user.pl: Use of inherited AUTOLOAD for non-method
Koha::Item::GetTransfers() is deprecated at /usr/share/kohaclone/Koha/Item.pm
line 123., referer: http://192.168.1.35/cgi-bin/koha/opac-main.pl?logout.x=1

[Wed Jun 08 16:13:11 2016] [error] [client 192.168.1.20] [Wed Jun  8 16:13:11
2016] opac-user.pl: Template process failed: undef error - Can't call method
"_columns" without a package or object reference at
/usr/share/kohaclone/Koha/Object.pm line 266., referer:
http://192.168.1.35/cgi-bin/koha/opac-main.pl?logout.x=1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #7 from Kyle M Hall  ---
(In reply to Marc Véron from comment #5)
> With patch I get a lot of errors (even on OPAC main page or on Staff login
> page):

It looks like some unwanted additions got merged into my patch. Please try this
new version! Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52164|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 52183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52183=edit
Bug 16686 - Fix "Item in transit from since" in Holds tab

"From branch" and date do not show up in patron's "Holds" tab: "Item in
transit from since"

OPAC log:  opac-user.pl: No method frombranch! at
/usr/share/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
line 607

Test Plan:
1) Apply this patch
2) Create an in transit hold
3) Not the from library is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #5 from Marc Véron  ---
With patch I get a lot of errors (even on OPAC main page or on Staff login
page):

syntax error at /usr/share/kohaclone/Koha/Item.pm line 101, near "unless
defined"
syntax error at /usr/share/kohaclone/Koha/Item.pm line 106, near "}"
Global symbol "$self" requires explicit package name at
/usr/share/kohaclone/Koha/Item.pm line 108.
Can't use global @_ in "my" at /usr/share/kohaclone/Koha/Item.pm line 117, near
"= @_"
Global symbol "$self" requires explicit package name at
/usr/share/kohaclone/Koha/Item.pm line 119.
Global symbol "$self" requires explicit package name at
/usr/share/kohaclone/Koha/Item.pm line 119.
syntax error at /usr/share/kohaclone/Koha/Item.pm line 130, near "}"
Can't use global @_ in "my" at /usr/share/kohaclone/Koha/Item.pm line 139, near
"= @_"
syntax error at /usr/share/kohaclone/Koha/Item.pm line 144, near "}"
Can't use global @_ in "my" at /usr/share/kohaclone/Koha/Item.pm line 153, near
"= @_"
/usr/share/kohaclone/Koha/Item.pm has too many errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52163|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 52164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52164=edit
Bug 16686 - Fix "Item in transit from since" in Holds tab

"From branch" and date do not show up in patron's "Holds" tab: "Item in
transit from since"

OPAC log:  opac-user.pl: No method frombranch! at
/usr/share/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
line 607

Test Plan:
1) Apply this patch
2) Create an in transit hold
3) Not the from library is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52157|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 52163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52163=edit
Bug 16686 - Fix "Item in transit from since" in Holds tab

"From branch" and date do not show up in patron's "Holds" tab: "Item in
transit from since"

OPAC log:  opac-user.pl: No method frombranch! at
/usr/share/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
line 607

Test Plan:
1) Apply this patch
2) Create an in transit hold
3) Not the from library is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

--- Comment #1 from Kyle M Hall  ---
Created attachment 52157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52157=edit
Bug 16686 - Fix "Item in transit from since" in Holds tab

"From branch" and date do not show up in patron's "Holds" tab: "Item in
transit from since"

OPAC log:  opac-user.pl: No method frombranch! at
/usr/share/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
line 607

Test Plan:
1) Apply this patch
2) Create an in transit hold
3) Not the from library is displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #2 from Kyle M Hall  ---
New methods should probably have unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

2016-06-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc Véron  changed:

   What|Removed |Added

 Depends on||13918
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16680


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918
[Bug 13918] Add waiting expiration date to opac list of holds for user
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

47 matches

Mail list logo