[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Mason James changed: What|Removed |Added Blocks||16758 Depends on|16758 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 [Bug 16758] Caching issues in scripts running in daemon mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Mason James changed: What|Removed |Added Blocks|16758 | Depends on||16758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 [Bug 16758] Caching issues in scripts running in daemon mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Mason James changed: What|Removed |Added Blocks||16758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758 [Bug 16758] Caching issues in scripts running in daemon mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Zeno Tajoli changed: What|Removed |Added Text to go in the|Now we have defined several |Now we have defined several release notes|namespaces for our cache|namespaces for our cache |system. |system. Instance sysprefs, |Instance sysprefs, |koha conf (koha-conf.xml) |koha conf (koha-conf.xml) |and unit tests are defined |and unit tests |in a separate namespace. |are defined |This permit to: launch the |in a separate namespace.|tests without interfering |This permit to: launch the |with other cache values; |tests without interfering |flush the sysprefs cache |with other cache values;|without flushing all other |flush the sysprefs cache|values. |without flushing all other |About update: there |values |are changes on koha.psgi, ||check your situation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Zeno Tajoli changed: What|Removed |Added Text to go in the||Now we have defined several release notes||namespaces for our cache ||system. ||Instance sysprefs, ||koha conf (koha-conf.xml) ||and unit tests ||are defined ||in a separate namespace. ||This permit to: launch the ||tests without interfering ||with other cache values; ||flush the sysprefs cache ||without flushing all other ||values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Mason James changed: What|Removed |Added Status|Pushed to Stable|Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Mason James changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||m...@kohaaloha.com --- Comment #31 from Mason James --- enhancement, passing for 16.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #30 from Frédéric Demians --- (In reply to Jonathan Druart from comment #29) > Note for RMaints: Do not backport it (at least for now)! Thanks for this note. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 --- Comment #29 from Jonathan Druart --- Note for RMaints: Do not backport it (at least for now)! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 --- Comment #28 from Kyle M Hall --- Created attachment 55341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55341&action=edit Bug 17189 [QA Followup] - Missing $ on $key var for unsafe variant Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #27 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Tomás Cohen Arazi changed: What|Removed |Added Attachment #55302|0 |1 is obsolete|| --- Comment #26 from Tomás Cohen Arazi --- Created attachment 55321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55321&action=edit Bug 17189: Use Koha::Caches instead of Koha::Cache in Koha::MetaSearcher Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=11921 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Tomás Cohen Arazi changed: What|Removed |Added Attachment #55301|0 |1 is obsolete|| --- Comment #25 from Tomás Cohen Arazi --- Created attachment 55320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55320&action=edit Bug 17189: Replace occurrences of 'use Koha::Cache' Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=11921 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Tomás Cohen Arazi changed: What|Removed |Added Attachment #55292|0 |1 is obsolete|| --- Comment #24 from Tomás Cohen Arazi --- Created attachment 55319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55319&action=edit Bug 17189: Use delete to flush a L1 cache namespace Signed-off-by: Jacek Ablewicz Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=11921 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Tomás Cohen Arazi changed: What|Removed |Added Attachment #55286|0 |1 is obsolete|| --- Comment #23 from Tomás Cohen Arazi --- Created attachment 55318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55318&action=edit Bug 17189: Add the ability to define several memcached namespaces - replace existing occurrences s/Koha::Cache->get_instance/Koha::Caches->get_instance Signed-off-by: Jacek Ablewicz Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=11921 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Tomás Cohen Arazi changed: What|Removed |Added Attachment #55284|0 |1 is obsolete|| --- Comment #21 from Tomás Cohen Arazi --- Created attachment 55316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55316&action=edit Bug 17189: Add the ability to define several memcached namespaces - tests Signed-off-by: Jacek Ablewicz Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=11921 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Tomás Cohen Arazi changed: What|Removed |Added Attachment #55285|0 |1 is obsolete|| --- Comment #22 from Tomás Cohen Arazi --- Created attachment 55317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55317&action=edit Bug 17189: Add the ability to define several memcached namespaces - Koha::Caches We need to define several namespaces for our cache system. For instance sysprefs, koha conf (koha-conf.xml) and unit tests should be defined in a separate namespace. This will permit to - launch the tests without interfering with other cache values - and flush the sysprefs cache without flushing all other values To do so, we need to store different Koha::Cache objects at a package level. That's why this patch adds a new Koha::Caches module. FIXME: There is an architecture problem here: the L1 cache should be defined in Koha::Cache Signed-off-by: Jacek Ablewicz Signed-off-by: Tomas Cohen Arazi https://bugs.koha-community.org/show_bug.cgi?id=11921 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Tomás Cohen Arazi changed: What|Removed |Added Blocks||17261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17261 [Bug 17261] Add memcached configuration info to about.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Jacek Ablewicz changed: What|Removed |Added Attachment #55295|0 |1 is obsolete|| --- Comment #20 from Jacek Ablewicz --- Created attachment 55302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55302&action=edit Bug 17189: Use Koha::Caches instead of Koha::Cache in Koha::MetaSearcher Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Jacek Ablewicz changed: What|Removed |Added Attachment #55294|0 |1 is obsolete|| --- Comment #19 from Jacek Ablewicz --- Created attachment 55301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55301&action=edit Bug 17189: Replace occurrences of 'use Koha::Cache' Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 --- Comment #18 from Jonathan Druart --- Created attachment 55295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55295&action=edit Bug 17189: Use Koha::Caches instead of Koha::Cache in Koha::MetaSearcher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 --- Comment #17 from Jonathan Druart --- It seems that Koha/MetaSearcher.pm missed the train. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Jonathan Druart changed: What|Removed |Added Attachment #55293|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 55294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55294&action=edit Bug 17189: Replace occurrences of 'use Koha::Cache' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 --- Comment #15 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #12) > There are many occurrences of 'use Koha::Cache;' left in the code (not > replaced by 'use Koha::Caches') - lack of 'use Koha::Caches' shouldn't > really be a problem in most places (C4::Context is usually loaded by, well, > everything, and it loads Koha::Caches), but some cleanup of those remainings > probably wouldn't hurt ;) Indeed, done! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 --- Comment #14 from Jonathan Druart --- Created attachment 55293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55293&action=edit Bug 17189: Replace occurrences of 'use Koha::Cache' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Jacek Ablewicz changed: What|Removed |Added Attachment #55291|0 |1 is obsolete|| --- Comment #13 from Jacek Ablewicz --- Created attachment 55292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55292&action=edit Bug 17189: Use delete to flush a L1 cache namespace Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 --- Comment #12 from Jacek Ablewicz --- There are many occurrences of 'use Koha::Cache;' left in the code (not replaced by 'use Koha::Caches') - lack of 'use Koha::Caches' shouldn't really be a problem in most places (C4::Context is usually loaded by, well, everything, and it loads Koha::Caches), but some cleanup of those remainings probably wouldn't hurt ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189
--- Comment #11 from Jonathan Druart
---
(In reply to Jacek Ablewicz from comment #6)
> sub flush_L1_cache {
> my( $self ) = @_;
> -%L1_cache = ();
> +$L1_cache{$self->{namespace}} = ();
> }
>
> It's setting $L1_cache{'whatever'} to undef, not sure if that's intentional?
> Probably not an issue, but I haven't done comprehensive tests of this part,
> it's only really used under plack. Something like
>
> %{ $L1_cache{$self->{namespace}} } = ();
>
> or
>
> delete $L1_cache{$self->{namespace}};
>
> would be more predictable maybe?
Definitely, thanks for catching it up!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 --- Comment #10 from Jonathan Druart --- Created attachment 55291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55291&action=edit Bug 17189: Use delete to flush a L1 cache namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Jacek Ablewicz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Jacek Ablewicz changed: What|Removed |Added Attachment #54817|0 |1 is obsolete|| --- Comment #9 from Jacek Ablewicz --- Created attachment 55286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55286&action=edit Bug 17189: Add the ability to define several memcached namespaces - replace existing occurrences s/Koha::Cache->get_instance/Koha::Caches->get_instance Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Jacek Ablewicz changed: What|Removed |Added Attachment #54815|0 |1 is obsolete|| --- Comment #7 from Jacek Ablewicz --- Created attachment 55284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55284&action=edit Bug 17189: Add the ability to define several memcached namespaces - tests Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Jacek Ablewicz changed: What|Removed |Added Attachment #54816|0 |1 is obsolete|| --- Comment #8 from Jacek Ablewicz --- Created attachment 55285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55285&action=edit Bug 17189: Add the ability to define several memcached namespaces - Koha::Caches We need to define several namespaces for our cache system. For instance sysprefs, koha conf (koha-conf.xml) and unit tests should be defined in a separate namespace. This will permit to - launch the tests without interfering with other cache values - and flush the sysprefs cache without flushing all other values To do so, we need to store different Koha::Cache objects at a package level. That's why this patch adds a new Koha::Caches module. FIXME: There is an architecture problem here: the L1 cache should be defined in Koha::Cache Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189
--- Comment #6 from Jacek Ablewicz ---
sub flush_L1_cache {
my( $self ) = @_;
-%L1_cache = ();
+$L1_cache{$self->{namespace}} = ();
}
It's setting $L1_cache{'whatever'} to undef, not sure if that's intentional?
Probably not an issue, but I haven't done comprehensive tests of this part,
it's only really used under plack. Something like
%{ $L1_cache{$self->{namespace}} } = ();
or
delete $L1_cache{$self->{namespace}};
would be more predictable maybe?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 --- Comment #5 from Jacek Ablewicz --- (In reply to Jacek Ablewicz from comment #4) > Hmm, IMO most serious limitation of this approach/implementation is that > having separate cache object instances for 1) sysprefs 2) config and 3) > everything else will result in opening 3 different connections to (the very > same) memcached daemon per script/plack worker. Under plack, the 2nd > connection will be used just once. OTOH - those 3 connections to memcached server do not seem to have any significant practical consequences, I did some tests and it's only 150-200 microseconds per connection. In fact it's probably a bit faster then unpatched version (there are 2 separate connections being made in unpatched master) if the Cache::Memcache loading time is taken into account. Memcached is event driven (so the added memory footprint on it's side is negligible, forking not involved) and it is taking the increased burden surprisingly (extremely!) well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 --- Comment #4 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #2) > We need to define several namespaces for our cache system. > For instance sysprefs, koha conf (koha-conf.xml) and unit tests > should be defined in a separate namespace. Hmm, IMO most serious limitation of this approach/implementation is that having separate cache object instances for 1) sysprefs 2) config and 3) everything else will result in opening 3 different connections to (the very same) memcached daemon per script/plack worker. Under plack, the 2nd connection will be used just once. IMO separate object instance (& connection) for sysprefs would have rather limited usability too > This will permit to > - and flush the sysprefs cache without flushing all other values because it will allow to flush only L1 syspref cache selectively, while no such thing would be possible for L2/upstream cache. Unfortunately, with memcached, it's either a flush of the given key or the whole cache flush (all keys in all namespaces & subnamespaces). In memcached, keys from different namespaces are not distinguishable in any way, and deleting keys by wildcard is not possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Jonathan Druart changed: What|Removed |Added Blocks||11921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11921 [Bug 11921] memcached configuration should be moved back to koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Jonathan Druart changed: What|Removed |Added Blocks||16579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16579 [Bug 16579] Use separate memcached namespace for caching koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 --- Comment #2 from Jonathan Druart --- Created attachment 54816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54816&action=edit Bug 17189: Add the ability to define several memcached namespaces - Koha::Caches We need to define several namespaces for our cache system. For instance sysprefs, koha conf (koha-conf.xml) and unit tests should be defined in a separate namespace. This will permit to - launch the tests without interfering with other cache values - and flush the sysprefs cache without flushing all other values To do so, we need to store different Koha::Cache objects at a package level. That's why this patch adds a new Koha::Caches module. FIXME: There is an architecture problem here: the L1 cache should be defined in Koha::Cache -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 --- Comment #1 from Jonathan Druart --- Created attachment 54815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54815&action=edit Bug 17189: Add the ability to define several memcached namespaces - tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 --- Comment #3 from Jonathan Druart --- Created attachment 54817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54817&action=edit Bug 17189: Add the ability to define several memcached namespaces - replace existing occurrences s/Koha::Cache->get_instance/Koha::Caches->get_instance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17189] Add the ability to define several memcached namespaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
