[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #52 from Jonathan Druart--- For information: I have added a "modify selected serials" link on bug 18426, but on the other screen (subscription search result) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queunechanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #51 from Séverine Queune --- (In reply to Owen Leonard from comment #47) > - Confirm that the "Delete selected" button works correctly. When serials of several years exist, only the button of the first tab works, not the buttons "Delete selected issues" displayed on the tabs of previous years. The other buttons work as expected on all tabs. Except that point, the rest of the patch works correctly, but I prefer not sign it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Roch D'Amourchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #50 from Roch D'Amour--- Created attachment 74359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74359=edit Bug 17674: Remove delete related item checkbox when no items is available When the number of items available is 0, the confirmation dialog still ask is you also want to delete related items. This patch remove the checkbox in the confirmation dialog when the number of related items is 0. To test: - Try to delete some serials that has items available, the confirmation dialog does not ask if you want to delete related items since there are none. - Try to delete some serials which has items avaible. The confirmation dialog should show a checkbox and ask if you want to delete related items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #49 from Owen Leonard--- (In reply to Roch D'Amour from comment #48) > Hi Owen, did you forget to switch this back to "Need signoff"? I think this issue is still unresolved: > 2) I think if the serial is not set up to create items, we should not ask. > Or if the number of items is 0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Roch D'Amourchanged: What|Removed |Added CC||roch.dam...@inlibro.com --- Comment #48 from Roch D'Amour --- Hi Owen, did you forget to switch this back to "Need signoff"? It seems like your patch cover everything said Kat, yet the bug's status is still failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #47 from Owen Leonard--- Created attachment 74318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74318=edit Bug 17674 (follow-up) Fix some HTML and JS inconsistencies This patch makes some HTML and JS changes to make the template more consistent with coding guidelines and other similar interfaces. - The confirmation dialog is now below the heading. Buttons are styled to match others like them. The layout of messages hopefully makes it a little more clear. - The "delete selected" event handler has been moved from an "onclick" attribute into the
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #46 from Katrin Fischer --- Starting with a code review, patches apply, QA script passes: 1) Translatability issue + Are you sure delete [% serialnumber %] selected serials Please rethink this sentence. The should not be used within a sentence as it will break this into several strings. I think it's not necessary here. Also sentence reads a bit strangely? :) Similar here: Number of items available : [% countitems %] That went well! Now testing: 2) I think if the serial is not set up to create items, we should not ask. Or if the number of items is 0. 3) A checkbox for deleting items would be a little nicer than the radio button. Could be fixed later, not blocker. 4) Number of items available : 0 No space there in English: available: 5) The appearing yellow dialogue pushes down the navigation bar on the right. Please check. Mostly tiny stuff, this looks quite good. Can you provide a quick follow-up and switch back to signed-off please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #45 from Séverine Queune--- Works as described. Thanks to all of you for this new feature ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #44 from Marjorie Barry-Vila--- (In reply to Séverine Queune from comment #37) > My bad, I confused myself between "serial" and "subscription" so I expected > a different feature and was looking at the wrong place ! (It's been a hard > hackfest week in Marseille ^^). > Thanks a lot Marjorie ! I 'm going to test it. Great! Thanks for testing! Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queunechanged: What|Removed |Added Attachment #71869|0 |1 is obsolete|| --- Comment #42 from Séverine Queune --- Created attachment 73039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73039=edit Bug 17674 - Adapting Serials.t to the namespace change Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queunechanged: What|Removed |Added Attachment #71868|0 |1 is obsolete|| --- Comment #41 from Séverine Queune --- Created attachment 73038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73038=edit Bug 17674 - Move subroutine GetSerialItemsInformations to Koha/Serials.pm Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queunechanged: What|Removed |Added Attachment #72985|0 |1 is obsolete|| --- Comment #43 from Séverine Queune --- Created attachment 73040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73040=edit Bug 17674 - Renamed GetSerialItemsInformations to get_serial_items_count and use new OOP logic Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queunechanged: What|Removed |Added Attachment #71867|0 |1 is obsolete|| --- Comment #40 from Séverine Queune --- Created attachment 73037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73037=edit Bug 17674 - Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=17674 Signed-off-by: Sonia BOUIS Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queunechanged: What|Removed |Added Attachment #71865|0 |1 is obsolete|| --- Comment #38 from Séverine Queune --- Created attachment 73035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73035=edit Bug 17674 - Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queunechanged: What|Removed |Added Attachment #71866|0 |1 is obsolete|| --- Comment #39 from Séverine Queune --- Created attachment 73036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73036=edit Bug 17674 - Fix problem tabs Signed-off-by: Sonia BOUIS Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queunechanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #37 from Séverine Queune--- My bad, I confused myself between "serial" and "subscription" so I expected a different feature and was looking at the wrong place ! (It's been a hard hackfest week in Marseille ^^). Thanks a lot Marjorie ! I 'm going to test it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #36 from Marjorie Barry-Vila--- Created attachment 73032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73032=edit remove selected issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #35 from Marjorie Barry-Vila--- (In reply to Séverine Queune from comment #34) > No conflict when applying the patch but I couldn't find where to find the > new feature. > Is it supposed to be on the /cgi-bin/koha/serials/serials-search.pl ? > Or a new menu is created on Tools ? Hi Severine, You have to go on serials-collection.pl?subscriptionid=?, you will see a button "Remove selected issue". See attached image. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Séverine Queunechanged: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #34 from Séverine Queune --- No conflict when applying the patch but I couldn't find where to find the new feature. Is it supposed to be on the /cgi-bin/koha/serials/serials-search.pl ? Or a new menu is created on Tools ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #33 from Roch D'Amour--- Created attachment 72985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72985=edit Bug 17674 - Renamed GetSerialItemsInformations to get_serial_items_count and use new OOP logic Removed SQl and use snake_case. Same test plan as before. Might also want to test t/db_dependent/Serials.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Roch D'Amourchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Jonathan Druartchanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #32 from Jonathan Druart --- 1. You are not supposed to write SQL queries 2. You should read how Koha::Object-based objects work 3. method's names must be snake_case In short: forget the former C4 logic and rethink your new method. I can help you if you are stuck. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #31 from Charles Farmer--- Rebased once again on the current master. This time, though, a new patch was submitted to make sure our subtests respected the new namespace, and that no items were created without a biblioitemnumber. Just one more signoff to go. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Charles Farmerchanged: What|Removed |Added Attachment #69978|0 |1 is obsolete|| --- Comment #28 from Charles Farmer --- Created attachment 71867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71867=edit Bug 17674 - Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=17674 Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #30 from Charles Farmer--- Created attachment 71869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71869=edit Bug 17674 - Adapting Serials.t to the namespace change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Charles Farmerchanged: What|Removed |Added Attachment #69979|0 |1 is obsolete|| --- Comment #29 from Charles Farmer --- Created attachment 71868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71868=edit Bug 17674 - Move subroutine GetSerialItemsInformations to Koha/Serials.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Charles Farmerchanged: What|Removed |Added Attachment #69976|0 |1 is obsolete|| --- Comment #26 from Charles Farmer --- Created attachment 71865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71865=edit Bug 17674 - Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Charles Farmerchanged: What|Removed |Added Attachment #69977|0 |1 is obsolete|| --- Comment #27 from Charles Farmer --- Created attachment 71866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71866=edit Bug 17674 - Fix problem tabs Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Charles Farmerchanged: What|Removed |Added CC||charles.far...@inlibro.com --- Comment #25 from Charles Farmer --- Had conflicting git apply, rebased the patch on the current master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Charles Farmerchanged: What|Removed |Added Attachment #69011|0 |1 is obsolete|| --- Comment #23 from Charles Farmer --- Created attachment 69978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69978=edit Bug 17674 - Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=17674 Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Charles Farmerchanged: What|Removed |Added Attachment #69013|0 |1 is obsolete|| --- Comment #24 from Charles Farmer --- Created attachment 69979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69979=edit Bug 17674 - Move subroutine GetSerialItemsInformations to Koha/Serials.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Charles Farmerchanged: What|Removed |Added Attachment #69007|0 |1 is obsolete|| --- Comment #21 from Charles Farmer --- Created attachment 69976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69976=edit Bug 17674 - Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Charles Farmerchanged: What|Removed |Added Attachment #69010|0 |1 is obsolete|| --- Comment #22 from Charles Farmer --- Created attachment 69977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69977=edit Bug 17674 - Fix problem tabs Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #20 from Marjorie Barry-Vila--- *** Bug 12575 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgaultchanged: What|Removed |Added Attachment #66565|0 |1 is obsolete|| --- Comment #19 from David Bourgault --- Created attachment 69013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69013=edit Bug 17674 - Move subroutine GetSerialItemsInformations to Koha/Serials.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgaultchanged: What|Removed |Added Attachment #61316|0 |1 is obsolete|| --- Comment #18 from David Bourgault --- Created attachment 69011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69011=edit Bug 17674 - Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=17674 Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgaultchanged: What|Removed |Added Attachment #61315|0 |1 is obsolete|| --- Comment #17 from David Bourgault --- Created attachment 69010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69010=edit Bug 17674 - Fix problem tabs Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgaultchanged: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 David Bourgaultchanged: What|Removed |Added Attachment #61314|0 |1 is obsolete|| --- Comment #16 from David Bourgault --- Created attachment 69007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69007=edit Bug 17674 - Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Alex Buckleychanged: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||alexbuck...@catalyst.net.nz --- Comment #15 from Alex Buckley --- Hi Can you please rebase against the master branch, when I apply the patches attached to this bug report I get the following merge error which is being thrown by the t/db_dependent/Serials.t file Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 17674 - Allow UI to delete serials in batch Applying: Bug 17674 - Fix problem tabs Applying: Bug 17674 - Add unit tests Using index info to reconstruct a base tree... M t/db_dependent/Serials.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Serials.t CONFLICT (content): Merge conflict in t/db_dependent/Serials.t Failed to merge in the changes. Patch failed at 0001 Bug 17674 - Add unit tests The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-17674---Add-unit-tests-yO9YMv.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Philippe Audet-Fortinchanged: What|Removed |Added Status|Failed QA |Needs Signoff CC||philippe.audet-fortin@inlib ||ro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #14 from Philippe Audet-Fortin--- Created attachment 66565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66565=edit Bug 17674 - Move subroutine GetSerialItemsInformations to Koha/Serials.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #13 from Jonathan Druart --- New subroutines should be covered by tests. It would be preferable not to add new subroutines to C4 whereas I am trying to move everything to Koha. Please consider adding a new method to Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #9 from sandbo...@biblibre.com--- Created attachment 61314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61314=edit Bug 17674 - Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #10 from sandbo...@biblibre.com--- Created attachment 61315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61315=edit Bug 17674 - Fix problem tabs Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 sandbo...@biblibre.comchanged: What|Removed |Added Attachment #58262|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #11 from sandbo...@biblibre.com--- Created attachment 61316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61316=edit Bug 17674 - Add unit tests https://bugs.koha-community.org/show_bug.cgi?id=17674 Signed-off-by: Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Koha Team Lyon 3changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #12 from Koha Team Lyon 3 --- It works as described. I test with 1, 2, 3 issues deletion at one time asking for items to be deleting or not and the result is consistent :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 sandbo...@biblibre.comchanged: What|Removed |Added Attachment #60925|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 sandbo...@biblibre.comchanged: What|Removed |Added Attachment #57731|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 sandbo...@biblibre.comchanged: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #8 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Bouzidchanged: What|Removed |Added Attachment #58264|0 |1 is obsolete|| --- Comment #7 from Bouzid --- Created attachment 60925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60925=edit Bug 17674 - Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Bouzidchanged: What|Removed |Added Attachment #58263|0 |1 is obsolete|| --- Comment #6 from Bouzid --- Created attachment 58264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58264=edit Bug 17674 - Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #5 from Bouzid--- Created attachment 58263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58263=edit Bug - Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #4 from Bouzid--- Created attachment 58262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58262=edit Bug 17674 - Fix problem tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Marc Véronchanged: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Blouchanged: What|Removed |Added Status|NEW |Needs Signoff --- Comment #3 from Blou --- A test file for the changes in C4/Serials.pm will follow. This enhancement was clamored for on the Koha (French) list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #2 from Blou--- Created attachment 57731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57731=edit Bug 17674 - Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Testing - Have at least three serials, with items - check the box to select two of them - Press the Remove selected issues button - Decide to delete their items as well or not - Validate. Sponsored by : CCSR -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Blouchanged: What|Removed |Added Patch complexity|--- |Small patch Assignee|koha-b...@lists.koha-commun |philippe.blo...@inlibro.com |ity.org | CC||bouzid.ferg...@inlibro.com, ||francois.charbonnier@inlibr ||o.com, ||marjorie.barry-v...@ccsr.qc ||.ca, ||philippe.blo...@inlibro.com Change sponsored?|--- |Sponsored --- Comment #1 from Blou --- Sponsored by : CCSR -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/