[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Fridolin SOMERS  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #22 from Fridolin SOMERS  ---
Enhancement not pushed to 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #21 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

--- Comment #20 from Marcel de Rooy  ---
Created attachment 64752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64752=edit
Bug 17738: [QA Follow-up] Remove second find of same patron

We can just use the $patron from line 77 here.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64332|0   |1
is obsolete||

--- Comment #19 from Marcel de Rooy  ---
Created attachment 64751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64751=edit
Bug 17738: Remove warning about redeclaration of $patron

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64330|0   |1
is obsolete||

--- Comment #17 from Marcel de Rooy  ---
Created attachment 64749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64749=edit
Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds

This patch replace the different calls to GetReservesFromBorrowernumber
with a calls to Koha::Patron->get_holds.
In some places we need to get a restricted set of holds, that's why we
process a search on this holds returned by ->get_holds (on the found
status for instance).

The changes are quite trivial and reading the diff should be enough to
catch bugs.

Test plan:
I would suggest to test this patch with patches from bug 17736 and bug 17737,
to place different kind of holds (biblio and item level, future and
past).
Then do a whole workflow to detect bug, view a record, delete record,
order, place a hold on an item which has been ordered, etc.
The hold's informations should always be the same without or without
these patches.

Tested both patches together, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #62188|0   |1
is obsolete||
  Attachment #62189|0   |1
is obsolete||
  Attachment #62219|0   |1
is obsolete||

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #14 from Kyle M Hall  ---
Created attachment 64330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64330=edit
Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds

This patch replace the different calls to GetReservesFromBorrowernumber
with a calls to Koha::Patron->get_holds.
In some places we need to get a restricted set of holds, that's why we
process a search on this holds returned by ->get_holds (on the found
status for instance).

The changes are quite trivial and reading the diff should be enough to
catch bugs.

Test plan:
I would suggest to test this patch with patches from bug 17736 and bug 17737,
to place different kind of holds (biblio and item level, future and
past).
Then do a whole workflow to detect bug, view a record, delete record,
order, place a hold on an item which has been ordered, etc.
The hold's informations should always be the same without or without
these patches.

Tested both patches together, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

--- Comment #15 from Kyle M Hall  ---
Created attachment 64331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64331=edit
Bug 17738: Remove C4::Reserves::GetReservesFromBorrowernumber

At this point, there should not be any occurrences of
GetReservesFromBorrowernumber anymore.

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

--- Comment #16 from Kyle M Hall  ---
Created attachment 64332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64332=edit
Bug 17738: Remove warning about redeclaration of $patron

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #64331|0   |1
is obsolete||

--- Comment #18 from Marcel de Rooy  ---
Created attachment 64750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64750=edit
Bug 17738: Remove C4::Reserves::GetReservesFromBorrowernumber

At this point, there should not be any occurrences of
GetReservesFromBorrowernumber anymore.

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Marc Véron  changed:

   What|Removed |Added

  Attachment #62208|0   |1
is obsolete||

--- Comment #13 from Marc Véron  ---
Created attachment 62219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62219=edit
Bug 17738: Remove warning about redeclaration of $patron

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

--- Comment #12 from Jonathan Druart  
---
Created attachment 62208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62208=edit
Bug 17738: Remove warning about redeclaration of $patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738
Bug 17738 depends on bug 17737, which changed state.

Bug 17737 Summary: Move GetReservesFromItemnumber to Koha::Item->holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17737

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Marc Véron  changed:

   What|Removed |Added

  Attachment #62110|0   |1
is obsolete||

--- Comment #11 from Marc Véron  ---
Created attachment 62189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62189=edit
Bug 17738: Remove C4::Reserves::GetReservesFromBorrowernumber

At this point, there should not be any occurrences of
GetReservesFromBorrowernumber anymore.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Marc Véron  changed:

   What|Removed |Added

  Attachment #62109|0   |1
is obsolete||

--- Comment #10 from Marc Véron  ---
Created attachment 62188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62188=edit
Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds

This patch replace the different calls to GetReservesFromBorrowernumber
with a calls to Koha::Patron->get_holds.
In some places we need to get a restricted set of holds, that's why we
process a search on this holds returned by ->get_holds (on the found
status for instance).

The changes are quite trivial and reading the diff should be enough to
catch bugs.

Test plan:
I would suggest to test this patch with patches from bug 17736 and bug 17737,
to place different kind of holds (biblio and item level, future and
past).
Then do a whole workflow to detect bug, view a record, delete record,
order, place a hold on an item which has been ordered, etc.
The hold's informations should always be the same without or without
these patches.

Tested both patches together, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

--- Comment #9 from Marc Véron  ---
Signing... :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

--- Comment #8 from Marc Véron  ---
(In reply to Marc Véron from comment #7)
> Tested both patches together on top of 17737. No problems found.
> 
> However, QA tool complains with first patch:
> FAIL  opac/opac-reserve.pl
>FAIL valid
>   "my" variable $patron masks earlier declaration in same scope

I can not find out why QA tool complains, code seems OK to me. 
Maybe QAers can find out? - Singing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

--- Comment #7 from Marc Véron  ---
Tested both patches together on top of 17737. No problems found.

However, QA tool complains with first patch:
FAILopac/opac-reserve.pl
   FAIL   valid
"my" variable $patron masks earlier declaration in same scope

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

--- Comment #6 from Jonathan Druart  
---
(In reply to Marc Véron from comment #3)
> Wanted to test on top of 17737 but 17737 does not apply:
> sha1 information lacking or useless (opac/opac-reserve.pl)

Both have been rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

--- Comment #5 from Jonathan Druart  
---
Created attachment 62110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62110=edit
Bug 17738: Remove C4::Reserves::GetReservesFromBorrowernumber

At this point, there should not be any occurrences of
GetReservesFromBorrowernumber anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58020|0   |1
is obsolete||
  Attachment #58021|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 62109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62109=edit
Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds

This patch replace the different calls to GetReservesFromBorrowernumber
with a calls to Koha::Patron->get_holds.
In some places we need to get a restricted set of holds, that's why we
process a search on this holds returned by ->get_holds (on the found
status for instance).

The changes are quite trivial and reading the diff should be enough to
catch bugs.

Test plan:
I would suggest to test this patch with patches from bug 17736 and bug 17737,
to place different kind of holds (biblio and item level, future and
past).
Then do a whole workflow to detect bug, view a record, delete record,
order, place a hold on an item which has been ordered, etc.
The hold's informations should always be the same without or without
these patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #3 from Marc Véron  ---
Wanted to test on top of 17737 but 17737 does not apply:
sha1 information lacking or useless (opac/opac-reserve.pl)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17829


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829
[Bug 17829] Move GetMember to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738
Bug 17738 depends on bug 17740, which changed state.

Bug 17740 Summary: Add the Koha::Patron->holds method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

--- Comment #2 from Jonathan Druart  
---
Created attachment 58021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58021=edit
Bug 17738: Remove C4::Reserves::GetReservesFromBorrowernumber

At this point, there should not be any occurrences of
GetReservesFromBorrowernumber anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

--- Comment #1 from Jonathan Druart  
---
Created attachment 58020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58020=edit
Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds

This patch replace the different calls to GetReservesFromBorrowernumber
with a calls to Koha::Patron->get_holds.
In some places we need to get a restricted set of holds, that's why we
process a search on this holds returned by ->get_holds (on the found
status for instance).

The changes are quite trivial and reading the diff should be enough to
catch bugs.

Test plan:
I would suggest to test this patch with patches from bug 17736 and bug 17737,
to place different kind of holds (biblio and item level, future and
past).
Then do a whole workflow to detect bug, view a record, delete record,
order, place a hold on an item which has been ordered, etc.
The hold's informations should always be the same without or without
these patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17740


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17740
[Bug 17740] Add the Koha::Patron->get_holds method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17738] Move GetReservesFromBorrowernumber to Koha::Patron->holds

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738

Jonathan Druart  changed:

   What|Removed |Added

Summary|Move|Move
   |GetReservesFromBorrowernumb |GetReservesFromBorrowernumb
   |er to   |er to Koha::Patron->holds
   |Koha::Patron->get_holds |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/