[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||20608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20608
[Bug 20608] Elasticsearch - relevancy weights proposition for unimarc in
mappings.yaml
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||29010


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010
[Bug 29010] Weight input pattern wrong
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

e.betemps  changed:

   What|Removed |Added

 CC||e.bete...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #137 from Martin Renvoize  ---
Enhancement, will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #136 from David Gustafsson  ---
Hmm, no second thought this seems to have been done in Koha-master. So perhaps
release-manager took care of this. I will fix this in my local branch then and
RM will have to fix this manually again where regenerating the schema files for
that in case it get merged.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #135 from David Gustafsson  ---
Basing my current work on bug 20589 on this I think I discovered a regression. 
In "Bug 18316: Update Koha/Schema/Result/SearchField.pm" the many-to-many
relationship (which has previously been manually added) was removed. This
causes a crash when resetting or adding new mappings. I can supply a patch for
this and will submit in this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #134 from Nick Clemens  ---
(In reply to Nick Clemens from comment #133)
> Created attachment 82050 [details] [review]
> Bug 18316: (follow-up) Don't let 'fields' be undef and adjust tests

Followup pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #133 from Nick Clemens  ---
Created attachment 82050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82050=edit
Bug 18316: (follow-up) Don't let 'fields' be undef and adjust tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
   Keywords||release-notes-needed

--- Comment #132 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #131 from Martin Renvoize  ---
Passing QA!

I can't find any regressions and the code looks reasonable.. well done for
sticking with it everyone and thank you for the perseverance. 

One minor note.. the bug claims it's sponsored but I can't see by whom... if
there is a sponsor can we have it added to the commits with the Sponsored-by
trailer?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #81011|0   |1
is obsolete||

--- Comment #128 from Martin Renvoize  ---
Created attachment 81514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81514=edit
Bug 18316: (follow-up) Fix tests and update statement

Signed-off-by: Ere Maijala 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #130 from Martin Renvoize  ---
Created attachment 81516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81516=edit
Bug 18316: (QA follow-up) Add final missing filter

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #81012|0   |1
is obsolete||

--- Comment #129 from Martin Renvoize  ---
Created attachment 81515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81515=edit
Bug 18316: (follow-up) remove use_dis_max

It is true by default on ES 5 and has been removed on ES 6

Signed-off-by: Ere Maijala 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #81009|0   |1
is obsolete||

--- Comment #126 from Martin Renvoize  ---
Created attachment 81512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81512=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

https://bugs.koha-community.org/show_bug.cgi?id=18316
Signed-off-by: Ere Maijala 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #81008|0   |1
is obsolete||

--- Comment #125 from Martin Renvoize  ---
Created attachment 81511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81511=edit
Bug 18316: Change search field weight field to decimal

Signed-off-by: Ere Maijala 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #81010|0   |1
is obsolete||

--- Comment #127 from Martin Renvoize  ---
Created attachment 81513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81513=edit
Bug 18316: Fix field weight validation/deletion bug

Signed-off-by: Ere Maijala 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #81007|0   |1
is obsolete||

--- Comment #124 from Martin Renvoize  ---
Created attachment 81510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81510=edit
Bug 18316: (follow-up) Koha::SearchField::search_marc_maps return a result set
- code refactoring for gettings weighted fields -
Koha::SearchFields::weighted_fields return a result set

Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 
Signed-off-by: Ere Maijala 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #81005|0   |1
is obsolete||

--- Comment #122 from Martin Renvoize  ---
Created attachment 81508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81508=edit
Bug 18316: Add weighting/relevancy options to ES query on simple search

The idea is the following: if some search field(s) are weighted in
search engine config page, Koha will query ES on all fields plus those with
the coresponding weights. Else, search is done on the entire record with
no weighting. The advanced search page is unaffected by these changes

Test plan (having Koha working with Elasticsearch):
  - apply this patch
  - have some weights defined for various fields
  - try searches from the search bar and from the advanced search page
  - confirm weighting affects the relevancy (in expected ways)
  e.g.
  1. search for 'a' from advanced search, note results
  2. give 'title' a weight
  3. search for 'a' using the simple search bar
  4. results with 'a' in the title should now be more relevant
  - confirm search results on advanced search page are unaffected

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 
Signed-off-by: Ere Maijala 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #81006|0   |1
is obsolete||

--- Comment #123 from Martin Renvoize  ---
Created attachment 81509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81509=edit
Bug 18316: String changes

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 
Signed-off-by: Ere Maijala 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #81004|0   |1
is obsolete||

--- Comment #121 from Martin Renvoize  ---
Created attachment 81507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81507=edit
Bug 18316: Ability to weight search fields

Weight can be defined between 1 and 99.
only search fields mapped with biblios can be weighted

Test plan:
  - apply this patch,
  - update schema file (perl misc/devel/update_dbix_class_files.pl),
  - go to Administration > Search engine configuration,
  - in search fields tab, define weights for some fields and save,
  - check weights has been saved,
  - reset some weights (empty) and save,
  - check weights has been reset

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 
Signed-off-by: Ere Maijala 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #120 from Ere Maijala  ---
I took the liberty of fixing the md5sum of the schema file while signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Ere Maijala  changed:

   What|Removed |Added

  Attachment #78403|0   |1
is obsolete||

--- Comment #118 from Ere Maijala  ---
Created attachment 81011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81011=edit
Bug 18316: (follow-up) Fix tests and update statement

Signed-off-by: Ere Maijala 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Ere Maijala  changed:

   What|Removed |Added

  Attachment #78401|0   |1
is obsolete||

--- Comment #116 from Ere Maijala  ---
Created attachment 81009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81009=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

https://bugs.koha-community.org/show_bug.cgi?id=18316
Signed-off-by: Ere Maijala 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Ere Maijala  changed:

   What|Removed |Added

  Attachment #80335|0   |1
is obsolete||

--- Comment #119 from Ere Maijala  ---
Created attachment 81012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81012=edit
Bug 18316: (follow-up) remove use_dis_max

It is true by default on ES 5 and has been removed on ES 6

Signed-off-by: Ere Maijala 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Ere Maijala  changed:

   What|Removed |Added

  Attachment #78400|0   |1
is obsolete||

--- Comment #115 from Ere Maijala  ---
Created attachment 81008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81008=edit
Bug 18316: Change search field weight field to decimal

Signed-off-by: Ere Maijala 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Ere Maijala  changed:

   What|Removed |Added

  Attachment #78397|0   |1
is obsolete||

--- Comment #112 from Ere Maijala  ---
Created attachment 81005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81005=edit
Bug 18316: Add weighting/relevancy options to ES query on simple search

The idea is the following: if some search field(s) are weighted in
search engine config page, Koha will query ES on all fields plus those with
the coresponding weights. Else, search is done on the entire record with
no weighting. The advanced search page is unaffected by these changes

Test plan (having Koha working with Elasticsearch):
  - apply this patch
  - have some weights defined for various fields
  - try searches from the search bar and from the advanced search page
  - confirm weighting affects the relevancy (in expected ways)
  e.g.
  1. search for 'a' from advanced search, note results
  2. give 'title' a weight
  3. search for 'a' using the simple search bar
  4. results with 'a' in the title should now be more relevant
  - confirm search results on advanced search page are unaffected

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 
Signed-off-by: Ere Maijala 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Ere Maijala  changed:

   What|Removed |Added

  Attachment #78402|0   |1
is obsolete||

--- Comment #117 from Ere Maijala  ---
Created attachment 81010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81010=edit
Bug 18316: Fix field weight validation/deletion bug

Signed-off-by: Ere Maijala 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Ere Maijala  changed:

   What|Removed |Added

  Attachment #78399|0   |1
is obsolete||

--- Comment #114 from Ere Maijala  ---
Created attachment 81007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81007=edit
Bug 18316: (follow-up) Koha::SearchField::search_marc_maps return a result set
- code refactoring for gettings weighted fields -
Koha::SearchFields::weighted_fields return a result set

Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 
Signed-off-by: Ere Maijala 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Ere Maijala  changed:

   What|Removed |Added

  Attachment #78396|0   |1
is obsolete||

--- Comment #111 from Ere Maijala  ---
Created attachment 81004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81004=edit
Bug 18316: Ability to weight search fields

Weight can be defined between 1 and 99.
only search fields mapped with biblios can be weighted

Test plan:
  - apply this patch,
  - update schema file (perl misc/devel/update_dbix_class_files.pl),
  - go to Administration > Search engine configuration,
  - in search fields tab, define weights for some fields and save,
  - check weights has been saved,
  - reset some weights (empty) and save,
  - check weights has been reset

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 
Signed-off-by: Ere Maijala 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Ere Maijala  changed:

   What|Removed |Added

  Attachment #78398|0   |1
is obsolete||

--- Comment #113 from Ere Maijala  ---
Created attachment 81006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81006=edit
Bug 18316: String changes

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 
Signed-off-by: Ere Maijala 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #80278|0   |1
is obsolete||

--- Comment #110 from Alex Arnaud  ---
Created attachment 80335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80335=edit
Bug 18316: (follow-up) remove use_dis_max

It is true by default on ES 5 and has been removed on ES 6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #109 from Julian Maurice  ---
(In reply to Joonas Kylmälä from comment #108)
> > Is there already a bug report open for this problem ?
> 
> yes: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20114

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #108 from Joonas Kylmälä  ---
(In reply to Julian Maurice from comment #105)
> (In reply to Joonas Kylmälä from comment #104)
> > This bug already happens even without this patch. Also for example if you
> > have specified multiple keywords in the search only one will be left after
> > clicking the return button.
> 
> Is there already a bug report open for this problem ?

yes: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20114

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #107 from Joonas Kylmälä  ---
(In reply to Alex Arnaud from comment #106)
> Created attachment 80278 [details] [review]
> Bug 18316: remove use_dis_max

There should be a (follow-up) in the title. Otherwise looks good and will
sign-off after the change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #106 from Alex Arnaud  ---
Created attachment 80278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80278=edit
Bug 18316: remove use_dis_max

It is true by default on ES 5 and has been removed on ES 6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #105 from Julian Maurice  ---
(In reply to Joonas Kylmälä from comment #104)
> This bug already happens even without this patch. Also for example if you
> have specified multiple keywords in the search only one will be left after
> clicking the return button.

Is there already a bug report open for this problem ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #104 from Joonas Kylmälä  ---
(In reply to Julian Maurice from comment #103)
> I found a potential bug. To reproduce:
> 1. Use advanced search
> 2. Go to the detail page of a result
> 3. Click on "Return to results" (in the left column)
> 4. The advsearch URL param is gone
> 

This bug already happens even without this patch. Also for example if you have
specified multiple keywords in the search only one will be left after clicking
the return button.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Ere Maijala  changed:

   What|Removed |Added

 CC||ere.maij...@helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #103 from Julian Maurice  ---
I found a potential bug. To reproduce:
1. Use advanced search
2. Go to the detail page of a result
3. Click on "Return to results" (in the left column)
4. The advsearch URL param is gone

Also, I think it should be implemented for OPAC as well. Or at least show a
message in the configuration page saying that this feature only works for
intranet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #102 from Julian Maurice  ---
Comment on attachment 78397
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78397
Bug 18316: Add weighting/relevancy options to ES query on simple search

Review of attachment 78397:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18316=78397)
-

::: Koha/SearchEngine/Elasticsearch/QueryBuilder.pm
@@ +92,5 @@
>  default_operator => 'AND',
>  default_field=> '_all',
>  lenient  => JSON::true,
> +fields   => $options{fields},
> +use_dis_max  => JSON::true,

From
https://www.elastic.co/guide/en/elasticsearch/reference/6.0/breaking_60_search_changes.html

> The use_dis_max parameter for the query_string query has been removed. If
> provided, it will be ignored and issue a deprecation warning. The tie_breaker
> parameter must be used instead.

In elasticsearch 5, use_dis_max is true by default. So maybe it's not a good
idea to specify it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #101 from Nick Clemens  ---
(In reply to Joonas Kylmälä from comment #90)
> Instead of adding a new 'advsearch' parameter maybe checking whether the
> 'idx' parameter is present would work just fine?

I think having the search parameter to weight or not could be useful -
advsearch should get weighting in future but may offer specific weighting. We
also may want the ability to sometimes search without weights

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #97 from Nick Clemens  ---
Created attachment 78400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78400=edit
Bug 18316: Change search field weight field to decimal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #100 from Nick Clemens  ---
Created attachment 78403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78403=edit
Bug 18316: (follow-up) Fix tests and update statement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #98 from Nick Clemens  ---
Created attachment 78401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78401=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #99 from Nick Clemens  ---
Created attachment 78402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78402=edit
Bug 18316: Fix field weight validation/deletion bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #96 from Nick Clemens  ---
Created attachment 78399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78399=edit
Bug 18316: (follow-up) Koha::SearchField::search_marc_maps return a result set
- code refactoring for gettings weighted fields -
Koha::SearchFields::weighted_fields return a result set

Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #95 from Nick Clemens  ---
Created attachment 78398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78398=edit
Bug 18316: String changes

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Nick Clemens  changed:

   What|Removed |Added

  Attachment #77661|0   |1
is obsolete||
  Attachment #77662|0   |1
is obsolete||
  Attachment #77663|0   |1
is obsolete||
  Attachment #77664|0   |1
is obsolete||
  Attachment #77665|0   |1
is obsolete||
  Attachment #77666|0   |1
is obsolete||
  Attachment #77667|0   |1
is obsolete||

--- Comment #93 from Nick Clemens  ---
Created attachment 78396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78396=edit
Bug 18316: Ability to weight search fields

Weight can be defined between 1 and 99.
only search fields mapped with biblios can be weighted

Test plan:
  - apply this patch,
  - update schema file (perl misc/devel/update_dbix_class_files.pl),
  - go to Administration > Search engine configuration,
  - in search fields tab, define weights for some fields and save,
  - check weights has been saved,
  - reset some weights (empty) and save,
  - check weights has been reset

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #94 from Nick Clemens  ---
Created attachment 78397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78397=edit
Bug 18316: Add weighting/relevancy options to ES query on simple search

The idea is the following: if some search field(s) are weighted in
search engine config page, Koha will query ES on all fields plus those with
the coresponding weights. Else, search is done on the entire record with
no weighting. The advanced search page is unaffected by these changes

Test plan (having Koha working with Elasticsearch):
  - apply this patch
  - have some weights defined for various fields
  - try searches from the search bar and from the advanced search page
  - confirm weighting affects the relevancy (in expected ways)
  e.g.
  1. search for 'a' from advanced search, note results
  2. give 'title' a weight
  3. search for 'a' using the simple search bar
  4. results with 'a' in the title should now be more relevant
  - confirm search results on advanced search page are unaffected

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #92 from Katrin Fischer  ---
We had agreed that this bug should be next, still waiting, please fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #91 from Katrin Fischer  ---
Thx, Joonas. Waiting for a follow-up here so I can continue testing - hopefully
soon!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #90 from Joonas Kylmälä  ---
Instead of adding a new 'advsearch' parameter maybe checking whether the 'idx'
parameter is present would work just fine?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@helsinki.fi

--- Comment #89 from Joonas Kylmälä  ---
(In reply to Katrin Fischer from comment #88)
> 3.2) Can you explain this line?
> 

It is used in search.pl to enable weighted field search to any other search
expect the one done in the Advanced search page
(/cgi-bin/koha/catalogue/search.pl):

unless ( $cgi->param('advsearch') ) {
$build_params->{weighted_fields} = 1;
}

So if the advsearch parameter equals '1' the weighted search is disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #88 from Katrin Fischer  ---
Giving this a go, any help/more eyes much appreaciated!

1) Questions

1.1) >This will allow to configure the way the simple search is weighted: 
>it will search in all fields for which a weight has been indicated. 
>If no weight was indicated it will search in all fields. (In addition, 
>this allows excluding some search fields from the simple search!)

>From comments#13+ I tihnk this is no longer the case and it will be
always searched on all fields + boosting the weighted fields.
Can you confirm?

1.2) Should the patches on this bug tested in combination with
other patches from dependent bugs? A more detailed test plan would help
me a lot.

1.3) Could we deliver this with a basic default weighting?

2) QA tools and unit tests

2.1) FAIL   t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
You tried to plan twice 

2.2) When I remove the doubled up line, the test still fails:

t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t .. Dubious, test
returned 255 (wstat 65280, 0xff00)
Failed 2/2 subtests 

Test Summary Report
---
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t (Wstat: 65280
Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 2 tests but ran 0.
Files=1, Tests=0,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.23 cusr  0.05
csys =  0.30 CPU)
Result: FAIL
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ vi
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t .. 1/3 # No
tests run!

#   Failed test 'No tests run for subtest "build_query with weighted fields
tests"'
#   at t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t line 167.
Can't locate object method "new" via package "t::lib::TestBuilder" (perhaps you
forgot to load "t::lib::TestBuilder"?) at
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t line 127.
# Looks like your test exited with 255 just after 3.
t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t .. Dubious, test
returned 255 (wstat 65280, 0xff00)
Failed 1/3 subtests 

2.3) * Commit title does not start with 'Bug X: ' - dfe2ab9

2.4) Other tests fail too:

t/db_dependent/Koha/SearchField.t .. 1/15 
#   Failed test 'Title weight is 25.'
#   at t/db_dependent/Koha/SearchField.t line 196.
#  got: '25.00'
# expected: '25'

#   Failed test 'Subject weight is 15.'
#   at t/db_dependent/Koha/SearchField.t line 198.
#  got: '15.00'
# expected: '15'

#   Failed test 'Author weight is 5.'
#   at t/db_dependent/Koha/SearchField.t line 200.
#  got: '5.00'
# expected: '5'
# Looks like you failed 3 tests of 15.
t/db_dependent/Koha/SearchField.t .. Dubious, test returned 3 (wstat 768,
0x300)
Failed 3/15 subtests 

3) Code Review

3.1) Please use AFTER/BEFORE to make sure the column ends always in the correct
spot.
+$dbh->do( "ALTER TABLE `search_field` ADD COLUMN `weight` decimal(5,2)
DEFAULT NULL" );

3.2) Can you explain this line?


4) Further tests

Adding, deleting and editing weights works. Waiting for follow-up and more info
before I continue!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #87 from Nick Clemens  ---
Created attachment 77667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77667=edit
Bug 18316: Fix field weight validation/deletion bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #86 from Nick Clemens  ---
Created attachment 77666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77666=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #83 from Nick Clemens  ---
Created attachment 77663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77663=edit
Bug 18316: String changes

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #85 from Nick Clemens  ---
Created attachment 77665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77665=edit
Bug 18316: Change search field weight field to decimal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #84 from Nick Clemens  ---
Created attachment 77664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77664=edit
Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a
result set - code refactoring for gettings weighted fields -
Koha::SearchFields::weighted_fields return a result set

Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #82 from Nick Clemens  ---
Created attachment 77662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77662=edit
Bug 18316: Add weighting/relevancy options to ES query on simple search

The idea is the following: if some search field(s) are weighted in
search
engine config page, Koha will query ES on these fields only and with
the coresponding weights. Else, search is done on the entire record.

Test plan (having Koha working with Elasticsearch):
  - apply this patch,
  - try searches with and without weight defined on search fields

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Nick Clemens  changed:

   What|Removed |Added

  Attachment #75536|0   |1
is obsolete||
  Attachment #75537|0   |1
is obsolete||
  Attachment #75538|0   |1
is obsolete||
  Attachment #75539|0   |1
is obsolete||
  Attachment #75540|0   |1
is obsolete||
  Attachment #75699|0   |1
is obsolete||
  Attachment #75730|0   |1
is obsolete||

--- Comment #81 from Nick Clemens  ---
Created attachment 77661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77661=edit
Bug 18316: Ability to weight search fields

Weight can be defined between 1 and 99.
only search fields mapped with biblios can be weighted

Test plan:
  - apply this patch,
  - update schema file (perl misc/devel/update_dbix_class_files.pl),
  - go to Administration > Search engine configuration,
  - in search fields tab, define weights for some fields and save,
  - check weights has been saved,
  - reset some weights (empty) and save,
  - check weights has been reset

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #80 from Katrin Fischer  ---
I am sorry, I fixed the conflict in kohastructure.sql, but then the 4th patch
won't apply:

sloth:/usr/local/vagrant/kohaclone_master (32-18316-qa-elastic_weight|AM 1/1) $
git bz apply --continue
Applying: Bug 18316: Ability to weight search fields
Applying: Bug 18316: Add weighting/relevancy options to ES query on simple
search
Applying: Bug 18316: String changes
Applying: Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps
return a result set - code refactoring for gettings weighted fields -
Koha::SearchFields::weighted_fields return a result set
error: sha1 information is lacking or useless
(Koha/SearchEngine/Elasticsearch/QueryBuilder.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 18316 - QA improvement -
Koha::SearchField::search_marc_maps return a result set - code refactoring for
gettings weighted fields - Koha::SearchFields::weighted_fields return a result
set
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-18316---QA-improvement---KohaSearchFieldsearch-dKxuaY.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #79 from David Gustafsson  ---
Ok! This should now be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #78 from David Gustafsson  ---
Created attachment 75730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75730=edit
Bug 18316: Fix field weight validation/deletion bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #77 from Alex Arnaud  ---
The patch "Bug 18316: Change search field weight field to decimal" seems to
break the ability to erase weights.

I.e
  - set weihgt to 1.25 for title,
  - save,
  - erase (empty) the weight input for title,
  - save,
  - weight is still here with the same value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #76 from David Gustafsson  ---
Yes, work for the master I did the rebase on, but the signature comment in
SearchField.pm had changed since then. Now should work again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75541|0   |1
is obsolete||

--- Comment #75 from David Gustafsson  ---
Created attachment 75699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75699=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #74 from David Gustafsson  ---
Hmm, thought I had fixed the merge conflicts, but perhaps I was using a non up
to date or something has changed since last time. Can have a look at it
tomorrow if no one else does before then.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #73 from Jonathan Druart  
---
(In reply to Séverine Queune from comment #72)
> error: The following untracked working tree files would be overwritten by
> merge:
>   installer/data/mysql/atomicupdate/bug_18316_add-weight-column.perl
>   t/db_dependent/Koha/SearchField.t

This error means you have these files in your repo and the patch is trying to
create it.
You should remove them, then apply the patch.

However there is another conflict later:
CONFLICT (content): Merge conflict in Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #72 from Séverine Queune  ---
Sorry David, I took a few days off and didn't try this patch earlier, it
doesn't apply on last master...

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 18316: Ability to weight search fields
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
error: The following untracked working tree files would be overwritten by
merge:
installer/data/mysql/atomicupdate/bug_18316_add-weight-column.perl
t/db_dependent/Koha/SearchField.t
Please move or remove them before you can merge.
Aborting
Failed to merge in the changes.
Patch failed at 0001 Bug 18316: Ability to weight search fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #71 from David Gustafsson  ---
Forgot to change status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75531|0   |1
is obsolete||

--- Comment #69 from David Gustafsson  ---
Created attachment 75541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75541=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75527|0   |1
is obsolete||

--- Comment #65 from David Gustafsson  ---
Created attachment 75537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75537=edit
Bug 18316: Add weighting/relevancy options to ES query on simple search

The idea is the following: if some search field(s) are weighted in
search
engine config page, Koha will query ES on these fields only and with
the coresponding weights. Else, search is done on the entire record.

Test plan (having Koha working with Elasticsearch):
  - apply this patch,
  - try searches with and without weight defined on search fields

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75529|0   |1
is obsolete||

--- Comment #67 from David Gustafsson  ---
Created attachment 75539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75539=edit
Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a
result set - code refactoring for gettings weighted fields -
Koha::SearchFields::weighted_fields return a result set

Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #70 from David Gustafsson  ---
Now patches should apply to latest master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75528|0   |1
is obsolete||

--- Comment #66 from David Gustafsson  ---
Created attachment 75538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75538=edit
Bug 18316: String changes

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75530|0   |1
is obsolete||

--- Comment #68 from David Gustafsson  ---
Created attachment 75540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75540=edit
Bug 18316: Change search field weight field to decimal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75526|0   |1
is obsolete||

--- Comment #64 from David Gustafsson  ---
Created attachment 75536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75536=edit
Bug 18316: Ability to weight search fields

Weight can be defined between 1 and 99.
only search fields mapped with biblios can be weighted

Test plan:
  - apply this patch,
  - update schema file (perl misc/devel/update_dbix_class_files.pl),
  - go to Administration > Search engine configuration,
  - in search fields tab, define weights for some fields and save,
  - check weights has been saved,
  - reset some weights (empty) and save,
  - check weights has been reset

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #63 from David Gustafsson  ---
I think root cause of this is that the "Bug 18316: Ability to weight search
fields" commit was created from a commit with the line:
"type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum', 'isbn', 'stdno')
..." in /data/mysql/kohastructure.sql
when in current Koha master the line is:
`type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum')

This is the reason why:
https://github.com/Koha-Community/Koha/commit/cff62796ea9fc227c24fec8f8f3f153a715796ef

I can rebase the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #62 from Séverine Queune  ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 18316:
Something went wrong !Applying: Bug 18316: Ability to weight search
fields
Using index info to reconstruct a base tree...
M   installer/data/mysql/kohastructure.sql
M  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
Auto-merging installer/data/mysql/kohastructure.sql
CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql
error: Failed to merge in the changes.
Patch failed at 0001 Bug 18316: Ability to weight search fields
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 18316 - Add weighting/relevancy options to ElasticSearch

75526 - Bug 18316: Ability to weight search fields
75527 - Bug 18316: Add weighting/relevancy options to ES query on simple search
75528 - Bug 18316: String changes
75529 - Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return
a result set - code refactoring for gettings weighted fields -
Koha::SearchFields::weighted_fields return a result set
75530 - Bug 18316: Change search field weight field to decimal
75531 - Bug 18316: Update Koha/Schema/Result/SearchField.pm

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-18316-Ability-to-weight-search-fields-MFIcJl.patch .


Same result on my test instance :/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #61 from David Gustafsson  ---
Not used to working with multiple patches in git bz, so had removed the schema
changes locally, but used git bz incorrectly so it did not get included. Later
managed to screw things up even more, but now managed to restore the patches
(which I accidentally obsoleted) and fix the two last ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75522|0   |1
is obsolete||

--- Comment #57 from David Gustafsson  ---
Created attachment 75528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75528=edit
Bug 18316: String changes

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75525|0   |1
is obsolete||

--- Comment #60 from David Gustafsson  ---
Created attachment 75531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75531=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75524|0   |1
is obsolete||

--- Comment #59 from David Gustafsson  ---
Created attachment 75530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75530=edit
Bug 18316: Change search field weight field to decimal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75523|0   |1
is obsolete||

--- Comment #58 from David Gustafsson  ---
Created attachment 75529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75529=edit
Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a
result set - code refactoring for gettings weighted fields -
Koha::SearchFields::weighted_fields return a result set

Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75521|0   |1
is obsolete||

--- Comment #56 from David Gustafsson  ---
Created attachment 75527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75527=edit
Bug 18316: Add weighting/relevancy options to ES query on simple search

The idea is the following: if some search field(s) are weighted in
search
engine config page, Koha will query ES on these fields only and with
the coresponding weights. Else, search is done on the entire record.

Test plan (having Koha working with Elasticsearch):
  - apply this patch,
  - try searches with and without weight defined on search fields

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #55 from David Gustafsson  ---
Created attachment 75526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75526=edit
Bug 18316: Ability to weight search fields

Weight can be defined between 1 and 99.
only search fields mapped with biblios can be weighted

Test plan:
  - apply this patch,
  - update schema file (perl misc/devel/update_dbix_class_files.pl),
  - go to Administration > Search engine configuration,
  - in search fields tab, define weights for some fields and save,
  - check weights has been saved,
  - reset some weights (empty) and save,
  - check weights has been reset

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #54 from David Gustafsson  ---
Created attachment 75525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75525=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #53 from David Gustafsson  ---
Created attachment 75524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75524=edit
Bug 18316: Change search field weight field to decimal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #52 from David Gustafsson  ---
Created attachment 75523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75523=edit
Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a
result set - code refactoring for gettings weighted fields -
Koha::SearchFields::weighted_fields return a result set

Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #51 from David Gustafsson  ---
Created attachment 75522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75522=edit
Bug 18316: String changes

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75520|0   |1
is obsolete||

--- Comment #50 from David Gustafsson  ---
Created attachment 75521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75521=edit
Bug 18316: Add weighting/relevancy options to ES query on simple search

The idea is the following: if some search field(s) are weighted in
search
engine config page, Koha will query ES on these fields only and with
the coresponding weights. Else, search is done on the entire record.

Test plan (having Koha working with Elasticsearch):
  - apply this patch,
  - try searches with and without weight defined on search fields

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 
Signed-off-by: Séverine QUEUNE 

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

David Gustafsson  changed:

   What|Removed |Added

  Attachment #75073|0   |1
is obsolete||
  Attachment #75074|0   |1
is obsolete||
  Attachment #75075|0   |1
is obsolete||
  Attachment #75076|0   |1
is obsolete||
  Attachment #75458|0   |1
is obsolete||
  Attachment #75490|0   |1
is obsolete||
  Attachment #75519|0   |1
is obsolete||

--- Comment #49 from David Gustafsson  ---
Created attachment 75520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75520=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #48 from David Gustafsson  ---
Created attachment 75519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75519=edit
Bug 18316: Update Koha/Schema/Result/SearchField.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/