[Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #26 from Mason James  ---
Pushed to 16.05.x, for 16.05.18 release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #25 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #24 from Fridolin SOMERS  ---
Pushed to 17.05.x, will be in 17.05.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #23 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #66042|0   |1
is obsolete||
  Attachment #66043|0   |1
is obsolete||
  Attachment #66044|0   |1
is obsolete||

--- Comment #20 from Kyle M Hall  ---
Created attachment 66725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66725=edit
Bug 19024: Add tests

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #21 from Kyle M Hall  ---
Created attachment 66726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66726=edit
Bug 19024 Fix some infelicities of phrasing in test messages

The test messages were awkwardly phrased, re phrase them to
sound more natuaral. Patch is cosmetic (grammar) only

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #22 from Kyle M Hall  ---
Created attachment 66727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66727=edit
Bug 19024 Do not unset order cancelled status on basket close

On closing a basket, status is updated to ordered for orders not
completed. However the operation  was resetting the status for
cancelled as well as new orders.
While display is correct from the basket view (it checks the
cancellation date). The status in the acquisitions tab from the
catalogue view reverts erroneously to ordered.

This patch adds cancelled to the statuses not updated on basket
close.

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #19 from Katrin Fischer  ---
I have filed bug 19120 for the issue of resetting the canceled status on
opening a basket.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19120

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] Order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Katrin Fischer  changed:

   What|Removed |Added

Summary|order cancelled   status is |Order cancelled status is
   |reset on basket close   |reset on basket close

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #66039|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #66040|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #66041|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #18 from Katrin Fischer  ---
Created attachment 66044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66044=edit
[SIGNED OFF] Bug 19024 Do not unset order cancelled status on basket close

On closing a basket, status is updated to ordered for orders not
completed. However the operation  was resetting the status for
cancelled as well as new orders.
While display is correct from the basket view (it checks the
cancellation date). The status in the acquisitions tab from the
catalogue view reverts erroneously to ordered.

This patch adds cancelled to the statuses not updated on basket
close.

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #16 from Katrin Fischer  ---
Created attachment 66042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66042=edit
[SIGNED OFF] Bug 19024: Add tests

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #17 from Katrin Fischer  ---
Created attachment 66043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66043=edit
[SIGNED OFF] Bug 19024 Fix some infelicities of phrasing in test messages

The test messages were awkwardly phrased, re phrase them to
sound more natuaral. Patch is cosmetic (grammar) only

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #14 from M. Tompsett  ---
Created attachment 66040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66040=edit
[SIGNED-OFF] Bug 19024 Fix some infelicities of phrasing in test messages

The test messages were awkwardly phrased, re phrase them to
sound more natuaral. Patch is cosmetic (grammar) only

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #15 from M. Tompsett  ---
Created attachment 66041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66041=edit
[SIGNED-OFF] Bug 19024 Do not unset order cancelled status on basket close

On closing a basket, status is updated to ordered for orders not
completed. However the operation  was resetting the status for
cancelled as well as new orders.
While display is correct from the basket view (it checks the
cancellation date). The status in the acquisitions tab from the
catalogue view reverts erroneously to ordered.

This patch adds cancelled to the statuses not updated on basket
close.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

M. Tompsett  changed:

   What|Removed |Added

  Attachment #65776|0   |1
is obsolete||
  Attachment #66004|0   |1
is obsolete||
  Attachment #66005|0   |1
is obsolete||

--- Comment #13 from M. Tompsett  ---
Created attachment 66039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66039=edit
[SIGNED-OFF] Bug 19024: Add tests

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #12 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #11)
> Sorry, but there is still a bug here. If you reopen a basket that already
> has an order line that is cancelled, it will be reset to new. We can deal
> with this on a separate bug if you want or can fix both together, as the
> test plan is really similar.

I suspect where the fix is done is slightly different, let's move forward on
what is currently working here. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #11 from Katrin Fischer  ---
Sorry, but there is still a bug here. If you reopen a basket that already has
an order line that is cancelled, it will be reset to new. We can deal with this
on a separate bug if you want or can fix both together, as the test plan is
really similar.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Colin Campbell  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #10 from Colin Campbell  ---
Fix error in sql of original patch, added patch to enhance the test messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #8 from Colin Campbell  ---
Created attachment 66005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66005=edit
Improve phrasing of test messages

Changed the awkward phrases of the original tests to be more grammatical

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #9 from Katrin Fischer  ---
(In reply to Colin Campbell from comment #7)
> (In reply to Katrin Fischer from comment #5)
> > Ok, thinking more about this, I think this is a failed QA:
> > 
> > I propose: When a basket is closed, change new to ordered, leave all other
> > status alone.
> > 
> > The workflow usually is something like:
> > 
> > new > ordered
> > then either:
> > > complete
> > or 
> > partial > complete
> > 
> > Note: The SQL in the patch has a typo and looks for completeD -
> > reintroducing an already fixed bug by reseting complete to ordered when the
> > basket is closed.
> > 
> > 
> > Reasoning: 
> > 
> > New - If the basket is closed, we want to set it to ordered.
> > 
> > Ordered - If a basket is reopened, we can reset this to new. If the basket
> > is closed again, those should be set from new to ordered.
> > 
> > Partial - Partial means a part of the order has already been received. To
> > keep that information, we should probably leave the status alone and not
> > change it when the basket is opened/closed.
> > 
> > Complete - If an item is received already and linked to an invoice, we don't
> > want to reset it to ordered or new on opening or closing the basket. The
> > only way to change the status at this point should be to undo the receive
> 
> Not sure of the reasoning behind partial. When an ordered is part-received
> it is split into two the received copies go on a new order marked complete
> the remainder stay on an order marked partial. partial is a special case of
> ordered, so I think it should probably continue to be treated like ordered
> (a reason for reopening the basket may well be to cancel the outstanding
> partial order)

It's difficult, I think partial doesn't quite fit into the process. Maybe there
should be: partial-new, partial-ordered, partial-cancelled - or partial should
be removed as a status. It's still indicated by the existance of the linked
parent order I tihnk? At the moment partial is only a special case of ordered,
as you said. I am ok with treating it one way or the other (moving it to new on
opening or not). Can we set this back to Needs Signoff?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #7 from Colin Campbell  ---
(In reply to Katrin Fischer from comment #5)
> Ok, thinking more about this, I think this is a failed QA:
> 
> I propose: When a basket is closed, change new to ordered, leave all other
> status alone.
> 
> The workflow usually is something like:
> 
> new > ordered
> then either:
> > complete
> or 
> partial > complete
> 
> Note: The SQL in the patch has a typo and looks for completeD -
> reintroducing an already fixed bug by reseting complete to ordered when the
> basket is closed.
> 
> 
> Reasoning: 
> 
> New - If the basket is closed, we want to set it to ordered.
> 
> Ordered - If a basket is reopened, we can reset this to new. If the basket
> is closed again, those should be set from new to ordered.
> 
> Partial - Partial means a part of the order has already been received. To
> keep that information, we should probably leave the status alone and not
> change it when the basket is opened/closed.
> 
> Complete - If an item is received already and linked to an invoice, we don't
> want to reset it to ordered or new on opening or closing the basket. The
> only way to change the status at this point should be to undo the receive

Not sure of the reasoning behind partial. When an ordered is part-received it
is split into two the received copies go on a new order marked complete the
remainder stay on an order marked partial. partial is a special case of
ordered, so I think it should probably continue to be treated like ordered (a
reason for reopening the basket may well be to cancel the outstanding partial
order)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Colin Campbell  changed:

   What|Removed |Added

  Attachment #65439|0   |1
is obsolete||

--- Comment #6 from Colin Campbell  ---
Created attachment 66004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66004=edit
Correct original patch to test status == complete

Fixes error where it was checking completed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #5 from Katrin Fischer  ---
Ok, thinking more about this, I think this is a failed QA:

I propose: When a basket is closed, change new to ordered, leave all other
status alone.

The workflow usually is something like:

new > ordered
then either:
> complete
or 
partial > complete

Note: The SQL in the patch has a typo and looks for completeD - reintroducing
an already fixed bug by reseting complete to ordered when the basket is closed.


Reasoning: 

New - If the basket is closed, we want to set it to ordered.

Ordered - If a basket is reopened, we can reset this to new. If the basket is
closed again, those should be set from new to ordered.

Partial - Partial means a part of the order has already been received. To keep
that information, we should probably leave the status alone and not change it
when the basket is opened/closed.

Complete - If an item is received already and linked to an invoice, we don't
want to reset it to ordered or new on opening or closing the basket. The only
way to change the status at this point should be to undo the receive

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
I think there is another bug here. I just tested with received orders, they get
reset to ordered too. Actually, should we not just move new > ordered and leave
all other status alone?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||15036
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036
[Bug 15036] Closing and reopening a basket should not alter status of completed
orders
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #65434|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 65776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65776=edit
Bug 19024: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

--- Comment #2 from Dilan Johnpullé  ---
Created attachment 65439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65439=edit
Bug 19024 Do not unset order cancelled status on basket close

Followed the test plan and works as described.

Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19024] order cancelled status is reset on basket close

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19024

Colin Campbell  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe.
   |ity.org |com
 Status|NEW |Needs Signoff

--- Comment #1 from Colin Campbell  ---
Created attachment 65434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65434=edit
Patch to prevent cancelled status from being reset in error

Straightforward test. On a basket cancel an orderline. Search for the title and
on the Acquisitions Details tab it shows status as Cancelled.
Close the basket
Search the title again Acquisitions Details now show 'ordered' (in basket
display it remains cancelled)
Apply patch and repeat above sequence with another order, this time it should
remain as 'Cancelled' after the basket closes.

A special problem is if an order has been placed, and is cancelled because its
now out of print you have to reopen the basket to cancel it and on reclosing
you undo part of the change

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/