[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Fridolin Somers changed: What|Removed |Added Blocks||36856 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36856 [Bug 36856] New order from existing biblio does not show marc subfield name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Jonathan Druart changed: What|Removed |Added Blocks||23675 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 [Bug 23675] UseACQFrameworkForBiblioRecords default framework is missing LDR breaking encoding -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Jonathan Druart changed: What|Removed |Added Blocks||25599 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25599 [Bug 25599] Allow use of cataloguing placeholders when ACQ framework is used creating new record (UseACQFrameworkForBiblioRecords) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Katrin Fischer changed: What|Removed |Added Blocks||23525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23525 [Bug 23525] ISBD view uses view policy of ACQ framework -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Owen Leonard changed: What|Removed |Added Blocks||21537 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 [Bug 21537] Regression: typo in acquisitions template processor name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Oliver Behnke changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21537 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Nick Clemens changed: What|Removed |Added Blocks||21316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21316 [Bug 21316] Adding controlfields to the ACQ framework causes issues when adding to basket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Bug 19289 depends on bug 20540, which changed state. Bug 20540 Summary: TransformHtmlToXml can duplicate the datafield close tag https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20540 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Bug 19289 depends on bug 3841, which changed state. Bug 3841 Summary: Add a Default ACQ framework https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Nick Clemenschanged: What|Removed |Added CC||n...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #47 from Nick Clemens --- Enhancement, not backported for 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Katrin Fischerchanged: What|Removed |Added Text to go in the|When creating a new order |When creating a new order release notes|on an acquisition basket, |on an acquisition basket, |bibliographic fields|bibliographic fields |displayed on 'Catalog |displayed on 'Catalog |details' can now be |details' can now be |customized. System |customized. The system |preference |preference |'UseACQFrameworkForBiblioRe |'UseACQFrameworkForBiblioRe |cords' must be enable. |cords' must be enabled. |Fields are set on the 'ACQ |Fields are set on the 'ACQ' |MARC framework'.|MARC framework. --- Comment #46 from Katrin Fischer --- Happy to see you around on bugzilla Severine :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Séverine Queunechanged: What|Removed |Added Text to go in the||When creating a new order release notes||on an acquisition basket, ||bibliographic fields ||displayed on 'Catalog ||details' can now be ||customized. System ||preference ||'UseACQFrameworkForBiblioRe ||cords' must be enable. ||Fields are set on the 'ACQ ||MARC framework'. Keywords|release-notes-needed| --- Comment #45 from Séverine Queune --- This my first release note (and it's in english, which is not a natural language for me) : I won't be offended if you think something/anything/everything must de rewrite ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #44 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Jonathan Druartchanged: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Katrin Fischerchanged: What|Removed |Added Attachment #73948|0 |1 is obsolete|| --- Comment #43 from Katrin Fischer --- Created attachment 73994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73994=edit Bug 19289: (follow-up) Add existing fields to the ACQ framework Changes for other frameworks Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Katrin Fischerchanged: What|Removed |Added Patch complexity|--- |Medium patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Jonathan Druartchanged: What|Removed |Added Attachment #73878|0 |1 is obsolete|| --- Comment #42 from Jonathan Druart --- Created attachment 73948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73948=edit Bug 19289: (follow-up) Add existing fields to the ACQ framework Changes for other frameworks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #41 from Jonathan Druart--- (In reply to Katrin Fischer from comment #40) > Looks ok, but I think you missed pl-PL in the last follow-up? Hum, I missed it because bug 3841 missed it already :-/ I have attached and pushed a follow-up for 3841. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #40 from Katrin Fischer--- Looks ok, but I think you missed pl-PL in the last follow-up? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #39 from Jonathan Druart--- Created attachment 73878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73878=edit Bug 19289: (follow-up) Add existing fields to the ACQ framework Changes for other frameworks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Katrin Fischerchanged: What|Removed |Added Status|Passed QA |BLOCKED --- Comment #38 from Katrin Fischer --- I will sign off on the dependent bug 20540. Blocking for another reason: We still need a follow up for the other MARC21 and UNIMARC sample frameworks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #34 from Katrin Fischer--- Created attachment 73820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73820=edit Bug 19289: Use the ACQ framework to display bibliographic details The ACQ MARC framework is only used for the ‘Item’ block. This patch add the ability to define biblio fields (!= 995 or 952) to customize the display of the bibliographic details when ordering. This new feature is controlled by a new pref: UseACQFrameworkForBiblioRecords Test plan: - Create a new installation to populate the ACQ framework correctly - Set the pref UseACQFrameworkForBiblioRecords to "Use" - Create a new order => You will see the lib from the ACQ framework - Add/remove/update biblio subfields in the ACQ framework - Create a new order => You should see the new subfields displayed Note for QA: I though I would be able to refactor existing code to make it more flexible, but it is a bit messy and lost a lot of time. I finally decided to copy/paste the existing code. I simplified it as, I think, we do not want the plugin, etc. like in the full biblio editor. Signed-off-by: Josef Moravec Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #35 from Katrin Fischer--- Created attachment 73821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73821=edit Bug 19289: Use jQuery validate plugin This is quite dirty but rewrite the JS checks is out of the scope of this bug report. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #37 from Katrin Fischer--- Created attachment 73823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73823=edit Bug 19289: Extend size of inputs to 50 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Katrin Fischerchanged: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #36 from Katrin Fischer--- Created attachment 73822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73822=edit Bug 19289: Use copyrightdate instead of publicationyear for MARC21 See comment 24 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Katrin Fischerchanged: What|Removed |Added Attachment #72256|0 |1 is obsolete|| Attachment #72257|0 |1 is obsolete|| Attachment #72258|0 |1 is obsolete|| Attachment #72259|0 |1 is obsolete|| Attachment #73800|0 |1 is obsolete|| --- Comment #33 from Katrin Fischer --- Created attachment 73819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73819=edit Bug 19289: Add existing fields to the ACQ framework When ordering, the bibliographic details contain the title, author, publisher code, publication year, isbn and series info. To avoid regression to provide the same behaviour, we will add these fields to the ACQ framework NOTE: This patch makes the change only for - en - fr / unimarc complet Other frameworks will be updated before to be pushed, to avoid unecessary rebases Signed-off-by: Josef Moravec Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Jonathan Druartchanged: What|Removed |Added Depends on||20540 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20540 [Bug 20540] TransformHtmlToXml can duplicate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #32 from Jonathan Druart--- (In reply to Katrin Fischer from comment #30) > Hi Jonathan, > > Continuing testing: > > I've used the SQL from the installer file to create my ACQ framework. > > 1) Looking at the code, why this change on the ISBD view? > filters => 'ViewPolicy', > options => { > interface => 'intranet', > -frameworkcode => $framework > +frameworkcode => 'ACQ' > }, No idea! Sounds like a mistake. Done. > 2) The input fields are much shorter with the ACQ framework active. Can we > extend them a bit to be a similar size than before? Especially title and > series fields are too short. Done. > 3) The descriptions of the fields coming from the default framework are not > very nice because they are out of context without the field description. For > example 440 says title, but it's not clear it's the series title. The MARC > helps a bit. We could show the description of the tag too, but it will display bad as well, "tag / subfield" would be: "SERIES STATEMENT/ADDED ENTRY--TITLE / Title". Do you have a suggestion to improve that? > 4) I filled in title and series title and got an error on saving: > Indicator in 440 is empty at /home/vagrant/kohaclone/C4/Biblio.pm line 2294. > :13: parser error : Opening and ending tag mismatch: record line 6 and > datafield > > ^ > :14: parser error : Opening and ending tag mismatch: collection line 2 and > record > > ^ > :15: parser error : Extra content at the end of the document > It's a bug in TransformHtmlToXml, I have opened and attached a patch on bug 20540. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #31 from Jonathan Druart--- Created attachment 73800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73800=edit Bug 19289: Extend size of inputs to 50 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Katrin Fischerchanged: What|Removed |Added Status|Signed Off |Failed QA --- Comment #30 from Katrin Fischer --- Hi Jonathan, Continuing testing: I've used the SQL from the installer file to create my ACQ framework. 1) Looking at the code, why this change on the ISBD view? filters => 'ViewPolicy', options => { interface => 'intranet', -frameworkcode => $framework +frameworkcode => 'ACQ' }, 2) The input fields are much shorter with the ACQ framework active. Can we extend them a bit to be a similar size than before? Especially title and series fields are too short. 3) The descriptions of the fields coming from the default framework are not very nice because they are out of context without the field description. For example 440 says title, but it's not clear it's the series title. The MARC helps a bit. 4) I filled in title and series title and got an error on saving: Indicator in 440 is empty at /home/vagrant/kohaclone/C4/Biblio.pm line 2294. :13: parser error : Opening and ending tag mismatch: record line 6 and datafield ^ :14: parser error : Opening and ending tag mismatch: collection line 2 and record ^ :15: parser error : Extra content at the end of the document -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Katrin Fischerchanged: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #29 from Jonathan Druart--- Created attachment 72259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72259=edit Bug 19289: Use copyrightdate instead of publicationyear for MARC21 See comment 24 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #27 from Jonathan Druart--- Created attachment 72257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72257=edit Bug 19289: Use the ACQ framework to display bibliographic details The ACQ MARC framework is only used for the ‘Item’ block. This patch add the ability to define biblio fields (!= 995 or 952) to customize the display of the bibliographic details when ordering. This new feature is controlled by a new pref: UseACQFrameworkForBiblioRecords Test plan: - Create a new installation to populate the ACQ framework correctly - Set the pref UseACQFrameworkForBiblioRecords to "Use" - Create a new order => You will see the lib from the ACQ framework - Add/remove/update biblio subfields in the ACQ framework - Create a new order => You should see the new subfields displayed Note for QA: I though I would be able to refactor existing code to make it more flexible, but it is a bit messy and lost a lot of time. I finally decided to copy/paste the existing code. I simplified it as, I think, we do not want the plugin, etc. like in the full biblio editor. Signed-off-by: Josef Moravec Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #28 from Jonathan Druart--- Created attachment 72258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72258=edit Bug 19289: Use jQuery validate plugin This is quite dirty but rewrite the JS checks is out of the scope of this bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Jonathan Druartchanged: What|Removed |Added Attachment #69114|0 |1 is obsolete|| Attachment #69115|0 |1 is obsolete|| Attachment #70706|0 |1 is obsolete|| Attachment #70765|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 72256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72256=edit Bug 19289: Add existing fields to the ACQ framework When ordering, the bibliographic details contain the title, author, publisher code, publication year, isbn and series info. To avoid regression to provide the same behaviour, we will add these fields to the ACQ framework NOTE: This patch makes the change only for - en - fr / unimarc complet Other frameworks will be updated before to be pushed, to avoid unecessary rebases Signed-off-by: Josef Moravec Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #25 from Jonathan Druart--- (In reply to Katrin Fischer from comment #24) > Hi Jonathan, > > continuing here. Could you please rebase? Will do. > (In reply to Jonathan Druart from comment #23) > > (In reply to Katrin Fischer from comment #22) > > > QA tools pass. > > > > > > Some first notes from reading the code: > > > > > > 1) > > > installer/data/mysql/en/marcflavour/marc21/mandatory/ > > > marc21_framework_DEFAULT.sql > > > > > > It looks like the code makes some assumptions about > > > biblioitems.publicationyear. There is something you will not like about > > > this > > > field: It's only used by UNIMARC by default. MARC21 installations safe > > > that > > > information to biblio.copyrightdate. Both use cases need to be supported. > > > > It is the current behaviour, neworderempty.tt displays > > biblioitems.publicationyear. > > If it is an existing bug it needs to be fixed on a separate bug report. > > I have thought about this some and I think for MARC21 just replace > publicationyear with copyrightdate. The problem is: it will create on > mapping. There is no field mapped to publicationyear in a MARC21 > installation so the SQL will do nothing as it is on a MARC21 installation > most likely. If you change it to copyrightyear the field will be filled as > it's in the other frameworks and we will only have to deal with a display > problem. Ideal would probably be check what exists in the frameworks you are > pulling from and use that. I am not sure I understand the problem neither the solution, but I have tried and provided a patch. Let me know if it is what you had in mind. > > > 3) Atomicupdate doesn't include changes for creating the ACQ framework. > > > > ACQ framework was added by bug 3841 for new installation. I do not think we > > should deal with existing installation (what about those having already the > > framework?) > > On my installation that meant after activating the rule I had an empty > framework. The ACQ framework was only created with 952, so no fields the > record itself. Giving a more complete sample with the most important fields > would be good as entering this data is very annoying. At the moment an acq > record is created with the default framework - will it be ACQ now? Couldn't > test because of the conflicts. I am a bit worried people will forget to add > important fields like the leader (causes problems with encoding), 999 > (causing problems at indexing) and others. ACQ is only use for display purpose here, so no need to add fields we do not want to see. > > > 3) koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt > > > A lot of FIXMEs in this code? > > > > It is to highlight the fact that the default values defined in ACQ will not > > be taken into account. I can remove it if you think it is confusing > > As some code editors let you highlight strings like FIXME I think we should > not use if it's not a real FIXME maybe. Why will the default not be used? > Are there other limits (plugins?) No, nothing else is used, no default, no plugin, etc. We display a dropdown list if linked with a authorised value list and make the field mandatory if marked as it in the framework. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #24 from Katrin Fischer--- Hi Jonathan, continuing here. Could you please rebase? (In reply to Jonathan Druart from comment #23) > (In reply to Katrin Fischer from comment #22) > > QA tools pass. > > > > Some first notes from reading the code: > > > > 1) > > installer/data/mysql/en/marcflavour/marc21/mandatory/ > > marc21_framework_DEFAULT.sql > > > > It looks like the code makes some assumptions about > > biblioitems.publicationyear. There is something you will not like about this > > field: It's only used by UNIMARC by default. MARC21 installations safe that > > information to biblio.copyrightdate. Both use cases need to be supported. > > It is the current behaviour, neworderempty.tt displays > biblioitems.publicationyear. > If it is an existing bug it needs to be fixed on a separate bug report. I have thought about this some and I think for MARC21 just replace publicationyear with copyrightdate. The problem is: it will create on mapping. There is no field mapped to publicationyear in a MARC21 installation so the SQL will do nothing as it is on a MARC21 installation most likely. If you change it to copyrightyear the field will be filled as it's in the other frameworks and we will only have to deal with a display problem. Ideal would probably be check what exists in the frameworks you are pulling from and use that. > > 2) Only en and fr-FR installers are changed? > > Yes, what I wrote in the first commit message "Other frameworks will be > updated before to be pushed, to avoid unecessary rebases" > Same changes will be copied/pasted to other installer files before push. OK > > 3) Atomicupdate doesn't include changes for creating the ACQ framework. > > ACQ framework was added by bug 3841 for new installation. I do not think we > should deal with existing installation (what about those having already the > framework?) On my installation that meant after activating the rule I had an empty framework. The ACQ framework was only created with 952, so no fields the record itself. Giving a more complete sample with the most important fields would be good as entering this data is very annoying. At the moment an acq record is created with the default framework - will it be ACQ now? Couldn't test because of the conflicts. I am a bit worried people will forget to add important fields like the leader (causes problems with encoding), 999 (causing problems at indexing) and others. > > > 3) koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt > > A lot of FIXMEs in this code? > > It is to highlight the fact that the default values defined in ACQ will not > be taken into account. I can remove it if you think it is confusing As some code editors let you highlight strings like FIXME I think we should not use if it's not a real FIXME maybe. Why will the default not be used? Are there other limits (plugins?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Katrin Fischerchanged: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #23 from Jonathan Druart--- (In reply to Katrin Fischer from comment #22) > QA tools pass. > > Some first notes from reading the code: > > 1) > installer/data/mysql/en/marcflavour/marc21/mandatory/ > marc21_framework_DEFAULT.sql > > It looks like the code makes some assumptions about > biblioitems.publicationyear. There is something you will not like about this > field: It's only used by UNIMARC by default. MARC21 installations safe that > information to biblio.copyrightdate. Both use cases need to be supported. It is the current behaviour, neworderempty.tt displays biblioitems.publicationyear. If it is an existing bug it needs to be fixed on a separate bug report. > 2) Only en and fr-FR installers are changed? Yes, what I wrote in the first commit message "Other frameworks will be updated before to be pushed, to avoid unecessary rebases" Same changes will be copied/pasted to other installer files before push. > 3) Atomicupdate doesn't include changes for creating the ACQ framework. ACQ framework was added by bug 3841 for new installation. I do not think we should deal with existing installation (what about those having already the framework?) > 3) koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt > A lot of FIXMEs in this code? It is to highlight the fact that the default values defined in ACQ will not be taken into account. I can remove it if you think it is confusing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #22 from Katrin Fischer --- QA tools pass. Some first notes from reading the code: 1) installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql It looks like the code makes some assumptions about biblioitems.publicationyear. There is something you will not like about this field: It's only used by UNIMARC by default. MARC21 installations safe that information to biblio.copyrightdate. Both use cases need to be supported. 2) Only en and fr-FR installers are changed? 3) Atomicupdate doesn't include changes for creating the ACQ framework. 3) koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt A lot of FIXMEs in this code? Jonathan, can you please take a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #21 from Séverine Queune--- (In reply to Jonathan Druart from comment #20) > Created attachment 70765 [details] [review] > Bug 19289: Use jQuery validate plugin > > This is quite dirty but rewrite the JS checks is out of the scope of > this bug report. Hi Jonathan, I just create a new bud report (#20087) for this problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Séverine Queunechanged: What|Removed |Added Blocks||20087 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20087 [Bug 20087] When UseACQFrameworkForBiblioRecords in on, required fields can be empty -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #20 from Jonathan Druart--- Created attachment 70765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70765=edit Bug 19289: Use jQuery validate plugin This is quite dirty but rewrite the JS checks is out of the scope of this bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #19 from Séverine Queune--- Hi Jonathan, Nicolas applied this morning the patch in our local instance, and everything seems to work as expected, except that we don't have any more warnings if required fields are empty, and the order is saved. I just tried once again in Biblibre's sandbox#2 and behaviour is the same. I'm really sorry I didn't notice it during my tests, it's not logical for me to try to save a form without the required fields so I didn't think about testing it. Do you need a new bug report ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #18 from Jonathan Druart--- (In reply to Nicolas Legrand from comment #16) > is it me or there is a catalog_details.js that should be there and is not? It was a first try, but I did not create this file finally. This line should be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #17 from Jonathan Druart--- Created attachment 70706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70706=edit Bug 19289: Remove reference to a non-existent .js file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #16 from Nicolas Legrand--- is it me or there is a catalog_details.js that should be there and is not? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Nicolas Legrandchanged: What|Removed |Added Attachment #68810|0 |1 is obsolete|| --- Comment #14 from Nicolas Legrand --- Created attachment 69114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69114=edit Bug 19289: Add existing fields to the ACQ framework When ordering, the bibliographic details contain the title, author, publisher code, publication year, isbn and series info. To avoid regression to provide the same behaviour, we will add these fields to the ACQ framework NOTE: This patch makes the change only for - en - fr / unimarc complet Other frameworks will be updated before to be pushed, to avoid unecessary rebases Signed-off-by: Josef Moravec Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Nicolas Legrandchanged: What|Removed |Added Attachment #68811|0 |1 is obsolete|| --- Comment #15 from Nicolas Legrand --- Created attachment 69115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69115=edit Bug 19289: Use the ACQ framework to display bibliographic details The ACQ MARC framework is only used for the ‘Item’ block. This patch add the ability to define biblio fields (!= 995 or 952) to customize the display of the bibliographic details when ordering. This new feature is controlled by a new pref: UseACQFrameworkForBiblioRecords Test plan: - Create a new installation to populate the ACQ framework correctly - Set the pref UseACQFrameworkForBiblioRecords to "Use" - Create a new order => You will see the lib from the ACQ framework - Add/remove/update biblio subfields in the ACQ framework - Create a new order => You should see the new subfields displayed Note for QA: I though I would be able to refactor existing code to make it more flexible, but it is a bit messy and lost a lot of time. I finally decided to copy/paste the existing code. I simplified it as, I think, we do not want the plugin, etc. like in the full biblio editor. Signed-off-by: Josef Moravec Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #13 from Séverine Queune--- I can't sign it from Biblibre's sandbox because of the dependency, but ok for me ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #12 from Séverine Queune--- (In reply to Jonathan Druart from comment #11) > Hi Séverine, I have created the correct ACQ framework only for: > > en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql > fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql > > When you setup the sandbox, tick "No database (run webinstaller)" to use the > files used from the Koha codebase and not the database created for the > sandbox. > > Otherwise you can remove the subfield (@) from 009. Thanks Jonathan ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #11 from Jonathan Druart--- Hi Séverine, I have created the correct ACQ framework only for: en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql When you setup the sandbox, tick "No database (run webinstaller)" to use the files used from the Koha codebase and not the database created for the sandbox. Otherwise you can remove the subfield (@) from 009. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #10 from Séverine Queune--- Created attachment 69016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69016=edit ACQ framework - Display only used tags/subfields Here is the ACQ framework structure with only the used subfields and as you can see, there is no informations about "9 (RLIN)" fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #9 from Séverine Queune--- Created attachment 69015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69015=edit Add to basket from new empty recvord I worked on Biblibre's sandbox #2 and modified the ACQ framework to get the structure we want to use, but I couldn’t found where the "9 (RLIN)" fields that I see when I add an order from a new empty record come from. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #8 from Jonathan Druart--- Can you detail please? This is what I see when I install using "en"/MARC21: https://screenshots.firefox.com/cJdFOY6Lk1Ves2KK/pro.kohadev.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #7 from Séverine Queune--- (In reply to Jonathan Druart from comment #6) > (In reply to Séverine Queune from comment #5) > > I wanted to test this patch even thought it's signed off but I couldn't > > apply it on Biblibre's sandbox. > > It applies correctly for me on top of bug 3841, did you apply the dependency > patches before? My bad, I didn't see the dependency... It seems to work quite good. I tested with new empty records and existing records and all fields are diplayed as expected. I just wonder about these fields in the 'Catalog details' framework that I didn't found on the MARC framework structure : 9 (RLIN) (6489) 9 (RLIN) (6549) 9 (RLIN) (6559) 9 (RLIN) (6569) 9 (RLIN) (6579) 9 (RLIN) (6589) 9 (RLIN) (6629) I don't know where they come from and i can't mask them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #6 from Jonathan Druart--- (In reply to Séverine Queune from comment #5) > I wanted to test this patch even thought it's signed off but I couldn't > apply it on Biblibre's sandbox. It applies correctly for me on top of bug 3841, did you apply the dependency patches before? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #5 from Séverine Queune--- I wanted to test this patch even thought it's signed off but I couldn't apply it on Biblibre's sandbox. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #4 from Josef Moravec--- Created attachment 68811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68811=edit Bug 19289: Use the ACQ framework to display bibliographic details The ACQ MARC framework is only used for the ‘Item’ block. This patch add the ability to define biblio fields (!= 995 or 952) to customize the display of the bibliographic details when ordering. This new feature is controlled by a new pref: UseACQFrameworkForBiblioRecords Test plan: - Create a new installation to populate the ACQ framework correctly - Set the pref UseACQFrameworkForBiblioRecords to "Use" - Create a new order => You will see the lib from the ACQ framework - Add/remove/update biblio subfields in the ACQ framework - Create a new order => You should see the new subfields displayed Note for QA: I though I would be able to refactor existing code to make it more flexible, but it is a bit messy and lost a lot of time. I finally decided to copy/paste the existing code. I simplified it as, I think, we do not want the plugin, etc. like in the full biblio editor. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Josef Moravecchanged: What|Removed |Added Attachment #68640|0 |1 is obsolete|| Attachment #68641|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 68810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68810=edit Bug 19289: Add existing fields to the ACQ framework When ordering, the bibliographic details contain the title, author, publisher code, publication year, isbn and series info. To avoid regression to provide the same behaviour, we will add these fields to the ACQ framework NOTE: This patch makes the change only for - en - fr / unimarc complet Other frameworks will be updated before to be pushed, to avoid unecessary rebases Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Josef Moravecchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #2 from Jonathan Druart--- Created attachment 68641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68641=edit Bug 19289: Use the ACQ framework to display bibliographic details The ACQ MARC framework is only used for the ‘Item’ block. This patch add the ability to define biblio fields (!= 995 or 952) to customize the display of the bibliographic details when ordering. This new feature is controlled by a new pref: UseACQFrameworkForBiblioRecords Test plan: - Create a new installation to populate the ACQ framework correctly - Set the pref UseACQFrameworkForBiblioRecords to "Use" - Create a new order => You will see the lib from the ACQ framework - Add/remove/update biblio subfields in the ACQ framework - Create a new order => You should see the new subfields displayed Note for QA: I though I would be able to refactor existing code to make it more flexible, but it is a bit messy and lost a lot of time. I finally decided to copy/paste the existing code. I simplified it as, I think, we do not want the plugin, etc. like in the full biblio editor. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 --- Comment #1 from Jonathan Druart--- Created attachment 68640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68640=edit Bug 19289: Add existing fields to the ACQ framework When ordering, the bibliographic details contain the title, author, publisher code, publication year, isbn and series info. To avoid regression to provide the same behaviour, we will add these fields to the ACQ framework NOTE: This patch makes the change only for - en - fr / unimarc complet Other frameworks will be updated before to be pushed, to avoid unecessary rebases -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Jonathan Druartchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Jonathan Druartchanged: What|Removed |Added Summary|Allow configuration of the |Allow configuration of the |fields on the ‘Catalog |fields on the 'Catalog |details’ form in the|details' form in the |acquisition baskets |acquisition baskets -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the ‘Catalog details’ form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Jonathan Druartchanged: What|Removed |Added Depends on||3841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841 [Bug 3841] Should have Default ACQ Framework -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the ‘Catalog details’ form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Jonathan Druartchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=12743 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the ‘Catalog details’ form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Séverine Queunechanged: What|Removed |Added CC||nicolas.legr...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the ‘Catalog details’ form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Jonathan Druartchanged: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the ‘Catalog details’ form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Séverine Queunechanged: What|Removed |Added Change sponsored?|Seeking developer |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19289] Allow configuration of the fields on the ‘Catalog details’ form in the acquisition baskets
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Séverine Queunechanged: What|Removed |Added Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/