[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #288 from Christopher Brannon --- So let me ask this. Instead of trying to overhaul the existing deletion tables, would it be easier to try to insert an option between - as a starting point? So, instead of doing away with a deleted table (which might resolve the question of what to do with said tables if we changed how things are deleted), how about we just add a new option - like "Mark for deletion". We could add a deleted column to the table in which a date is posted if this option is marked on a record. Then we could start having Koha omit records in searches that have a date in that field. The record would be there, and in tact, it just wouldn't appear in any regular searches. We could allow the batch tools to still interact with these records, and move them to the deleted tables if desired. Everything from that point would behave the same as it does currently. We could also introduce a new tool to search for these "Marked deleted" records, and undo the mark for deletion, restoring the record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Emily Lamancusa changed: What|Removed |Added Blocks|10758 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 [Bug 10758] acqui/basket: Show bibliographic information of deleted records -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30888 --- Comment #287 from Marcel de Rooy --- See also bug 30888. It introduces deletedauth_header now for deleted authorities. In its current form it is a fairly simple patch set. But if we would want to introduce deleted authorities in the current auth_header table, it would be a completely different story for all the reasons already mentioned in the earlier comments. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #286 from Victor Grousset/tuxayo --- The problem is not to test the concept of delete flagging. The patches on this ticket well demonstrated that. Even without that already done, not sure that was ever a question. The difficulty is that biblio, biblioitems, biblio_metadata, and items (and their counterpart) are used in a lot of places in Koha. Even taken individually that is still **a lot** of places to change, **test** and review. Really a lot of workflows to check for regression. Automated test coverage doesn't seem enough. Not sure there is any way to be sure enough to not miss many usages of biblio, biblioitems, biblio_metadata, and items. And thus avoid shipping a few regressions in edge cases. That needs to be weighted against the benefits of this refactoring. (In reply to Katrin Fischer from comment #281) > Securing funding is one part, but the other part is to come to a decision as > community about these change and ensure that there will be enough > time/committment to see it through, if it's decided to do this. [...] > I am not fully persuaded on benefits vs. work/risk yet, but would be open to > be persuaded. +1 , money can buy a provider to have someone do the painful task of changing a lot of the table usage everywhere. But it still needs other people in the community to test and review it. And the benefits that refactoring need to be weighted against the huge cost in testing and QA. Given the current huge bottleneck on signoff (141 waiting tickets (25 bugfixes)) and QA (168 tickets, (26 bugfixes)) including other refactorings, the benefits of this one need to be big also. In the long run, which alternate timeline Koha **can be expected** to have the less bugs, cleaner code, most features? That depends on the benefits of the refactoring here. Even finding a way to do that incrementally (something with DB views maybe?) to avoid the need of pulling out of massive effort spike won't make the problem of overall testing and review effort go away. A way to make the question way easier is to get literally a dozen or more **weekly active** librarians and Koha sysadmins to do some patch testing. Making the bottleneck mostly go away. Librarians, rise up! (and library executives: let the workers improve their tools!) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #285 from Christopher Brannon --- No, but if you want to start small, and at least do a proof of concept, you might try out the delete flagging technique on something that doesn't have a delete table, then if that goes well, try a table that does have a delete table. I was trying to offer a suggestion of an easier proof of concept. Something that people could see in operation and get behind. I threw circ rules at this, because eventually it might be useful to be able to delete (and recover) deleted rules. If you have a better suggestion, go for it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #284 from Katrin Fischer --- (In reply to Christopher Brannon from comment #283) > (In reply to Marcel de Rooy from comment #282) > > When reviving this one, it might be wise to do it one by one table instead? > > If doing it table by table would help move it along, I would go for that. > The first one could be proof of concept, at least. Maybe pick something > that would have the least impact, or maybe even try something we haven't > done deletions on yet. Maybe circ rules? But circ rules don't need merging? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #283 from Christopher Brannon --- (In reply to Marcel de Rooy from comment #282) > When reviving this one, it might be wise to do it one by one table instead? If doing it table by table would help move it along, I would go for that. The first one could be proof of concept, at least. Maybe pick something that would have the least impact, or maybe even try something we haven't done deletions on yet. Maybe circ rules? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #282 from Marcel de Rooy --- When reviving this one, it might be wise to do it one by one table instead? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Dave changed: What|Removed |Added CC||ddagh...@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #281 from Katrin Fischer --- Securing funding is one part, but the other part is to come to a decision as community about these change and ensure that there will be enough time/committment to see it through, if it's decided to do this. If that's the case I could imagine freezing a version for all other changes (but bug fixes) to ensure there is no distraction, proper testing and we are not working against an ever changing codebase. I am not fully persuaded on benefits vs. work/risk yet, but would be open to be persuaded. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #280 from Christopher Brannon --- (In reply to Victor Grousset/tuxayo from comment #279) > > Is this at a place for testing, or does more work need to be done? > > Testing became impossible after a few weeks after the last code update long > ago. > It needs a really big work to be reapplied to the current code, since this > touches many parts of Koha, as the time passes there a many places where > there have been diverging changes. And likely some new places using the old > tables that would need to be found and the tables merged. Overall it's like > partially redoing the work over again. We would really like to see this development through to completion. I've asked before, with no response, is this being funded? Does anyone have a bid on this development? We would be probably be interested in contributing to this cause. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #279 from Victor Grousset/tuxayo --- > Is this at a place for testing, or does more work need to be done? Testing became impossible after a few weeks after the last code update long ago. It needs a really big work to be reapplied to the current code, since this touches many parts of Koha, as the time passes there a many places where there have been diverging changes. And likely some new places using the old tables that would need to be found and the tables merged. Overall it's like partially redoing the work over again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Christopher Brannon changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30392 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #278 from Christopher Brannon --- Is this at a place for testing, or does more work need to be done? If there are funding issues, please let us know what funds are needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #277 from Rhonda Kuiper --- Adding my support for this enhancement. Hope we can get it moving again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Michaela Sieber changed: What|Removed |Added CC||michaela.sie...@kit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #276 from Christopher Brannon --- (In reply to Victor Grousset/tuxayo from comment #275) > If I recall correctly testing was most of what this patch needed. > To check if stuff was broken in many parts of Koha. > At the time, it was possible to test it (except crons) using the sandboxes, > so non-programmers could have helped a lot without much being limited. If that is the case, we can certainly rally people to test in sandboxes, if the sandboxes are still functioning. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #275 from Victor Grousset/tuxayo --- If I recall correctly testing was most of what this patch needed. To check if stuff was broken in many parts of Koha. At the time, it was possible to test it (except crons) using the sandboxes, so non-programmers could have helped a lot without much being limited. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #274 from Christopher Brannon --- What would it mean to have many people focus on it? Previously you asked for more eyes and feedback. I'm not setup to get into the development side of things, but if there is anything several non-programmers can do to help and give feedback, I'm sure we can generate interest and people to do what they can. Can you be more specific on what is needed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #273 from Jonathan Druart --- The best hope is to find people to focus on it at the same time. Having someone to rebase it is not enough, I have rebased it and adjusted it dozens of times already. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #272 from Victor Grousset/tuxayo --- At this point the best hope would be for a few user libraries to pool funding together and contract a support company to revive this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org --- Comment #271 from AspenCat Team --- After discussing this a bit with Christopher I have to agree that I think this would make life a lot easier for libraries. Periodically we have accidental patron deletes, and it is not easy getting the toothpaste back in the tube once things move to the deleted items table. This seems like a far easier approach to managing this data I would be very interested in this moving forward. - Bob Bennhoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Michael Adamyk changed: What|Removed |Added CC||mada...@ckls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #270 from Christopher Brannon --- I see this bug stalled back in 2020. I LOVE the concept of it, and hope it can pick up momentum again. I think leaving deleted things in their original tables with a date to flag deletion is a positively brilliant idea. It would leave links in tact where needed, and make it so easy to implement an undo feature of deletion down the road. If this project is too big, maybe it can be done in phases? Just a shame it hasn't move in a couple of years. This would be a HUGE step forward for Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Charles Kelley changed: What|Removed |Added CC||cmkelley...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added Blocks|11983 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 rkui...@roundrocktexas.gov changed: What|Removed |Added CC||rkui...@roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c |koha-b...@lists.koha-commun |ommunity.org|ity.org Keywords|rel_20_11_target, | |RM_priority | --- Comment #269 from Jonathan Druart --- Regarding the lack of interest in the time-frame I expected, I am removing myself as assignee of this one. I will be happy to help anybody else who would be willing to work on it however. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #268 from Jonathan Druart --- This is now "in discussion". More eyes and feedback are needed urgently. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #267 from Jonathan Druart --- Remote branch has been rebased against master, few tweaks made: * new commit "Bug 20271: Fix - is_current is nullable" * Only 1 "DBIC changes" commit and a separate "Declare is_current as boolean in schema" to deal with is_boolean. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #266 from David Cook --- (In reply to Jonathan Druart from comment #264) > (In reply to Nick Clemens from comment #261) > > Maybe it is too late to ask this question: Rather than joining items and > > deleteditems, can we join them into a new table and provide views for both > > of the old tables? This would prevent breaking reports across the board. > > > > biblio, deletedbiblios => biblios? > > items,deleteditems => all_items? > > > > This is going to be a big problem for existing users, it is going to be many > > reports, and it is going to cause disruption. Havign views that keep the > > reports working would be a huge boon. > > Yes Nick, this will be addressed on bug 25921. > However, I don't think it's a good idea to rename the table to have an > inconsistent name. We could rename biblio to biblio, but items is correct. > My opinion is that it should be quite trivial to fix the report in an update > DB. > * \sitems can be replaced with items_legacy > * \sbiblio => biblio_legacy > * and so on That's a good point. I wouldn't trust the report DB update to be 100% effective, but effective enough. Even if someone had to manually update a couple reports here and there with items_legacy or biblio_legacy... having the ability to use those legacy views would be good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Margaret changed: What|Removed |Added CC||margaret@bywatersolutions.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #265 from Jonathan Druart --- New commits are: Bug 20271: Prevent cover image to be attached to a deleted record Bug 20271: Prevent biblio to be modified in batch Bug 20271: Prevent marked as deleted items to be added to lists Bug 20271: (follow-up) Rely on indexed columns Bug 20271: Prevent edition of marked as deleted items Bug 20271: Make Orders->items return current items only Bug 20271: CanBookBeReserved must not check marked as deleted items Bug 20271: Prevent marked as delete items to be batch edited/deleted Bug 20271: Delete attached holds when an item is deleted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #264 from Jonathan Druart --- (In reply to Nick Clemens from comment #260) > (In reply to Jonathan Druart from comment #259) > > Patches have been rebased against master. > > Looking here: > 1 - Foreign key constraints on items table 'ON DELETE' updates are affected > here - for instance a hold is not deleted if an item is deleted (can be done > from additem.pl) See previous comment and the pad for discussion > 2 - Batch mod and batch delete should not allow altering deleted items Done! > 3 - CanBookBeReserved should not check deleted items (missing is_current => > 1) Done! (In reply to Nick Clemens from comment #261) > Maybe it is too late to ask this question: Rather than joining items and > deleteditems, can we join them into a new table and provide views for both > of the old tables? This would prevent breaking reports across the board. > > biblio, deletedbiblios => biblios? > items,deleteditems => all_items? > > This is going to be a big problem for existing users, it is going to be many > reports, and it is going to cause disruption. Havign views that keep the > reports working would be a huge boon. Yes Nick, this will be addressed on bug 25921. However, I don't think it's a good idea to rename the table to have an inconsistent name. We could rename biblio to biblio, but items is correct. My opinion is that it should be quite trivial to fix the report in an update DB. * \sitems can be replaced with items_legacy * \sbiblio => biblio_legacy * and so on What do you think? > Otherwise: > > I mostly tested functionality in this pass rather than reading the code, > there are some areas that need attention. > > Acquisitions - Can delete ordered items and recieve them > > Can edit deleted items by forcing URL in additem.pl > > Can add to list using deleted barcodes > > Can add deleted items to label batches and rotating collections > > Batch record modification: Can load deleted records - then modification fails > > Can attach images to deleted records All fixed. > Canned reports - I don't think these were checked: > grep items /kohadevbox/koha/reports/* -c > grep is_current /kohadevbox/koha/reports/* -c That one sounds tricky, will try to fix later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #263 from Jonathan Druart --- (In reply to Nick Clemens from comment #260) > (In reply to Jonathan Druart from comment #259) > > Patches have been rebased against master. > > Looking here: > 1 - Foreign key constraints on items table 'ON DELETE' updates are affected > here - for instance a hold is not deleted if an item is deleted (can be done > from additem.pl) Indeed. I listed itemnumber FK here: (I am adding FIX when this patchset will actually fix the problem for this column ie. we won't lose anymore the FK): * branchtransfers.itemnumber => must be deleted when marked as deleted * issues.itemnumber => there is a restrict at DB level and a FIXME in the code, I am opening a new bug report * items_last_borrower => FIX * creator_batches => ? TODO? * reserves => follow-up is coming * old_reserves => no change expected * serialitems => ? TODO? * tmp_holdsqueue => follow-up is coming * accountlines => I need help on this one, hard to tell for me * course_items => follow-up is coming * hold_fill_targets => ? TODO? * article_requests => FIX? (as there is a on delete set null) * club_holds => I did not manage to have clubs.item_id different than NULL. How do I do that? (see bug 19618 comment 38) * stockrotationitems => I am not familiar with stock rotation, but I am expecting change in behaviour here - TODO? * return_claims => FIX (?) biblionumber FK: * biblioitems => OK * items => It's handled in an ugly way in DelBiblio. Must be fixed later with a move to Koha::Biblio * reserves => Done in DelBiblio * old_reserves => no change expected here * reviews => FIX * subscription => Done in DelBiblio (Note that maybe we could remove that to have a "undo" ft) * serial => will be deleted on cascade when the subscription will be deleted * subscriptionhistory => same as before * tags_all, tags_index => I think the tags must be deleted when the biblio is marked as deleted TODO? * virtualshelfcontents => TODO! We will deleted to restore the existing behaviour * suggestions => TODO, restoring existing behaviour * aqorders => FIX (?) see also bug 10758 * biblioimages => FIX (?) this will take disk space, but can be reused for "undo". Can be done to restore the existing behaviour if needed * ratings => FIX (?) same as biblioimages for "undo" * hold_fill_targets => TODO? * article_requests => TODO? * biblio_metadata => OK * club_holds => TODO I have opened a pad at https://annuel2.framapad.org/p/koha_bug_20271_fk-9im9?lang=en Please discuss there and I will copy it back here once we are done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Tomáš Wünsch changed: What|Removed |Added CC||frak...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #262 from David Cook ---
(In reply to Nick Clemens from comment #261)
> Maybe it is too late to ask this question: Rather than joining items and
> deleteditems, can we join them into a new table and provide views for both
> of the old tables? This would prevent breaking reports across the board.
>
> biblio, deletedbiblios => biblios?
> items,deleteditems => all_items?
>
> This is going to be a big problem for existing users, it is going to be many
> reports, and it is going to cause disruption. Havign views that keep the
> reports working would be a huge boon.
It's an interesting idea. It would be nice to preserve that backwards
compatibility.
I think MySQL supports read/write for views, so in theory it could work...
--
I imagine another issue would be changing the tables used in the DBIC
definitions?
However, I don't think Biblio or Item were extensively used directly...
C4/Circulation.pm:my @itemnumbers =
$schema->resultset('Item')->search(
circ/renew.pl:$item = $schema->resultset("Item")->single( { barcode =>
$barcode } );
Koha/Edifact/Order.pm:my $i_obj = $schema->resultset('Item')->find(
$item->itemnumber );
Koha/EDI.pm:my $item = $schema->resultset('Item')->find(
$ilink->itemnumber );
Koha/EDI.pm:my $rs = $schema->resultset('Item')->search(
Koha/EDI.pm:my $item = $schema->resultset('Item')->find(
$ilink->itemnumber );
Koha/BiblioUtils.pm: $schema->resultset('Biblio')->search(
So then it would just be updating Koha/Item.pm and Koha/Biblio.pm with the new
ResultSet module name.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #261 from Nick Clemens --- Maybe it is too late to ask this question: Rather than joining items and deleteditems, can we join them into a new table and provide views for both of the old tables? This would prevent breaking reports across the board. biblio, deletedbiblios => biblios? items,deleteditems => all_items? This is going to be a big problem for existing users, it is going to be many reports, and it is going to cause disruption. Havign views that keep the reports working would be a huge boon. Otherwise: I mostly tested functionality in this pass rather than reading the code, there are some areas that need attention. Acquisitions - Can delete ordered items and recieve them Can edit deleted items by forcing URL in additem.pl Can add to list using deleted barcodes Can add deleted items to label batches and rotating collections Batch record modification: Can load deleted records - then modification fails Can attach images to deleted records Canned reports - I don't think these were checked: grep items /kohadevbox/koha/reports/* -c grep is_current /kohadevbox/koha/reports/* -c -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #260 from Nick Clemens --- (In reply to Jonathan Druart from comment #259) > Patches have been rebased against master. Looking here: 1 - Foreign key constraints on items table 'ON DELETE' updates are affected here - for instance a hold is not deleted if an item is deleted (can be done from additem.pl) 2 - Batch mod and batch delete should not allow altering deleted items 3 - CanBookBeReserved should not check deleted items (missing is_current => 1) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #259 from Jonathan Druart --- Patches have been rebased against master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Blocks|26080 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 [Bug 26080] Use the task queue for the batch delete records tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #258 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #256) > Bug found: OPAC results lists deleted items > > - delete items from a record > - do a search that returns the record among other ones > - in the results you should see «Items available for loan: MyLibrary (2). » > - this is wrong > - click on the result > - «No physical items for this record»: as expected > - add in a list > - go to the list > - you should see «Items available for loan: MyLibrary (2). » > - this is wrong (should be the same cause) Should be fixed by "Bug 20271: Fix XSLT display" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #257 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #255) > Should be fixed now by "Bug 20271: Handle items marked as deleted in the > circ module" Confirmed :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #256 from Victor Grousset/tuxayo --- Bug found: OPAC results lists deleted items - delete items from a record - do a search that returns the record among other ones - in the results you should see «Items available for loan: MyLibrary (2). » - this is wrong - click on the result - «No physical items for this record»: as expected - add in a list - go to the list - you should see «Items available for loan: MyLibrary (2). » - this is wrong (should be the same cause) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #255 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #253) > Bug found: it's possible to check out a deleted item. > - find a record > - copy the barcode of an item > - delete it > - check it out > - it works :o Should be fixed now by "Bug 20271: Handle items marked as deleted in the circ module" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #254 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #252) > (In reply to Victor Grousset/tuxayo from comment #251) > > Does anyone know something worth to test with UNIMARC? > > Not UNIMARC specific, but did you see: > https://lite.framacalc.org/9hdw-bug_20271 ? Collected ideas on what to test > there. Yes, that's what I was doing but also wondered if something could impact only UNIMARC (or NORMARC) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #253 from Victor Grousset/tuxayo --- Bug found: it's possible to check out a deleted item. - find a record - copy the barcode of an item - delete it - check it out - it works :o -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #252 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #251) > Does anyone know something worth to test with UNIMARC? Not UNIMARC specific, but did you see: https://lite.framacalc.org/9hdw-bug_20271 ? Collected ideas on what to test there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #251 from Victor Grousset/tuxayo --- Does anyone know something worth to test with UNIMARC? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #250 from Victor Grousset/tuxayo --- For what it's worth. Nothing suspicious found after rereading the whole diff. Also, deleted an item when using ES and restored it manually via the DB. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #249 from Victor Grousset/tuxayo --- Potentially incorrect remaining occurrences of the old tables: misc/cronjobs/cleanup_database.pl > (from tables deleteditems, deletedbiblioitems, deletedbiblio_metadata and > deletedbiblio). It's the usage string for the option --deleted-catalog. - Nothing else suspicious found when greping deleteditems, deletedbiblioitems, deletedbiblio and deletedbiblio_metadata -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Blocks||26080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26080 [Bug 26080] Use the task queue for the batch delete records tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #248 from Jonathan Druart --- All Koha gitlab projects have this problem (because of the size). I will deal with that in the next couple of months. The remote branch is up-to-date however ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #247 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #246) > (In reply to Marcel de Rooy from comment #245) > > fatal: repository 'https://gitlab.com/joubu/Koha/commits/bug_20271/' not > > found > > ?? > > When do you get this error? > > % git remote add joubu https://gitlab.com/joubu/koha.git > % git fetch joubu > % git checkout -b bug_20271 Yeah when adding the remote bug_20271 and doing the fetch. Did you see the warnings on your gitlab: This project is mirrored from https://*@gitlab.com/koha-community/Koha.git. Pull mirroring failed 1 year ago. Repository mirroring has been paused due to too many failed attempts, and can be resumed by a project maintainer. Last successful update 1 year ago. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #246 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #245) > fatal: repository 'https://gitlab.com/joubu/Koha/commits/bug_20271/' not > found > ?? When do you get this error? % git remote add joubu https://gitlab.com/joubu/koha.git % git fetch joubu % git checkout -b bug_20271 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #245 from Marcel de Rooy --- fatal: repository 'https://gitlab.com/joubu/Koha/commits/bug_20271/' not found ?? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25260 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #244 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #242) > From what I understand cleanup_database.pl (and maybe other things) still > rely on the original table names, so with the patchset, the views. > > It would be in a follow up to use the new tables right? (and check if > deleted) To work incrementally and not further add to this patchset. > > Or maybe that's a good use of views that it would be better to keep? We missed it, should be corrected in this patchset. Fixed in a new commit "Bug 20271: Correct occurrences in cleanup_database.pl" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #243 from Jonathan Druart --- The failure from t/db_dependent/Items.t should be fixed by bug 25964. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #242 from Victor Grousset/tuxayo --- From what I understand cleanup_database.pl (and maybe other things) still rely on the original table names, so with the patchset, the views. It would be in a follow up to use the new tables right? (and check if deleted) To work incrementally and not further add to this patchset. Or maybe that's a good use of views that it would be better to keep? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #241 from Victor Grousset/tuxayo --- with koha-testing-docker (images up to date, including DB and ES) Debian 9 with MariaDB 10.1 Debian 10 with MariaDB 10.3 (and ES 6 in case that matters) prove t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #240 from Martin Renvoize --- Tomas and I have been discussing the possibilities to rename the tables here so we can reuse the current table names for the views and thus nicely sidestep the reports challenges. I didn't get the failures you mention Victor... Wonder how our setups differ. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #239 from Victor Grousset/tuxayo --- > is there a way to disable the output Found. The declarations of the views can be found with `git grep "ResultSource::View"` Beside from me removing them now to check for other warnings. We might want later to not have the tests logs cluttered with this right? Should I create a followup bug about hiding the output of view creations? (happens more than 100 times in the full suite) So the results: no suspicious difference found in the output between running the test suite without and with the patch set. Typo found: installer/data/mysql/atomicupdate/bug_20271_-_merge_deletedbiblio_and_deleteitems_tables_with_their_alive_cousins.perl > # Create the views for backward compatibility in reportrs «reportrs» -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #238 from Victor Grousset/tuxayo --- When running the tests, is there a way to disable the output of «running "CREATE VIEW "items_legacy"» ? There are more than 100 of those outputs when running the tests. I commented all instances of CREATE VIEW - installer/data/mysql/kohastructure.sql - installer/data/mysql/atomicupdate/bug_20271_-_merge_deletedbiblio_and_deleteitems_tables_with_their_alive_cousins.perl And reset the DB but the messages are still outputted in a high number. Before that: is that relevant to run the tests with and without the patchset to compare the output and check if there are additional warnings? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #237 from Victor Grousset/tuxayo --- Reran the tests (branch joubu/Koha/commits/bug_20271), the issues of comment 219 are gone. New failing test: kohadev-koha@50ed3ff6e267:/kohadevbox/koha$ prove t/db_dependent/Items.t t/db_dependent/Items.t .. 4/15 # Failed test 'found 1 item with itemnotes = "foobar"' # at t/db_dependent/Items.t line 613. # Looks like you failed 1 test of 15. t/db_dependent/Items.t .. 7/15 # Failed test 'SearchItems test' # at t/db_dependent/Items.t line 638. t/db_dependent/Items.t .. 13/15 # Looks like you failed 1 test of 15. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Blocks||25921 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25921 [Bug 25921] Merge biblio* and items table - Update reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #236 from Jonathan Druart --- Thanks Martin, I've cherry-picked your 2 QA follow-ups and added your stamp on the whole stack! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #235 from Martin Renvoize --- I've added a couple of additional followups with fixes to minor issues I found.. generally it's looking great, performs well and I've not found any regressions. I'm not 100% sure about the introduced *_legacy views as we're not using them here for updating reports.. but I do like the deleted* views as a way to lower the requirement for people to immediately update reports. Having spoken to Jonathan about this I think we were in agreement they were OK to stay with a later followup working on automating updating reports to use them. All in all, I've added my SO stamp to the patchset on another local branch: https://gitlab.com/mrenvoize/Koha/-/commits/qa_20271 ready for Jonathan to merge in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #233 from Martin Renvoize --- My turn, thanks for leading the way Tomas.. I'm taking over and giving it my once over.. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #234 from Jonathan Druart --- Remote branch updated. Tomas's signed-off-by lines have been added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #232 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #231) > Tomas, I cherry-picked 2 of your patches and added a commit to fix the > atomic update process bug you reported me (pm) I tested your follow-up, and it works great! I amended my last patch to catch a typo. You can consider this as SO by me, picking my branch. It includes a commit from Martin, but better ask him about his SO status! Good job team! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #231 from Jonathan Druart --- Tomas, I cherry-picked 2 of your patches and added a commit to fix the atomic update process bug you reported me (pm) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #230 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #229) > I don't think items is an exception, and so I don't think biblio should have > another naming. > > For instance (as noted in comment 198): > """As we are going to face this situation for some other tables as well (at > least columns borrowers.cardnumber, borrowers.userid, issues.itemnumber)""" You're 100% right. I'll tweak my working branch so this moves forward, in a consistent way! Thanks for the clarification Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #229 from Jonathan Druart --- I don't think items is an exception, and so I don't think biblio should have another naming. For instance (as noted in comment 198): """As we are going to face this situation for some other tables as well (at least columns borrowers.cardnumber, borrowers.userid, issues.itemnumber)""" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #228 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #227) > (In reply to Tomás Cohen Arazi from comment #226) > > (In reply to Jonathan Druart from comment #225) > > > Tomas, with your patches we now have: > > > biblio.deleted_on, biblio.deleted > > > and > > > items.deleted_on, items.is_current > > > I think it's confusing. > > > > Yes. I think is_current is an anomaly and shouldn't be the rule. But I > > wouldn't block this for that. > > Can you explain? I think if possible we should be consistent, thinking of > the many report writeres out there. Comment #198 explains it. What really makes sense is a 'deleted' flag, but because of this very special case in which we want to preserve the UNIQUE constraint on the items.barcode column which some libraries would like to reuse, and the DBMS doesn't allow us to have the constraint on non-NULL values, we need to do it in reverse (i.e. instead of 'deleted' we do 'not_deleted' and set NULL to represent deleted). So we are forcing the DB structure because of our limitations on the DB features we are allowed to use, or the versions of the DB we want to support (all for good reasons, not arguing). I would just add a FIXME on the items table and leave the other tables saner. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #227 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #226) > (In reply to Jonathan Druart from comment #225) > > Tomas, with your patches we now have: > > biblio.deleted_on, biblio.deleted > > and > > items.deleted_on, items.is_current > > I think it's confusing. > > Yes. I think is_current is an anomaly and shouldn't be the rule. But I > wouldn't block this for that. Can you explain? I think if possible we should be consistent, thinking of the many report writeres out there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #226 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #225) > Tomas, with your patches we now have: > biblio.deleted_on, biblio.deleted > and > items.deleted_on, items.is_current > I think it's confusing. Yes. I think is_current is an anomaly and shouldn't be the rule. But I wouldn't block this for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #225 from Jonathan Druart --- Tomas, with your patches we now have: biblio.deleted_on, biblio.deleted and items.deleted_on, items.is_current I think it's confusing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #224 from Tomás Cohen Arazi --- I submitted my work to the mentioned branch [1] What I tested was: - Do a reset_all on master - Run updatedatabase on that branch - Tested adding biblios/items and deleting them works without changes. - Rebuilding zebra - Tests need to pass I fixed the API so it acknowledges the new deleted_on and deleted fields. Fetching items should keep the current behaviour (no deleted items retrieved by default, we could add the feature later if we wanted to be able to retrieve them). I noticed we merge the tables and now have a WHERE condition all over the place, that has an impact on performance, unless we have an index for the compared columns. As we are not making real use of the date the record was deleted, I made sure the index is created against a boolean (size, probably speed) so I changed all item-related queries to do items.is_current=1 instead of items.deleted_on IS NULL items.is_current=0 instead of items.deleted_on IS NOT NULL and for biblios: biblio.deleted=0 instead of biblio.deleted_on IS NULL biblio.deleted=1 instead of biblio.deleted_on IS NOT NULL I put my signature on this patchset as-is, but am still checking the atomic update edge cases. [1] https://gitlab.com/thekesolutions/Koha/-/commits/qa_20271 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #223 from Tomás Cohen Arazi --- I'm working on a performance improvement. Gimme one hour or so to submit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #222 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #220) > Ok, I tested all I could find and added a couple follow-ups for the API > (tests and spec). Hi Tomas, can you explain a bit more so people can get creativ about other things to test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #221 from Tomás Cohen Arazi --- My SO branch with the follow-up commits: https://gitlab.com/thekesolutions/Koha/-/commits/qa_20271 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #220 from Tomás Cohen Arazi --- Ok, I tested all I could find and added a couple follow-ups for the API (tests and spec). My only concern is the atomic update doesn't seem to be idempotent. Not sure it is a big deal as this is not a target for backporting. But worth mentioning. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #219 from Victor Grousset/tuxayo --- On the branch https://gitlab.com/joubu/Koha/commits/bug_20271 7 tests are failing while they pass in the master commit on which the branch is based. pastebin: https://copycat.drycat.fr/?c17f8b259b275bf6#7MLWpfeTftSKTwT8Rs3ke6rP9Srau9jXXQzUroJNYcZH -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Alexander Borkowski changed: What|Removed |Added CC||alexander.borkow...@kau.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What|Removed |Added Patch complexity|Medium patch|Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #218 from Jonathan Druart --- I rebased the remote branch against master and added the view for backward compatibility. biblio_legacy items_legacy biblioitems_legacy biblio_metadata_legacy deletedbiblio deletedbiblioitems deleteditems deletedbiblio_metadata -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
