[Koha-bugs] [Bug 20545] Add multi-language support to SIP2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20545

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20545] Add multi-language support to SIP2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20545

abernaud  changed:

   What|Removed |Added

 CC||anne-claire.bernaudin@univ-
   ||rennes1.fr

--- Comment #9 from abernaud  ---
Hello,
in my opinion, we should only use the language that was set in the request,
assuming that it's the language selected on the self check GUI, as Katrin said
in Comment #5.
All the messages displayed on the selfcheck machines aren't coming from Koha :
some messages are sent directly by the selfcheck machine itself. So it would be
better to use the language set on the GUI.
Best wishes
Anne-Claire (from Rennes, France)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20545] Add multi-language support to SIP2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20545

--- Comment #8 from Katrin Fischer  ---
I think borrowers.lang was added in 17.05 or 17.11, maybe you are looking at
different versions? It's a rather recent addition.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20545] Add multi-language support to SIP2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20545

--- Comment #7 from Magnus Enger  ---
(In reply to Colin Campbell from comment #6)
> Actually we always return 000 for the language because the language does not
> get set in the ILS::Patron objectand we fall back on default.

That has not been my experience. The one time I checked, borrowers.lang was
empty and the three-digit language code was missing from the SIP2 response,
giving the "fixed length" part of the response the wrong length.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20545] Add multi-language support to SIP2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20545

--- Comment #6 from Colin Campbell  ---
Actually we always return 000 for the language because the language does not
get set in the ILS::Patron objectand we fall back on default.

Would be interesting to see if self-issue machines take much notice of whats
set, what they are configured for may override anything in the response

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20545] Add multi-language support to SIP2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20545

--- Comment #5 from Katrin Fischer  ---
Hm, I was wondering if we should just response in the lanugage that was set in
the request, assuming that it's the language selected on the self check GUI.
Maybe a fallback to borrowers.lang?

Yes, we'd need to map the Koha language codes to the SIP2 codes in some way.
Maybe a YAML system preference?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20545] Add multi-language support to SIP2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20545

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #4 from Magnus Enger  ---
This hints at a bug in the SIP2 implementation in Koha. In the SIP2 standard
that Katrin references in Comment 1, "language" is listed as a "3-char, fixed
length required field". The contents of this field should be the 3-digit
language codes that Katrin lists. 

As fas as I can tell, Koha uses the contents of the borrowers.lang database
field for the language, using 000 if the field is not set:
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/SIP/ILS/Patron.pm;h=23c576493fbc6214905efd1297225057a80c537a;hb=HEAD#l252

If a language code like nb-NO is used for the language in SIP2 the language
info will have both the wrong length and the wrong format. 

As far as I can tell, we should have a mapping somewhere from the codes we use
in borrowers.lang to the 3-digit codes required by SIP2. 

Not sure if it makes sense to fix this as part of the present bug or if it
should be a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20545] Add multi-language support to SIP2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20545

--- Comment #3 from Kyle M Hall  ---
Better idea from cait, use YAML and hook into the same translation system as
the sysprefs. Still should allow alternatives in the config ; )

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20545] Add multi-language support to SIP2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20545

--- Comment #2 from Kyle M Hall  ---
Also, if we are going this far, we should also allow alternative templates to
be specified on a per-login basis in the SIP2 config.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20545] Add multi-language support to SIP2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20545

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #1 from Kyle M Hall  ---
If we moved all SIP2 strings into Template Toolkit files it would make
translation easy. I would recommend we use TT directly in the SIP2 code and
*not* use C4::Templates do to it's cgi-centriticy and the fact that it would
add a huge amount of overhead to the SIP server.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/