[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #35 from Martin Renvoize --- More work needed here so leaving in FQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #34 from Martin Renvoize --- Created attachment 166631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166631=edit Bug 22421: (follow-up) Check issue during add_debit We need additional handling for the case where a debt may be added with an issue_id after the issue is returned. This patch tries to fix that at a low level, but introduces new test failures in t/db_dependent/Circulation.t to be investigated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Emily Lamancusa changed: What|Removed |Added Status|Signed Off |Failed QA CC||emily.lamancusa@montgomeryc ||ountymd.gov --- Comment #33 from Emily Lamancusa --- Taking a look at this one... It looks like there are some test failures: t/db_dependent/Koha/Account/Line.t .. 1/15 # Looks like you planned 4 tests but ran 2. # Failed test 'library() tests' # at t/db_dependent/Koha/Account/Line.t line 173. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.old_issue_id' in 'field list' at /kohadevbox/koha/Koha/Objects.pm line 95 # Looks like your test exited with 255 just after 4. t/db_dependent/Koha/Account/Line.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 12/15 subtests t/db_dependent/Circulation.t .. 17/74 # Failed test 'CanBookBeRenewed tests' # at t/db_dependent/Circulation.t line 1753. DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.old_issue_id' in 'field list' at /kohadevbox/koha/Koha/Objects.pm line 319 # Looks like your test exited with 11 just after 17. t/db_dependent/Circulation.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 58/74 subtests I'm also not sure it makes sense to put all steps of the dbrev inside the "unless" that checks for the existence of the old_issue_id column. If for some reason the column exists but the foreign keys don't exist (e.g. a previous update failed in the middle), the whole dbrev would be skipped and the foreign keys wouldn't be created. I think it should be pretty doable to have a separate check for most individual steps of the dbrev. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Andreas Jonsson changed: What|Removed |Added CC||andreas.jons...@kreablo.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #32 from Victor Grousset/tuxayo --- QA script reports this: WARN C4/Circulation.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 1095, now: 1098) WARN Koha/Schema/Result/Accountline.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 142, now: 162) WARN Koha/Schema/Result/Issue.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 108, now: 112) WARN Koha/Schema/Result/OldIssue.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 106, now: 110) At the time of the 1st submission these patches, perltidy was already in Coding Guidelines (PERL1), and was about default perltidy config. Likely a lot of current errors are from default config and not or few customization. So at least a lot at the messy lines would be needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #31 from Victor Grousset/tuxayo --- I'm not sure about all of the implications and places to change but at least here is another signoff. Changes in tests make sense. Additional testing: Confirmed that purged old_issues (cleanup_database.pl) are handled well :) (accountlines.issue_id is nulled) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161923|0 |1 is obsolete|| --- Comment #30 from Victor Grousset/tuxayo --- Created attachment 162248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162248=edit Bug 22421: Schema Update Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161922|0 |1 is obsolete|| --- Comment #29 from Victor Grousset/tuxayo --- Created attachment 162247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162247=edit Bug 22421: (follow-up) Correct checkout relation The Koha::Account::Line->checkout relationship accessor needed an update to respect the new fields and foreign keys introduced here. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161921|0 |1 is obsolete|| --- Comment #28 from Victor Grousset/tuxayo --- Created attachment 162246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162246=edit Bug 22421: Ensure old_issue_id is populated in accountlines Update C4::Circulation::MarkIssueReturned to handle moving issue_id to old_issue_id in accountlines. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161920|0 |1 is obsolete|| --- Comment #27 from Victor Grousset/tuxayo --- Created attachment 162245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162245=edit Bug 22421: Add missing constraints DB update to add a new old_issue_id field to accountlines and set foreign key constraints for both the new field and the existing issue_id field. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #161919|0 |1 is obsolete|| --- Comment #26 from Victor Grousset/tuxayo --- Created attachment 162244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162244=edit Bug 22421: Add tests for new constraints Test plan: * Read the updated tests and verify that they make sense and do not remove anything previously tested for. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #25 from Martin Renvoize --- Rebased and brought up to modern standards.. Back to read for QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #24 from Martin Renvoize --- Created attachment 161923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161923=edit Bug 22421: Schema Update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Attachment #90368|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 161922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161922=edit Bug 22421: (follow-up) Correct checkout relation The Koha::Account::Line->checkout relationship accessor needed an update to respect the new fields and foreign keys introduced here. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Attachment #90367|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 161921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161921=edit Bug 22421: Ensure old_issue_id is populated in accountlines Update C4::Circulation::MarkIssueReturned to handle moving issue_id to old_issue_id in accountlines. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Attachment #90366|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 161920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161920=edit Bug 22421: Add missing constraints DB update to add a new old_issue_id field to accountlines and set foreign key constraints for both the new field and the existing issue_id field. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Attachment #90365|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 161919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161919=edit Bug 22421: Add tests for new constraints Test plan: * Read the updated tests and verify that they make sense and do not remove anything previously tested for. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Blocks||17976 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17976 [Bug 17976] TT syntax for notices - Add an equivalence for items.fine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #19 from Katrin Fischer ---
I got myself into trouble here:
1) Check out item backdated, so it's overdue
2) Run fines.pl to accrue fines
3) Return it
4) Verify title etc. still show
- Apply patchset
1) Run updatedatabase and dbic, restart_all
2) Check out same item backdated again
3) Return from patron account
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_kohadev`.`accountlines`, CONSTRAINT
`accountlines_ibfk_issues` FOREIGN KEY (`issue_id`) REFERENCES `issues`
(`issue_id`) ON DELETE SET NULL ON UPDATE CASCADE) [for Statement "INSERT INTO
`accountlines` ( `accounttype`, `amount`, `amountoutstanding`,
`borrowernumber`, `branchcode`, `date`, `description`, `interface`, `issue_id`,
`itemnumber`, `manager_id`, `note`, `payment_type`, `status`) VALUES ( ?, ?, ?,
?, ?, NOW(), ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='OVERDUE', 1=0.9,
2=0.9, 3=51, 4=undef, 5='Conspirator : 07/01/2019 23:59', 6='intranet', 7=4,
8=22, 9=undef, 10='', 11=undef, 12='UNRETURNED'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88
Exception::Class::Base::throw('Koha::Exceptions::Object::FKConstraint',
'error', 'Broken FK constraint', 'broken_fk', 'issue_id') called at
/home/vagrant/kohaclone/Koha/Object.pm line 163
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #18 from Katrin Fischer --- I also tried charging overdue fines and returning the items. After returning them, the due date and return date information are no longer visible in accountlines (not implemented yet?). old_issue_id is set, so that works. I'll have to reset my db to check the lost behaviour, running a bit low on time right now, help appreciated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #17 from Katrin Fischer --- Trying to test this, but I am having issues getting a lost replacement fee to charge. I have set a replacement default cost on item level and set WhenLostChargeReplacementFee to Charge. Items are returned on setting the lost status. Not sure if this is related yet, but maybe you can help verify. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #15 from Kyle M Hall --- Created attachment 90367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90367=edit Bug 22421: Ensure old_issue_id is populated in accountlines Update C4::Circulation::MarkIssueReturned to handle moving issue_id to old_issue_id in accountlines. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #14 from Kyle M Hall --- Created attachment 90366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90366=edit Bug 22421: Add missing constraints DB update to add a new old_issue_id field to accountlines and set foreign key constraints for both the new field and the existing issue_id field. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #16 from Kyle M Hall --- Created attachment 90368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90368=edit Bug 22421: (follow-up) Correct checkout relation The Koha::Account::Line->checkout relationship accessor needed an update to respect the new fields and foreign keys introduced here. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Kyle M Hall changed: What|Removed |Added Attachment #90359|0 |1 is obsolete|| Attachment #90360|0 |1 is obsolete|| Attachment #90361|0 |1 is obsolete|| Attachment #90362|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 90365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90365=edit Bug 22421: Add tests for new constraints Test plan: * Read the updated tests and verify that they make sense and do not remove anything previously tested for. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Attachment #90353|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 90360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90360=edit Bug 22421: Add missing constraints DB update to add a new old_issue_id field to accountlines and set foreign key constraints for both the new field and the existing issue_id field. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #12 from Martin Renvoize --- Created attachment 90362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90362=edit Bug 22421: (follow-up) Correct checkout relation The Koha::Account::Line->checkout relationship accessor needed an update to respect the new fields and foreign keys introduced here. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Attachment #90352|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 90359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90359=edit Bug 22421: Add tests for new constraints Test plan: * Read the updated tests and verify that they make sense and do not remove anything previously tested for. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Attachment #90354|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 90361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90361=edit Bug 22421: Ensure old_issue_id is populated in accountlines Update C4::Circulation::MarkIssueReturned to handle moving issue_id to old_issue_id in accountlines. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Attachment #85774|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 90353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90353=edit Bug 22421: Add missing constraints DB update to add a new old_issue_id field to accountlines and set foreign key constraints for both the new field and the existing issue_id field. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Attachment #85773|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 90352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90352=edit Bug 22421: Add tests for new constraints Test plan: * Read the updated tests and verify that they make sense and do not remove anything previously tested for. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Attachment #85775|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 90354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90354=edit Bug 22421: Ensure old_issue_id is populated in accountlines Update C4::Circulation::MarkIssueReturned to handle moving issue_id to old_issue_id in accountlines. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Katrin Fischer changed: What|Removed |Added Blocks||5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Depends on|22008 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 [Bug 22008] accountlines.manager_id is missing a foreign key constraint -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Josef Moravec --- Sorry, can't apply: Applying: Bug 22421: Add tests for new constraints error: sha1 information is lacking or useless (t/db_dependent/Koha/Account/Lines.t). There are also some templates referencing issue_id, it should be fixed, and Koha::Accout::Line->checkout should be adjusted too... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #3 from Martin Renvoize --- Created attachment 85774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85774=edit Bug 22421: Add missing constraints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #4 from Martin Renvoize --- Created attachment 85775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85775=edit Bug 22421: Ensure old_issue_id is populated in accountlines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #2 from Martin Renvoize --- Created attachment 85773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85773=edit Bug 22421: Add tests for new constraints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 --- Comment #1 from Martin Renvoize --- This is a more challenging one, as issue_id refers to not one but two distinct tables .. issues and old_issues.. as such we either need to merge issues and old_issues or split this constraint into two distinct fields and ensure they're properly populated. I've opted for the distinct fields in this patch for now as it's the simpler approach and can be easily switched at a later date for the issue/old_issue merge. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Depends on||22008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 [Bug 22008] accountlines.manager_id is missing a foreign key constraint -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
