[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Keywords||Manual-updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||29327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29327 [Bug 29327] Add option to remove Non-Priority status from hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Tomás Cohen Arazi changed: What|Removed |Added Blocks||25260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #27 from Lucas Gass --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Tomás Cohen Arazi changed: What|Removed |Added Keywords||Manual QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 --- Comment #26 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 --- Comment #25 from Katrin Fischer --- Created attachment 109205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109205=edit Bug 22789: (QA follow-up) Some minor formatting changes - Remove the unordered list added to the holds list Details column - Switch div to span to have the hint appear behind the checkbox Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Katrin Fischer changed: What|Removed |Added Attachment #109128|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 109203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109203=edit Bug 22789: Add non priority feature to C4 classes and staff interface This patch implements necesary code to implement non priority feature To test: 1) Apply all patches. 2) Run updatedatabase. 3) Checkout a specific item for patron1. 4) Place a hold on the same item for patron2 (do not check non priority hold checkbox). 5) Try to renew the item for patron1. CHECK => in checkouts table, there is a message that the item could not be renewed because there was a hold. 6) Cleanup all checkouts and holds. 7) repeat steps 3 to 5, but this time check the non priority checkbox. SUCCESS => item was renewed 8) prove t/db_dependent/Holds.t Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Katrin Fischer changed: What|Removed |Added Attachment #109129|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 109204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109204=edit Bug 22789: (follow-up) Fix atomic update, GUI and more than one hold This patch * sets one check for reserves and another for old_reserves in atomic update * Adds a message below the checkbox and adds detail when a hold is non priority * Fixes issue when there are more than one hold, but the first is non priority * Adds test case for this last scenario Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Katrin Fischer changed: What|Removed |Added Attachment #109125|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 109200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109200=edit Bug 22789: Add tests Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Katrin Fischer changed: What|Removed |Added Attachment #109127|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 109202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109202=edit Bug 22789: Set non_priority column as boolean in schema Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Katrin Fischer changed: What|Removed |Added Attachment #109126|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 109201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109201=edit Bug 22789: Add non_priority column to reserves and old_reserves Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 --- Comment #19 from Agustín Moyano --- Created attachment 109129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109129=edit Bug 22789: (follow-up) Fix atomic update, GUI and more than one hold This patch * sets one check for reserves and another for old_reserves in atomic update * Adds a message below the checkbox and adds detail when a hold is non priority * Fixes issue when there are more than one hold, but the first is non priority * Adds test case for this last scenario -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 --- Comment #18 from Agustín Moyano --- Created attachment 109128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109128=edit Bug 22789: Add non priority feature to C4 classes and staff interface This patch implements necesary code to implement non priority feature To test: 1) Apply all patches. 2) Run updatedatabase. 3) Checkout a specific item for patron1. 4) Place a hold on the same item for patron2 (do not check non priority hold checkbox). 5) Try to renew the item for patron1. CHECK => in checkouts table, there is a message that the item could not be renewed because there was a hold. 6) Cleanup all checkouts and holds. 7) repeat steps 3 to 5, but this time check the non priority checkbox. SUCCESS => item was renewed 8) prove t/db_dependent/Holds.t Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 --- Comment #16 from Agustín Moyano --- Created attachment 109126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109126=edit Bug 22789: Add non_priority column to reserves and old_reserves Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 --- Comment #17 from Agustín Moyano --- Created attachment 109127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109127=edit Bug 22789: Set non_priority column as boolean in schema Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Agustín Moyano changed: What|Removed |Added Attachment #108708|0 |1 is obsolete|| Attachment #108709|0 |1 is obsolete|| Attachment #108710|0 |1 is obsolete|| Attachment #109123|0 |1 is obsolete|| Attachment #109124|0 |1 is obsolete|| --- Comment #15 from Agustín Moyano --- Created attachment 109125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109125=edit Bug 22789: Add tests Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 --- Comment #14 from Agustín Moyano --- Created attachment 109124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109124=edit Bug 22789: (follow-up) Fix atomic update, GUI and more than one hold This patch * sets one check for reserves and another for old_reserves in atomic update * Adds a message below the checkbox and adds detail when a hold is non priority * Fixes issue when there are more than one hold, but the first is non priority * Adds test case for this last scenario -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Agustín Moyano changed: What|Removed |Added Attachment #108707|0 |1 is obsolete|| --- Comment #13 from Agustín Moyano --- Created attachment 109123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109123=edit Bug 22789: Add tests Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #12 from Katrin Fischer ---
Starting with a first round of testing and reviewing here:
1) Database update
I feel it would be cleaner to do the same check for the old_reserves table as
well:
if( !column_exists( 'reserves', 'non_priority' ) ) {
2) GUI
request.tt
a) I am not sure of a 'non priority hold' is a standing term, but I haven't
seen this feature in another ILS before. I think maybe having an explanation in
a tool tip or after the checkbox could be quite helpful here.
I'd also suggest to add an ID to the to help libraries hide this
functionality if they don't intend on using it:
+
+Non priority
hold:
+
+
b) Once the hold is placed, there is no way to visually tell that it's a
non-priority hold. I think this could lead to support questions and we will
only be able to figure it out looking at the database entry.
I'd strongly recommend to add a note to request.tt and to the hold list in the
patron account on staff side. On request.tt this could go into the Details
column.
3) More than one hold
My test case:
- Check out item to Henry
- Place a non-priority hold for admin
- Henry can still renew
- Place another hold for a regular staff patron
- Henry can still renew...
I feel like it needs to look at all holds and not only the next one?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 ByWater Sandboxes changed: What|Removed |Added Attachment #108706|0 |1 is obsolete|| --- Comment #10 from ByWater Sandboxes --- Created attachment 108710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108710=edit Bug 22789: Add non priority feature to C4 classes and staff interface This patch implements necesary code to implement non priority feature To test: 1) Apply all patches. 2) Run updatedatabase. 3) Checkout a specific item for patron1. 4) Place a hold on the same item for patron2 (do not check non priority hold checkbox). 5) Try to renew the item for patron1. CHECK => in checkouts table, there is a message that the item could not be renewed because there was a hold. 6) Cleanup all checkouts and holds. 7) repeat steps 3 to 5, but this time check the non priority checkbox. SUCCESS => item was renewed 8) prove t/db_dependent/Holds.t Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #11 from Lisette Scheer --- Worked as expected and I'm looking forward to this development! I wasn't able to prove t/db_dependent/Holds.t as I was on the sandbox. Lisette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 ByWater Sandboxes changed: What|Removed |Added Attachment #108703|0 |1 is obsolete|| --- Comment #7 from ByWater Sandboxes --- Created attachment 108707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108707=edit Bug 22789: Add tests Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 ByWater Sandboxes changed: What|Removed |Added Attachment #108704|0 |1 is obsolete|| --- Comment #8 from ByWater Sandboxes --- Created attachment 108708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108708=edit Bug 22789: Add non_priority column to reserves and old_reserves Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 ByWater Sandboxes changed: What|Removed |Added Attachment #108705|0 |1 is obsolete|| --- Comment #9 from ByWater Sandboxes --- Created attachment 108709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108709=edit Bug 22789: Set non_priority column as boolean in schema Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 --- Comment #6 from Agustín Moyano --- Created attachment 108706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108706=edit Bug 22789: Add non priority feature to C4 classes and staff interface This patch implements necesary code to implement non priority feature To test: 1) Apply all patches. 2) Run updatedatabase. 3) Checkout a specific item for patron1. 4) Place a hold on the same item for patron2 (do not check non priority hold checkbox). 5) Try to renew the item for patron1. CHECK => in checkouts table, there is a message that the item could not be renewed because there was a hold. 6) Cleanup all checkouts and holds. 7) repeat steps 3 to 5, but this time check the non priority checkbox. SUCCESS => item was renewed 8) prove t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 --- Comment #5 from Agustín Moyano --- Created attachment 108705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108705=edit Bug 22789: Set non_priority column as boolean in schema -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 --- Comment #3 from Agustín Moyano --- Created attachment 108703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108703=edit Bug 22789: Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 --- Comment #4 from Agustín Moyano --- Created attachment 108704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108704=edit Bug 22789: Add non_priority column to reserves and old_reserves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Agustín Moyano changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #2 from Donna --- This is a functionality libraries request on a regular basis. Great idea! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish non-priority holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Summary|Establish Non-Priority |Establish non-priority |Holds |holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish Non-Priority Holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Joy Nelson changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish Non-Priority Holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --- Comment #1 from Lisette Scheer --- This would be very helpful here. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 22789] Establish Non-Priority Holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22789 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
