[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Blocks|23046 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046 [Bug 23046] Add tax handling to accounts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Blocks||26398 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398 [Bug 26398] Credit type on creating a manual credit is not translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Jonathan Druart changed: What|Removed |Added Blocks||25010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25010 [Bug 25010] Fix typo in debit type description: rewewal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Blocks||24532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532 [Bug 24532] Some account types are converted to debits when they shouldn't be -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Jonathan Druart changed: What|Removed |Added Blocks||24542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542 [Bug 24542] Checkout page - Can't locate object method "search" via package "Koha::Account::DebitTypes" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Bug 23049 depends on bug 23321, which changed state. Bug 23321 Summary: Add 'cash registers' to the accounts system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #226 from Lucas Gass --- enchancment wont be backported to 19.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Katrin Fischer changed: What|Removed |Added Blocks||24316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 [Bug 24316] Fix non-English web installers by removing obsolete authorised value MANUAL_INV -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Jonathan Druart changed: What|Removed |Added Blocks||24241 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 [Bug 24241] Description missing for subpermission manage_accounts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Text to go in the|This patchset moves the |This patchset moves the release notes|'MANUAL_INV' authorized |`MANUAL_INV` authorized |values into their own table |values into their own table |and adds in interface into |and adds an interface into |the administration pages to |the administration pages to |allow addition and |allow the addition and |modification of such|modification of such |account types. |account types. | | |This serves |This serves |as the foundation for |as the foundation for |enhancing the accounts |enhancing the accounts |system and leads to clearer |system and leads to clearer |code and more consistent|code and more consistent |data via database-level |data via database-level |constraints. |constraints. | | |Note: Reports |**Reports |will need to be updated to |note**: Reports will need |look in the new |to be updated to look in |debit_type_code field for |the new debit_type_code |accountlines of type|field for accountlines of |'debit' and use the updated |type 'debit' and use the |coded values. |updated coded values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17702 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Blocks|23636 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23636 [Bug 23636] MANUAL_INV values should be able to have a code, a description, and a price. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #225 from Martin Renvoize --- *** Bug 23636 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Blocks|23354 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Text to go in the||This patchset moves the release notes||'MANUAL_INV' authorized ||values into their own table ||and adds in interface into ||the administration pages to ||allow addition and ||modification of such ||account types. || ||This serves ||as the foundation for ||enhancing the accounts ||system and leads to clearer ||code and more consistent ||data via database-level ||constraints. || ||Note: Reports ||will need to be updated to ||look in the new ||debit_type_code field for ||accountlines of type ||'debit' and use the updated ||coded values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #224 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #223 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #221)
> (In reply to Martin Renvoize from comment #220)
> > I managed at least to get this all running under MariaDB 10.2.27 and see the
> > check constraint in action myself. Turns out one cannot use a ternary the
> > way I tried to inside an execute call.
>
> I think that you are mistaken. You used the wrong conditions in the ternary:
>
> -$sth->execute($borrower->borrowernumber, $data->{amount},
> $data->{days_ago}, $data->{description}, 'commandline', $data->{amount} > 0
> ? 'W' : undef, $data->{amount} >= 0 ? undef : 'OVERDUE' );
> +$sth->execute($borrower->borrowernumber, $data->{amount},
> $data->{days_ago}, $data->{description}, 'commandline', $data->{amount} < 0
> ? 'W' : undef, $data->{amount} < 0 ? undef : 'OVERDUE' );
>
> This should work. Note the differences between >0 and <0 but also between
> >=0 and <0. Credit is negative !
> I would suggest to remove patch 34.
> Coming back here soon.
We keep the new code. Only adjust the commit message.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #222 from Marcel de Rooy --- Created attachment 94648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94648=edit Bug 23049: [LAST PATCH ONLY] (QA follow-up) Catch '0' case debits Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Medium patch Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #221 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #220)
> I managed at least to get this all running under MariaDB 10.2.27 and see the
> check constraint in action myself. Turns out one cannot use a ternary the
> way I tried to inside an execute call.
I think that you are mistaken. You used the wrong conditions in the ternary:
-$sth->execute($borrower->borrowernumber, $data->{amount},
$data->{days_ago}, $data->{description}, 'commandline', $data->{amount} > 0 ?
'W' : undef, $data->{amount} >= 0 ? undef : 'OVERDUE' );
+$sth->execute($borrower->borrowernumber, $data->{amount},
$data->{days_ago}, $data->{description}, 'commandline', $data->{amount} < 0 ?
'W' : undef, $data->{amount} < 0 ? undef : 'OVERDUE' );
This should work. Note the differences between >0 and <0 but also between >=0
and <0. Credit is negative !
I would suggest to remove patch 34.
Coming back here soon.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #220 from Martin Renvoize --- Pushed again... I managed at least to get this all running under MariaDB 10.2.27 and see the check constraint in action myself. Turns out one cannot use a ternary the way I tried to inside an execute call. All tests should now pass, the warning should now be suppressed and the db update now also handles the '0' case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #219 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #218)
> Hmm,
>
> The exception is intended and is in fact caught and rethrown within
> Koha::Account.pm.. not sure why it results in noise in the test though.. it
> should be hidden by the 'throws_ok' call..
>
> Investigating.
my $schema = Koha::Database->new->schema;
$schema->storage->dbh->{PrintError} = 0;
Might do it in Koha/Account.t
Please try
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #218 from Martin Renvoize --- Hmm, The exception is intended and is in fact caught and rethrown within Koha::Account.pm.. not sure why it results in noise in the test though.. it should be hidden by the 'throws_ok' call.. Investigating. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #217 from Marcel de Rooy --- t/db_dependent/Accounts.t (Wstat: 768 Tests: 33 Failed: 3) Failed tests: 12-14 t/db_dependent/ILSDI_Services.t .. ok All tests successful. t/db_dependent/Koha/Account/Offsets.t .. ok All tests successful. t/db_dependent/Members.t .. ok All tests successful. prove t/db_dependent/Koha/Account.t t/db_dependent/Koha/Account.t .. 3/11 DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_master`.`accountlines`, CONSTRAINT `accountlines_ibfk_debit_type` FOREIGN KEY (`debit_type_code`) REFERENCES `account_debit_types` (`code`) ON UPDATE CASCADE) [for Statement "INSERT INTO `accountlines` ( `amount`, `amountoutstanding`, `borrowernumber`, `branchcode`, `date`, `debit_type_code`, `description`, `interface`, `issue_id`, `itemnumber`, `manager_id`, `note`, `payment_type`) VALUES ( ?, ?, ?, ?, NOW(), ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0=5, 1=5, 2=169, 3='X8YVxu', 4='failure', 5='type validation failure', 6='commandline', 7=undef, 8=undef, 9=169, 10='this should fail anyway', 11=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. t/db_dependent/Koha/Account.t .. ok All tests successful. => Please check for me if this exception was intended (it seems). Should we catch the warning instead ? t/db_dependent/Koha/Account/Lines.t .. ok All tests successful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #216 from Marcel de Rooy --- DBD::mysql::st execute failed: CONSTRAINT `accountlines_check_type` failed for `koha_master`.`accountlines` [for Statement "INSERT INTO accountlines ( borrowernumber, amountoutstanding, date, description, interface, accounttype, debit_type_code ) VALUES ( ?, ?, (select date_sub(CURRENT_DATE, INTERVAL ? DAY) ), ?, ?, ?, ? )" with ParamValues: 0='117', 1=undef, 2=6, 3='purge_zero_balance_fees should delete NULL balance fees with date after threshold day', 4='commandline', 5=undef, 6=undef] at t/db_dependent/Accounts.t line 143. 5 and 6 are both undef BOOM -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #215 from Martin Renvoize --- OK, I've now grepped the codebase for INSERT INTO `accountlines` Koha::Account::Line->new Koha::Schema::Result::Accountline->new and corrected all cases.. I confident in saying these were only used in tests at this point and those have now been corrected. Putting back to Signed off.. thanks for all your efforts Marcel.. I think we might finally be there now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #214 from Marcel de Rooy --- And I am still a bit worried that we did not complete resolve the amount<0 or amount=0 cases in the upgrade.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #213 from Marcel de Rooy ---
[FAIL] t/db_dependent/Accounts.t
[FAIL] t/db_dependent/Koha/Account.t
[FAIL] t/db_dependent/Koha/Account/Lines.t
[1] Comment on the first failure in Accounts.t
ok 14 - outstanding_debits returns a list of Koha::Account::Line objects in
list context
DBD::mysql::st execute failed: CONSTRAINT `accountlines_check_type` failed for
`koha_master`.`accountlines` [for Statement "INSERT INTO `accountlines` (
`amountoutstanding`, `borrowernumber`, `interface`) VALUES ( ?, ?, ? )" with
ParamValues: 0=-2, 1=102, 2='commandline'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
# Looks like you planned 22 tests but ran 14.
not ok 2 - outstanding_debits() tests
# Failed test 'outstanding_debits() tests'
# at t/db_dependent/Koha/Account.t line 113.
Coming from:
# create a pathological credit with amountoutstanding > 0 (BZ 14591)
Koha::Account::Line->new({ borrowernumber => $patron_4->id, amount => -3,
amountoutstanding => 3, interface => 'commandline' })->store();
=> This statement obviously fails, since we do not set accounttype or
debittype. I am inclined to think that we should start without the type check
constraint. Pretty sure that we did not catch all occurrences in code where an
account line is added without one of the two types.
[2] The first problem in Lines.t
t/db_dependent/Koha/Account/Lines.t .. 8/9 DBD::mysql::st execute failed:
CONSTRAINT `accountlines_check_type` failed for `koha_master`.`accountlines`
[for Statement "INSERT INTO `accountlines` ( `amount`, `amountoutstanding`,
`borrowernumber`, `interface`) VALUES ( ?, ?, ?, ? )" with ParamValues: 0=10,
1=10, 2='115', 3='commandline'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm
line 1836.
# No tests run!
# Failed test 'No tests run for subtest "void() tests"'
# at t/db_dependent/Koha/Account/Lines.t line 591.
What about:
my $line1 = Koha::Account::Line->new({ borrowernumber =>
$borrower->borrowernumber, amount => 10, amountoutstanding => 10, interface =>
'commandline' })->store();
Here another insert that should fail because of the new constraint.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #212 from Marcel de Rooy --- Koha/Schema/Result/AccountDebitType.pm | 12 - Koha/Schema/Result/Accountline.pm | 6 +-- admin/debit_types.pl | 43 +--- => Imo we should not mix schema changes with regular codebase changes. Do we have a rule for that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #211 from Marcel de Rooy --- [OK] t/db_dependent/Koha/Account/Offsets.t | 7 ++- [OK] t/db_dependent/Members.t | 15 -- t/db_dependent/Accounts.t (Wstat: 65280 Tests: 31 Failed: 10) Failed tests: 12-14, 17-22, 31 # Failed test 'The 'charges' attribute should be correctly filled (bug 17836)' # at t/db_dependent/ILSDI_Services.t line 230. # got: '0.00' # expected: '10.00' # Looks like you failed 1 test of 5. t/db_dependent/ILSDI_Services.t .. 3/9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #210 from Marcel de Rooy --- t/db_dependent/api/v1/patrons_accounts.t .. ok All tests successful. Hopeful ! Hang on -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #209 from Martin Renvoize --- Fixed the API test now on the pushed branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #208 from Martin Renvoize ---
(In reply to Marcel de Rooy from comment #207)
> (Minor) If you archive a debit type, you should probably be no longer
> allowed to create a manual invoice with that type.
Corrected on the branch now.
> (Minor) UPDATE accountlines SET accounttype = ? WHERE accounttype = ?
> => Hope you dont have too many clashes on the prefix here ;) The algorithm
> now just assumes that it should be the first one found. But hard to solve..
Agreed, I did think about this but when I looked at out customer base I
couldn't find any cases in real life so i decided this was better than leaving
the mess.
> (Minor) UPDATE accountlines SET accounttype = 'MANUAL' WHERE accounttype =
> 'M'
> => How do you know that you are not moving sundry to manual fee here? Or is
> that okay (did we manage to get rid of it completely) ?
I believe this is resolved in previous bugs already. the two accounttypes were
merged.
> (Major) t/db_dependent/api/v1/patrons_accounts.t
> not ok 5 - 200 OK
> # Failed test '200 OK'
> # at t/db_dependent/api/v1/patrons_accounts.t line 95.
> # got: '500'
> # expected: '200'
> not ok 6 - exact match for JSON Pointer ""
> # Failed test 'exact match for JSON Pointer ""'
> # at t/db_dependent/api/v1/patrons_accounts.t line 95.
> # Structures begin differing at:
> # $got->{balance} = Does not exist
> # $expected->{balance} = '100.01'
> not ok 11 - 200 OK
> # Failed test '200 OK'
> # at t/db_dependent/api/v1/patrons_accounts.t line 139.
> # got: '500'
> # expected: '200'
> not ok 12 - exact match for JSON Pointer ""
> # Failed test 'exact match for JSON Pointer ""'
> # at t/db_dependent/api/v1/patrons_accounts.t line 139.
> # Structures begin differing at:
> # $got->{outstanding_debits} = Does not exist
> # $expected->{outstanding_debits} = HASH(0x55d12cacfd80)
> => Some other tests with API calls do pass.
Looking into this one at the moment.
> (Major) Three other tests still fail. Related to new constraint on type
> check.
I can't replicate these failures still :(
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Failed QA
--- Comment #207 from Marcel de Rooy ---
(Minor) If you archive a debit type, you should probably be no longer allowed
to create a manual invoice with that type.
(Minor) UPDATE accountlines SET accounttype = ? WHERE accounttype = ?
=> Hope you dont have too many clashes on the prefix here ;) The algorithm now
just assumes that it should be the first one found. But hard to solve..
(Minor) UPDATE accountlines SET accounttype = 'MANUAL' WHERE accounttype = 'M'
=> How do you know that you are not moving sundry to manual fee here? Or is
that okay (did we manage to get rid of it completely) ?
(Major) t/db_dependent/api/v1/patrons_accounts.t
not ok 5 - 200 OK
# Failed test '200 OK'
# at t/db_dependent/api/v1/patrons_accounts.t line 95.
# got: '500'
# expected: '200'
not ok 6 - exact match for JSON Pointer ""
# Failed test 'exact match for JSON Pointer ""'
# at t/db_dependent/api/v1/patrons_accounts.t line 95.
# Structures begin differing at:
# $got->{balance} = Does not exist
# $expected->{balance} = '100.01'
not ok 11 - 200 OK
# Failed test '200 OK'
# at t/db_dependent/api/v1/patrons_accounts.t line 139.
# got: '500'
# expected: '200'
not ok 12 - exact match for JSON Pointer ""
# Failed test 'exact match for JSON Pointer ""'
# at t/db_dependent/api/v1/patrons_accounts.t line 139.
# Structures begin differing at:
# $got->{outstanding_debits} = Does not exist
# $expected->{outstanding_debits} = HASH(0x55d12cacfd80)
=> Some other tests with API calls do pass.
(Major) Three other tests still fail. Related to new constraint on type check.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #206 from Marcel de Rooy --- Revisiting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #205 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #204) > Rebased and pushed addition QA followups to the github branch. > > I'm unable to replicate your test failures at the moment and have tried with > 6 different datasets... sorry but I'm going to struggle to fix that one > without being able to replicate it :(. OK Coming back to it soon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #204 from Martin Renvoize --- Rebased and pushed addition QA followups to the github branch. I'm unable to replicate your test failures at the moment and have tried with 6 different datasets... sorry but I'm going to struggle to fix that one without being able to replicate it :(. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #203 from Martin Renvoize ---
(In reply to Marcel de Rooy from comment #199)
> Tested on top of commit 480434bbf4a32750c5e47a3600b6a386d9732296 with your
> branch.
>
> Thanks for your hard work.
> I have noted comments 64 and 85 (thx Kyle). I made my preference clear, and
> continued on the current stand.
>
> Comments below are in order of time noted, not priority.
>
> User experience:
> During startup of admin/debit_types.pl I am seeing the 15 records for a
> short moment and end up with 3 records (filtered).
I agree, I not a fan of the "flash of unstyled content" effect this has but as
yet I've not managed to work around it.. I'll have another try.
> It would be nice to see them all and only allow editing of the non-system
> types ?
This is actually how I had it originally but updated the approach after
feedback from Nick and Severine. Perhaps just sorted the system and archived
ones to the bottom would be the best approach.. though I liked them being
interleaved so one could see why you could not create a new type with a code
that matched a system debit type.
> Same when saving a record (no blocker, but does not look good). When you do
> not want to show the records, do not fetch them at all?
> I saw that I now have a debit type F (Unexpected type found during upgrade).
I will take a look at adding some additional handling into the db update to
catch more cases of unrecognised types.. 'F' is obviously missed in certain
cases in previous bugs and should be caught and converted to proper 'OVERDUE'
types in my opinion. (I'm going to apply the patchset to a number of clones of
customers from various versions and try to spot some patterns to see what other
types may be being missed).
> Obviously this had to do with old fines stuff. I understand that bug 22521
> should have dealt with those, but somehow I still had such a record in
> accountlines. I am wondering if this will happen to more people and if we
> should anticipate on that by giving this F another description than
> unexpected ;)
>
> $dbh->do(
> qq{
> INSERT IGNORE INTO account_debit_types (
> code,
> description,
> can_be_added_manually,
> default_amount,
> is_system
> )
> SELECT
> SUBSTR(accounttype, 1, 80),
> "Unexpected type found during upgrade",
> 1,
> NULL,
> 0
> FROM
> accountlines
> WHERE
> amount > 0
> }
> );
> No need for the SUBSTR anymore. Please add a DISTINCT accounttype to this
> query to eliminate a lof of ignored inserts.
Good catch, I'll update the update statement
> And a question: If this type is unexpected, why do we enable Add manually ?
Also a good catch, thanks :).
>
> sub UpdateFine
> You touch the following line, obviously only changing the type codes. But
> this is a condition for finding the overdues. Why type M in the first place,
> and why not yet another debit code?
> debit_type_code => [ 'OVERDUE', 'M' ],
> This needs fixing somehow but I agree that it should be done on its own
> report..
Totally agree, I've never been entirely sure why 'M' was in that list and have
been slowly working towards removing it by clarifying it's use in bugs like
this.
>
> sub GetFine
> +WHERE debit_type_code LIKE 'OVERDUE'
> Shouldnt that be = ?
Also agree, I remember coming accross that one and thinking the same but
forgetting to actually change it. Thanks :). (I think historically it comes
from when fines were 'F' and 'FU' so it was a `LIKE "F%"`.)
>
> flexability [a.o. :) ]
> No, not so flexible.
>
> sub adjust
> -my $account_type = $self->accounttype;
> [..]
> +my $debit_type_code = $self->debit_type_code;
> As I understand, the only allowed code is now overdue so debit. But this
> change does not look very solid to me. Hopefully, we will not adjust too
> much ;)
Not sure I follow.. I'll double check the code but I believe it checks against
'OVERDUE' + 'UNRETURNED' (mix of type + status)
>
> Copier Fees
> Database: | Copier Fees | Copier Fees |
> 1 | 0.25 | 0 |
> -INSERT INTO `authorised_values` (category, authorised_value, lib) VALUES
> ('MANUAL_INV','Copier Fees','.25');
> git grep 'Copier Fees'
> installer/data/mysql/es-ES/optional/auth_val.sql:INSERT INTO
> `authorised_values` (category, authorised_value, lib) VALUES
> ('MANUAL_INV','Copier Fees','.25');
> Oops, you should remove that one above.
> Since we previously installed Copier Fees as a manual invoice, I think you
> should do now too. So add it too account_debit_types.sql.
> And Copier Fees should also have a new code. Now the description and code
> are the same. It is inconsistent with the other debit types. You also
> changed lots of other codes, or not?
I spotted that one this morning
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #202 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #201) > I saw that I still had data that conflicted with accounttype IS NOT NULL OR > debit_type_code IS NOT NULL; > > But when I removed that data and ran Accounts.t again, it still fails. So, we should make sure that at upgrade time we no longer have data that does not meet the new constraint. And still something wrong in the test ?? I leave it here for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #201 from Marcel de Rooy --- I saw that I still had data that conflicted with accounttype IS NOT NULL OR debit_type_code IS NOT NULL; But when I removed that data and ran Accounts.t again, it still fails. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #200 from Marcel de Rooy --- [FAIL] t/db_dependent/Accounts.t [OK] t/db_dependent/Circulation.t [OK] t/db_dependent/Circulation/NoIssuesChargeGuarantees.t [OK] t/db_dependent/Circulation/Returns.t [OK] t/db_dependent/Circulation/issue.t [FAIL] t/db_dependent/Koha/Account.t [OK] t/db_dependent/Circulation/issue.t [OK] t/db_dependent/Koha/Account/DebitType.t [OK] t/db_dependent/Koha/Account/DebitTypes.t [FAIL] t/db_dependent/Koha/Account/Lines.t [OK] t/db_dependent/Koha/Patron.t [OK] t/db_dependent/Reserves.t [OK] t/db_dependent/SIP/Transaction.t [FAIL] t/db_dependent/api/v1/patrons_accounts.t t/db_dependent/api/v1/patrons_accounts.t .. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_master`.`accountlines`, CONSTRAINT `accountlines_ibfk_debit_type` FOREIGN KEY (`debit_type_code`) REFERENCES `account_debit_types` (`code`) ON UPDATE CASCADE) [for Statement "INSERT INTO `accountlines` ( `amount`, `amountoutstanding`, `borrowernumber`, `branchcode`, `date`, `debit_type_code`, `description`, `interface`, `manager_id`) VALUES ( ?, ?, ?, ?, NOW(), ?, ?, ?, ? )" with ParamValues: 0=50, 1=50, 2=2930, 3='wfeFkt_9', 4='N', 5='A description', 6='test', 7=2930] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. => Looks like the description is copied to the debit code ? The other tests stumble over: DBIx::Class::Storage::DBI::_dbh_execute(): CONSTRAINT `accountlines_check_type` failed for `koha_master`.`accountlines` at /usr/share/koha/Koha/Object.pm line 156 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #199 from Marcel de Rooy ---
Tested on top of commit 480434bbf4a32750c5e47a3600b6a386d9732296 with your
branch.
Thanks for your hard work.
I have noted comments 64 and 85 (thx Kyle). I made my preference clear, and
continued on the current stand.
Comments below are in order of time noted, not priority.
User experience:
During startup of admin/debit_types.pl I am seeing the 15 records for a short
moment and end up with 3 records (filtered).
It would be nice to see them all and only allow editing of the non-system types
?
Same when saving a record (no blocker, but does not look good). When you do not
want to show the records, do not fetch them at all?
I saw that I now have a debit type F (Unexpected type found during upgrade).
Obviously this had to do with old fines stuff. I understand that bug 22521
should have dealt with those, but somehow I still had such a record in
accountlines. I am wondering if this will happen to more people and if we
should anticipate on that by giving this F another description than unexpected
;)
$dbh->do(
qq{
INSERT IGNORE INTO account_debit_types (
code,
description,
can_be_added_manually,
default_amount,
is_system
)
SELECT
SUBSTR(accounttype, 1, 80),
"Unexpected type found during upgrade",
1,
NULL,
0
FROM
accountlines
WHERE
amount > 0
}
);
No need for the SUBSTR anymore. Please add a DISTINCT accounttype to this query
to eliminate a lof of ignored inserts.
And a question: If this type is unexpected, why do we enable Add manually ?
sub UpdateFine
You touch the following line, obviously only changing the type codes. But this
is a condition for finding the overdues. Why type M in the first place, and why
not yet another debit code?
debit_type_code => [ 'OVERDUE', 'M' ],
This needs fixing somehow but I agree that it should be done on its own
report..
sub GetFine
+WHERE debit_type_code LIKE 'OVERDUE'
Shouldnt that be = ?
flexability [a.o. :) ]
No, not so flexible.
sub adjust
-my $account_type = $self->accounttype;
[..]
+my $debit_type_code = $self->debit_type_code;
As I understand, the only allowed code is now overdue so debit. But this change
does not look very solid to me. Hopefully, we will not adjust too much ;)
Copier Fees
Database: | Copier Fees | Copier Fees |
1 | 0.25 | 0 |
-INSERT INTO `authorised_values` (category, authorised_value, lib) VALUES
('MANUAL_INV','Copier Fees','.25');
git grep 'Copier Fees'
installer/data/mysql/es-ES/optional/auth_val.sql:INSERT INTO
`authorised_values` (category, authorised_value, lib) VALUES
('MANUAL_INV','Copier Fees','.25');
Oops, you should remove that one above.
Since we previously installed Copier Fees as a manual invoice, I think you
should do now too. So add it too account_debit_types.sql.
And Copier Fees should also have a new code. Now the description and code are
the same. It is inconsistent with the other debit types. You also changed lots
of other codes, or not?
Does this hold for some other debit types too that were formerly hardcoded?
Stuff like sundry etc. ? Which actually is a horrible category..
+ [%- SWITCH account.debit_type_code -%]
+ [%- CASE 'ACCOUNT' -%]Account creation fee
+ [%- CASE 'ACCOUNT_RENEW'-%]Account renewal fee
+ [%- CASE 'LOST' -%]Lost item
+ [%- CASE 'M'-%]Sundry
+ [%- CASE 'NEW_CARD' -%]New card
+ [%- CASE 'OVERDUE' -%]Fine
+ [%- CASE 'PROCESSING' -%]Lost item processing fee
+ [%- CASE 'RENT' -%]Rental fee
+ [%- CASE 'RENT_DAILY' -%]Daily rental fee
+ [%- CASE 'RENT_RENEW' -%]Renewal of rental item
+ [%- CASE 'RENT_DAILY_RENEW' -%]Rewewal of daily rental item
+ [%- CASE 'RESERVE' -%]Hold fee
+ [%- CASE 'RESERVE_EXPIRED' -%]Hold waiting too long
+ [%- CASE-%][% account.debit_type.description |
html %]
+ [%- END -%]
Note that koha-tmpl/intranet-tmpl/prog/en/includes/accounts.inc contains debit
code M for sundry while account_debit_types.sql install M as Manual fee !
This is a BLOCKER. Please correct.
At the credit side, I am seeing code FORW (and FOR and W and WO !) and having
doubts about it, leaving it outside the scope for now..
Submitting another comment for the failing tests.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website :
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #198 from Marcel de Rooy --- Still working on this one, Martin. Dont change QA contact without communication please, especially within such a short time frame. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Marcel de Rooy changed: What|Removed |Added QA Contact|k...@bywatersolutions.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #197 from Marcel de Rooy --- Martin Renvoize changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|k...@bywatersolutions.com Whats happening here ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94351|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94350|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94352|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94348|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94349|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94347|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94341|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94343|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94346|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94344|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94345|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94342|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94340|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94337|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94339|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94338|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94331|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94336|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94335|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94333|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94334|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94332|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 --- Comment #196 from Martin Renvoize --- I've pushed a public branch to keep this rebased rather than throw yet more patches in here: https://github.com/PTFS-Europe/koha/tree/bug_23049_inv -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added URL||https://github.com/PTFS-Eur ||ope/koha/tree/bug_23049_inv -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #195 from Martin Renvoize --- (In reply to Kyle M Hall from comment #150) > DEV atomic update: bug_23049_debit.perl > DBD::mysql::db do failed: Table 'koha_kohadev.account_credit_types' doesn't > exist [for Statement " > INSERT IGNORE INTO account_credit_types ( > code, > description, > can_be_added_manually, > default_amount, > is_system > ) > SELECT > SUBSTR(accounttype, 1, 80), > "Unexpected type found during upgrade", > 1, > NULL, > 0 > FROM > accountlines > WHERE > amount > 0 > "] at (eval 1419) line 109. > Upgrade to XXX done (Bug 23049 - Add account debit_types) Rebase mistake.. should be better now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94329|0 |1 is obsolete|| --- Comment #194 from Martin Renvoize --- Created attachment 94352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94352=edit Bug 23049: (follow-up) Handle unexpected types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94326|0 |1 is obsolete|| --- Comment #191 from Martin Renvoize --- Created attachment 94349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94349=edit Bug 23049: More thorough param checking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94328|0 |1 is obsolete|| --- Comment #193 from Martin Renvoize --- Created attachment 94351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94351=edit Bug 23049: (follow-up) Correction to includes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94327|0 |1 is obsolete|| --- Comment #192 from Martin Renvoize --- Created attachment 94350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94350=edit Bug 23049: (follow-up) VARCHAR(80) + ac -> account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94325|0 |1 is obsolete|| --- Comment #190 from Martin Renvoize --- Created attachment 94348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94348=edit Bug 23049: Update API Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94324|0 |1 is obsolete|| --- Comment #189 from Martin Renvoize --- Created attachment 94347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94347=edit Bug 23049: Drop type lookup as it's now a foreign key Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94319|0 |1 is obsolete|| --- Comment #185 from Martin Renvoize --- Created attachment 94343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94343=edit Bug 23049: Capitalise type passed to add_debit for lost_item Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94321|0 |1 is obsolete|| --- Comment #187 from Martin Renvoize --- Created attachment 94345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94345=edit Bug 23049: Capitalise type passed to add_debit for `overdue` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94320|0 |1 is obsolete|| --- Comment #186 from Martin Renvoize --- Created attachment 94344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94344=edit Bug 23049: Remove manual_debit as it's never called Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94318|0 |1 is obsolete|| --- Comment #184 from Martin Renvoize --- Created attachment 94342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94342=edit Bug 23049: Update 'HE' to 'RESERVE_EXPIRED' for consistency This patch updates all cases where debit_type_code was 'HE' to 'RESERVE_EXPIRED' which is more informative and consistent with the new style guidelines. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94323|0 |1 is obsolete|| --- Comment #188 from Martin Renvoize --- Created attachment 94346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94346=edit Bug 23049: Update 'N' to 'NEW_CARD' for consistency Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94317|0 |1 is obsolete|| --- Comment #183 from Martin Renvoize --- Created attachment 94341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94341=edit Bug 23049: Capitalise type passed to add_debit for `account` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94316|0 |1 is obsolete|| --- Comment #182 from Martin Renvoize --- Created attachment 94340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94340=edit Bug 23049: Update 'PF' to 'PROCESSING' for consistency Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94315|0 |1 is obsolete|| --- Comment #181 from Martin Renvoize --- Created attachment 94339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94339=edit Bug 23049: Capitalise type passed to add_debit for `rent` Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94314|0 |1 is obsolete|| --- Comment #180 from Martin Renvoize --- Created attachment 94338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94338=edit Bug 23049: Update debit_type_code 'Res' to 'RESERVE' This patch updates all cases where debit_type_code was 'Res' to 'RESERVE' which is more informative and consistent with the new style guidelines. The patch also ensure all calls to add_debit with a type or 'reserve' now pass the capitalised code instead. Signed-off-by: Séverine QUEUNE Capitalise reserve -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94313|0 |1 is obsolete|| --- Comment #179 from Martin Renvoize --- Created attachment 94337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94337=edit Bug 23049: Update existing code to use debit_type * Update C4::Accounts::chargelostitem * Update C4::Accounts::manualinvoice * Update C4::Circulation::_FixOverduesOnReturn * Update C4::Circulation::_FixAccountForLostAndReturned * Update C4::Overdues::UpdateFine * Update C4::Overdues::GetFine * Update C4::Overdues::GetOverduesForBranch * Update Koha::Account->pay * Update Koha::Account->add_debit * Update Koha::Account->non_issues_charges * Update Koha::Account::Line->apply * Update Koha::Account::Line->adjust * Update controller scripts * Update reports scripts * Update tests Test Plan 1) Run the test suit and ensure everything still passes 2) Test reports/cash_register_stats still works 3) Test that adding manual invoices still works 4) Test that making payments still works 5) Test that lost item fee handling still works 6) Test that invoice printing still works 7) Test that the sco still works Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94311|0 |1 is obsolete|| --- Comment #177 from Martin Renvoize --- Created attachment 94335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94335=edit Bug 23049: Update maninvoice to reference debit types Test plan: 1) Naviage to a patron record and select the accounts > manual invoice tab 2) Add some manual invoices and confirm they are working as expected 3) Signoff Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94310|0 |1 is obsolete|| --- Comment #176 from Martin Renvoize --- Created attachment 94334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94334=edit Bug 23049: Filter out system types by default Test Plan 1) Navigate to the debit types management page added in previous patches 2) Note that system types are now filtered out by default 3) Click on the new unfilter button to include system types 4) Signoff Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94312|0 |1 is obsolete|| --- Comment #178 from Martin Renvoize --- Created attachment 94336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94336=edit Bug 23049: Add tests Test plan: prove t/db_dependent/Koha/Account/DebitType.t prove t/db_dependent/Koha/Account/DebitTypes.t Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94308|0 |1 is obsolete|| --- Comment #174 from Martin Renvoize --- Created attachment 94332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94332=edit Bug 23049: Add CHECK constraint to accountlines Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94309|0 |1 is obsolete|| --- Comment #175 from Martin Renvoize --- Created attachment 94333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94333=edit Bug 23049: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Debit types page in Accounting section 2) Go to any other admin page and confirm there is link to Debit types in the admin menu as well 3) Go to Debit types page 4) You should see a datatable listing existing debit types, ensure they are working as expected. 5) Try to create, edit and delete some debit types. Note: Some debit types cannot be deleted as they are needed for koha functionality. Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94307|0 |1 is obsolete|| --- Comment #173 from Martin Renvoize --- Created attachment 94331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94331=edit Bug 23049: Add debit_type * Add account_debit_types table * Add ac_debit_types_branches table * Add account_debit_types defaults * Add Koha::Account::DebitType and Koha::Account::DebitTypes * Prevent deletion of defaults * Migrate MANUAL_INV values * Remove MANUAL_INV references * Migrate accounttype values Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize changed: What|Removed |Added Attachment #94152|0 |1 is obsolete|| --- Comment #171 from Martin Renvoize --- Created attachment 94328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94328=edit Bug 23049: (follow-up) Correction to includes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
