[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2023-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Sam Lau  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=34071

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2023-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||33887


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33887
[Bug 33887] Automatic checkin should be able to optionally fill the next hold
with the returned item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2022-01-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Keywords|Manual  |Manual-updated
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-08-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||28913


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913
[Bug 28913] Automatic checkin setting in item type setup should note required
cronjob
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-05-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207
Bug 23207 depends on bug 28190, which changed state.

Bug 28190 Summary: Library limitation column not toggable on itemtypes table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28190

   What|Removed |Added

 Status|Pushed to stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #41 from Fridolin Somers  ---
Enhancement not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #40 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #39 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #38)
> One last thing, shouldn't we display the "auto checkin" info in the checkout
> list (current checkouts at circulation.pl and circulation history)?
> 
> Pushing as it, feel free to follow-up here or open a separate bug report if
> you think it is a good one to have for 21.05.

I will ask the sponsors, but it makes sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #38 from Jonathan Druart  
---
One last thing, shouldn't we display the "auto checkin" info in the checkout
list (current checkouts at circulation.pl and circulation history)?

Pushing as it, feel free to follow-up here or open a separate bug report if you
think it is a good one to have for 21.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #37 from Tomás Cohen Arazi  ---
Created attachment 12
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12=edit
Bug 23207: Automatic checkin items should never be overdue

This patch makes Koha::Checkouts->automatic_checkin pass the date_due as
return date to AddReturn.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Checkouts.t
=> FAIL: The feature is not working properly
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #36 from Tomás Cohen Arazi  ---
Created attachment 11
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11=edit
Bug 23207: Regression tests

This patch introduces a regression test for the case the automatic
checkin happens after the date due. In that case the item souldn't
really be overdue, and the checkin should be recorded with the date due
as return date.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Checkouts.t
=> FAIL: The feature doesn't behave correctly

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #119966|0   |1
is obsolete||

--- Comment #35 from Jonathan Druart  
---
Created attachment 119985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119985=edit
Bug 23207: (QA follow-up) Add COMMENT to new column

Signed-off-by: Tomas Cohen Arazi 

JD amended patch: FIX syntax error.(swap COMMENT and AFTER)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #34 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #27)
> 4. Thinking about the edge cases, date handling: don't we want to pass the
> due date for the return date, in order to not flag the checkin as overdue in
> the checkout history list?

No answer provided.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #33 from Tomás Cohen Arazi  ---
Created attachment 119973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119973=edit
Bug 23207: (QA follow-up) Add to cron files

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #32 from Tomás Cohen Arazi  ---
Created attachment 119967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119967=edit
Bug 23207: (QA follow-up) Add new column on item types UI table

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #31 from Tomás Cohen Arazi  ---
Created attachment 119966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119966=edit
Bug 23207: (QA follow-up) Add COMMENT to new column

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||28190
 Status|Failed QA   |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28190
[Bug 28190] Library limitation column not toggable on itemtypes table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #30 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #28)
> (In reply to Jonathan Druart from comment #27)
> > 1. Entry missing in misc/cronjobs/crontab.example
> 
> Good catch.
> 
> > 2. Any good reasons to not add the info in a new column of the itemtypes
> > table?
> 
> You mean is missing the COMMENT?

admin/itemtypes.pl => The info is not in the table.

(In reply to Katrin Fischer from comment #29)
> (In reply to Tomás Cohen Arazi from comment #28)
> > (In reply to Jonathan Druart from comment #27)
> > > 1. Entry missing in misc/cronjobs/crontab.example
> > 
> > Good catch.
> > 
> > > 2. Any good reasons to not add the info in a new column of the itemtypes
> > > table?
> > 
> > You mean is missing the COMMENT?
> 
> Not sure if it#s there already, but I think waht's meant was administration
> > itemtypes - showing the setting there in column, so you can filter etc.
> 
> > 
> > > 3. (just grumbling) we really need to remove the item type at biblio level
> > > (item-level_itypes syspref) and have a FK on items.itemtype. Not having 
> > > the
> > > ability to join here is terrible, we have to loop over all the 
> > > checkouts...
> > > Not considering blocker but we may want to improve perf here in the future
> > > using the usual (ugly) condition for the join.
> > 
> > This is a broader discussion, but biblio-level itype is really a thing,
> > because it is used for filtering and facets as well.
> I agree, we cannot remove the itemtype on biblio-level, it's tied to varioud
> features and checks (max reserves check for biblio level holds, article
> requests without items etc.) We could maybe remove it from MARC/only add it
> for indexing maybe?

Definitely not the place to have the discussion, but we discussed it already
several times and mostly agreed on removing it...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #29 from Katrin Fischer  ---
(In reply to Tomás Cohen Arazi from comment #28)
> (In reply to Jonathan Druart from comment #27)
> > 1. Entry missing in misc/cronjobs/crontab.example
> 
> Good catch.
> 
> > 2. Any good reasons to not add the info in a new column of the itemtypes
> > table?
> 
> You mean is missing the COMMENT?

Not sure if it#s there already, but I think waht's meant was administration >
itemtypes - showing the setting there in column, so you can filter etc.

> 
> > 3. (just grumbling) we really need to remove the item type at biblio level
> > (item-level_itypes syspref) and have a FK on items.itemtype. Not having the
> > ability to join here is terrible, we have to loop over all the checkouts...
> > Not considering blocker but we may want to improve perf here in the future
> > using the usual (ugly) condition for the join.
> 
> This is a broader discussion, but biblio-level itype is really a thing,
> because it is used for filtering and facets as well.

I agree, we cannot remove the itemtype on biblio-level, it's tied to varioud
features and checks (max reserves check for biblio level holds, article
requests without items etc.) We could maybe remove it from MARC/only add it for
indexing maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #28 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #27)
> 1. Entry missing in misc/cronjobs/crontab.example

Good catch.

> 2. Any good reasons to not add the info in a new column of the itemtypes
> table?

You mean is missing the COMMENT?

> 3. (just grumbling) we really need to remove the item type at biblio level
> (item-level_itypes syspref) and have a FK on items.itemtype. Not having the
> ability to join here is terrible, we have to loop over all the checkouts...
> Not considering blocker but we may want to improve perf here in the future
> using the usual (ugly) condition for the join.

This is a broader discussion, but biblio-level itype is really a thing, because
it is used for filtering and facets as well.

> 4. Thinking about the edge cases, date handling: don't we want to pass the
> due date for the return date, in order to not flag the checkin as overdue in
> the checkout history list?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #27 from Jonathan Druart  
---
1. Entry missing in misc/cronjobs/crontab.example

2. Any good reasons to not add the info in a new column of the itemtypes table?

3. (just grumbling) we really need to remove the item type at biblio level
(item-level_itypes syspref) and have a FK on items.itemtype. Not having the
ability to join here is terrible, we have to loop over all the checkouts...
Not considering blocker but we may want to improve perf here in the future
using the usual (ugly) condition for the join.

4. Thinking about the edge cases, date handling: don't we want to pass the due
date for the return date, in order to not flag the checkin as overdue in the
checkout history list?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the||This adds a new
  release notes||configuration option to the
   ||itemtype administration
   ||page: Automatic checkin.
   ||With automatic checkin
   ||enabled the item will be
   ||automatically checked in at
   ||its due date.
   ||In order for
   ||this feature to work
   ||correctly, the
   ||automatic_checkin.pl
   ||cronjob needs to be set up
   ||on your installation.
   Keywords||Manual,
   ||release-notes-needed

--- Comment #26 from Katrin Fischer  ---
Happy to see this in PQA, trying to provide the release notes note.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #25 from Martin Renvoize  ---
Interesting feature.. works as described and contains tests and passes QA
scripts.

Passing QA

I can see lots of use cases for this, it'll be interesting to see how it plays
out..

Electronic resources, Inter-library loans etc..

I liked Andrews suggestions, so I went ahead an implemented them as a QA
follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #24 from Martin Renvoize  ---
Created attachment 119730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119730=edit
Bug 23207: (QA follow-up) Move option

This patch impliment the changes as suggested by Andrew on the bug
report. I agree that the suggested location fits better in the page and
the updated description is clearer.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #117994|0   |1
is obsolete||

--- Comment #23 from Martin Renvoize  ---
Created attachment 119729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119729=edit
Bug 23207: Add automatic checkin feature

This patch adds the posibility to set an itemtype with automatic
checkin. It means that when the checkout is due, it will
automatically check in.

To test:
1. apply patches
2. updatedatabase
3. go to koha administration -> item types and edin an item type (from
   now on called itemtype1)
CHECK => there is a checkbox almost at the end called automatic checkin
4. check that checkbox and save
5. checkout 2 items from itemtype1 and one item from another itemtype
   (from now on called itemtype2)
6. go to mysql database console (koha-mysql) and manually set date_due =
current_timestamp
   in issues table for the item of itemtype2 and only one of the items of
itemtype1
7. run cronjob at misc/cronjobs/automatic_checkin.pl
8. go to mysql database console again and select * from issues
SUCCESS => All issues are present except for the issue of itemtype1
which had it's date_due set to current_timestamp. That one was
automatically checked in.
9. prove t/db_dependent/Koha/Checkouts.t

Signed-off-by: Andrew Fuerste-Henry 
Signed-off-by: Hasina Akhter 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #117993|0   |1
is obsolete||

--- Comment #22 from Martin Renvoize  ---
Created attachment 119728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119728=edit
Bug 23207: Set automatic_checkin column as boolean in Itemtype schema

Signed-off-by: Andrew Fuerste-Henry 
Signed-off-by: Hasina Akhter 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #117992|0   |1
is obsolete||

--- Comment #21 from Martin Renvoize  ---
Created attachment 119727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119727=edit
Bug 23207: Add automatic_checkin column to itemtypes table

installer/data/mysql/kohastructure.sql

Signed-off-by: Andrew Fuerste-Henry 
Signed-off-by: Hasina Akhter 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-04-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #117991|0   |1
is obsolete||

--- Comment #20 from Martin Renvoize  ---
Created attachment 119726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119726=edit
Bug 23207: Add test

Signed-off-by: Andrew Fuerste-Henry 
Signed-off-by: Hasina Akhter 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #117986|0   |1
is obsolete||

--- Comment #18 from Andrew Fuerste-Henry  ---
Created attachment 117993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117993=edit
Bug 23207: Set automatic_checkin column as boolean in Itemtype schema

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Hasina Akhter 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #117987|0   |1
is obsolete||

--- Comment #19 from Andrew Fuerste-Henry  ---
Created attachment 117994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117994=edit
Bug 23207: Add automatic checkin feature

This patch adds the posibility to set an itemtype with automatic
checkin. It means that when the checkout is due, it will
automatically check in.

To test:
1. apply patches
2. updatedatabase
3. go to koha administration -> item types and edin an item type (from
   now on called itemtype1)
CHECK => there is a checkbox almost at the end called automatic checkin
4. check that checkbox and save
5. checkout 2 items from itemtype1 and one item from another itemtype
   (from now on called itemtype2)
6. go to mysql database console (koha-mysql) and manually set date_due =
current_timestamp
   in issues table for the item of itemtype2 and only one of the items of
itemtype1
7. run cronjob at misc/cronjobs/automatic_checkin.pl
8. go to mysql database console again and select * from issues
SUCCESS => All issues are present except for the issue of itemtype1
which had it's date_due set to current_timestamp. That one was
automatically checked in.
9. prove t/db_dependent/Koha/Checkouts.t

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Hasina Akhter 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #117985|0   |1
is obsolete||

--- Comment #17 from Andrew Fuerste-Henry  ---
Created attachment 117992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117992=edit
Bug 23207: Add automatic_checkin column to itemtypes table

installer/data/mysql/kohastructure.sql

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Hasina Akhter 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #117984|0   |1
is obsolete||

--- Comment #16 from Andrew Fuerste-Henry  ---
Created attachment 117991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117991=edit
Bug 23207: Add test

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Hasina Akhter 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #15 from Andrew Fuerste-Henry  ---
Two tiny bits of feedback. On the item type setup page, I'd like to see the
checkbox for automatic checkin moved up just underneath the checkbox for Not
for Loan. That groups things a bit more thematically. Additionally, the text
there currently reads: "If checked, items will be checked in automatically
after a period of time. Useful for materials where you really don't care for
fisical return, like museum passes, etc."
I would suggest:
"If checked, items will be automatically checked in once they've reached their
due date."
This clarifies how the checkin time is specified. I don't think we need a note
here suggesting possible usage, that could go in the release notes and manual.
If we want to retain that note, however, I 'd reword it as "This is useful for
materials that do not require a physical checkin, such as museum passes, etc."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #117973|0   |1
is obsolete||

--- Comment #14 from Andrew Fuerste-Henry  ---
Created attachment 117987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117987=edit
Bug 23207: Add automatic checkin feature

This patch adds the posibility to set an itemtype with automatic
checkin. It means that when the checkout is due, it will
automatically check in.

To test:
1. apply patches
2. updatedatabase
3. go to koha administration -> item types and edin an item type (from
   now on called itemtype1)
CHECK => there is a checkbox almost at the end called automatic checkin
4. check that checkbox and save
5. checkout 2 items from itemtype1 and one item from another itemtype
   (from now on called itemtype2)
6. go to mysql database console (koha-mysql) and manually set date_due =
current_timestamp
   in issues table for the item of itemtype2 and only one of the items of
itemtype1
7. run cronjob at misc/cronjobs/automatic_checkin.pl
8. go to mysql database console again and select * from issues
SUCCESS => All issues are present except for the issue of itemtype1
which had it's date_due set to current_timestamp. That one was
automatically checked in.
9. prove t/db_dependent/Koha/Checkouts.t

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #117972|0   |1
is obsolete||

--- Comment #13 from Andrew Fuerste-Henry  ---
Created attachment 117986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117986=edit
Bug 23207: Set automatic_checkin column as boolean in Itemtype schema

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #117971|0   |1
is obsolete||

--- Comment #12 from Andrew Fuerste-Henry  ---
Created attachment 117985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117985=edit
Bug 23207: Add automatic_checkin column to itemtypes table

installer/data/mysql/kohastructure.sql

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #117970|0   |1
is obsolete||

--- Comment #11 from Andrew Fuerste-Henry  ---
Created attachment 117984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117984=edit
Bug 23207: Add test

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #10 from Nick Clemens  ---
Created attachment 117973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117973=edit
Bug 23207: Add automatic checkin feature

This patch adds the posibility to set an itemtype with automatic
checkin. It means that when the checkout is due, it will
automatically check in.

To test:
1. apply patches
2. updatedatabase
3. go to koha administration -> item types and edin an item type (from
   now on called itemtype1)
CHECK => there is a checkbox almost at the end called automatic checkin
4. check that checkbox and save
5. checkout 2 items from itemtype1 and one item from another itemtype
   (from now on called itemtype2)
6. go to mysql database console (koha-mysql) and manually set date_due =
current_timestamp
   in issues table for the item of itemtype2 and only one of the items of
itemtype1
7. run cronjob at misc/cronjobs/automatic_checkin.pl
8. go to mysql database console again and select * from issues
SUCCESS => All issues are present except for the issue of itemtype1
which had it's date_due set to current_timestamp. That one was
automatically checked in.
9. prove t/db_dependent/Koha/Checkouts.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #9 from Nick Clemens  ---
Created attachment 117972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117972=edit
Bug 23207: Set automatic_checkin column as boolean in Itemtype schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #8 from Nick Clemens  ---
Created attachment 117971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117971=edit
Bug 23207: Add automatic_checkin column to itemtypes table

installer/data/mysql/kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Nick Clemens  changed:

   What|Removed |Added

 Attachment #114212|0   |1
is obsolete||
 Attachment #114213|0   |1
is obsolete||
 Attachment #114214|0   |1
is obsolete||
 Attachment #114215|0   |1
is obsolete||

--- Comment #7 from Nick Clemens  ---
Created attachment 117970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117970=edit
Bug 23207: Add test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Katrin Fischer  changed:

   What|Removed |Added

 CC||m...@software.coop

--- Comment #6 from Katrin Fischer  ---
*** Bug 7716 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2021-03-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #5 from Katrin Fischer  ---
This sounds like a really interesting feature to handle our ILL copies. Could
you please rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2020-12-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2020-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #4 from Agustín Moyano  ---
Created attachment 114215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114215=edit
Bug 23207: Add automatic checkin feature

This patch adds the posibility to set an itemtype with automatic
checkin. It means that when the checkout is due, it will
automatically check in.

To test:
1. apply patches
2. updatedatabase
3. go to koha administration -> item types and edin an item type (from
   now on called itemtype1)
CHECK => there is a checkbox almost at the end called automatic checkin
4. check that checkbox and save
5. checkout 2 items from itemtype1 and one item from another itemtype
   (from now on called itemtype2)
6. go to mysql database console (koha-mysql) and manually set date_due =
current_timestamp
   in issues table for the item of itemtype2 and only one of the items of
itemtype1
7. run cronjob at misc/cronjobs/automatic_checkin.pl
8. go to mysql database console again and select * from issues
SUCCESS => All issues are present except for the issue of itemtype1
which had it's date_due set to current_timestamp. That one was
automatically checked in.
9. prove t/db_dependent/Koha/Checkouts.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2020-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #3 from Agustín Moyano  ---
Created attachment 114214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114214=edit
Bug 23207: Set automatic_checkin column as boolean in Itemtype schema

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2020-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #2 from Agustín Moyano  ---
Created attachment 114213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114213=edit
Bug 23207: Add automatic_checkin column to itemtypes table

installer/data/mysql/kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2020-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

--- Comment #1 from Agustín Moyano  ---
Created attachment 114212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114212=edit
Bug 23207: Add test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2020-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Agustín Moyano  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2020-11-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Agustín Moyano  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period

2020-08-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207

Tomás Cohen Arazi  changed:

   What|Removed |Added

Version|18.11   |master
   Assignee|koha-b...@lists.koha-commun |agustinmoy...@theke.io
   |ity.org |
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/