[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_22_11_candidate Severity|enhancement |new feature CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Bug 23681 depends on bug 31136, which changed state. Bug 31136 Summary: Restrictions types select fails on memberentry page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31136 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Depends on||31136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31136 [Bug 31136] Restrictions types select fails on memberentry page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Depends on||31129 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31129 [Bug 31129] Number of restrictions is always "0" on the "Check out" tab -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31129 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137094|0 |1 is obsolete|| --- Comment #287 from Katrin Fischer --- Created attachment 137130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137130=edit Bug 23681: (QA follow-up) Fix memberentry page display We were missing some changes to the restriction types dropdown handling in the memberentry template. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137093|0 |1 is obsolete|| --- Comment #286 from Katrin Fischer --- Created attachment 137129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137129=edit Bug 23681: (QA follow-up) Fix debarment count This patch fixes the debarment count displayed on the circulation page tabs Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137092|0 |1 is obsolete|| --- Comment #285 from Katrin Fischer --- Created attachment 137128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137128=edit Bug 23681: (QA follow-up) Match default data to update The default data at install time didn't match the data added at update. This patch corrects that and by doing so it also adds back the ability to make MANUAL restriction types the default after any other type has been made default. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137091|0 |1 is obsolete|| --- Comment #284 from Katrin Fischer --- Created attachment 137127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137127=edit Bug 23681: (QA follow-up) Remove spacing and add question mark This patch removes the superflous whitespace around the restriction descriptions and also adds the missing question mark into the delete question. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137090|0 |1 is obsolete|| --- Comment #283 from Katrin Fischer --- Created attachment 137126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137126=edit Bug 23681: (QA follow-up) Add patron restrictions to admin menu This patch adds the patron restrictions page to the admin menu that appears to the left on all administration pages. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137089|0 |1 is obsolete|| --- Comment #282 from Katrin Fischer --- Created attachment 137125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137125=edit Bug 23681: (follow-up) Mark fields at booleans Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137088|0 |1 is obsolete|| --- Comment #281 from Katrin Fischer --- Created attachment 137124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137124=edit Bug 23681: DBIC Rebuild Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137087|0 |1 is obsolete|| --- Comment #280 from Katrin Fischer --- Created attachment 137123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137123=edit Bug 23681: (QA follow-up) Proper handling of default option This patch removes the 'can_be_added_manually' flag. Only non-system restriction types can be added manually, so we exclude is_system instead of having two flags. (And we set the 'Manual' that's added at install time to default but not system). We then add proper handling for setting the default manual restriction type in the management page and set the dropdown list to use that value by default. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137086|0 |1 is obsolete|| --- Comment #279 from Katrin Fischer --- Created attachment 137122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137122=edit Bug 23681: (QA follow-up) Merge update files This patch merges the three atomic update files into one and also adds a check for foreing key existance to make the update idempotent. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137085|0 |1 is obsolete|| --- Comment #278 from Katrin Fischer --- Created attachment 137121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137121=edit Bug 23681: (QA follow-up) Restore customisablity of description This patch restores the customisability of description for system restriction types. Translatability is not affected as you can translate the defaults via template translation and assuming the end users leave their descriptions at the default, the translations will be picked. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137084|0 |1 is obsolete|| --- Comment #277 from Katrin Fischer --- Created attachment 137120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137120=edit Bug 23681: (QA follow-up) Move preference again This patch removes the new PatronRestrictionTypes preference from the accounting area in preference to creating a new group for 'Patron restriction' related preferences in the circulation preferences tab. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137083|0 |1 is obsolete|| --- Comment #276 from Katrin Fischer --- Created attachment 137119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137119=edit Bug 23681: DO NOT PUSH! Schema changes To be able to delete and pass tests we need to declare koha_object[s]_class to DebarmentType.pm. Otherwise following error is raised: "Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237" Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137082|0 |1 is obsolete|| --- Comment #275 from Katrin Fischer --- Created attachment 137118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137118=edit Bug 23681: Fix QA issues This patch fixes following QA issues: - convert intaller files as .yml - change column name readonly as is_system - change column name is_system as default_value - add column can_be_added_manually (testplan for this below) - move syspref "PatronRestrictionTypes" to "Accounting > Features" tab - tweak page title - tweak tests to apply these changes Also atomicupdate files have been updated. Issues with delete and tests is fixed with adding additional schema change file. To test: 1) Add new restriction type and make it manual. 2) Navigate to patron details page. 3) Add new restriction to patron. => Only selectable restriction should be the one you just created. Also prove t/db_dependent/RestrictionTypes.t. Sponsored-by: Koha-Suomi Oy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137081|0 |1 is obsolete|| --- Comment #274 from Katrin Fischer --- Created attachment 137117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137117=edit Bug 23681: (QA follow-up) Fix prefs Add the missing `.` and switch from `yes/no` to `1/0`. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137080|0 |1 is obsolete|| --- Comment #273 from Katrin Fischer --- Created attachment 137116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137116=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137079|0 |1 is obsolete|| --- Comment #272 from Katrin Fischer --- Created attachment 137115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137115=edit Bug 23681: (QA follow-up) Fix license, perlcritic & executable This patch fixes the simple issues mentioned by the QA script. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137078|0 |1 is obsolete|| --- Comment #271 from Katrin Fischer --- Created attachment 137114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137114=edit Bug 23681: Updates for bug 26703 This patch fixes the title ordering and also replaces the breadcrumbs with the modern nav block equivilent Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137077|0 |1 is obsolete|| --- Comment #270 from Katrin Fischer --- Created attachment 137113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137113=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137076|0 |1 is obsolete|| --- Comment #269 from Katrin Fischer --- Created attachment 137112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137112=edit Bug 23681: (follow-up) Fix rebase issues Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137075|0 |1 is obsolete|| --- Comment #268 from Katrin Fischer --- Created attachment 137111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137111=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137074|0 |1 is obsolete|| --- Comment #267 from Katrin Fischer --- Created attachment 137110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137110=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137073|0 |1 is obsolete|| --- Comment #266 from Katrin Fischer --- Created attachment 137109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137109=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137072|0 |1 is obsolete|| --- Comment #265 from Katrin Fischer --- Created attachment 137108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137108=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137071|0 |1 is obsolete|| --- Comment #264 from Katrin Fischer --- Created attachment 137107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137107=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137070|0 |1 is obsolete|| --- Comment #263 from Katrin Fischer --- Created attachment 137106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137106=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137069|0 |1 is obsolete|| --- Comment #262 from Katrin Fischer --- Created attachment 137105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137105=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137068|0 |1 is obsolete|| --- Comment #261 from Katrin Fischer --- Created attachment 137104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137104=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137067|0 |1 is obsolete|| --- Comment #260 from Katrin Fischer --- Created attachment 137103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137103=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Attachment #137066|0 |1 is obsolete|| --- Comment #259 from Katrin Fischer --- Created attachment 137102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137102=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #258 from Katrin Fischer --- 0) QA script + unit tests RESOLVED 1) Side menu RESOLVED 2) Delete confirmation RESOLVED 3) Default behavior / MANUAL RESOLVED 4) :) 5) Pre-selection in pull down Retested and RESOLVED. 6) Number in restrictions tab RESOLVED 7) When editing the patron record, the pull down for restriction type is empty. RESOLVED 8) Show restriction type in places MOVE to separate bug later :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #257 from Katrin Fischer --- (In reply to Martin Renvoize from comment #256) > (In reply to Katrin Fischer from comment #224) > > > I'd also make the button just "Delete" or "Yes, delete", but that's a > > personal preference and I see that this was 'copied' from how deleting a > > patron category looks like. > > Hmm, I'd love to see us standardise on something and create a guideline > about it.. at that time I'd be keen to go through and get everything > consistent. Agreed, I was just wondering, because in German such buttons tend to get huge. > > > 3) After installing/updating with this patch, MANUAL is marked es the > > default. You cannot change it, until you have added a new restriction, which > > makes sense, as the system internal ones should not be default. But: you > > cannot ever change the default back to MANUAL. I think this is because > > system internal values are excluded, but it might raise complaints for > > people experimenting with the feature that want to restore previous > > behavior. > > I discovered the update and the install data were out of sync.. fixed in a > follow-up. This resolves the defaulting issue. Good catch! Will retest. > > 5) When adding a manual restriction to the patron account, the default seems > > to be only used when PatronRestrictionTypes is off, when it's on and the > > pull down shows, the default is not preselected, but the first entry is. > > Hmm, I couldn't replicate this. I'll retest. > > 8) I notice that the type itself doesn't show up in the OPAC or the note on > > the patron account in staff, just the comments do. This is the case with and > > without the patches, maybe something so consider later. Or we could imagine > > adding a default comment? (no blocker, just loud thinking) > > Wow.. wierd.. I'd never noticed that.. can we submit a new bug for that one? Yes, loud thinking definitely warrants a separate bug. I'd also not noticed that before, but it's unchanged by this patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Blocks||31097 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31097 [Bug 31097] Patron restriction types should display in Staff and OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #256 from Martin Renvoize --- (In reply to Katrin Fischer from comment #224) > 1) The new patron restrictions configuration page is missing from the > Administration side menu, visible when you are on any of the admin pages. > It's ok on the start page of the module. Fixed in follow-up > 2) The delete confirmation question is missing a question mark :) (also > might want to remove the additional spaces) > Are you sure you want to delete " Test " Fixed in follow-up > I'd also make the button just "Delete" or "Yes, delete", but that's a > personal preference and I see that this was 'copied' from how deleting a > patron category looks like. Hmm, I'd love to see us standardise on something and create a guideline about it.. at that time I'd be keen to go through and get everything consistent. > 3) After installing/updating with this patch, MANUAL is marked es the > default. You cannot change it, until you have added a new restriction, which > makes sense, as the system internal ones should not be default. But: you > cannot ever change the default back to MANUAL. I think this is because > system internal values are excluded, but it might raise complaints for > people experimenting with the feature that want to restore previous behavior. I discovered the update and the install data were out of sync.. fixed in a follow-up. This resolves the defaulting issue. > 4) Just a comment: Love the new Patron restrictions sub heading in patron > preferences :) Glad you like it :) > 5) When adding a manual restriction to the patron account, the default seems > to be only used when PatronRestrictionTypes is off, when it's on and the > pull down shows, the default is not preselected, but the first entry is. Hmm, I couldn't replicate this. > 6) Something super odd: In the patron account in the staff interface, on the > checkout tab, the Restrictions shows as (0), while on the details tab the > restrictions show the correct number (2) I have added. Only the tab heading > is wrong, otherwise the restrictions show ok. Unrelated to this patchset I believe.. bit it is fixed in a follow-up now. > 7) When editing the patron record, the pull down for restriction type is > empty. Fixed in follow-up. > 8) I notice that the type itself doesn't show up in the OPAC or the note on > the patron account in staff, just the comments do. This is the case with and > without the patches, maybe something so consider later. Or we could imagine > adding a default comment? (no blocker, just loud thinking) Wow.. wierd.. I'd never noticed that.. can we submit a new bug for that one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #255 from Martin Renvoize --- Created attachment 137094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137094=edit Bug 23681: (QA follow-up) Fix memberentry page display We were missing some changes to the restriction types dropdown handling in the memberentry template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #254 from Martin Renvoize --- Created attachment 137093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137093=edit Bug 23681: (QA follow-up) Fix debarment count This patch fixes the debarment count displayed on the circulation page tabs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #253 from Martin Renvoize --- Created attachment 137092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137092=edit Bug 23681: (QA follow-up) Match default data to update The default data at install time didn't match the data added at update. This patch corrects that and by doing so it also adds back the ability to make MANUAL restriction types the default after any other type has been made default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #252 from Martin Renvoize --- Created attachment 137091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137091=edit Bug 23681: (QA follow-up) Remove spacing and add question mark This patch removes the superflous whitespace around the restriction descriptions and also adds the missing question mark into the delete question. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #251 from Martin Renvoize --- Created attachment 137090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137090=edit Bug 23681: (QA follow-up) Add patron restrictions to admin menu This patch adds the patron restrictions page to the admin menu that appears to the left on all administration pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136739|0 |1 is obsolete|| --- Comment #250 from Martin Renvoize --- Created attachment 137089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137089=edit Bug 23681: (follow-up) Mark fields at booleans Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136738|0 |1 is obsolete|| --- Comment #249 from Martin Renvoize --- Created attachment 137088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137088=edit Bug 23681: DBIC Rebuild -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136737|0 |1 is obsolete|| --- Comment #248 from Martin Renvoize --- Created attachment 137087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137087=edit Bug 23681: (QA follow-up) Proper handling of default option This patch removes the 'can_be_added_manually' flag. Only non-system restriction types can be added manually, so we exclude is_system instead of having two flags. (And we set the 'Manual' that's added at install time to default but not system). We then add proper handling for setting the default manual restriction type in the management page and set the dropdown list to use that value by default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136736|0 |1 is obsolete|| --- Comment #247 from Martin Renvoize --- Created attachment 137086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137086=edit Bug 23681: (QA follow-up) Merge update files This patch merges the three atomic update files into one and also adds a check for foreing key existance to make the update idempotent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136735|0 |1 is obsolete|| --- Comment #246 from Martin Renvoize --- Created attachment 137085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137085=edit Bug 23681: (QA follow-up) Restore customisablity of description This patch restores the customisability of description for system restriction types. Translatability is not affected as you can translate the defaults via template translation and assuming the end users leave their descriptions at the default, the translations will be picked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136734|0 |1 is obsolete|| --- Comment #245 from Martin Renvoize --- Created attachment 137084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137084=edit Bug 23681: (QA follow-up) Move preference again This patch removes the new PatronRestrictionTypes preference from the accounting area in preference to creating a new group for 'Patron restriction' related preferences in the circulation preferences tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136733|0 |1 is obsolete|| --- Comment #244 from Martin Renvoize --- Created attachment 137083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137083=edit Bug 23681: DO NOT PUSH! Schema changes To be able to delete and pass tests we need to declare koha_object[s]_class to DebarmentType.pm. Otherwise following error is raised: "Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136732|0 |1 is obsolete|| --- Comment #243 from Martin Renvoize --- Created attachment 137082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137082=edit Bug 23681: Fix QA issues This patch fixes following QA issues: - convert intaller files as .yml - change column name readonly as is_system - change column name is_system as default_value - add column can_be_added_manually (testplan for this below) - move syspref "PatronRestrictionTypes" to "Accounting > Features" tab - tweak page title - tweak tests to apply these changes Also atomicupdate files have been updated. Issues with delete and tests is fixed with adding additional schema change file. To test: 1) Add new restriction type and make it manual. 2) Navigate to patron details page. 3) Add new restriction to patron. => Only selectable restriction should be the one you just created. Also prove t/db_dependent/RestrictionTypes.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136731|0 |1 is obsolete|| --- Comment #242 from Martin Renvoize --- Created attachment 137081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137081=edit Bug 23681: (QA follow-up) Fix prefs Add the missing `.` and switch from `yes/no` to `1/0`. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136730|0 |1 is obsolete|| --- Comment #241 from Martin Renvoize --- Created attachment 137080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137080=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136729|0 |1 is obsolete|| --- Comment #240 from Martin Renvoize --- Created attachment 137079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137079=edit Bug 23681: (QA follow-up) Fix license, perlcritic & executable This patch fixes the simple issues mentioned by the QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136728|0 |1 is obsolete|| --- Comment #239 from Martin Renvoize --- Created attachment 137078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137078=edit Bug 23681: Updates for bug 26703 This patch fixes the title ordering and also replaces the breadcrumbs with the modern nav block equivilent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136727|0 |1 is obsolete|| --- Comment #238 from Martin Renvoize --- Created attachment 137077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137077=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136726|0 |1 is obsolete|| --- Comment #237 from Martin Renvoize --- Created attachment 137076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137076=edit Bug 23681: (follow-up) Fix rebase issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136725|0 |1 is obsolete|| --- Comment #236 from Martin Renvoize --- Created attachment 137075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137075=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136724|0 |1 is obsolete|| --- Comment #235 from Martin Renvoize --- Created attachment 137074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137074=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136723|0 |1 is obsolete|| --- Comment #234 from Martin Renvoize --- Created attachment 137073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137073=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136722|0 |1 is obsolete|| --- Comment #233 from Martin Renvoize --- Created attachment 137072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137072=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136721|0 |1 is obsolete|| --- Comment #232 from Martin Renvoize --- Created attachment 137071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137071=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136720|0 |1 is obsolete|| --- Comment #231 from Martin Renvoize --- Created attachment 137070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137070=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136719|0 |1 is obsolete|| --- Comment #230 from Martin Renvoize --- Created attachment 137069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137069=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136718|0 |1 is obsolete|| --- Comment #229 from Martin Renvoize --- Created attachment 137068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137068=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136717|0 |1 is obsolete|| --- Comment #228 from Martin Renvoize --- Created attachment 137067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137067=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #136716|0 |1 is obsolete|| --- Comment #227 from Martin Renvoize --- Created attachment 137066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137066=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #226 from Katrin Fischer --- (In reply to Martin Renvoize from comment #225) > (In reply to Katrin Fischer from comment #224) > > Starting QA here: > > > > 0) Tests pass. QA script complains a lot about "added and removed in the > > same patch set", we could consider some squashing. Database update is > > missing execute permission. > > I think this is a QA script mis-identification.. the file it mentions is > also mentioned in the git manip.. i.e. it no longer exists and the remaining > renamed file does have the exec bit set. I think you are right about this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #225 from Martin Renvoize --- (In reply to Katrin Fischer from comment #224) > Starting QA here: > > 0) Tests pass. QA script complains a lot about "added and removed in the > same patch set", we could consider some squashing. Database update is > missing execute permission. I think this is a QA script mis-identification.. the file it mentions is also mentioned in the git manip.. i.e. it no longer exists and the remaining renamed file does have the exec bit set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #224 from Katrin Fischer --- Starting QA here: 0) Tests pass. QA script complains a lot about "added and removed in the same patch set", we could consider some squashing. Database update is missing execute permission. 1) The new patron restrictions configuration page is missing from the Administration side menu, visible when you are on any of the admin pages. It's ok on the start page of the module. 2) The delete confirmation question is missing a question mark :) (also might want to remove the additional spaces) Are you sure you want to delete " Test " I'd also make the button just "Delete" or "Yes, delete", but that's a personal preference and I see that this was 'copied' from how deleting a patron category looks like. 3) After installing/updating with this patch, MANUAL is marked es the default. You cannot change it, until you have added a new restriction, which makes sense, as the system internal ones should not be default. But: you cannot ever change the default back to MANUAL. I think this is because system internal values are excluded, but it might raise complaints for people experimenting with the feature that want to restore previous behavior. 4) Just a comment: Love the new Patron restrictions sub heading in patron preferences :) 5) When adding a manual restriction to the patron account, the default seems to be only used when PatronRestrictionTypes is off, when it's on and the pull down shows, the default is not preselected, but the first entry is. 6) Something super odd: In the patron account in the staff interface, on the checkout tab, the Restrictions shows as (0), while on the details tab the restrictions show the correct number (2) I have added. Only the tab heading is wrong, otherwise the restrictions show ok. 7) When editing the patron record, the pull down for restriction type is empty. 8) I notice that the type itself doesn't show up in the OPAC or the note on the patron account in staff, just the comments do. This is the case with and without the patches, maybe something so consider later. Or we could imagine adding a default comment? (no blocker, just loud thinking) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Blocks||31095 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31095 [Bug 31095] Koha::Patron::Debarment should be updated to follow current Koha:: style -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #223 from Martin Renvoize --- Rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134708|0 |1 is obsolete|| --- Comment #222 from Martin Renvoize --- Created attachment 136739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136739=edit Bug 23681: (follow-up) Mark fields at booleans Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134707|0 |1 is obsolete|| --- Comment #221 from Martin Renvoize --- Created attachment 136738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136738=edit Bug 23681: DBIC Rebuild -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134706|0 |1 is obsolete|| --- Comment #220 from Martin Renvoize --- Created attachment 136737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136737=edit Bug 23681: (QA follow-up) Proper handling of default option This patch removes the 'can_be_added_manually' flag. Only non-system restriction types can be added manually, so we exclude is_system instead of having two flags. (And we set the 'Manual' that's added at install time to default but not system). We then add proper handling for setting the default manual restriction type in the management page and set the dropdown list to use that value by default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134705|0 |1 is obsolete|| --- Comment #219 from Martin Renvoize --- Created attachment 136736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136736=edit Bug 23681: (QA follow-up) Merge update files This patch merges the three atomic update files into one and also adds a check for foreing key existance to make the update idempotent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134704|0 |1 is obsolete|| --- Comment #218 from Martin Renvoize --- Created attachment 136735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136735=edit Bug 23681: (QA follow-up) Restore customisablity of description This patch restores the customisability of description for system restriction types. Translatability is not affected as you can translate the defaults via template translation and assuming the end users leave their descriptions at the default, the translations will be picked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134703|0 |1 is obsolete|| --- Comment #217 from Martin Renvoize --- Created attachment 136734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136734=edit Bug 23681: (QA follow-up) Move preference again This patch removes the new PatronRestrictionTypes preference from the accounting area in preference to creating a new group for 'Patron restriction' related preferences in the circulation preferences tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134702|0 |1 is obsolete|| --- Comment #216 from Martin Renvoize --- Created attachment 136733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136733=edit Bug 23681: DO NOT PUSH! Schema changes To be able to delete and pass tests we need to declare koha_object[s]_class to DebarmentType.pm. Otherwise following error is raised: "Can't locate object method "_new_from_dbic" via package "Koha::DebarmentType" (perhaps you forgot to load "Koha::DebarmentType"?) at /kohadevbox/koha/Koha/Object.pm line 237" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134701|0 |1 is obsolete|| --- Comment #215 from Martin Renvoize --- Created attachment 136732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136732=edit Bug 23681: Fix QA issues This patch fixes following QA issues: - convert intaller files as .yml - change column name readonly as is_system - change column name is_system as default_value - add column can_be_added_manually (testplan for this below) - move syspref "PatronRestrictionTypes" to "Accounting > Features" tab - tweak page title - tweak tests to apply these changes Also atomicupdate files have been updated. Issues with delete and tests is fixed with adding additional schema change file. To test: 1) Add new restriction type and make it manual. 2) Navigate to patron details page. 3) Add new restriction to patron. => Only selectable restriction should be the one you just created. Also prove t/db_dependent/RestrictionTypes.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134700|0 |1 is obsolete|| --- Comment #214 from Martin Renvoize --- Created attachment 136731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136731=edit Bug 23681: (QA follow-up) Fix prefs Add the missing `.` and switch from `yes/no` to `1/0`. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134699|0 |1 is obsolete|| --- Comment #213 from Martin Renvoize --- Created attachment 136730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136730=edit Bug 23681: (QA follow-up) Rename columns Renames ronly to readonly and dflt to is_system. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134698|0 |1 is obsolete|| --- Comment #212 from Martin Renvoize --- Created attachment 136729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136729=edit Bug 23681: (QA follow-up) Fix license, perlcritic & executable This patch fixes the simple issues mentioned by the QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134697|0 |1 is obsolete|| --- Comment #211 from Martin Renvoize --- Created attachment 136728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136728=edit Bug 23681: Updates for bug 26703 This patch fixes the title ordering and also replaces the breadcrumbs with the modern nav block equivilent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134696|0 |1 is obsolete|| --- Comment #210 from Martin Renvoize --- Created attachment 136727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136727=edit Bug 23681: (QA follow-up) Allow for translations This patch allows for existing translations to follow through if debarment type descriptions are left unaltered for the default types. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134694|0 |1 is obsolete|| --- Comment #209 from Martin Renvoize --- Created attachment 136726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136726=edit Bug 23681: (follow-up) Fix rebase issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134693|0 |1 is obsolete|| --- Comment #208 from Martin Renvoize --- Created attachment 136725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136725=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134692|0 |1 is obsolete|| --- Comment #207 from Martin Renvoize --- Created attachment 136724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136724=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134691|0 |1 is obsolete|| --- Comment #206 from Martin Renvoize --- Created attachment 136723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136723=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134690|0 |1 is obsolete|| --- Comment #205 from Martin Renvoize --- Created attachment 136722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136722=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134689|0 |1 is obsolete|| --- Comment #204 from Martin Renvoize --- Created attachment 136721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136721=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134688|0 |1 is obsolete|| --- Comment #203 from Martin Renvoize --- Created attachment 136720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136720=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134687|0 |1 is obsolete|| --- Comment #202 from Martin Renvoize --- Created attachment 136719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136719=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134686|0 |1 is obsolete|| --- Comment #201 from Martin Renvoize --- Created attachment 136718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136718=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134685|0 |1 is obsolete|| --- Comment #200 from Martin Renvoize --- Created attachment 136717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136717=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What|Removed |Added Attachment #134684|0 |1 is obsolete|| --- Comment #199 from Martin Renvoize --- Created attachment 136716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136716=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 23681] Patron restrictions should be user definable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
