[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Fridolin Somers changed: What|Removed |Added Blocks||34666 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34666 [Bug 34666] _Findgroupreserve is not returning title level matches from the queue for holds with no item group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Jonathan Druart changed: What|Removed |Added Blocks||34520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34520 [Bug 34520] Database update 22.06.00.078 breaks update process -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860
--- Comment #231 from Jonathan Druart ---
See bug 34155, OPAC item level holds="force" is broken
in opac-reserve.pl:
495 $biblioLoopIter{force_hold} = 1 if $opac_hold_policy eq
'F';
But we are ignoring this with the change in "24860: Add ability to select an
item group when placing a hold - OPAC"
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Owen Leonard changed: What|Removed |Added Blocks||34155 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34155 [Bug 34155] OPAC item level holds "force" option broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860
--- Comment #230 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #226)
> I think we are missing from_local_hold_group in reserve/request.tt
>
> 1581 switch (override_items[itemnumber].holdallowed) {
Bug 33052 - Add a message for from_local_hold_group override
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #229 from Kyle M Hall --- (In reply to Kyle M Hall from comment #228) > (In reply to Kyle M Hall from comment #227) > > (In reply to Jonathan Druart from comment #225) > > > `biblio_id` int(11) NOT NULL DEFAULT 0 COMMENT 'id for the bibliographic > > > record the group belongs to', > > > > > > DEFAULT 0, is this correct? > > > > As 0 cannot be used, it's harmless but you are correct and we should update > > the table schema. > > Out of scope for this bug, but the recalls table has the same issue. Bug 33053 - Tables item_groups and recalls have a biblio_id column with a default of 0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #228 from Kyle M Hall --- (In reply to Kyle M Hall from comment #227) > (In reply to Jonathan Druart from comment #225) > > `biblio_id` int(11) NOT NULL DEFAULT 0 COMMENT 'id for the bibliographic > > record the group belongs to', > > > > DEFAULT 0, is this correct? > > As 0 cannot be used, it's harmless but you are correct and we should update > the table schema. Out of scope for this bug, but the recalls table has the same issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #227 from Kyle M Hall --- (In reply to Jonathan Druart from comment #225) > `biblio_id` int(11) NOT NULL DEFAULT 0 COMMENT 'id for the bibliographic > record the group belongs to', > > DEFAULT 0, is this correct? As 0 cannot be used, it's harmless but you are correct and we should update the table schema. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860
--- Comment #226 from Jonathan Druart ---
I think we are missing from_local_hold_group in reserve/request.tt
1581 switch (override_items[itemnumber].holdallowed) {
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Caroline Cyr La Rose changed: What|Removed |Added Blocks||32803 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32803 [Bug 32803] EnableItemGroups and EnableItemGroupHolds options are wrong -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Jessie Zairo changed: What|Removed |Added Text to go in the|With this feature you can |This feature was sponsored release notes|now place holds on groups |by Arlington Public |of items. A group consists |Library. With this feature |of multiple items of the|you can now place holds on |same record, representing |groups of items. A group |for example, all items of a |consists of multiple items |specific volume. When a |of the same record, |hold for an item group is |representing for example, |placed, only items of the |all items of a specific |requested group will be |volume. When a hold for an |able to fill the hold. |item group is placed, only |The |items of the requested |feature is enabled using|group will be able to fill |the new |the hold. |EnableItemGroupHolds system |The feature is |preference. It also |enabled using the new |requires EnableItemGroups |EnableItemGroupHolds system |for managing item groups. |preference. It also ||requires EnableItemGroups ||for managing item groups. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Jessie Zairo changed: What|Removed |Added Change sponsored?|--- |Sponsored CC||jza...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs documenting |RESOLVED Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/609 Documentation||Caroline Cyr La Rose contact|| CC||caroline.cyr-la-rose@inlibr ||o.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Lucas Gass changed: What|Removed |Added Status|Pushed to master|Needs documenting CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #225 from Jonathan Druart --- `biblio_id` int(11) NOT NULL DEFAULT 0 COMMENT 'id for the bibliographic record the group belongs to', DEFAULT 0, is this correct? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Text to go in the||With this feature you can release notes||now place holds on groups ||of items. A group consists ||of multiple items of the ||same record, representing ||for example, all items of a ||specific volume. When a ||hold for an item group is ||placed, only items of the ||requested group will be ||able to fill the hold. ||The ||feature is enabled using ||the new ||EnableItemGroupHolds system ||preference. It also ||requires EnableItemGroups ||for managing item groups. Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #224 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Tomás Cohen Arazi changed: What|Removed |Added Keywords|rel_22_11_candidate |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Tomás Cohen Arazi changed: What|Removed |Added Severity|enhancement |new feature CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142974|0 |1 is obsolete|| --- Comment #223 from Katrin Fischer --- Created attachment 143011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143011=edit Bug 24860: (QA follow-up) Ask for any available item of matching group Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142973|0 |1 is obsolete|| --- Comment #222 from Katrin Fischer --- Created attachment 143010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143010=edit Bug 24860: (QA follow-up): Don't assume item group is set for all items Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142972|0 |1 is obsolete|| --- Comment #221 from Katrin Fischer --- Created attachment 143009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143009=edit Bug 24860: (QA follow-up) Show group holds on Holds to pull Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142971|0 |1 is obsolete|| --- Comment #220 from Katrin Fischer --- Created attachment 143008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143008=edit Bug 24860: (QA follow-up) Fix typo in holds queue viewer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142970|0 |1 is obsolete|| --- Comment #219 from Katrin Fischer --- Created attachment 143007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143007=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::REST::V1::Holds::add Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142969|0 |1 is obsolete|| --- Comment #218 from Katrin Fischer --- Created attachment 143006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143006=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Holds::forced_hold_level Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142968|0 |1 is obsolete|| --- Comment #217 from Katrin Fischer --- Created attachment 143005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143005=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Hold::item_group Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142967|0 |1 is obsolete|| --- Comment #216 from Katrin Fischer --- Created attachment 143004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143004=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to Reserves.pm Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142966|0 |1 is obsolete|| --- Comment #215 from Katrin Fischer --- Created attachment 143003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143003=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to HoldsQueue.pm Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142965|0 |1 is obsolete|| --- Comment #214 from Katrin Fischer --- Created attachment 143002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143002=edit Bug 24860: (QA follow-up) Terminology and translation fixes * Fixes a single to a double underscore for translation in holds.js * Fixes item_group to item group in API description * Fixes volume hold to item group hold in syspref db descrpitions Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142964|0 |1 is obsolete|| --- Comment #213 from Katrin Fischer --- Created attachment 143001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143001=edit Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142963|0 |1 is obsolete|| --- Comment #212 from Katrin Fischer --- Created attachment 143000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143000=edit Bug 24860: Update existing Schema files [DO NOT PUSH] Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142962|0 |1 is obsolete|| --- Comment #211 from Katrin Fischer --- Created attachment 142999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142999=edit Bug 24860: Add hold's item group to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142961|0 |1 is obsolete|| --- Comment #210 from Katrin Fischer --- Created attachment 142998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142998=edit Bug 24860: Skip non-matching item group holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142960|0 |1 is obsolete|| --- Comment #209 from Katrin Fischer --- Created attachment 142997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142997=edit Bug 24860: Skip non-matching item group holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142959|0 |1 is obsolete|| --- Comment #208 from Katrin Fischer --- Created attachment 142996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142996=edit Bug 24860: Add ability to select an item group when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142958|0 |1 is obsolete|| --- Comment #207 from Katrin Fischer --- Created attachment 142995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142995=edit Bug 24860: Add ability to select an item group when placing a hold Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142957|0 |1 is obsolete|| --- Comment #206 from Katrin Fischer --- Created attachment 142994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142994=edit Bug 24860: Implement reserves.item_group_id Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142956|0 |1 is obsolete|| --- Comment #205 from Katrin Fischer --- Created attachment 142993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142993=edit Bug 24860: Add new syspref EnableItemGroupHolds Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Attachment #142955|0 |1 is obsolete|| --- Comment #204 from Katrin Fischer --- Created attachment 142992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142992=edit Bug 24860: Add reserves.item_group_it This feature builds upon bug 24857 and allows placing holds that target a specific item group of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and item groups, with each item being assigned to an item group 6) Place a hold for a patron 7) Note the new selector to choose an item group in addition to record and item level holds 8) Place an item group level hold 9) Check in an item from the record that is not part of that item group 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that item group 12) Note the hold is trapped for that item 13) Place an item group level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that item group 16) Check out all the items of that item group to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #203 from Kyle M Hall --- Ah! I was testing a slightly different scenario. You are right, the last patch is no good. I've obsoleted it and now everything should be good! I'm not sure what scenario you are > But it's not true... in my test case I had 2 available items within this > group. I can retest, but I am pretty sure. I had created new items in order > to group and place a hold on them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What|Removed |Added Attachment #142974|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What|Removed |Added Attachment #142975|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What|Removed |Added Attachment #142974|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860
--- Comment #202 from Katrin Fischer ---
(In reply to Kyle M Hall from comment #201)
> (In reply to Katrin Fischer from comment #179)
> > I am sorry Kyle, the latest follow-up fixed the error, but the new text in
> > pendingreserves never displays. I have tried to figure out what's going on
> > there, but got stuck on this line:
> >
> > +if ( $res_info->item_group ) {
> > + $hold_info->{barcodes} = [ uniq map { defined $_->barcode &&
> > $_->item_group && ( $_->item_group->id == $res_info->item_group_id ) ?
> > $_->barcode : () } @$items ];
> > +}
> > +
> >
> > I believe that [% IF ( hold_info.barcodes.size ) %] is not set for a hold
> > group hold.
>
> Yes, the problem here is that there are not items with the selected hold
> group currently available. We have two choices where, either we hide that
> hold until there is an item from that item group available, or we just
> display an "Any item from item group $item_group" message.
>
> "Bug 24860: (QA follow-up) Don't show holds where a matching item group item
> is not available" does the former, "Bug 24860: (QA follow-up) Ask for any
> available item of matching group" does the latter. Please choose which
> behavior you would prefer and deprecate the other patch!
But it's not true... in my test case I had 2 available items within this group.
I can retest, but I am pretty sure. I had created new items in order to group
and place a hold on them.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860
--- Comment #201 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #179)
> I am sorry Kyle, the latest follow-up fixed the error, but the new text in
> pendingreserves never displays. I have tried to figure out what's going on
> there, but got stuck on this line:
>
> +if ( $res_info->item_group ) {
> + $hold_info->{barcodes} = [ uniq map { defined $_->barcode &&
> $_->item_group && ( $_->item_group->id == $res_info->item_group_id ) ?
> $_->barcode : () } @$items ];
> +}
> +
>
> I believe that [% IF ( hold_info.barcodes.size ) %] is not set for a hold
> group hold.
Yes, the problem here is that there are not items with the selected hold group
currently available. We have two choices where, either we hide that hold until
there is an item from that item group available, or we just display an "Any
item from item group $item_group" message.
"Bug 24860: (QA follow-up) Don't show holds where a matching item group item is
not available" does the former, "Bug 24860: (QA follow-up) Ask for any
available item of matching group" does the latter. Please choose which behavior
you would prefer and deprecate the other patch!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #200 from Kyle M Hall --- Created attachment 142975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142975=edit Bug 24860: (QA follow-up) Don't show holds where a matching item group item is not available -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #199 from Kyle M Hall --- Created attachment 142974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142974=edit Bug 24860: (QA follow-up) Ask for any available item of matching group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #198 from Kyle M Hall --- Created attachment 142973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142973=edit Bug 24860: (QA follow-up): Don't assume item group is set for all items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #197 from Kyle M Hall --- Created attachment 142972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142972=edit Bug 24860: (QA follow-up) Show group holds on Holds to pull -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #196 from Kyle M Hall --- Created attachment 142971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142971=edit Bug 24860: (QA follow-up) Fix typo in holds queue viewer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #195 from Kyle M Hall --- Created attachment 142970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142970=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::REST::V1::Holds::add -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #194 from Kyle M Hall --- Created attachment 142969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142969=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Holds::forced_hold_level -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #193 from Kyle M Hall --- Created attachment 142968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142968=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Hold::item_group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #192 from Kyle M Hall --- Created attachment 142967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142967=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to Reserves.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #191 from Kyle M Hall --- Created attachment 142966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142966=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to HoldsQueue.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #190 from Kyle M Hall --- Created attachment 142965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142965=edit Bug 24860: (QA follow-up) Terminology and translation fixes * Fixes a single to a double underscore for translation in holds.js * Fixes item_group to item group in API description * Fixes volume hold to item group hold in syspref db descrpitions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #189 from Kyle M Hall --- Created attachment 142964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142964=edit Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #188 from Kyle M Hall --- Created attachment 142963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142963=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #187 from Kyle M Hall --- Created attachment 142962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142962=edit Bug 24860: Add hold's item group to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #186 from Kyle M Hall --- Created attachment 142961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142961=edit Bug 24860: Skip non-matching item group holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #185 from Kyle M Hall --- Created attachment 142960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142960=edit Bug 24860: Skip non-matching item group holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #184 from Kyle M Hall --- Created attachment 142959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142959=edit Bug 24860: Add ability to select an item group when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #183 from Kyle M Hall --- Created attachment 142958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142958=edit Bug 24860: Add ability to select an item group when placing a hold Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #182 from Kyle M Hall --- Created attachment 142957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142957=edit Bug 24860: Implement reserves.item_group_id Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #181 from Kyle M Hall --- Created attachment 142956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142956=edit Bug 24860: Add new syspref EnableItemGroupHolds Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What|Removed |Added Attachment #142413|0 |1 is obsolete|| Attachment #142414|0 |1 is obsolete|| Attachment #142415|0 |1 is obsolete|| Attachment #142416|0 |1 is obsolete|| Attachment #142417|0 |1 is obsolete|| Attachment #142418|0 |1 is obsolete|| Attachment #142419|0 |1 is obsolete|| Attachment #142420|0 |1 is obsolete|| Attachment #142421|0 |1 is obsolete|| Attachment #142422|0 |1 is obsolete|| Attachment #142423|0 |1 is obsolete|| Attachment #142424|0 |1 is obsolete|| Attachment #142425|0 |1 is obsolete|| Attachment #142426|0 |1 is obsolete|| Attachment #142427|0 |1 is obsolete|| Attachment #142428|0 |1 is obsolete|| Attachment #142429|0 |1 is obsolete|| Attachment #142430|0 |1 is obsolete|| Attachment #142827|0 |1 is obsolete|| --- Comment #180 from Kyle M Hall --- Created attachment 142955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142955=edit Bug 24860: Add reserves.item_group_it This feature builds upon bug 24857 and allows placing holds that target a specific item group of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and item groups, with each item being assigned to an item group 6) Place a hold for a patron 7) Note the new selector to choose an item group in addition to record and item level holds 8) Place an item group level hold 9) Check in an item from the record that is not part of that item group 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that item group 12) Note the hold is trapped for that item 13) Place an item group level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that item group 16) Check out all the items of that item group to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #179 from Katrin Fischer ---
I am sorry Kyle, the latest follow-up fixed the error, but the new text in
pendingreserves never displays. I have tried to figure out what's going on
there, but got stuck on this line:
+if ( $res_info->item_group ) {
+ $hold_info->{barcodes} = [ uniq map { defined $_->barcode &&
$_->item_group && ( $_->item_group->id == $res_info->item_group_id ) ?
$_->barcode : () } @$items ];
+}
+
I believe that [% IF ( hold_info.barcodes.size ) %] is not set for a hold group
hold.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #178 from Katrin Fischer --- Back here again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #177 from Kyle M Hall --- Created attachment 142827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142827=edit Bug 24860: (QA follow-up): Don't assume item group is set for all items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860
--- Comment #176 from Katrin Fischer ---
(In reply to Katrin Fischer from comment #175)
> Sorry Kyle, I tried to understand what's going wrong here, but failed:
>
> When opening 'Holds to pull':
>
> Can't call method "id" on an undefined value at
> /kohadevbox/koha/circ/pendingreserves.pl line 288
>
> 287: if ( $res_info->item_group ) {
> 288:$hold_info->{barcodes} = [ uniq map { defined $_->barcode &&
> $_->item_group->id == $res_info->item_group_id ? $_->barcode : () } @$items
> ];
> 289: }
>
> If you can fix quickly, I'll retest.
*ping*?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #175 from Katrin Fischer ---
Sorry Kyle, I tried to understand what's going wrong here, but failed:
When opening 'Holds to pull':
Can't call method "id" on an undefined value at
/kohadevbox/koha/circ/pendingreserves.pl line 288
287: if ( $res_info->item_group ) {
288:$hold_info->{barcodes} = [ uniq map { defined $_->barcode &&
$_->item_group->id == $res_info->item_group_id ? $_->barcode : () } @$items ];
289: }
If you can fix quickly, I'll retest.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #174 from Katrin Fischer --- Back here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #173 from Kyle M Hall --- > To summarize: > * Verify/make sure tests clean up their created data Fixed on Bug 31920 > * Remove _ from message on holds queue page Fixed with followup! > * Adapt message when only a item group hold exists on holds to pull Also fixed with a followup! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #172 from Kyle M Hall --- Created attachment 142430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142430=edit Bug 24860: (QA follow-up) Show group holds on Holds to pull -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #171 from Kyle M Hall --- Created attachment 142429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142429=edit Bug 24860: (QA follow-up) Fix typo in holds queue viewer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #170 from Kyle M Hall --- Created attachment 142428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142428=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::REST::V1::Holds::add -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #169 from Kyle M Hall --- Created attachment 142427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142427=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Holds::forced_hold_level -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #168 from Kyle M Hall --- Created attachment 142426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142426=edit Bug 24860: (QA follow-up) Add unit tests to cover Koha::Hold::item_group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #167 from Kyle M Hall --- Created attachment 142425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142425=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to Reserves.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #166 from Kyle M Hall --- Created attachment 142424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142424=edit Bug 24860: (QA follow-up) Add unit tests to cover changes to HoldsQueue.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #165 from Kyle M Hall --- Created attachment 142423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142423=edit Bug 24860: (QA follow-up) Terminology and translation fixes * Fixes a single to a double underscore for translation in holds.js * Fixes item_group to item group in API description * Fixes volume hold to item group hold in syspref db descrpitions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #164 from Kyle M Hall --- Created attachment 142422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142422=edit Bug 24860: (QA follow-up) Fix number of tests in t/db_dependent/Koha/Holds.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #163 from Kyle M Hall --- Created attachment 142421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142421=edit Bug 24860: Update existing Schema files [DO NOT PUSH] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #162 from Kyle M Hall --- Created attachment 142420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142420=edit Bug 24860: Add hold's item group to holds table on circulation.pl and moremember.pl Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #161 from Kyle M Hall --- Created attachment 142419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142419=edit Bug 24860: Skip non-matching item group holds in HoldsQueue Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #160 from Kyle M Hall --- Created attachment 142418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142418=edit Bug 24860: Skip non-matching item group holds in CheckReserves Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #159 from Kyle M Hall --- Created attachment 142417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142417=edit Bug 24860: Add ability to select an item group when placing a hold - OPAC Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #158 from Kyle M Hall --- Created attachment 142416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142416=edit Bug 24860: Add ability to select an item group when placing a hold Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #157 from Kyle M Hall --- Created attachment 142415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142415=edit Bug 24860: Implement reserves.item_group_id Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #156 from Kyle M Hall --- Created attachment 142414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142414=edit Bug 24860: Add new syspref EnableItemGroupHolds Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Kyle M Hall changed: What|Removed |Added Attachment #141735|0 |1 is obsolete|| Attachment #141736|0 |1 is obsolete|| Attachment #141737|0 |1 is obsolete|| Attachment #141738|0 |1 is obsolete|| Attachment #141739|0 |1 is obsolete|| Attachment #141740|0 |1 is obsolete|| Attachment #141741|0 |1 is obsolete|| Attachment #141742|0 |1 is obsolete|| Attachment #141743|0 |1 is obsolete|| Attachment #141744|0 |1 is obsolete|| Attachment #141745|0 |1 is obsolete|| Attachment #141746|0 |1 is obsolete|| Attachment #141747|0 |1 is obsolete|| Attachment #141748|0 |1 is obsolete|| Attachment #141749|0 |1 is obsolete|| Attachment #141750|0 |1 is obsolete|| --- Comment #155 from Kyle M Hall --- Created attachment 142413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142413=edit Bug 24860: Add reserves.item_group_it This feature builds upon bug 24857 and allows placing holds that target a specific item group of a record. It is patterned after the feature that allows limiting hold selection by itemtype ( AllowHoldItemTypeSelection ). Test Plan: 1) Apply bug 24857 and this bug's patches 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the sysprefs EnableVolumes and EnableVolumeHolds 5) Create a record, items and item groups, with each item being assigned to an item group 6) Place a hold for a patron 7) Note the new selector to choose an item group in addition to record and item level holds 8) Place an item group level hold 9) Check in an item from the record that is not part of that item group 10) Note the hold is not trapped for that item 11) Check in an item from the record that *is* part of that item group 12) Note the hold is trapped for that item 13) Place an item group level hold for another item 14) Run the holds queue builder 15) Note the holds queue targets only items from that item group 16) Check out all the items of that item group to other patrosn 17) Re-run the holds queue builder 18) Note the holds queue no longer has a line for that hold, as all items that could fill that hold are now unavailable Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Rebecca Coert -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Keywords||rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #154 from Katrin Fischer --- 1) All the new and old tests pass. But: I did a reset_all to have a clean starting page before applying these patches. And my branches are all mangled after running the tests: I end up with 36 branches on the sample database, a lot of those generated ones like: brW5iS. There are also a ton of generated patrons... I am not completely sure it's the new tests here, but could you please check your clean-up? 3) Holds queue is looking good now: a1 or any item from item_group A Just please remove the _ :) 2) Pending holds / Holds to pull > I don't think Holds to pull is the tool a library should be using if they > are using item group holds. This same is true for the holds itemtype filter, > which has been in Koha since 16.05. I'm finding the holds to pull interface > doesn't display data well. For instance, if I place one item level hold, and > one biblio level hold for the same record, holds to pull doesn't really > indicate that. If you can can tell me what you'd like to see, I'll see what > I can do! I don't think we can argue that, unless we hid the report once the item group holds are activated... and that might create quite some complaints. I know single branch libraries like to use the report, also the less busy ones. Maybe it would be worth adding a note to the system preference? "Might not go well with..." or so? In general the page needs work, I agree with you on that! I did some more testing: a) If there is a record level hold only: Only 311418 b) If there is an item level hold only: 305097 or any available. c) If there is a group level hold only: 305097 or any available. For a start, could we catch the third case and have a correct message display? Similar to the one on holds queue? I'd be ok with that as a solution for this patch set. For the future 2 ideas (just to get your opinion, will file later): * If there are different types of holds we could display this as a note: "Different types of holds, please check holds page"? * We could repeat the information for every hold, maybe deduplicated. At the moment it looks like we only get the info for the first hold placed. Maye something like: * Only 311418 (1 hold) * 305097 or any available (2 holds) To summarize: * Verify/make sure tests clean up their created data * Remove _ from message on holds queue page * Adapt message when only a item group hold exists on holds to pull OK? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 Katrin Fischer changed: What|Removed |Added Blocks||31832 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31832 [Bug 31832] Add reference for EnableItemGroups to EnableItemGroupHolds system preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24860] Add ability to place item group level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24860 --- Comment #153 from Katrin Fischer --- Having another look here... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
