[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Katrin Fischer  changed:

   What|Removed |Added

 CC||anthony.laque...@ccsr.qc.ca

--- Comment #47 from Katrin Fischer  ---
*** Bug 8016 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||21584


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584
[Bug 21584] Wrong offset type for Lost Item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to Master|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696
Bug 2696 depends on bug 18790, which changed state.

Bug 18790 Summary: Add ability to void payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Charles Quain  changed:

   What|Removed |Added

 CC||c...@interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20841


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20841
[Bug 20841] Barcode and description are needed in payment details
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||20840


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840
[Bug 20840] Internal Server Error when clicking on "Details" button
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_18_05_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #46 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #45 from Kyle M Hall  ---
Created attachment 74817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74817=edit
Bug 2696 [QA Followup]: Add more test, move to subtest

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #44 from Jonathan Druart  
---
Kyle, please move the tests to a separate subtest and also test the "return
undef" parts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #43 from Kyle M Hall  ---
I have fixed everything except:

--
@@ +42,5 @@
> +
> +sub debit {
> +my ( $self ) = @_;
> +my $debit_rs = $self->_result->debit;
> +return unless $debit_rs;

I do not think we should "return unless" here, we do not do that for other
methods. Is there a good reason?
--

which I believe to be incorrect. Please refer to Koha::Item::checkout for
precedence. What you write makes sense *if* the foreign key *must* exist ( such
as the case of items.biblionumber ). However, in this case, a checkout may not
exist for this item ). Without that line, you would return a perfectly value
but empty Koha::Checkout object. In that case code such as "if ( my $c =
$item->checkout )" would by true instead of false like everyone would expect it
to be. In fact, $item->checkout would *always* return true since the you'd get
a Koha::Checkout object every time, valid or not.


(In reply to Jonathan Druart from comment #39)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #42 from Kyle M Hall  ---
Created attachment 74765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74765=edit
Bug 2696 [QA Followup]: Fix POD, results sorting, permissions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #41 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #40)
> It would also be great to use the new .inc in other parts of the code where
> they are displayed, to avoid duplicated code (on a follow-up bug report?)

Excellent idea. I'll file the bug report!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_18_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #40 from Jonathan Druart  
---
It would also be great to use the new .inc in other parts of the code where
they are displayed, to avoid duplicated code (on a follow-up bug report?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #39 from Jonathan Druart  
---
Comment on attachment 74672
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74672
Bug 2696: Fine payments should show what was paid for

Review of attachment 74672:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=2696=74672)
-

::: Koha/Account/Offset.pm
@@ +20,4 @@
>  use Carp;
>  
>  use Koha::Database;
> +use Koha::Account::Line;

Should be Koha::Account::Lines

@@ +39,5 @@
> +=head3 debit
> +
> +=cut
> +
> +sub debit {

POD missing.

@@ +42,5 @@
> +
> +sub debit {
> +my ( $self ) = @_;
> +my $debit_rs = $self->_result->debit;
> +return unless $debit_rs;

I do not think we should "return unless" here, we do not do that for other
methods. Is there a good reason?

@@ +50,5 @@
> +=head3 credit
> +
> +=cut
> +
> +sub credit {

Same as above

::: members/accountline-details.pl
@@ +34,5 @@
> +query   => $input,
> +type=> "intranet",
> +authnotrequired => 0,
> +flagsrequired   => {
> +borrowers => 1,

should be edit_borrowers.

@@ +48,5 @@
> +if ($accountline) {
> +my $type = $accountline->amount < 0 ? 'credit' : 'debit';
> +my $column = $type eq 'credit' ? 'credit_id' : 'debit_id';
> +
> +my @account_offsets = Koha::Account::Offsets->search( { $column => 
> $accountlines_id } );

Would be better to call in scalar context and make the order by created_on
here, not template-side.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Katrin Fischer  changed:

   What|Removed |Added

Summary|Fine Payments Should Show   |Fine payments should show
   |What Was Paid For   |what was paid for
  Text to go in the||This adds a details view
  release notes||for every fine and payment
   ||in a patron account that
   ||will show detailed
   ||information about the
   ||payments made forward a
   ||fine and how a payment has
   ||been split up to pay
   ||towards several fines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72088|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72263|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #36 from Katrin Fischer  ---
Created attachment 74672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74672=edit
Bug 2696: Fine payments should show what was paid for

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

Signed-off-by: Lee Jamison 
Running updatedatabase.pl after patch application makes dependencies
happy. Passes QA Tools and works as intended.

Rebased (2017-12-21): Alex Arnaud 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #38 from Katrin Fischer  ---
Created attachment 74674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74674=edit
Bug 2696: (QA follow-up) Several fixes to template variables

- Fix link to patron account in breadcrumbs
- Fix includes for accounttype.inc to display type correctly
  - in Details for fee
  - in Payments list
- Fix use CGI qw ( -utf8 );
- Remove  from within a string for better translation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #37 from Katrin Fischer  ---
Created attachment 74673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74673=edit
Bug 2696: (QA follow-up) - Remove use of GetMember

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #35 from Katrin Fischer  ---
Comment on attachment 72088
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72088
Bug 2696 - Fine Payments Should Show What Was Paid For

Review of attachment 72088:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=2696=72088)
-

Hi all,

looking at how long we've wanted for this... wow. While testing I discovered
several issues with the template variables that I am fixing in a QA follow-up.

::: Koha/Account/Offset.pm
@@ +37,5 @@
>  =cut
>  
> +=head3 debit
> +
> +=cut

1) Please add POD to debit and credit! Not treating this as a blocker, but
please provide a follow up.

::: koha-tmpl/intranet-tmpl/prog/en/includes/account_offset_type.inc
@@ +1,2 @@
> +[% SWITCH account_offset.type %]
> +[% CASE 'Payment' %]Payment

2) I've checked and the strings from account_offset_type.inc and
accounttype.inc are picked up by translation scripts. Just a note, nothing to
see here!

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt
@@ +84,5 @@
> +Amount
> +Amount outstanding
> +Type
> +Note
> +Transactinglibrarian id

3) This is a translation issue, because it leaves you with "Transacting" and
"library id" separately. We need to achieve a nice layout otherwise. I will
remove the  in a QA follow-up.

::: members/accountline-details.pl
@@ +18,5 @@
> +# along with Koha; if not, see .
> +
> +use Modern::Perl;
> +
> +use CGI;

4) Should be: use CGI qw ( -utf8 );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #34 from Katrin Fischer  ---
QA script and tests pass, will continue poking at this for a bit longer :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #33 from Katrin Fischer  ---
Can't wait to have this, but currently blocked by FAILED QA on bug 18790 -
Kyle, can you put this in our queue again once the other is in? Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #32 from Kyle M Hall  ---
Created attachment 72263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72263=edit
Bug 2696 [QA Followup] - Remove use of GetMember

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #31 from Alex Arnaud  ---
Kyle, GetMember is still in use in members/accountline-details.pl. Also this
script is not executable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Alex Arnaud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #30 from Alex Arnaud  ---
Kyle, it does not apply, can you rebase please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #72024|0   |1
is obsolete||

--- Comment #29 from Kyle M Hall  ---
Created attachment 72088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72088=edit
Bug 2696 - Fine Payments Should Show What Was Paid For

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

Signed-off-by: Lee Jamison 
Running updatedatabase.pl after patch application makes dependencies
happy. Passes QA Tools and works as intended.

Rebased (2017-12-21): Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #28 from Kyle M Hall  ---
(In reply to Alex Arnaud from comment #27)
> Kyle,
> 
> Haven't you forgotten to add accountline-details.pl, accountline-details.tt
> and accounttype.inc in the last patch?

Wow, no idea what happened there. Thanks for letting me know!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #27 from Alex Arnaud  ---
Kyle,

Haven't you forgotten to add accountline-details.pl, accountline-details.tt and
accounttype.inc in the last patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Claudio  changed:

   What|Removed |Added

 CC||cost...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #26 from Kyle M Hall  ---
(In reply to Alex Arnaud from comment #24)
> Quick test gave me:
>  
>  - Error on accountline-details.pl:
>  "GetMember" is not exported by the C4::Members module
>  Can't continue after import errors at
> /home/koha/src/members/accountline-details.pl line 26.
> You could use Koha::Patron->find now.
> 
>   - On the same script after fixing the first error: 
> Template process failed: undef error - The method payment_type is not
> covered by tests!
> 
> Also, i've rebased the patch: new account type ('PF', Processing fee),

Removed call to GetMember. Don't forget to update the dbix class files before
testing! That would explain your second error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #70031|0   |1
is obsolete||

--- Comment #25 from Kyle M Hall  ---
Created attachment 72024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72024=edit
Bug 2696 - Fine Payments Should Show What Was Paid For

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

Signed-off-by: Lee Jamison 
Running updatedatabase.pl after patch application makes dependencies
happy. Passes QA Tools and works as intended.

Rebased (2017-12-21): Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #24 from Alex Arnaud  ---
Quick test gave me:

 - Error on accountline-details.pl:
 "GetMember" is not exported by the C4::Members module
 Can't continue after import errors at
/home/koha/src/members/accountline-details.pl line 26.
You could use Koha::Patron->find now.

  - On the same script after fixing the first error: 
Template process failed: undef error - The method payment_type is not
covered by tests!

Also, i've rebased the patch: new account type ('PF', Processing fee),

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #67479|0   |1
is obsolete||

--- Comment #23 from Alex Arnaud  ---
Created attachment 70031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70031=edit
[PATCH] Bug 2696 - Fine Payments Should Show What Was Paid For

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

Signed-off-by: Lee Jamison 
Running updatedatabase.pl after patch application makes dependencies
happy. Passes QA Tools and works as intended.

Rebased (2017-12-21): Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Alex Arnaud  changed:

   What|Removed |Added

 QA Contact|koha-b...@lists.koha-commun |alex.arn...@biblibre.com
   |ity.org |
 CC||alex.arn...@biblibre.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #64350|0   |1
is obsolete||

--- Comment #22 from Kyle M Hall  ---
Created attachment 67479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67479=edit
Bug 2696 - Fine Payments Should Show What Was Paid For

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

Signed-off-by: Lee Jamison 
Running updatedatabase.pl after patch application makes dependencies
happy. Passes QA Tools and works as intended.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Lee Jamison  changed:

   What|Removed |Added

  Attachment #64346|0   |1
is obsolete||

--- Comment #21 from Lee Jamison  ---
Created attachment 64350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64350=edit
[SIGNED-OFF] Bug 2696 - Fine Payments Should Show What Was Paid For

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

Signed-off-by: Lee Jamison 
Running updatedatabase.pl after patch application makes dependencies
happy. Passes QA Tools and works as intended.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Lee Jamison  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Lee Jamison  changed:

   What|Removed |Added

  Attachment #64345|0   |1
is obsolete||

--- Comment #20 from Lee Jamison  ---
Created attachment 64346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64346=edit
[SIGNED-OFF]Bug 2696: Payments Shows What Paid For

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

Signed-off-by: Lee Jamison 
Running updatedatabase.pl after patch application makes dependencies
happy. Passes QA Tools and works as intended.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Jonathan Druart  changed:

   What|Removed |Added

   Severity|critical|major

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #64293|0   |1
is obsolete||
  Attachment #64342|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart  
---
Lowering severity, it has been set as critical 7 years ago.

--- Comment #18 from Kyle M Hall  ---
Created attachment 64342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64342=edit
Bug 2696 - Fine Payments Should Show What Was Paid For

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

--- Comment #19 from Kyle M Hall  ---
Created attachment 64345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64345=edit
Bug 2696 - Fine Payments Should Show What Was Paid For

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Lee Jamison  changed:

   What|Removed |Added

 CC||ldjami...@marywood.edu

--- Comment #16 from Lee Jamison  ---
The patch and its dependencies applied cleanly and there were no problems when
running updatedatabase.pl. I added/paid fines on accounts but when I click on
the "Details" button of boraccount.pl tailing plack throws the following error
message:

Can't locate object method "search" via package "Koha::Account::Offsets"
(perhaps you forgot to load "Koha::Account::Offsets"?) at
/home/vagrant/kohaclone/members/accountline-details.pl line 52.

Line 52 of accountline-details.pl consists of the following code:

my @account_offsets = Koha::Account::Offsets->search( { $column =>
$accountlines_id } );

The only methods contained in Offsets.pm that are showing for me are:

sub _type {
return 'AccountOffset';
}

sub object_class {
return 'Koha::Account::Offset';
}

Let me know if there appears to be a problem with my test and I will try it
again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #15 from Jonathan Druart  
---
Tests are missing

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||18805


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805
[Bug 18805] Add ability to use up account credits
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #64287|0   |1
is obsolete||

--- Comment #14 from Kyle M Hall  ---
Created attachment 64293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64293=edit
Bug 2696 - Fine Payments Should Show What Was Paid For

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

   Attachment #9583|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

   Attachment #3069|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #800 is|0   |1
   obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #13 from Kyle M Hall  ---
Created attachment 64287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64287=edit
Bug 2696 - Fine Payments Should Show What Was Paid For

Test Plan:
1) Apply this patch and its' dependencies
2) Create and pay some various fees and fines
3) View the payments for fees, and fees paid by payments by
   using the new 'Details' button available on boraccount.pl

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

 Depends on|14826   |18790


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
[Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790
[Bug 18790] Add ability to void payments
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com,
   ||josef.mora...@gmail.com,
   ||r...@rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15273

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #12 from Katrin Fischer  ---
*** Bug 10167 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #11 from Chetan Panchal  ---
Thanks Kartin, 

I understood the problem.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Chetan Panchal  changed:

   What|Removed |Added

 CC||chetanpanchal...@hotmail.co
   ||m

--- Comment #9 from Chetan Panchal  ---
Hi Everyone,

I am new in this. I want to solve this bug. Please suggest me what is the
actual requirement. Is it that when we pay fine in admin then it shows only
payment thanks but you need that it should show item details also (i.e - Item
Barcode or Item Title).


Please help me.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #10 from Katrin Fischer  ---
Hi Chetan, this is not easy to solve, as one payment can be for multiple fines
and can only include partial payments. This is why Kyle and others have been
working on a rewrite of the accounts system.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall  changed:

   What|Removed |Added

 Depends on|6427|14826
 CC||kyle.m.h...@gmail.com


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427
[Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
[Bug 14826] Resurrect account offsets table
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
It's still an open bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

--- Comment #7 from Indranil Das Gupta indr...@gmail.com ---
(In reply to Kyle M Hall from comment #6)
 (In reply to Katrin Fischer from comment #5)
  Something to look out for when testing the accounts rewrite :)
 
 I can tell you that the new accounting system tracks and stores every fee
 paid for by every payment. If a payment is made that paid 3 fines, it
 creates three account_offset rows that link the payment to each of those
 fines, along with the amount paid on each!
 
 When you look at patrons fines, you can even drill down to see the entire
 history for each fee, and for each payment.

So, it this still an open bug or can this be closed?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Depends on||6427

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Katrin Fischer from comment #5)
 Something to look out for when testing the accounts rewrite :)

I can tell you that the new accounting system tracks and stores every fee paid
for by every payment. If a payment is made that paid 3 fines, it creates three
account_offset rows that link the payment to each of those fines, along with
the amount paid on each!

When you look at patrons fines, you can even drill down to see the entire
history for each fee, and for each payment.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6427
   Assignee|koha.sek...@gmail.com   |koha-b...@lists.koha-commun
   ||ity.org

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Something to look out for when testing the accounts rewrite :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #4 from Nicole C. Engard neng...@gmail.com ---
Created attachment 9583
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9583action=edit
staff with payment description

It looks like in some cases it is now showing what was paid for - when you pay
for a specific line item.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron ve...@veron.ch ---
At the moment the implementation is as follows (Acounts.pm line 65 ff and other
places):

--Snip
Amounts owed are paid off oldest first. That is, if the patron has a
$1 fine from Feb. 1, another $1 fine from Mar. 1, and makes a payment
of $1.50, then the oldest fine will be paid off in full, and $0.50
will be credited to the next one.

(...)

# FIXME - I'm not at all sure about the above, because I don't
# understand what the acct* tables in the Koha database are for.

--End Snip 

I tried to understand what happens in the code, and I came to the conclusion
that the most important thing is a missing primary key in the table
accountlines.

This key could be transported through the chain of forms and involved code
files to match payments with the fines the payments are made for.

I a primary key in the table accountlines could be the basis to solve other
bugs as well:

- Bug 7531 - Reversing partial payments is buggy
- (?) Bug 6413 - Notes in Fines doing wonky things
- (?) Bug 2598 - Pay Fines allows payment against accruing fine.
- (?) Bug 7205 - can't reverse manual credits 
- (?) Bug 7565 - Fee/fines receipt for printing
- (?) Bug 6273 - SIP2 Fee Paid and Fee Paid Response support
- Bug 3498 - Allow partial fine payments
- Bug 2169 - Paying only partial fines (Duplicate of 3498)

Maybe already addressed by: Bug 6427 - Rewrite of the accounts system ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

--- Comment #3 from Marc Véron ve...@veron.ch ---
Oh, I see that the primary key is already addressed in 
Bug 7671 - add a real primary key accountlinesid in accountlines.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 AssignedTo|gmcha...@gmail.com  |ian.walls@bywatersolutions.
   ||com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/