[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Owen Leonard changed: What|Removed |Added Blocks||36909 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36909 [Bug 36909] Eliminate duplicate ID in cookie consent markup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Aude Charillon changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #195 from Aude Charillon --- System preferences, HTML customizations and OPAC view added to the Koha manual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Aude Charillon changed: What|Removed |Added Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/862 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Aude Charillon changed: What|Removed |Added Documentation||Aude Charillon contact|| CC||aude.charillon@ptfs-europe. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Blocks||36316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36316 [Bug 36316] CookieConsent should not display in Z39.50/SRU window -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #194 from Martin Renvoize --- There's a whole set of follow-up bugs dealt with 3 months ago that should really have been in the first point release.. why is it taking so long to work through QA queues :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What|Removed |Added Text to go in the|This new features adds |This new features adds release notes|proper handling of tracking |proper handling of tracking |cookies into Koha. |cookies into Koha. | | |An |An |administrator can now |administrator can now |enable the option for end |enable the option for end |users to accept or deny |users to accept or deny |non-essential cookies being |non-essential cookies being |stored in their browser |stored in their browser |using the new system|using the new system |preference `CookieConsent`. |preference `CookieConsent`. | | |Once enabled, the |Once enabled, the |administrator should add|administrator should add |their non-essential cookie |their non-essential cookie |code into |code into |`CookieConsentedJS` as |`CookieConsentedJS` as |aposed to `OPACUserJS` and |opposed to `OPACUserJS` and |`IntranetUserJS`. |`IntranetUserJS`. || ||This ||will enable a cookie banner ||to appear at the bottom of ||the screen with options to ||allow all, allow essential ||and view more information. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What|Removed |Added Text to go in the||This new features adds release notes||proper handling of tracking ||cookies into Koha. || ||An ||administrator can now ||enable the option for end ||users to accept or deny ||non-essential cookies being ||stored in their browser ||using the new system ||preference `CookieConsent`. || ||Once enabled, the ||administrator should add ||their non-essential cookie ||code into ||`CookieConsentedJS` as ||aposed to `OPACUserJS` and ||`IntranetUserJS`. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What|Removed |Added Blocks|34792 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792 [Bug 34792] CookieConsentBar content feels mis-aligned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|Needs documenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #193 from Fridolin Somers --- Large enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What|Removed |Added Blocks||34793 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 [Bug 34793] We should ship default 'CookieConsentPopup' data that describes our required cookies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #192 from Martin Renvoize --- That same modal is also used for the 'Your cookies' button when you've accepted cookies but not logged in yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #191 from Martin Renvoize --- I don't see space issues myself.. could you drop a screenshot in here Marcel? Regards switching away from the modal.. it would mean sharing less code in the end case as the modal is used as the 'More information' dialogue when clicked on in the banner. I do think there aught to be some default content in the modal however.. I was surprised that we don't list the required cookies and what they do at all.. only the extra tracking cookies an administrator may be adding. I'm not sure how you could tie it all to one save button though.. the options in the modal are more voluminous (Accept all cookies, Accept essential cookies only, Accept selected non-essential cookies, Cancel). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What|Removed |Added Blocks||34792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792 [Bug 34792] CookieConsentBar content feels mis-aligned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What|Removed |Added Blocks||34791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34791 [Bug 34791] CookieConsent preference should hint that there's HTML content blocks available for customisation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31503 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #190 from Marcel de Rooy --- Noticing that the combination of GDPR consent and cookie consent looks a bit weird on the opac-user consents tab. The first one is with radio buttons. The second cones directly under it (needs spacing) and is a popup where I can only click Accept. On bug 31503 I added additional consent types. The idea is that they share the same Save button. (Working with a description text, and two radio buttons. And showing the consent date from the patron consent table.) Could we rework this cookie consent somehow in the same line of thought? As a side note, 31503 is a retry of a development that stranded in QA last year because of opposition to the use of Authorised values.. This approach uses plugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Marcel de Rooy changed: What|Removed |Added Keywords||release-notes-needed --- Comment #189 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #188) > Pushed to master for 23.11. > > Nice work everyone, thanks! Great ! Add a pointer for usage in the release notes ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #188 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #187 from Matt Blenkinsop --- Thanks for persevering on this one Cait! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #186 from Katrin Fischer --- Ok, I think this all works now. I am really glad we found the encoding issue last round of testing, that would have bitten us badly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #185 from Katrin Fischer --- Created attachment 154276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154276=edit Bug 27378: (QA follow-up) Tidy admin/preferences.pl Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Attachment #154093|0 |1 is obsolete|| --- Comment #184 from Katrin Fischer --- Created attachment 154275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154275=edit Bug 27378: (QA follow-up) Fix tests and character encoding This patch fixes an encoding issue when using diacritics. It also fixes a failing test, corrects the format of the "Cancel" links in the modal and perltidy has been used on all relevant files Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Attachment #154025|0 |1 is obsolete|| --- Comment #183 from Katrin Fischer --- Created attachment 154274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154274=edit Bug 27378: (QA follow-up) Add filtering for OPAC only and staff only cookies This patch fixes an issue where cookies selected as OPAC only would still show in the staff client and vise versa. The cookies are now filtered and only the correct cookies will be used in the OPAC and staff client Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Attachment #154024|0 |1 is obsolete|| --- Comment #182 from Katrin Fischer --- Created attachment 154273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154273=edit Bug 27378: (QA follow-up) Add cancel button to cookie modal This patch adds a cancel button to the modal for reviewing cookie consents. Previously there was no way to exit without selecting one of the cookie options Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Attachment #154023|0 |1 is obsolete|| --- Comment #181 from Katrin Fischer --- Created attachment 154272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154272=edit Bug 27378: (QA follow-up) Allow staff to view their cookie consents This patch allows staff to view their cookie consents through a link in the dropdown menu in the navbar. Previously staff had no way of accessing their cookie consents Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Attachment #154022|0 |1 is obsolete|| --- Comment #180 from Katrin Fischer --- Created attachment 154271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154271=edit Bug 27378: (QA follow-up) Small fixes and tidy-ups This patch does the following: - Realphabetizes the lines in sysprefs.sql - Fixes a formatting error in patrons.pref - Adjusts the position of the cookie consent bar if the language selector is visible - Fixes translatability on the syspref modal Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Attachment #154021|0 |1 is obsolete|| --- Comment #179 from Katrin Fischer --- Created attachment 154270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154270=edit Bug 27378: Remove two sysprefs and replace with html customisations Currently there are two sysprefs - CookieConsentBar and CookieConsentPopup. These allow the user to select what text they would like to see in the consent bar and modal. These have been removed and replaced with HTML customisations to allow more flexible customisations and different languages. Sponsored by: PTFS-Europe Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Attachment #154020|0 |1 is obsolete|| --- Comment #178 from Katrin Fischer --- Created attachment 154269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154269=edit Bug 27378: Stop the codemirror editor and delete confirmation from duplicating Previously, if the "Add new code button" was clicked in the CookieConsentedJS editor, the original entry would have duplicated CodeMirror editors. This was exponential, i.e adding two new lines would result in three codemirror editors appearing on the first entry, two on the second and so on. The click event was not being applied properly and was being applied to every element with the .expand-textarea class, rather than specifically the new elements being created. The addExpandHandler function now loops through each element individually and decides whether to apply the click event handler. Similarly, the delete confirmation was dupliacting for the same reason. This has also been resolved. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Attachment #154019|0 |1 is obsolete|| --- Comment #177 from Katrin Fischer --- Created attachment 154268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154268=edit Bug 27378: Change ConsentJS to CookieConsentedJS This patch updates the name of the ConsentJS syspref to CookieConsentedJS and amends the description to be more clear what the syspref is for Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Attachment #154018|0 |1 is obsolete|| --- Comment #176 from Katrin Fischer --- Created attachment 154267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154267=edit Bug 27378: Update to new atomicupdate structure This patch consolidates the previous 4 database update files into one atomicupdate file in line with the new structure Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Attachment #154017|0 |1 is obsolete|| --- Comment #175 from Katrin Fischer --- Created attachment 154266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154266=edit Bug 27378: Fix accessibility issues Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Attachment #154016|0 |1 is obsolete|| --- Comment #174 from Katrin Fischer --- Created attachment 154265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154265=edit Bug 27378: (follow-up) Add missing filters (cherry picked from commit 6b8565b949b62269f6d850e6d412458d0dbcfb37) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Attachment #154015|0 |1 is obsolete|| --- Comment #173 from Katrin Fischer --- Created attachment 154264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154264=edit Bug 27378: Introduce cookie consent to OPAC and staff client To avoid confusion around commit messages and the content of this enhancement, this first commit is a squashed commit of all the original code submited to this bug. Following a few years of inactivity, it has been rebased and re-submitted with some fixes and concept changes contained in the more recent commits. Signed-ff-by: Barry Cannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Keywords|rel_22_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #172 from Katrin Fischer --- Back for this one... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #171 from Matt Blenkinsop --- Created attachment 154093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154093=edit Bug 27378: (QA follow-up) Fix tests and character encoding This patch fixes an encoding issue when using diacritics. It also fixes a failing test, corrects the format of the "Cancel" links in the modal and perltidy has been used on all relevant files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #170 from Katrin Fischer --- 3) Cancel button in the modals should be a cancel link (not blocker) We usually have the design pattern that the submit is a button, but that the cancel is a link. 4) Cookie name or description with diacritics have OPAC and staff interface explode I had: Name: OPAC1ü Description: Description1ü Template process failed: undef error - malformed UTF-8 character in JSON string, at character offset 33 (before "\x{fffd}scription":"...") at /kohadevbox/koha/Koha/Template/Plugin/JSConsents.pm line 33. at /kohadevbox/koha/C4/Templates.pm line 127 I'll wait with further testing until this is fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #169 from Katrin Fischer --- Hi Matt, 1) Tests are not passing: prove t/db_dependent/Koha/Template/Plugin/JSConsents.t t/db_dependent/Koha/Template/Plugin/JSConsents.t .. 1/3 # No tests run! # Failed test 'No tests run for subtest "all"' # at t/db_dependent/Koha/Template/Plugin/JSConsents.t line 23. Not an ARRAY reference at /kohadevbox/koha/Koha/Template/Plugin/JSConsents.pm line 34. # Looks like your test exited with 255 just after 3. t/db_dependent/Koha/Template/Plugin/JSConsents.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/3 subtests 2) Please some more tidy on the new files: WARN installer/data/mysql/atomicupdate/bug_27378-add_cookie_consents.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 5) WARN t/db_dependent/Koha/Template/Plugin/JSConsents.t WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 2) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #153336|0 |1 is obsolete|| --- Comment #168 from Matt Blenkinsop --- Created attachment 154025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154025=edit Bug 27378: (QA follow-up) Add filtering for OPAC only and staff only cookies This patch fixes an issue where cookies selected as OPAC only would still show in the staff client and vise versa. The cookies are now filtered and only the correct cookies will be used in the OPAC and staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #153335|0 |1 is obsolete|| --- Comment #167 from Matt Blenkinsop --- Created attachment 154024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154024=edit Bug 27378: (QA follow-up) Add cancel button to cookie modal This patch adds a cancel button to the modal for reviewing cookie consents. Previously there was no way to exit without selecting one of the cookie options -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #153334|0 |1 is obsolete|| --- Comment #166 from Matt Blenkinsop --- Created attachment 154023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154023=edit Bug 27378: (QA follow-up) Allow staff to view their cookie consents This patch allows staff to view their cookie consents through a link in the dropdown menu in the navbar. Previously staff had no way of accessing their cookie consents -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #15|0 |1 is obsolete|| --- Comment #165 from Matt Blenkinsop --- Created attachment 154022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154022=edit Bug 27378: (QA follow-up) Small fixes and tidy-ups This patch does the following: - Realphabetizes the lines in sysprefs.sql - Fixes a formatting error in patrons.pref - Adjusts the position of the cookie consent bar if the language selector is visible - Fixes translatability on the syspref modal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #153332|0 |1 is obsolete|| --- Comment #164 from Matt Blenkinsop --- Created attachment 154021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154021=edit Bug 27378: Remove two sysprefs and replace with html customisations Currently there are two sysprefs - CookieConsentBar and CookieConsentPopup. These allow the user to select what text they would like to see in the consent bar and modal. These have been removed and replaced with HTML customisations to allow more flexible customisations and different languages. Sponsored by: PTFS-Europe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #153331|0 |1 is obsolete|| --- Comment #163 from Matt Blenkinsop --- Created attachment 154020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154020=edit Bug 27378: Stop the codemirror editor and delete confirmation from duplicating Previously, if the "Add new code button" was clicked in the CookieConsentedJS editor, the original entry would have duplicated CodeMirror editors. This was exponential, i.e adding two new lines would result in three codemirror editors appearing on the first entry, two on the second and so on. The click event was not being applied properly and was being applied to every element with the .expand-textarea class, rather than specifically the new elements being created. The addExpandHandler function now loops through each element individually and decides whether to apply the click event handler. Similarly, the delete confirmation was dupliacting for the same reason. This has also been resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #153330|0 |1 is obsolete|| --- Comment #162 from Matt Blenkinsop --- Created attachment 154019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154019=edit Bug 27378: Change ConsentJS to CookieConsentedJS This patch updates the name of the ConsentJS syspref to CookieConsentedJS and amends the description to be more clear what the syspref is for -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #153329|0 |1 is obsolete|| --- Comment #161 from Matt Blenkinsop --- Created attachment 154018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154018=edit Bug 27378: Update to new atomicupdate structure This patch consolidates the previous 4 database update files into one atomicupdate file in line with the new structure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #153328|0 |1 is obsolete|| --- Comment #160 from Matt Blenkinsop --- Created attachment 154017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154017=edit Bug 27378: Fix accessibility issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #153327|0 |1 is obsolete|| --- Comment #159 from Matt Blenkinsop --- Created attachment 154016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154016=edit Bug 27378: (follow-up) Add missing filters (cherry picked from commit 6b8565b949b62269f6d850e6d412458d0dbcfb37) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #153326|0 |1 is obsolete|| --- Comment #158 from Matt Blenkinsop --- Created attachment 154015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154015=edit Bug 27378: Introduce cookie consent to OPAC and staff client To avoid confusion around commit messages and the content of this enhancement, this first commit is a squashed commit of all the original code submited to this bug. Following a few years of inactivity, it has been rebased and re-submitted with some fixes and concept changes contained in the more recent commits. Signed-ff-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Martin Renvoize changed: What|Removed |Added Assignee|martin.renvoize@ptfs-europe |matt.blenkinsop@ptfs-europe |.com|.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #157 from Matt Blenkinsop --- (In reply to Katrin Fischer from comment #143) > Overall this is mostly small stuff, apart from 9) maybe! > > We'll also need some good documetnation, but the test plan in comment 121 is > a good start. > > 1) Perltidy > > Should we perltidy the new files at least? I've run perltidy for JSConsents.pm. > > 2) System preferences - sysprefs.sql > > sysprefs.sql is supposed to be alphabetic (being a librarian, this is not > acceptable! ;) ) Fixed :) > > ('ConfirmFutureHolds','0',... > +('CookieConsentedJS', '', NULL, 'Add ... > ('ConsiderOnSiteCheckoutsAsNormalCheckouts',... > ('ContentWarningField', '',... > +('CookieConsent', '0', NULL... > > 3) System preferences - YAML > > a) > + - pref: CookieConsent > + choices: > + yes: Require > + no: "Don't require" > + - cookie consent to be displayed > > Should be 1 and 0. (blocker) Fixed > Should we rephrase a bit? Re-written as per below > ... cookie consent to be displayed in the OPAC and staff interface. > > Question: Could it be interesting to make this OPAC only in the future? > > b) Add Javascript code that will run if cookie consent is provided (e.g. > tracking code). > > Should we rephrase this a little? Re-phrased as per below > Run the following JavaScript if cookie consent was provided (e.g. tracking > code): > > > 3) Add to cookie documentation please > > https://wiki.koha-community.org/wiki/Use_of_Cookies > > For OPAC and staff interface. Done > > 4) Translatability (blocker) > > ' href="#">Delete' + Fixed > > 5) Test plan and comments > > Giving that this is an old development there are quite some inconsistencies > in what is the final product and what is mentioned in the commit messages. > Like we started out with 4 prefs and now 2 are HTML customizations. Some > squashing and clean-up could be really helpful I think. > > But: great updated test plan in comment 121 ! I've squashed the original commits into one to remove the confusing messages. I've also consolidated the accessibility fixes into one commit and combined a couple of other similar commits to try and prevent duplication > > 6) Display issues > > a) In the OPAC, the cookie banner overlaps and blocks access to the language > selection at the bottom. If you have them at the top too, that's ok, but > some libraries prefer one over the other ( OpacLangSelectorMode = only > footer ). Fixed - it will now sit above the language selection when visible > > b) In the staff interface we have the language chooser in front, cutting off > a bit of the "Accept all cookies" button. Fixed as per above solution > > c) In the OPAC readability (font color and size) is good, but in the staff > interface it's much less readable. It currently just uses the default bootstrap class as in the rest of Koha, could this be a problem elsewhere? > > > 7) Patron account > > a) It doesn't appear to be possible to revoke the general cookie consent? Do you mean consent to all cookies including for example the session id? Giving this option could lead to issues with using Koha, we would probably need to be specific about which cookies this would delete > > b) The contrast on the yellow "Accept selected non-essential" cookies seems > bad (greyish font color on yellow background) It currently just uses the default bootstrap class as in the rest of Koha, could this be a problem elsewhere? > > c) Should the button read "View and update..."? > > d) I cannot close/cancel the modal without making a change. Clicking > outside, pressing ESC, nothing works. We shoudl have a "Cancel" link. This > is also true when using the "your cookies" link for a non-authenticated user. I've added a cancel button that now closes the modal > > > 8) Visibility OPAC/staff > > a) I checked one of the cookies for only OPAC and one only for staff > interface. I still see all 3 cookies in the pop-up in both OPAC and staff > after clearing local storage. > > b) This might be related: test2 is my "staff only" cookie. It's unchecked in > the view, but it still gets added every time I refresh any OPAC page. > Same for my "opac only" cookie: it's always added in staff interface on page > reload. For points A and B I've added some filtering into the call for the cookies code. This was missing previously so all cookies were being provided to both the OPAC and the staff client. This should now be fixed > > c) Where can staff view and alter their cookie consents? I've added a "My Consents" option under the user menu dropdown in the top right hand corner. This opens the modal and allows staff to review their consents Hopefully I've addressed everything, let me know if there are any further comments! -- You are receiving this mail because: You are watching all bug changes.
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151842|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151839|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151838|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151837|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151836|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151834|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151833|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151832|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151831|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151830|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151829|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151828|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151827|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151826|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151843|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #156 from Matt Blenkinsop --- Created attachment 153336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153336=edit Bug 27378: (QA follow-up) Add filtering for OPAC only and staff only cookies This patch fixes an issue where cookies selected as OPAC only would still show in the staff client and vise versa. The cookies are now filtered and only the correct cookies will be used in the OPAC and staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #155 from Matt Blenkinsop --- Created attachment 153335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153335=edit Bug 27378: (QA follow-up) Add cancel button to cookie modal This patch adds a cancel button to the modal for reviewing cookie consents. Previously there was no way to exit without selecting one of the cookie options -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #154 from Matt Blenkinsop --- Created attachment 153334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153334=edit Bug 27378: (QA follow-up) Allow staff to view their cookie consents This patch allows staff to view their cookie consents through a link in the dropdown menu in the navbar. Previously staff had no way of accessing their cookie consents -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #153 from Matt Blenkinsop --- Created attachment 15 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15=edit Bug 27378: (QA follow-up) Small fixes and tidy-ups This patch does the following: - Realphabetizes the lines in sysprefs.sql - Fixes a formatting error in patrons.pref - Adjusts the position of the cookie consent bar if the language selector is visible - Fixes translatability on the syspref modal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151844|0 |1 is obsolete|| --- Comment #152 from Matt Blenkinsop --- Created attachment 153332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153332=edit Bug 27378: Remove two sysprefs and replace with html customisations Currently there are two sysprefs - CookieConsentBar and CookieConsentPopup. These allow the user to select what text they would like to see in the consent bar and modal. These have been removed and replaced with HTML customisations to allow more flexible customisations and different languages. Sponsored by: PTFS-Europe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #151 from Matt Blenkinsop --- Created attachment 153331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153331=edit Bug 27378: Stop the codemirror editor and delete confirmation from duplicating Previously, if the "Add new code button" was clicked in the CookieConsentedJS editor, the original entry would have duplicated CodeMirror editors. This was exponential, i.e adding two new lines would result in three codemirror editors appearing on the first entry, two on the second and so on. The click event was not being applied properly and was being applied to every element with the .expand-textarea class, rather than specifically the new elements being created. The addExpandHandler function now loops through each element individually and decides whether to apply the click event handler. Similarly, the delete confirmation was dupliacting for the same reason. This has also been resolved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151841|0 |1 is obsolete|| --- Comment #150 from Matt Blenkinsop --- Created attachment 153330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153330=edit Bug 27378: Change ConsentJS to CookieConsentedJS This patch updates the name of the ConsentJS syspref to CookieConsentedJS and amends the description to be more clear what the syspref is for -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151840|0 |1 is obsolete|| --- Comment #149 from Matt Blenkinsop --- Created attachment 153329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153329=edit Bug 27378: Update to new atomicupdate structure This patch consolidates the previous 4 database update files into one atomicupdate file in line with the new structure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #148 from Matt Blenkinsop --- Created attachment 153328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153328=edit Bug 27378: Fix accessibility issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Matt Blenkinsop changed: What|Removed |Added Attachment #151835|0 |1 is obsolete|| --- Comment #147 from Matt Blenkinsop --- Created attachment 153327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153327=edit Bug 27378: (follow-up) Add missing filters (cherry picked from commit 6b8565b949b62269f6d850e6d412458d0dbcfb37) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #146 from Matt Blenkinsop --- Created attachment 153326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153326=edit Bug 27378: Introduce cookie consent to OPAC and staff client To avoid confusion around commit messages and the content of this enhancement, this first commit is a squashed commit of all the original code submited to this bug. Following a few years of inactivity, it has been rebased and re-submitted with some fixes and concept changes contained in the more recent commits. Signed-ff-by: Barry Cannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #145 from Katrin Fischer --- Just a note: JavaScript code from the test plan needs to have its quotes fixed in order to work: (function() { console.log('Hello from test1'); document.cookie = "test1=testing; domain=localhost; path=/; SameSite=None; Secure"; })(); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added CC||m...@software.coop --- Comment #144 from Katrin Fischer --- *** Bug 8155 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #143 from Katrin Fischer --- Overall this is mostly small stuff, apart from 9) maybe! We'll also need some good documetnation, but the test plan in comment 121 is a good start. 1) Perltidy Should we perltidy the new files at least? 2) System preferences - sysprefs.sql sysprefs.sql is supposed to be alphabetic (being a librarian, this is not acceptable! ;) ) ('ConfirmFutureHolds','0',... +('CookieConsentedJS', '', NULL, 'Add ... ('ConsiderOnSiteCheckoutsAsNormalCheckouts',... ('ContentWarningField', '',... +('CookieConsent', '0', NULL... 3) System preferences - YAML a) + - pref: CookieConsent + choices: + yes: Require + no: "Don't require" + - cookie consent to be displayed Should be 1 and 0. (blocker) Should we rephrase a bit? ... cookie consent to be displayed in the OPAC and staff interface. Question: Could it be interesting to make this OPAC only in the future? b) Add Javascript code that will run if cookie consent is provided (e.g. tracking code). Should we rephrase this a little? Run the following JavaScript if cookie consent was provided (e.g. tracking code): 3) Add to cookie documentation please https://wiki.koha-community.org/wiki/Use_of_Cookies For OPAC and staff interface. 4) Translatability (blocker) 'Delete' + 5) Test plan and comments Giving that this is an old development there are quite some inconsistencies in what is the final product and what is mentioned in the commit messages. Like we started out with 4 prefs and now 2 are HTML customizations. Some squashing and clean-up could be really helpful I think. But: great updated test plan in comment 121 ! 6) Display issues a) In the OPAC, the cookie banner overlaps and blocks access to the language selection at the bottom. If you have them at the top too, that's ok, but some libraries prefer one over the other ( OpacLangSelectorMode = only footer ). b) In the staff interface we have the language chooser in front, cutting off a bit of the "Accept all cookies" button. c) In the OPAC readability (font color and size) is good, but in the staff interface it's much less readable. 7) Patron account a) It doesn't appear to be possible to revoke the general cookie consent? b) The contrast on the yellow "Accept selected non-essential" cookies seems bad (greyish font color on yellow background) c) Should the button read "View and update..."? d) I cannot close/cancel the modal without making a change. Clicking outside, pressing ESC, nothing works. We shoudl have a "Cancel" link. This is also true when using the "your cookies" link for a non-authenticated user. 8) Visibility OPAC/staff a) I checked one of the cookies for only OPAC and one only for staff interface. I still see all 3 cookies in the pop-up in both OPAC and staff after clearing local storage. b) This might be related: test2 is my "staff only" cookie. It's unchecked in the view, but it still gets added every time I refresh any OPAC page. Same for my "opac only" cookie: it's always added in staff interface on page reload. c) Where can staff view and alter their cookie consents? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 --- Comment #142 from Katrin Fischer --- Giving this another go... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau changed: What|Removed |Added Attachment #151753|0 |1 is obsolete|| --- Comment #141 from Sam Lau --- Created attachment 151844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151844=edit Bug 27378: Remove two sysprefs and replace with html customisations Currently there are two sysprefs - CookieConsentBar and CookieConsentPopup. These allow the user to select what text they would like to see in the consent bar and modal. These have been removed and replaced with HTML customisations to allow more flexible customisations and different languages. Sponsored by: PTFS-Europe Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau changed: What|Removed |Added Attachment #151752|0 |1 is obsolete|| --- Comment #140 from Sam Lau --- Created attachment 151843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151843=edit Bug 27378: Prevent delete confirmation from duplicating Previously, if the "Add new code" button was clicked multipe times in the CookieConsentedJS editor and then those new items were deleted, the confirmation alert would show multiple times. This was an incremental issue, i.e. if 4 new items were deleted, then the first of those would require 4 confirmations to delete, the second would require 3 and so on. This is now prevented by looping through all delete buttons and avoiding duplicating the event listeners Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau changed: What|Removed |Added Attachment #151751|0 |1 is obsolete|| --- Comment #139 from Sam Lau --- Created attachment 151842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151842=edit Bug 27378: Stop the codemirror editor from duplicating Previously, if the "Add new code button" was clicked in the CookieConsentedJS editor, the original entry would have duplicated CodeMirror editors. This was exponential, i.e adding two new lines would result in three codemirror editors appearing on the first entry, two on the second and so on. The click event was not being applied properly and was being applied to every element with the .expand-textarea class, rather than specifically the new elements being created. The addExpandHandler function now loops through each element individually and decides whether to apply the click event handler. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau changed: What|Removed |Added Attachment #151750|0 |1 is obsolete|| --- Comment #138 from Sam Lau --- Created attachment 151841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151841=edit Bug 27378: Change ConsentJS to CookieConsentedJS This patch updates the name of the ConsentJS syspref to CookieConsentedJS and amends the description to be more clear what the syspref is for Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau changed: What|Removed |Added Attachment #151749|0 |1 is obsolete|| --- Comment #137 from Sam Lau --- Created attachment 151840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151840=edit Bug 27378: Update to new atomicupdate structure This patch consolidates the previous 4 database update files into one atomicupdate file in line with the new structure Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau changed: What|Removed |Added Attachment #151748|0 |1 is obsolete|| --- Comment #136 from Sam Lau --- Created attachment 151839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151839=edit Bug 27378: Add aria-label to more information button This patch adds an aria-label to the More Information button in order to comply with WCAG Accessibility guidelines Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau changed: What|Removed |Added Attachment #151747|0 |1 is obsolete|| --- Comment #135 from Sam Lau --- Created attachment 151838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151838=edit Bug 27378: Add missing aria-labels The checkboxes on the cookie consent modal were failing accessibility testing for not being labelled. This patch adds aria-labels to the checkboxes to satisfy the accessibility requirements Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau changed: What|Removed |Added Attachment #151746|0 |1 is obsolete|| --- Comment #134 from Sam Lau --- Created attachment 151837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151837=edit Bug 27378: Fix missing bootstrap button classes This patch restores the background colour to buttons in the intranet where bootstrap classes were being overidden with a default of #fff. The colour of the the "More Information" button in the cookies bar and the "Accept selected non-essential cookies" button in the cookies modal have been changed slightly to comply with accessibility colour contrasts. Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau changed: What|Removed |Added Attachment #151745|0 |1 is obsolete|| --- Comment #133 from Sam Lau --- Created attachment 151836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151836=edit Bug 27378: Fix heading structure of opac-patron-consent The current heading structure of opac-patron-consent.tt jumps straight from an h1 to an h5 for cookie consents. This has been changed to an h2 with scss updates to maintain formatting Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27378] Enable compliance with EU Cookie Legislation via cookie consent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 Sam Lau changed: What|Removed |Added Attachment #151744|0 |1 is obsolete|| --- Comment #132 from Sam Lau --- Created attachment 151835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151835=edit Bug 27378: (follow-up) Add missing filters (cherry picked from commit 6b8565b949b62269f6d850e6d412458d0dbcfb37) Signed-off-by: Sam Lau -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/